profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ericdallo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Eric Dallo ericdallo @nubank São Paulo, Brazil https://ericdallo.dev Emacs fanatic, NixOS enthusiast, maintainer of emacs-lsp, lsp-dart and clojure-lsp https://www.patreon.com/ericdallo

emacs-lsp/lsp-ui 815

UI integrations for lsp-mode

clojure-lsp/clojure-lsp 665

Language Server (LSP) for Clojure

emacs-lsp/lsp-java 484

lsp-mode :heart: java

emacs-lsp/lsp-dart 113

lsp-mode :heart: dart

clj-kondo/lein-clj-kondo 5

Leiningen plugin to run clj-kondo

ericdallo/bctrader 1

Bitcoin bot trader

douglascampos/RubyOnRails 0

Projeto para aprendizado da framework Rails usando linguagem Ruby

ericdallo/alda 0

A music programming language for musicians. :notes:

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 4b4115688ffc9e636ccd4332fc98979095d23a36

[CHANGELOG]

view details

push time in 4 hours

issue closedclojure-lsp/clojure-lsp

Read cljfmt settings from a file

Is your feature request related to a problem? Please describe. Calva use cljfmt for formatting. It also uses clojure-lsp for as the lsp client. clojure-lsp also uses cljfmt for its formatting actions. As it stands, it is possible for Calva to format differently from how clojure-lsp would format it. This could lead to false negatives when running clojure-lsp format checking on the CI.

Describe the solution you'd like cljfmt doesn't have a preferred file path for its config. So there is no established convention for cljfmt standalone config. Calva in its config accepts a filepath for cljfmt settings calva.fmt.configPath.

clojure-lsp could also support reading the cljfmt settings from a file path. We could use a config key like :cljfmt-config-path. And its value would be a string containing the path to the cljfmt config file, the same one used for Calva.

Describe alternatives you've considered Since Calva embeds/uses clojure-lsp, it could potentially read the cljfmt config from clojure-lsp's config file .lsp/config.edn. It however creates a coupling between the two, and not very maintainable.

Additional context N/A

closed time in 4 hours

amithgeorge

issue commentclojure-lsp/clojure-lsp

Read cljfmt settings from a file

Done, available on new release, added a new :cljfmt-config-path setting with a default value of .cljfmt.edn.

@PEZ this setting is already available on the both serverInfo and serverInfoRaw custom methods that Calva already uses, so Calva can now check use the file provided from the return of that method if no file was provided by the user :)

amithgeorge

comment created time in 4 hours

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 5b5e7394c953633efcc1f7220ee3bae7d6f10297

Check for a default `.cljfmt.edn` config file for cljfmt config settings if no `:cljfmt-config-path` was provided.

view details

push time in 4 hours

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 21c41afd3125a8fc3ee1ecaff2b8e8be2b2f8b0d

Deprecate `:lens-segregate-test-references` in favor of `:code-lens` `:segregate-test-references`

view details

push time in 8 hours

issue commentclojure-lsp/clojure-lsp

emacs: blacklisted home directory, all sub directories believed to be blacklisted

oh, sorry, I think what you want is lsp-workspace-blacklist-remove

cloudbuck3t

comment created time in 8 hours

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha d0ae5591b33a9073f7dce4b377913dafe91f50ad

[docs] Update issue template

view details

push time in 8 hours

issue closedclojure-lsp/clojure-lsp

emacs: blacklisted home directory, all sub directories believed to be blacklisted

Hi, how can I un-blacklist directories in clojure-lsp? I blacklisted an upstream folder ~/ and this is interpreted as blacklisting all subfolders...
How can I revise this? I'm unable to find it in the docs. (emacs)

closed time in 8 hours

cloudbuck3t

issue commentclojure-lsp/clojure-lsp

emacs: blacklisted home directory, all sub directories believed to be blacklisted

lsp-workspace-folders-remove should work for you

cloudbuck3t

comment created time in 8 hours

issue commentBetterThanTomorrow/calva

Navigate between files using namespace names

@bpringe I just added the support for clicking on references code lens for emacs/lsp-mode here, Unfortunately, it's something that must be done for every client, handle that command and show call the references from the command args. I suggest you create a new issue on Calva to add that support

markaddleman

comment created time in 9 hours

CommitCommentEvent

PR opened emacs-lsp/lsp-mode

[clojure] Handle reference code lens for lsp-clojure

This should add support for "click" on the reference code lens showing them.

+17 -1

0 comment

1 changed file

pr created time in 9 hours

create barnchemacs-lsp/lsp-mode

branch : clojure-action-code-lens-handler

created branch time in 9 hours

issue commentclj-kondo/clj-kondo

Clojure LSP's Goto Definition/Show Documentation/et. issue in ClojureScript and namespace aliases (or macros??)

ATM clojure-lsp uses this logica order you described (just not checking clj for cljs files), I think if clj-kondo always provides something that says which langs are available would be great, I mean, there are some analysis contains :lang but there are others that doesn't, that's why clojure-lsp also checks the :filename extension if no :lang here: https://github.com/clojure-lsp/clojure-lsp/blob/master/src/clojure_lsp/queries.clj#L43-L49

stevenproctor

comment created time in 10 hours

issue commentclj-kondo/clj-kondo

Clojure LSP's Goto Definition/Show Documentation/et. issue in ClojureScript and namespace aliases (or macros??)

Oh got it the top-ns, I see, so IMO we should tag with some key that would say where this analysis makes sense. for example if the analysis has a :available-langs #{:cljc :cljs}, that means that that analysis element can be used on analysis for clj + cljs files

stevenproctor

comment created time in 10 hours

issue commentclj-kondo/clj-kondo

Clojure LSP's Goto Definition/Show Documentation/et. issue in ClojureScript and namespace aliases (or macros??)

@borkdude I'll take a look at that branch, what's the difference between :ns and :top-ns? Also, it's not clear to me, clojure-lsp should check both :lang and :cljc?

stevenproctor

comment created time in 11 hours

push eventericdallo/nixpkgs

Eric Dallo

commit sha ff7905256c42067aa89714afd873fae25b6965a1

clojure-lsp: 2021.09.04-17.11.44 -> 2021.09.13-22.25.35

view details

push time in 13 hours

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 79dd68d5b610678f66f65caf26e06d5cfc2fa495

[CHANGELOG]

view details

push time in 16 hours

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 28161476d125b08b5c43b14f44248333b600f61b

Keep comments on sorting (#567)

view details

push time in 16 hours

delete branch clojure-lsp/clojure-lsp

delete branch : keep-comments-on-sorting

delete time in 16 hours

PR merged clojure-lsp/clojure-lsp

Keep comments on sorting

Fixes #559

+68 -16

0 comment

2 changed files

ericdallo

pr closed time in 16 hours

issue closedclojure-lsp/clojure-lsp

`clean-ns` drops comments from ns form

Describe the bug Sorting the ns form does not preserve comments

To Reproduce

(ns foo
  (:require [clojure.set :as set] ;; important comment
            [clojure.edn :as edn]))

Sort-ns command yields

(ns foo
  (:require
   [clojure.edn :as edn]
   [clojure.set :as set]))

Expected behavior The comment is added on purpose and should be preserved

Screenshots

Before

image

After

image

closed time in 16 hours

dpsutton

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 49e254c4e0a300bd7ad950fe2988518db713b4a2

Keep comments on sorting

view details

push time in 16 hours

issue commentclj-kondo/clj-kondo

Clojure LSP's Goto Definition/Show Documentation/et. issue in ClojureScript and namespace aliases (or macros??)

yeah, I think having :available-langs for those cases would help, something that tells that this analysis should work for those langs, WDYT?

stevenproctor

comment created time in 16 hours

issue commentclojure-lsp/clojure-lsp

Report as unused public var if the function was self referred only

I see, some of them like deprecated and macro seems a good idea to me keep it as clojure-lsp adds different colors when checking those attrs, and avoid the need to find the definition for those cases seems a performance improvement to me, but others like arity ones seem not useful. We actually need to check if it's a good tradeoff remove those fields to have less data and when we need that data we find the definition and check if worth it

ericdallo

comment created time in 16 hours

issue commentclj-kondo/clj-kondo

Clojure LSP's Goto Definition/Show Documentation/et. issue in ClojureScript and namespace aliases (or macros??)

@borkdude so you think clojure-lsp should match the file lang unless it's a macro always?

stevenproctor

comment created time in 17 hours

issue commentclojure-lsp/clojure-lsp

`clean-ns` drops comments from ns form

Hey @dpsutton it was not easy but I made it work for your case and probably the most cases, it's not perfect, I need to improve the code yet, but I'd love to hear from you if it helps, do you think you can test with the clojure-lsp from this branch? https://github.com/clojure-lsp/clojure-lsp/pull/567

You can just run make on the project and it should generate a clojure-lsp binary on the project root

dpsutton

comment created time in a day

push eventclojure-lsp/clojure-lsp

Eric Dallo

commit sha 80e46d09c6c5590169bf52c6165d30c99ca640d4

Keep comments on sorting

view details

push time in a day

create barnchclojure-lsp/clojure-lsp

branch : keep-comments-on-sorting

created branch time in a day