Coerce gets called multiple times for nested command positional, this could cause issues when the arg type is converted.

Example Script:

import yargs from 'yargs'

const argv = yargs('rule add foo bar baz').showHelpOnFail(false).fail(msg => {
  console.error(`[ERR] ${msg}`)
  process.exit(1)
}).command('rule', '', yargs => {
  return yargs.command('add <name> <desc...>', '', yargs => {
    return yargs.positional('desc', {
      type: 'string',
      coerce: arg => {
        console.log(arg)

        return arg.join(' ')
      }
    })
  })
}).argv

// the parsed data is stored in argv.
console.log(argv)

Expected Output:

[ 'bar', 'baz' ]
{ _: [ 'rule', 'add' ], '$0': 't.js', name: 'foo', desc: 'bar baz' }

Actual Output:

[ 'bar', 'baz' ]
bar baz
[ERR] arg.join is not a function

@bcoe just a tiny reminder

This seems to be a pretty common issue, if you look at the replies of #1953. Is there anything wrong with the changes?

Thanks! This was driving me crazy. I have several Typescript projects using yargs. Some were suddenly throwing new errors with argv properties like noted in this issue. Others were still fine. I even tried putting some of the problematic modules into a directory where modules were not having problems and they were fine there. Finally discovered the "good' directories were still on yargs 16.2.0 as I somehow forgot to upgrade them and npm was reporting otherwise. When I upgraded them to 17.0.1, they started throwing errors too. I found this issue here and parseSync() solved the problem.

@jeff-hykin - simpler but still too convoluted, IMO. I am thinking like this: If it is that complex to use, few will use it and the value of the development will be too low to motivate actually doing it...

@chipbite I mean, this is my first time trying to use yargs. If I didn't find a solution, I would have thrown out yargs and manually parsed the arguments to get ideal/dynamic defaults, like I've done on my past projects.

I'm not trying to motivate anyone to use dynamic defaults, just trying to make it easier for devs to implement dynamic defaults, so they can avoid manually parsing args.

My workaround (in the application) is to add a doingCompletion flag

import yargs from 'yargs';
import { hideBin } from 'yargs/helpers';

const doingCompletion = (process.argv[2] === '--get-yargs-completions')

yargs(hideBin(process.argv))
  .usage('$0 [options] [command]')
  .completion('completion')
  .command('hello', 'Say Hello', () => {
    if (doingCompletion) return
    console.log('EXECUTING HELLO')
  })
  .argv;

I'm looking to selectively override the version bumping logic with my own, but in order to do so I'd have to recreate all of the option-parsing for locating the correct packageFiles/git tags and reading the current version if I were to do it in the prebump lifecycle script. My problem would be mostly solved if I could read the existing version as a shell argument.

I'm now realizing that I can't override version bumping logic with prebump scripts as the bump lifecycle script only uses it to determine what the initial version should be before performing the bump. I'm closing this since I think I don't see a straightforward way to customize version bumping behavior using this library.

Describe the bug npm i got unfixable issue https://www.npmjs.com/advisories/1753

Current behavior A clear and concise description of the behavior.

Expected behavior A clear and concise description of what you expected to happen.

Environment

• standard-version version(s): [e.g. v6.0.0, v8.0.0, master]
• Node/npm version: [e.g. Node 10/npm 6]
• OS: [e.g. OSX 10.13.4, Windows 10]

Possible Solution <!--- If you have suggestions on a fix for the bug -->

Additional context Add any other context about the problem here. Or a screenshot if applicable

I'm looking to selectively override the version bumping logic with my own, but in order to do so I'd have to recreate all of the option-parsing for locating the correct packageFiles/git tags and reading the current version if I were to do it in the prebump lifecycle script. My problem would be mostly solved if I could read the existing version as a shell argument.

When I press TAB on an already-complete command (without pressing ENTER), the command actually runs.

Here's a bug.js to show the failure:

import yargs from 'yargs';
import { hideBin } from 'yargs/helpers';

yargs(hideBin(process.argv))
  .usage('$0 [options] [command]')
  .completion('completion')
  .command('hello', 'Say Hello', () => console.log('EXECUTING HELLO'))
  .argv;

$ node bug.js --get-yargs-completions hell
completion
hello
$ # that was correct
$ node bug.js --get-yargs-completions hello
EXECUTING HELLO
$ # WHAT?!?!

Any updates please?

Bumps django from 1.4 to 1.11.29. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/django/django/commit/f1e3017aeaeddc590dcf2cf88511f3a726da73ca"><code>f1e3017</code></a> [1.11.x] Bumped version for 1.11.29 release.</li> <li><a href="https://github.com/django/django/commit/02d97f3c9a88adc890047996e5606180bd1c6166"><code>02d97f3</code></a> [1.11.x] Fixed CVE-2020-9402 -- Properly escaped tolerance parameter in GIS f...</li> <li><a href="https://github.com/django/django/commit/e6438335626cb7e662dd015485a23cfc5721ad72"><code>e643833</code></a> [1.11.x] Pinned PyYAML < 5.3 in test requirements.</li> <li><a href="https://github.com/django/django/commit/d0e3eb8e827355462a2d90660079234796d94ab0"><code>d0e3eb8</code></a> [1.11.x] Added CVE-2020-7471 to security archive.</li> <li><a href="https://github.com/django/django/commit/9a62ed5d5f827b44e8c95559c60fb28fb444e3ad"><code>9a62ed5</code></a> [1.11.x] Post-release version bump.</li> <li><a href="https://github.com/django/django/commit/e09f09b965ef47ffd99abd2c26ba7416751cffa6"><code>e09f09b</code></a> [1.11.x] Bumped version for 1.11.28 release.</li> <li><a href="https://github.com/django/django/commit/001b0634cd309e372edb6d7d95d083d02b8e37bd"><code>001b063</code></a> [1.11.x] Fixed CVE-2020-7471 -- Properly escaped StringAgg(delimiter) parameter.</li> <li><a href="https://github.com/django/django/commit/7fd1ca3ef63e5e834205a8208f4dc17d80f9a417"><code>7fd1ca3</code></a> [1.11.x] Fixed timezones tests for PyYAML 5.3+.</li> <li><a href="https://github.com/django/django/commit/121115d2c291b3969ac00ca62253f23513481739"><code>121115d</code></a> [1.11.x] Added CVE-2019-19844 to the security archive.</li> <li><a href="https://github.com/django/django/commit/2c4fb9a35db575ec56207446d782b8f450a2b4e7"><code>2c4fb9a</code></a> [1.11.x] Post-release version bump.</li> <li>Additional commits viewable in <a href="https://github.com/django/django/compare/1.4...1.11.29">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Superseded by #4.

Bumps django from 1.4 to 2.2.24. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/django/django/commit/2da029d8540ab0b2e9edcba25c4d46c52853197f"><code>2da029d</code></a> [2.2.x] Bumped version for 2.2.24 release.</li> <li><a href="https://github.com/django/django/commit/f27c38ab5d90f68c9dd60cabef248a570c0be8fc"><code>f27c38a</code></a> [2.2.x] Fixed CVE-2021-33571 -- Prevented leading zeros in IPv4 addresses.</li> <li><a href="https://github.com/django/django/commit/053cc9534d174dc89daba36724ed2dcb36755b90"><code>053cc95</code></a> [2.2.x] Fixed CVE-2021-33203 -- Fixed potential path-traversal via admindocs'...</li> <li><a href="https://github.com/django/django/commit/6229d8794ff7d3f471e29811857d72e67f24b608"><code>6229d87</code></a> [2.2.x] Confirmed release date for Django 2.2.24.</li> <li><a href="https://github.com/django/django/commit/f163ad5c638f79d3fd0e76bed0e15e6928fae1f5"><code>f163ad5</code></a> [2.2.x] Added stub release notes and date for Django 2.2.24.</li> <li><a href="https://github.com/django/django/commit/bed1755bc596b8c83351471e4276386b2e6643c0"><code>bed1755</code></a> [2.2.x] Changed IRC references to Libera.Chat.</li> <li><a href="https://github.com/django/django/commit/63f0d7a0f6b6d762b8c15894c531b687ac843c66"><code>63f0d7a</code></a> [2.2.x] Refs <a href="https://github-redirect.dependabot.com/django/django/issues/32718">#32718</a> -- Fixed file_storage.test_generate_filename and model_fi...</li> <li><a href="https://github.com/django/django/commit/5fe4970bd0b64a24ed6f9f18db3d4a80b5ac0a78"><code>5fe4970</code></a> [2.2.x] Post-release version bump.</li> <li><a href="https://github.com/django/django/commit/61f814f9fab554d10f1e2c193bcf3a5c56c4e9ef"><code>61f814f</code></a> [2.2.x] Bumped version for 2.2.23 release.</li> <li><a href="https://github.com/django/django/commit/b8ecb0643619a0650a4447b282478ce5257856e2"><code>b8ecb06</code></a> [2.2.x] Fixed <a href="https://github-redirect.dependabot.com/django/django/issues/32718">#32718</a> -- Relaxed file name validation in FileField.</li> <li>Additional commits viewable in <a href="https://github.com/django/django/compare/1.4...2.2.24">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>