profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/duglin/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

cloudevents/spec 2518

CloudEvents Specification

docker/docker-credential-helpers 616

Programs to keep Docker login credentials safe by storing in platform keystores

docker/go-connections 146

Utility package to work with network connections

docker/go-units 121

Parse and print size and time units in human-readable format

cloudviz/agentless-system-crawler 105

A tool to crawl systems like crawlers for the web

cloudevents/cloudevents-web 10

Source files for the website

brahmaroutu/docker-broker 5

Cloud Foundry Service Broker Using Docker

duglin/1password-teams-open-source 0

Get a free 1Password Teams membership for your open source project

pull request commentknative/serving

Do not call GetIngressEndpoint() when --resolvabledomain is enabled

Codecov Report

Merging #11318 (3275f0b) into main (d30f0bd) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11318      +/-   ##
==========================================
- Coverage   87.74%   87.72%   -0.03%     
==========================================
  Files         191      191              
  Lines        9211     9211              
==========================================
- Hits         8082     8080       -2     
- Misses        876      878       +2     
  Partials      253      253              
Impacted Files Coverage Δ
pkg/autoscaler/scaling/multiscaler.go 87.61% <0.00%> (-1.77%) :arrow_down:
pkg/autoscaler/statforwarder/leases.go 76.97% <0.00%> (-1.44%) :arrow_down:
pkg/reconciler/configuration/configuration.go 88.28% <0.00%> (+1.56%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d30f0bd...3275f0b. Read the comment docs.

nak3

comment created time in 33 minutes

pull request commentknative/serving

Do not call GetIngressEndpoint() when --resolvabledomain is enabled

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["nak3"]} -->

nak3

comment created time in 37 minutes

PR opened knative/serving

Do not call GetIngressEndpoint() when --resolvabledomain is enabled

GetIngressEndpoint() is a function to get ingress endpoint for the spoof client. So we don't need to call it when --resolvabledomain is enabled. Especially when Ingresss service uses ClusterIP, it alwasy fails to get endpoint and test fails.

This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test.

+7 -7

0 comment

1 changed file

pr created time in 38 minutes

PR opened cncf/toc

Added Turkish option to definition

Added Turkish option

+9 -1

0 comment

1 changed file

pr created time in 2 hours

Pull request review commentknative/eventing

Fix error text

 func (h *Handler) writeResponse(ctx context.Context, writer http.ResponseWriter, 			// Note that we could just use StatusInternalServerError, but to distinguish 			// between the failure cases, we use a different code here. 			writer.WriteHeader(http.StatusBadGateway)-			return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be or empty or a valid CloudEvent")+			return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be empty or a valid CloudEvent")

I think this was the original intention:

			return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be either empty or a valid CloudEvent")
naiduv

comment created time in 5 hours

pull request commentknative/eventing

Fix error text

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign slinkydeveloper after the PR has been reviewed. You can assign the PR to them by writing /assign @slinkydeveloper in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["slinkydeveloper"]} -->

naiduv

comment created time in 7 hours

pull request commentknative/eventing

Fix error text

Hi @naiduv. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

naiduv

comment created time in 7 hours

pull request commentknative/eventing

Fix error text

Welcome @naiduv! It looks like this is your first PR to knative/eventing 🎉

naiduv

comment created time in 7 hours

pull request commentknative/eventing

Fix error text

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

<!-- need_sender_cla -->

naiduv

comment created time in 7 hours

PR opened knative/eventing

Fix error text
+1 -1

0 comment

1 changed file

pr created time in 7 hours

issue commentknative/serving

Digest resolution not working?

Ah, I see. I think this may be working as intended: the local ksvc yaml is unchanged so the client didn't do anything (it does not check the digest, it only checks if the image name changed). There's a cli issue discussing changing this in https://github.com/knative/client/issues/398.

@rhuss may be able to share the best cli workflow to handle this case

/assign @rhuss

xclud

comment created time in 12 hours

issue commentknative/serving

Digest resolution not working?

E0508 11:11:28.225062      16 aws_credentials.go:77] while getting AWS credentials NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
INFO[0006] Retrieving image manifest nginx:stable-alpine 
INFO[0006] Retrieving image nginx:stable-alpine from registry index.docker.io 
INFO[0009] Built cross stage deps: map[]                
INFO[0009] Retrieving image manifest nginx:stable-alpine 
INFO[0009] Returning cached image manifest              
INFO[0009] Executing 0 build triggers                   
INFO[0009] Unpacking rootfs as cmd COPY ./web /usr/share/nginx/html requires it. 
INFO[0013] COPY ./web /usr/share/nginx/html             
INFO[0013] Taking snapshot of files...                  
INFO[0014] Pushing image to 
INFO[0014] Pushed image to 1 destinations  

Step completed
No changes to apply to service 'develop'.
Service 'develop' with latest revision 'develop-00003' (unchanged) is available at URL:
http://develop.sun-frontend...

Step completed
xclud

comment created time in 12 hours

issue commentknative/serving

Digest resolution not working?

@julz Thanks for the quick response. Yes the deployment is successful. Image is pushed successfully and kn works but it does not create a new Revision (due to the unchanged docker image !!!!?).

I am expecting revision 00004 but it remains on 00003.

Name:         develop
Namespace:    sun-frontend
Labels:       <none>
Annotations:  serving.knative.dev/creator: kubernetes-admin
              serving.knative.dev/lastModifier: kubernetes-admin
API Version:  serving.knative.dev/v1
Kind:         Service
Metadata:
  Creation Timestamp:  2021-05-06T05:56:23Z
  Generation:          3
  Managed Fields:
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:address:
          .:
          f:url:
        f:conditions:
        f:latestCreatedRevisionName:
        f:latestReadyRevisionName:
        f:observedGeneration:
        f:traffic:
        f:url:
    Manager:      controller
    Operation:    Update
    Time:         2021-05-06T05:56:30Z
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:template:
          .:
          f:metadata:
            .:
            f:annotations:
              .:
              f:client.knative.dev/user-image:
            f:creationTimestamp:
          f:spec:
            .:
            f:containers:
    Manager:         kn
    Operation:       Update
    Time:            2021-05-06T11:50:09Z
  Resource Version:  16009570
  UID:               440d25b8-1106-49c3-a038-0477002f5ba0
Spec:
  Template:
    Metadata:
      Annotations:
        client.knative.dev/user-image:  docker.domainname.tld/pna/sun-frontend
      Creation Timestamp:               <nil>
    Spec:
      Container Concurrency:  0
      Containers:
        Image:  docker.domainname.tld/pna/sun-frontend
        Name:   user-container
        Ports:
          Container Port:  80
        Readiness Probe:
          Success Threshold:  1
          Tcp Socket:
            Port:  0
        Resources:
      Enable Service Links:  false
      Timeout Seconds:       300
  Traffic:
    Latest Revision:  true
    Percent:          100
Status:
  Address:
    URL:  http://develop.sun-frontend.svc.cluster.local
  Conditions:
    Last Transition Time:        2021-05-06T11:50:27Z
    Status:                      True
    Type:                        ConfigurationsReady
    Last Transition Time:        2021-05-06T11:50:28Z
    Status:                      True
    Type:                        Ready
    Last Transition Time:        2021-05-06T11:50:28Z
    Status:                      True
    Type:                        RoutesReady
  Latest Created Revision Name:  develop-00003
  Latest Ready Revision Name:    develop-00003
  Observed Generation:           3
  Traffic:
    Latest Revision:  true
    Percent:          100
    Revision Name:    develop-00003
  URL:                http://develop.sun-frontend.alpha.domainname.tld
Events:               <none>

xclud

comment created time in 12 hours

issue commentknative/serving

Digest resolution not working?

Hi @xclud - I may be misunderstanding, but the message above sounds like the deploy succeeded, did you mean to say "doesn't resolve"? Could you post the full cli invocation and response (the whole thing, not just the last line), and also the output of "kubectl describe ksvc develop" please? It would also be helpful to know the knative version you are using.

Thanks!

xclud

comment created time in 13 hours

issue openedknative/serving

Digest resolution not working?

/area build

I am using knative-serving along with tekton and kaniko. In a multi step Task my image is getting built and pushed to a private registry (yes, it supports api version 2) using kaniko. Then the next step runs a kn command to create a new Revision for the KService.

Unfortunately in the last step kn does resolve the digest and logs Service 'develop' with latest revision 'develop-00003' (unchanged) is available at URL:. However, when I run docker pull ... in the node CLI, kn creates a new revision (if triggered).

I have read this doc https://knative.dev/docs/serving/tag-resolution/ and i am sure i did not enable the digest resolution skipping.

I appreciate if you shed some light on this. Or have i just found a bug?

created time in 14 hours

issue commentknative/serving

[flaky] test/conformance/api/v1.TestRouteCreation

Reopening issue: this test is flaky

knative-test-reporter-robot

comment created time in 14 hours

IssuesEvent

issue commentknative/serving

[flaky] test/e2e/initscale.TestInitScaleZero

Latest result for this test: Flaky Last build start time: 2021-05-08 08:00:29 +0000 UTC Failed 1 times out of 10 runs. Failed runs: 1390758452745211904 <!------Latest History of Up To 10 runs------> 2021-05-08 08:00:29 +0000 UTC: <!------End of History------> ✔ Passed ✖ Failed ◻ Skipped

<!--[DONT_MODIFY_TEST_IDENTIFIER]'test/e2e/initscale.TestInitScaleZero' in repo 'serving'[DONT_MODIFY_TEST_IDENTIFIER]-->

knative-test-reporter-robot

comment created time in 14 hours

issue openedknative/serving

[flaky] test/e2e/initscale.TestInitScaleZero

Auto-generated issue tracking flakiness of test

  • Test name: test/e2e/initscale.TestInitScaleZero
  • Repository name: serving

<!-------------End of issue body, Please don't edit below this line-------------> <!--[DONT_MODIFY_TEST_IDENTIFIER]'test/e2e/initscale.TestInitScaleZero' in repo 'serving'[DONT_MODIFY_TEST_IDENTIFIER]-->

created time in 14 hours

issue commentknative/docs

Knative Serving(docs/serving/_index.md)

This is same issue with https://github.com/knative/docs/pull/3487. As README.md was changed to index.md, we need to remove README.md.

Not only samples link, but also all README.md link grep-ed by:

$ grep -rH "\/README.md)" | grep -v https

need to be updated.

cc @evankanderson

xtreme-sameer-vohra

comment created time in 18 hours

Pull request review commentknative/serving

Add Domainmapping AutoTLS e2e test

+// +build e2e++/*+Copyright 2021 The Knative Authors++Licensed under the Apache License, Version 2.0 (the "License");+you may not use this file except in compliance with the License.+You may obtain a copy of the License at++    http://www.apache.org/licenses/LICENSE-2.0++Unless required by applicable law or agreed to in writing, software+distributed under the License is distributed on an "AS IS" BASIS,+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+See the License for the specific language governing permissions and+limitations under the License.+*/++package autotls++import (+	"context"+	"testing"++	"github.com/kelseyhightower/envconfig"+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"+	"k8s.io/apimachinery/pkg/util/wait"+	"knative.dev/networking/test/conformance/ingress"+	duckv1 "knative.dev/pkg/apis/duck/v1"+	"knative.dev/pkg/reconciler"+	v1 "knative.dev/serving/pkg/apis/serving/v1"+	"knative.dev/serving/pkg/apis/serving/v1alpha1"+	"knative.dev/serving/test"+	"knative.dev/serving/test/e2e"+	v1test "knative.dev/serving/test/v1"+)++type dmConfig struct {+	// TLSServiceName is the name of testing Knative Service.+	// It is not required for self-signed CA or for the HTTP01 challenge when wildcard domain+	// is mapped to the Ingress IP.+	TLSServiceName string `envconfig:"tls_service_name" required:"false"`+	// TLSTestNamespace is the namespace of where the tls tests run.+	TLSTestNamespace string `envconfig:"tls_test_namespace" required:"false"`+	// CustomDomainSuffix is the custom domain used for the domainMapping.+	CustomDomainSuffix string `envconfig:"custom_domain_suffix" required:"false"`+}++func TestDomainMappingAutoTLS(t *testing.T) {+	t.Parallel()

@YoussB sorry could you please fix the format error? I think it is an indent issue.

YoussB

comment created time in 19 hours

pull request commentknative/eventing

[Automated] Update knative/community files

@knative-automation: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

knative-automation

comment created time in 19 hours

push eventknative/serving

knative-automation

commit sha d30f0bd69bcf16afba6c9c5696b093149eb89489

Update net-certmanager nightly (#11306) bumping knative.dev/net-certmanager c42834e...d43cafb: > d43cafb Update actions (# 209) Signed-off-by: Knative Automation <automation@knative.team>

view details

push time in a day

PR merged knative/serving

[Automated] Update net-certmanager nightly approved cla: yes lgtm size/S

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager c42834e...d43cafb:
  > d43cafb Update actions (# 209)
+12 -12

3 comments

1 changed file

knative-automation

pr closed time in a day

pull request commentknative/serving

[Automated] Update net-contour nightly

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-contour-latest 49a8d56f495f89ba4553fff44c52a532532cd5d7 link /test pull-knative-serving-contour-latest

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

knative-automation

comment created time in a day

pull request commentknative/serving

[Automated] Update net-kourier nightly

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-istio-stable-no-mesh 287266a4fe7c09f55cd22580100154793c4d7fd0 link /test pull-knative-serving-istio-stable-no-mesh

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

knative-automation

comment created time in a day

issue commentknative/serving

[flaky] test/e2e/tagheader.TestTagHeaderBasedRouting/send_request_with_correct_header

This is same with GC test. It failed to apply config-features.

Setting feature tag-header-based-routing to EnabledError from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.net-certmanager.networking.internal.knative.dev": Post https://net-certmanager-webhook.d4d994de-62f4-4d42-990c-836e2e991ce1.svc:443/config-validation?timeout=30s: no endpoints available for service "net-certmanager-webhook"

knative-test-reporter-robot

comment created time in a day

pull request commentknative/serving

Disable webhook for net-certmanager-webhook

Codecov Report

Merging #11315 (7605f80) into main (f8f26b7) will increase coverage by 0.03%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11315      +/-   ##
==========================================
+ Coverage   87.67%   87.71%   +0.03%     
==========================================
  Files         191      191              
  Lines        9211     9211              
==========================================
+ Hits         8076     8079       +3     
+ Misses        881      877       -4     
- Partials      254      255       +1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 85.93% <0.00%> (-0.79%) :arrow_down:
pkg/activator/net/revision_backends.go 92.41% <0.00%> (+0.89%) :arrow_up:
pkg/autoscaler/scaling/multiscaler.go 89.38% <0.00%> (+1.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8f26b7...7605f80. Read the comment docs.

nak3

comment created time in a day

issue commentknative/serving

[flaky] test/e2e/gc.TestRevisionGC

Setting config-gc to immediate garbage collectionError from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.net-certmanager.networking.internal.knative.dev": Post https://net-certmanager-webhook.fa21803d-a9d6-4a0d-8740-2149102cce16.svc:443/config-validation?timeout=30s: no endpoints available for service "net-certmanager-webhook"

It failed to set config-gc due to webhook issue. https://github.com/knative/serving/pull/11315 tries to disable the webhook.

knative-test-reporter-robot

comment created time in a day

pull request commentknative/serving

Disable webhook for net-certmanager-webhook

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["nak3"]} -->

nak3

comment created time in a day