Codecov Report

Merging #11318 (3275f0b) into main (d30f0bd) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11318      +/-   ##
==========================================
- Coverage   87.74%   87.72%   -0.03%     
==========================================
  Files         191      191              
  Lines        9211     9211              
==========================================
- Hits         8082     8080       -2     
- Misses        876      878       +2     
  Partials      253      253              

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d30f0bd...3275f0b. Read the comment docs.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["nak3"]} -->

GetIngressEndpoint() is a function to get ingress endpoint for the spoof client. So we don't need to call it when --resolvabledomain is enabled. Especially when Ingresss service uses ClusterIP, it alwasy fails to get endpoint and test fails.

This patch changes to call GetIngressEndpoint() only when resolvabledomain is false in websocket test.

Added Turkish option

I think this was the original intention:

			return http.StatusBadGateway, errors.New("received a non-empty response not recognized as CloudEvent. The response MUST be either empty or a valid CloudEvent")

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign slinkydeveloper after the PR has been reviewed. You can assign the PR to them by writing /assign @slinkydeveloper in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["slinkydeveloper"]} -->

Hi @naiduv. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

Welcome @naiduv! It looks like this is your first PR to knative/eventing 🎉

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

<!-- need_sender_cla -->

Ah, I see. I think this may be working as intended: the local ksvc yaml is unchanged so the client didn't do anything (it does not check the digest, it only checks if the image name changed). There's a cli issue discussing changing this in https://github.com/knative/client/issues/398.

@rhuss may be able to share the best cli workflow to handle this case

/assign @rhuss

E0508 11:11:28.225062      16 aws_credentials.go:77] while getting AWS credentials NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
INFO[0006] Retrieving image manifest nginx:stable-alpine 
INFO[0006] Retrieving image nginx:stable-alpine from registry index.docker.io 
INFO[0009] Built cross stage deps: map[]                
INFO[0009] Retrieving image manifest nginx:stable-alpine 
INFO[0009] Returning cached image manifest              
INFO[0009] Executing 0 build triggers                   
INFO[0009] Unpacking rootfs as cmd COPY ./web /usr/share/nginx/html requires it. 
INFO[0013] COPY ./web /usr/share/nginx/html             
INFO[0013] Taking snapshot of files...                  
INFO[0014] Pushing image to 
INFO[0014] Pushed image to 1 destinations  

Step completed

No changes to apply to service 'develop'.
Service 'develop' with latest revision 'develop-00003' (unchanged) is available at URL:
http://develop.sun-frontend...

Step completed

@julz Thanks for the quick response. Yes the deployment is successful. Image is pushed successfully and kn works but it does not create a new Revision (due to the unchanged docker image !!!!?).

I am expecting revision 00004 but it remains on 00003.

Name:         develop
Namespace:    sun-frontend
Labels:       <none>
Annotations:  serving.knative.dev/creator: kubernetes-admin
              serving.knative.dev/lastModifier: kubernetes-admin
API Version:  serving.knative.dev/v1
Kind:         Service
Metadata:
  Creation Timestamp:  2021-05-06T05:56:23Z
  Generation:          3
  Managed Fields:
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:address:
          .:
          f:url:
        f:conditions:
        f:latestCreatedRevisionName:
        f:latestReadyRevisionName:
        f:observedGeneration:
        f:traffic:
        f:url:
    Manager:      controller
    Operation:    Update
    Time:         2021-05-06T05:56:30Z
    API Version:  serving.knative.dev/v1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:template:
          .:
          f:metadata:
            .:
            f:annotations:
              .:
              f:client.knative.dev/user-image:
            f:creationTimestamp:
          f:spec:
            .:
            f:containers:
    Manager:         kn
    Operation:       Update
    Time:            2021-05-06T11:50:09Z
  Resource Version:  16009570
  UID:               440d25b8-1106-49c3-a038-0477002f5ba0
Spec:
  Template:
    Metadata:
      Annotations:
        client.knative.dev/user-image:  docker.domainname.tld/pna/sun-frontend
      Creation Timestamp:               <nil>
    Spec:
      Container Concurrency:  0
      Containers:
        Image:  docker.domainname.tld/pna/sun-frontend
        Name:   user-container
        Ports:
          Container Port:  80
        Readiness Probe:
          Success Threshold:  1
          Tcp Socket:
            Port:  0
        Resources:
      Enable Service Links:  false
      Timeout Seconds:       300
  Traffic:
    Latest Revision:  true
    Percent:          100
Status:
  Address:
    URL:  http://develop.sun-frontend.svc.cluster.local
  Conditions:
    Last Transition Time:        2021-05-06T11:50:27Z
    Status:                      True
    Type:                        ConfigurationsReady
    Last Transition Time:        2021-05-06T11:50:28Z
    Status:                      True
    Type:                        Ready
    Last Transition Time:        2021-05-06T11:50:28Z
    Status:                      True
    Type:                        RoutesReady
  Latest Created Revision Name:  develop-00003
  Latest Ready Revision Name:    develop-00003
  Observed Generation:           3
  Traffic:
    Latest Revision:  true
    Percent:          100
    Revision Name:    develop-00003
  URL:                http://develop.sun-frontend.alpha.domainname.tld
Events:               <none>

Hi @xclud - I may be misunderstanding, but the message above sounds like the deploy succeeded, did you mean to say "doesn't resolve"? Could you post the full cli invocation and response (the whole thing, not just the last line), and also the output of "kubectl describe ksvc develop" please? It would also be helpful to know the knative version you are using.

Thanks!

/area build

I am using knative-serving along with tekton and kaniko. In a multi step Task my image is getting built and pushed to a private registry (yes, it supports api version 2) using kaniko. Then the next step runs a kn command to create a new Revision for the KService.

Unfortunately in the last step kn does resolve the digest and logs Service 'develop' with latest revision 'develop-00003' (unchanged) is available at URL:. However, when I run docker pull ... in the node CLI, kn creates a new revision (if triggered).

I have read this doc https://knative.dev/docs/serving/tag-resolution/ and i am sure i did not enable the digest resolution skipping.

I appreciate if you shed some light on this. Or have i just found a bug?

Reopening issue: this test is flaky

Latest result for this test: Flaky Last build start time: 2021-05-08 08:00:29 +0000 UTC Failed 1 times out of 10 runs. Failed runs: 1390758452745211904 <!------Latest History of Up To 10 runs------> 2021-05-08 08:00:29 +0000 UTC: ✔ ✔ ✔ ✖ ✔ ✔ ✔ ✔ ✔ ✔ <!------End of History------> ✔ Passed ✖ Failed ◻ Skipped

<!--[DONT_MODIFY_TEST_IDENTIFIER]'test/e2e/initscale.TestInitScaleZero' in repo 'serving'[DONT_MODIFY_TEST_IDENTIFIER]-->

Auto-generated issue tracking flakiness of test

• Test name: test/e2e/initscale.TestInitScaleZero
• Repository name: serving

<!-------------End of issue body, Please don't edit below this line-------------> <!--[DONT_MODIFY_TEST_IDENTIFIER]'test/e2e/initscale.TestInitScaleZero' in repo 'serving'[DONT_MODIFY_TEST_IDENTIFIER]-->

This is same issue with https://github.com/knative/docs/pull/3487. As README.md was changed to index.md, we need to remove README.md.

Not only samples link, but also all README.md link grep-ed by:

$ grep -rH "\/README.md)" | grep -v https

need to be updated.

cc @evankanderson

@YoussB sorry could you please fix the format error? I think it is an indent issue.

@knative-automation: PR needs rebase.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager c42834e...d43cafb:
  > d43cafb Update actions (# 209)

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

This is same with GC test. It failed to apply config-features.

Setting feature tag-header-based-routing to EnabledError from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.net-certmanager.networking.internal.knative.dev": Post https://net-certmanager-webhook.d4d994de-62f4-4d42-990c-836e2e991ce1.svc:443/config-validation?timeout=30s: no endpoints available for service "net-certmanager-webhook"

Codecov Report

Merging #11315 (7605f80) into main (f8f26b7) will increase coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11315      +/-   ##
==========================================
+ Coverage   87.67%   87.71%   +0.03%     
==========================================
  Files         191      191              
  Lines        9211     9211              
==========================================
+ Hits         8076     8079       +3     
+ Misses        881      877       -4     
- Partials      254      255       +1     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8f26b7...7605f80. Read the comment docs.

Setting config-gc to immediate garbage collectionError from server (InternalError): Internal error occurred: failed calling webhook "config.webhook.net-certmanager.networking.internal.knative.dev": Post https://net-certmanager-webhook.fa21803d-a9d6-4a0d-8740-2149102cce16.svc:443/config-validation?timeout=30s: no endpoints available for service "net-certmanager-webhook"

It failed to set config-gc due to webhook issue. https://github.com/knative/serving/pull/11315 tries to disable the webhook.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from nak3 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["nak3"]} -->