profile
viewpoint

dgross881/administrate 0

A Rails engine that helps you put together a super-flexible admin dashboard.

dgross881/alipay 0

An unofficial alipay ruby gem

dgross881/angkordriver 0

Fun project for a friend

dgross881/bootstrap-loader 0

Load Bootstrap styles and scripts in your Webpack bundle

PR opened phoenixframework/phoenix

Update heroku deployment docs

Heroku 16 has been deprecated and the hashnuke build pack suggests this buildpack instead.

I have since upgraded my app from Heroku 16 to Heroku 20 and can confirm that the new build pack compiled and deployed.

+5 -3

0 comment

1 changed file

pr created time in 16 hours

Pull request review commentphoenixframework/phoenix

Add phx.gen.auth tests to main test suite

 defmodule Mix.Tasks.Phx.Gen.Auth do     {context, schema} = Gen.Context.build(context_args, __MODULE__)     Gen.Context.prompt_for_code_injection(context) -    # Needed so we can get the ecto adapter and ensure other-    # libraries are loaded.-    #-    # As far as I can tell, everything after this must be tested with an-    # integration test.-    Mix.Task.run("compile")+    if Keyword.get(test_opts, :validate_dependencies?, true) do

Actually, ignore me, we need test_opts anyway. :)

aaronrenner

comment created time in 20 hours

Pull request review commentphoenixframework/phoenix

Add phx.gen.auth tests to main test suite

 defmodule Mix.Tasks.Phx.Gen.Auth do     {context, schema} = Gen.Context.build(context_args, __MODULE__)     Gen.Context.prompt_for_code_injection(context) -    # Needed so we can get the ecto adapter and ensure other-    # libraries are loaded.-    #-    # As far as I can tell, everything after this must be tested with an-    # integration test.-    Mix.Task.run("compile")+    if Keyword.get(test_opts, :validate_dependencies?, true) do

Maybe we can support a "--no-compile" regular flag?

aaronrenner

comment created time in 20 hours

pull request commentphoenixframework/phoenix

Add phx.gen.auth tests to main test suite

This adds for phx.gen.auth to the main test suite. I found that trying to debug using the integration tests is difficult because they are running in a different BEAM instance and tools like IO.inspect/1 don't output anything to the console (because output is being captured).

Btw, one option is to have an env var that makes you print the captured result as you capture them (or afterwards), but unit tests are also welcome.

aaronrenner

comment created time in 20 hours

PR opened phoenixframework/phoenix

Reviewers
Add phx.gen.auth tests to main test suite

This adds for phx.gen.auth to the main test suite. I found that trying to debug using the integration tests is difficult because they are running in a different BEAM instance and tools like IO.inspect/1 don't output anything to the console (because output is being captured).

Things to note

  1. In order to get these tests to work, I had to add an optional second parameter to Mix.Tasks.Phx.Gen.Auth.run/1 that allows me to pass in the database adapter and skip the dependency check. With these two options set, I'm able to bypass the need to compile the app that's being tested and test this like the rest of the phx.gen.* tasks.
  2. Since phx.gen.auth injects code into several files in an existing phoenix project, instead of trying to create those needed files in something like in_tmp_live_project/1, I found that I could just call Mix.Tasks.Phx.New.run/1 and have the project generated for me automatically. This required me adding phx_new as a path-based, test dependency, but it doesn't seem to cause any issues and makes the test set up much simpler.
  3. Now that I can use phx.new to generate projects, not every project needs to be named :phoenix. I modified with_generator_env/3 to accept an optional app name.
  4. This test currently takes about 30 seconds to run because of the size of some of the eex templates. My next task is to precompile these templates while still allowing templates to be overridden in thepriv directory. I added a test in this PR that overrides a template in the priv directory and ensures the override works.
  5. I added new tests for some of the user prompts and found some could use formatting improvements. I updated one of the prompts to make it look a little nicer.

Please let me know what you think. I hope these tests will make the developer experience working on phx.gen.auth much easier.

+857 -18

0 comment

4 changed files

pr created time in a day

PR opened phoenixframework/phoenix

Standardize names in Installation (Guides)

Use "macOS"

+2 -2

0 comment

1 changed file

pr created time in 2 days

pull request commentphoenixframework/phoenix

heroku.md: Remove unnecessary "longpoll: false"

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

henrik

comment created time in 2 days

push eventphoenixframework/phoenix

Henrik Nyh

commit sha fdafd8563c16ed997a2b8a4ec7d73de62b52c238

heroku.md: Remove unnecessary "longpoll: false" (#4147) Per https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#socket/3, this is already the default.

view details

push time in 2 days

PR merged phoenixframework/phoenix

heroku.md: Remove unnecessary "longpoll: false"

Per https://hexdocs.pm/phoenix/Phoenix.Endpoint.html#socket/3, this is already the default, so perhaps not worth mentioning.

Unless I'm missing something and this setting is extra important in the context of Heroku – if so, perhaps the docs could say a bit more about that.

+1 -2

0 comment

1 changed file

henrik

pr closed time in 2 days

push eventphoenixframework/phoenix

Niels Kristian Hansen Skovmand

commit sha 32c906fc96d030113d95e0e8be49299b640c7b1f

Use consistent naming of Node.js in Phoenix, also to distinguish from a node in the elixir sense (#4150)

view details

push time in 2 days

pull request commentphoenixframework/phoenix

Use consistent naming of Node.js in docs

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

skovmand

comment created time in 2 days

push eventphoenixframework/phoenix

Niels Kristian Hansen Skovmand

commit sha d8f2f90fcd85b4a3b1cf214be292cdb77c7271f1

Use consistent naming of Node.js in Phoenix, also to distinguish from a node in the elixir sense (#4150)

view details

push time in 2 days

PR merged phoenixframework/phoenix

Use consistent naming of Node.js in docs

Across the Phoenix docs, Node.js is spelled differently as e.g. "node", "NodeJS", "Node.JS", etc, but the correct spelling is Node.js. This is corrected across the project in this PR.

The term "node" is also easy to confuse with erlang nodes, so it improves the clarity to use Node.js.

References for Node.js being the correct spelling:

  • https://nodejs.org/en/
  • https://github.com/nodejs/node/pull/33088
+15 -15

0 comment

6 changed files

skovmand

pr closed time in 2 days

push eventphoenixframework/phoenix

Max Veytsman

commit sha acdfcadb84a8b6a7b86bc79da3982692262158cc

Update @unsent Plug.Conn states (#4159)

view details

push time in 2 days

pull request commentphoenixframework/phoenix

Update `@unsent` Plug.Conn states to include `:set_chunked` and `:set_file`

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

mveytsman

comment created time in 2 days

PR merged phoenixframework/phoenix

Update `@unsent` Plug.Conn states to include `:set_chunked` and `:set_file`

We use @unsent to raise an AlreadySentError if trying to change the view or the layout after a response is sent. This updates the module variable to include the other unsent states from https://github.com/elixir-plug/plug/blob/40efbe4680f98eb063ea1e17f079c4243b6593cf/lib/plug/conn.ex#L258

It might be nicer to expose unsent?/sent? as functions on Plug.Conn itself. What do you think?

+1 -1

0 comment

1 changed file

mveytsman

pr closed time in 2 days

pull request commentphoenixframework/phoenix

Fix phx.gen.auth confirm_account test arity description

Thank you, @aaronjensen! Here is the PR for phx_gen_auth: https://github.com/aaronrenner/phx_gen_auth/pull/109

bhtabor

comment created time in 2 days

issue commentphoenixframework/phoenix

npm install fails on fresh project

It also looks like node-sass version 4 is not compatible with Node 15. Things work well with Node.js 14 on my machine.

This seems like indeed the issue. Phoenix 1.6 Changelog suggests node-sass is replaced with sass, which should fix this for once and all.

As a newcomer to this community, sorry if this is not the right forum but what's the timeline on that release?

scripttease

comment created time in 2 days

PR closed phoenixframework/phoenix

test commit
+2 -1

0 comment

1 changed file

Jbur43

pr closed time in 2 days

PR opened phoenixframework/phoenix

test commit
+2 -1

0 comment

1 changed file

pr created time in 2 days

push eventsantiment/sanbase2

Atanas

commit sha 26643458fef448553b8f8bd1c96f6beded2a3b87

Alias historical balance resolver

view details

push time in 2 days

push eventsantiment/sanbase2

Ivan Ivanov

commit sha 15d3a64ee3723d2ba151f76eb46fb1f50b3a8e1b

Add docs for daily_metric_signal

view details

Ivan Ivanov

commit sha f858ac1822ac42ab1779ae18924964aca82ee95f

Extend Metric.History to apply to DailyMetricHistory

view details

Ivan Ivanov

commit sha 67c34e2d2e9c618fc08c9143d251f75e4f28e04a

Rework metric signal tests. Add tests for daily metric signal

view details

push time in 2 days

push eventsantiment/sanbase2

Ivan Ivanov

commit sha 2f407d7b4d5b80d1fbdc71f8306b67af5bac7e21

Add DailyMetricTriggerSettings. Rework existing code to be reused

view details

push time in 3 days

PR opened santiment/sanbase2

Add DailyMetricTriggerSettings. Rework existing code to be reused

Changes

<!--- Describe your changes -->

Ticket

<!--- Issue to which the pull request is related -->

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->

  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have tried to find clearer solution before commenting hard-to-understand parts of code
  • [ ] I have added tests that prove my fix is effective or that my feature works

<!--- ## Deployment steps --> <!--- Deployment todo steps, if needed. Example: running seed files, mix tasks... -->

<!--- ## Usage --> <!--- (Mainly graphql snippets that showcase how new API is used) -->

<!--- ## Screenshots --> <!--- (if appropriate) -->

<!--- original: https://github.com/VeryBigThings/elixir_common/blob/98e723a3d1ecbc21107b3a2f98b8ab619ba28800/.github/pull_request_template.md -->

+368 -240

0 comment

9 changed files

pr created time in 3 days

create barnchsantiment/sanbase2

branch : daily-metrics-signal

created branch time in 3 days

PR opened santiment/sanbase2

Reviewers
WIP: Rework balance usd with dataloader

Changes

<!--- Describe your changes -->

Ticket

<!--- Issue to which the pull request is related -->

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. -->

  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have tried to find clearer solution before commenting hard-to-understand parts of code
  • [ ] I have added tests that prove my fix is effective or that my feature works

<!--- ## Deployment steps --> <!--- Deployment todo steps, if needed. Example: running seed files, mix tasks... -->

<!--- ## Usage --> <!--- (Mainly graphql snippets that showcase how new API is used) -->

<!--- ## Screenshots --> <!--- (if appropriate) -->

<!--- original: https://github.com/VeryBigThings/elixir_common/blob/98e723a3d1ecbc21107b3a2f98b8ab619ba28800/.github/pull_request_template.md -->

+45 -12

0 comment

5 changed files

pr created time in 3 days

push eventsantiment/sanbase2

Atanas

commit sha bfb5a8fbd1fa3a50e8ba495bfbdfaf66a776918f

import Absinthe resolution helpers module

view details

push time in 3 days

push eventsantiment/sanbase2

Atanas

commit sha f0a047df600c2ae226a665bd49364ee3b264adb1

Run format

view details

push time in 3 days

push eventsantiment/sanbase2

Atanas

commit sha da449e55976ea1d790283e6b571adb889641f33f

Fix typoo

view details

Atanas

commit sha 8a563f01035155d5ff9cbc9dd5467a59b31dc1f9

add balance_usd resolver

view details

push time in 3 days

more