profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/dgladkov/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Dmitry Gladkov dgladkov Uber San Francisco

dgladkov/django-turbolinks 115

Drop-in turbolinks implementation for Django

dgladkov/django-project-template 7

Yet another attempt to create neat and reusable Django project template

dgladkov/cyclic_complexity 5

Python cyclic complexity checker (mirror)

dgladkov/buildbot 1

Python-based continuous integration testing framework; send pull requests for your patches!

dgladkov/django-mongokit 1

Bridging Django to MongoDB with the MongoKit ODM (Object Document Mapper)

dgladkov/django-multimedia 1

A django app used to encode video from the django admin. Uses ffmpeg to encode the video and django-celery to process it in a queue. Supports any video profile you can write an ffmpeg command to accomplish.

dgladkov/django-nose 1

Django test runner using nose

dgladkov/django-rosetta 1

Rosetta is a Django application that eases the translation process of your Django projects

dgladkov/fabric 1

Simple, Pythonic remote execution and deployment. Please file tickets at http://code.fabfile.org instead of sending pull requests!

issue commentuber/cadence

[Question] Does cron workflow change require a manual termination?

Yea it does

On Fri, Jun 18, 2021 at 5:22 AM Long Ho ***@***.***> wrote:

Does it apply to cron workflows as well?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/uber/cadence/issues/4277#issuecomment-863999173, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCQPM7TOWSFA45TL6CCYOLTTM3A5ANCNFSM462LHOOA .

--

Thanks, Quanzheng

longlho

comment created time in 2 hours

issue commentuber/cadence

[Question] Does cron workflow change require a manual termination?

Does it apply to cron workflows as well?

longlho

comment created time in 3 hours

Pull request review commentuber/arcanist

Try to fetch base ref explicitly before fetch all

 private function pullFromAllRemotesUntilFound($hash) {       $remotes = array_merge($remotes, array_filter(explode(PHP_EOL, $stdin)));     }     foreach ($remotes as $remote) {-      $repository_api->execManualLocal('fetch %s %s', $remote, $hash);+      $repository_api->execManualLocal('fetch --no-tags --depth=1 %s %s', $remote, $hash);

And also - this is general path some repositories might still use tags as way to push staging refs, do not break backward compatibility

mattlwilliams

comment created time in 4 hours

issue commentuber/cadence

How to get previous result of activity as the args of Subsequent activity after service restart?

If activity B already successfully completed, meaning the result2 is reported to cadence server. Then your worker after restart will resume from there and get result 2 back from server. So nothing needs to do. It’s all automatically

enuoCM

comment created time in 7 hours

issue commentuber/cadence

Memory leak in executing cadence workflows

Thanks for reporting.

The screenshot shows that memory leak is in client, not server. Can you upgraded to the latest version to see if that still exists? It will be much easier to fix on the latest version.

suman-anand-grab

comment created time in 7 hours

issue commentuber/cadence

[Question] Does cron workflow change require a manual termination?

Terminate and start new ones definitely works, but not required. Because you can use versioning.

When all existing workflow runs have finished and start new runs with the new order (B C A), then you can remove the old path.

docs are in https://cadenceworkflow.io/docs/go-client/workflow-versioning/ And https://cadenceworkflow.io/docs/java-client/versioning/

See also https://stackoverflow.com/questions/65007136/uber-cadence-workflow-versioning/65029001#65029001

let me know if you need more help

longlho

comment created time in 7 hours

release wix/Detox

18.18.0

released time in 7 hours

issue commentreact-native-linear-gradient/react-native-linear-gradient

not working in web

try to use this https://www.npmjs.com/package/react-native-web-linear-gradient

learncodingforweb

comment created time in 7 hours

release mochajs/mocha

v9.0.1

released time in 8 hours

Pull request review commentuber/arcanist

Try to fetch base ref explicitly before fetch all

 public function run() {           "<bg:blue>** %s **</bg> %s\n",           pht('INFO'),           pht('Base commit is not in local repository; trying to fetch.'));-        $repository_api->execManualLocal('fetch --quiet --all');+        // UBER CODE

Are you sure this part is even used by submitqueue, afaik you rely on custom patching from ref and you probably won't even go here?

mattlwilliams

comment created time in 8 hours

Pull request review commentuber/arcanist

Try to fetch base ref explicitly before fetch all

 private function pullFromAllRemotesUntilFound($hash) {       $remotes = array_merge($remotes, array_filter(explode(PHP_EOL, $stdin)));     }     foreach ($remotes as $remote) {-      $repository_api->execManualLocal('fetch %s %s', $remote, $hash);+      $repository_api->execManualLocal('fetch --no-tags --depth=1 %s %s', $remote, $hash);

As with PR231 - do you have benchmarks showing that it is actually faster?

mattlwilliams

comment created time in 8 hours

pull request commentuber/arcanist

Fetch using depth=1 with "--uber-use-staging-git-tags"

Do you have benchmarks showing that it is faster? I was doing benchmark and --depth=1 added extra couple of seconds to fetch

mattlwilliams

comment created time in 8 hours

issue commentvisgl/deck.gl

Toggling layer visibility with a checkbox and updateTriggers

@alitarraf, would you be able to share your code? because it contains many features necessary to produce quality maps like yours! Regards

alitarraf

comment created time in 10 hours

issue commentvisgl/deck.gl

Toggling layer visibility with a checkbox and updateTriggers

Hi, this is how I worked it out. Also checkout the source code for this example https://deck.gl/gallery/hexagon-layer. renderlayer function and also you can have a look at http://sets-cloud.com/covrex/

You have the renderlayer() function:

// here you are creating the option for the layer to be visible or not depending on wether the checkbox is checked or not.
    let optionsEducation = {
        visible: document.getElementById('Education').checked
      };

//here you are defining your layers parameters
const educationLayer = new IconLayer({
        id: 'education-layer',
        data:educationData.features,
        pickable: true,
        iconAtlas: './img/school.png',
        iconMapping: ICON_MAPPING,
        getIcon: d => 'marker',
        sizeScale: 5,
        getPosition: d => d.geometry.coordinates,
        getSize: d => 5,
        onHover: updateTooltipPOI,
        ...optionsEducation // <<<<<<<--------notice here we are using the optionsEducation variable in the layer
      });

// here you are setting the deckgl prop to render your layer
 deckgl.setProps({
        layers: [educationLayer],
        viewState: Object.assign({}, currentViewState)
      });
alitarraf

comment created time in 10 hours

push eventuber/cadence

Quanzheng Long

commit sha ffe4e2fa128c36eb8bdc3c4cbbe0ede61b9927a7

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1

view details

push time in 15 hours

delete branch uber/cadence

delete branch : qlong-nosql-wf-1

delete time in 15 hours

PR merged uber/cadence

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1 automerge

<!-- Describe what has changed in this PR --> What changed?

  1. Create NoSQL interface for create workflow operation
  2. Extract the logic of Cassandra to implement the interface
  3. Replace executionStore with NoSQL plugin db style

<!-- Tell your future self why have you made these changes --> Why? For https://github.com/uber/cadence/issues/3514

<!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> How did you test it? existing tests. Working on adding more test to the PR.

<!-- Assuming the worst case, what can be broken when deploying this change to production? --> Potential risks Medium risks. Even though the goal of the PR is to keep the same behavior, it's still some uknown and this is the critical persistence for Cadence.

<!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> Release notes No

<!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/uber/cadence-docs --> Documentation Changes No

+2496 -150

2 comments

11 changed files

longquanzheng

pr closed time in 15 hours

push eventuber/cadence

Quanzheng Long

commit sha ed7a542fac6db65f06ce5475578a4c635195a8a6

rerun

view details

push time in 16 hours

Pull request review commentuber/cadence

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1

 const ( 	SortByStartTime VisibilitySortType = iota 	SortByClosedTime )++const (+	CurrentWorkflowWriteModeNoop CurrentWorkflowWriteMode = iota+	CurrentWorkflowWriteModeUpdate+	CurrentWorkflowWriteModeInsert+)++func (w *CurrentWorkflowWriteCondition) GetCurrentRunID() string {+	if w == nil || w.CurrentRunID == nil {+		return ""+	}+	return *w.CurrentRunID+}++func (e *WorkflowOperationConditionFailure) Error() string {

you are right. I found the corresponding error handling logic for the new type.

longquanzheng

comment created time in 16 hours

push eventuber/cadence

Yichao Yang

commit sha e4a5917590c6abdedd4fb6b53365c3f690a85c18

Task fetcher implementation (#4272) - Add common task fetcher implementation - Fixed several issues in existing replication task fetcher impl

view details

Quanzheng Long

commit sha 1bfe1512489663d19a380c1f67e30fa89239ef88

done comment

view details

Quanzheng Long

commit sha c1b9dbafa1ac7e0a4e2b5660e53cd9bcd5465399

fix comment

view details

Quanzheng Long

commit sha fdffa3a3912bad1c8d657946af2e64c4099078e2

add

view details

Quanzheng Long

commit sha 7896348c36ad57c7d95af8d484860a082d8171a9

done interface for createWF

view details

Quanzheng Long

commit sha 1676eaa7625995a40d69d2d1cc297dc56a61713f

interface

view details

Quanzheng Long

commit sha e5ce06e58d6fc48e37660fe6f196287879e6e29c

stash

view details

Quanzheng Long

commit sha 957f8ee8f5f8bae93686a88ed4663ffcd764f366

done create workflow impl

view details

Quanzheng Long

commit sha 0f2b84bf1ba9130ab4859b9693c68312650e7c87

stash

view details

Quanzheng Long

commit sha 58c8ca278a29f7dc0864700db543910b7e6f411c

done

view details

Quanzheng Long

commit sha b624492e5c93672ca4697f560c1e0e6549847b56

fmt

view details

Quanzheng Long

commit sha 91ac8631eee9cfeb0a03c6c43b6febf2fc5578f1

fix bug

view details

Quanzheng Long

commit sha 4a00786641405175cda51cb0b0f57e59e4720eb5

improve comment

view details

Quanzheng Long

commit sha 2952c316f8406e85dd487583b845479550366058

rename var

view details

Quanzheng Long

commit sha 137e21e2ebfd51ad6fc64435361a51c053d00ff3

rename var

view details

Quanzheng Long

commit sha f707cfcdf0bc24993efb6568f17bb05a6d04edc8

improve nil check

view details

Quanzheng Long

commit sha 2e34e24c07f8545903ecf78e2505283d5154e337

fix corruption bug

view details

Quanzheng Long

commit sha df549ecdd6875732ac1d1be6588391e9108c892d

revert rename file

view details

Quanzheng Long

commit sha 3677b4abbb94720e8b0071986debc000a0687bf2

remove todo

view details

Quanzheng Long

commit sha d93f6df2e43d46bb580cfabf1d8dceda94fd1781

improve comment

view details

push time in 16 hours

Pull request review commentuber/cadence

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1

 const ( 	SortByStartTime VisibilitySortType = iota 	SortByClosedTime )++const (+	CurrentWorkflowWriteModeNoop CurrentWorkflowWriteMode = iota+	CurrentWorkflowWriteModeUpdate+	CurrentWorkflowWriteModeInsert+)++func (w *CurrentWorkflowWriteCondition) GetCurrentRunID() string {+	if w == nil || w.CurrentRunID == nil {+		return ""+	}+	return *w.CurrentRunID+}++func (e *WorkflowOperationConditionFailure) Error() string {

No we don't need to. Also checking that means you have double checking, which is duplicated and unnescessary.

I will remove IsConditionFailedError() from the interface in another PR once this one is merged: https://github.com/uber/cadence/issues/4273

longquanzheng

comment created time in 16 hours

pull request commentuber/cadence

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1

It seems like the old code path is not deleted, do you think it makes sense to have a feature flag for controlling whether the new impl should be used?

It's not being used at all. applyWorkflowSnapshotBatchAsNew is still being used by UpdateWorkflow and ConflictResolution API so they will be deleted in next PR.

I don't feel it's useful at all to have a feature flag. The refactoring goal is to get rid of it.

longquanzheng

comment created time in 16 hours

Pull request review commentuber/cadence

Refactoring Cassandra workflow persistence manager for NoSQL support : Part 1

 const ( 	SortByStartTime VisibilitySortType = iota 	SortByClosedTime )++const (+	CurrentWorkflowWriteModeNoop CurrentWorkflowWriteMode = iota+	CurrentWorkflowWriteModeUpdate+	CurrentWorkflowWriteModeInsert+)++func (w *CurrentWorkflowWriteCondition) GetCurrentRunID() string {+	if w == nil || w.CurrentRunID == nil {+		return ""+	}+	return *w.CurrentRunID+}++func (e *WorkflowOperationConditionFailure) Error() string {

Do we need to update the impl for IsConditionFailedError() to also check for this error?

longquanzheng

comment created time in 17 hours

push eventvisgl/deck.gl

Victor Belomestnov

commit sha 0f595e9ff08bfe7cb51f5c8eccecbde6b1acede2

Bump @loaders.gl to 3.0.0-alpha.21 (#5879)

view details

Xiaoji Chen

commit sha 98a7c249e7213073c4edc68662db4b5ee9b465bd

Update TextLayer documentation (#5888)

view details

Xiaoji Chen

commit sha 7b6c14bf1da669d7f5f123df1df950fd0a517a89

TextLayer supports characterSet:auto

view details

Xiaoji Chen

commit sha abb217cdac0d95c775dd910961d74f130834d2cf

address comments

view details

push time in 17 hours

Pull request review commentvisgl/deck.gl

TextLayer supports characterSet:auto

 export default class TextLayer extends CompositeLayer {   // Text strings are variable width objects   // Returns the index at the start of each string (every character is rendered by one instance)   _updateText() {-    const {data} = this.props;+    const {data, characterSet} = this.props;     const textBuffer = data.attributes && data.attributes.getText;     let {getText} = this.props;     let {startIndices} = data;     let numInstances; +    const autoCharacterSet = characterSet === 'auto' && new Set(DEFAULT_CHAR_SET);+     if (textBuffer && startIndices) {       const {texts, characterCount} = getTextFromBuffer({         ...(ArrayBuffer.isView(textBuffer) ? {value: textBuffer} : textBuffer),         length: data.length,-        startIndices+        startIndices,+        characterSet: autoCharacterSet

This is an internal utility. Unnecessarily copying Set objects will add a performance hit.

Pessimistress

comment created time in 17 hours

Pull request review commentvisgl/deck.gl

TextLayer supports characterSet:auto

 The padding of the background, `[padding_x, padding_y]` in pixels.  Specifies a prioritized list of one or more font family names and/or generic family names. Follow the specs for CSS [font-family](https://developer.mozilla.org/en-US/docs/Web/CSS/font-family). -##### `characterSet` (Array | String, optional)+##### `characterSet` (Array | Set | String, optional)

What kind of note? The example readmes just link to layer documentation.

Pessimistress

comment created time in 17 hours

push eventvisgl/deck.gl

Xiaoji Chen

commit sha 2a6f3636bb230c3933e7d40ad8f9c2ad6d539fd7

address comments

view details

push time in 17 hours

PR opened uber/arcanist

Fetch using depth=1 with "--uber-use-staging-tags"
  • Use --depth=1 when fetching base ref from staging repository
  • Remove '--tag' flag which is not applicable to 'git fetch'
+2 -2

0 comment

1 changed file

pr created time in 17 hours

pull request commentuber/arcanist

Try to fetch base ref explicitly before fetch all

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

mattlwilliams

comment created time in 18 hours

PR opened uber/arcanist

Try to fetch base ref explicitly before fetch all

When a diff has a base not present in the repository, try to fetch the specific base ref from staging and origin first before trying the potentially expensive 'git fetch --all'.

+7 -6

0 comment

1 changed file

pr created time in 18 hours