I think it's still broken 🤔

$ Dev node --version        
v16.1.0
$ Dev npm init wmr hello-wmr 
Need to install the following packages:
  create-wmr
Ok to proceed? (y) y
node:internal/modules/cjs/loader:944
  throw err;
  ^

Error: Cannot find module 'string_decoder/'
Require stack:
- /Users/wiese/.npm/_npx/3c66316f091b0520/node_modules/create-wmr/dist/index.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:941:15)
    at Function.Module._load (node:internal/modules/cjs/loader:774:27)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.<anonymous> (/Users/wiese/.npm/_npx/3c66316f091b0520/node_modules/create-wmr/dist/index.js:2:194)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/wiese/.npm/_npx/3c66316f091b0520/node_modules/create-wmr/dist/index.js'
  ]
}
npm ERR! code 1
npm ERR! path /Users/wiese/Dev
npm ERR! command failed
npm ERR! command sh -c create-wmr "hello-wmr"

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/wiese/.npm/_logs/2021-05-12T07_46_40_624Z-debug.log

I feel like converting the npm middleware into a standard plugin would make a lot of issues like this easier. In doing so it would automatically be included during the resolution phase.

Describe the bug WMR handles CSS imports from node_modules differently based on the current environment. Take the following for example

node_modules/
--foo/
----package.json
----dist/
------index.css

The package.json file has an exports key that (partially) looks like the following:

"exports": {
  ...
  "./index.css": "./dist/index.css"

This should mean that the CSS file can be imported like import "foo/index.css";, and indeed this works when using wmr build. However, in dev, the exports field is not taken into account, so one must use import "foo/dist/index.css";.

Additional context Adding this to the list of CSS shenanigans I need to explore some time, writing this down so I remember to come back to it.

• [ ] Check if updating to the latest Preact version resolves the issue

Describe the bug Cannot read property 'insertBefore' of undefined when using Suspense and lazy. Reason being originalParent is undefined in Suspense's removeOriginal function

Works if checks originalParent before calling insertBefore on it

To Reproduce

If possible, please provide a CodeSandbox/Codepen that demonstrates the issue. You can use the following template: https://codesandbox.io/s/immutable-grass-ziq4b?file=/src/index.js

Steps to reproduce the behavior: In codesandbox

Expected behavior No error

Fixes: https://github.com/preactjs/preact/issues/3137

thanks for your help! 👍

It seems you're heavily using the window object so I'm not sure there's even any use in enabling prerendering here (at least not at the moment, with the content that's in the repo). You're likely better off disabling as browser graphics / animation isn't usually cut out for prerendering / ssr.

You're looking in the wrong folder. You map a path to ../src. Not sure where the Promise.ts is coming from, but your issue is in the other directory there.

Not sure how well file: is supported at the moment. Will try to take a look into this more tomorrow.

• [x] Check if updating to the latest Preact version resolves the issue: Yes, using preact 10.5.13

Describe the bug

Preact isn't able to prerender a project on build, with a file that does not exist. When i run "preact build", it shows the following error:

Unable to read file: /mnt/d/Projects/Musicorum/prestion/testing/src/src/Promise.ts

ReferenceError: self is not defined
method: nGod
at: /mnt/d/Projects/Musicorum/prestion/testing/src/src/Promise.ts:4:5

Source code:


This is most likely caused by using DOM or Web APIs.
Pre-render runs in node and has no access to globals available in browsers.

Consider wrapping code producing error in: 'if (typeof window !== "undefined") { ... }'

Alternatively use 'preact build --no-prerender' to disable prerendering.

The thing is that this file (Promise.ts) doesn't exist, either this last src folder. Here is my file tree:

To Reproduce

Because this is a build problem, i can't link to a csb/codepen app, but the full code is open source at this commit.

Expected behavior

It should build with no problems. I used the --no-prerender option and it works fine, but it would be better to use the prerender option.

• [x] Check if updating to the latest Preact version resolves the issue: Yes, using preact 10.5.13

Describe the bug

Preact isn't able to prerender a project on build, with a file that does not exist. When i run "preact build", it shows the following error:

Unable to read file: /mnt/d/Projects/Musicorum/prestion/testing/src/src/Promise.ts

ReferenceError: self is not defined
method: nGod
at: /mnt/d/Projects/Musicorum/prestion/testing/src/src/Promise.ts:4:5

Source code:


This is most likely caused by using DOM or Web APIs.
Pre-render runs in node and has no access to globals available in browsers.

Consider wrapping code producing error in: 'if (typeof window !== "undefined") { ... }'

Alternatively use 'preact build --no-prerender' to disable prerendering.

The thing is that this file (Promise.ts) doesn't exist, either this last src folder. Here is my file tree:

To Reproduce

Because this is a build problem, i can't link to a csb/codepen app, but the full code is open source at this commit.

Expected behavior

It should build with no problems. I used the --no-prerender option and it works fine, but it would be better to use the prerender option.