In practice, implementations of the Subscription methods end up thread-safe anyway.

Not sure if this is generally true as it depends on how a Publisher is using a Subscription instance. As an example this Subscription instance usage is such that an instance is only used by the associated Subscriber and hence can assume serial access as required by rule 2.7

Bumps jetty-server from 9.4.19.v20190610 to 9.4.41.v20210516. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eclipse/jetty.project/releases">jetty-server's releases</a>.</em></p> <blockquote> <h2>9.4.41.v20210516</h2> <h1>Changelog</h1> <ul> <li>This release resolves <a href="https://github.com/eclipse/jetty.project/security/advisories/GHSA-gwcr-j4wh-j3cq">CVE-2021-28169</a></li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6099">#6099</a> Cipher preference may break SNI if certificates have different key types</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6186">#6186</a> Add Null Protection on Log / Logger</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6205">#6205</a> OpenIdAuthenticator may use incorrect redirect</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6208">#6208</a> HTTP/2 max local stream count exceeded</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6227">#6227</a> Better resolve race between <code>AsyncListener.onTimeout</code> and <code>AsyncContext.dispatch</code></li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6254">#6254</a> Total timeout not enforced for queued requests</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6263">#6263</a> Review URI encoding in ConcatServlet & WelcomeFilter</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6277">#6277</a> Better handle exceptions thrown from session destroy listener</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6280">#6280</a> Copy ServletHolder class/instance properly during startWebapp</li> </ul> <h2>9.4.40.v20210413</h2> <h1>Notable Bug Fixes</h1> <p>Users of GzipHandler should upgrade. (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6168">#6168</a>) Users of SSL/TLS on the jetty-server or jetty-client should upgrade. (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6082">#6082</a>)</p> <h1>Changelog</h1> <ul> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6168">#6168</a> - Improve handling of unconsumed content</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6148">#6148</a> - Jetty start.jar always reports jetty.tag.version as <code>master</code></li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6105">#6105</a> - HttpConnection.getBytesIn() incorrect for requests with chunked content</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6082">#6082</a> - SslConnection compacting</li> </ul> <h2>9.4.39.v20210325</h2> <h1>Changelog</h1> <h1>:warning: Important Security related Changes</h1> <ul> <li><a href="https://github.com/eclipse/jetty.project/security/advisories/GHSA-26vr-8j45-3r4w">CVE-2021-28165</a> - <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6072">#6072</a> - jetty server high CPU when client send data length > 17408</li> <li><a href="https://github.com/eclipse/jetty.project/security/advisories/GHSA-v7ff-8wcx-gmc5">CVE-2021-28164</a> - <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6101">#6101</a> - Normalize ambiguous URIs</li> <li><a href="https://github.com/eclipse/jetty.project/security/advisories/GHSA-j6qj-j888-vvgq">CVE-2021-28163</a> - <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6102">#6102</a> - Exclude webapps directory from deployment scan</li> </ul> <h1>Other Changes</h1> <ul> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6034">#6034</a> - SslContextFactory may select a wildcard certificate during SNI selection when a more specific SSL certificate is present</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6050">#6050</a> - Websocket: NotUtf8Exception after upgrade 9.4.35 -> 9.4.36 or newer</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6052">#6052</a> - Cleanup TypeUtil and ModuleLocation to allow jetty-client/hybrid to work on Android</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6063">#6063</a> - Allow override of hazelcast version when using module</li> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6085">#6085</a> - Jetty keeps Sessions in use after "Duplicate valid session cookies" Message</li> </ul> <h2>9.4.38.v20210224</h2> <h1>Changelog</h1> <ul> <li><a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6001">#6001</a> - Ambiguous URI legacy compliance mode</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eclipse/jetty.project/commit/98607f93c7833e7dc59489b13f3cb0a114fb9f4c"><code>98607f9</code></a> Updating to version 9.4.41.v20210516</li> <li><a href="https://github.com/eclipse/jetty.project/commit/087f486b4461746b4ded45833887b3ccb136ee85"><code>087f486</code></a> Issue <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6277">#6277</a> Better handling of exceptions thrown in sessionDestroyed (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6278">#6278</a>) ...</li> <li><a href="https://github.com/eclipse/jetty.project/commit/edcaf70d9a11186771c9decf25fe3575fb717638"><code>edcaf70</code></a> Copy ServletHolder class/instance properly during startWebapp (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6214">#6214</a>)</li> <li><a href="https://github.com/eclipse/jetty.project/commit/1c05b0bcb181c759e98b060bded0b9376976b055"><code>1c05b0b</code></a> Fixes <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6263">#6263</a> - Review URI encoding in ConcatServlet & WelcomeFilter.</li> <li><a href="https://github.com/eclipse/jetty.project/commit/9cb93432b38d8af20058f5a95b90b370869422f1"><code>9cb9343</code></a> Issue <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6205">#6205</a> - Fix serialization issues in OpenIdAuthenticator</li> <li><a href="https://github.com/eclipse/jetty.project/commit/2e7f5ebd2b7b7ebed4be53085549cc8f876791a7"><code>2e7f5eb</code></a> Issue <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6205">#6205</a> - Fix issues with OpenID redirecting to wrong URI (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6211">#6211</a>)</li> <li><a href="https://github.com/eclipse/jetty.project/commit/88ac10439a8b5ec1c34aaab4ccbf0f590aee33f8"><code>88ac104</code></a> Issue <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6254">#6254</a> - Total timeout not enforced for queued requests.</li> <li><a href="https://github.com/eclipse/jetty.project/commit/da50e06b640d448d42e642c842cf9bc647797a49"><code>da50e06</code></a> Fixes <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6254">#6254</a> - Total timeout not enforced for queued requests.</li> <li><a href="https://github.com/eclipse/jetty.project/commit/5f23689aa7f44c0660ba2ad92c7c6a15d7c4af15"><code>5f23689</code></a> Issue <a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6254">#6254</a> - Total timeout not enforced for queued requests.</li> <li><a href="https://github.com/eclipse/jetty.project/commit/003c3134ca54b00e4151f9525976e1ea58813fd0"><code>003c313</code></a> upgrade h2spec-maven-plugin 1.0.5 (<a href="https://github-redirect.dependabot.com/eclipse/jetty.project/issues/6247">#6247</a>)</li> <li>Additional commits viewable in <a href="https://github.com/eclipse/jetty.project/compare/jetty-9.4.19.v20190610...jetty-9.4.41.v20210516">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

The inconsistency between cancel() and request() does seem questionable.

Thanks for the prompt response 👍 I do understand the 'serially' part, however the fact that Subscription methods end up thread-safe is not the point. My argument is, that the spec defines that cancel must be 'thread-safe', which isn't necessary true, likewise for request which doesn't list this clause. Shouldn't this part be removed or re-worded for clarity?

The definition of serially should clear things up.

In practice, implementations of the Subscription methods end up thread-safe anyway.

Rule 3.5

Subscription.cancel MUST respect the responsivity of its caller by returning in a timely manner, MUST be idempotent and MUST be thread-safe.

mentions thread-safety and also links the keyword to it's definition in this context, which mentions "async".

Can be safely invoked synchronously, or asychronously, without requiring external synchronization to ensure program correctness.

The rule seems to contradict other rules, like:

• 2.7

A Subscriber MUST ensure that all calls on its Subscription's request and cancel methods are performed serially.

• 3.1

Subscription.request and Subscription.cancel MUST only be called inside of its Subscriber context.

And lastly the "MUST be thread-safe" doesn't equally apply to 'Subscription.request'. Is this obsolete, or is my understanding wrong?

Hello,

i'm trying to generate Java classes from a metadata xml following the logic of the odata-client-microsoft-dynamics client but the process fails with the following error:

manyToManyRelationships() in microsoft.dynamics.crm.entity.set.EntityDefinitions cannot override manyToManyRelationships() in microsoft.dynamics.crm.entity.collection.request.EntityMetadataCollectionRequest

The XML definitions for RelationshipDefinitions and EntityDefinitions in my metadata file are similar with those of https://github.com/davidmoten/odata-client/blob/master/odata-client-microsoft-dynamics/src/main/odata/microsoft-dynamics-crm4-v9.1-metadata.xml:

<EntitySet Name="RelationshipDefinitions" EntityType="Microsoft.Dynamics.CRM.RelationshipMetadataBase" />

<EntitySet Name="EntityDefinitions" EntityType="Microsoft.Dynamics.CRM.EntityMetadata">
  <NavigationPropertyBinding Path="Microsoft.Dynamics.CRM.BooleanAttributeMetadata/GlobalOptionSet" Target="GlobalOptionSetDefinitions" />
  <NavigationPropertyBinding Path="ManyToManyRelationships" Target="RelationshipDefinitions" />
  <NavigationPropertyBinding Path="ManyToOneRelationships" Target="RelationshipDefinitions" />
  <NavigationPropertyBinding Path="OneToManyRelationships" Target="RelationshipDefinitions" />
  <NavigationPropertyBinding Path="Microsoft.Dynamics.CRM.EnumAttributeMetadata/GlobalOptionSet" Target="GlobalOptionSetDefinitions" />
</EntitySet>

but the code generated (e.g. for manyToManyRelationships()) is:

public final class EntityDefinitions extends EntityMetadataCollectionRequest {

    public RelationshipDefinitions manyToManyRelationships() {
        return new RelationshipDefinitions(contextPath.addSegment("ManyToManyRelationships"));
    }	
}

public class EntityMetadataCollectionRequest extends CollectionPageEntityRequest<EntityMetadata, EntityMetadataRequest> {
    
	public ManyToManyRelationshipMetadataCollectionRequest manyToManyRelationships() {
        return new ManyToManyRelationshipMetadataCollectionRequest(contextPath.addSegment("ManyToManyRelationships"), Optional.empty());
    }
}

Am i doing something wrong? If i comment out the EntityDefinitions entity set, the process completes successfully. Can this be considered a solution to my problem or it will result a non functional client? What is the purpose of the EntityDefinitions entity set?

Thank you.

It would be nice if this got documented in the Javadoc for the method. It is a really subtle behavior that can lead to nasty bugs.

I'm able to download content with @microsoft.graph.downloadUrl too.

Yup! I could fetch the mediaReadLink and download content too, successfully. Thankyou David.

Bumps mockito-core from 3.11.1 to 3.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p> <blockquote> <h2>v3.11.2</h2> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h4>3.11.2</h4> <ul> <li>2021-06-21 - <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">5 commit(s)</a> by dependabot[bot]</li> <li>Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2333">mockito/mockito#2333</a>)</li> <li>Bump assertj-core from 3.20.0 to 3.20.1 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2332">mockito/mockito#2332</a>)</li> <li>Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2330">mockito/mockito#2330</a>)</li> <li>Bump assertj-core from 3.19.0 to 3.20.0 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2329">mockito/mockito#2329</a>)</li> <li>Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2328">mockito/mockito#2328</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0"><code>2be3fcf</code></a> Bump versions.bytebuddy from 1.11.2 to 1.11.3 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8"><code>566cfa5</code></a> Bump assertj-core from 3.20.0 to 3.20.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df"><code>a8164ea</code></a> Bump shipkit-auto-version from 1.1.17 to 1.1.19 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440"><code>163629c</code></a> Bump assertj-core from 3.19.0 to 3.20.0 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0"><code>441e556</code></a> Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)</li> <li>See full diff in <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Bumps mockito-core from 3.11.1 to 3.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p> <blockquote> <h2>v3.11.2</h2> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h4>3.11.2</h4> <ul> <li>2021-06-21 - <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">5 commit(s)</a> by dependabot[bot]</li> <li>Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2333">mockito/mockito#2333</a>)</li> <li>Bump assertj-core from 3.20.0 to 3.20.1 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2332">mockito/mockito#2332</a>)</li> <li>Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2330">mockito/mockito#2330</a>)</li> <li>Bump assertj-core from 3.19.0 to 3.20.0 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2329">mockito/mockito#2329</a>)</li> <li>Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2328">mockito/mockito#2328</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0"><code>2be3fcf</code></a> Bump versions.bytebuddy from 1.11.2 to 1.11.3 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8"><code>566cfa5</code></a> Bump assertj-core from 3.20.0 to 3.20.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df"><code>a8164ea</code></a> Bump shipkit-auto-version from 1.1.17 to 1.1.19 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440"><code>163629c</code></a> Bump assertj-core from 3.19.0 to 3.20.0 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0"><code>441e556</code></a> Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)</li> <li>See full diff in <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Bumps com.vanniktech.maven.publish from 0.15.1 to 0.16.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/releases">com.vanniktech.maven.publish's releases</a>.</em></p> <blockquote> <h2>0.16.0</h2> <p><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/blob/master/CHANGELOG.md#version-0160-2021-06-20">Changelog</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/blob/master/CHANGELOG.md">com.vanniktech.maven.publish's changelog</a>.</em></p> <blockquote> <h2>Version 0.16.0 <em>(2021-06-20)</em></h2> <ul> <li>Add <code>pomFromGradleProperties</code> API to base plugin. This configures the pom in the same way the regular plugin does.</li> <li>Add the ability to remove the default <code>mavenCentral</code> repository, by setting <code>sonatypeHost</code> to <code>null</code></li> <li>Support <code>POM_LICENSE_NAME</code>, <code>POM_LICENSE_URL</code> and <code>POM_LICENSE_DIST</code> properties in addition to <code>LICENCE</code> based properties.</li> <li>Fixes an issue in the base plugin that caused an error during configuration of Android projects.</li> <li>Fixes an issue with javadoc tasks when using Java toolchains.</li> <li>The deprecated <code>nexusOptions</code> method was removed. <code>closeAndReleaseRepository</code> is automatically configured.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/03c04dfee412af5c9e742e977ef13e1fb319ccf7"><code>03c04df</code></a> Prepare for release 0.16.0.</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/b7bb81170e41f7dcacc31ca3f4fe0c88312b8430"><code>b7bb811</code></a> use 0.16.0-rc1</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/039889e9526df7fd1cc77d21b64878f86b4c94a0"><code>039889e</code></a> Prepare for release 0.16.0-rc1.</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/dc37f7e9c12272ce268d461860aa38ca40f449e8"><code>dc37f7e</code></a> update README and CHANGELOG for 0.16.0 (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/273">#273</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/4b8e7815bff3cf9a0a6b54db13d37db52bc0c29f"><code>4b8e781</code></a> get current java version from toolchain if possible (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/271">#271</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/9dfa4e013a631345de26088aec7bc599505c6bd6"><code>9dfa4e0</code></a> add support for LICENSE properties in addition to LICENCE (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/272">#272</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/850e75f08a57dd023d0b51e4ea6d00ab154c9574"><code>850e75f</code></a> fix Android projects in base plugin not working (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/270">#270</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/fc8c5c2982d319c7debf3bc88ac2e1a6e64fcbad"><code>fc8c5c2</code></a> Fix key password property name in documentation and publication action (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/266">#266</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/4b3df71b859bf5260d90542a12c991ed31d42af2"><code>4b3df71</code></a> Cleanup (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/251">#251</a>)</li> <li><a href="https://github.com/vanniktech/gradle-maven-publish-plugin/commit/094ae11b40dfaaa9d8bf182082b3617cf69e9831"><code>094ae11</code></a> add pomFromGradleProperties API to base plugin (<a href="https://github-redirect.dependabot.com/vanniktech/gradle-maven-publish-plugin/issues/250">#250</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vanniktech/gradle-maven-publish-plugin/compare/0.15.1...0.16.0">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Bumps junit from 4.12 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Codecov Report

Merging #7287 (eb057ce) into 3.x (578b4f8) will increase coverage by 0.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x    #7287      +/-   ##
============================================
+ Coverage     99.56%   99.57%   +0.01%     
+ Complexity     6758     6757       -1     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
+ Hits          47183    47191       +8     
+ Misses           95       92       -3     
+ Partials        113      108       -5     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 578b4f8...eb057ce. Read the comment docs.

Codecov Report

Merging #7286 (55f3b42) into 3.x (578b4f8) will decrease coverage by 0.04%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x    #7286      +/-   ##
============================================
- Coverage     99.56%   99.51%   -0.05%     
+ Complexity     6758     6753       -5     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
- Hits          47183    47161      -22     
- Misses           95      109      +14     
- Partials        113      121       +8     

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 578b4f8...55f3b42. Read the comment docs.

Bumps mockito-core from 3.11.1 to 3.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p> <blockquote> <h2>v3.11.2</h2> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Changelog generated by <a href="https://github.com/shipkit/shipkit-changelog">Shipkit Changelog Gradle Plugin</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h4>3.11.2</h4> <ul> <li>2021-06-21 - <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">5 commit(s)</a> by dependabot[bot]</li> <li>Bump versions.bytebuddy from 1.11.2 to 1.11.3 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2333">mockito/mockito#2333</a>)</li> <li>Bump assertj-core from 3.20.0 to 3.20.1 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2332">mockito/mockito#2332</a>)</li> <li>Bump org.eclipse.osgi from 3.16.200 to 3.16.300 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2330">mockito/mockito#2330</a>)</li> <li>Bump assertj-core from 3.19.0 to 3.20.0 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2329">mockito/mockito#2329</a>)</li> <li>Bump shipkit-auto-version from 1.1.17 to 1.1.19 [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2328">mockito/mockito#2328</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mockito/mockito/commit/2be3fcfa306d9e130d87213ff6698c859d01aef0"><code>2be3fcf</code></a> Bump versions.bytebuddy from 1.11.2 to 1.11.3 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2333">#2333</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/566cfa5e95b2f22f23321868f272f773017db2d8"><code>566cfa5</code></a> Bump assertj-core from 3.20.0 to 3.20.1 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2332">#2332</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/a8164eacb870013b5a21027f28ef5eec171965df"><code>a8164ea</code></a> Bump shipkit-auto-version from 1.1.17 to 1.1.19 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2328">#2328</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/163629c5cb5af73f8efd0fabd234963483f09440"><code>163629c</code></a> Bump assertj-core from 3.19.0 to 3.20.0 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2329">#2329</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/441e5569dc58c8c6cc1b060f1071b5c8975953a0"><code>441e556</code></a> Bump org.eclipse.osgi from 3.16.200 to 3.16.300 (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2330">#2330</a>)</li> <li>See full diff in <a href="https://github.com/mockito/mockito/compare/v3.11.1...v3.11.2">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>