profile
viewpoint
Austin Belknap dabelknap ColdQuanta Madison, WI Experimental particle physicist working as a software engineer.

apple/swift-syntax 1489

SwiftPM package for SwiftSyntax library.

dabelknap/CaloLinks 0

Class for handling the RCT bits in the format used in the oRSC to MP7/CTP7 optical links

dabelknap/ci-test 0

Sandbox for GitHub CI

dabelknap/cms-calo-layer1 0

Xilinx Microblaze Projects for RCT Upgrade

dabelknap/DblHAnalysis 0

Doubly-Charged Higgs Analysis at 8 TeV

dabelknap/DPS 0

Pythia simulation for double parton scattering in HZZ4L

dabelknap/FinalStateAnalysis 0

An analysis framework for the Compact Muon Solenoid

dabelknap/oRSCPatterns 0

Generate Physics Patterns for oRSC Playback Memories

dabelknap/swift 0

The Swift Programming Language

dabelknap/swift-format 0

Formatting technology for Swift source code

fork sergiocampama/prezto

The configuration framework for Zsh

fork in 10 days

pull request commentgoogle/swift

add swift-format to README

Apparently, that branch doesn't exist anymore.

muescha

comment created time in 23 days

push eventgoogle/swift

Dan Zheng

commit sha 42d45484f4a40971da1c94174edf360dfdb22f9a

[AutoDiff] Disable `differentiable_function_extract` explicit type assertion. `differentiability_function_extract` instruction has an optional explicit extractee type. This is currently used by TypeSubstCloner and the LoadableByAddress transform to rewrite `differentiability_function_extract` instructions while preserving `@differentiable` function type invariants. There is an assertion that `differentiability_function_extract` instructions do not have explicit extractee types outside of canonical/lowered SIL. However, this does not handle the SIL deserialization case above: when a function containing a `differentiable_function_extract` instruction with an explicit type is deserialized into a raw SIL module (which happens when optimizations are enabled). Removing the assertion unblocks this encountered use case. A more robust longer-term solution may be to change SIL `@differentiable` function types to explicitly store component original/JVP/VJP function types. Resolves SR-14004.

view details

Dan Zheng

commit sha 10f8a9466bee1c9f66eb3c2038cc82f802b763f8

[AutoDiff] Fix `differentiable_function_extract` extractee type serialization. The explicit extractee type was previously not serialized. The operand's type was incorrectly used instead.

view details

Dan Zheng

commit sha 6a6f972f7fcf51d8f81eca390d3cdde100681505

Merge pull request #270 from dan-zheng/holiday-patches [AutoDiff] Disable `differentiable_function_extract` explicit type assertion.

view details

push time in a month

PR merged google/swift

Reviewers
[AutoDiff] Disable `differentiable_function_extract` explicit type assertion.

Cherry-pick of https://github.com/apple/swift/pull/35239 during the holiday freeze.


differentiability_function_extract instruction has an optional explicit extractee type. This is currently used by TypeSubstCloner and the LoadableByAddress transform to rewrite differentiability_function_extract instructions while preserving @differentiable function type invariants.

There is an assertion that differentiability_function_extract instructions do not have explicit extractee types outside of canonical/lowered SIL. However, this does not handle the SIL deserialization case above: when a function containing a differentiable_function_extract instruction with an explicit type is deserialized into a raw SIL module (which happens when optimizations are enabled).

Removing the assertion unblocks this encountered use case.

Resolves SR-14004.

+53 -20

1 comment

7 changed files

dan-zheng

pr closed time in a month

pull request commentgoogle/swift

[AutoDiff] Disable `differentiable_function_extract` explicit type assertion.

Locally tested, merging to unblock progress. Happy to address any follow-up issues!

dan-zheng

comment created time in a month

PR opened google/swift

Reviewers
[AutoDiff] Disable `differentiable_function_extract` explicit type assertion.

Cherry-pick of https://github.com/apple/swift/pull/35239 during the holiday freeze.


differentiability_function_extract instruction has an optional explicit extractee type. This is currently used by TypeSubstCloner and the LoadableByAddress transform to rewrite differentiability_function_extract instructions while preserving @differentiable function type invariants.

There is an assertion that differentiability_function_extract instructions do not have explicit extractee types outside of canonical/lowered SIL. However, this does not handle the SIL deserialization case above: when a function containing a differentiable_function_extract instruction with an explicit type is deserialized into a raw SIL module (which happens when optimizations are enabled).

Removing the assertion unblocks this encountered use case.

Resolves SR-14004.

+53 -20

0 comment

7 changed files

pr created time in a month

startedios-bazel-users/ios-bazel-users

started time in a month

push eventgoogle/swift

Mishal Shah

commit sha f588e2a3ce39e0f57d842729bf1d320ed5ddb992

Disable subclass_existentials.swift test because it's failing on Ubuntu 20.04, 18.04 and CentOS 8

view details

Mishal Shah

commit sha 1d939e3a0dc38565ec0bb03b48db2fd2abc59b59

Merge pull request #35216 from apple/shahmishal/r72636579 Disable subclass_existentials.swift test because it's failing on Ubun…

view details

Dan Zheng

commit sha f2de54678bd56ea6be0e2a00562512fd06175f07

[AutoDiff] Disable flaky test on Linux. Disable test that occasionally flake on Linux. SR-13021 tracks re-enabling related failing AutoDiff tests.

view details

Mishal Shah

commit sha 949b0c0cc3632b0c278a33a4022dd280cf31215a

Merge pull request #35217 from dan-zheng/autodiff-testing [AutoDiff] Disable flaky test on Linux.

view details

Marc Rasi

commit sha 0142e524e153110ef76565527ef02341963bf24a

[AutoDiff] generated linear maps should be "convention(thin)"

view details

Marc Rasi

commit sha 880ca34b28aa7bb06b177df8549f8394d701c46a

Merge branch 'sr-13945' into holiday-patches

view details

push time in a month

create barnchgoogle/swift

branch : holiday-patches

created branch time in a month

push eventgoogle/swift

Marc Rasi

commit sha 336b96481bfafdb24f9b336eeed3e382cfd45a58

[AutoDiff] fix ownership instructions (SR-13973)

view details

Marc Rasi

commit sha 38b511242c843ed9817e9fe93656ee6ba25ba96c

add FileCheck for the new retain instruction

view details

Marc Rasi

commit sha 62339d3e9dc905146a2c4196e7d157703e7ec286

add ossa test and sil test hygiene

view details

Marc Rasi

commit sha d194c822a4019ec142a54171bd14b3015b0e3342

Merge branch 'marcrasi-fix-sr13973' into holiday-patches

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha ba3c8f30258fb43445e11f1aaebd81e587feacf9

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Nate Chandler

commit sha d4664c8bc20ca8af434541d2082ca8e09be722b6

[Async CC] Never use simple partial apply for async functions. Currently, the convention for partially applying an async function is to form a thick function consisting of (1) a pointer to the partial apply forwarder and (2) a thick context containing the async context size. Previously, the partial application of async methods--specifically, for which the partial application of the non-async analog produced a simple partial apply (meaning that their context was a single ref-counted object in the form of self)--would result in a simple partial application. Here, that error is addressed by never allowing the partial application of async methods to produce a simple partial apply. Eventually, when the complex temporary ABI for partial application of async functions is unrolled, this change will need to be unrolled as well.

view details

Doug Gregor

commit sha fb4583f7e7b4576adb4bbc50a8a1bd681043ae5c

Merge pull request #35111 from nate-chandler/concurrency/irgen/for-now-async-is-not-simple [Async CC] Never use simple partial apply for async functions.

view details

TensorFlow SyncBot

commit sha f2cf0510d6e25911e9babada46e0025862bd00cd

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: [Async CC] Never use simple partial apply for async functions.

view details

push time in a month

push eventgoogle/swift

John McCall

commit sha bad16fd105ac2094f6580b67576cfac06a8fb86e

Do dynamic layout of generic/resilient default actors properly. Since these types have an implicit stored property, this requires adding an abstraction over fields to IRGen, at least throughout the class code. In some ways I think this significantly improves the code, especially in how we approach missing members. Fixes rdar://72202671.

view details

John McCall

commit sha d68d406dae39ea1677d586714b3991b8f2037dab

Merge pull request #35094 from rjmccall/actor-dynamic-layout Do dynamic layout of generic/resilient default actors properly

view details

TensorFlow SyncBot

commit sha 9c2eb436fe79acb6ad36149d9d6d68e889104e8a

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: Do dynamic layout of generic/resilient default actors properly.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 5b2a0413aef371f6b0e9ec5f28820135be27be82

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Doug Gregor

commit sha bffc7434faec1a9446323d2d10c456049850c1e5

[Concurrency] Make 'await' and 'try' implicit in async let initializer

view details

Doug Gregor

commit sha b7be6cefc7feed85fba82075fdb1998c7dfe97a7

Merge pull request #35107 from DougGregor/async-let-implicit-try-await [Concurrency] Make 'await' and 'try' implicit in async let initializer

view details

TensorFlow SyncBot

commit sha 4c8206eb988ffa224be794a7ac88a74e4c59b461

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: [Concurrency] Make 'await' and 'try' implicit in async let initializer

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 7dfea080cc59f23db141c438583a784869889ead

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 8e5094d26db52cdf3328d3065718a53579250086

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Dan Liew

commit sha cb277316ebcc0e28cef5012f0c6770df326afec2

Re-enable `test/Driver/sanitizer_recover.swift`. rdar://problem/64784401

view details

Dan Liew

commit sha bb705ce14aa946572eebc11ffc2dc7e6d6295ca9

Merge pull request #35109 from apple/dliew/rdar-64784401 Re-enable `test/Driver/sanitizer_recover.swift`.

view details

TensorFlow SyncBot

commit sha c202eae2b77fc5501e2aa6b2707aae4af77c9eb5

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: Re-enable `test/Driver/sanitizer_recover.swift`.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 6666eae9a141ad4553ec4c0f8a35f773e77f5c8c

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Robert Widmann

commit sha 76a7ceea64e2e070190adf748dcbcd9296ab4654

[NFC] Re-Core Fingerprint Switch from a string core to a 128-bit integral core. This should make Fingerprints much cheaper to copy around and sets us up for a future where we can provide alternative implementations of the ambient hashing algorithm. rdar://72313506

view details

Michael Gottesman

commit sha 4801fe1966c4a30ecd15fb141edea6ec54e22bff

Fix a typo in a comment.

view details

swift-ci

commit sha c527323bc3a0b4f98fd316b26cfb7a14a6840775

Merge pull request #35104 from gottesmm/pr-979d6e3dd2ede93fc91b8f17c304baf548b2a113

view details

Robert Widmann

commit sha bf813aa6080c8f26cf7269fc5cb9fe7a0ac8e0a7

Merge pull request #35090 from CodaFi/apple-corps [NFC] Re-Core Fingerprint

view details

TensorFlow SyncBot

commit sha 84488d83dedb96990439d01a4cf8ba7524babc53

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: Fix a typo in a comment. [NFC] Re-Core Fingerprint

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha a899a764d991a7f91a2aa26e5c91a1cea171dc91

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Nate Chandler

commit sha 9e81653d1d4db8c74997714b8335ba7eb2f17e94

[metadata prespecialization] Fixed OldRemangler's Metaclass impl. Previously, the suffix was added to the buffer before the metaclass itself. Here, that is fixed.

view details

swift-ci

commit sha 90ad37b52d5f2afdc53f9529ad9a5113d66e5bba

Merge pull request #35101 from nate-chandler/generic-metadata-prespecialization-components/oldremangler-metaclass

view details

TensorFlow SyncBot

commit sha 3c9e32943604f1888a50f9f2c1d923b601862b15

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: [metadata prespecialization] Fixed OldRemangler's Metaclass impl.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha af1072a500c6a584fda3037b567eee342053b771

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 14f339499057dde4978f27f71081cd6865088a34

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Michael Gottesman

commit sha f7e6aa5847d634859e0b5cd745774dd0d73e9823

[silgenpattern] Rename an EnumElementDecl value from elt -> eltDecl. Since we are working with values here, it can be confusing when reading the code that elt is an EnumElementDecl. The rename to eltDecl will make it much clearer.

view details

Michael Gottesman

commit sha 3de8263b26a3a5146d94037ee6ceb0636aad60e2

[silgenpattern] When emitting address only enum element dispatch, do not leak the switch's operand along the default path. For the following discussion, let OP be the switch's operand. This is implemented by: * Modeling switch_enum_addr as not forwarding OP and instead delegate the forwarding of OP to be done by each enum case. This matches what SILGen is actually doing since the actual taking of the address in SIL is done in each enum case block by an unchecked_take_enum_data_addr. * In each enum case, I treat OP as being forwarded into an irrefutable sub-tree. I follow the pattern of other places this is done by creating a CleanupStateRestorationScope and using forwardIntoIrrefutableSubTree. This ensures that if I forward OP in the enum case, it just becomes dormant instead of being thrown away. * Inside each case, there is a bunch of code that does some final preparations to src before dispatching to the inner dispatch. This code was written using old low-level SILValue APIs where ownership is done by hand. I replaced all of that by hand ownership with higher level Managed Value APIs that automatically handle ownership for the user. This simplified the implementation and ensured correctness via SILGenBuilder API invariants. The end result of all of these together is that: 1. The cleanup on OP is still live when we emit the default case later than the cleanups. This eliminates the leak that I am fixing. 2. We have greater correctness since the SILGenBuilder APIs automatically handle ownership for us. 3. We have eliminated some brittle logic that could in the future introduce bugs. Specifically, I noticed that if we were ever given a ConsumableManagedValue that was CopyOnSuccess or BorrowAlways but its ManagedValue was a +1 value, we would leak. I could not figure out how to create a Swift test case that would go down this code path though = (. But that being said, it is one new language feature away from being broken. I added some asserts to ConsumableManagedValue that ensures this invariant, so we are safe. If it is inconvenient, we can also cause ConsumableManagedValue to create a new ManagedValue when it detects this condition without the cleanup. But lets see how difficult it is to keep this invariant. In terms of testing, I put in both a SILGen test and also an end<->end interpreter test to ensure this doesn't break again. rdar://71992652 SR-13926

view details

Michael Gottesman

commit sha 6f3fff29b614f8e68ba216b7fa8ec92945266320

Merge pull request #35093 from gottesmm/pr-f0ea76d1078cea17fa23ac2b2a27e8960bd077ad [silgenpattern] When emitting address only enum element dispatch, do not leak the switch's operand along the default path.

view details

TensorFlow SyncBot

commit sha 7d09c01874be299734b71af2f9412976b55b5feb

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: [silgenpattern] When emitting address only enum element dispatch, do not leak the switch's operand along the default path. [silgenpattern] Rename an EnumElementDecl value from elt -> eltDecl.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 58a3ed56f3272c9276807efc6ccf35287bfb0b4e

Upstream Swift/LLVM integrated.

view details

push time in a month

push eventgoogle/swift

Arnold Schwaighofer

commit sha 2b6ba2830ce44aa392dfa6262ef62a4002c70421

Serialize decls with `_specialize(exported:true, target: somefunc(_:), ...)` in a list for fast lookup rdar://71430641

view details

Rintaro Ishizaki

commit sha 4284a5158982209c327520a0c3c30870e7b5bc44

[Parse/CodeCompletion] Implement effects specifier completion Rewrote and rename 'parseAsyncThrows' to 'parseEffectsSpecifiers'. Implemented 'CodeCompletionCallbacks::completeEffectsSpecifier()'

view details

Rintaro Ishizaki

commit sha ed82d1828e314d9e31300191a7a2cf616d831c3d

[CodeCompletion] Complete effects specifiers in closure signature position

view details

Rintaro Ishizaki

commit sha 1c791d345d96d197f6a6252037a3cf6df9cc2cc9

[Parse] Factor out 'isEffectsSpecifier()'

view details

Rintaro Ishizaki

commit sha c72f9e5c9220b7bd29eb2961e121594ea085e282

[Parse] Adjust diagnostics for effects specifiers in closure signature

view details

Rintaro Ishizaki

commit sha 31595e3b2b2831545c7ae5644f5a87bc24568510

[Parse] Adjust diagnostics message for duplicated effects specifiers

view details

Erik Eckstein

commit sha e697e49582a7291d805a5b6f4e0f95740f40e669

[concurrency] IRGen:: do ptrauth for hop_to_executor Sign the resume-function pointer which is stored in AsyncTask.ResumeTask

view details

Nate Chandler

commit sha 4a515c6dd5341551be5a6ba67f971964a9698e86

[TBDGen] @asyncHandlers don't have public async function pointers. Previously, an async function pointer symbol was being emitted into the TBD for all AbstractFunctionDecls which returned true for "hasAsynContext", i.e. both those that were async and those which were asnycHandlers. That was not correct because the async function portion of an asyncHandler is not ABI. Here, that mistake is fixed by only emitting this symbol for functions which are annotated async (i.e. those for which "hasAsync" returns true). rdar://problem/72329062

view details

eeckstein

commit sha 7c78207407cf562ab34592f66f6c6a35421847e9

Merge pull request #35082 from eeckstein/concurrency-ptrauth [concurrency] IRGen:: do ptrauth for hop_to_executor

view details

Arnold Schwaighofer

commit sha b9407099fd2aa95f32f00a26545ce664f943a365

Merge pull request #35060 from aschwaighofer/fix_prespec_import_perf_problem Serialize decls with `_specialize(exported:true, target: somefunc(_:), ...)` in a list for fast lookup

view details

Rintaro Ishizaki

commit sha 4c38ec5a4a1c4385981e35f916d25ade2166610b

Merge pull request #35069 from rintaro/ide-completion-rdar72199413 [Parse/CodeCompletion] Implement effects specifier completion

view details

nate-chandler

commit sha d89ffe789a3a623912a161ac14be70701a069f0f

Merge pull request #35096 from nate-chandler/concurrency/irgen/rdar72329062 [TBDGen] @asyncHandlers don't have public async function pointers.

view details

TensorFlow SyncBot

commit sha 68b00927f98295293b68c1ba91d14ad5d4f7baab

Merge branch 'main' of github.com:apple/swift into tensorflow-stage * 'main' of github.com:apple/swift: [TBDGen] @asyncHandlers don't have public async function pointers. [concurrency] IRGen:: do ptrauth for hop_to_executor [Parse] Adjust diagnostics message for duplicated effects specifiers [Parse] Adjust diagnostics for effects specifiers in closure signature [Parse] Factor out 'isEffectsSpecifier()' [CodeCompletion] Complete effects specifiers in closure signature position [Parse/CodeCompletion] Implement effects specifier completion Serialize decls with `_specialize(exported:true, target: somefunc(_:), ...)` in a list for fast lookup

view details

Michelle Casbon

commit sha dc8ed85b5c8f907ca4b718a23ba5e5a61b27026c

[AutoDiff] Update non-upstreamed autodiff test. Update FileCheck test to match changes in #35096.

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha c78a28009c792bd39907c742187fa1e09b6a6955

Likely manual conflict resolution/bugfix.

view details

push time in a month

push eventgoogle/swift

Keith Smiley

commit sha 8472616af582eb3cafbd3350a4bc61776e63007e

Make python_format script executable It doesn't look like this script gets run much, but it should be executable so it can be.

view details

David Ungar

commit sha f90b2fca56ce71826f8bfa77e0558f41c10cf159

Make the "./" optional where it's easy to do so.

view details

David Ungar

commit sha a2b45686458f34f372ae9ec222bde4eaa772deca

Fix another test

view details

Kavon Farvardin

commit sha e23f0abbe858fff672ffc470651c2c379d850dc6

[concurrency] patch hole in typechecking ordinary functions for global actor references Non-actor isolated synchronous functions were previously allowed to call & reference global-actor isolated declarations. This patch puts a stop to that. Resolves rdar://71548470

view details

Andrew Trick

commit sha dbd5b2765f96ca174d810d19e9ea7629b8ca87e2

Add -sil-verify-all and -sil-verify-none to the sil-opt tool.

view details

David Ungar

commit sha 08da9cf2ffe17e0cd12fed6f4f58fdd50dd33400

Check stderr when looking for incremental remarks.

view details

David Ungar

commit sha af58ed4f1eb978da8f94acf282d7bb5f8038305f

Fix another test

view details

Ben Langmuir

commit sha d7b813b9ef0a2c6e717cde5d31aabf45c1cce9ea

[sourcekit] Identify xpc service by toolchain instead of sdk rdar://72310494

view details

Evan Wilde

commit sha a09224d9c4582a12a69030ce612e6194021a440c

[Concurrency] Ban passing actor state via inout Passing actor statte to async functions via inout parameters violates automicity. This patch bans passing actor state via inout parameter to async functions. This removes the warning when passing a sub-property of a property of an actor class and replaces it with an error message since passing actor state inout is not allowed.

view details

Evan Wilde

commit sha c2eda02fb5455334e4726f81ce59380b20051107

Adding test case for implicit async funcs This patch adds a test to verify that functions that are implicitly async also are reported as errors when passing data inout.

view details

Robert Widmann

commit sha 0557e74be1f1455412a8df562f9b54da3b004580

Merge pull request #34351 from keith/ks/make-python_format-script-executable Make python_format script executable

view details

Andrew Trick

commit sha 16bb57e823c9d80c8c39f66cbaed303337127991

Merge pull request #35083 from atrick/sil-verify-none Add -sil-verify-all and -sil-verify-none to the sil-opt tool.

view details

Kavon Farvardin

commit sha e8dcc979a0d556c7a4169e3f316aa4ff63e69d56

fix-it regression coverage for notes suggesting 'async', '@asyncHandler' and '@GlobalActorType' Currently, we don't have a fix-it to insert 'async', so I've marked those places as not expecting a fix-it, until someone goes and implements that (rdar://72313654)

view details

David Ungar

commit sha 3c2658511197bc1f1699110da4137da572536452

Merge pull request #35087 from davidungar/fixing-tests-2 [swift-driver Incremental] Fix test to be more compatible with swift-driver

view details

Andrew Trick

commit sha f24658fe9e03e0d03b98730be5cf86c5ea29f265

Fix ExistentialSpecializer to detect repeated specialization. Add handling for repeated specialization and remove an incorrect assertion in ExistentialTransform::createExistentialSpecializedFunctionName(): assert(!F->getModule().hasFunction(MangledName)); The ExistentialSpecializer replaces the original function with a thunk to a newly specialized function. Repeated attempts to specialize the same function bail out because the pass avoids reoptimizing thunks. Ultimately, the intention is that the thunks will all be inlined into their callers. Dead function elimination will then remove the thunks. If the original function was itself a specialization, then the GenericSpecialize may regenerate the original again in non-thunk form. Consider the pipeline: - GenericSpecializer - ExistentialSpecializer - Inliner - DeadFunctionElimination - GenericSpecializer - ExistentialSpecializer This is not a problem with the ExistentialSpecializer itself. In fact, it may respecialize the same function in different ways, for example specializing more of the arguments each time. Each different specialization transforms the original function into a thunk, that thunk is inlined, and the newly specialized code is called directly. Of course, the ExistentialSpecializer may also decide to respecialize a function the same way as before. When doing this, it still needs to produce the thunk, which was dead function eliminated since last specialization of the same function. However, it can simply reuse the previous specialization by performing a name lookup first. The design problem is that the SILModule makes assumptions about duplicate symbols when managing symbol memory but does not provide a robust way to protect against such duplicate symbols. That will be improved in a separate commit. Minimal fix for: rdar://72135512 The ExistentialSpecializer crashes

view details

Pavel Yaskevich

commit sha c6bdeea852ce2b16e4586f37e900222d4a39f355

[ConstraintSystem] Strengthen dependent member type checks while inferring bindings Look through specifier (inout, l-value) and optional types while checking for presence of dependent member types to avoid inferring incorrect bindings (which could lead to infinite recursion in the solver). Resolves: SR-13856 Resolves: rdar://problem/71383770

view details

Ben Langmuir

commit sha 04ec96e4de4bc89cfe0bad4174d8d255682af956

Merge pull request #35086 from benlangmuir/rdar72310494 [sourcekit] Identify xpc service by toolchain instead of sdk

view details

Evan Wilde

commit sha 66d307e4af9c5c5a2aacbe7c5da205bb40065418

Improve implicit async error message At the declaration, the implicitly async functions appear to be synchronous, so it isn't clear why the error message is being emitted. This patch updates the error message to indicate that the function is implicitly asynchronous.

view details

swift-ci

commit sha 1eb810f5663514118fb12b8463bb0e26e7f01dec

Merge pull request #35048 from kavon/typechecking-unspecified-isolation-contexts-71548470

view details

David Ungar

commit sha 332569aaccb6619baf123d9fb3a881e8ef2b2445

Merge pull request #35053 from davidungar/fixing-tests [swift-driver] Make checked build-record paths in many tests insensitive to ./ prefix

view details

push time in a month

push eventgoogle/swift

TensorFlow SyncBot

commit sha 3d62a9033cca6d1263980778b78029a8a1093185

Likely manual conflict resolution/bugfix.

view details

push time in a month

more