profile
viewpoint
Christoph Nakazawa cpojer Facebook Facebook http://cpojer.net Formerly Pojer · 👨🏻‍💻 Engineering Manager at Facebook · 🚇 Metro · 🃏 Jest · 📦 Yarn

pull request commentreact-native-sensors/react-native-sensors

Remove dev dependencies from the published npm package

Done! I hope the bot is happy with me :)

cpojer

comment created time in 18 hours

push eventcpojer/react-native-sensors

Christoph Nakazawa

commit sha 4b10610f3d6e8c5306c4291b39cfde4aeb7baabf

fix: remove dev dependencies from the published npm package

view details

push time in 18 hours

pull request commentromejs/rome

Add governance document

This is possibly the wrong place for this discussion but I think there is something to be said about reported violations that can be one-sided, like what if somebody's aim is to discredit somebody else after they got into a fight, or somebody sharing a really skewed perspective of what happened. I think it would be great to list the process in detail, including talking to the person who is accused of wrongdoing and identifying the root cause, instead of saying that a contributor will be banned after a violation is reported. While likely not the usual case (I do not want to discredit any future people who make use of the email address and report violations), it is possible that a report is wrong and the situation is explainable. Ideally the process will ensure that everyone is given privacy and space to deal with it instead of making quick decisions to resolve a tough situation.

(Note: this is me observing other projects, I have not been involved in such discussions or violations myself)

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.

I think specifying them as minimums is a good idea then.

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.+- If you are an owner of a particular area you are free to merge it without any review despite PR size.+- If an area involves multiple owners then it's up to .+- If after a PR is merged and there are comments or suggestions after the fact, allow yourself time to address them in a follow up PR. If you don't think you will be able to respond in a reasonable timeframe then create an issue to track.+- You are welcome to use the `rome` repo for your WIP branches. However you should prefix branches with your username. ie. `git branch sebmck/feature`. Branches not involved in an active PR will be regularly pruned.+- If you are adding a new feature then ensure that it has been discussed or approved on GitHub or Discord.++## Moderation++Users found to be in violation of the projects [code of conduct](./CODE_OF_CONDUCT.md) will be:++- Banned from the GitHub org and Discord server+- Have their contributor status revoked (if applicable)+- Have admin privileges revoked (if applicable)+- Action listed in [`MODERATION.md`](./MODERATION.md). There may be some scenarios where discretion is required and some details omitted to protect individuals.++Code of conduct violations can be reported to <conduct@romejs.dev> which is listed in the [code of conduct](./CODE_OF_CONDUCT.md). This email address is monitored by admins.

The other doc made me think that it goes to "community leaders" that are separate from the admins. It may make sense to clarify that there. Also, bummer, because if I think an admin violated the CoC and this email goes out to all admins I don't really get protection as the person in question will also see my complaint and that it's coming from me. This may intimidate members from the community to report possible violations.

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.+- If you are an owner of a particular area you are free to merge it without any review despite PR size.+- If an area involves multiple owners then it's up to .+- If after a PR is merged and there are comments or suggestions after the fact, allow yourself time to address them in a follow up PR. If you don't think you will be able to respond in a reasonable timeframe then create an issue to track.+- You are welcome to use the `rome` repo for your WIP branches. However you should prefix branches with your username. ie. `git branch sebmck/feature`. Branches not involved in an active PR will be regularly pruned.+- If you are adding a new feature then ensure that it has been discussed or approved on GitHub or Discord.++## Moderation++Users found to be in violation of the projects [code of conduct](./CODE_OF_CONDUCT.md) will be:++- Banned from the GitHub org and Discord server+- Have their contributor status revoked (if applicable)+- Have admin privileges revoked (if applicable)+- Action listed in [`MODERATION.md`](./MODERATION.md). There may be some scenarios where discretion is required and some details omitted to protect individuals.

"protect individuals" or "protect and individual's privacy"?

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.+- If you are an owner of a particular area you are free to merge it without any review despite PR size.+- If an area involves multiple owners then it's up to .+- If after a PR is merged and there are comments or suggestions after the fact, allow yourself time to address them in a follow up PR. If you don't think you will be able to respond in a reasonable timeframe then create an issue to track.+- You are welcome to use the `rome` repo for your WIP branches. However you should prefix branches with your username. ie. `git branch sebmck/feature`. Branches not involved in an active PR will be regularly pruned.+- If you are adding a new feature then ensure that it has been discussed or approved on GitHub or Discord.++## Moderation++Users found to be in violation of the projects [code of conduct](./CODE_OF_CONDUCT.md) will be:

Is this a one-strike policy?

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.+- If you are an owner of a particular area you are free to merge it without any review despite PR size.+- If an area involves multiple owners then it's up to .
  • "up to cpojer to act as a tie breaker" or whatever else you wanted to write here.
sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.+- If you are an owner of a particular area you are free to merge it without any review despite PR size.

wowza, that's a lot of power. Should this include some level of testing as a minimum requirement?

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.+- If a PR is against code that you have previously committed and is either small changes, bug fixes, or refactors, then you're free to merge it without any review. However if you don't feel confident in your changes then wait for approval from another core contributor.

"then wait" -> "you can wait"

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:++- Access to the [@romejsdev Twitter account](https://twitter.com/romejsdev)+- Administration privileges on the [Rome GitHub org](https://github.com/romejs)+- Administration privileges on the [Rome Discord server](https://github.com/romejs)+- Publish access to the [`rome` npm package](https://www.npmjs.com/package/rome)+- Domain registrar and DNS access to all `romejs.*` domains+- Administration access to the `romejs.dev` Netlify account+- Ability to decide on moderation decisions involving core contributors+- Access to the `*@romejs.dev` email address++The separation of Core Contributor and Admin allows for a minimum access of privileges.++New admins will be decided based on a general consensus by the existing admins.++### Owners++Certain parts of the codebase can be owned by one or more people. This process is informal and inclusion could be a result of substantial contribution or delegation by other members. It's the responsibility of a core contributor to identify the relevant owners and ensure there's an understanding when it comes to code review.++## Current Members++Members listed in alphabetical order.++### Admins++- [Sebastian McKenzie @sebmck](https://github.com/sebmck)++### Core Contributors++- [Eduardo Lopes @EduardoLopes](https://github.com/EduardoLopes)+- [Florent Cailhol @ooflorent](https://github.com/ooflorent)+- [Jamie Kyle @jamiebuilds](https://github.com/jamiebuilds)+- [Kevin Kelbie](https://github.com/KevinKelbie)+- [Olivier Dusabimana @diokey](https://github.com/diokey)+- [Paul Bouchon @bitpshr](https://github.com/bitpshr)+- [Victor Hom @VictorHom](https://github.com/VictorHom)++## Code review and merging++- All code needs to go through pull requests and must pass status checks before being merged. If a PR is merged that breaks `master` due to the branch not being up to date, then it should either be reverted or a quick fix merged as a separate PR.

"through Pull Requests (PR)" – you are later using an abbreviation so gotta introduce it.

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.

Majority vote? Unanimous vote?

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.++New contributors will be decided based on a general consensus by the existing core contributors.++### Admin++The amount of admins will be kept deliberately small. An admin has additional privileges over a core contributor including:

Why

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.++There are no expectations around activity. There may be a time where contributor privileges are restricted or removed for inactivity. However you will not lose org membership.

Maybe clarify "once core contributor status is granted […]"

Also: "a time when"?

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).++### Core Contributor++Core Contributors are those who have proved themselves as an active contributor by being involved in project management or by submitting high quality pull requests.

"proving themselves" sounds intimidating. Maybe "are those who have been an active contributor for a long period of time by being involved in project management or by submitting high quality pull requests."

You can also specify the period of time directly, like "one month" or "six months" or "two days".

sebmck

comment created time in 5 days

Pull request review commentromejs/rome

Add governance document

+# Governance++This document outlines the governance model for Rome. This includes the contributor model, code review, merging, and the consequences and process for code of conduct violations.++## Member Roles++All members must follow the [code of conduct](./CODE_OF_CONDUCT.md). Consequences for member violations are detailed in [Moderation](#moderation).

"Code of Conduct"?

sebmck

comment created time in 5 days

issue commentfacebook/jest

Make jest small

@probil JSDOM will become optional in Jest 28: https://jestjs.io/blog/2020/05/05/jest-26

Right now it's the default, so Jest 27 will make the node env the default, and then 28 will stop shipping it.

Note that for the monorepo at Facebook where we develop React Native, we blackhole jest-environment-jsdom to an empty module.

styfle

comment created time in 10 days

issue commentfacebook/jest

Make jest small

@SimenB is removing sane in https://github.com/facebook/jest/pull/10048.

styfle

comment created time in 11 days

Pull request review commentfacebook/jest

feat: replace `sane` with `chokidar`

 class HasteMap extends EventEmitter {     let mustCopy = true;      const createWatcher = (root: Config.Path): Promise<Watcher> => {-      // @ts-expect-error: TODO how? "Cannot use 'new' with an expression whose type lacks a call or construct signature."-      const watcher = new Watcher(root, {-        dot: false,-        glob: extensions.map(extension => '**/*.' + extension),-        ignored: ignorePattern,-      });+      const useWatchman = canUseWatchman && this._options.useWatchman;+      const patterns = extensions.map(extension => '**/*.' + extension);+      // Prefer Watchman over Chokidar+      const watcher = useWatchman+        ? new WatchmanWatcher(root, {+            dot: false,+            glob: patterns,+            ignored: ignorePattern,+          })+        : chokidarWatch(patterns, {

Surprising but .. they expose almost the same API? :O

SimenB

comment created time in 11 days

issue commentfacebook/jest

Make jest small

Let's remove node-notifier and make it an optional plugin. I don't know of anyone who uses it, and the people who do can install a separate package to hook it in. Does anyone want to work on a PR to make it its own package that will be used only when installed (and explicitly enabled)?

Note it is already an optional dependency (and at FB we blackhole it to an empty package).

styfle

comment created time in 11 days

PR closed facebook/metro

allow defaultConfigOverrides to work with configModule function CLA Signed

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

I was attempting to write a custom config for a react-native project (mostly for cache control), so I set up my metro.config.js to look something like this:

module.exports = async (defaultConfig) => ({
  ...defaultConfig,
  cacheStores: [
    new FileStore(/* config */),
	...defaultConfig.cacheStores,
  ],
});

However, when I did that, I got compilation errors because of flow syntax not being compiled away. @react-native-community/cli passes in it's own default config as overrides when calling loadConfig.

Unfortunately, these are silently thrown away when you set metro.config.js to export a function.

This is one option for a "fix" (this will make my code work, but may not be generally liked). Another would be:

- const resultedConfig = await configModule(defaultConfig);
+ const resultedConfig = await configModule(defaultConfig, defaultConfigOverrides);

That one would be backwards compatible, because wouldn't touch the default config for older configModules, and newer ones could accept the second argument.

Test plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

Unsure at this stage - if there is appetite for this change, I can look at adding tests.

+3 -1

2 comments

1 changed file

deecewan

pr closed time in 11 days

pull request commentfacebook/metro

allow defaultConfigOverrides to work with configModule function

Thanks for the PR! I believe https://github.com/facebook/metro/pull/559 will resolve the same issue, and it has tests, so I'll merge that one.

deecewan

comment created time in 11 days

Pull request review commentfacebook/metro

[rn-babel-transformer]: use async transform

 function buildBabelConfig(filename, options, plugins?: BabelPlugins = []) {   return Object.assign({}, babelRC, config); } -function transform({filename, options, src, plugins}: BabelTransformerArgs) {+async function transform({filename, options, src, plugins}: BabelTransformerArgs) {

What about the callsite of this? Does it already await or work with Promises?

jrylan

comment created time in 11 days

issue commentbabel/babel

Babel 8 Release Plan

@hzoo I think that's a great idea, thank you for thinking about this.

nicolo-ribaudo

comment created time in 13 days

issue commentbabel/babel

Babel 8 Release Plan

Thanks for the reply @nicolo-ribaudo, that's really exciting as that will ease the transition 👍

nicolo-ribaudo

comment created time in 14 days

pull request commentfacebook/react-native-website

React Native packager -> Metro bundler

Question: should we use "Metro bundler" only once in the bundler specific page and then later refer to it as "Metro"? We don't say "Jest testing framework" or "React Native UI library" in the docs either.

EvanBacon

comment created time in 15 days

push eventfacebook/react-native-website

Evan Bacon

commit sha 483f36c674c0d0546052740f005ab2552bde3b84

"React Native packager" -> Metro bundler

view details

Evan Bacon

commit sha 2bcacc84576c4b9d559754514911ff0410cc26f9

Merge branch 'master' into @evanbacon/use-metro-bundler-more

view details

Evan Bacon

commit sha ce6beb5199093087f1ea66d10e4e22ba428263d3

Remove old instance which don't apply

view details

Evan Bacon

commit sha 56522b8f81efcf1b2546f7bec33cd7f7e2021f63

use bundler instead of packager to reduce verbage

view details

Evan Bacon

commit sha 270fc05bf26fe2280db3ea51847d4079cde6bce1

Delete troubleshooting.md

view details

Christoph Nakazawa

commit sha 3ce100237affe2886bb5f259cd7ec618eb4065d2

Merge pull request #1916 from EvanBacon/@evanbacon/use-metro-bundler-more

view details

push time in 15 days

PR merged facebook/react-native-website

React Native packager -> Metro bundler Partner p: expo

Users coming from a web background will make a clearer connection to how React works when running natively if they can draw the comparison between the bundlers.

cite: React docs: https://reactjs.org/docs/create-a-new-react-app.html#creating-a-toolchain-from-scratch

+55 -45

1 comment

25 changed files

EvanBacon

pr closed time in 15 days

pull request commentbabel/babel

Use single object spread call in loose mode

Thank you for making this change, excited to try it out once it is released :)

jridgewell

comment created time in 15 days

pull request commentfacebook/relay

[Do not land] Remove fast-glob

@mrmlnc Nice work! I'll definitely consider using fast-glob in the future if the need arises :)

cpojer

comment created time in 15 days

issue commentbabel/babel

Babel 8 Release Plan

Question: could the official upgrade guide suggest how library authors can make their code compatible with both Babel 7 and 8, and then recommend them to use a semver range that works with either 7 or 8 until 7 is dropped at a later time?

I believe that could significantly reduce the gap in time when some tools are upgraded but others aren't.

nicolo-ribaudo

comment created time in 15 days

issue commentreact-native-community/discussions-and-proposals

Lean Core

@TheSavior is correct. We are gradually removing things and you may see some leftovers in some releases. I highly recommend against accessing them as they'll go away soon.

kelset

comment created time in 15 days

pull request commentfacebook/relay

[Do not land] Remove fast-glob

@mrmlnc @alloy is correct. There is nothing wrong with your package, in fact I actually like it quite a bit. I have been reducing the size of Facebook's React Native node_modules folder internally at Facebook. We use a monorepo, so every product developer has to install dependencies for every single project: Relay, Metro, Jest, Babel, eslint, React Native, jscodeshift and dozens more.

Previously the size of our node_modules folder was 930 MiB and we pulled in thousands of packages, many which were outdated or unnecessary. This lead to a long install time until people could get started, both on CI and locally. I have since been focusing on reducing the size of this folder through a number of (funky) techniques while simultaneously updating everything to the latest major versions. Our node_modules folder is now ~143 MiB and is much faster to install.

One of the techniques was to eliminate dependencies that are big (500k+), used only in one or two places (for example only in Relay) and are already covered by functionality of packages that are shared across a wider range of tools (like "glob"). In this case the impact is very low as people who run into problems with glob in open source can switch to watchman, which for large projects is much more scalable. While part of the source code, we do not use this code path at Facebook either.

To summarize, I'm removing large dependencies that we don't use (much) to make it faster for product developers to get started with React Native. If you are looking for things to improve I recommend reducing the size of the "fast-glob" packages and the dependencies it brings in. Why does it have to be 500k? Can it be 100k? Can it be 10?

cpojer

comment created time in 18 days

PR closed facebook/react-native

Reviewers
Remove duplicate local-cli/cli.js file CLA Signed Type: Removal

Summary

This PR remove unused local-cli/cli.js file and removes it from package.json. The same file can be found in ROOT_DIRECTORY/cli.js and it is exported in the package.json file too

Changelog

[JavaScript] [Removed] - Unused and duplicate file

Test Plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->

+0 -19

4 comments

2 changed files

ecreeth

pr closed time in 18 days

pull request commentfacebook/react-native

Remove duplicate local-cli/cli.js file

Thank you for the PR! When we removed this the last time some external tooling broke because it was requiring this file from RN. Since it’s a very small file, we decided to keep it.

ecreeth

comment created time in 18 days

PR closed facebook/relay

[Do not land] Remove fast-glob CLA Signed

See https://www.internalfb.com/intern/diff/D21428538

+14 -48

4 comments

4 changed files

cpojer

pr closed time in 19 days

pull request commentfacebook/relay

[Do not land] Remove fast-glob

Thank you so much for giving it a try <3

I'll land the internal version of this change after somebody approves it.

cpojer

comment created time in 19 days

Pull request review commentfacebook/relay

[Do not land] Remove fast-glob

 const WatchmanClient = require('../core/GraphQLWatchmanClient');  const crypto = require('crypto'); const fs = require('fs');+const glob = require('glob');

I assume it doesn't matter but I don't know.

cpojer

comment created time in 19 days

pull request commentfacebook/relay

[Do not land] Remove fast-glob

Let's try without flat map.

@alloy do you know how to best verify this code doesn't break anything? We don't use this code path at fb 🤷‍♂️

cpojer

comment created time in 19 days

push eventcpojer/relay

cpojer

commit sha 95f75e8fb1bdbb0a84da5ef5e123b4e8781ef359

Remove fast-glob

view details

push time in 19 days

PR opened facebook/relay

[Do not land] Remove fast-glob

See https://www.internalfb.com/intern/diff/D21428538

+14 -48

0 comment

4 changed files

pr created time in 19 days

push eventcpojer/relay

cpojer

commit sha de8cd5a264ad3ca9e479c7b69c6ca6a416443187

Remove fast-glob

view details

push time in 19 days

fork cpojer/relay

Relay is a JavaScript framework for building data-driven React applications.

https://relay.dev

fork in 19 days

PR merged facebook/jest

chore: fix date and heading in blog post cla signed

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

<!-- Please remember to update CHANGELOG.md in the root of the project if you have not done so. -->

Summary

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Test plan

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

+1 -3

0 comment

1 changed file

SimenB

pr closed time in 20 days

push eventfacebook/jest

Simen Bekkhus

commit sha 8cc7492c269561fb8bddbb6d50ca55821391cf19

chore: fix date and heading in blog post (#9977)

view details

push time in 20 days

push eventfacebook/jest

Christoph Nakazawa

commit sha 9c832f11c8721abd7f14ee0bd77fa2586f5659b7

Add Jest 26 blog post (#9950)

view details

push time in 20 days

PR merged facebook/jest

Add Jest 26 blog post cla signed

Jest 26, yeah!

+79 -0

2 comments

1 changed file

cpojer

pr closed time in 20 days

push eventcpojer/jest

cpojer

commit sha 5f9a0468e626964134392e8e85f347e9ebf79a0b

Updates

view details

push time in 20 days

push eventcpojer/jest

Christoph Nakazawa

commit sha bc844800c7eaa976298b494682f0c753ad1b2220

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 20 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 1d4ed4def5a86e213bcf4f43238b6760fc1cdc9b

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 20 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 2caee7c2a2f8c73bc982bd50abf1876a5314957e

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 20 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 1165de35cf12c3c6b2c3fb26a385e1b216281288

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 21 days

PR closed jest-community/jest-watch-typeahead

Update dependencies

Update to latest major versions.

+741 -595

2 comments

2 changed files

cpojer

pr closed time in 21 days

pull request commentjest-community/jest-watch-typeahead

Update dependencies

oh lol, let's merge https://github.com/jest-community/jest-watch-typeahead/pull/35 instead. It's the same, but better…

cpojer

comment created time in 21 days

PR opened jest-community/jest-watch-typeahead

Update dependencies

Update to latest major versions.

+741 -595

0 comment

2 changed files

pr created time in 21 days

push eventcpojer/jest-watch-typeahead

cpojer

commit sha 05dacaf997659f57328a2093bceca5c86e910b4d

Update dependencies

view details

push time in 21 days

fork cpojer/jest-watch-typeahead

Jest watch plugin for filtering test by file name or test name

fork in 21 days

push eventcpojer/jest

Simen Bekkhus

commit sha ea04be53b3b129a6c826100491427287d1e856ff

chore: another try at fixing test-utils dependency

view details

Simen Bekkhus

commit sha cab5c395eec8671814cecc79a94c71e5d3a43c71

chore: bump dated dependencies (#9951)

view details

Simen Bekkhus

commit sha 1cc205c274defb24f8b827b8a0c53c161c79d106

chore: remove dependency on `realpath-native` (#9952)

view details

Michael Wu

commit sha b6052e02e7de30a76e98d04bf48d3437d0091408

Update jest-phabricator documentation (#8662)

view details

Daniel Morrison

commit sha 3078172822bce962e73dc12b22290f34605646df

Updated config docs with default transform value (#8583) * Updated config docs - transform I've added a default option to clear up any confusion, hopefully that will make it more obvious how it should be added back in when additional transformers are added. * Updated change log for #8583 * Update docs/Configuration.md Co-Authored-By: Tim Seckinger <seckinger.tim@gmail.com> * Update Configuration.md * transform is an object instead of array - fixing. * --amend * update versioned docs Co-authored-by: Tim Seckinger <seckinger.tim@gmail.com> Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

view details

Simen Bekkhus

commit sha 42f920c1d117718d5ea6f34a5fe0cf1560bb6acc

chore: update ts-eslint (#9953)

view details

Tim Seckinger

commit sha 7a3c9977847cc9fafed6f6662289f3c35e44e0c6

jest-circus: throw if a test / hook is defined asynchronously (#8096)

view details

Yusuke Iinuma

commit sha 2e8f8d5d22fe70a11d5ce407f573078ebaca6b47

fix: handle `null` being passed to `createTransformer` (#9955)

view details

sai umesh

commit sha 4216b862c91ff80fc73805ae0f603db2c5c085fb

updated docs regarding testSequencer (#9174)

view details

Clark

commit sha 5a16415ec46d2372504cc2951ed42811e3cb6630

docs: Updated Testing Frameworks guide with React; make it generic (#9106) * Add Jest work with "testing-library/react" to Framework Guides * update frameworks guide to be generic * add changelog * use link to example docs Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

view details

Orta

commit sha 2c7682c27d9fe319bde13432b9ce1016c13d2786

Update index.js (#9095)

view details

Simen Bekkhus

commit sha d7f3427f5caa366634575be4a7a885e7769d42a7

chore: rename LolexFakeTimers to ModernFakeTimers (#9960)

view details

Simen Bekkhus

commit sha 71631f6bf9ccf8937f02a5ecfb64b62712b86c19

feat: add new 'modern' implementation of Fake Timers (#7776)

view details

Simen Bekkhus

commit sha 8147af1a898c8348d2985fff50f101aa8fca44e4

chore: improve error on module not found (#9963)

view details

Simen Bekkhus

commit sha c665f229e7abbec25a6e35ecea4aaf5defa24ae3

feat: add `createMockFromModule` to replace `genMockFromModule` (#9962)

view details

Simen Bekkhus

commit sha 2bac04ffb8e533d12a072998da5c3751a41b796f

v26.0.0-alpha.1

view details

Simen Bekkhus

commit sha 5d1be035cc7b12a25010941953a88fe3c20d0984

chore: fix windows CI (#9964)

view details

Rubén Norte

commit sha 968a301902796a5082b0119b82a6a996a20e1448

Fix invalid re-run of tests in watch mode (#7347) * Add failing e2e test * Stop re-running tests when mtime has not changed * fix test * fix copyright * adjust file accessed check * bring back reading fileMetadata from async callback Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

view details

Tim Seckinger

commit sha e8e8146ef6feacc56f9153a16c69f627cfa34d49

align circus with jasmine's top-to-bottom execution order (#9965)

view details

Simen Bekkhus

commit sha 68d12d59d37369ffd44169b15e09a090f9bbb635

chore: skip broken test on windows (#9966)

view details

push time in 21 days

Pull request review commentfacebook/jest

Add Jest 26 blog post

+---+title: Jest 26: Tick Tock+author: Christoph Nakazawa+authorURL: http://twitter.com/cpojer+authorFBID: 100000023028168+---++# Jest 26: Tick Tock++When we started rebuilding Jest five years ago our goal was to provide a batteries-included zero-configuration test runner that is approachable for beginners, extensible for almost all testing use cases and scalable to large projects. One of the most important releases was [Jest 15](https://jestjs.io/blog/2016/09/01/jest-15) which tied all the bits and pieces together and provided great defaults that allowed people to install and run Jest often without any setup. However, this approach has a big downside as Jest installs a lot of dependencies into your projects that you may not need.++We are now beginning to address this shortcoming and are working on reducing Jest’s install size while keeping it approachable and extensible. We have made the following breaking changes in Jest 26:++<!--truncate-->++* `[expect, jest-mock, pretty-format]` Remove `ES5` build files with a new minimum of support of ES2015 (Node 8) which were only used for browser builds ([#9945](https://github.com/facebook/jest/pull/9945))+* `[jest-config, jest-resolve]` Remove support for `browser` field ([#9943](https://github.com/facebook/jest/pull/9943))+* TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823))++With the above changes Jest 26 is now 4 MiB smaller than Jest 25.5.4 (53 → 49 MiB). Please keep in mind that many dependencies like Babel are likely already part of your project. Jest's own size was reduced by 1.2 MiB (4.3 -> 3.1 MiB).++While this is a good start, it isn’t enough to make Jest meaningfully leaner. We are planning on gradually reducing Jest's and its dependency tree size by about 70%. Most of the changes to reduce Jest’s default setup will be small breaking changes and we want to bring the community with us as much as possible. Therefore we will make the following changes in Jest 27 and Jest 28 using a [“Tick-Tock" release process](https://en.wikipedia.org/wiki/Tick%E2%80%93tock_model):

It seems realistic if we remove jsdom, jasmine and Babel eventually.

cpojer

comment created time in 21 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 949d91e64092b7497d138f8a8fd108fa71ea473a

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Tim Seckinger <seckinger.tim@gmail.com>

view details

push time in 21 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 6abe49bedc1afa8065eff8f136908888cc2813db

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Tim Seckinger <seckinger.tim@gmail.com>

view details

push time in 21 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 5237c5169a24afd6c7af10a2b5bb2eab99497757

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Tim Seckinger <seckinger.tim@gmail.com>

view details

push time in 21 days

push eventcpojer/jest

Christoph Nakazawa

commit sha a0e016fb7b932514d04dfc2f194270997cea5afe

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Tim Seckinger <seckinger.tim@gmail.com>

view details

push time in 21 days

pull request commentfacebook/jest

Remove es5 builds

@skovhus thank you for your contribution to Jest all those years ago. It was very useful when Jest was still gaining adoption. Nowadays everyone is using a bundler so they can compile these themselves.

cpojer

comment created time in 21 days

Pull request review commentfacebook/metro

[Fix] `DependencyGraph.resolveDependency` resolves to the same module when imported from `..`

 class DependencyGraph extends EventEmitter {     const isPath =

It's short-circuiting whether to use a "global" cache or a cache that's relative to the current path. At Facebook all module ids are global and engineers require them like require('MyModule') without a path. This code here optimizes the common use case of requiring a global module.

raejin

comment created time in 21 days

pull request commentbabel/babel

[helpers] Add a private function name within `createSuper`

@nicolo-ribaudo should have already been enabled: Screen Shot 2020-05-04 at 21 00 31

cpojer

comment created time in 21 days

pull request commentbabel/babel

[helpers] Add a private function name within `createSuper`

Somehow I can't locally run the tests on my Facebook company laptop, possibly related to some watchman and Jest setup issue. Any chance you could update the test? 😬

cpojer

comment created time in 21 days

pull request commentbabel/babel

Fix evaluation order with object spread, 2

We are using the new experimental JSX transform.

jridgewell

comment created time in 21 days

pull request commentbabel/babel

Fix evaluation order with object spread, 2

Could we not move more stuff into the helper? I don't know why empty objects need to be created so much and then passed around.

jridgewell

comment created time in 22 days

pull request commentbabel/babel

Fix evaluation order with object spread, 2

I can confirm that this change increases our app's size in React Native by about 60k which is an unfortunate regression.

jridgewell

comment created time in 22 days

PR opened babel/babel

[helpers] Add a private function name within `createSuper`
Q A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link No
Any Dependency Changes? No
License MIT

The createSuper helper was changed sometime between 7.4 and 7.9 to add a new private function within createSuper. We noticed in a large codebase that when a custom error instance gets thrown (like throw new class CustomError extends Error {}), the top of the stack frame blames to this internal function instead of the callsite. In this diff I propose adding a function name so that it isn't anonymous and can be filtered out by error reporting systems (when using source maps correctly). This diff should only add one byte in minified output for users of the ES2015 class transform.

+1 -1

0 comment

1 changed file

pr created time in 22 days

push eventcpojer/babel

cpojer

commit sha 6eb0a927318cad84ed641b2249d5a8e56dae624c

[helpers] Add a private function name within `createSuper`

view details

push time in 22 days

push eventcpojer/babel

Shriram Balaji

commit sha ecad667dda7d8bbc8594df0a36d0a68f3eacb21b

Fix optional method chaining in derived classes (#10694)

view details

Nicolò Ribaudo

commit sha f71338baf93ad483cf5c48be4f1573ceac8f88ac

E2E test Babel with itself before publishing (#10569) * Add e2e test using Babel itself * Make checks run again

view details

Huáng Jùnliàng

commit sha ce070ce42261fa3d537fe5a87a54f26635656c3e

bump @babel/* dev dependencies (#10648) * bump @babel/* dev dependencies * chore: align version to @babel/runtime * chore: bump to 7.7.1 * chore: bump to 7.7.2

view details

Huáng Jùnliàng

commit sha 7633f094793e2bffc82f1c4f4036fdbf30418700

Babel should not silently remove unknown options after command… (#10698) * chore: add test case * chore: bump commander to 4.0.1 * fix: let commander.js throw on unknown options after args

view details

Jaideep Bhoosreddy

commit sha 67ea7f4b4da9726d66982258a64c001481b7cda5

Implement PR workflow for running test262 on babel PRs (#10579) * Implement PR workflow with test262 * revisions

view details

ZYSzys

commit sha 1d1101eb7c8d89a2179b098f6dd131b4b479020a

Add missing flow type to babel-cli for consistency (#10692)

view details

Jaideep Bhoosreddy

commit sha 433b6ba3a41c6715bd3638b243502d51304555a2

Ignore PR job on master branch (#10702)

view details

Huáng Jùnliàng

commit sha e1839e5ec9c10ffadac51aa58fbc1e6753c6b27f

Circumvent typeof transform for umd build template (#10701) * add test case * fix: circumvent typeof transform * chore: update test fixtures

view details

Kai Cataldo

commit sha 15b0283650581c100da7fc6571df58c1ceee425b

view details

Henry Zhu

commit sha 13feb7278e5c19c7e1b8d9177447525088e34e53

init

view details

Henry Zhu

commit sha a48f2e209cc925de6afaac2e3b08770ee0f008e8

fix bug with config, use other way of specifying severity

view details

Henry Zhu

commit sha 5706f0531ba70d62f64b9314e31ba176525f6a00

1.0.1

view details

Bo Borgerson

commit sha bfa69bbdb63e44d95afdfb7586c7bfb214c83990

Add the "space-infix-ops" rule (babel/eslint-config-babel#1) Require whitespace around infix operators. The babel code base already mostly satisfies this. Nice to keep it that way. This is used by Lerna, too.

view details

Henry Zhu

commit sha b95c7aa5568861ec6114ec6f2f4ce7e5a30fd72c

1.0.2

view details

Daniel Tschinder

commit sha edcf1b59dd7022a01c18560acb3db58709e863b2

Exchange flow plugin with new one (babel/eslint-config-babel#2) * Change to eslint-plugin-flowtype * Use new plugin * Make dependencies peerDependencies * Readd babel-eslint

view details

Henry Zhu

commit sha c88f9033748e4176647b444e7927b22da3c91497

readme [skip ci]

view details

Daniel Tschinder

commit sha 978f3392c5bc5cfdbb3683ea93d06aaed0a26b12

Do not allow trailing spaces (babel/eslint-config-babel#3)

view details

Daniel Tschinder

commit sha 0f877648277526795c5c6b2c6de3a20c835db8bd

Ensure unix line endings (babel/eslint-config-babel#4)

view details

Henry Zhu

commit sha c3bc500240b3df6b8281bc7e9ced08a084ce9676

update info/links

view details

Henry Zhu

commit sha b2b1416fbcf7dad0e920d1c05e49b192f225f7b1

2.0.0

view details

push time in 22 days

pull request commentbabel/babel

Fix evaluation order with object spread, 2

When upgrading a large codebase from 7.9.4 to 7.9.6 I notice that a lot of code now receives extra spread calls: babelHelpers.objectSpread2(babelHelpers.objectSpread2({}, sharedData), {}, {…}).

Is this duplication expected? I see a lot of empty object literals and duplicated function calls in the output which looks inefficient to me.

jridgewell

comment created time in 22 days

push eventfacebook/jest

Rubén Norte

commit sha 968a301902796a5082b0119b82a6a996a20e1448

Fix invalid re-run of tests in watch mode (#7347) * Add failing e2e test * Stop re-running tests when mtime has not changed * fix test * fix copyright * adjust file accessed check * bring back reading fileMetadata from async callback Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

view details

push time in 22 days

PR merged facebook/jest

Fix invalid re-run of tests in watch mode cla signed

Summary

Fixes #7124. Watch mode shouldn't trigger a new test run when only the access time of the file has been modified.

Test plan

Added e2e tests.

+90 -1

6 comments

3 changed files

rubennorte

pr closed time in 22 days

issue closedfacebook/jest

Changing a file's access time re-runs tests in watch mode

<!-- Love Jest? Please consider supporting our collective: 👉 https://opencollective.com/jest/donate -->

🐛 Bug Report

When running jest --watch, changing a file's access time triggers a test re-run.

To Reproduce

Steps to reproduce the behavior:

  • Start jest --watch
  • Change the access time for a file and nothing else. Example: touch -a src/components/SomeComponent.js

Expected behavior

I don't expect Jest to re-run tests when only the access time changes. I would expect it to re-run tests when the modified time changes or new files are added, etc.

Link to repl or repo (highly encouraged)

Please provide either a repl.it demo or a minimal repository on GitHub.

Issues without a reproduction link are likely to stall.

Run npx envinfo --preset jest

Paste the results here:


  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
  Binaries:
    Node: 8.11.4 - ~/.nvm/versions/node/v8.11.4/bin/node
    Yarn: 1.9.4 - /usr/local/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.4/bin/npm
  npmPackages:
    jest: ^23.1.0 => 23.1.0

The chokidar file watcher always changes access time shortly after a file is modified. I'm not sure why and I'm not sure how to turn it off. Since I use chokidar in a separate shell to run flow as I edit code, this causes my tests to always run twice.

closed time in 22 days

kumar303

pull request commentfacebook/jscodeshift

Make @babel/preset-env optional, drop support for Node 8 and below

Actually learned that optionalDependencies is only for deps that can fail to install, but they will still be installed. I changed it to peerDependencies which prints a warning, I think that's a good middle ground.

https://github.com/facebook/jscodeshift/commit/2256c1d38c117c85e4f4872ea2ec66abe2765d10

cpojer

comment created time in 22 days

push eventfacebook/jscodeshift

cpojer

commit sha 2256c1d38c117c85e4f4872ea2ec66abe2765d10

Actually use `peerDependencies`

view details

cpojer

commit sha 13bf8067f5a1fc1010247c78e8ac01c543d5dc2e

0.9.0

view details

push time in 22 days

push eventfacebook/jscodeshift

cpojer

commit sha edd9fecfd32776cbcc99245b543637a2eb01b69c

0.8.0

view details

push time in 22 days

push eventcpojer/jscodeshift

Christoph Nakazawa

commit sha 36c7e2e2480788dede21bd88e32530c30be8b563

Merge pull request #375 from cpojer/master

view details

cpojer

commit sha edd9fecfd32776cbcc99245b543637a2eb01b69c

0.8.0

view details

push time in 22 days

push eventfacebook/jscodeshift

cpojer

commit sha 9db8928d16c1c560da3c8da488149a91da91ce7f

Remove @babel/preset-env, drop support for Node 8 and below

view details

Christoph Nakazawa

commit sha 36c7e2e2480788dede21bd88e32530c30be8b563

Merge pull request #375 from cpojer/master

view details

push time in 22 days

PR merged facebook/jscodeshift

Make @babel/preset-env optional, drop support for Node 8 and below CLA Signed

@babel/preset-env is a very large dependency to determine which plugins to use in node. In this PR I'm making it optional, dropping support for Node 8 and below (which have been deprecated for years) and added common syntax transforms to make jscodeshift transforms run in Node 10+.

The behavior will be unchanged if @babel/preset-env is already part of node_modules, otherwise it needs to be installed by the user. This will be released as jscodeshift 0.8 to make it non-breaking.

+775 -413

0 comment

4 changed files

cpojer

pr closed time in 22 days

PR opened facebook/jscodeshift

Make @babel/preset-env optional, drop support for Node 8 and below

@babel/preset-env is a very large dependency to determine which plugins to use in node. In this PR I'm making it optional, dropping support for Node 8 and below (which have been deprecated for years) and added common syntax transforms to make jscodeshift transforms run in Node 10+.

The behavior will be unchanged if @babel/preset-env is already part of node_modules, otherwise it needs to be installed by the user. This will be released as jscodeshift 0.8 to make it non-breaking.

+775 -413

0 comment

4 changed files

pr created time in 22 days

push eventcpojer/jscodeshift

cpojer

commit sha 9db8928d16c1c560da3c8da488149a91da91ce7f

Remove @babel/preset-env, drop support for Node 8 and below

view details

push time in 22 days

push eventcpojer/jest

Christoph Nakazawa

commit sha d2d43e25db062fee5ae8a797eeefdb75a1415abd

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 22 days

push eventcpojer/jscodeshift

Mickael Zhang

commit sha 62f288885d066cb967257f92424d4fabcbaf0119

rename any to isMatch

view details

George Zahariev

commit sha d7631b4525a98c9010199494033d2daf190ccbed

Merge pull request #371 from mickaelzhang/update-mm-method Rename micromatch any to isMatch

view details

cpojer

commit sha 5885662920ed7a3077da22beed4a8f76743dd19c

Update npmignore

view details

cpojer

commit sha 4acfd61c02cc4c05dd8517b05eb87d02e4abac76

0.7.1

view details

cpojer

commit sha b8393f52decc0d88c1495df921519afeda0f58ee

Remove @babel/preset-env, drop support for Node 8 and below

view details

push time in 22 days

pull request commentfacebook/jest

Intercept process.stdout and process.stderr

What's the status of this PR?

SimenB

comment created time in 22 days

pull request commentfacebook/jest

fix: normalize path separator for rootDir replacement

What's the status of this PR?

SimenB

comment created time in 22 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 2b0ae8fe86a8a1f56d52f30a8e28af7c44798fce

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>

view details

push time in 22 days

push eventcpojer/jest

cpojer

commit sha 5c9b6f333e062422696e34d6d406375777b09514

Comments

view details

push time in 22 days

push eventfacebook/jest

Simen Bekkhus

commit sha 8147af1a898c8348d2985fff50f101aa8fca44e4

chore: improve error on module not found (#9963)

view details

push time in 22 days

PR merged facebook/jest

Reviewers
chore: improve error on module not found cla signed

<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory. -->

<!-- Please remember to update CHANGELOG.md in the root of the project if you have not done so. -->

Summary

I think it's a bit easier to grok

<!-- Explain the motivation for making this change. What existing problem does the pull request solve? -->

Test plan

Tests updated

<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. -->

+5 -4

0 comment

4 changed files

SimenB

pr closed time in 22 days

Pull request review commentfacebook/jest

Add Jest 26 blog post

+---+title: Jest 26: Tick Tock+author: Christoph Nakazawa+authorURL: http://twitter.com/cpojer+authorFBID: 100000023028168+---++# Jest 26: Tick Tock++When we started rebuilding Jest five years ago our goal was to provide a batteries-included zero-configuration test runner that is approachable for beginners, extensible for almost all testing use cases and scalable to large projects. One of the most important releases was [Jest 15](https://jestjs.io/blog/2016/09/01/jest-15) which tied all the bits and pieces together and provided great defaults that allowed people to install and run Jest often without any setup. However, this approach has a big downside as Jest installs a lot of dependencies into your projects that you may not need.++We are now beginning to address this shortcoming and are working on reducing Jest’s install size while keeping it approachable and extensible. We have made the following breaking changes in Jest 26:++<!--truncate-->++* `[expect, jest-mock, pretty-format]` Remove `es5` build files from with a new minimum of support of ES2015 (Node 8) - the es5 build files were only for browsers.  ([#9945](https://github.com/facebook/jest/pull/9945))+* `[jest-config, jest-resolve]` Remove support for `browser` field ([#9943](https://github.com/facebook/jest/pull/9943))+* TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823))++With the above changes Jest 26 is now 4 MiB smaller than Jest 25.5.4 (53 → 49 MiB). Please keep in mind that many dependencies like Babel are likely already part of your project. Jest's own size was reduced by 1.2 MiB (4.3 -> 3.1 MiB).++While this is a good start, it isn’t enough to make Jest meaningfully leaner. We are planning on gradually reducing Jest's and it's dependency tree size by about 70%. Most of the changes to reduce Jest’s default setup will be small breaking changes and we want to bring the community with us as much as possible. Therefore we will make the following changes in Jest 27 and Jest 28 using a [“Tick-Tock" release process](https://en.wikipedia.org/wiki/Tick%E2%80%93tock_model):++* Jest 27 will ship with a new test runner (`jest-circus`), new fake timers with Lolex and the node.js environment by default. `jest-jasmine2`, the previous FakeTimers implementation and `jsdom` will still be bundled so users can keep using them by changing one-line each in the configuration.+* Jest 28 will remove `jest-jasmine2`, FakeTimers and `jsdom` from the default distribution of Jest. The packages will still be actively maintained as part of the Jest project and be published separately. Users will need to install these packages to use them.++Upon upgrading to these major releases, Jest will guide you through the necessary changes. If you’d like to get ahead and migrate to the new architecture now you can upgrade to Jest 26 and add the following configuration options:++```+TODO Simen/jeysal: configuration example+```++## Other Breaking Changes in Jest 26++* Dropped support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423))+* `[jest-environment-jsdom]` Upgrade `jsdom` to v16 ([#9606](https://github.com/facebook/jest/pull/9606))+* `[jest-runtime]` Remove long-deprecated `require.requireActual` and `require.requireMock` methods ([#9854](https://github.com/facebook/jest/pull/9854))+* `[jest-haste-map]` Removed `providesModuleNodeModules` ([#8535](https://github.com/facebook/jest/pull/8535))+* `[jest-circus]` Fail tests if a test takes a done callback and have return values ([#9129](https://github.com/facebook/jest/pull/9129))+* `[jest-circus]` Throw a proper error if a test / hooks is defined asynchronously ([#8096](https://github.com/facebook/jest/pull/8096))+* ***TODO***++## Stay Safe++We are all currently experiencing an unprecedented time of uncertainty. If you are struggling financially, we would like to use [Jest’s OpenCollective fund](https://opencollective.com/jest) to help new and existing contributors. We have an existing [list of issues with a bounty](https://github.com/facebook/jest/issues?q=is%3Aissue+is%3Aopen+bounty+label%3A%22Has+Bounty%22) but are open to offering a bounty on any of our current open issues - you can mention that this issue should have a bounty in the issue or contact us privately via _x_.

Yeah I'm fine with that.

cpojer

comment created time in 22 days

Pull request review commentfacebook/jest

Add Jest 26 blog post

+---+title: Jest 26: Tick Tock+author: Christoph Nakazawa+authorURL: http://twitter.com/cpojer+authorFBID: 100000023028168+---++# Jest 26: Tick Tock++When we started rebuilding Jest five years ago our goal was to provide a batteries-included zero-configuration test runner that is approachable for beginners, extensible for almost all testing use cases and scalable to large projects. One of the most important releases was [Jest 15](https://jestjs.io/blog/2016/09/01/jest-15) which tied all the bits and pieces together and provided great defaults that allowed people to install and run Jest often without any setup. However, this approach has a big downside as Jest installs a lot of dependencies into your projects that you may not need.++We are now beginning to address this shortcoming and are working on reducing Jest’s install size while keeping it approachable and extensible. We have made the following breaking changes in Jest 26:++<!--truncate-->++* `[expect, jest-mock, pretty-format]` Remove `es5` build files from with a new minimum of support of ES2015 (Node 8) - the es5 build files were only for browsers.  ([#9945](https://github.com/facebook/jest/pull/9945))+* `[jest-config, jest-resolve]` Remove support for `browser` field ([#9943](https://github.com/facebook/jest/pull/9943))+* TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823))++With the above changes Jest 26 is now 4 MiB smaller than Jest 25.5.4 (53 → 49 MiB). Please keep in mind that many dependencies like Babel are likely already part of your project. Jest's own size was reduced by 1.2 MiB (4.3 -> 3.1 MiB).++While this is a good start, it isn’t enough to make Jest meaningfully leaner. We are planning on gradually reducing Jest's and it's dependency tree size by about 70%. Most of the changes to reduce Jest’s default setup will be small breaking changes and we want to bring the community with us as much as possible. Therefore we will make the following changes in Jest 27 and Jest 28 using a [“Tick-Tock" release process](https://en.wikipedia.org/wiki/Tick%E2%80%93tock_model):++* Jest 27 will ship with a new test runner (`jest-circus`), new fake timers with Lolex and the node.js environment by default. `jest-jasmine2`, the previous FakeTimers implementation and `jsdom` will still be bundled so users can keep using them by changing one-line each in the configuration.+* Jest 28 will remove `jest-jasmine2`, FakeTimers and `jsdom` from the default distribution of Jest. The packages will still be actively maintained as part of the Jest project and be published separately. Users will need to install these packages to use them.++Upon upgrading to these major releases, Jest will guide you through the necessary changes. If you’d like to get ahead and migrate to the new architecture now you can upgrade to Jest 26 and add the following configuration options:++```+TODO Simen/jeysal: configuration example+```++## Other Breaking Changes in Jest 26++* Dropped support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423))+* `[jest-environment-jsdom]` Upgrade `jsdom` to v16 ([#9606](https://github.com/facebook/jest/pull/9606))+* `[jest-runtime]` Remove long-deprecated `require.requireActual` and `require.requireMock` methods ([#9854](https://github.com/facebook/jest/pull/9854))+* `[jest-haste-map]` Removed `providesModuleNodeModules` ([#8535](https://github.com/facebook/jest/pull/8535))+* `[jest-circus]` Fail tests if a test takes a done callback and have return values ([#9129](https://github.com/facebook/jest/pull/9129))+* `[jest-circus]` Throw a proper error if a test / hooks is defined asynchronously ([#8096](https://github.com/facebook/jest/pull/8096))+* ***TODO***++## Stay Safe++We are all currently experiencing an unprecedented time of uncertainty. If you are struggling financially, we would like to use [Jest’s OpenCollective fund](https://opencollective.com/jest) to help new and existing contributors. We have an existing [list of issues with a bounty](https://github.com/facebook/jest/issues?q=is%3Aissue+is%3Aopen+bounty+label%3A%22Has+Bounty%22) but are open to offering a bounty on any of our current open issues - you can mention that this issue should have a bounty in the issue or contact us privately via _x_.

What's the best way to reach us privately? :D

cpojer

comment created time in 22 days

push eventcpojer/jest

Christoph Nakazawa

commit sha 993ba2c8e08bf62bb21dc9be97a63770035eacd4

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Orta <orta.therox+github@gmail.com>

view details

push time in 22 days

Pull request review commentfacebook/jest

Add Jest 26 blog post

+---+title: Jest 26: Tick Tock+author: Christoph Nakazawa+authorURL: http://twitter.com/cpojer+authorFBID: 100000023028168+---++# Jest 26: Tick Tock++When we started rebuilding Jest five years ago our goal was to provide a batteries-included zero-configuration test runner that is approachable for beginners, extensible for almost all testing use cases and scalable to large projects. One of the most important releases was [Jest 15](https://jestjs.io/blog/2016/09/01/jest-15) which tied all the bits and pieces together and provided great defaults that allowed people to install and run Jest often without any setup. However, this approach has a big downside as Jest installs a lot of dependencies into your projects that you may not need.++We are now beginning to address this shortcoming and are working on reducing Jest’s install size while keeping it approachable and extensible. We have made the following breaking changes in Jest 26:++<!--truncate-->++* `[expect, jest-mock, pretty-format]` Remove `build-es5` from all packages ([#9945](https://github.com/facebook/jest/pull/9945))+* `[jest-config, jest-resolve]` Remove support for `browser` field ([#9943](https://github.com/facebook/jest/pull/9943))+* TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823))++With these changes combined, Jest 26 is now X MiB smaller than Jest 25.5.4 (Y → Z MiB). While this is a good start, it isn’t enough to make Jest meaningfully leaner. Since most of the changes to reduce Jest’s default setup are breaking, we want to bring the community with us as much as possible. Therefore we will make the following changes in Jest 27 and Jest 28 using a [“Tick-Tock" release process](https://en.wikipedia.org/wiki/Tick%E2%80%93tock_model):++* Jest 27 will ship with a new test runner (`jest-circus`), new fake timers with Lolex and the node.js environment by default. `jest-jasmine2`, the previous FakeTimers implementation and `jsdom` will still be bundled so users can keep using them by changing one-line each in the configuration.+* Jest 28 will remove `jast-jasmine2`, FakeTimers and `jsdom` from the default distribution of Jest. The packages will still be actively maintained as part of the Jest project and be published separately. Users will need to install these packages to use them.++Upon upgrading to these major releases, Jest will guide you through the necessary changes. If you’d like to get ahead and migrate to the new architecture now you can upgrade to Jest 26 and add the following configuration options:++```+TODO Simen/jeysal: configuration example+```++## Other Breaking Changes in Jest 26++* Dropped support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423))+* `[jest-environment-jsdom]` Upgrade `jsdom` to v16 ([#9606](https://github.com/facebook/jest/pull/9606))+* `[jest-runtime]` Remove long-deprecated `require.requireActual` and `require.requireMock` methods ([#9854](https://github.com/facebook/jest/pull/9854))+* `[jest-haste-map]` Removed `providesModuleNodeModules` ([#8535](https://github.com/facebook/jest/pull/8535))+* `[jest-circus]` Fail tests if a test takes a done callback and have return values ([#9129](https://github.com/facebook/jest/pull/9129))+* `[jest-circus]` Throw a proper error if a test / hooks is defined asynchronously ([#8096](https://github.com/facebook/jest/pull/8096))+* ***TODO***++## Stay Safe++We are all currently experiencing an unprecedented time in recent history. If you were recently laid off because of the ongoing pandemic and are struggling, we are happy to support you using [Jest’s OpenCollective fund](https://opencollective.com/jest). Check out this list of tasks and comment on the ones you’d like to work on to get started.

I like this, that's great, thank you.

cpojer

comment created time in 22 days

push eventcpojer/jest

Christoph Nakazawa

commit sha fb64d07e7756e79fab537494b05aeb9ced836430

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Orta <orta.therox+github@gmail.com>

view details

push time in 22 days

push eventcpojer/jest

Christoph Nakazawa

commit sha a5fe0bd348469da87fab13401b0de5150e35411b

Update website/blog/2020-05-06-jest-26.md Co-authored-by: Orta <orta.therox+github@gmail.com>

view details

push time in 22 days

delete branch facebook/jest

delete branch : orta-patch-1

delete time in 23 days

more