profile
viewpoint
Mark Murphy commonsguy CommonsWare https://commonsware.com Author of several books on Android app development (https://commonsware.com)

commonsguy/cw-omnibus 5147

Source code to omnibus edition of _The Busy Coder's Guide to Android Development_

commonsguy/cw-advandroid 1469

Source Code to _The Busy Coder's Guide To Advanced Android Development_

commonsguy/cw-android 1160

Source Code to _The Busy Coder's Guide To Android Development_

commonsguy/cwac-merge 597

CommonsWare Android Components: MergeAdapter

commonsguy/cwac-saferoom 554

CWAC-SafeRoom: A Room<->SQLCipher for Android Bridge

commonsguy/cwac-wakeful 497

CommonsWare Android Components: WakefulIntentService

commonsguy/cwac-richedit 393

CWAC RichEditText component

commonsguy/cwac-security 286

CWAC-Security: Helping You Help Your Users Defend Their Data

commonsguy/cwac-netsecurity 241

CWAC-NetSecurity: Simplifying Secure Internet Access

commonsguy/cwac-anddown 231

CWAC AndDown: Markdown Utility Library

PR closed commonsguy/cwac-document

Replace support lib dependencies with AndroidX

This cwac-document was flagged by can-i-drop-jetifier plugin due to use of the support-annotations library. This PR migrates to Android X annotations with no functional changes.

⚠️ I had issues with running the instrumentation tests (IOTests) failed with Test running failed: Process crashed. - wonder if I'm missing something simple?

+30 -34

3 comments

8 changed files

scottyab

pr closed time in a month

pull request commentcommonsguy/cwac-document

Replace support lib dependencies with AndroidX

I made the general fixes that you requested, though I elected to do that directly rather than incorporate your PR.

I had issues with running the instrumentation tests (IOTests) failed with Test running failed: Process crashed. - wonder if I'm missing something simple?

I ran into the same problem. The tests are a bit unusual, in that they use FileProvider. Not only did I need to migrate the code and tests to use the AndroidX FileProvider, I also needed to update the test manifest to reference the AndroidX FileProvider in the <provider> element.

Your changes, along with an unrelated bug fix, are in v0.5.0.

Thanks for the kick in the posterior to get this updated! :grin:

scottyab

comment created time in a month

issue closedcommonsguy/cwac-document

Getting document info may crash in rare cases

Stack trace:

java.lang.NullPointerException: Attempt to invoke interface method 'void android.database.Cursor.close()' on a null object reference
        at com.commonsware.cwac.document.DocumentsContractApi1.queryForString(DocumentsContractApi1.java:58)
        at com.commonsware.cwac.document.DocumentsContractApi1.getName(DocumentsContractApi1.java:31)
        at com.commonsware.cwac.document.SingleLegacyDocumentFile.getName(SingleLegacyDocumentFile.java:55)

Steps to reproduce:

  1. Fire intent with ACTION_GET_CONTENT (example here) on emulator with API 21
  2. Choose any file from Gallery or Music app

In this case resolver.query() throws SecurityException if an app doesn't have READ_EXTERNAL_STORAGE permission (mentioned in comments to this question), so the cursor is null.

I suppose a simple null-check in finally would be enough to fix it.

Thanks for a nice library! :)

closed time in a month

gmk57

issue commentcommonsguy/cwac-document

Getting document info may crash in rare cases

Since I needed to make another change (finally moving to AndroidX!), I elected to tuck this fix in there. v0.5.0 should address this problem. Thanks for pointing it out!

gmk57

comment created time in a month

release commonsguy/cwac-document

v0.5.0

released time in a month

created tagcommonsguy/cwac-document

tagv0.5.0

CWAC-Document: A Better DocumentFile

created time in a month

push eventcommonsguy/cwac-document

Mark Murphy

commit sha d3a7761df583a69ddc3f0222d2bfa743476478de

update Kotlin, Gradle, AGP versions

view details

Mark Murphy

commit sha 6b3958d9e4632d23aa31cc8c7474044706da0eda

upgrade to AndroidX dependencies

view details

Mark Murphy

commit sha e3276f5f9517e9fa478e4b4fb748a4cac41b6411

upgrade SDK versions

view details

Mark Murphy

commit sha 6dd8bdcebbd51229c4267b8fa3ff9fdf25753358

add null checks in finally

view details

Mark Murphy

commit sha d5a7e56e846faa073023deebdfc2e0cac6c2a944

updates for v0.5.0

view details

push time in a month

pull request commentcommonsguy/cwac-document

Replace support lib dependencies with AndroidX

I'll try to look into this on the weekend — thanks!

scottyab

comment created time in a month

issue commentcommonsguy/cwac-presentation

Recycleview list item is not scrolling on external display.Touch is blocking.

Can you explain, in detail, why you think my library is doing something wrong? For example, do you have touch input working when using this external display in other ways?

NarendraKr

comment created time in a month

issue commentcommonsguy/cwac-presentation

Recycleview list item is not scrolling on external display.Touch is blocking.

External displays do not provide touch input. External displays are for output only.

NarendraKr

comment created time in a month

pull request commentsqlcipher/sqlcipher-android-tests

update support tests for SQLCipher 4.4.0

Sorry — when I contributed the SupportSQLite* code, I didn't want to change the existing tests, since I am a bit of an interloper in the code base. Trying to consolidate them felt a bit risky and felt a lot like going into somebody's house and rearranging their furniture... :grinning:

brodybits

comment created time in 2 months

issue openedkcrimi/ToolTipDialog

Publish License Info

This library seems nice and might fit the need for a project that I am working on. However, I cannot find definitive information about the software license under which it is published:

  • The Kotlin files do not have any sort of license header block
  • I do not see a LICENSE file
  • No licensing information is in the project README
  • The Android Arsenal listing says it is GPLv3
  • The bintray.gradle file says that it is Apache License 2.0

Ideally, it would be clearer what license you are publishing this library under, so we can make sure that we conform to your license requirements.

Thanks for considering this!

created time in 3 months

more