This cwac-document was flagged by can-i-drop-jetifier plugin due to use of the support-annotations library. This PR migrates to Android X annotations with no functional changes.

⚠️ I had issues with running the instrumentation tests (IOTests) failed with Test running failed: Process crashed. - wonder if I'm missing something simple?

I made the general fixes that you requested, though I elected to do that directly rather than incorporate your PR.

I had issues with running the instrumentation tests (IOTests) failed with Test running failed: Process crashed. - wonder if I'm missing something simple?

I ran into the same problem. The tests are a bit unusual, in that they use FileProvider. Not only did I need to migrate the code and tests to use the AndroidX FileProvider, I also needed to update the test manifest to reference the AndroidX FileProvider in the <provider> element.

Your changes, along with an unrelated bug fix, are in v0.5.0.

Thanks for the kick in the posterior to get this updated! :grin:

Stack trace:

java.lang.NullPointerException: Attempt to invoke interface method 'void android.database.Cursor.close()' on a null object reference
        at com.commonsware.cwac.document.DocumentsContractApi1.queryForString(DocumentsContractApi1.java:58)
        at com.commonsware.cwac.document.DocumentsContractApi1.getName(DocumentsContractApi1.java:31)
        at com.commonsware.cwac.document.SingleLegacyDocumentFile.getName(SingleLegacyDocumentFile.java:55)

Steps to reproduce:

1. Fire intent with ACTION_GET_CONTENT (example here) on emulator with API 21
2. Choose any file from Gallery or Music app

In this case resolver.query() throws SecurityException if an app doesn't have READ_EXTERNAL_STORAGE permission (mentioned in comments to this question), so the cursor is null.

I suppose a simple null-check in finally would be enough to fix it.

Thanks for a nice library! :)

Since I needed to make another change (finally moving to AndroidX!), I elected to tuck this fix in there. v0.5.0 should address this problem. Thanks for pointing it out!

I'll try to look into this on the weekend — thanks!

Can you explain, in detail, why you think my library is doing something wrong? For example, do you have touch input working when using this external display in other ways?

External displays do not provide touch input. External displays are for output only.

Sorry — when I contributed the SupportSQLite* code, I didn't want to change the existing tests, since I am a bit of an interloper in the code base. Trying to consolidate them felt a bit risky and felt a lot like going into somebody's house and rearranging their furniture... :grinning:

This library seems nice and might fit the need for a project that I am working on. However, I cannot find definitive information about the software license under which it is published:

• The Kotlin files do not have any sort of license header block
• I do not see a LICENSE file
• No licensing information is in the project README
• The Android Arsenal listing says it is GPLv3
• The bintray.gradle file says that it is Apache License 2.0

Ideally, it would be clearer what license you are publishing this library under, so we can make sure that we conform to your license requirements.

Thanks for considering this!