profile
viewpoint
Chris Lee clee Panasonic North America Denver https://c133.org/ Open-source hacker & custom keyboard enthusiast

cbiffle/pushr-for-android 5

[obsolete] Simple, easy way to push photos to Flickr from your Android-powered phone. Based loosely on the iPhone program of the same name.

clee/channon 3

A really simple continuous integration system

clee/crankshaft 3

REST API on top of node-maildir (using express)

clee/arborealize 2

Creates an HTML5+CSS3 page with recursive directory contents.

clee/dna 2

My genome

clee/boilerplate 1

Simple flask app to test deployment scripts

clee/clee.github.io 1

My github pages repo

airencracken/gobbs 0

A Go BBS, gobbs

clee/50mm 0

Create minimal HTML5 image galleries from S3 buckets.

clee/agealyzer-rust 0

Rust implementation of my agealyzer tool

issue commentgo-gitea/gitea

Using URL anchors in markdown docs repo's vs 'user-content' prefix.

Please show an example on https://try.gitea.io.

aschrijver

comment created time in 5 minutes

Pull request review commentgo-gitea/gitea

[Vendor] Update go-redis to v8.4.0

 func NewRedisByteFIFO(config RedisByteFIFOConfiguration) (*RedisByteFIFO, error) 		queueName: config.QueueName, 	} 	fifo.client = nosql.GetManager().GetRedisClient(config.ConnectionString)-	if err := fifo.client.Ping().Err(); err != nil {+	if err := fifo.client.Ping(context.Background()).Err(); err != nil {

Docs recommend a global var ctx = context.TODO(), maybe it would be more performant to do that instead of recreating that context every time?

6543

comment created time in 18 minutes

push eventnolanlawson/pinafore

Nolan Lawson

commit sha c98b5a93d3c3a48d19b10fda15f54a27a3d8441d

fix test

view details

push time in 26 minutes

pull request commentgo-gitea/gitea

[Vendor] Update Batch 2020-11

:rocket:

6543

comment created time in 26 minutes

push eventnolanlawson/pinafore

Nolan Lawson

commit sha 0da4f86f27fbced04d8cfba1ff3b8d410b0748fb

update readme [skip ci]

view details

push time in 31 minutes

issue commentgo-gitea/gitea

Avatars need thumbnail versions

And https://github.com/go-gitea/gitea/pull/13649 makes avatars actually cachable by removing the redirects. This should pretty much solve this performance issue in most cases, but actual image resizing would still be nice to have.

mrsdizzie

comment created time in 32 minutes

push eventnolanlawson/pinafore

Nolan Lawson

commit sha a2503a5df954bf2f98d1eb9c5a859448a43c679c

fix some missing translations

view details

push time in 34 minutes

pull request commentgo-gitea/gitea

Direct avatar rendering

This is ready for review now. Turns out org avatars were already working and caching, I was just confused by their different URL scheme (they use /avatars/num instead of storage paths).

I don't think there is anything left to clean up from the old avatar code, bits and pieces are still in use in some places.

silverwind

comment created time in 39 minutes

pull request commentgo-gitea/gitea

Direct avatar rendering

make fmt missing?

silverwind

comment created time in 40 minutes

pull request commentnolanlawson/pinafore

fix: extract English UI strings into separate file

Measured the perf, and formatIntl doesn't really add much overhead. Even on 4x slowdown, just a few milliseconds here and there. It seems trivial.

5kB added to the base bundle size, not bad.

I also added some (fairly bad) French translations, but I'm just trying to get one other language supported so I can start testing.

This will undoubtedly not be the final design, but right now this is pretty good for testing and to at least unblock people who want to add translations.

LOCALE=fr yarn build will build a French version.

nolanlawson

comment created time in 44 minutes

PR opened go-gitea/gitea

Update go-redis to v8.4.0

as title

+15166 -4933

0 comment

136 changed files

pr created time in an hour

issue closedgo-gitea/gitea

SIGSEGV with SSH built-in server

<!-- 1. Please speak English, this is the language all of us can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/NsatcWJ) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. -->

Hi :wave:

  • Gitea version (or commit ref): v1.7.0
  • Git version: v2.11.0
  • Operating system: Debian 9
  • Database (use [x]):
    • [X] PostgreSQL
    • [ ] MySQL
    • [ ] MSSQL
    • [ ] SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • [ ] Yes (provide example URL)
    • [ ] No
    • [X] Not relevant
  • Log gist:
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x872bbc]
goroutine 853 [running]:
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh.newPacketCipher(0x2808d77, 0x1, 0x1, 0x2808d78, 0x1, 0x1, 0x2808d79, 0x1, 0x1, 0xc0026c6040, ...)
        /go/src/code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh/transport.go:245 +0x15c
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh.(*transport).prepareKeyChange(0xc0000b87e0, 0xc001285500, 0xc000908200, 0xc001285500, 0xc00258ac00)
        /go/src/code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh/transport.go:80 +0xeb
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).enterKeyExchange(0xc0000f62c0, 0xc00233b800, 0x588, 0x588, 0x1, 0x1)
        /go/src/code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh/handshake.go:598 +0x3d0
code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh.(*handshakeTransport).kexLoop(0xc0000f62c0)
        /go/src/code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh/handshake.go:301 +0x1d6
created by code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh.newServerTransport
        /go/src/code.gitea.io/gitea/vendor/golang.org/x/crypto/ssh/handshake.go:143 +0x105

Description

When using the built-in SSH server, the application is crashing when SSH connections occurred.

It was already the case on the v1.6.X branch. If needed, I can run further tests on my own.

Thanks, bye :bow:

EDIT : Maybe related to #5460 (?). The OP didn't precise whether its instance crashed or not though.

closed time in an hour

HorlogeSkynet

issue commentgo-gitea/gitea

SIGSEGV with SSH built-in server

It looks like I can't reproduce as of 1.12.6. Although, I haven't tried it in a long time so it might have been fixed before.

Bye, closing here :wave:

HorlogeSkynet

comment created time in an hour

push eventnolanlawson/pinafore

Nolan Lawson

commit sha 3102b19e6943a1384cad56861116d32074a45da3

measure perf

view details

Nolan Lawson

commit sha 6ad7ee0a70c2613dac6981a87f6d9df76faa97c6

start on french

view details

Nolan Lawson

commit sha b144871a221b66d8368ff4b7a96dd232d0aad3c8

more work on french

view details

Nolan Lawson

commit sha de1c83cbd9ae3468c0640473dd95259589ff10ed

more french

view details

Nolan Lawson

commit sha a9f0ee72089309d8a52e5a97093a766ca44f2c69

more french

view details

Nolan Lawson

commit sha 75d788adfddd85ae2ea2a78507183c30bcf3ab32

finish french

view details

push time in an hour

push eventnolanlawson/pinafore

Nolan Lawson

commit sha 038ee33078a943eb314eb39d1123971beff87d46

fix typo

view details

Nolan Lawson

commit sha b93cff77bd1cedda4a5eccbf149204b0b27f4b58

fix english

view details

push time in an hour

issue openedgo-gitea/gitea

Using URL anchors in markdown docs repo's vs 'user-content' prefix.

<!-- NOTE: If your issue is a security concern, please send an email to security@gitea.io instead of opening a public issue -->

<!-- 1. Please speak English, this is the language all maintainers can speak and write. 2. Please ask questions or configuration/deploy problems on our Discord server (https://discord.gg/gitea) or forum (https://discourse.gitea.io). 3. Please take a moment to check that your issue doesn't already exist. 4. Please give all relevant information below for bug reports, because incomplete details will be handled as an invalid report. -->

  • Gitea version (or commit ref): 1.12.3 (Codeberg)

Description

When using anchors within the same Markdown doc, then upon save everything works fine. The anchors are processed and the prefix user-content- is added.

But when referencing an anchor in another Markdown document in the same repo, then this doesn't work, and the prefix must be manually added to the anchor text. E.g.

- [Header 1 works](#header-1-works)
- [Subpage Header 1 does not](subfolder/subpage.md#subpage-header-1-does-not)
- [Subpage Header 1 prefixed does](subfolder/subpage.md#user-content-subpage-header-1-prefixed-does)

And <a href="subfolder/subpage.md#subpage-header-1">does not work either.</a>

# Header 1 works

Maybe it is hard to change this behavior, as it would require more parsing and checks of the referenced page, probably. But for working in a documentation repository with potentially many pages and cross-references (I intend to follow readme-driven development) this will be very confusing for all the people involved in refining said docs.

created time in 2 hours

push eventgo-gitea/gitea

hana

commit sha e8a6c425ecc649ba60885a49729d0fba9bba5e3e

Update discord domain (#13747) Update discord domain in webhook repository settings.

view details

push time in 2 hours

PR merged go-gitea/gitea

Update discord domain kind/docs lgtm/done skip-changelog

Update discord domain in webhook repository settings.

Reference Article

+1 -1

0 comment

1 changed file

hanahaneull

pr closed time in 2 hours

PR opened go-gitea/gitea

Update discord domain

Update discord domain in webhook repository settings.

Reference Article

+1 -1

0 comment

1 changed file

pr created time in 3 hours

push eventgo-gitea/gitea

GiteaBot

commit sha c2ac1c73f26d6f932b05052ae89bea89aed48d32

[skip ci] Updated translations via Crowdin

view details

push time in 4 hours

push eventgo-gitea/gitea

silverwind

commit sha 295fc99607915d85141fd16099d2d9f59a7ee977

Markdown and Repo header tweaks (#13744) * Markdown and Repo header tweaks - Use CSS vars for all markdown colors - Tweak repo header, removing double borders and adjust sizes - Use menu instead of buttons for issue open/close switcher - Add emoji inversion for select emoji glyphs in arc-green - Use border over box-shadow for all buttons - Add spacing element to login form without openid * repo settings navbar fix * use shared template in more places and adjust dashboard * fix remaining open/close combos

view details

push time in 4 hours

PR merged go-gitea/gitea

Markdown and Repo header tweaks kind/refactor kind/ui lgtm/done skip-changelog
  • Use CSS vars for all markdown colors
  • Tweak repo header, removing double borders and adjust sizes
  • Use menu instead of buttons for issue open/close switcher
  • Add emoji inversion for select emoji glyphs in arc-green
  • Use border over box-shadow for all buttons
  • Add spacing element to login form without openid

Screen Shot 2020-11-29 at 12 16 00 Screen Shot 2020-11-29 at 12 16 08 Screen Shot 2020-11-29 at 12 24 16 Screen Shot 2020-11-29 at 12 24 25 Screen Shot 2020-11-29 at 12 03 22 image

+129 -148

1 comment

16 changed files

silverwind

pr closed time in 4 hours

pull request commentgo-gitea/gitea

Add support for ed25519_sk and ecdsa_sk SSH keys

I only suggested autodetection for the tests, to implement the suggestion on https://github.com/go-gitea/gitea/pull/13462#issuecomment-723537202

E.g., we can detect what is supported on the platform with a ssh connection, and test only those type of keys. If we can't connect by ssh during the tests, they would fail anyway no matter what keys we try.

artemist

comment created time in 4 hours

pull request commentgo-gitea/gitea

Vendor Update 2020-11

Codecov Report

Merging #13746 (e173df2) into master (e00a355) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13746      +/-   ##
==========================================
- Coverage   42.22%   42.22%   -0.01%     
==========================================
  Files         699      699              
  Lines       76957    76957              
==========================================
- Hits        32498    32494       -4     
- Misses      39098    39099       +1     
- Partials     5361     5364       +3     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) :arrow_down:
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) :arrow_down:
modules/git/utils.go 73.77% <0.00%> (-3.28%) :arrow_down:
modules/log/file.go 73.60% <0.00%> (-1.61%) :arrow_down:
modules/git/repo.go 45.17% <0.00%> (-0.51%) :arrow_down:
models/error.go 38.17% <0.00%> (-0.49%) :arrow_down:
routers/repo/view.go 38.11% <0.00%> (+0.64%) :arrow_up:
modules/log/event.go 59.90% <0.00%> (+0.94%) :arrow_up:
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) :arrow_up:
modules/util/timer.go 85.71% <0.00%> (+42.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e00a355...e173df2. Read the comment docs.

6543

comment created time in 4 hours

issue commentgo-gitea/gitea

Suggest addition to "Installation on Windows" section to avoid trap

I've been thinking about how to write about running gitea in the security context of a dedicated user (see 1. above) for a bit - because it contradicts parts of the existing setup guide for Windows. I wonder how to best frame it. As an alternative approach? As an FAQ? Replacing the contradicting parts for consistency?

Setting the Windows service up to log on as a dedicated user account seems to work just fine. That raised the following question that I wanted to throw into the ring:

Why does the existing documentation recommend running gitea as the LocalSystem account on Windows?

Especially because there are major security implications associated with doing so?

I found this being either explicitly or implicitly recommended in the following docs:

1. https://docs.gitea.io/en-us/windows-service/#prerequisites

RUN_USER = COMPUTERNAME$

Sets Gitea to run as the local system user.

authored by @ve3

2. https://docs.gitea.io/en-us/#system-requirements

Gitea should be run with a dedicated non-root system account on UNIX-type systems.

changed by @MTecknology and @bkcsoft from the original:

Gitea is supposed to be run with a dedicated non-root user account on UNIX systems, no other mode of operation is supported. (NOTE: in case you run it with your own user account and the built-in SSH server disabled, Gitea modifies the ~/.ssh/authorized_keys file so you will not be able to interactively log in.)

3. https://docs.gitea.io/en-us/faq/#ssh-common-errors (not specific to Windows)

Check the permissions of the .ssh directory in the system user’s home directory.

Make sure that the git system user has a usable shell set

authored by @techknowlogick @jolheiser


Does anyone remember the reason why this was the recommended Windows setup? I can't seem to find any documented reason for this recommendation. Cheers!

itsbruce

comment created time in 5 hours

pull request commentgo-gitea/gitea

Clickable links in pull request (and issue) titles

Codecov Report

Merging #13695 (2cf8c45) into master (e00a355) will increase coverage by 0.03%. The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13695      +/-   ##
==========================================
+ Coverage   42.22%   42.26%   +0.03%     
==========================================
  Files         699      699              
  Lines       76957    76974      +17     
==========================================
+ Hits        32498    32530      +32     
+ Misses      39098    39083      -15     
  Partials     5361     5361              
Impacted Files Coverage Δ
modules/templates/helper.go 47.76% <50.00%> (+0.02%) :arrow_up:
modules/markup/html.go 78.79% <100.00%> (+0.44%) :arrow_up:
modules/process/manager.go 72.50% <0.00%> (-2.50%) :arrow_down:
modules/log/file.go 73.60% <0.00%> (-1.61%) :arrow_down:
routers/api/v1/repo/pull.go 25.45% <0.00%> (+0.60%) :arrow_up:
routers/repo/view.go 38.11% <0.00%> (+0.64%) :arrow_up:
modules/log/event.go 59.90% <0.00%> (+0.94%) :arrow_up:
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) :arrow_up:
models/unit.go 49.31% <0.00%> (+2.73%) :arrow_up:
modules/queue/manager.go 65.08% <0.00%> (+2.95%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e00a355...2cf8c45. Read the comment docs.

jpraet

comment created time in 6 hours

issue commentgo-gitea/gitea

The color of the button obscures the text content

Addressed in https://github.com/go-gitea/gitea/pull/13744.

ZhouJiaZhi

comment created time in 6 hours

pull request commentgo-gitea/gitea

Markdown and Repo header tweaks

Adjusted the remaining instances of open/close button combos as well. Their template can not easily be shared because the use different hrefs.

silverwind

comment created time in 6 hours

pull request commentgo-gitea/gitea

[API] List, Check, Add & delete endpoints for repository teams

Codecov Report

Merging #13630 (d8cd33e) into master (e00a355) will decrease coverage by 0.02%. The diff coverage is 8.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13630      +/-   ##
==========================================
- Coverage   42.22%   42.20%   -0.03%     
==========================================
  Files         699      700       +1     
  Lines       76957    77028      +71     
==========================================
+ Hits        32498    32512      +14     
- Misses      39098    39152      +54     
- Partials     5361     5364       +3     
Impacted Files Coverage Δ
routers/api/v1/repo/teams.go 0.00% <0.00%> (ø)
routers/api/v1/api.go 79.68% <100.00%> (+0.17%) :arrow_up:
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) :arrow_down:
modules/git/utils.go 73.77% <0.00%> (-3.28%) :arrow_down:
modules/log/file.go 73.60% <0.00%> (-1.61%) :arrow_down:
modules/git/repo.go 45.17% <0.00%> (-0.51%) :arrow_down:
services/pull/pull.go 40.68% <0.00%> (-0.50%) :arrow_down:
routers/repo/view.go 38.11% <0.00%> (+0.64%) :arrow_up:
modules/log/event.go 59.90% <0.00%> (+0.94%) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e00a355...d8cd33e. Read the comment docs.

6543

comment created time in 7 hours

more