See inline comment: https://github.com/rescript-association/rescript-lang.org/pull/385#discussion_r650729738

Of couse, what is clearer is subjective, and if you want I can try to achieve the same behaviour without this library.

@ryyppy For me, the improvement is being able to connect a specific action (like clearing the search box) to this effect (updating the URL). With ReactUpdate, you can queue the effect at the same location where you handle the action, whereas in the old version you have to compare the current URL and new state to reverse engineer what the most recent change was.

The use case was to pass aria-* props to React components from a ui library written in javascript. In our case a company's ui library.

This sounds like you are defining a type Props = { "aria-label": string } in your existing React component? This doesn't sound right to me for some reason.

Size Change: 0 B

Total Size: 621 kB

<details><summary>ℹ️ <strong>View Unchanged</strong></summary>

</details>

<a href="https://github.com/preactjs/compressed-size-action">_{compressed-size-action}</a>

⚡️ Lighthouse report for the changes in this PR:

Lighthouse ran on https://deploy-preview-4962--docusaurus-2.netlify.app/ <!-- Sticky Pull Request Commentlighthouse -->

:heavy_check_mark: [V2]

:hammer: Explore the source changes: 9200dba01a6d18a3650d3bd96104c206becbf8a1

:mag: Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c7073b242c0600078521e2

:sunglasses: Browse the preview: https://deploy-preview-4962--docusaurus-2.netlify.app

What makes the logic cleaner with ReactUpdate? It might look cleaner on first glance, but for me it's currently not entirely clear what benefits I get over the approach we had before?

<!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to Docusaurus here: https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md

Happy contributing!

-->

Motivation

Fixes #4956

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tests

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

That would be awesome. Also, for every subdirectory in /docs, it would be also great to redirect to a first doc there in the sidebar.

For example: redirect /docs/cli to /docs/cli/first-doc-under-cli-subdirectory, assuming that in the /docs/cli there is first-doc-under-cli-subdirectory.md file, which is the very first link in the sidebar.

Size Change: +46 B (0%)

Total Size: 621 kB

<details><summary>ℹ️ <strong>View Unchanged</strong></summary>

</details>

<a href="https://github.com/preactjs/compressed-size-action">_{compressed-size-action}</a>

Size Change: 0 B

Total Size: 621 kB

<details><summary>ℹ️ <strong>View Unchanged</strong></summary>

</details>

<a href="https://github.com/preactjs/compressed-size-action">_{compressed-size-action}</a>

⚡️ Lighthouse report for the changes in this PR:

Lighthouse ran on https://deploy-preview-4961--docusaurus-2.netlify.app/ <!-- Sticky Pull Request Commentlighthouse -->

:heavy_check_mark: [V2]

:hammer: Explore the source changes: 70c9c8807a6d889fca5f6d0b82fa16318b79ef86

:mag: Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c70483fd9d30000880eaae

:sunglasses: Browse the preview: https://deploy-preview-4961--docusaurus-2.netlify.app

⚡️ Lighthouse report for the changes in this PR:

Lighthouse ran on https://deploy-preview-4960--docusaurus-2.netlify.app/ <!-- Sticky Pull Request Commentlighthouse -->

:heavy_check_mark: [V2]

:hammer: Explore the source changes: 1a8196de0b156e9f49b2b2f8bb958285eb7bb19c

:mag: Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c703dad692870007929d96

:sunglasses: Browse the preview: https://deploy-preview-4960--docusaurus-2.netlify.app

<!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to Docusaurus here: https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md

Happy contributing!

-->

Motivation

Does the same thing as #4940, but for the blog sidebar.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@drcmda sorry, will be fixed in #4960.

<!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to Docusaurus here: https://github.com/facebook/docusaurus/blob/master/CONTRIBUTING.md

Happy contributing!

-->

Motivation

Proper way to fix #4934 :facepalm:

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See Test Plan from #4935

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

Right, I understand. Feel free to ignore this / leave this until later, but just to clear up any confusion:

I did not migrate the lockfile to v2 in this PR, that was done a month ago in this commit: https://github.com/rescript-association/rescript-lang.org/commit/b1ecde64fbe2152370fdae26cff6cb3e7fd749b3. I just updated the README to reflect the lockfile version that is currently in use. If you want to stay on npm@6 it would be better to revert the lockfile in the repo to v1; I could do that if you want?

The team's problems with the v2 lockfile may be the same I encountered (missing binaries)? Both downgrading to v1 or re-upgrading to v2 (this PR) would fix that.

@slorber @lex111 for some reason the canary gives me this now:

index.js?1ef8:1 Warning: React has detected a change in the order of Hooks called by BrowserOnly. This will lead to bugs and errors if not fixed. For more information, read the Rules of Hooks: https://reactjs.org/link/rules-of-hooks

   Previous render            Next render
   ------------------------------------------------------
1. useContext                 useContext
2. undefined                  useRef
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

    at BrowserOnly (webpack-internal:///./node_modules/@docusaurus/core/lib/client/exports/BrowserOnly.js:12:26)
    at div
    at div
    at nav
    at Navbar (webpack-internal:///./src/theme/Navbar.js:28:423)
    at DocsPreferredVersionContextProviderUnsafe (webpack-internal://

there seems to be nothing unusual in the file that im loading inside browseronly.

No change in behaviour, but this aligns better with the docs.

perfect. Then it's safe to merge I guess. Thanks!

Right now you are supposed to use node@12 and npm@6 (this was not a typo).

npm@6 uses lockfile v1, which works perfectly fine on all our machines. We experienced problems with lockfile version 2 though, which ended up so badly that Cheng was literally zipping up node_modules to be able to reproduce his rescript-lang.org setup.

Same for Maxim and Bettina's machine (and partly also mine).

Will have another look at it soon, right now it's too cumbersome to me to communicate yet another tooling version change for everyone.