chandde ( Chandler Deng )

In the above image, page.signature is being used to check whether a similar page has already been crawled, but, page.signature is not set until crawl_page() is called.

IMO, page.signature should be a cached_property of the Page class.

class Page:
    def __init__(self, url, contents, child_urls, signature):
        self.url = url
        self.contents = contents
        self.child_urls = child_urls

    def calculate_page_signature(self):
        pass

    @cached_property
    def signature(self):
        return self.calculate_page_signature()

created time in 12 days

PR closed donnemartin/system-design-primer

Merge pull request #1 from donnemartin/master

Get updates

Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

Tagged the language maintainer
Prefixed the title with a language code
- Example: "ja: Fix ..."

+0 -0

1 commit in omaralqady/system-design-primer/tree/master donnemartin/system-design-primer/tree/master

0 comment

0 changed file

omaralqady

pr closed time in 13 days

PR opened donnemartin/system-design-primer

Merge pull request #1 from donnemartin/master

Get updates

Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

Tagged the language maintainer
Prefixed the title with a language code
- Example: "ja: Fix ..."

+0 -0

1 commit in omaralqady/system-design-primer/tree/master donnemartin/system-design-primer/tree/master

0 comment

0 changed file

pr created time in 13 days

PR opened donnemartin/system-design-primer

Add German translation

This Draft PR will add a German translation.

+0 -0

1 commit in dominikbraun/system-design-primer/tree/german donnemartin/system-design-primer/tree/master

0 comment

1 changed file

pr created time in 15 days

PR opened donnemartin/system-design-primer

Fixes constructor for Director, Operator and Supervisor

Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

Tagged the language maintainer
Prefixed the title with a language code
- Example: "ja: Fix ..."

+14 -9

1 commit in anna-droid-beep/system-design-primer/tree/call-center-constructor-fix donnemartin/system-design-primer/tree/master

0 comment

1 changed file

pr created time in 16 days

issue commentdonnemartin/system-design-primer

Unit prefix in Powers of two table

thanks for advise

mortyccp

comment created time in 17 days

PR opened donnemartin/system-design-primer

Fix Celery url

Fixed celery task queue link

+1 -1

1 commit in sharpcodex/system-design-primer/tree/my-contributions donnemartin/system-design-primer/tree/master

0 comment

1 changed file

pr created time in 17 days

issue commentdonnemartin/system-design-primer

Spanish translation

@donnemartin :

Hi @eamanu: Are you still interested in translating the guide and being the language maintainer?

Hey there, I'll gladly take this one.

Lets put some order on this mess already, this beauty needs to be accessible to everyone!

Cool @weisk let me know if I can help.

ghost

comment created time in 17 days

issue commentdonnemartin/system-design-primer

Spanish translation

@donnemartin :

Hi @eamanu: Are you still interested in translating the guide and being the language maintainer?

Hey there, I'll gladly take this one.

Lets put some order on this mess already, this beauty needs to be accessible to everyone!

ghost

comment created time in 17 days

issue commentdonnemartin/system-design-primer

French translation

Hello @pfongkye, your contribution is welcome, I just merged master in: https://github.com/spuyet/system-design-primer/blob/add-french-translation/README-fr.md

You can make a PR at anytime :)

spuyet