chadaustin ( Chad Austin )

see https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html

For shared libraries VERSION and SOVERSION can be used to specify the build version and API version respectively. When building or installing appropriate symlinks are created if the platform supports symlinks and the linker supports so-names. If only one of both is specified the missing is assumed to have the same version number.

yurivict

comment created time in 4 hours

issue commentchadaustin/is-it-snappy

iPhone XR problem

Taking screenshots in the simulator should work out of the box… 🤔 Do you have problems taking them at their full resolution? If yes: https://stackoverflow.com/a/47152270

pahwp

comment created time in 6 hours

issue commentfacebook/fb303

You don't set SONAME at all. You should add the corresponding argument to the link command.

yurivict

comment created time in 6 hours

issue commentfacebook/fb303

So this is intentional - since fb303's API is not stable, leaving the SONAME unset means CMake uses the same value for version and soname. Packagers building shared libraries should make sure to always bump the version.

I'm open to better ideas, or maybe we should just document this better.

yurivict

comment created time in 6 hours

fork graydon/obsidian-sample-plugin

obsidianmd/obsidian-sample-plugin graydon/obsidian-sample-plugin

fork in 6 hours

startedobsidianmd/obsidian-sample-plugin

started time in 6 hours

starteddanluu/post-mortems

started time in 7 hours

Lukas Piatkowski

commit sha 15f0f924e66f397b0d843072c809f25d3f5c5ec5

mononoke/blobstore: use async_trait instead of BoxFuture Reviewed By: farnz Differential Revision: D25124793 fbshipit-source-id: 1ebe72d1db8043fabf9f20538f3e95c755e049e0

push time in 9 hours

issue openedfacebookexperimental/eden

osxfuse 4.0 issue

Hello guys, I saw your post here: https://github.com/osxfuse/osxfuse/issues/742 Just wanted to let you know that I can help you compile a previous "open source" version (3.8.3) of osxfuse for macOS 11.

Many people are having issues with this because it seems the interface was changed to encourage support without proper documentation.

created time in 10 hours

Thomas Orozco

commit sha 95cc0e5a30fba61ecbfdfae85fad020a17ae9c77

revisionstore: log more info when we time out Summary: Right now we just get a "deadline exceeded" error, which isn't very amenable to helping us understand why we timed out. Let's add more logging. Notably, I'd like to understnad what we've actually received at this point, if anything, and how long we waited, as I'm starting to suspect this issue doesn't have much to do with HTTP. See https://fb.workplace.com/groups/scm/permalink/3361972140519049/ for more context. Reviewed By: quark-zju Differential Revision: D25128159 fbshipit-source-id: b45d3415526fdf21aa80b7eeed98ee9206fbfd12

https://github.com/psy0rz/zfs_autobackup

push time in 15 hours

startedtetsugi/phaser3-electron-tutorial

started time in 16 hours

fork graydon/zfs_autobackup

ZFS autobackup is used to periodicly backup ZFS filesystems to other locations. No additional tools of libraries or config files needed.

psy0rz/zfs_autobackup graydon/zfs_autobackup

fork in 18 hours

startedpsy0rz/zfs_autobackup

started time in 18 hours

startedOneCDOnly/create-autorun

started time in 20 hours

startedjjjake/internetarchive

started time in 21 hours

issue commentfacebook/fb303

Would you submit a PR?

@michel-slm

yurivict

comment created time in 21 hours

issue openedfacebook/fb303

rev. 94cac88

created time in a day

push eventfacebook/fb303

Michel Salim

commit sha de82ce86747e3b256fd3633bdb077350bf02ac2c

allow disabling Python bindings Summary: Add an `PYTHON_EXTENSIONS` option (defaulting to `ON` to preserve current behavior) that can be toggled off. When off, the Thrift bindings will be generated for C++ only. Fixes #3. Fixes #4. Tested with the fb303 package being submitted for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1900147 Reviewed By: yfeldblum Differential Revision: D25138287 fbshipit-source-id: 0be272fd35d47bff55c4ee010afc4aaea66ce66b

Michel Salim

commit sha 94cac88cf8be1636727727591891b903a1dbdcb5

add PACKAGE_VERSION for building shared libraries Summary: Since `fb303` does not guarantee API/ABI stability, we want to be able to bump the soname whenever doing a new build. I'd ideally set this version to default to 0, but for consistency with fizz/wangle/fbthrift I've used 1.0.0. Tested with the fb303 package being submitted for Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1900147 Reviewed By: yfeldblum Differential Revision: D25138415 fbshipit-source-id: da1d77f695be480e3d2324ab56921c79c74586d4

Doesn't configure when fbthrift isn't built with python

push time in a day

issue closedfacebook/fb303

-- Configuring done
CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
  The dependency target "FBThrift::thrift_py.py_lib" of target
  "fb303_thrift_py.py_sources_built" does not exist.
Call Stack (most recent call first):
  build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
  build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
  fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)

Could you please add a cmake option to turn the python support on/off?

Thanks.

closed time in a day

yurivict

issue closedfacebook/fb303

Cmake build failing

I'm trying to get OpenR running, but I can not get an fb303 build. I hope you can help me to figure it out.

Cmake fails here:

2020-06-17T12:57:20.9023233Z CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
2020-06-17T12:57:20.9023619Z   The dependency target "FBThrift::thrift_py.py_lib" of target
2020-06-17T12:57:20.9023761Z   "fb303_thrift_py.py_sources_built" does not exist.
2020-06-17T12:57:20.9023891Z Call Stack (most recent call first):
2020-06-17T12:57:20.9024253Z   build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
2020-06-17T12:57:20.9024424Z   build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
2020-06-17T12:57:20.9024572Z   fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)
2020-06-17T12:57:20.9024642Z

No idea where I can get this library from.

Full log:

2020-06-17T12:57:17.6175552Z + git clone https://github.com/facebook/fb303
2020-06-17T12:57:17.6216775Z Cloning into 'fb303'...
2020-06-17T12:57:19.7658614Z + mkdir -p /usr/local/src/fb303/_build
2020-06-17T12:57:19.7669914Z + cd /usr/local/src/fb303/_build
2020-06-17T12:57:19.7671005Z + CXXFLAGS=' -fPIC'
2020-06-17T12:57:19.7671601Z + CFLAGS=' -fPIC'
2020-06-17T12:57:19.7672055Z + cmake -DBUILD_SHARED_LIBS=ON ..
2020-06-17T12:57:19.8613933Z -- The CXX compiler identification is GNU 7.5.0
2020-06-17T12:57:19.9124339Z -- The C compiler identification is GNU 7.5.0
2020-06-17T12:57:19.9248120Z -- Check for working CXX compiler: /usr/bin/c++
2020-06-17T12:57:19.9922128Z -- Check for working CXX compiler: /usr/bin/c++ - works
2020-06-17T12:57:19.9945782Z -- Detecting CXX compiler ABI info
2020-06-17T12:57:20.0782526Z -- Detecting CXX compiler ABI info - done
2020-06-17T12:57:20.0974588Z -- Detecting CXX compile features
2020-06-17T12:57:20.0982859Z -- Detecting CXX compile features - done
2020-06-17T12:57:20.1011666Z -- Check for working C compiler: /usr/bin/cc
2020-06-17T12:57:20.1592519Z -- Check for working C compiler: /usr/bin/cc - works
2020-06-17T12:57:20.8654076Z CMake Warning (dev) at /usr/local/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
2020-06-17T12:57:20.8654449Z -- Detecting C compiler ABI info
2020-06-17T12:57:20.8658853Z   The package name passed to `find_package_handle_standard_args` (glog) does
2020-06-17T12:57:20.8659879Z   not match the name of the calling package (Glog).  This can lead to
2020-06-17T12:57:20.8660265Z -- Detecting C compiler ABI info - done
2020-06-17T12:57:20.8661104Z   problems in calling code that expects `find_package` result variables
2020-06-17T12:57:20.8661398Z -- Detecting C compile features
2020-06-17T12:57:20.8662025Z   (e.g., `_FOUND`) to follow a certain pattern.
2020-06-17T12:57:20.8662326Z -- Detecting C compile features - done
2020-06-17T12:57:20.8663394Z Call Stack (most recent call first):
2020-06-17T12:57:20.8663948Z -- Found gflags from package config /usr/lib/x86_64-linux-gnu/cmake/gflags/gflags-config.cmake
2020-06-17T12:57:20.8664798Z   build/fbcode_builder/CMake/FindGlog.cmake:17 (find_package_handle_standard_args)
2020-06-17T12:57:20.8665161Z -- Found glog: /usr/lib/x86_64-linux-gnu/libglog.so  
2020-06-17T12:57:20.8666164Z   CMakeLists.txt:35 (find_package)
2020-06-17T12:57:20.8666576Z -- Looking for pthread.h
2020-06-17T12:57:20.8667785Z This warning is for project developers.  Use -Wno-dev to suppress it.
2020-06-17T12:57:20.8668021Z -- Looking for pthread.h - found
2020-06-17T12:57:20.8668768Z 
2020-06-17T12:57:20.8669067Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
2020-06-17T12:57:20.8669762Z -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
2020-06-17T12:57:20.8670314Z -- Looking for pthread_create in pthreads
2020-06-17T12:57:20.8670729Z -- Looking for pthread_create in pthreads - not found
2020-06-17T12:57:20.8671126Z -- Looking for pthread_create in pthread
2020-06-17T12:57:20.8671907Z -- Looking for pthread_create in pthread - found
2020-06-17T12:57:20.8672468Z -- Found Threads: TRUE  
2020-06-17T12:57:20.8673226Z -- Found Boost: /usr/local/include (found suitable version "1.69.0", minimum required is "1.51.0") found components: context filesystem program_options regex system thread chrono date_time atomic 
2020-06-17T12:57:20.8673651Z -- Found folly: /usr/local
2020-06-17T12:57:20.8674057Z -- Check if compiler accepts -pthread
2020-06-17T12:57:20.8674453Z -- Check if compiler accepts -pthread - yes
2020-06-17T12:57:20.8674832Z -- Found FBThrift: /usr/local
2020-06-17T12:57:20.8675466Z -- Found fizz: /usr/local
2020-06-17T12:57:20.8676004Z -- Found wangle: /usr/local
2020-06-17T12:57:20.8676379Z -- Found YARPL: /usr/local
2020-06-17T12:57:20.8676750Z -- Found rsocket: /usr/local
2020-06-17T12:57:20.8896041Z -- Found Python 3: /usr/bin/python3.6
2020-06-17T12:57:20.8984834Z -- Configuring done
2020-06-17T12:57:20.9023233Z CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
2020-06-17T12:57:20.9023619Z   The dependency target "FBThrift::thrift_py.py_lib" of target
2020-06-17T12:57:20.9023761Z   "fb303_thrift_py.py_sources_built" does not exist.
2020-06-17T12:57:20.9023891Z Call Stack (most recent call first):
2020-06-17T12:57:20.9024253Z   build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
2020-06-17T12:57:20.9024424Z   build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
2020-06-17T12:57:20.9024572Z   fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)
2020-06-17T12:57:20.9024642Z

closed time in a day

butjar

commit sha 080712c602833b4d66074e8a07adffb238421e5a

Updating submodules Summary: GitHub commits: https://github.com/facebook/rocksdb/commit/1a5fc4f5771d6996d8ece9359788ceeaba32df98 https://github.com/facebook/watchman/commit/8ed313ff53dbad438354ff83493a6a7b01dcc9f8 https://github.com/facebookexperimental/rust-shed/commit/0186ce639371da6184eb1e82a73fadbc7f12ab05 Reviewed By: wittgenst fbshipit-source-id: 1772b81a9f6aecf2f7175385683d08cb505c1707

push time in 2 days

push eventfacebook/fb303

commit sha b0ade4275c87f58023f1d2252dcb8ac88248d28e

Updating submodules Summary: GitHub commits: https://github.com/facebook/fbthrift/commit/46e0567b89d1bd4fdf888ff4d30cc0e876a7872f Reviewed By: wittgenst fbshipit-source-id: 21737a0c84a37f6dc8deb667914a1872fc1d9852

push time in 2 days

startedvigna/MRG32k3a

started time in 3 days

commit sha 251a17c317f08a3cb7f23a6e852b7a1411ccf346

Updating submodules Summary: GitHub commits: https://github.com/facebookexperimental/rust-shed/commit/8f2f4d97a22c4c5c65db283c0cc69498f1a0ffa1 Reviewed By: wittgenst fbshipit-source-id: 6cc2fbdc3c8218a794556e62e5d1f60c9ae4c9b6

push time in 3 days

Katie Mancini

commit sha a46707cc19f902467e0beea5ce925fbe1c82f865

Fix eden du --clean on MacOS Summary: `eden du --clean` currently fails with ``` Fatal Python error: initfsencoding: unable to load the file system codec ModuleNotFoundError: No module named 'encodings' ``` Full error: P149352812 It looks like this is because Buck expects to run with a different python, so here I clear out the PYTHONHOME variable before we start buck. This reuses out logic used elsewhere to clean up the environment before calling buck. Reviewed By: wez Differential Revision: D24904105 fbshipit-source-id: 73587c52aff3ea00f68339eb44e7042329de2e44

push time in 3 days

commit sha 123e9fffaf28081868c38c4b90fc6f21e0d1183f

Updating submodules Summary: GitHub commits: https://github.com/facebook/fb303/commit/e2c9673f653def4edcefda36ac22a8ad0d8b92ea https://github.com/facebook/fbthrift/commit/4f88c3f60e0f9af227a36b3c85cdfacbf7901b16 https://github.com/facebook/fbzmq/commit/8b64c71ab792cab48611403351679c61b44bd25d https://github.com/facebook/proxygen/commit/179b347d9bd5face3e388770664a4fbc924d2a5e https://github.com/facebook/wangle/commit/b2170a682445b17c53cde504b8f56cdc5f82e805 https://github.com/facebook/watchman/commit/3263b4e18e3270429f6abc01875f043d62fb2caa https://github.com/facebookexperimental/rust-shed/commit/43bf02b6cb2fd9475ba5fd20cf4a9379d9999278 https://github.com/facebookincubator/fizz/commit/367f209cee305b2d3badd562109bd7ca59c844ae https://github.com/facebookincubator/katran/commit/dea2f94287420283085a8264787d773850a9685f https://github.com/facebookincubator/mvfst/commit/8613ac65b72c93266642e95e4409e3dfb367aaaa https://github.com/rsocket/rsocket-cpp/commit/3d70533b0402cd6b8833c3535733e5ede2f7d58e Reviewed By: wittgenst fbshipit-source-id: 37e8d77debbb3a61afb6a14c7a6f52b7120ee6c5

Jonathan Keljo

commit sha 8cb2b9b7108a650272645b6ba15dfbddcb2c0426

Work around lru-disk-cache UB in Rust 1.48 Summary: `lru-disk-cache` depends on an old version of `linked-hash-map` which contains UB in 1.48 (see https://github.com/mozilla/sccache/issues/813). They updated the deps in their repo months ago, but haven't pushed a new version. This diff makes us get `lru-disk-cache` directly from their GitHub instead. Reviewed By: dtolnay Differential Revision: D25134582 fbshipit-source-id: 05fd63a76b7095ebeea458645b92a83bbd8c4614