profile
viewpoint

cdunn2001/git-sym 9

Handling large files in git via symlinks

beieler/twoo 3

TWOO Development

cdunn2001/chug 3

C++ Humanoid Unwrapping Generator

cdunn2001/icfp11 2

ICFP Contest 2011

cdunn2001/bignumjsonlua 1

JSON reader to handle big numbers, impl'd in Lua, using PEG parser.

cdunn2001/compile-times 1

From reddit, a simple way to compare compile-times for Rust, Go, C++, Nim,D, Pascal, ...

cdunn2001/go-gb 1

A(nother) tool to build go projects.

cdunn2001/greg 1

a recursive-descent parser generator based on Ian Piumarta's peg/leg, re-entrant thanks to _why, and with better error-reporting features

cdunn2001/bauhaus2 0

For testing only

cdunn2001/blasr 0

BLASR: The PacBio® long read aligner

issue openedopen-source-parsers/jsoncpp

Unresolved external symbol error VS2019

Describe the bug Upon compilation, multiple errors are thrown all to do with 'unresolved external symbols'.

To Reproduce Not too sure.

Expected behavior It to compile.

Desktop (please complete the following information): Windows 10 I'm trying to compile a DLL

Additional context Hi, I'm trying to compile my DLL with jsoncpp, however I am getting this unusual error I have never really seen before: 1>dllmain.obj : error LNK2001: unresolved external symbol "class std::basic_istream<char,struct std::char_traits<char> > & __cdecl Json::operator>>(class std::basic_istream<char,struct std::char_traits<char> > &,class Json::Value &)" (??5Json@@YAAAV?$basic_istream@DU?$char_traits@D@std@@@std@@AAV12@AAVValue@0@@Z)

1>dllmain.obj : error LNK2001: unresolved external symbol "public: class Json::Value & __thiscall Json::Value::operator[](char const *)" (??AValue@Json@@QAEAAV01@PBD@Z)

1>dllmain.obj : error LNK2001: unresolved external symbol "public: int __thiscall Json::Value::asInt(void)const " (?asInt@Value@Json@@QBEHXZ)

1>dllmain.obj : error LNK2001: unresolved external symbol "public: __thiscall Json::Value::~Value(void)" (??1Value@Json@@QAE@XZ)

1>dllmain.obj : error LNK2001: unresolved external symbol "public: __thiscall Json::Value::Value(enum Json::ValueType)" (??0Value@Json@@QAE@W4ValueType@1@@Z)

I have included value.h & json.h in my project.

Like I said, I haven't really seen this error before and I'm not too sure what is happening, after some googling I came to no conclusion. Thanks for any help given.

(Sorry if I've missed something and this isn't the right place to ask)

created time in 5 hours

issue commentopen-source-parsers/jsoncpp

output error with comment, before and after "//"

@dota17 please check these 2 issues, they are not the same error

kjflyback

comment created time in 15 hours

issue openedopen-source-parsers/jsoncpp

output error with comment, before and after "//"

thanks..., and next issue, talk is cheap,show code to you:

1st bug about comment again

reader.parse("{\"p\":[//\n//\n//\n]}", root);
std::cout<<Json::writeString(wb, root);

output is:

{
	"p" : 
	[
		//
		//
		//
		null
	]
}

the "null" may be a wrong string


2nd bug about comment again

reader.parse("{\"a\":1234567890,\"p\":[//\n//\n//\n]}", root);
std::cout<<Json::writeString(wb, root);

output is:

{
	"a" : 1234567890, //
	"p" : 
	[
		//
		//
		null
	]
}

may be first comment mark goes to wrong place

3rd something interesting

reader.parse("{\"a\":1234567890,\\ pop\n\"p\":[//\n]}", root);
output
{
	"a" : 1234567890
}

missing comment and following part

4th

reader.parse("\\ pop\n{\"a\":1234567890,\"p\":[//\n]}", root);

can not parse

5th

reader.parse("{\\ pop\n\"a\":1234567890,\"p\":[//\n]}", root);
output:
{}

missing all data but {} mark

PS:I use lastest code from jsoncpp

created time in 3 days

pull request commentopen-source-parsers/jsoncpp

Remove trailing space characters and add a few missing newlines

Any update? This should be good to go. CC @baylesj and @BillyDonahue

Travis completed successfully if you click "Details", but it's not updating here on GitHub.

aaronfranke

comment created time in 3 days

issue commentopen-source-parsers/jsoncpp

parse error when "//" comment follows array and array is empty

thanks..., and next issue, talk is cheap,show code to you:

1st bug about comment again

reader.parse("{\"p\":[//\n//\n//\n]}", root);
std::cout<<Json::writeString(wb, root);

output is:

{
	"p" : 
	[
		//
		//
		//
		null
	]
}

the "null" may be a wrong string


2nd bug about comment again

reader.parse("{\"a\":1234567890,\"p\":[//\n//\n//\n]}", root);
std::cout<<Json::writeString(wb, root);

output is:

{
	"a" : 1234567890, //
	"p" : 
	[
		//
		//
		null
	]
}

may be first comment mark goes to wrong place

3rd something interesting

reader.parse("{\"a\":1234567890,\\ pop\n\"p\":[//\n]}", root);
output
{
	"a" : 1234567890
}

missing comment and following part

4th

reader.parse("\\ pop\n{\"a\":1234567890,\"p\":[//\n]}", root);

can not parse

5th

reader.parse("{\\ pop\n\"a\":1234567890,\"p\":[//\n]}", root);
output:
{}

missing all data but {} mark

PS:I use lastest code from jsoncpp

kjflyback

comment created time in 4 days

issue commentopen-source-parsers/jsoncpp

parse error when "//" comment follows array and array is empty

Related to: https://github.com/open-source-parsers/jsoncpp/issues/650

kjflyback

comment created time in 6 days

issue commentopen-source-parsers/jsoncpp

1.9.4 do not compile with older cmake (cmake < 3.12) in libjson/cmakefile.txt

Quick workaround: removing the OBJECTS line for cmake < 3.12

Pascal-Fremaux

comment created time in 7 days

issue commentopen-source-parsers/jsoncpp

The Chinese Character Code Format data is abnormal

But I like the console display gbk text information, how to modify the JSON source encoding format

w136111526

comment created time in 7 days

issue commentopen-source-parsers/jsoncpp

The Chinese Character Code Format data is abnormal

Please see the discussion here https://github.com/open-source-parsers/jsoncpp/pull/1232#discussion_r504396311, this library assumes all strings are UTF-8, so you should use u8"你好,中国" instead.

w136111526

comment created time in 7 days

issue openedopen-source-parsers/jsoncpp

The Chinese Character Code Format data is abnormal

I used your example streamWrite to print json information, and the Chinese field display is not normal,my code is following: Json::Value root; root["Name"] = "你好,中国"; root["Age"] = 20; std::string result = root.toStyledString(); printf("%s", result.c_str()); writer->write(root, &std::cout);

created time in 7 days

issue openedopen-source-parsers/jsoncpp

1.9.4 do not compile with older cmake (cmake < 3.12) in libjson/cmakefile.txt

Describe the bug Compiling with an older cmake (no choice) v3.8 do not recognize the install (OBJECTS) (available only since cmake 3.12) https://cmake.org/cmake/help/v3.12/command/install.html

CMake Error at src/lib_json/CMakeLists.txt:214 (install): install TARGETS given unknown argument "OBJECTS".

To Reproduce Steps to reproduce the behavior: Use cmake v3.8 (any cmake < 3.12) and build

Expected behavior The file has a lot of older cmake adaptation, but not for this one.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Yocto
  • Meson version ?
  • Ninja version ?

Additional context

created time in 7 days

issue openedopen-source-parsers/jsoncpp

parse error when "//" comment follows array and array is empty

Describe the bug a json file content

{	
	"list": [ 
	]
}

when I write some comments to the first line after array's first '[', JSONCPP can not parse it,

{	
	"list": [ //
	]
}

parse will failed.

{	
	"list": [ 
             //
             //
             //
	]
}

parse will failed

created time in 8 days

push eventopen-source-parsers/jsoncpp

Chen

commit sha 6515246e2d22b4f52d98ee07e75613a73e93f824

fix the CI failure

view details

push time in 8 days

pull request commentopen-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

I forked this repo, and now use my copy with also these two lines removed This is not standard CMake, and it should not cause problems when building in the main folder and overwrite intermediate and source code files. If it does, something else is wrong. Sure it is best practice to create a build folder, but I would not force this...

@baylesj , @hjmjohnson , hope you can reconsider this patch

hjmjohnson

comment created time in 14 days

push eventopen-source-parsers/jsoncpp

Jordan Bayles

commit sha d6152a06ea95a670a6a68996ebf04e1c9abd0d0c

Revert to JSONCPP_(SO)?VERSION_*

view details

push time in 14 days

pull request commentopen-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

This has caused me a problem Building jsoncpp today. In the end I had to comment the two new lines added in the CMakelists within the json folder.

hjmjohnson

comment created time in 14 days

issue commentopen-source-parsers/jsoncpp

File using amalgamate

i can't believe I just pressed the enter key and this happens.

Evan-Clegern

comment created time in 15 days

issue closedopen-source-parsers/jsoncpp

File using amalgamate

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: 1.

Expected behavior A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Meson version
  • Ninja version

Additional context Add any other context about the problem here.

closed time in 15 days

Evan-Clegern

issue openedopen-source-parsers/jsoncpp

File using amalgamate

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: 1.

Expected behavior A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Meson version
  • Ninja version

Additional context Add any other context about the problem here.

created time in 15 days

pull request commentopen-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

Sorry for asking, but we use your library as a sub project and build this via:

add_subdirectory (extern/jsoncpp EXCLUDE_FROM_ALL) target_link_libraries(domoticz jsoncpp_static)

With this change it's not possible to build this anymore

Could you make this an Option which is default set to YES, but when used as a external library in other projects we can set this to NO ?

hjmjohnson

comment created time in 15 days

pull request commentopen-source-parsers/jsoncpp

Fix empty version string in pkgconfig/jsoncpp.pc

@baylesj Sorry, my bad, you are right. I shouldn't change the project setting in CMakelists.txt. I didn't know that <PROJECT-NAME>_VERSION and PROJECT_VERSION are the same[1,2], so there is no need to change the project name from JSONCPP to jsoncpp. So, based on this, I agree with you to partially reverting #1197, use JSONCPP_VERSION and JSONCPP_VERSION_MAJOR again.

dota17

comment created time in 15 days

Pull request review commentopen-source-parsers/jsoncpp

* PVS Studio fix

 StreamWriter* StreamWriterBuilder::newStreamWriter() const {   const bool emitUTF8 = settings_["emitUTF8"].asBool();   unsigned int pre = settings_["precision"].asUInt();   CommentStyle::Enum cs = CommentStyle::All;-  if (cs_str == "All") {-    cs = CommentStyle::All;-  } else if (cs_str == "None") {+  if (cs_str == "None") {

https://github.com/open-source-parsers/jsoncpp/blob/ceae0e3867fe16e1227b4a39fe6951ee005591dc/src/lib_json/json_writer.cpp#L1170

pavel-pimenov

comment created time in 16 days

pull request commentopen-source-parsers/jsoncpp

include/json: check MSVC before adding pragma warning directive

The error is not happening with MSVC, it's with GCC and/or Clang. First read the commit message. The #pragma warning are for MSVC, so my preprocessor changes check it first then enables it. Without it GCC show multiple warnings like this:

In file included from ../include/json/reader.h:11,
                 from ../src/lib_json/json_reader.cpp:10:
../include/json/value.h:52: warning: ignoring '#pragma warning ' [-Wunknown-pragmas]
   52 | #pragma warning(push)
      |
../include/json/value.h:53: warning: ignoring '#pragma warning ' [-Wunknown-pragmas]
   53 | #pragma warning(disable : 4251)
      |
../include/json/value.h:932: warning: ignoring '#pragma warning ' [-Wunknown-pragmas]
  932 | #pragma warning(pop)
      |
Biswa96

comment created time in 17 days

pull request commentopen-source-parsers/jsoncpp

some old pre C++11 cleanups

From AppVeyor:

c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
  json_value.cpp
C:\projects\jsoncpp\include\json/value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  C:\projects\jsoncpp\include\json/value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  json_writer.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  Generating Code...
  jsoncpp_object.vcxproj -> C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_object.dir\Release\jsoncpp_object.lib
  Building Custom Rule C:/projects/jsoncpp/src/lib_json/CMakeLists.txt
  json_reader.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_lib.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
  json_value.cpp
C:\projects\jsoncpp\include\json/value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_lib.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  C:\projects\jsoncpp\include\json/value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_lib.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  json_writer.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_lib.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_lib.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  Generating Code...
     Creating library C:/projects/jsoncpp/build/release/lib/Release/jsoncpp.lib and object C:/projects/jsoncpp/build/release/lib/Release/jsoncpp.exp
  jsoncpp_lib.vcxproj -> C:\projects\jsoncpp\build\release\bin\Release\jsoncpp.dll
  Building Custom Rule C:/projects/jsoncpp/src/lib_json/CMakeLists.txt
  json_reader.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_static.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
  json_value.cpp
C:\projects\jsoncpp\include\json/value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_static.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  C:\projects\jsoncpp\include\json/value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_static.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  json_writer.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_static.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
C:\projects\jsoncpp\include\json/writer.h(153): warning C4996: 'Json::Writer::~Writer': Use StreamWriter instead [C:\projects\jsoncpp\build\release\src\lib_json\jsoncpp_static.vcxproj]
  C:\projects\jsoncpp\include\json/writer.h(150): note: see declaration of 'Json::Writer::~Writer'
  C:\projects\jsoncpp\include\json/writer.h(153): note: This diagnostic occurred in the compiler generated function 'void *Json::Writer::__delDtor(unsigned int)'
  Generating Code...
  jsoncpp_static.vcxproj -> C:\projects\jsoncpp\build\release\lib\Release\jsoncpp_static.lib
  Building Custom Rule C:/projects/jsoncpp/src/test_lib_json/CMakeLists.txt
  jsontest.cpp
C:\projects\jsoncpp\include\json/value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\test_lib_json\jsoncpp_test.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  C:\projects\jsoncpp\include\json/value.h(67): note: see declaration of 'Json::Exception'
  fuzz.cpp
c:\projects\jsoncpp\include\json\value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\test_lib_json\jsoncpp_test.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  c:\projects\jsoncpp\include\json\value.h(67): note: see declaration of 'Json::Exception'
  main.cpp
C:\projects\jsoncpp\include\json/value.h(67): warning C4275: non dll-interface class 'std::exception' used as base for dll-interface class 'Json::Exception' [C:\projects\jsoncpp\build\release\src\test_lib_json\jsoncpp_test.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\vcruntime_exception.h(43): note: see declaration of 'std::exception'
  C:\projects\jsoncpp\include\json/value.h(67): note: see declaration of 'Json::Exception'

Removed the warning suppression commits. Those can be dealt with elsewhere I think.

neheb

comment created time in 17 days

Pull request review commentopen-source-parsers/jsoncpp

* PVS Studio fix

 Json::String ToJsonString(const char* toConvert) {   return Json::String(toConvert); } -Json::String ToJsonString(Json::String in) { return in; }+Json::String ToJsonString(const Json::String& in) { return in; }

You also need to modify the header:

  jsoncpp_static.vcxproj -> C:\projects\jsoncpp\lib\Release\jsoncpp_static.lib
main.obj : error LNK2019: unresolved external symbol "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl JsonTest::ToJsonString(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >)" (?ToJsonString@JsonTest@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V23@@Z) referenced in function "public: virtual void __thiscall TestCharReaderAllowSingleQuotesTestissue182::runTestCase(void)" (?runTestCase@TestCharReaderAllowSingleQuotesTestissue182@@UAEXXZ) [C:\projects\jsoncpp\src\test_lib_json\jsoncpp_test.vcxproj]
pavel-pimenov

comment created time in 17 days

Pull request review commentopen-source-parsers/jsoncpp

* PVS Studio fix

 StreamWriter* StreamWriterBuilder::newStreamWriter() const {   const bool emitUTF8 = settings_["emitUTF8"].asBool();   unsigned int pre = settings_["precision"].asUInt();   CommentStyle::Enum cs = CommentStyle::All;-  if (cs_str == "All") {-    cs = CommentStyle::All;-  } else if (cs_str == "None") {+  if (cs_str == "None") {

This seems wrong. Am I missing something here?

pavel-pimenov

comment created time in 17 days

push eventopen-source-parsers/jsoncpp

Hans Johnson

commit sha 8954092f0af9538f3cde47aceb459dbe4d6e2241

ENH: Prevent cmake in source builds (#1091) * ENH: Prevent cmake in source builds Building directly inside the root of the source tree can cause problems where the build intermediate files overwrite or conflict with the intended source code files. This modification identifies this problem and issues failure messages and suggestions to over come the problem with more robust build suggestion. Co-authored-by: Jordan Bayles <jophba@chromium.org>

view details

push time in 17 days

PR merged open-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

Building directly inside the root of the source tree can cause problems where the build intermediate files overwrite or conflict with the intended source code files.

This modification identifies this problem and issues failure messages and suggestions to over come the problem with more robust build suggestion.

+67 -4

8 comments

5 changed files

hjmjohnson

pr closed time in 17 days

pull request commentopen-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

Travis is being slow, but it's all green so going to submit.

hjmjohnson

comment created time in 17 days

pull request commentopen-source-parsers/jsoncpp

ENH: Prevent cmake in source builds

I think this is a good step forward.

hjmjohnson

comment created time in 17 days

more