profile
viewpoint

carsonip/alexa-pocket 11

Alexa Skill for Pocket

carsonip/architect-awesome 0

后端架构师技术图谱

carsonip/aws-ecr-orb 0

CircleCI orb for interacting with Amazon's Elastic Container Registry (ECR)

fork vstinner/scipy

Scipy library main repository

https://scipy.org/scipylib/

fork in 7 hours

startedscipy/scipy

started time in 7 hours

startedcarsonip/Penguin-Subtitle-Player

started time in 17 hours

startedretejs/rete

started time in a day

fork yyx990803/postcss-modules

PostCSS plugin to use CSS Modules everywhere

fork in 2 days

fork yyx990803/postcss

Transforming styles with JS plugins

https://postcss.org

fork in 2 days

fork rptr/Penguin-Subtitle-Player

An open-source, cross-platform standalone subtitle player

fork in 2 days

startedarrobalytics/django-ledger

started time in 2 days

startedSPSCommerce/redlock-py

started time in 2 days

startedgrafana/loki

started time in 2 days

startedBrobridgeOrg/gravity-adapter-debezium

started time in 2 days

created repositoryBrobridgeOrg/gravity-adapter-debezium

Gravity adapter for debezium

created time in 2 days

startedtailwindlabs/tailwindcss

started time in 3 days

startedrsalmei/clearly

started time in 3 days

startedsaxix/django-concurrency

started time in 3 days

startedcarsonip/hugo-theme-minos

started time in 4 days

startedapple/tensorflow_macos

started time in 6 days

startedvueComponent/ant-design-vue

started time in 6 days

startedcarsonip/alexa-pomodoro

started time in 7 days

startedQUANTAXIS/QUANTAXIS

started time in 9 days

issue openedcarsonip/Penguin-Subtitle-Player

Problems with line breaks and HTML formatted text

In principle, the Penguin Subtitle Player seems to support HTML formatted text, e.g. subtiles with <i> and </i> tags are rendered italic:

1
01:42:13,365 --> 01:42:21,723
- <i>This includes all the marine vessels.</i>

image

However, I have found that if there are two lines of text and only the second line contains HTML tags, then the tags are ignored and show up literally:

2
01:42:56,429 --> 01:43:02,198
- The war is over, my love. The war is gone.
- <i>This includes all the marine vessels.</i>

image

If the first line of text also contains HTML tags, then the formatting works, but the line break itself gets ignored:

3
01:43:09,731 --> 01:43:17,464
- The <i>war</i> is over, my love. The war is gone.
- <i>This includes all the marine vessels.</i>

image

The cause of these issues appears to be the line break. If a <br> tag is used instead of a real line break, then it works fine:

4
01:43:23,731 --> 01:43:30,464
- The war is over, my love. The war is gone.<br>- <i>This includes all the marine vessels.</i>

image

In fact, even if the <br> tag is then followed by a real line break, it still works:

5
01:43:38,139 --> 01:43:45,479
- The war is over, my love. The war is gone.<br>
- <i>This includes all the marine vessels.</i>

image

By the way, I took these screenshots on Windows 10 version 2004. I haven't tested this on other operating systems.

<hr>

My suggestion to fix these issues would be as follows: While parsing the .srt file, whenever you encounter a line break (inside a subtitle text block) that isn't already followed by a <br> tag, simply append a <br> tag to it. What do you think? Would that be possible?

created time in 10 days

startedopenark/orchestrator

started time in 11 days

startedRedCokeDevelopment/CTF-Writeup

started time in 11 days

created repositorysamueltangz/hkcert-ctf-2020-challenges

created time in 11 days

fork TritonHo/migrate

Database migrations. CLI and Golang library.

fork in 12 days

startedelement-plus/element-plus

started time in 12 days

created repository2020comp7404-11/project

created time in 12 days

fork zarrowbahn/hugo-theme-minos

A simple and retro styled Hugo theme ported from Hexo

fork in 16 days

more