profile
viewpoint

candrews/callerid-for-android 15

The CallerID Android application uses a web service to provide CallerID information when the phone rings, or when a user inputs a phone number to lookup. The web service the project uses is Free Software – see https://gitorious.org/callerid-service It’s incredibly simple right now – but hopefully I’ll have the attention span to add some awesome, or even better, someone else will help me along.

candrews/abendbrot 0

Desktop oriented overlay for various ebuilds and the occasional gamer

candrews/add-to-homescreen 0

Add to home screen call-out for mobile devices

candrews/AkamaiOPEN-edgegrid-java 0

Java library for Akamai OPEN EdgeGrid Client Authentication

candrews/amazon-sqs-java-messaging-lib 0

This Amazon SQS Java Messaging Library holds the Java Message Service compatible classes, that are used for communicating with Amazon Simple Queue Service.

candrews/AndroidAsync 0

Asynchronous socket, http (client+server), websocket, and socket.io library for android. Based on nio, not threads.

candrews/apt-package-whitelist 0

Whitelist of apt packages approved for build environments with restricted sudo

PR opened oktadeveloper/okta-aws-cli-assume-role

Don't use internal class

Use CookieHandler.getDefault() instead of the com.sun.webkit.network.CookieManager internal class.

CookieHandler.getDefault() returns an instance of com.sun.webkit.network.CookieManager so this change results in the same behavior.

This change fixes this error at runtime:

Exception in thread "JavaFX Application Thread" java.lang.IllegalAccessError: class com.okta.tools.authentication.CookieManager (in unnamed module @0x1ce24091) cannot access class com.sun.webkit.network.CookieManager (in module javafx.web) because module javafx.web does not export com.sun.webkit.network to unnamed module @0x1ce24091

Problem Statement

Solution

+1 -2

0 comment

1 changed file

pr created time in a day

push eventcandrews/okta-aws-cli-assume-role

Craig Andrews

commit sha fef7ef7e34c6607861b03e27cde497976305660d

Don't use internal class Use `CookieHandler.getDefault()` instead of the `com.sun.webkit.network.CookieManager` internal class. `CookieHandler.getDefault()` returns an instance of `com.sun.webkit.network.CookieManager` so this change results in the same behavior. This change fixes this error at runtime: ``` Exception in thread "JavaFX Application Thread" java.lang.IllegalAccessError: class com.okta.tools.authentication.CookieManager (in unnamed module @0x1ce24091) cannot access class com.sun.webkit.network.CookieManager (in module javafx.web) because module javafx.web does not export com.sun.webkit.network to unnamed module @0x1ce24091 ```

view details

push time in a day

pull request commentgentoo/gentoo

sys-devel/llvm-roc: Use flag to optionaly build runtime libraries

If they're installed by sys-libs/compiler-rt, then why are they installed by this use flag too? Should this flag conflict with sys-libs/compiler-rt or replace it?

justxi

comment created time in 3 days

create barnchcandrews/gentoo

branch : bug743535

created branch time in 4 days

PR opened gentoo/gentoo

Removal of media-tv/kodi-18* (and all dependencies on it)

See https://bugs.gentoo.org/743535

+0 -9553

0 comment

284 changed files

pr created time in 4 days

pull request commentgentoo/gentoo

sys-devel/llvm-roc: Use flag to optionaly build runtime libraries

What are the runtime libraries? What are they used for / why would someone want them?

I'm trying to determine if the use flag should default to enabled and what other packages may depend on this use flag.

justxi

comment created time in 5 days

PR opened jhy/jsoup

Add @SafeHtml java validator

This change does not add any new dependencies to jsoup. If a bean validation implementation is present, then the new @org.jsoup.constraints.SafeHtml constraints can be used.

This implementation was copied from Hibernate Validator 6.1.5.FINAL SafeHtml was marked deprecated in Hibernate Validator following CVE-2019-10219 see https://in.relation.to/2019/11/20/hibernate-validator-610-6018-released/

The root cause of the CVE was a misunderstanding of jsoup by Hibernate Validator. By making the @SafeHtml constraint part of jsoup, that concern is eliminated.

With this change, users have a logical source for @SafeHtml, eliminating the need for each project to build and maintain @SafeHtml itself, making for more secure and maintainable software.

Closes #1382

+367 -0

0 comment

28 changed files

pr created time in 7 days

create barnchcandrews/jsoup

branch : safehtml

created branch time in 7 days

fork candrews/jsoup

jsoup: Java HTML Parser, with best of DOM, CSS, and jquery

https://jsoup.org/

fork in 7 days

issue commentjhy/jsoup

Add @SafeHtml Jakarta Validator

Based on a reading of https://in.relation.to/2019/11/20/hibernate-validator-610-6018-released/, I believe CVE-2019-10219's root cause was a misunderstanding of jsoup. If the validator is maintained in jsoup, that concern is eliminated.

candrews

comment created time in 7 days

pull request commenthibernate/hibernate-validator

HV-1780 Add @Normalized contraint that validates unicode normalization form

@gsmet can you please make a 6.1.6.Final release? https://hibernate.atlassian.net/browse/HV-1800

candrews

comment created time in 7 days

pull request commentspring-projects/spring-framework

AbstractRequestLoggingFilter: split client info, conditional before/after

@jhoeller can you (or anyone else applicable) please review and (hopefully) merge this PR?

Thank you!

candrews

comment created time in 10 days

create barnchcandrews/spring-framework

branch : AbstractRequestLoggingFilter

created branch time in 14 days

PR opened spring-projects/spring-framework

AbstractRequestLoggingFilter: split client info, conditional before/after
  • New methods to configure each part of the client info logging
  • Session id is no longer logged by default when client info logging is enabled The session id is sensitive information (similar to user credentials)
  • Methods to separately and conditional enable/disable before and after logging
+116 -11

0 comment

1 changed file

pr created time in 14 days

pull request commentspring-projects/spring-framework

PingPongWebSocketHandlerDecorator schedules pings and replies to pongs

@rstoyanchev can you please take a look at this PR?

candrews

comment created time in 14 days

issue commentjustxi/rocm

PRs to Gentoo

It seems acceptable to me...

candrews

comment created time in 14 days

CommitCommentEvent

pull request commentgentoo/gentoo

dev-libs/rocr-runtime: Added dependency "xxdi"

If you remove app-editors/vim-core and install just dev-util/xxdi does this package emerge correctly?

I ask because dev-util/xxdi provides xxdi.pl - not xxdi, so I suspect it's not a straight drop in replacement.

justxi

comment created time in a month

pull request commentgentoo/gentoo

Radeon Open Compute packages

... and there it is ... rocm-opencl-runtime 3.7.0

The star of the show has now been merged :+1:

BTW, if it's easier for you, in the future, you could do one PR containing a commit for each package. Or keep up with this approach, whichever approach works for you works for me.

candrews

comment created time in a month

issue commentjustxi/rocm

PRs to Gentoo

Thank you for all of this!

Are you submitting these patches are pull requests upstream? I'm really hoping that someday no patches are necessary :crossed_fingers:

candrews

comment created time in a month

pull request commentgentoo/gentoo

dev-libs/libcec: bump to 4.0.7, fixes and improvements

@whyman can we merge this now?

Karlson2k

comment created time in a month

pull request commentgentoo/gentoo

Bitcoin 0.20.1

libressl was dropped - was that intentional?

luke-jr

comment created time in a month

issue commentxbmc/xbmc

Test failures: TestDateTime.FileTimeOperators and TestDateTime.SetFromUTCDateTime

Based on version control history, I think @lrusak would know the most about this issue.

candrews

comment created time in a month

issue openedxbmc/xbmc

Test failures: TestDateTime.FileTimeOperators and TestDateTime.SetFromUTCDateTime

<!--- Please fill out this template to the best of your ability. You can always edit this issue once you have created it. --> <!--- Read the following link before you create a new problem report: https://kodi.wiki/view/HOW-TO:Submit_a_bug_report -->

Bug report

Describe the bug

Here is a clear and concise description of what the problem is: <!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug --> <!--- A bug report that is not clear will be closed --> <!--- Put your text below this line --> These two tests are failing for Kodi 19a1: TestDateTime.FileTimeOperators TestDateTime.SetFromUTCDateTime

Expected Behavior

Here is a clear and concise description of what was expected to happen: <!--- Tell us what should happen --> <!--- Put your text below this line --> Tests should pass :)

Actual Behavior

<!--- Tell us what happens instead --> <!--- Put your text below this line --> The tests fail. Here are some excerpts from LastTest.log:

444/547 Testing: TestDateTime.FileTimeOperators
444/547 Test: TestDateTime.FileTimeOperators
Command: "/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/kodi-19.0_alpha1_build/kodi-test" "--gtest_filter=TestDateTime.FileTimeOperators"
Directory: /var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/kodi-19.0_alpha1_build
"TestDateTime.FileTimeOperators" start time: Aug 17 06:48 CEST
Output:
----------------------------------------------------------
Note: Google Test filter = TestDateTime.FileTimeOperators
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestDateTime
[ RUN      ] TestDateTime.FileTimeOperators
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:43: Failure
Value of: dateTime1 < fileTime
  Actual: false
Expected: true
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:44: Failure
Value of: dateTime1 > fileTime
  Actual: true
Expected: false
[  FAILED  ] TestDateTime.FileTimeOperators (0 ms)
[----------] 1 test from TestDateTime (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (49 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestDateTime.FileTimeOperators

 1 FAILED TEST
Clean shutdown of TestGlobalPattern1
<end of output>
458/547 Testing: TestDateTime.SetFromUTCDateTime
458/547 Test: TestDateTime.SetFromUTCDateTime
Command: "/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/kodi-19.0_alpha1_build/kodi-test" "--gtest_filter=TestDateTime.SetFromUTCDateTime"
Directory: /var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/kodi-19.0_alpha1_build
"TestDateTime.SetFromUTCDateTime" start time: Aug 17 06:48 CEST
Output:
----------------------------------------------------------
Note: Google Test filter = TestDateTime.SetFromUTCDateTime
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestDateTime
[ RUN      ] TestDateTime.SetFromUTCDateTime
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:250: Failure
Expected equality of these values:
  dateTime3.GetYear()
    Which is: 1922
  1991
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:251: Failure
Expected equality of these values:
  dateTime3.GetMonth()
    Which is: 11
  5
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:253: Failure
Expected equality of these values:
  dateTime3.GetHour()
    Which is: 19
  12
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:254: Failure
Expected equality of these values:
  dateTime3.GetMinute()
    Which is: 36
  34
/var/tmp/portage/media-tv/kodi-19.0_alpha1-r1/work/xbmc-19.0a1-Matrix/xbmc/test/TestDateTime.cpp:255: Failure
Expected equality of these values:
  dateTime3.GetSecond()
    Which is: 26
  56
[  FAILED  ] TestDateTime.SetFromUTCDateTime (0 ms)
[----------] 1 test from TestDateTime (0 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (48 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestDateTime.SetFromUTCDateTime

 1 FAILED TEST
Clean shutdown of TestGlobalPattern1
<end of output>

Full LastLog.log: https://737544.bugs.gentoo.org/attachment.cgi?id=655024 build output: https://bugs.gentoo.org/attachment.cgi?id=655018

Possible Fix

<!--- Not obligatory, but suggest a fix or reason for the bug --> <!--- Put your text below this line -->

To Reproduce

Steps to reproduce the behavior: <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> <!--- Put your text below this line -->

  1. Run the Kodi 19a1 tests

Debuglog

<!--- Put your text below this line --> <!--- A debuglog is always mandatory when creating an issue. Provide one! --> The debuglog can be found here: n/a

Screenshots

Here are some links or screenshots to help explain the problem: <!--- Put your text below this line --> n/a

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help: <!--- How has this bug affected you? What were you trying to accomplish? --> <!--- Put your text below this line --> Originally reported at https://bugs.gentoo.org/737544

Your Environment

Used Operating system: <!--- Include as many relevant details about the environment you experienced the bug in --> <!--- Put your text below this line. Checkboxes can easily be ticked once issue is created -->

  • [ ] Android

  • [ ] iOS

  • [X] Linux

  • [ ] OSX

  • [ ] Raspberry-Pi

  • [ ] Windows

  • [ ] Windows UWP

  • Operating system version/name: Gentoo/Linux

  • Kodi version: 19a1

<!--- End of this issue --> note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

created time in a month

issue commentlukas-krecan/ShedLock

Include pid in lockedBy to support multiple instances on the same host

except a special case of extending a lock in some lock providers

That's the exact scenario I'm dealing with. I'm extend JDBC locks, and lockedBy is used in that case.

candrews

comment created time in a month

issue openedxbmc/xbmc

Compiling with MariaDB client that uses gnutls results in "DSO missing from command line"

<!--- Please fill out this template to the best of your ability. You can always edit this issue once you have created it. --> <!--- Read the following link before you create a new problem report: https://kodi.wiki/view/HOW-TO:Submit_a_bug_report -->

Bug report

Describe the bug

Here is a clear and concise description of what the problem is: <!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug --> <!--- A bug report that is not clear will be closed --> <!--- Put your text below this line -->

When compiling Kodi 19a1 against MariaDB client that was built with gnutls, the build fails with this error:

/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libmariadbclient.a(gnutls.c.o): undefined reference to symbol 'gnutls_certificate_type_get@@GNUTLS_3_4'
/usr/lib/gcc/x86_64-pc-linux-gnu/9.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: //usr/lib64/libgnutls.so.30: error adding symbols: DSO missing from command line

Expected Behavior

Here is a clear and concise description of what was expected to happen: <!--- Tell us what should happen --> <!--- Put your text below this line --> The build should not fail :)

Actual Behavior

<!--- Tell us what happens instead --> <!--- Put your text below this line --> Here's the full log: https://bugs.gentoo.org/attachment.cgi?id=654079

Possible Fix

<!--- Not obligatory, but suggest a fix or reason for the bug --> <!--- Put your text below this line --> I believe the problem is in https://github.com/xbmc/xbmc/blob/19.0a1-Matrix/cmake/modules/FindMariaDBClient.cmake I believe it should be including the MariaDB's dependency libraries (in this case, -lgnutls) in MARIADBCLIENT_LIBRARIES and it isn't doing that.

For reference, here's /usr/lib64/pkgconfig/libmariadb.pc that shows the required libraries:

# 
#  pkg_config.pc.in
#
#  pkg_config configuration file 
#  For a detailed description of options, please visit
#  Dan Nicholson’s Guide to pkg-config (http://www.freedesktop.org/wiki/Software/pkg-config/)
#

prefix=/usr
includedir=${prefix}/include
libdir=${prefix}/lib64

Name: libmariadb
Version: 3.1.9
URL: https://mariadb.com/kb/en/library/mariadb-connector-c/
Description: MariaDB Connector/C dynamic library
Cflags: -I${includedir}/mariadb
Libs: -L${libdir} -lmariadb
Libs.private: -lz -ldl -lm -lpthread -lgnutls

To Reproduce

Steps to reproduce the behavior: <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> <!--- Put your text below this line --> Build the mariadb client connector library with gnutls. Build Kodi with -DENABLE_MARIADBCLIENT=yes

Debuglog

<!--- Put your text below this line --> <!--- A debuglog is always mandatory when creating an issue. Provide one! --> The debuglog can be found here: n/a

Screenshots

Here are some links or screenshots to help explain the problem: <!--- Put your text below this line --> n/a

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help: <!--- How has this bug affected you? What were you trying to accomplish? --> <!--- Put your text below this line --> Originally reported at https://bugs.gentoo.org/736667

Your Environment

Used Operating system: <!--- Include as many relevant details about the environment you experienced the bug in --> <!--- Put your text below this line. Checkboxes can easily be ticked once issue is created -->

  • [ ] Android

  • [ ] iOS

  • [X] Linux

  • [ ] OSX

  • [ ] Raspberry-Pi

  • [ ] Windows

  • [ ] Windows UWP

  • Operating system version/name:

  • Kodi version: 19a1

<!--- End of this issue --> note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

created time in a month

pull request commentgentoo/gentoo

dev-libs/libcec: bump to 4.0.7, fixes and improvements

Kodi ebuild dependencies need to be updated as libcec-6.x (ebuild is not prepared yet) is not compatible with Leia.

Thank you! Can you please submit a PR when appropriate?

And thank you very much for all of your work, your contributions are greatly valued.

Karlson2k

comment created time in a month

PR opened ganskef/LittleProxy-mitm

Generate 2048 bit RSA certificates

More and more systems are requiring RSA certificates to be of at least 2048 bit strength.

For example, RHEL 8 and Fedora require 2048 bit or greater strength in their default configuration.

On systems which implement this security requirement, Java applications acting as a client to the this proxy fail to establish connections through it with this error:

java.security.cert.CertPathValidatorException: Algorithm constraints check failed on keysize limits. RSA 1024bit key used with certificate: OU=[something]  Usage was tls server
+1 -1

0 comment

1 changed file

pr created time in 2 months

push eventcandrews/LittleProxy-mitm

Craig Andrews

commit sha ee5f6e23dc5b527a71ff2270a9d6b0c5685ea26b

Generate 2048 bit RSA certificates More and more systems are requiring RSA certificates to be of at least 2048 bit strength.

view details

push time in 2 months

fork candrews/jfx

https://openjdk.java.net/projects/openjfx/

fork in 2 months

issue commentoktadeveloper/okta-aws-cli-assume-role

Error initializing QuantumRenderer: no suitable pipeline found

FYI, when running with java --module-path /usr/lib/jvm/openjfx --add-modules=javafx.base,javafx.graphics,javafx.controls,javafx.web,javafx.fxml on Fedora 33, it fails with:

java.lang.UnsatisfiedLinkError: no jfxwebkit in java.library.path

I've reported this issue to Fedora at https://bugzilla.redhat.com/show_bug.cgi?id=1866442

This same bug also exists in Ubuntu, reported at https://bugs.launchpad.net/ubuntu/+source/openjfx/+bug/1877000

berridgd

comment created time in 2 months

PR opened spring-projects/spring-framework

PingPongWebSocketHandlerDecorator schedules pings and replies to pongs

I've found it to be common for WebSockets clients to be required to issue pings and reply to pongs, or if not required to do so, want to do so in order to detect disconnects. In the interest of making this common chore easier for everyone to do, it would be nice for Spring to include PingPongWebSocketHandlerDecorator making it easy to implement that functionality.

+92 -0

0 comment

1 changed file

pr created time in 2 months

create barnchcandrews/spring-framework

branch : PingPongWebSocketHandlerDecorator

created branch time in 2 months

pull request commentfacebook/create-react-app

Conditionally drop console messages from production build

@iansu @amyrlam @mrmckeb @ianschmitz @petetnt Can you please take a look at this PR?

I believe that this approach to removing console statements from production builds is easy, safe, maintainable, and very much desirable for end users.

If there are further changes I can make to this PR to make it more acceptable and/or appealing, please let me know. I'm eager to get (or a functionally equivalent) change accepted.

Thanks again!

candrews

comment created time in 2 months

issue openedmultipath-tcp/mptcp

`curl http://www.multipath-tcp.org` reports incorrect result with Linux 5.6+

I've performed this test using Linux 5.7.10-201.fc32.x86_64 and 5.8.0-rc7-x86_64 both with the kernel configured with CONFIG_MPTCP=y and CONFIG_MPTCP_IPV6=y:

$ curl http://www.multipath-tcp.org
Nay, Nay, Nay, your have an old computer that does not speak MPTCP. Shame on you!

The result should be that mptcp is supported. It appears that http://www.multipath-tcp.org doesn't support MPTCP v1 that's included in Linux 5.6+.

created time in 2 months

PR opened spring-projects/spring-framework

CloseStatus implements Serializable

I wanted to use CloseStatus in another serializable class and noticed that it wasn't serializable.

There's no harm in making it serializable... so why not :)

+5 -1

0 comment

1 changed file

pr created time in 2 months

push eventcandrews/spring-framework

Craig Andrews

commit sha e43c21d92bb1b50f1ea953f2e5de947195879ef4

CloseStatus implements Serializable

view details

push time in 2 months

issue openedxbmc/xbmc

CVE-2014-3800: world-readable permissions for .kodi/userdata/sources.xml, which allows local users to obtain user names and passwords by reading this file

<!--- Please fill out this template to the best of your ability. You can always edit this issue once you have created it. --> <!--- Read the following link before you create a new problem report: https://kodi.wiki/view/HOW-TO:Submit_a_bug_report -->

Bug report

This problem goes way back to 2014: https://nvd.nist.gov/vuln/detail/CVE-2014-3800

Quoting the Debian bug:

I just add a webdav source in xbmc, so it asks for a username and password. But these informations are then stored in a plain XML file: ~/.xbmc/userdata/sources.xml, moreover a world readable file:

adrien ~/ $ ls -l .xbmc/userdata/sources.xml -rw-r--r-- 1 adrien adrien 1006 mai 8 16:34 .xbmc/userdata/sources.xml

This file should be at least chmod 700 and the users should be informed that the password will be stored in a unsafe manner.

The issue was reported to Trac at https://trac.kodi.tv/ticket/15198 but apparently the issue was lost with the migration off of Trac to GitHub.

It was also reported in Gentoo at https://bugs.gentoo.org/536366

As far as I can tell, this issue is still valid. ~/.kodi/userdata/sources.xml is 644 on my new installation of Kodi 19a1.

Describe the bug

Here is a clear and concise description of what the problem is: <!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug --> <!--- A bug report that is not clear will be closed --> <!--- Put your text below this line -->

~/.kodi/userdata/sources.xml is world readable and (potentially) contains sensitive information (usernames and passwords)

Expected Behavior

Here is a clear and concise description of what was expected to happen: <!--- Tell us what should happen --> <!--- Put your text below this line -->

~/.kodi/userdata/sources.xml should be at least 700.

Actual Behavior

<!--- Tell us what happens instead --> <!--- Put your text below this line -->

~/.kodi/userdata/sources.xml is world readable and (potentially) contains sensitive information (usernames and passwords)

Possible Fix

<!--- Not obligatory, but suggest a fix or reason for the bug --> <!--- Put your text below this line -->

~/.kodi/userdata/sources.xml should be at least 700.

To Reproduce

Steps to reproduce the behavior: <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> <!--- Put your text below this line -->

  1. Install Kodi
  2. Add a webdav source with a username and password

Note that ~/.kodi/userdata/sources.xml is world readable and contains that username and password.

Debuglog

<!--- Put your text below this line --> <!--- A debuglog is always mandatory when creating an issue. Provide one! --> The debuglog can be found here:

n/a

Screenshots

Here are some links or screenshots to help explain the problem: <!--- Put your text below this line -->

n/a

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help: <!--- How has this bug affected you? What were you trying to accomplish? --> <!--- Put your text below this line -->

n/a

Your Environment

Used Operating system: <!--- Include as many relevant details about the environment you experienced the bug in --> <!--- Put your text below this line. Checkboxes can easily be ticked once issue is created -->

  • [ ] Android

  • [ ] iOS

  • [X] Linux

  • [ ] OSX

  • [ ] Raspberry-Pi

  • [ ] Windows

  • [ ] Windows UWP

  • Operating system version/name: Linux

  • Kodi version: 19a1

<!--- End of this issue --> note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

created time in 2 months

PR opened xbmc/xbmc

[test] [webserver] Conditional TestHTTPDirectory

TestHTTPDirectory.cpp requires microhttpd so only include it if microhttpd is found.

TestHTTPDirectory.cpp includes network/WebServer.h which includes network/httprequesthandler/IHTTPRequestHandler.h which includes microhttpd.h

Description

TestHTTPDirectory.cpp fails to compile if microhttpd isn't available.

To fix this erroneously failing test, TestHTTPDirectory.cpp must only be included conditional upon the availability of microhttpd.

Additionally reported downstream at https://bugs.gentoo.org/734922

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here -->

Invalid test failures are bad.

How Has This Been Tested?

<!--- Please describe in detail how you tested your change --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc -->

Tests were run without microhttpd and they succeed.

Screenshots (if appropriate):

n/a

Types of change

<!--- What type of change does your code introduce? Put an x in all the boxes that apply like this: [X] -->

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [ ] Improvement (non-breaking change which improves existing functionality)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that will cause existing functionality to change)
  • [ ] Cosmetic change (non-breaking change that doesn't touch code)
  • [ ] None of the above (please explain below)

Checklist:

<!--- Go over all the following points, and put an X in all the boxes that apply like this: [X] --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the Code Guidelines of this project
  • [ ] My change requires a change to the documentation, either Doxygen or wiki
  • [ ] I have updated the documentation accordingly
  • [ ] I have read the Contributing document
  • [ ] I have added tests to cover my change
  • [ ] All new and existing tests passed
+4 -1

0 comment

1 changed file

pr created time in 2 months

push eventcandrews/xbmc

Craig Andrews

commit sha 3be79a564343886ade7e88f447944fd4b5452959

[test] [webserver] Conditional TestHTTPDirectory TestHTTPDirectory.cpp requires microhttpd so only include it if microhttpd is found. TestHTTPDirectory.cpp includes network/WebServer.h which includes network/httprequesthandler/IHTTPRequestHandler.h which includes microhttpd.h

view details

push time in 2 months

issue commentlukas-krecan/ShedLock

Unexpected LockConfiguration state

Is there a way to throw an exception if an attempt is made to use an invalid LockConfiguration because it's too old?

It would be ideal for the user to be alerted if they made the same mistake I did :)

candrews

comment created time in 2 months

issue openedxbmc/audiodecoder.timidity

2.3.0 fails to compile with -fno-common

When compiling with the -fno-common CFLAG (which is the default in GCC 10 and later), compilation fails. The first few of those errors are:

/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: lib/timidity/CMakeFiles/timidity_1.dir/timidity/sdl_c.c.o:(.bss+0x10): multiple definition of `global_pink_noise_light'; lib/timidity/CMakeFiles/timidity_1.dir/timidity/buffer_a.c.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: lib/timidity/CMakeFiles/timidity_1.dir/timidity/sdl_c.c.o:(.bss+0x40): multiple definition of `multi_eq_xg'; lib/timidity/CMakeFiles/timidity_1.dir/timidity/buffer_a.c.o:(.bss+0x20): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: lib/timidity/CMakeFiles/timidity_1.dir/timidity/sdl_c.c.o:(.bss+0x260): multiple definition of `eq_status_gs'; lib/timidity/CMakeFiles/timidity_1.dir/timidity/buffer_a.c.o:(.bss+0x240): first defined here

Here's the full build output: https://734934.bugs.gentoo.org/attachment.cgi?id=651842

Here's some background, including how to fix this issue: https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

Originally reported downstream at https://bugs.gentoo.org/734934

created time in 2 months

issue openedlukas-krecan/ShedLock

Unexpected LockConfiguration state

The current, non-deprecated LockConfiguration constructor uses only Duration arguments: https://github.com/lukas-krecan/ShedLock/blob/shedlock-parent-4.12.0/shedlock-core/src/main/java/net/javacrumbs/shedlock/core/LockConfiguration.java#L45

This implies that it isn't tied to the current time. Yet, it is. This constructor calls ClockProvider.now() and saves that result: https://github.com/lukas-krecan/ShedLock/blob/shedlock-parent-4.12.0/shedlock-core/src/main/java/net/javacrumbs/shedlock/core/LockConfiguration.java#L56

This unexpected internal state means that a LockConfiguration cannot be reused and cannot be static initialized which I found to be unexpected.

I believe that the fix is to remove the LockConfiguration.createdAt field and change the LockConfiguration.getLockAtMostUntil and LockConfiguration.getLockAtLeastUntil methods to calculate based on ClockProvider.now() instead of createdAt.

Describe the bug I'm using shedlock 4.12.0 with the JdbcTemplateLockProvider

Using this Spring configuration:

import java.time.Duration;

import javax.sql.DataSource;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.scheduling.annotation.EnableScheduling;
import org.springframework.scheduling.annotation.Scheduled;

import lombok.NonNull;
import lombok.extern.slf4j.Slf4j;
import net.javacrumbs.shedlock.core.LockConfiguration;
import net.javacrumbs.shedlock.core.LockProvider;
import net.javacrumbs.shedlock.provider.jdbctemplate.JdbcTemplateLockProvider;
import net.javacrumbs.shedlock.spring.annotation.EnableSchedulerLock;

@Configuration
@EnableScheduling
@EnableSchedulerLock(defaultLockAtMostFor = "PT10M")
@Slf4j
public class TestSchedulingConfiguration {
	@Bean("alphaLockProvider")
	public LockProvider alphaLockProvider(final @NonNull DataSource dataSource) {
		return new JdbcTemplateLockProvider(JdbcTemplateLockProvider.Configuration.builder()
				.withJdbcTemplate(new JdbcTemplate(dataSource))
				.withLockedByValue("ALPHA")
				.build());
	}

	@Bean("betaLockProvider")
	public LockProvider betaLockProvider(final @NonNull DataSource dataSource) {
		return new JdbcTemplateLockProvider(JdbcTemplateLockProvider.Configuration.builder()
				.withJdbcTemplate(new JdbcTemplate(dataSource))
				.withLockedByValue("BETA")
				.build());
	}

	private static final LockConfiguration LOCK_CONFIGURATION = new LockConfiguration(
		"lock",
		Duration.ofSeconds(10),
		Duration.ofSeconds(10));

	@Autowired
	@Qualifier("alphaLockProvider")
	private LockProvider alphaLockProvider;

	@Autowired
	@Qualifier("betaLockProvider")
	private LockProvider betaLockProvider;

	@Scheduled(fixedRateString = "PT5S")
	public void doLocking() {
		alphaLockProvider.lock(LOCK_CONFIGURATION)
			.ifPresentOrElse(lock -> {
				log.info("ALPHA got the lock");
			},
			() -> {
				log.info("ALPHA nope the lock");
			});

		betaLockProvider.lock(LOCK_CONFIGURATION)
			.ifPresentOrElse(lock -> {
				log.info("BETA got the lock - THIS SHOULD NEVER HAPPEN");
			},
			() -> {
				log.info("BETA nope the lock");
			});
	}
}

Expected behavior The log output is expected to be:

ALPHA got the lock
BETA nope the lock

repeating endlessly.

Actual behavior What happened instead:

The actual log output is:

ALPHA got the lock
BETA got the lock - THIS SHOULD NEVER HAPPEN

repeating endlessly.

created time in 2 months

issue commentlukas-krecan/ShedLock

Include pid in lockedBy to support multiple instances on the same host

Some people are deploying JVM using Kubernetes and in Docker the PID is usually useless information.

Hostname alone is not unique. If I run 2 instances of my application on my system right now, both will show the same hostname.

PID alone is also not unique. If I run my application in docker or k8s two times, both instances will report the same pid: 1.

But, hostname+pid is (I believe) always unique. On docker and k8s, each running container has a uniquely generated hostname, so hostname+pid is unique there. And on more traditional systems, pid is always unique, so hostname+pid is unique.

Therefore, if the default value of lockedBy is changed to be pid+hostname, it will always be unique no matter which mechanism is used to run the application, which is how it should be.

Out of curiosity, what are you using lockedBy column for?

I'm running the same application on my system twice. I expected one instance of the application to get the lock - but instead, both instances are able to get the lock (which is clearly bad :) ). I tracked the cause down to both instances having the same lockedBy value.

candrews

comment created time in 2 months

issue openedlukas-krecan/ShedLock

Include pid in lockedBy to support multiple instances on the same host

Is your feature request related to a problem? Please describe. Currently, lockedBy defaults to the host name. For example, see https://github.com/lukas-krecan/ShedLock/blob/5a4dc62c76b66a7bb94b2f3d476989c37c833aa1/providers/jdbc/shedlock-provider-jdbc/src/main/java/net/javacrumbs/shedlock/provider/jdbc/JdbcStorageAccessor.java#L54

If two instances of the same application are running on the same host, then both instances will use the same lockedBy resulting in incorrect behavior.

Describe the solution you'd like It would be nice if lockedBy could include information uniquely identifying the instance of the JVM, for example, the PID. On Java 9, you can get the pid using ProcessHandle:

java.lang.ProcessHandle.current().pid()

Spring Boot gets the pid in a different way, from https://github.com/spring-projects/spring-boot/blob/v2.3.2.RELEASE/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/system/ApplicationPid.java#L54 :

private String getPid() {
	try {
		String jvmName = ManagementFactory.getRuntimeMXBean().getName();
		return jvmName.split("@")[0];
	}
	catch (Throwable ex) {
		return null;
	}
}

Describe alternatives you've considered When constructing the lock provider, the lockBy value can be provided, for example:

new JdbcTemplateLockProvider(
		JdbcTemplateLockProvider
		.Configuration
		.builder()
		.withLockedByValue(java.lang.ProcessHandle.current().pid() + "@" + net.javacrumbs.shedlock.support.Utils.getHostname())
		.build());

However, I think this behavior should be in place by default.

created time in 2 months

fork candrews/ShedLock

Distributed lock for your scheduled tasks

fork in 2 months

push eventcandrews/gentoo

Marek Szuba

commit sha 09891e5757fc1abb7796a1599cda33c7f6f9f0f8

app-dicts/sword-KJV: bump to 2.9 Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Marek Szuba

commit sha d671b406676fbfac9416f66d946211519fa2f89d

app-dicts/sword-KJVA: new package Like sword-KJV but with Apocrypha included. Used by the app-text/bibletime test suite. Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Marek Szuba

commit sha 6a8dcd02ceac9388b7547bd5f22a188e98664488

app-dicts/sword-Scofield: update for eclass changes Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Marek Szuba

commit sha f1d755ebdf6a262e5857be3b7356fbf83e0ed5d0

app-dicts/sword-Josephus: update for eclass changes Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Marek Szuba

commit sha 8bfb581303432ff4c66be03e3b56ce71ede44914

app-dicts/sword-StrongsGreek: update for eclass changes Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Marek Szuba

commit sha 224079f76c16f43bc97b542ff8ec5c1608b55d2a

app-text/sword-modules: add last-rite replacements to the list Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Alexis Ballier

commit sha 4e19f232564148cb085e7f367f79c44e6a9c2f56

dev-ros/rospy_tutorials: set proper search path for tests Closes: https://bugs.gentoo.org/624782 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Alexis Ballier <aballier@gentoo.org>

view details

Alexis Ballier

commit sha 42b36a01c6a1020fb97ef1e1ed03c891ec718b9b

dev-python/python_orocos_kdl: Fix build with latest sip Patch from upstream backported by Victor Mataré. Closes: https://bugs.gentoo.org/728618 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Alexis Ballier <aballier@gentoo.org>

view details

Andreas Sturmlechner

commit sha 73649720a3f8b0428c33202f359bd8f7af85b989

profiles: Mask media-sound/moosic for removal Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

view details

Andreas Sturmlechner

commit sha b13f34640eeec7f6236aef90ae6c7fdafa810bcf

profiles: Mask media-sound/positron for removal Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

view details

Andreas Sturmlechner

commit sha e5705989874600a31626af28a41bcffeac923c82

profiles: Mask media-sound/edna for removal Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

view details

Marek Szuba

commit sha 227bb472c1463e0293717d46b67a5f7345207d81

media-plugins/vamp-aubio-plugins: update to a py3-compatible waf Committed with permission of aballier (on behalf of proaudio@g.o.). Signed-off-by: Marek Szuba <marecki@gentoo.org>

view details

Sam James

commit sha 50f93655b131369bbd8c051ef0b3e896ef25887c

net-libs/libetpan: ppc64 stable (bug #734130) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha 737a40792b84cbdb774ea65c87045a82c19cb92b

net-vpn/tor: ppc64 stable (bug #732644) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha fdb70cdfbb86234cd64d95f895cf852226ac5994

app-text/recode: ppc64 stable (bug #717054) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha 68068c015478f2c0ddd8df0aca6ecb03388c966a

net-libs/libetpan: ppc stable (bug #734130) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha 23e3697dc11c40c9f94ea87394f4dd67364fd63b

net-vpn/tor: ppc stable (bug #732644) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha 7af79a12ad5b302bec010b68ddcc1301b6ec34bb

app-text/recode: ppc stable (bug #717054) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha d270cdbb21cf21310ee2752e0c9c993d14b972ad

dev-libs/rapidjson: arm64 stable (bug #734100) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

Sam James

commit sha 86840a40c1b63fcc55dfcbf299e937595c5b7b59

dev-util/valgrind: arm64 stable (bug #734100) Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Sam James <sam@gentoo.org>

view details

push time in 2 months

push eventcandrews/gentoo

Craig Andrews

commit sha 2a8c7ff4bfb1c946ecc51419fc4642bd2a120e37

media-plugins/kodi-imagedecoder-heif: 1.3.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha f32436fb33bc49bb6484cf3551c618f6528d0e24

media-plugins/kodi-imagedecoder-raw: 3.0.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 0bf1e2ee4f631df5b4701f5af1890a6564084142

media-plugins/kodi-inputstream-adaptive: 2.6.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha cd7350b33a1114b7f57f3f3db545e9b8d2848e10

media-plugins/kodi-inputstream-rtmp: 3.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 5683b3dfed6b9c9952dddc215c5624cb05121987

media-plugins/kodi-peripheral-joystick: 1.6.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha cb6caa59c203b057d6b76f74df731ba0f1feaa9a

media-plugins/kodi-peripheral-steamcontroller: Remove media-libs/kodi-platform Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha d59ca5eef3984a2b2df9c1abac616e052ad53598

media-plugins/kodi-pvr-argustv: 6.0.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha bc0050f999c347915dbf0032d965f99b8b1dbd76

media-plugins/kodi-pvr-demo: 6.0.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha f89cedc025be8e7353bb403e48614fd0cdca0b39

media-plugins/kodi-pvr-dvblink: 7.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha f6b7c88888bc850c3d9d0eea0ccb8306663f9fd0

media-plugins/kodi-pvr-dvbviewer: 6.0.6 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 0d6f8879290f8abc9eecf1d0179e9d333ef10c59

media-plugins/kodi-pvr-filmon: 5.1.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha f01e86fdef62cfa5f85932f4139d4885ab417d72

media-plugins/kodi-pvr-hts: 7.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 20ecfacd906cac4ac32b0bf7041317ddb2d1ae40

media-plugins/kodi-pvr-iptvsimple: 6.2.4 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 48e2d51fa224bc47c6f0c77fc17e7558ef57af45

media-plugins/kodi-pvr-mediaportal-tvserver: 6.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 24e766997c30afe994df8c83de48f270f8476fe3

media-plugins/kodi-pvr-mythtv: 7.0.5 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 8ea4ed8c0a7722d9933d0c15aac032cafe1571af

media-plugins/kodi-pvr-nextpvr: 6.0.5 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha cd0bda2ca294a5561a96cda1146a00a8e91b95b3

media-plugins/kodi-pvr-njoy: 6.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 89d1387847577f132af2344bafc06ec3b2d2fedb

media-plugins/kodi-pvr-pctv: 5.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 0733d4da57ef3ceaaaf67ea20fbb8bf04f52f7c9

media-plugins/kodi-pvr-stalker: 6.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 0f8e517a8f24bc7742bd6ecfcf8241eb84ca31c9

media-plugins/kodi-pvr-vbox: 7.0.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

push time in 2 months

create barnchcandrews/gentoo

branch : kodi-19

created branch time in 2 months

push eventcandrews/gentoo

Craig Andrews

commit sha c514c13ca76594c416f1d1d660e9dc55f5fdd936

media-tv/kodi: 19.0_alpha1 version bump Bug: https://bugs.gentoo.org/717538 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha ada8ee48f3997ad8fba9b5447be4a30a65dff398

media-plugins/kodi-audiodecoder-modplug: 2.1.3 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 21af70cf83c94d362576f13b60f18aa723699326

media-plugins/kodi-audiodecoder-nosefart: 2.3.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha cb0cc84cf7a15ec8ae14b3b0b8b4a52074b94eb7

media-plugins/kodi-audiodecoder-sidplay: 2.1.3 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha b80702ecc79537f379de39d287fab4555fc544fd

media-plugins/kodi-audiodecoder-snesapu: 2.1.3 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha f74be3ed4f7a924f2f3cbdec3a7bcef280d828e1

media-plugins/kodi-audiodecoder-stsound: 2.1.3 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 369064287acff4d16282c1e0e320773178e7170f

media-plugins/kodi-audiodecoder-timidity: 2.3.0 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha c0a52d792217540e3ecec801b234e7dbaf2828c4

media-plugins/kodi-audiodecoder-vgmstream: 2.1.2 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 21a30865ad95c426633481ce9456cab9e3739a91

media-plugins/kodi-audioencoder-flac: 2.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 94a3583fb08414ddcee3a671bb0781d1a8b3368f

media-plugins/kodi-audioencoder-lame: 2.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 22f57afa96c0eded250d9d1411d3330ef9a0b0d6

media-plugins/kodi-audioencoder-vorbis: 2.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Craig Andrews

commit sha 17bbaf8f82bf81a057568740f5a09f42e759ba78

media-plugins/kodi-audioencoder-wav: 2.1.1 version bump Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

push time in 2 months

PR opened gentoo/gentoo

media-tv/kodi: 19.0_alpha1 version bump
+779 -30

0 comment

34 changed files

pr created time in 2 months

pull request commentgentoo/gentoo

media-libs/libde265: bump to 1.0.5 and ebuild fixes

* Added missing RDEPEND for virtual/pkgconfig

Are you sure that pkgconfig is used at runtime?

Karlson2k

comment created time in 2 months

pull request commentgentoo/gentoo

media-libs/libde265: bump to 1.0.5 and ebuild fixes

You can't add keywords like this - they need to go through the keywording process. I see there's already a keywording request: https://bugs.gentoo.org/734060

Karlson2k

comment created time in 2 months

pull request commentfacebook/create-react-app

Conditionally drop console messages from production build

@eddiemonge @ianschmitz what are your thoughts on this?

I believe it addresses the concerns expressed in my earlier PR, and I think it would be a great improvement to CRA.

Thanks in advance!

candrews

comment created time in 2 months

issue openedrenovatebot/config-help

Commits not being signed

What Renovate type are you using?

<!-- Tell us if you're using the hosted App, or if you are self-hosted Renovate yourself. Platform too (GitHub, GitLab, etc) if you think it's relevant. -->

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

$ renovate --version
21.29.3

Platform is GitLab.

Describe the bug

<!-- A clear and concise description of what the bug is. -->

Renovate is not signing commits even though gitPrivateKey and gitAuthor are set.

Based on my reading of the debug logs, it seems Renovate should be signing commits; it seems to set itself up to do so, but then it just doesn't happen.

Relevant debug logs

<!-- Try not to raise a bug report unless you've looked at the logs first. If you're running self-hosted, run with --log-level=debug or LOG_LEVEL=debug and search for whatever dependency/branch/PR that is causing the problem. If you are using the Renovate App, log into https://app.renovatebot.com/dashboard and locate the correct job log for when the problem occurred (e.g. when the PR was created). The Job ID will help us locate it. -->

Here are some relevant log fragments from running: renovate --print-config true --include-forks true candrews/REDACTED --log-level debug --log-file logs.txt

DEBUG: gradle.updateDependency(): packageFile:settings.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/owasp.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/node.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:build.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Updating packageFile content (repository=candrews/REDACTED, packageFile=build.gradle, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "depName": "com.vladmihalcea:hibernate-types-52"
DEBUG: Updated 1 package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Getting updated lock files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: lock file dirs (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing repo .npmrc (/tmp/renovate/repos/gitlab/candrews/REDACTED) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing package.json files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "packageFiles": ["package.json", "react-app/package.json"]
DEBUG: Writing .yarnrc to /tmp/renovate/repos/gitlab/candrews/REDACTED (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing any updated package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: No updated lock files in branch (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: 1 file(s) to commit (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Committing files to branch renovate/com.vladmihalcea-hibernate-types-52-2.x (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Setting git private key (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "gpg --import /tmp/git-private.key"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "gpg --import /tmp/git-private.key",
       "durationMs": 74,
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Private key import result (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config user.signingkey 508D503C0FA40A21"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config user.signingkey 508D503C0FA40A21",
       "durationMs": 41,
       "stdout": "",
       "stderr": ""
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config commit.gpgsign true"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config commit.gpgsign true",
       "durationMs": 43,
       "stdout": "",
       "stderr": ""
 INFO: Branch created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "commitHash": "d95d008"
DEBUG: Ensuring PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: There are 0 errors and 0 warnings (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: getBranchPr(renovate/com.vladmihalcea-hibernate-types-52-2.x) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Got res with 0 results (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Creating PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Creating Merge Request: Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
 INFO: PR created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "pr": 9,
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Created Merge Request renovatebot/renovate#9 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Checking renovatebot/renovate#9 for automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)

When I look at commit d95d008 in Gitlab, it's not signed. I also checked using the git command, and confirmed that the commit is not signed.

To Reproduce

<!-- To fix a bug, we nearly always need a minimal repo to reproduce it in, before verifying that our fix works using the same repo. If you provide a public repo that already reproduces the problem, then your bug will get highest priority for fixing. If you can't reproduce it in a simple repo, do your best to describe how it could be reproduced, or under what circumstances the bug occurs. -->

Using this config.js:

const gitPrivateKey = process.env.GIT_PRIVATE_KEY ? process.env.GIT_PRIVATE_KEY.replace(/\\n/g, '\n') : undefined;
module.exports = {
    platform: 'gitlab',
    endpoint: 'https://git.REDACTED/api/v4/',
    gitAuthor: "Renovate Service <service-renovate@REDACTED>",
    gitPrivateKey: gitPrivateKey,
    labels: ["renovate"],
    logLevel: 'debug',
    printConfig: true,
    trustLevel: 'high'
    onboardingConfig: { extends: ["config:base"] },
};

Before running renovate, run:

export GIT_PRIVATE_KEY="-----BEGIN PGP PRIVATE KEY BLOCK-----

lQc...
...
...
=4SWI
-----END PGP PRIVATE KEY BLOCK-----"

MRs created by Renovate should be signed, but the commits in them are not.

Additional context

<!-- Add any other context about the problem here, including your own debugging or ideas on what went wrong. -->

I'm not sure... it really looks like signing should be happening. :thinking:

created time in 2 months

issue commentPrivateBin/PrivateBin

Chrome 83.0.4103. download issue

I reported this issue to Chrome at https://bugs.chromium.org/p/chromium/issues/detail?id=1106906 Content Security Policy standard does not define "allow-downloads" for the sandbox directive

vmazyliukTW

comment created time in 2 months

pull request commentwhatwg/html

Add spec for 'sandboxed downloads' flag

With this feature in production, we are now looking for a recommended way web application can implement a very common use-case, that is a download button implemented as an anchor tag.

As we are not directly using any iframes, I cannot see where we would be setting the 'allow-donwloads' flag.

I suspect you're using Chrome and experiencing this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1106906

xyaoinum

comment created time in 2 months

issue commentrenovatebot/renovate

Commits not being signed

Thank you for that debug mode lead, I hadn't noticed those instructions. I'll do that :)

candrews

comment created time in 2 months

issue commentrenovatebot/renovate

Commits not being signed

Have you added the signing public key to renovate's user on gitlab? You can see in the logs that Renovate is setting everything as designed.

I have, yes.

You should also check out the branch locally and run git log --show-signature

I did, and the commit made by renovate is not signed.

candrews

comment created time in 2 months

issue closedrenovatebot/config-help

Commits not being signed

<!-- Please make sure to fill out this questionnaire. You don't need to delete any of the html comments like these ones -->

Which Renovate are you using?

<!-- Delete those that don't apply -->

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

$ renovate --version
21.29.3

Which platform are you using?

<!-- Delete those that don't apply -->

GitLab self-hosted

Have you checked the logs? Don't forget to include them if relevant

Here are some relevant log fragments from running: renovate --print-config true --include-forks true candrews/REDACTED --log-level debug --log-file logs.txt

DEBUG: gradle.updateDependency(): packageFile:settings.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/owasp.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/node.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:build.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Updating packageFile content (repository=candrews/REDACTED, packageFile=build.gradle, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "depName": "com.vladmihalcea:hibernate-types-52"
DEBUG: Updated 1 package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Getting updated lock files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: lock file dirs (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing repo .npmrc (/tmp/renovate/repos/gitlab/candrews/REDACTED) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing package.json files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "packageFiles": ["package.json", "react-app/package.json"]
DEBUG: Writing .yarnrc to /tmp/renovate/repos/gitlab/candrews/REDACTED (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing any updated package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: No updated lock files in branch (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: 1 file(s) to commit (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Committing files to branch renovate/com.vladmihalcea-hibernate-types-52-2.x (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Setting git private key (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "gpg --import /tmp/git-private.key"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "gpg --import /tmp/git-private.key",
       "durationMs": 74,
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Private key import result (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config user.signingkey 508D503C0FA40A21"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config user.signingkey 508D503C0FA40A21",
       "durationMs": 41,
       "stdout": "",
       "stderr": ""
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config commit.gpgsign true"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config commit.gpgsign true",
       "durationMs": 43,
       "stdout": "",
       "stderr": ""
 INFO: Branch created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "commitHash": "d95d008"
DEBUG: Ensuring PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: There are 0 errors and 0 warnings (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: getBranchPr(renovate/com.vladmihalcea-hibernate-types-52-2.x) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Got res with 0 results (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Creating PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Creating Merge Request: Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
 INFO: PR created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "pr": 9,
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Created Merge Request #9 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Checking #9 for automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)

When I look at commit d95d008 in Gitlab, it's not signed. I also checked using the git command, and confirmed that the commit is not signed.

<!-- You can find them at https://app.renovatebot.com/dashboard if you're using the WhiteSource Renovate app -->

What would you like to do?

<!-- Maybe you came here because you reached a "dead end" with config and now have a particular question. But don't forget to tell us what you really set out to achieve in the first place, because maybe there's a better way or we can help you better if we understand what your original goal was -->

I'd like Renovate to sign its commits.

I have gitPrivateKey and gitAuthor set, but the commits aren't being signed.

What am doing wrong?

closed time in 2 months

candrews

issue commentrenovatebot/config-help

Commits not being signed

Since I've followed the configuration documentation, I don't think this is a configuration problem on my part. Therefore, I reported: https://github.com/renovatebot/renovate/issues/6778

candrews

comment created time in 2 months

issue openedrenovatebot/renovate

Commits not being signed

What Renovate type are you using?

<!-- Tell us if you're using the hosted App, or if you are self-hosted Renovate yourself. Platform too (GitHub, GitLab, etc) if you think it's relevant. -->

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

$ renovate --version
21.29.3

Platform is GitLab.

Describe the bug

<!-- A clear and concise description of what the bug is. -->

Renovate is not signing commits even though gitPrivateKey and gitAuthor are set.

Based on my reading of the debug logs, it seems Renovate should be signing commits; it seems to set itself up to do so, but then it just doesn't happen.

Relevant debug logs

<!-- Try not to raise a bug report unless you've looked at the logs first. If you're running self-hosted, run with --log-level=debug or LOG_LEVEL=debug and search for whatever dependency/branch/PR that is causing the problem. If you are using the Renovate App, log into https://app.renovatebot.com/dashboard and locate the correct job log for when the problem occurred (e.g. when the PR was created). The Job ID will help us locate it. -->

Here are some relevant log fragments from running: renovate --print-config true --include-forks true candrews/REDACTED --log-level debug --log-file logs.txt

DEBUG: gradle.updateDependency(): packageFile:settings.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/owasp.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/node.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:build.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Updating packageFile content (repository=candrews/REDACTED, packageFile=build.gradle, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "depName": "com.vladmihalcea:hibernate-types-52"
DEBUG: Updated 1 package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Getting updated lock files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: lock file dirs (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing repo .npmrc (/tmp/renovate/repos/gitlab/candrews/REDACTED) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing package.json files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "packageFiles": ["package.json", "react-app/package.json"]
DEBUG: Writing .yarnrc to /tmp/renovate/repos/gitlab/candrews/REDACTED (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing any updated package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: No updated lock files in branch (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: 1 file(s) to commit (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Committing files to branch renovate/com.vladmihalcea-hibernate-types-52-2.x (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Setting git private key (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "gpg --import /tmp/git-private.key"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "gpg --import /tmp/git-private.key",
       "durationMs": 74,
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Private key import result (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config user.signingkey 508D503C0FA40A21"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config user.signingkey 508D503C0FA40A21",
       "durationMs": 41,
       "stdout": "",
       "stderr": ""
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config commit.gpgsign true"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config commit.gpgsign true",
       "durationMs": 43,
       "stdout": "",
       "stderr": ""
 INFO: Branch created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "commitHash": "d95d008"
DEBUG: Ensuring PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: There are 0 errors and 0 warnings (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: getBranchPr(renovate/com.vladmihalcea-hibernate-types-52-2.x) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Got res with 0 results (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Creating PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Creating Merge Request: Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
 INFO: PR created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "pr": 9,
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Created Merge Request #9 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Checking #9 for automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)

When I look at commit d95d008 in Gitlab, it's not signed. I also checked using the git command, and confirmed that the commit is not signed.

To Reproduce

<!-- To fix a bug, we nearly always need a minimal repo to reproduce it in, before verifying that our fix works using the same repo. If you provide a public repo that already reproduces the problem, then your bug will get highest priority for fixing. If you can't reproduce it in a simple repo, do your best to describe how it could be reproduced, or under what circumstances the bug occurs. -->

Using this config.js:

const gitPrivateKey = process.env.GIT_PRIVATE_KEY ? process.env.GIT_PRIVATE_KEY.replace(/\\n/g, '\n') : undefined;
module.exports = {
    platform: 'gitlab',
    endpoint: 'https://git.REDACTED/api/v4/',
    gitAuthor: "Renovate Service <service-renovate@REDACTED>",
    gitPrivateKey: gitPrivateKey,
    labels: ["renovate"],
    logLevel: 'debug',
    printConfig: true,
    trustLevel: 'high'
    onboardingConfig: { extends: ["config:base"] },
};

Before running renovate, run:

export GIT_PRIVATE_KEY="-----BEGIN PGP PRIVATE KEY BLOCK-----

lQc...
...
...
=4SWI
-----END PGP PRIVATE KEY BLOCK-----"

MRs created by Renovate should be signed, but the commits in them are not.

Additional context

<!-- Add any other context about the problem here, including your own debugging or ideas on what went wrong. -->

I'm not sure... it really looks like signing should be happening. :thinking:

created time in 2 months

issue commentrenovatebot/renovate

Provide custom environment variable configuration option

I think a new admin option could be ok: an array of strings, that lists env variables to pass through for child processes.

I think instead of only allowing pass through, it would be better to specify both name and values for environment variables available to the child processes as given in the description of this issue. That way, the admin could calculate new environment variables, or modify existing ones, as appropriate. For example, I have a use case where I have an environment variable containing a username, another containing a password, and a third containing a URL, and I'd like to use javascript in config.js to combine the 3 into a new environment variable containing a URL with the username and password embedded in it.

I had also been thinking about letting repo configs specify literal env variable values to pass through, until I saw this article that made me think we need some controls: https://www.elttam.com/blog/env/

Agreed - this should be an admin-only config.js configuration option.

candrews

comment created time in 2 months

issue commentrenovatebot/renovate

Provide custom environment variable configuration option

renovate version and platform

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

$ renovate --version
21.29.3

Thanks!

candrews

comment created time in 2 months

issue openedrenovatebot/config-help

Commits not being signed

<!-- Please make sure to fill out this questionnaire. You don't need to delete any of the html comments like these ones -->

Which Renovate are you using?

<!-- Delete those that don't apply -->

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

$ renovate --version
21.29.3

Which platform are you using?

<!-- Delete those that don't apply -->

GitLab self-hosted

Have you checked the logs? Don't forget to include them if relevant

Here are some relevant log fragments from running: renovate --print-config true --include-forks true candrews/REDACTED --log-level debug --log-file logs.txt

DEBUG: gradle.updateDependency(): packageFile:settings.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/owasp.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:gradle/node.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: gradle.updateDependency(): packageFile:build.gradle depName:com.vladmihalcea:hibernate-types-52, version:2.4.2 ==> 2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Updating packageFile content (repository=candrews/REDACTED, packageFile=build.gradle, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "depName": "com.vladmihalcea:hibernate-types-52"
DEBUG: Updated 1 package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Getting updated lock files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: lock file dirs (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "dirs": {
         "yarnLockDirs": [],
         "npmLockDirs": [],
         "pnpmShrinkwrapDirs": [],
         "lernaDirs": []
       }
DEBUG: Writing repo .npmrc (/tmp/renovate/repos/gitlab/candrews/REDACTED) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing package.json files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "packageFiles": ["package.json", "react-app/package.json"]
DEBUG: Writing .yarnrc to /tmp/renovate/repos/gitlab/candrews/REDACTED (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Writing any updated package files (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: No updated lock files in branch (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: 1 file(s) to commit (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Committing files to branch renovate/com.vladmihalcea-hibernate-types-52-2.x (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Setting git private key (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "gpg --import /tmp/git-private.key"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "gpg --import /tmp/git-private.key",
       "durationMs": 74,
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Private key import result (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "stdout": "",
       "stderr": "gpg: directory '/home/ubuntu/.gnupg' created\ngpg: keybox '/home/ubuntu/.gnupg/pubring.kbx' created\ngpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created\ngpg: key 508D503C0FA40A21: public key \"Renovate Bot <service-renovate@REDACTED>\" imported\ngpg: key 508D503C0FA40A21: secret key imported\ngpg: Total number processed: 1\ngpg:               imported: 1\ngpg:       secret keys read: 1\ngpg:   secret keys imported: 1\n"
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config user.signingkey 508D503C0FA40A21"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config user.signingkey 508D503C0FA40A21",
       "durationMs": 41,
       "stdout": "",
       "stderr": ""
DEBUG: Executing command (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "command": "git config commit.gpgsign true"
DEBUG: exec completed (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "cmd": "git config commit.gpgsign true",
       "durationMs": 43,
       "stdout": "",
       "stderr": ""
 INFO: Branch created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "commitHash": "d95d008"
DEBUG: Ensuring PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: There are 0 errors and 0 warnings (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: getBranchPr(renovate/com.vladmihalcea-hibernate-types-52-2.x) (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Got res with 0 results (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Creating PR (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Creating Merge Request: Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
 INFO: PR created (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "pr": 9,
       "prTitle": "Update dependency com.vladmihalcea:hibernate-types-52 to v2.9.12"
DEBUG: Created Merge Request #9 (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
DEBUG: Checking #9 for automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)
       "automerge": false,
       "automergeType": "pr",
       "automergeComment": "automergeComment"
DEBUG: No automerge (repository=candrews/REDACTED, branch=renovate/com.vladmihalcea-hibernate-types-52-2.x)

When I look at commit d95d008 in Gitlab, it's not signed. I also checked using the git command, and confirmed that the commit is not signed.

<!-- You can find them at https://app.renovatebot.com/dashboard if you're using the WhiteSource Renovate app -->

What would you like to do?

<!-- Maybe you came here because you reached a "dead end" with config and now have a particular question. But don't forget to tell us what you really set out to achieve in the first place, because maybe there's a better way or we can help you better if we understand what your original goal was -->

I'd like Renovate to sign its commits.

I have gitPrivateKey and gitAuthor set, but the commits aren't being signed.

What am doing wrong?

created time in 2 months

issue openedrenovatebot/renovate

Provide custom environment variable configuration option

What would you like Renovate to be able to do?

With trustLevel set to low, no environment variables are passed through.

With trustLevel set to high, all environment variables are passed through.

I'd love to see another option, where custom environment variables can be provided.

<!-- A clear and concise description of what problem needs solving. Make sure you describe what you "really" are trying to achieve (the bigger picture) as that often helps. -->

Did you already have any implementation ideas?

One approach would be for config.js to have a new option, "environment" demonstrated by this configuration:

module.exports = {
    environment: {
        MY_VAR: "my value",
        PASSED_THROUGH: process.env.PASSED_THROUGH
    }
}

Ideally, this would work with trustLevel set to low.

<!-- This is totally optional, but we know many people dig into the source code already before raising a request. Try to keep implementation ideas separate from requirements above -->

Are there any workarounds or alternative ideas you've tried to avoid needing this feature? Not really... setting trustLevel to high exposes all environment variables, and there are some that I really don't want to expose (such as the git private key).

Is this a feature you'd be interested in implementing yourself? Probably not? I'm fluent in a number of languages, but typescript isn't currently one of them. <!-- Again, totally optional. But let us know if you're interested and if you need any particular help -->

created time in 2 months

issue commentcurl/curl

alt-svc cache file grows unbounded

Could it be a problem in Kodi's side? If so, do you have any hints as to what to look for in the code there?

candrews

comment created time in 2 months

issue commentrenovatebot/config-help

Github always returning Unauthorized

Also - thank you very much for help. I realized I forgot to say that before, and I'm sorry for that.

Seriously, thank you.

candrews

comment created time in 2 months

issue commentrenovatebot/docker-renovate

Docker image does not contain config-validator anymore

This is expected, should we provide a config-validator global shortcut too, like the global renovate command ?

Yes, please!

Lucas-C

comment created time in 2 months

issue commentrenovatebot/config-help

Github always returning Unauthorized

The problem ended up being that there is no btoa function defined in node... I had to use Buffer.from(something).toString('base64') instead.

Can renovate display a better error when this happens? This log output:

{
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "config": {},
    "msg": "File config",
    "time": "2020-07-14T20:14:09.156Z",
    "v": 0
}

Is not clearly indicating a config.js parsing error... and it would be really nice if it could. Even better, this stdout/stderror output:

FATAL: Authentication failure
 INFO: Renovate is exiting with a non-zero code due to the following logged errors
       "loggerErrors": [
         {
           "name": "renovate",
           "level": 60,
           "logContext": "TAXNK1fYr",
           "msg": "Authentication failure"
         }
       ]

should really say that config.js is invalid/unparseable, not that there's an authentication failure.

candrews

comment created time in 2 months

issue commentcloudflare/quiche

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o

I think this is a compiler bug that happens with certain optimizations... The simplest CFLAGS I've come up with that reproduce this issue are -O2 -floop-nest-optimize

Here's the error output in that case:

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc -DBORINGSSL_DISPATCH_TEST -DBORINGSSL_HAVE_LIBUNWIND -DBORINGSSL_IMPLEMENTATION -DOPENSSL_NO_ASM -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/third_party/googletest/include -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/../include -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/../../include  -DNDEBUG -O2 -floop-nest-optimize -fPIC -Werror -Wformat=2 -Wsign-compare -Wmissing-field-initializers -Wwrite-strings -Wvla -ggdb -Wall -fvisibility=hidden -fno-common -Wno-free-nonheap-object -Wimplicit-fallthrough -Wmissing-prototypes -Wold-style-definition -Wstrict-prototypes -Wshadow -std=c11 -D_XOPEN_SOURCE=700 -MD -MT crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o -MF crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o.d -o crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o -c /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c
In file included from /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c:31:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/ec/simple.c: In function ‘ec_affine_jacobian_equal’:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/../internal.h:363:38: error: ‘({anonymous})’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  363 |   return constant_time_msb_w(~a & (a - 1));
      |                                   ~~~^~~~
In file included from /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c:76:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/ec/simple.c:287:5: note: ‘({anonymous})’ was declared here
  287 | int ec_affine_jacobian_equal(const EC_GROUP *group, const EC_AFFINE *a,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.

I'm eager to learn if this information allows you to reproduce the issue on Debian.

candrews

comment created time in 2 months

issue openedrenovatebot/config-help

Github always returning Unauthorized

<!-- Please make sure to fill out this questionnaire. You don't need to delete any of the html comments like these ones -->

Which Renovate are you using?

<!-- Delete those that don't apply -->

Renovate Open Source CLI (Self hosted, docker, renovate/renovate:latest)

Which platform are you using?

GitLab self-hosted

Have you checked the logs? Don't forget to include them if relevant

Here's the log:

{
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "config": {},
    "msg": "File config",
    "time": "2020-07-14T20:14:09.156Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "config": {
        "dryRun": true,
        "logFile": "/tmp/log"
    },
    "msg": "CLI config",
    "time": "2020-07-14T20:14:09.157Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "config": {
        "hostRules": [{
            "hostType": "github",
            "domainName": "github.com",
            "token": "***********"
        }],
        "token": "***********"
    },
    "msg": "Env config",
    "time": "2020-07-14T20:14:09.157Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "config": {
        "hostRules": [{
            "hostType": "github",
            "domainName": "github.com",
            "token": "***********"
        }],
        "token": "***********",
        "dryRun": true,
        "logFile": "/tmp/log"
    },
    "msg": "Combined config",
    "time": "2020-07-14T20:14:09.157Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "msg": "Using default github endpoint: https://api.github.com/",
    "time": "2020-07-14T20:14:09.158Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "token": "***********",
    "err": {
        "name": "HTTPError",
        "hostname": "api.github.com",
        "method": "GET",
        "path": "/user",
        "protocol": "https:",
        "url": "https://api.github.com/user",
        "gotOptions": {
            "path": "/user",
            "protocol": "https:",
            "hostname": "api.github.com",
            "hash": "",
            "search": "",
            "pathname": "/user",
            "href": "https://api.github.com/user",
            "retry": {
                "methods": {},
                "statusCodes": {},
                "errorCodes": {}
            },
            "headers": {
                "user-agent": "https://github.com/renovatebot/renovate",
                "accept": "application/vnd.github.v3+json",
                "authorization": "***********",
                "accept-encoding": "gzip, deflate"
            },
            "hooks": {
                "beforeRequest": [],
                "beforeRedirect": [null],
                "beforeRetry": [],
                "afterResponse": [],
                "beforeError": [],
                "init": []
            },
            "decompress": true,
            "throwHttpErrors": true,
            "followRedirect": true,
            "stream": false,
            "form": false,
            "json": true,
            "cache": false,
            "useElectronNet": false,
            "method": "GET",
            "hostType": "github",
            "baseUrl": "https://api.github.com/"
        },
        "statusCode": 401,
        "statusMessage": "Unauthorized",
        "headers": {
            "server": "GitHub.com",
            "date": "Tue, 14 Jul 2020 20:14:09 GMT",
            "content-type": "application/json; charset=utf-8",
            "content-length": "83",
            "connection": "close",
            "status": "401 Unauthorized",
            "x-github-media-type": "github.v3; format=json",
            "x-ratelimit-limit": "60",
            "x-ratelimit-remaining": "53",
            "x-ratelimit-reset": "1594758606",
            "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
            "access-control-allow-origin": "*",
            "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
            "x-frame-options": "deny",
            "x-content-type-options": "nosniff",
            "x-xss-protection": "1; mode=block",
            "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
            "content-security-policy": "default-src 'none'",
            "vary": "Accept-Encoding, Accept, X-Requested-With",
            "x-github-request-id": "DECA:3533:528ED7:C4FAD4:5F0E1211"
        },
        "body": {
            "message": "Bad credentials",
            "documentation_url": "https://developer.github.com/v3"
        },
        "message": "Response code 401 (Unauthorized)",
        "stack": "HTTPError: Response code 401 (Unauthorized)\n    at EventEmitter.<anonymous> (/usr/src/app/node_modules/got/source/as-promise.js:74:19)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)"
    },
    "msg": "GitHub failure: Bad credentials",
    "time": "2020-07-14T20:14:09.291Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "err": {
        "hostType": "github",
        "err": {
            "name": "HTTPError",
            "hostname": "api.github.com",
            "method": "GET",
            "path": "/user",
            "protocol": "https:",
            "url": "https://api.github.com/user",
            "gotOptions": {
                "path": "/user",
                "protocol": "https:",
                "hostname": "api.github.com",
                "hash": "",
                "search": "",
                "pathname": "/user",
                "href": "https://api.github.com/user",
                "retry": {
                    "methods": {},
                    "statusCodes": {},
                    "errorCodes": {}
                },
                "headers": {
                    "user-agent": "https://github.com/renovatebot/renovate",
                    "accept": "application/vnd.github.v3+json",
                    "authorization": "***********",
                    "accept-encoding": "gzip, deflate"
                },
                "hooks": {
                    "beforeRequest": [],
                    "beforeRedirect": [null],
                    "beforeRetry": [],
                    "afterResponse": [],
                    "beforeError": [],
                    "init": []
                },
                "decompress": true,
                "throwHttpErrors": true,
                "followRedirect": true,
                "stream": false,
                "form": false,
                "json": true,
                "cache": false,
                "useElectronNet": false,
                "method": "GET",
                "hostType": "github",
                "baseUrl": "https://api.github.com/"
            },
            "statusCode": 401,
            "statusMessage": "Unauthorized",
            "headers": {
                "server": "GitHub.com",
                "date": "Tue, 14 Jul 2020 20:14:09 GMT",
                "content-type": "application/json; charset=utf-8",
                "content-length": "83",
                "connection": "close",
                "status": "401 Unauthorized",
                "x-github-media-type": "github.v3; format=json",
                "x-ratelimit-limit": "60",
                "x-ratelimit-remaining": "53",
                "x-ratelimit-reset": "1594758606",
                "access-control-expose-headers": "ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset",
                "access-control-allow-origin": "*",
                "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
                "x-frame-options": "deny",
                "x-content-type-options": "nosniff",
                "x-xss-protection": "1; mode=block",
                "referrer-policy": "origin-when-cross-origin, strict-origin-when-cross-origin",
                "content-security-policy": "default-src 'none'",
                "vary": "Accept-Encoding, Accept, X-Requested-With",
                "x-github-request-id": "DECA:3533:528ED7:C4FAD4:5F0E1211"
            },
            "body": {
                "message": "Bad credentials",
                "documentation_url": "https://developer.github.com/v3"
            }
        },
        "message": "external-host-error",
        "stack": "Error: external-host-error\n    at handleGotError (/usr/src/app/node_modules/renovate/dist/util/http/github.js:67:19)\n    at GithubHttp.request (/usr/src/app/node_modules/renovate/dist/util/http/github.js:155:13)\n    at processTicksAndRejections (internal/process/task_queues.js:97:5)"
    },
    "msg": "Error authenticating with GitHub",
    "time": "2020-07-14T20:14:09.293Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 60,
    "logContext": "TAXNK1fYr",
    "msg": "Authentication failure",
    "time": "2020-07-14T20:14:09.294Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 20,
    "logContext": "TAXNK1fYr",
    "msg": "Renovate exiting",
    "time": "2020-07-14T20:14:09.295Z",
    "v": 0
} {
    "name": "renovate",
    "hostname": "1aa5ca955860",
    "pid": 36,
    "level": 30,
    "logContext": "TAXNK1fYr",
    "loggerErrors": [{
        "name": "renovate",
        "level": 60,
        "logContext": "TAXNK1fYr",
        "msg": "Authentication failure"
    }],
    "msg": "Renovate is exiting with a non-zero code due to the following logged errors",
    "time": "2020-07-14T20:14:09.295Z",
    "v": 0
}

<!-- You can find them at https://app.renovatebot.com/dashboard if you're using the WhiteSource Renovate app -->

What would you like to do?

I'm trying to run renovate against my Gitlab instance.

I've created a Github Token using my Github account, and I've provided that token in the GITHUB_COM_TOKEN environment variable when I run docker like this: docker run -e GITHUB_COM_TOKEN="4...e" -e NEXUS_USERNAME="service-renovate" -e NEXUS_PASSWORD="redacted" -e NEXUS_URL="https://repo.redacted" -e RENOVATE_TOKEN="D...z" --rm -v "$(pwd)/config.js:/usr/src/app/config.js:Z"

Renovate fails with this output:

FATAL: Authentication failure
 INFO: Renovate is exiting with a non-zero code due to the following logged errors
       "loggerErrors": [
         {
           "name": "renovate",
           "level": 60,
           "logContext": "TAXNK1fYr",
           "msg": "Authentication failure"
         }
       ]

I know the token is valid - I've tested it using curl like this: curl -H "Authorization: token 4...e" https://api.github.com

Here's my configuration:

const nexusUsername = process.env.NEXUS_USERNAME;
const nexusPassword = process.env.NEXUS_PASSWORD;
const nexusUrl = process.env.NEXUS_URL;
const gitPrivateKey = process.env.GIT_PRIVATE_KEY ? process.env.GIT_PRIVATE_KEY.replace(/\\n/g, '\n') : undefined;
const npmAuth = btoa(nexusUsername + ":" + nexusPassword);

if(! nexusUsername){
    console.log("The NEXUS_USERNAME environment variable must be set")
    process.exit(1);
}
if(! nexusPassword){
    console.log("The NEXUS_PASSWORD environment variable must be set")
    process.exit(1);
}

module.exports = {
    platform: 'gitlab',
    endpoint: 'https://git.redacted/api/v4/',
    packageRules: [{
        managers: ["gradle"],
        registryUrls: ["https://plugins.gradle.org/m2/"]
    }, {
        managers: ["maven", "gradle"],
        registryUrls: [nexusUrl + "/repository/maven-public/", nexusUrl + "/repository/redacted-releases/"]
    },
    {
        managers: ["npm"],
        registryUrls: [nexusUrl + "/repository/npm-public/"]
    }],
    hostRules: [{
        hostName: "repo.redacted",
        username: nexusUsername,
        password: nexusPassword
    },
    {
        hostName: "registry.redacted",
        username: nexusUsername,
        password: nexusPassword
    }],
    gitAuthor: "Renovate Service <service-renovate@redacted>",
    gitPrivateKey: gitPrivateKey,
    labels: ["renovate"],
    ignoreNpmrcFile: true,
    npmrc: "registry=" + nexusUrl + "/repository/npm-public/\nalways-auth=truei\n_auth=\"\"",
    logLevel: 'debug',
    onboardingConfig: { extends: ["config:base"] },
    autodiscover: true
};

I cannot figure out how to get Renovate to work with a Github token... can you help please?

created time in 2 months

issue commentcloudflare/quiche

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o

I have CFLAGS="-fno-common" (the default in GCC 10) and the failure occurs.

If I use CFLAGS="-fcommon" the build succeed. I'm guessing Debian is overriding the GCC default configuration.

So this is a bug and it should be fixed as it is manifested when using the default GCC configuration. See https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common too

candrews

comment created time in 2 months

issue commentcloudflare/quiche

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o

Which C compiler and version are you using?

$ gcc --version
gcc (Gentoo 10.1.0-r2 p3) 10.1.0
candrews

comment created time in 2 months

issue openedcloudflare/quiche

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o

Building quiche 0.5.0, I'm getting this failure:

FAILED: crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-gcc -DBORINGSSL_DISPATCH_TEST -DBORINGSSL_HAVE_LIBUNWIND -DBORINGSSL_IMPLEMENTATION -DOPENSSL_NO_ASM -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/third_party/googletest/include -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/../include -I/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/../../include  -DNDEBUG -O2 -march=native -pipe -fuse-linker-plugin -flto -Wl,-flto -ftree-vectorize -falign-functions=32 -fgraphite-identity -floop-nest-optimize -fno-common -fno-lto -fno-use-linker-plugin -fPIC -Werror -Wformat=2 -Wsign-compare -Wmissing-field-initializers -Wwrite-strings -Wvla -ggdb -Wall -fvisibility=hidden -fno-common -Wno-free-nonheap-object -Wimplicit-fallthrough -Wmissing-prototypes -Wold-style-definition -Wstrict-prototypes -Wshadow -std=c11 -D_XOPEN_SOURCE=700 -MD -MT crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o -MF crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o.d -o crypto/fipsmodule/CMakeFiles/fipsmodule.dir/bcm.c.o -c /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c
In file included from /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c:31:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/ec/simple.c: In function ‘ec_affine_jacobian_equal’:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/../internal.h:363:38: error: ‘({anonymous})’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  363 |   return constant_time_msb_w(~a & (a - 1));
      |                                   ~~~^~~~
In file included from /var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/bcm.c:76:
/var/tmp/portage/net-libs/quiche-0.5.0/work/quiche-0.5.0/deps/boringssl/crypto/fipsmodule/ec/simple.c:287:5: note: ‘({anonymous})’ was declared here
  287 | int ec_affine_jacobian_equal(const EC_GROUP *group, const EC_AFFINE *a,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.

created time in 2 months

issue openedxbmc/xbmc

Python 2 is dead; need a Kodi 19 / Python 3 release

<!--- Please fill out this template to the best of your ability. You can always edit this issue once you have created it. --> <!--- Read the following link before you create a new problem report: https://kodi.wiki/view/HOW-TO:Submit_a_bug_report -->

Bug report

Describe the bug

Here is a clear and concise description of what the problem is: <!--- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug --> <!--- A bug report that is not clear will be closed --> <!--- Put your text below this line -->

Python 2 is dead; it was sunset January 1, 2020. It is not being maintained at all - including for security purposes.

Therefore, in my opinion, Kodi really needs to make a release (or at least a pre-release version) of Kodi 19 available. Otherwise, distributions will being to stop distributing Kodi, negatively impacting its users.

For example, one major problem right now is that Kodi requires pillow, and pillow 6.2.2 (the last version to support Python 2) has multiple security issues:

  • CVE-2020-10177 Fix multiple OOB reads in FLI decoding
  • CVE-2020-10378 Fix bounds overflow in PCX decoding
  • CVE-2020-10379 Fix two buffer overflows in TIFF decoding
  • CVE-2020-10994 Fix bounds overflow in JPEG 2000 decoding
  • CVE-2020-11538 Fix buffer overflow in SGI-RLE decoding

Users (and distributions) have to use known, insecure, unmaintained software (Python 2 and pillow 6.2.2) if they want to use Kodi. Gentoo is considering last riting Kodi for this reason: https://bugs.gentoo.org/717538 I'm confident other distros will soon have the same conversation, if they're not already having it.

Expected Behavior

Here is a clear and concise description of what was expected to happen: <!--- Tell us what should happen --> <!--- Put your text below this line --> Kodi should not require known insecure, unmaintained dependencies.

Actual Behavior

<!--- Tell us what happens instead --> <!--- Put your text below this line --> Kodi is dependent upon unmaintained software with CVEs reported against it.

Possible Fix

<!--- Not obligatory, but suggest a fix or reason for the bug --> <!--- Put your text below this line --> Release Kodi 19 (or at least a pre-release version)

To Reproduce

Steps to reproduce the behavior: <!--- Provide a link to a live example, or an unambiguous set of steps to --> <!--- reproduce this bug. Include code to reproduce, if relevant --> <!--- Put your text below this line --> n/a

Debuglog

<!--- Put your text below this line --> <!--- A debuglog is always mandatory when creating an issue. Provide one! --> n/a

Screenshots

Here are some links or screenshots to help explain the problem: <!--- Put your text below this line --> n/a

Additional context or screenshots (if appropriate)

n/a

Your Environment

Used Operating system: <!--- Include as many relevant details about the environment you experienced the bug in --> <!--- Put your text below this line. Checkboxes can easily be ticked once issue is created -->

  • [X] Android

  • [X] iOS

  • [X] Linux

  • [X] OSX

  • [X] Raspberry-Pi

  • [X] Windows

  • [X] Windows UWP

  • Operating system version/name:

  • Kodi version: 18.7.1

<!--- End of this issue --> note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

created time in 2 months

push eventcandrews/xbmc

Kai Sommerfeld

commit sha 67bd433e9d372146d136603be077ab1d144708aa

[PVR] CGUIEPGGridContainer: Update layout early in GUI thread, not in timeline refresh thread, for performance and thread safety reasons (fix a race).

view details

Kai Sommerfeld

commit sha 723e603f8a42b236308107eabe19b179f134c586

[PVR] Make CGUIEPGGridContainer::UpdateLayout thread-safe; some of the modified members will be read by timeline refresh thread.

view details

Kai Sommerfeld

commit sha 1bcc91bb25b58b94a973c1b470b15505ef38d607

Merge pull request #18056 from ksooo/leia-pvr-fix-epg-container-race Leia pvr fix epg container race

view details

Craig Andrews

commit sha 4fd1f82baff32232c6e0866870eb7dac6ea5b0bc

[webserver] Compatibility with libmicrohttpd 0.9.71 From the libmicrohttpd 0.9.71 release notes: The release introduces an 'enum MHD_Result' instead of for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change _will_ cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

view details

push time in 3 months

push eventcandrews/xbmc

Kai Sommerfeld

commit sha bfd958ad0840ae2b3cbdf9ada7739aae6677be9e

[PVR] CGUIEPGGridContainer: Update layout early in GUI thread, not in timeline refresh thread, for performance and thread safety reasons (fix a race).

view details

Kai Sommerfeld

commit sha 9fd67eaf34d09173673331a2bc4666ce740d9c2b

[PVR] Make CGUIEPGGridContainer::UpdateLayout thread-safe; some of the modified members will be read by timeline refresh thread.

view details

Craig Andrews

commit sha ebdfa46e78d7a68d761c4ee0ebd7f76eefeee340

[webserver] Compatibility with libmicrohttpd 0.9.71 From the libmicrohttpd 0.9.71 release notes: The release introduces an 'enum MHD_Result' instead of for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change _will_ cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

view details

push time in 3 months

issue openedJayDDee/cpuminer-opt

Fails to build with LLVM

cpuminer-opt fails to compile with LLVM. Here's full build output: https://731678.bugs.gentoo.org/attachment.cgi?id=648302

There are a few errors... here's one of them:

In file included from util.c:27:
./sysinfos.c:1:2: warning: 'SYSINJFOS_C___' is used as a header guard here,
      followed by #define of a different macro [-Wheader-guard]
#if !defined(SYSINJFOS_C___)
 ^~
./sysinfos.cIn file included from cpu-miner.c:40:
./sysinfos.c:1:2: warning: 'SYSINJFOS_C___' is used as a header guard here,
      followed by #define of a different macro [-Wheader-guard]
#if !defined(SYSINJFOS_C___)
 ^~
./sysinfos.c:2:9: note: 'SYSINFOS_C__' is defined here; did you mean
      'SYSINJFOS_C___'?
#define SYSINFOS_C__
        ^~~~~~~~~~~~
        SYSINJFOS_C___
:2:9: note: 'SYSINFOS_C__' is defined here; did you mean
      'SYSINJFOS_C___'?
#define SYSINFOS_C__
        ^~~~~~~~~~~~
        SYSINJFOS_C___

This issue was originally reported downstream at https://bugs.gentoo.org/731678

created time in 3 months

pull request commentxbmc/xbmc

[Leia] [webserver] Compatibility with libmicrohttpd 0.9.71

Isn't there already a backport pr open? #18134

There is.. but that PR isn't up to date with what actually went into master. This one is.

candrews

comment created time in 3 months

PR opened xbmc/xbmc

[Leia] [webserver] Compatibility with libmicrohttpd 0.9.71

Description

Backport of https://github.com/xbmc/xbmc/pull/18131 to Leia

The release introduces an 'enum MHD_Result' instead of for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change will cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

Description

<!--- Provide a general summary of your change in the Pull Request title above --> <!--- Describe your change in detail here -->

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Kodi currently fails to build against libmicrohttpd 0.9.71

Here's the release announcement from libmicrohttpd 0.9.71: https://lists.gnu.org/archive/html/libmicrohttpd/2020-06/msg00013.html I believe this to be the significant part:

Furthermore, the release introduces an 'enum MHD_Result' instead of #defines for MHD_YES/MHD_NO. This is intended to make it easier to check for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change will cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

If you want your code to build without warnings on both older and newer MHD releases, you may want to introduce a MHD_RESULT as done here:

https://git.gnunet.org/gnunet.git/tree/src/include/gnunet_mhd_compat.h

How Has This Been Tested?

<!--- Please describe in detail how you tested your change --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc --> Built on my system and the build succeed and Kodi works.

Screenshots (if appropriate):

n/a

Types of change

<!--- What type of change does your code introduce? Put an x in all the boxes that apply like this: [X] -->

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [ ] Improvement (non-breaking change which improves existing functionality)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that will cause existing functionality to change)
  • [ ] Cosmetic change (non-breaking change that doesn't touch code)
  • [ ] None of the above (please explain below)

Checklist:

<!--- Go over all the following points, and put an X in all the boxes that apply like this: [X] --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the Code Guidelines of this project
  • [ ] My change requires a change to the documentation, either Doxygen or wiki
  • [ ] I have updated the documentation accordingly
  • [X] I have read the Contributing document
  • [ ] I have added tests to cover my change
  • [X] All new and existing tests passed
+386 -262

0 comment

15 changed files

pr created time in 3 months

create barnchcandrews/xbmc

branch : leia-mhd-0.9.71

created branch time in 3 months

pull request commentxbmc/xbmc

[webserver] Compatibility with libmicrohttpd 0.9.71

Squash b425d3c into d0c0823 and fix the C-style cast, then good to merge from my side +1

Done!

candrews

comment created time in 3 months

Pull request review commentxbmc/xbmc

[webserver] Compatibility with libmicrohttpd 0.9.71

 int CWebServer::AskForAuthentication(const HTTPRequest& request) const    LogResponse(request, MHD_HTTP_UNAUTHORIZED); -  ret =-      MHD_queue_basic_auth_fail_response(request.connection, CCompileInfo::GetAppName(), response);+  // This MHD_RESULT cast is only necessary for libmicrohttpd 0.9.71+  // The return type of MHD_queue_basic_auth_fail_response was fixed for future versions+  // See+  // https://git.gnunet.org/libmicrohttpd.git/commit/?id=860b42e9180da4dcd7e8690a3fcdb4e37e5772c5+  ret = (MHD_RESULT)MHD_queue_basic_auth_fail_response(request.connection,

Change to static_cast<MHD_RESULT>(MHD_queue_basic_auth_fail_response(request.connection, CCompileInfo::GetAppName(), response));

candrews

comment created time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha cb95e541be594f5716d0141ef6b4331afc7b6fba

[webserver] Compatibility with libmicrohttpd 0.9.71 From the libmicrohttpd 0.9.71 release notes: The release introduces an 'enum MHD_Result' instead of for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change _will_ cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

view details

Craig Andrews

commit sha 51fa35f2d3b100bfa04143e2efc9bef46679fb8d

[webserver] run clang-format

view details

push time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha b425d3c0458b4acf08bcb315c5a1e5a5e75cb816

[webserver] use "using" instead of "#define" for MHD_RESULT

view details

push time in 3 months

Pull request review commentxbmc/xbmc

[webserver] Compatibility with libmicrohttpd 0.9.71

 #include <sys/socket.h> #include <sys/types.h> +#if MHD_VERSION >= 0x00097002+#define MHD_RESULT enum MHD_Result+#else+#define MHD_RESULT int+#endif+

I tested that and it worked fine. I've added a commit to this PR with that change.

candrews

comment created time in 3 months

PR closed gabime/spdlog

Define FMT_USE_INTERNAL for fmt 7.0.0

fmt 7.0.0 renamed the internal namespace to detail. The former is still provided as an alias if the FMT_USE_INTERNAL macro is defined.

See: https://github.com/fmtlib/fmt/issues/1538

+5 -1

1 comment

1 changed file

candrews

pr closed time in 3 months

pull request commentgabime/spdlog

Define FMT_USE_INTERNAL for fmt 7.0.0

https://github.com/gabime/spdlog/pull/1606 is a better approach; closing this PR in favor of that one.

candrews

comment created time in 3 months

PR opened gabime/spdlog

fmt 7.0.0 renamed the internal namespace to detail.

See: https://github.com/fmtlib/fmt/issues/1538

Fixes: https://github.com/gabime/spdlog/issues/1604

+9 -1

0 comment

1 changed file

pr created time in 3 months

create barnchcandrews/spdlog

branch : fmt-7

created branch time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha d0c08238eee5f2bad901df41800a9999ca7df156

[webserver] Compatibility with libmicrohttpd 0.9.71 From the libmicrohttpd 0.9.71 release notes: The release introduces an 'enum MHD_Result' instead of for certain API misuse bugs by providing better types (not everything is an 'int'). While this does NOT change the binary API, this change _will_ cause compiler warnings for all legacy code -- until 'int' is replaced with 'enum MHD_Result'.

view details

Craig Andrews

commit sha 485f6519a9569b1323bd70bd7233321cd8959dd4

[webserver] run clang-format

view details

push time in 3 months

Pull request review commentxbmc/xbmc

[webserver] Compatibility with libmicrohttpd 0.9.71

 #include <sys/socket.h> #include <sys/types.h> +#include <microhttpd.h>

Thanks!

candrews

comment created time in 3 months

issue commentgabime/spdlog

spdlog does not build with latest fmt lib

Pull request addressing this issue: https://github.com/gabime/spdlog/pull/1605

dpriedel

comment created time in 3 months

PR opened gabime/spdlog

Define FMT_USE_INTERNAL for fmt 7.0.0

fmt 7.0.0 renamed the internal namespace to detail. The former is still provided as an alias if the FMT_USE_INTERNAL macro is defined.

See: https://github.com/fmtlib/fmt/issues/1538

+5 -1

0 comment

1 changed file

pr created time in 3 months

push eventcandrews/spdlog

Craig Andrews

commit sha 7212aa41444317ce96700592b31552ca041f4f58

Define FMT_USE_INTERNAL for fmt 7.0.0 fmt 7.0.0 renamed the internal namespace to detail. The former is still provided as an alias if the FMT_USE_INTERNAL macro is defined. See: https://github.com/fmtlib/fmt/issues/1538

view details

push time in 3 months

fork candrews/spdlog

Fast C++ logging library.

fork in 3 months

more