profile
viewpoint

candrews/callerid-for-android 15

The CallerID Android application uses a web service to provide CallerID information when the phone rings, or when a user inputs a phone number to lookup. The web service the project uses is Free Software – see https://gitorious.org/callerid-service It’s incredibly simple right now – but hopefully I’ll have the attention span to add some awesome, or even better, someone else will help me along.

candrews/abendbrot 0

Desktop oriented overlay for various ebuilds and the occasional gamer

candrews/add-to-homescreen 0

Add to home screen call-out for mobile devices

candrews/AkamaiOPEN-edgegrid-java 0

Java library for Akamai OPEN EdgeGrid Client Authentication

candrews/amazon-sqs-java-messaging-lib 0

This Amazon SQS Java Messaging Library holds the Java Message Service compatible classes, that are used for communicating with Amazon Simple Queue Service.

candrews/AndroidAsync 0

Asynchronous socket, http (client+server), websocket, and socket.io library for android. Based on nio, not threads.

candrews/apt-package-whitelist 0

Whitelist of apt packages approved for build environments with restricted sudo

pull request commentxbmc/xbmc

[curl] Enable alt-svc if available

@Rechi can this be merged please?

candrews

comment created time in 9 days

pull request commentxbmc/xbmc

[curl] Enable alt-svc if available

Please follow the current code guidelines.

I've updated the PR addressing the style issues.

candrews

comment created time in 12 days

push eventcandrews/xbmc

Craig Andrews

commit sha 5efea8301202d17e863a6aeb7c4d53f0f73852e0

[curl] Enable alt-svc cache if available Enable alt-svc cache when using a version of curl (7.64.1 or later) that was compiled with alt-svc support (as of 7.66.0, it's disabled by default). This file is used as the Alt-Svc cache to read existing cache contents from and possibly also write back to after a transfer. See: https://daniel.haxx.se/blog/2019/03/03/alt-svc-in-curl/

view details

push time in 12 days

Pull request review commentxbmc/xbmc

[curl] Enable alt-svc if available

 void CCurlFile::SetCommonOptions(CReadState* state, bool failOnError /* = true *   else     // enable HTTP2 support. default: CURL_HTTP_VERSION_1_1. Curl >= 7.62.0 defaults to CURL_HTTP_VERSION_2TLS     g_curlInterface.easy_setopt(h, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);++  const CURLcode altSvcCacheResult = g_curlInterface.easy_setopt(h, CURLOPT_ALTSVC, m_curlAltSvcCachePath.c_str());+  if (altSvcCacheResult == CURLE_OK)+  {+    CLog::Log(LOGDEBUG, "CCurlFile::SetCommonOptions - alt svc path set to %s", m_curlAltSvcCachePath.c_str());+  }+  else+  {+    CLog::Log(LOGERROR, "CCurlFile::SetCommonOptions - failed to set alt svc path to %s with result code {}", m_curlAltSvcCachePath.c_str(), altSvcCacheResult);

Thanks, I've added new lines to meet the line length constraint.

candrews

comment created time in 12 days

Pull request review commentxbmc/xbmc

[curl] Enable alt-svc if available

 void CCurlFile::SetCommonOptions(CReadState* state, bool failOnError /* = true *   else     // enable HTTP2 support. default: CURL_HTTP_VERSION_1_1. Curl >= 7.62.0 defaults to CURL_HTTP_VERSION_2TLS     g_curlInterface.easy_setopt(h, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);++  const CURLcode altSvcCacheResult = g_curlInterface.easy_setopt(h, CURLOPT_ALTSVC, m_curlAltSvcCachePath.c_str());+  if (altSvcCacheResult == CURLE_OK)+  {+    CLog::Log(LOGDEBUG, "CCurlFile::SetCommonOptions - alt svc path set to %s", m_curlAltSvcCachePath.c_str());

Thanks, I've added new lines to meet the line length constraint.

candrews

comment created time in 12 days

Pull request review commentxbmc/xbmc

[curl] Enable alt-svc if available

 void CCurlFile::SetCommonOptions(CReadState* state, bool failOnError /* = true *   else     // enable HTTP2 support. default: CURL_HTTP_VERSION_1_1. Curl >= 7.62.0 defaults to CURL_HTTP_VERSION_2TLS     g_curlInterface.easy_setopt(h, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);++  const CURLcode altSvcCacheResult = g_curlInterface.easy_setopt(h, CURLOPT_ALTSVC, m_curlAltSvcCachePath.c_str());

Thanks, I've added new lines to meet the line length constraint.

candrews

comment created time in 12 days

issue openedcurl/curl

CURLOPT_ALTSVC_CTRL man page: DEFAULT is incorrect

<!-- Only file bugs here! Ask questions on the mailing lists https://curl.haxx.se/mail/

 SECURITY RELATED? Post it here: https://hackerone.com/curl

 There are collections of known issues to be aware of:
 https://curl.haxx.se/docs/knownbugs.html
 https://curl.haxx.se/docs/todo.html       -->

I did this

https://curl.haxx.se/libcurl/c/CURLOPT_ALTSVC_CTRL.html says:

DEFAULT 0. No Alt-Svc treatment.

But, the code says https://github.com/curl/curl/blob/curl-7_68_0/lib/altsvc.c#L256 :

  /* set default behavior */
  asi->flags = CURLALTSVC_H1
#ifdef USE_NGHTTP2
    | CURLALTSVC_H2
#endif
#ifdef ENABLE_QUIC
    | CURLALTSVC_H3
#endif

So the documented default is wrong.

I expected the following

The documentation to be agree with the code :)

curl/libcurl version

$ curl --version
curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1d zlib/1.2.11 brotli/1.0.7 libidn2/2.3.0 libssh2/1.9.0_DEV nghttp2/1.40.0 quiche/0.2.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtmp rtsp scp sftp smtp smtps telnet tftp 
Features: alt-svc AsynchDNS brotli HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM SSL TLS-SRP UnixSockets

operating system

# uname -a
Linux irrational 5.4.0-rc6 #2 SMP Fri Nov 8 19:09:49 EST 2019 x86_64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux

created time in 12 days

push eventcandrews/xbmc

Craig Andrews

commit sha 5ee0faf8acd2bbac957ebf4107ae695fec0def09

[curl] Enable alt-svc cache if available Enable alt-svc cache when using a version of curl (7.64.1 or later) that was compiled with alt-svc support (as of 7.66.0, it's disabled by default). This file is used as the Alt-Svc cache to read existing cache contents from and possibly also write back to after a transfer. See: https://daniel.haxx.se/blog/2019/03/03/alt-svc-in-curl/

view details

push time in 12 days

issue openedcurl/curl

alt-svc should fallback if alt-svc doesn't work

<!-- Only file bugs here! Ask questions on the mailing lists https://curl.haxx.se/mail/

 SECURITY RELATED? Post it here: https://hackerone.com/curl

 There are collections of known issues to be aware of:
 https://curl.haxx.se/docs/knownbugs.html
 https://curl.haxx.se/docs/todo.html       -->

I did this

Using curl with alt-svc support compiled in:

$ curl --alt-svc test.txt https://integralblue.com
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="https://www.integralblue.com/">here</a>.</p>
<hr>
<address>Apache Server at integralblue.com Port 443</address>
</body></html>

$ curl --alt-svc test.txt https://integralblue.com
curl: (7) Failed to connect to 3dbbdetxoyw4nsp6c3cc456oj2aysmzhbfzz6s43ezxzsfxxri3h5xqd.onion port 443: Connection refused

https://integralblue.com uses an alt-svc header pointing to a tor .onion address. Cloudflare does this too: https://blog.cloudflare.com/cloudflare-onion-service/

I expected the following

The second curl invocation should have worked.

According to https://tools.ietf.org/html/rfc7838#section-2.4

Furthermore, if the connection to the alternative service fails or is unresponsive, the client MAY fall back to using the origin or another alternative service.

So falling back is okay.

I can see a few of approaches:

  • Only add the alt-svc to the cache when curl determines that the service is reachable. This is what Chrome and Firefox do.
  • Always add the alt-svc to cache (which is what curl does today), but then fall back to the original origin if the alt-svc isn't reachable. This is like how the IPv6 to IPv4 fallback works.

curl/libcurl version

$ curl --version
curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1d zlib/1.2.11 brotli/1.0.7 libidn2/2.3.0 libssh2/1.9.0_DEV nghttp2/1.40.0 quiche/0.2.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtmp rtsp scp sftp smtp smtps telnet tftp 
Features: alt-svc AsynchDNS brotli HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM SSL TLS-SRP UnixSockets

operating system

$ uname -a
Linux irrational 5.4.0-rc6 #2 SMP Fri Nov 8 19:09:49 EST 2019 x86_64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux

created time in 12 days

issue openedcurl/curl

Save altsvc cache in curl_easy_reset

<!-- Only file bugs here! Ask questions on the mailing lists https://curl.haxx.se/mail/

 SECURITY RELATED? Post it here: https://hackerone.com/curl

 There are collections of known issues to be aware of:
 https://curl.haxx.se/docs/knownbugs.html
 https://curl.haxx.se/docs/todo.html       -->

I did this

I expect this block to save the altsvc cache to "altsvc.txt" but it does not. When the curl_easy_reset line (noted with a comment) is removed, "altsvc.txt" is saved as expected.

/********* Sample code generated by the curl command line tool **********
 * All curl_easy_setopt() options are documented at:
 * https://curl.haxx.se/libcurl/c/curl_easy_setopt.html
 ************************************************************************/
#include <curl/curl.h>

int main(int argc, char *argv[])
{ 
  CURLcode ret;
  CURL *hnd;

  hnd = curl_easy_init();
  curl_easy_setopt(hnd, CURLOPT_BUFFERSIZE, 102400L);
  curl_easy_setopt(hnd, CURLOPT_URL, "https://integralblue.com");
  curl_easy_setopt(hnd, CURLOPT_NOPROGRESS, 1L);
  curl_easy_setopt(hnd, CURLOPT_USERAGENT, "curl/7.68.0");
  curl_easy_setopt(hnd, CURLOPT_MAXREDIRS, 50L);
  curl_easy_setopt(hnd, CURLOPT_HTTP_VERSION, (long)CURL_HTTP_VERSION_2TLS);
  curl_easy_setopt(hnd, CURLOPT_TCP_KEEPALIVE, 1L);
  curl_easy_setopt(hnd, CURLOPT_ALTSVC, "altsvc.txt");

  /* Here is a list of options the curl code used that cannot get generated
     as source easily. You may select to either not use them or implement
     them yourself.

  CURLOPT_WRITEDATA set to a objectpointer
  CURLOPT_INTERLEAVEDATA set to a objectpointer
  CURLOPT_WRITEFUNCTION set to a functionpointer
  CURLOPT_READDATA set to a objectpointer
  CURLOPT_READFUNCTION set to a functionpointer
  CURLOPT_SEEKDATA set to a objectpointer
  CURLOPT_SEEKFUNCTION set to a functionpointer
  CURLOPT_ERRORBUFFER set to a objectpointer
  CURLOPT_STDERR set to a objectpointer
  CURLOPT_HEADERFUNCTION set to a functionpointer
  CURLOPT_HEADERDATA set to a objectpointer

  */

  ret = curl_easy_perform(hnd);

  curl_easy_reset(hnd); // line added
  curl_easy_cleanup(hnd);
  hnd = NULL;

  return (int)ret;
}
/**** End of sample code ****/

Currently, the alt svc cache is only saved in curl_close which is called by curl_easy_cleanup: https://github.com/curl/curl/blob/curl-7_68_0/lib/url.c#L383 https://github.com/curl/curl/blob/curl-7_68_0/lib/easy.c#L738

It should also be saved when curl_easy_reset is called.

I believe that adding

#ifdef USE_ALTSVC
  Curl_altsvc_save(data->asi, data->set.str[STRING_ALTSVC]);
#endif

at https://github.com/curl/curl/blob/curl-7_68_0/lib/easy.c#L941 would address this issue.

I expected the following

curl_easy_reset should save the altsvc cache file.

curl/libcurl version

$ curl --version
curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1d zlib/1.2.11 brotli/1.0.7 libidn2/2.3.0 libssh2/1.9.0_DEV nghttp2/1.40.0 quiche/0.2.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtmp rtsp scp sftp smtp smtps telnet tftp 
Features: alt-svc AsynchDNS brotli HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Largefile libz Metalink NTLM SSL TLS-SRP UnixSockets

operating system

$ uname -a
Linux irrational 5.4.0-rc6 #2 SMP Fri Nov 8 19:09:49 EST 2019 x86_64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz GenuineIntel GNU/Linux

created time in 14 days

push eventcandrews/xbmc

Craig Andrews

commit sha 783d0237f140fdedbbbf13860449150fc9fc7851

[curl] Enable alt-svc cache if available Enable alt-svc cache when using a version of curl (7.64.1 or later) that was compiled with alt-svc support (as of 7.66.0, it's disabled by default). This file is used as the Alt-Svc cache to read existing cache contents from and possibly also write back to after a transfer. See: https://daniel.haxx.se/blog/2019/03/03/alt-svc-in-curl/

view details

push time in 15 days

push eventcandrews/xbmc

Craig Andrews

commit sha 8f983bb7a04f6311205c42e0dbd1dbde61549202

[curl] Enable alt-svc cache if available Enable alt-svc cache when using a version of curl (7.64.1 or later) that was compiled with alt-svc support (as of 7.66.0, it's disabled by default). This file is used as the Alt-Svc cache to read existing cache contents from and possibly also write back to after a transfer. See: https://daniel.haxx.se/blog/2019/03/03/alt-svc-in-curl/

view details

push time in 15 days

push eventcandrews/xbmc

fandangos

commit sha 72501c328fa2ba69f5b37fc794deb66be1bfa602

Fix UHD BD Dolby Vision dual layer stream Exclusive to UHD BD, Dolby has a second video layer that is mistaken by a 1080p HEVC/AVC stream causing a green screen when played.

view details

peak3d

commit sha 89e875938983ddf29ff5736af3b582845435652c

Prevent VideoSync from setting up in Destructor

view details

arnova

commit sha 6290693bc352171c1db075757d5d2a15242d34c4

fixed: File cache logic for reading from source

view details

Bernd Kuhls

commit sha 7fd0d2577a2c39ad5c6b823a65909aba737e419a

Add missing cstddef includes Fixes build errors seen with gcc 5.5.0: xbmc/pictures/SlideShowPicture.cpp:903:109: error: 'offsetof' was not declared in this scope glVertexAttribPointer(posLoc, 3, GL_FLOAT, 0, sizeof(PackedVertex), BUFFER_OFFSET(offsetof(PackedVertex, x))); xbmc/cores/RetroPlayer/rendering/VideoRenderers/RPRendererGuiTexture.cpp:187:109: error: 'offsetof' was not declared in this scope glVertexAttribPointer(posLoc, 3, GL_FLOAT, 0, sizeof(PackedVertex), BUFFER_OFFSET(offsetof(PackedVertex, x)));

view details

ronie

commit sha ed4a38c127a0f7b8ddc0c7df43e87b1bfc69b4b3

Dialog.Close(all) should only close modal dialogs

view details

fandangos2

commit sha f2f97235d17b0f4f8706cf98aab16eba1a85e4ef

Update DVDInputStreamBluray for UHD BD Fix: WARNING: CDVDInputStreamBluray - unhandled libbluray event 32 Fix: WARNING: CDVDInputStreamBluray - unhandled libbluray event 33 Set Bluray Player profile to accomodate UHD BDs. Set Bluray Player UHD capabilities Set HDR Preference. If HDR metadata is present it should be used and if the display doesn't support it, it will tonemap to SDR.

view details

ronie

commit sha 27c4f4a824a72c5a1ea3ae5aa668b07613541b18

[videos] allow 0.0 rating

view details

Lukas Rusak

commit sha c67ca2c8fccb6c75ee098412960a887a21221242

[posix] network: split into platform specific files

view details

the-black-eagle

commit sha 2606f6c4dc37a85ca1ca349bde107ed843e6eb2a

Add boxset, disctitle & totaldiscs to jsonrpc Sort results by totaldiscs

view details

Alwin Esch

commit sha 5d5d06063167e84fde17f7fbb72d096048a03358

[addons] use in filesystem the IsAddonInstalled to check No need to call "CServiceBroker::GetAddonMgr().GetAddon(addon->ID(), localAddon, ADDON_UNKNOWN, false)" if already a function in Manager where do this.

view details

Alwin Esch

commit sha 177c949617d3722653d69cf0d12b12e3f8b67c27

[addons] prevent on addon directory the add of "plugin" or "script" as own folder This types have always a subtype where controlled in own folders. Needed for following changes.

view details

Alwin Esch

commit sha 178f229ab8320be0af48fc6d4b27a25902d8dc75

[addons] remove func. "FullType()" from IAddon and other places, becomes nowhere used

view details

Alwin Esch

commit sha f4a8a119527a7d39c2c8566d9eda82ab787a9dcd

[addons] fix check on CAddonsDirectory::GetScriptsAndPlugins for right type This fix the ask about the script and plugin addons to have the right start path, that they can be used on addon window. This failure effect was present in case a addon has contained more as one type, e.g. python screensaver together with video addon.

view details

Alwin Esch

commit sha 7e3c45f8e06c4b9c84ed7b23906e3e3c2c21f00a

[addons] fix script/plugin subtype check Before was wrongly during creation the subtype added to addon info, this then make e.g. "video" to all types inside a addon and "program" then also declared wrongly as "video".

view details

Alwin Esch

commit sha 0384233156839a4456ea039f98539e1b0a9fdfc3

[addons] rename all addon IsType func. to HasType (is more correct)

view details

Alwin Esch

commit sha 516487354d607cd5726f8b95c4751a2d7bd0dc7d

[addons] add a bit of documentation to CAddon and CAddonInfo This to have a description what the related functions do.

view details

Alwin Esch

commit sha f062ac54fb2f723d85801fce5b00b529755cba56

[addons] remove wrong PVR API version note

view details

Alwin Esch

commit sha 0ce5be5cc370add636196e9b14e57075a58b5491

[addons] Don't use kodi::addon::IAddonInstance on Kodi side To use a C++ part from addon side inside Kodi breaks "C" interface usage. Further is wanted to allow pure "C" way for addons where need to change also this in future on all "KodiToAddonFuncTable_..." structures to use only KODI_HANDLE (void*) instead of class name. For PVR this becomes already prepared to allow "C" only. But to allow this must be come first.

view details

Alwin Esch

commit sha ed0997408d6b8ceb6bd73346854b6262f1af3c0b

[addons] fix CStructHdl operator= with before has not worked

view details

Alwin Esch

commit sha 7c30bc44b5d7f0db6c168c46b6cd496493a9b5e5

[videoplayer] cleanup Inputstream constants documentation To have in one line by so big text, makes it hard to read and looks a bit ugly.

view details

push time in 16 days

issue commentROCm-Developer-Tools/HIP

Question regarding HIP-CLang dependencies

How long does it take for AMD to answer these questions?

I'm not an AMD person... I'm just a user and a Gentoo developer.

I'm frustrated with waiting just like you are :(

justxi

comment created time in 17 days

issue openedxbmc/vfs.sacd

Fails to build with `-fno-common` / GCC 10

gcc-10 and above flipped a default from -fcommon to -fno-common: https://gcc.gnu.org/PR85678

vfs.sacd currently fails to compile when given the CFLAG -fno-common so it will fail with GCC 10:

/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `audio_packet_data_type_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `track_type_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `category_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `genre_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `character_set_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_id3.c.o (symbol from plugin): in function `scarletbook_id3_tag_render':
(.text+0x0): multiple definition of `frame_format_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':
(.text+0x0): multiple definition of `audio_packet_data_type_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':
(.text+0x0): multiple definition of `track_type_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':
(.text+0x0): multiple definition of `category_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':
(.text+0x0): multiple definition of `genre_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':
(.text+0x0): multiple definition of `character_set_t'; CMakeFiles/vfs.sacd.dir/src/SACDFile.cpp.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: scarletbook_output.c.o (symbol from plugin): in function `scarletbook_output_enqueue_track':

(and more) Here's complete build output: build.log

Here's some more info about how to fix the issue: https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

Thanks!

created time in a month

pull request commentnetdata/netdata

.travis.yml: Add -fno-common to CFLAGS

this should be ready to go, please ping me if you need anything else.

Indeed, all tests are now passing :tada:

candrews

comment created time in a month

push eventcandrews/xbmc

bb10

commit sha 61891b5a95a97858e5f36f42f95b579817344994

Update joystick.xml Added <back>ActivateWindow(Home)</back> as a global keypress, it was not assigned any action before. Changed <b> back to the original action of Stop and changed the long press action to Fullscreen. Changed the <back> button to the Fullscreen action. It doesn't toggle, instead it sends you back to the home screen after pressing it a second time because of the global action, which kind of makes sense for the View (on xbox one, previously back) button.

view details

Andre Meyering

commit sha a9d1432c15776b181cc91a6049bc56aadb07044f

[Buildsteps] Fix URL for list of Kodi mirrors - "/list.html" does not exist anymore - "/timestamp.txt?mirrorlist" should be used instead

view details

montellese

commit sha 6a565700e96597c153a5c813949c6f203cca9e68

[settings] support <close> attribute in action button <control>

view details

montellese

commit sha f38d71ce519d0cf5156815b24ecce19198728602

[settings] support pure string based labels for <option>

view details

montellese

commit sha 845f8614e33bceb0f63b16d2942d3efb38fc532f

[settings] extend supported <masking> format in CSettingPath with "video", "audio", "image", "executable" and "", "", "", ""

view details

montellese

commit sha 8404a5e42b285adfce6c3d63ec1f69d2991aca5b

[settings] fix parsing of path setting with <control type="button" format="image">

view details

montellese

commit sha 253141723d2684e78d12f783a013a51b1154d5cc

[settings] support "sort" attribute on <options> constraint of integer and string settings

view details

montellese

commit sha c3927d8a3047af0cc6b07f0d18157320657b7db5

[settings] fix missing label for multiselect (list) add-on settings (fixes #15423)

view details

montellese

commit sha 272b7333983caac17e8f7f8bd8c7b0f4add4ba1e

[addons/settings] fix empty labels showing up with wrong translated string

view details

montellese

commit sha 84b719c36b4aebc1fd8d92230d051cc0c3c9af41

[addons/settings] add missing CGUIDialogAddonSettings::OnSettingAction()

view details

montellese

commit sha a2ca3e92e2f4ea8e1e8a04e72f88faa616ff3a89

[settings] catch formatting exception in CGUIControlSliderSetting::GetText() and fall back to default formatting labels (fixes #16663)

view details

phunkyfish

commit sha d1628d4bf5f0a377186960a273e930831b4953ed

[docs] Fix indexes for code guidelines

view details

phunkyfish

commit sha d0dd36c61ed2613af812e1b6b40480c83927442f

[clang-format] change constructor init list to colon on newline, break after comma for longer lines

view details

phunkyfish

commit sha cf7b0bb5b6129889a70f8916c24933062adc9ec8

[clang-format] switch - indent case and default

view details

phunkyfish

commit sha 1eeec97e94304190305a380cf1535aba5bcbc9af

[docs] Update code guidelines on C++14 usage

view details

DaveTBlake

commit sha ccf713437a2ef19a0ae3ecfd8151df3032a7b051

Reduce repeated parsing of path to get node details, get information in one call.

view details

jakaja

commit sha 33dd6c51ad7619cc1eccc8cd06e6acc63599618f

Add rating mark also to "Shift" view "InfoWall", "Wall" and "Poster" views already have "ratings bubble", but for some reason it was missing from "Shift" view. Adding it.

view details

Kai Sommerfeld

commit sha a1d625ddb87e8e89290a6d907875974a1e0eb2e2

[PVR] EPG database: Fix persisting/restoring of optional(\!) firstAired date.

view details

phunkyfish

commit sha b3d57acb7cf2d07aed080e24904f877bdfc162fd

[skin.estuary] includ Deleted in breadcrumbs when viewing deleted recordings

view details

phunkyfish

commit sha 62d2cd887db3476e58bf7f34ecd3a3dc43da73ea

[skin.estuary] increase info panel space slighly to allow 12 hour clock times fit on one line

view details

push time in a month

pull request commentRadeonOpenCompute/ROCR-Runtime

Install to standard locations

@jlgreathouse @skeelyamd @chsigg can you please take a look at this?

I'd really like to get this PR merged. Thank you!

candrews

comment created time in a month

push eventcandrews/netdata

Craig Andrews

commit sha afbd3de51e04691e2cfc418627214f4641595afe

.travis.yml: Add -fno-common to CFLAGS -fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678 Therefore, netdata should test with that configuration to be ready for this change. See https://github.com/netdata/netdata/issues/7869

view details

push time in a month

push eventcandrews/netdata

Joel Hans

commit sha 439f334e678baf92253315d65d374b67dd4b9a16

Docs: Overhaul of installation documentation (#7841) * Initial commit to bring new branch up to speed with previous work * Initial commit to bring new branch up to speed with previous work * Pass through for grammar and typos * Pass through for grammar and typos * First additions * Improvements to installation page plus new separate kickstart page * Lots of new pages, lots of improvements * Continued work * Fixing the install grid * Added methods to nav * Fix typo and add kickstart to nav * CSS cleanup * Various cleanup * Cleanup on update/uninstall pages * Add responsiveness to install grid * Update checking of the kickstart files MD5 checksusm. This updates the CI script used to verify the MD5 checksums of the kickstart files as being correct in the documentation to use the new locations for the respective checksums. This is more involved than a simple path update because the existing script assumes that both checksums are listed in the same file, which is no longer the case. Any future updates that move the location of the checksums just need to modify the lines in tests/installer/checksums.sh that start with `check_checksum` to point to the correct files. * Added Alpine package for James * Add packages to top of installation page * Fix for Chris * Telemetry fixes * Trying to fix CI * Changing checksums * Fix CI checks for kickstart checksums. The changed wording was confusing the code that parsed the checksum out of the documentation, this fixes the code to handle this new wording correctly. * Update kickstart-static64 checksum * Update 64 checksum Co-authored-by: Austin S. Hemmelgarn <ahferroin7@gmail.com>

view details

Thomas Anderson

commit sha 5f7899070197b5d6e7c3c72f8ece271470aeeb81

Small updates to dash.html (#7757) * dash.html docs and styling improvements * Fixing whitespace * Futher whitespace fixing * Finally fixed whitespace * Tabs to spaces * Fix Netdata capitalization Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> * Fix Netdata capitalization Co-Authored-By: Joel Hans <joel.g.hans@gmail.com> Co-authored-by: Joel Hans <joel.g.hans@gmail.com>

view details

netdatabot

commit sha fa92c1e3b4990d76a87bb6d85297c954b667f397

[ci skip] create nightly packages and update changelog

view details

thiagoftsm

commit sha 93631017d868d8d432124e18c96bbe6dcba4bce0

Missing extern (#7877) * missing_extern: Fix missing Fix few externs that were missing in global variables * missing_extern: Variables This commit declares the variables inside .c files

view details

Craig Andrews

commit sha ac73481508807c2b2549f72cda492452e9bb1a0b

.travis.yml: Add -fno-common to CFLAGS -fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678 Therefore, netdata should test with that configuration to be ready for this change. See https://github.com/netdata/netdata/issues/7869

view details

push time in a month

issue commentJayDDee/cpuminer-opt

Fails to build with `-fno-common` / GCC 10

That would be awesome - thank you! :-)

candrews

comment created time in a month

issue commentnetdata/netdata

Fails to build with `-fno-common` / GCC 10

Yes, this PR should not be merged right now.

My intent is for this PR is twofold:

  1. Demonstrate in a clear, reproducible fashion on netdata's own systems (so it's clear that the issue is not distro related, for example) that netdata currently fails to build with the -fno-common CFLAG which will be set by default in GCC 10 (so in GCC 10, no explicit CFLAG setting is necessary - netdata fails by default with GCC 10 today).
  2. Have this PR ready as it should be merged when the source changes have been made that cause the build failures.
candrews

comment created time in a month

issue commentJayDDee/cpuminer-opt

Fails to build with `-fno-common` / GCC 10

I'm reporting this issue as both a user and the Gentoo maintainer of this package - cpuminer-opt is indeed in Gentoo :-) https://packages.gentoo.org/packages/net-p2p/cpuminer-opt

The distro policy is to have packages build with GCC defaults, and since this will be a GCC default with the release of GCC 10, we're trying to get a head start by testing packages and reporting any issues we find.

candrews

comment created time in a month

issue commentnetdata/netdata

Fails to build with `-fno-common` / GCC 10

That works, which is expected, as -fno-common isn't explicitly set and I'm not using >=GCC 10.

candrews

comment created time in a month

issue commentnetdata/netdata

Fails to build with `-fno-common` / GCC 10

  1. json-c version is 0.13.1

gcc (Gentoo 9.2.0-r3 p4) 9.2.0 Copyright (C) 2019 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ```

You can see this problem in Travis CI at #7870 (it's not a Gentoo specific problem, it happens whenever -fno-common is set which it will be by default in GCC 10)

candrews

comment created time in a month

pull request commentnetdata/netdata

.travis.yml: Add -fno-common to CFLAGS

I completely agree - the changes to fix this issue should be made and this PR merged after that to ensure no such future issues appear.

candrews

comment created time in a month

PR opened JayDDee/cpuminer-opt

.travis.yml: Add -fno-common to CFLAGS

-fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678

Therefore, cpuminer-opt should test with that configuration to be ready for this change.

See https://github.com/JayDDee/cpuminer-opt/issues/232

+1 -1

0 comment

1 changed file

pr created time in a month

push eventcandrews/cpuminer-opt

Craig Andrews

commit sha 223eee1bab6409babce1d83f1341acea5f21ffcd

.travis.yml: Add -fno-common to CFLAGS -fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678 Therefore, cpuminer-opt should test with that configuration to be ready for this change. See https://github.com/JayDDee/cpuminer-opt/issues/232

view details

push time in a month

fork candrews/cpuminer-opt

Optimized multi algo CPU miner

fork in a month

PR opened netdata/netdata

Reviewers
.travis.yml: Add -fno-common to CFLAGS

-fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678

Therefore, netdata should test with that configuration to be ready for this change.

See https://github.com/netdata/netdata/issues/7869

<!-- Describe the change in summary section, including rationale and degin decisions. Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This will help us review your PR quicker.

If you have more information you want to add, write them in "Additional Information" section. This is usually used to help others understand your motivation behind this change. A step-by-step reproduction of the problem is helpful if there is no related issue. -->

Summary
Component Name
Additional Information
+1 -1

0 comment

1 changed file

pr created time in a month

push eventcandrews/netdata

Craig Andrews

commit sha 79a1fe50d065ee025261f3492d0a30ffddb42029

.travis.yml: Add -fno-common to CFLAGS -fno-common will be set by default in GCC 10, see https://gcc.gnu.org/PR85678 Therefore, netdata should test with that configuration to be ready for this change. See https://github.com/netdata/netdata/issues/7869

view details

push time in a month

issue openednetdata/netdata

Fails to build with `-fno-common` / GCC 10

<!-- When creating a bug report please:

  • Verify first that your issue is not already reported on GitHub.
  • Test if the latest release and master branch are affected too. -->
Bug report summary

gcc-10 and above flipped a default from -fcommon to -fno-common: https://gcc.gnu.org/PR85678

netdata currently fails to compile when given the CFLAG -fno-common:

/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/libnetdata.o (symbol from plugin): in function `strdupz':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/locks/locks.o (symbol from plugin): in function `netdata_thread_disable_cancelability':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/log/log.o (symbol from plugin): in function `facility_log':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/popen/popen.o (symbol from plugin): in function `myp_init':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/procfile/procfile.o (symbol from plugin): in function `procfile_adaptive_initial_allocation':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/os.o (symbol from plugin): in function `get_system_cpus':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/simple_pattern/simple_pattern.o (symbol from plugin): in function `simple_pattern_create':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/socket/socket.o (symbol from plugin): in function `poll_default_add_callback':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/socket/security.o (symbol from plugin): in function `security_openssl_library':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/statistical/statistical.o (symbol from plugin): in function `log_series_to_stderr':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/storage_number/storage_number.o (symbol from plugin): in function `pack_storage_number':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/threads/threads.o (symbol from plugin): in function `netdata_thread_tag':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/url/url.o (symbol from plugin): in function `from_hex':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/json/json.o (symbol from plugin): in function `json_callback_print':
(.text+0x0): multiple definition of `silencers_filename'; libnetdata/log/log.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/json/json.o (symbol from plugin): in function `json_callback_print':
(.text+0x0): multiple definition of `netdata_ready'; libnetdata/log/log.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/json/json.o (symbol from plugin): in function `json_callback_print':
(.text+0x0): multiple definition of `api_secret'; libnetdata/log/log.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/json/json.o (symbol from plugin): in function `json_callback_print':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: libnetdata/health/health.o (symbol from plugin): in function `create_silencer':
(.text+0x0): multiple definition of `silencers'; collectors/apps.plugin/apps_plugin.o (symbol from plugin):(.text+0x0): first defined here
collect2: error: ld returned 1 exit status

Here's the the build log showing the failure: net-analyzer:netdata-9999:20200127-204109.log

Here's some more info about how to fix the issue: https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

OS / Environment

<!-- Provide as much information about your environment (which operating system and distribution you're using, if Netdata is running in a container, etc.) as possible to allow us reproduce this bug faster.

To get this information, execute the following commands based on your operating system:

  • uname -a; grep -Hv "^#" /etc/*release # Linux
  • uname -a; uname -K # BSD
  • uname -a; sw_vers # macOS

Place the output from the command in the code section below.
--> n/a, use GCC 10 or specify the fno-common CFLAG.

Netdata version

<!-- Provide output of netdata -V.

If Netdata is running, execute: $(ps aux | grep -E -o "[a-zA-Z/]+netdata ") -V --> Current master, https://github.com/netdata/netdata/commit/a4223457b49497f57bd199dfaf5cf35c4fb86997

Component Name

<!-- Let us know which component is affected by the bug. Our code is structured according to its component, so the component name is the same as the top level directory of the repository. For example, a bug in the dashboard would be under the web component. --> core

Steps To Reproduce

<!-- Describe how you found this bug and how we can reproduce it, preferably with a minimal test-case scenario. If you'd like to attach larger files, use gist.github.com and paste in links. -->

  1. Compile with CFLAGS="-fno-common"
Expected behavior

<!-- Provide a clear and concise description of what you expected to happen. --> Should compile.

created time in a month

issue openedJayDDee/cpuminer-opt

Fails to build with `-fno-common` / GCC 10

gcc-10 and above flipped a default from -fcommon to -fno-common: https://gcc.gnu.org/PR85678

cpuminer-opt currently fails to compile when given the CFLAG -fno-common

Here's the the build log showing the failure: net-p2p cpuminer-opt-3.11.7 20200127-033308.log

Originally reported at https://bugs.gentoo.org/706666 and here's some more info about how to fix the issue: https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

created time in a month

Pull request review commentgentoo/gentoo

dev-libs/spdlog: bump 1.5.0

 SLOT="0/1" IUSE="test" RESTRICT="!test? ( test )" +BDEPEND="+	virtual/pkgconfig+" DEPEND="-	>=dev-libs/libfmt-5.0.0+	>=dev-libs/libfmt-5.3.0:= " RDEPEND="${DEPEND}" -PATCHES=( "${FILESDIR}/${PN}-1.0.0-unbundle-fmt.patch" )+#PATCHES=(+#	"${FILESDIR}/${PN}-1.4.2-fix-compilation.patch"+#) -src_configure() {-	rm -r include/spdlog/fmt/bundled || die+src_prepare() {+	cmake_src_prepare+	rm -r include/spdlog/fmt/bundled || die "Failed to delete bundled libfmt"+} +src_configure() { 	local mycmakeargs=(-		-DSPDLOG_BUILD_EXAMPLES=no 		-DSPDLOG_BUILD_BENCH=no+		-DSPDLOG_BUILD_EXAMPLE=no

Should this be EXAMPLES or EXAMPLE?

I personally don't know, but I want to make sure this change is correct and not a mistake.

stkw0

comment created time in a month

Pull request review commentgentoo/gentoo

dev-libs/spdlog: bump 1.5.0

 SLOT="0/1" IUSE="test" RESTRICT="!test? ( test )" +BDEPEND="+	virtual/pkgconfig+" DEPEND="-	>=dev-libs/libfmt-5.0.0+	>=dev-libs/libfmt-5.3.0:= " RDEPEND="${DEPEND}" -PATCHES=( "${FILESDIR}/${PN}-1.0.0-unbundle-fmt.patch" )+#PATCHES=(+#	"${FILESDIR}/${PN}-1.4.2-fix-compilation.patch"+#)

Why is this commented out?

If it's not applicable, I should be removed (and not left as a comment)

stkw0

comment created time in a month

pull request commentgentoo/gentoo

dev-libs/pigpio: new version 73

Regarding stable, no, you can't just submit a PR for that. There's a process: https://wiki.gentoo.org/wiki/Stable_request basically, it has to be in tree without bugs for 30 days then you create a bug asking for it to be stabilized.

github-k8n

comment created time in a month

pull request commentxbmc/xbmc

Backport: PeripheralBusUSB Fixes

In this backport, can you also add the missing cassert include? See #17196

fritsch

comment created time in a month

PR opened xbmc/xbmc

Reviewers
Add missing cassert include

Without this include, ‘assert’ was not declared in this scope errors occur.

This issue was introduced by https://github.com/xbmc/xbmc/pull/17182

Description

<!--- Provide a general summary of your change in the Pull Request title above --> <!--- Describe your change in detail here -->

FAILED: build/platform/linux/peripherals/CMakeFiles/platform_linux_peripherals.dir/PeripheralBusUSBLibUdev.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++  -I/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999 -I/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/lib -I/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/lib/gtest/include -I/var/tmp/p
ortage/media-tv/kodi-9999/work/kodi-9999/xbmc -I/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/platform/linux -I/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/cores/VideoPlayer -Ibuild -I/var/tmp/portage/media-tv/kodi-99
99/work/kodi-9999/xbmc/platform/posix -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/python3.7m -I/usr/include/libxml2 -Ibuild/cores/RetroPlayer/messages -I/usr/include/freetype2 -I/usr/include/fribidi -Ibuild/libdvd
/include -I/usr/include/lzo -I/usr/include/libdrm  -DNDEBUG -O2 -march=native -pipe -fuse-linker-plugin -flto -Wl,-flto -ftree-vectorize -ftree-slp-vectorize -falign-functions=32 -fgraphite-identity -floop-nest-optimize -fno-lto -fno-use-
linker-plugin -ggdb -DPLATFORM_SETTINGS_FILE=x11.xml -Wall   -DTARGET_POSIX -DTARGET_LINUX -D_GNU_SOURCE -DHAVE_LINUX_MEMFD=1 -DHAVE_MKOSTEMP=1 -DHAVE_SSE=1 -DHAVE_SSE2=1 -DHAVE_SSE3=1 -DHAVE_SSSE3=1 -DHAVE_SSE4_1=1 -D__STDC_CONSTANT_MACR
OS -D_FILE_OFFSET_BITS=64 -DHAS_LINUX_NETWORK -DHAS_BUILTIN_SYNC_ADD_AND_FETCH=1 -DHAS_BUILTIN_SYNC_SUB_AND_FETCH=1 -DHAS_BUILTIN_SYNC_VAL_COMPARE_AND_SWAP=1 -DHAVE_INOTIFY=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_GMTIME_R=1 -
DHAVE_INTTYPES_H=1 -DHAS_ALSA=1 -DHAS_AVAHI=1 -DHAS_ZEROCONF=1 -DHAVE_LIBBLURAY=1 -DHAVE_LIBBLURAY_BDJ=1 -DHAVE_LIBCEC=1 -DHAS_DBUS=1 -DHAVE_LCMS2=1 -DHAS_WEB_SERVER=1 -DHAS_WEB_INTERFACE=1 -DHAS_PULSEAUDIO=1 -DHAS_PYTHON=1 -DHAVE_LIBUDEV
=1 -DHAVE_LIBXSLT=1 -DHAVE_LIBVA=1 -DHAS_GLX=1 -DFFMPEG_VER_SHA=\"undef\" -I/usr/include/fribidi -DHAS_EGL=1 -DHAVE_X11=1 -DHAVE_LIBXRANDR=1 -DHAS_GL=1 -DHAS_UPNP=1 -DHAS_DVD_DRIVE -DHAS_CDDA_RIPPER -DBIN_INSTALL_PATH=\"/usr/lib64/kodi\" 
-DINSTALL_PATH=\"/usr/share/kodi\" -std=c++14 -MD -MT build/platform/linux/peripherals/CMakeFiles/platform_linux_peripherals.dir/PeripheralBusUSBLibUdev.cpp.o -MF build/platform/linux/peripherals/CMakeFiles/platform_linux_peripherals.dir/
PeripheralBusUSBLibUdev.cpp.o.d -o build/platform/linux/peripherals/CMakeFiles/platform_linux_peripherals.dir/PeripheralBusUSBLibUdev.cpp.o -c /var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/platform/linux/peripherals/PeripheralBu
sUSBLibUdev.cpp
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/platform/linux/peripherals/PeripheralBusUSBLibUdev.cpp: In member function ‘virtual bool PERIPHERALS::CPeripheralBusUSB::PerformDeviceScan(PERIPHERALS::PeripheralScanResults&)’:
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/platform/linux/peripherals/PeripheralBusUSBLibUdev.cpp:85:3: error: ‘assert’ was not declared in this scope
   85 |   assert(IsCurrentThread());
      |   ^~~~~~
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/platform/linux/peripherals/PeripheralBusUSBLibUdev.cpp:16:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   15 | #include "utils/log.h"
  +++ |+#include <cassert>
   16 | 

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> Fix compilation error :)

How Has This Been Tested?

<!--- Please describe in detail how you tested your change --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc --> Tested on my system.

Screenshots (if appropriate):

n/a

Types of change

<!--- What type of change does your code introduce? Put an x in all the boxes that apply like this: [X] -->

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [ ] Improvement (non-breaking change which improves existing functionality)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that will cause existing functionality to change)
  • [ ] Cosmetic change (non-breaking change that doesn't touch code)
  • [ ] None of the above (please explain below)

Checklist:

<!--- Go over all the following points, and put an X in all the boxes that apply like this: [X] --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the Code Guidelines of this project
  • [ ] My change requires a change to the documentation, either Doxygen or wiki
  • [ ] I have updated the documentation accordingly
  • [ ] I have read the Contributing document
  • [ ] I have added tests to cover my change
  • [ ] All new and existing tests passed
+1 -0

0 comment

1 changed file

pr created time in a month

push eventcandrews/xbmc

Craig Andrews

commit sha f8a38e5ecdc3f38fa3f5d5baf4c0f37ba30f54a6

Add missing cassert include Without this include, ‘assert’ was not declared in this scope errors occur.

view details

push time in a month

PR opened gentoo/gentoo

sys-apps/util-linux: Python 3.8 compatibility

All tests pass.

Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+2 -2

0 comment

2 changed files

pr created time in a month

create barnchcandrews/gentoo

branch : util-linux-py38

created branch time in a month

PR closed gentoo/gentoo

dev-libs/libxslt: 1.1.34 version bump assigned bug linked

Closes: https://bugs.gentoo.org/703274 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+126 -0

2 comments

2 changed files

candrews

pr closed time in a month

pull request commentgentoo/gentoo

dev-libs/libxslt: 1.1.34 version bump

Nevermind, this bump is more complex than I initially thought. I'll leave it to the experts.

candrews

comment created time in a month

create barnchcandrews/gentoo

branch : bug703274

created branch time in a month

PR opened gentoo/gentoo

dev-libs/libxslt: 1.1.34 version bump

Closes: https://bugs.gentoo.org/703274 Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+126 -0

0 comment

2 changed files

pr created time in a month

PR closed gentoo/gentoo

net-misc/nyx: Python 3.7 and 3.8 compatibility assigned no bug found

Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+1 -1

2 comments

1 changed file

candrews

pr closed time in a month

pull request commentgentoo/gentoo

net-misc/nyx: Python 3.7 and 3.8 compatibility

Merged https://github.com/gentoo/gentoo/commit/643da6cc52b4e8789d5dafb14b7e7404dc31ccaa

candrews

comment created time in a month

PR opened gentoo/gentoo

net-misc/nyx: Python 3.7 and 3.8 compatibility

Package-Manager: Portage-2.3.84, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchcandrews/gentoo

branch : nyx-py38

created branch time in a month

pull request commentgentoo/gentoo

dev-libs/spdlog: bump 1.4.2

There are conflicts... if you fix the conflicts I shall happily merge this PR.

Thanks again!

stkw0

comment created time in a month

pull request commentgentoo/gentoo

cargo.eclass: Use a regex to fix crate name/version extraction

I would double check a pre version as well.

Tested with rand-0.7.0-pre.2 and it worked correctly. If you have any others you'd like to have tested, please let me know.

candrews

comment created time in a month

push eventcandrews/gentoo

Craig Andrews

commit sha 7bc68d18e7f831b6d2c88dc8394159a654a8484b

cargo.eclass: Use a regex to fix crate name/version extraction Closes: https://bugs.gentoo.org/705044 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

push time in a month

push eventcandrews/gentoo

Craig Andrews

commit sha 1a3061b304d99f07f606bb098cfb92a928f3649f

cargo.eclass: Use a regex to fix create name/version extraction Closes: https://bugs.gentoo.org/705044 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

push time in a month

create barnchcandrews/gentoo

branch : bug705044

created branch time in a month

PR opened gentoo/gentoo

cargo.eclass: Use a regex to fix create name/version extraction

Closes: https://bugs.gentoo.org/705044 Signed-off-by: Craig Andrews candrews@gentoo.org

+5 -8

0 comment

1 changed file

pr created time in a month

pull request commentgentoo/gentoo

dev-libs/roct-thunk-interface: Remove NUMA from kernel check

Awesome! Thank you!

cjmayo

comment created time in 2 months

issue openedxbmc/vfs.rar

Kodi hasn't yet branches Matrix so what are the master/matrix branches?

This repo has a matrix branch which seems to be ahead of the master branch.

Since Kodi hasn't branched matrix yet, according to https://github.com/xbmc/vfs.rar/blob/Leia/README.md the master branch of this repo should be used.

So what so the matrix branch and when should it be used?

created time in 2 months

PR opened netdata/netdata

Reviewers
Indicate availability on Gentoo

<!-- Describe the change in summary section, including rationale and degin decisions. Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This will help us review your PR quicker.

If you have more information you want to add, write them in "Additional Information" section. This is usually used to help others understand your motivation behind this change. A step-by-step reproduction of the problem is helpful if there is no related issue. -->

Summary

Add information about Gentoo to DISTRIBUTIONS.md

Component Name

DISTRIBUTIONS.md

Additional Information

Netdata is available in Gentoo. See https://packages.gentoo.org/packages/net-analyzer/netdata

+2 -0

0 comment

1 changed file

pr created time in 2 months

push eventcandrews/netdata

Craig Andrews

commit sha 532c9bf247c661a6f8dd05e493f8a6da94fa70a2

Indicate availability on Gentoo

view details

push time in 2 months

push eventcandrews/netdata

Craig Andrews

commit sha d19b834d0011485759604ecfa095a898b597d8e0

Fix spelling of Prometheus (#7673)

view details

push time in 2 months

create barnchcandrews/netdata

branch : prometheus-spelling

created branch time in 2 months

PR opened netdata/netdata

Reviewers
Fix spelling of Prometheus (#7673)

<!-- Describe the change in summary section, including rationale and degin decisions. Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This will help us review your PR quicker.

If you have more information you want to add, write them in "Additional Information" section. This is usually used to help others understand your motivation behind this change. A step-by-step reproduction of the problem is helpful if there is no related issue. -->

Summary

"Prometheus" was spelled wrong. The misspelling in configure.ac caused #7673

Component Name

Prometheus

Additional Information
+4 -4

0 comment

3 changed files

pr created time in 2 months

issue openednetdata/netdata

--disable-backend-prometheus-remote-write does not work

<!--- When creating a bug report please:

  • Verify first that your issue is not already reported on GitHub
  • Test if the latest release and master branch are affected too.
  • Provide a clear and concise description of what the bug is in "Bug report summary" section.
  • Try to provide as much information about your environment (OS distribution, running in container, etc.) as possible to allow us reproduce this bug faster.
  • Write which component is affected. We group our components the same way our code is structured so basically: component name = dir in top level directory of repository
  • Describe how you found this bug and how we can reproduce it. Preferable with a minimal test-case scenario. You can paste gist.github.com links for larger files
  • Provide a clear and concise description of what you expected to happen. -->
Bug report summary

./configure --disable-backend-prometheus-remote-write still builds prometheus support.

This configure flag is documented at https://github.com/netdata/netdata/blob/v1.19.0/packaging/DISTRIBUTIONS.md

Here's a log demonstrating the problem: build.log --disable-backend-prometheus-remote-write is passed, yet this line is still output:

checking if prometheus remote write backend should be enabled... yes
OS / Environment (output of uname -a; command -v sw_vers && sw_vers || grep -Hv "^#" /etc/*release)

Gentoo/Linux

Netdata version (ouput of netdata -V)

1.19.0

Component Name

prometheus

Steps To Reproduce

Configure with --disable-backend-prometheus-remote-write

Expected behavior

When --disable-backend-prometheus-remote-write is passed, prometheus should not be enabled and support for it should not be built.

created time in 2 months

pull request commentgentoo/gentoo

Port various to cmake.eclass

Thanks for addressing these issues so quickly - and don't worry about it, it's software and we're human, stuff happens :-)

a17r

comment created time in 2 months

pull request commentgentoo/gentoo

Port various to cmake.eclass

All media-plugins/kodi-* packages and net-libs/quiche fail too.

@a17r can you please fix this issue (or revert the change)?

Thanks!

a17r

comment created time in 2 months

pull request commentgentoo/gentoo

Port various to cmake.eclass

At a glance, the packages assigned to me. I trust that you've made a sane change :)

a17r

comment created time in 2 months

Pull request review commentgentoo/gentoo

sys-auth/google-authenticator: Version bump 1.08.

 # Copyright 1999-2019 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 -EAPI=6+EAPI=7

Right - the bump should be one commit, then the removing old version(s) should be a separate commit.

tastytea

comment created time in 2 months

pull request commentgentoo/gentoo

Radeon Open Compute packages

I don't see why anything (ex, ROCm libraries) would depend on rocminfo - rocminfo is a tool that is supposed to tell the user about their system's hardware/software, not do anything else, right?

candrews

comment created time in 2 months

pull request commentgentoo/gentoo

Radeon Open Compute packages

I have pushed "rocr-runtime" and "llvm-roc". Please merge them, then I can push "rocm-device-libs", "rocm-comgr" and "rocm-opencl-runtime".

I've pushed 3.0.0 versions of all of those to Gentoo. So far, it seems to be working on my system... :crossed_fingers:

Thank you for your help on this!

candrews

comment created time in 2 months

pull request commentRadeonOpenCompute/ROCR-Runtime

Install to standard locations

I've rebased this PR.

@jlgreathouse (or anyone else appropriate) can you please consider merging these changes?

candrews

comment created time in 2 months

push eventcandrews/ROCR-Runtime

Craig Andrews

commit sha 09a835e8de2d88e917328a78765a1db423d21920

Correctly install the library into the system Install to standard locations in /usr/{lib,include}/lib (as opposed to /usr/hsa/{lib,include}/hsa) Use CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR from GNUInstallDirs instead of using "lib" and "include"

view details

push time in 2 months

push eventcandrews/ROCR-Runtime

Sean Keely

commit sha 1374eb7b2754e08a5d584cda27f773927ad5b772

ROCm 2.1.0 updates

view details

Sean Keely

commit sha e2d1950bd8fc83dd5b8352a41b829a7c57fc1073

Merge pull request #53 from RadeonOpenCompute/roc-2.1.x ROCm 2.1.0 updates

view details

Sean Keely

commit sha 36f5a2e8fba57974c80f3ffe8932cfe8f2e92a83

ROCm 2.2.0 updates

view details

Sean Keely

commit sha 84443a19cc9afbaa551bed5dcad5b7c950fe93ed

Merge pull request #57 from RadeonOpenCompute/roc-2.2.x ROCm 2.2.0 updates

view details

Sean Keely

commit sha 8ab547cab69fc212b314cd4fa474263e738b4789

ROCm 2.3.0 updates

view details

Sean Keely

commit sha 2b9ce2d4320d2bcc5262f39c186f8d68c35f53ab

Merge pull request #59 from RadeonOpenCompute/roc-2.3.x ROCm 2.3.0 updates

view details

Sean Keely

commit sha 4986cee9c61c665f74f5e228efa886345d16d837

ROCm 2.4.0 updates

view details

Sean Keely

commit sha faa3ae51388517353afcdaf9c16621f879ef0a59

Merge pull request #61 from RadeonOpenCompute/roc-2.4.x ROCm 2.4.0 updates

view details

Sean Keely

commit sha f3c22b35b7cf5ba2d55303ec1253aee8fac86000

ROCm 2.5.0 updates

view details

Sean Keely

commit sha b320b8871b9b244cd083a653b1b5aab0da9aa84b

Merge pull request #63 from RadeonOpenCompute/roc-2.5.x ROCm 2.5.0 updates

view details

Sean Keely

commit sha d28ec758f02aff2c50b2cc332f28291126e6903d

ROCm 2.6.0 updates

view details

Sean Keely

commit sha 898beb5adbe227923b84946e9d5f6570e727d34f

Merge pull request #64 from RadeonOpenCompute/roc-2.6.x ROCm 2.6.0 updates

view details

Richard Diamond

commit sha 46d522a2552713e19be936d0c1e20acea4d2b771

Allow user specified profiles if the HSAIL note is not found.

view details

Sean Keely

commit sha f6d7b664d1c982674dc3f06b8f04508ff9d32380

Merge pull request #65 from legionella-rs/master Allow user specified profiles if the HSAIL note is not found.

view details

Sean Keely

commit sha 54ca21e51adef550ee5f4680e6ebfbe38dfad69a

ROCm 2.7.0 updates

view details

Sean Keely

commit sha 8ea15e12ee4760dc6ec394841a5de8e8b9e8c845

Merge pull request #67 from RadeonOpenCompute/roc-2.7.x ROCm 2.7.0 updates

view details

Christian Sigg

commit sha e426bca1d9edd1ca9f89f8291a5ba8580b406987

Adding missing includes to sdma_registers.h

view details

Christian Sigg

commit sha 7c1b693f7277a499a29708ad31bd524e29ae0635

Add missing include to lazy_ptr.h

view details

Christian Sigg

commit sha 7b136635363bd81591fb9476f353f1c4835e4ace

Change #include of libelf.h from quote to angle.

view details

Christian Sigg

commit sha 247940d48098a6c728f0d983702a1689f5a3fccd

Include C header instead of C++

view details

push time in 2 months

PR opened gentoo/gentoo

net-libs/serf: Python 3.7 and 3.8 compatibility

Closes: https://bugs.gentoo.org/703670 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchcandrews/gentoo

branch : bug703670

created branch time in 2 months

pull request commentgentoo/gentoo

dev-libs/spdlog: bump 1.4.2

spdlog 1.4.2 fails to compile with dev-libs/libfmt-6.1.2 (which is the current latest version):

/var/tmp/portage/dev-libs/spdlog-1.4.2/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h: In member function ‘bool spdlog::details::thread_pool::process_next_msg_()’:
/var/tmp/portage/dev-libs/spdlog-1.4.2/work/spdlog-1.4.2/include/spdlog/details/thread_pool-inl.h:119:9: error: ‘assert’ was not declared in this scope
  119 |         assert(false && "Unexpected async_msg_type");
      |         ^~~~~~
compilation terminated due to -Wfatal-errors.

build.log

I believe spdlog is missing at least one #include <cassert> statement.

stkw0

comment created time in 2 months

push eventcandrews/gentoo

Craig Andrews

commit sha 03066925e279d79ca480ffc12dd9a4bdc7eb95e3

net-libs/libtorrent-rasterbar: Fix building with Boost 1.72 Closes: https://bugs.gentoo.org/703014 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

push time in 2 months

pull request commentgentoo/gentoo

www-misc/shellinabox: GLEP 81

Your acct-user ebuild needs at least one group, and then it has to call acct-user_add_deps.

Thank you for pointing out this error - I've updated this PR with that problem fixed.

candrews

comment created time in 2 months

push eventcandrews/gentoo

Amadeusz Piotr Żołnowski

commit sha 7377e74536a257675e455b6857aba9941a6fa0d0

dev-python/precis-i18n: Bump version and enable Python 3.7 and 3.8 Upstream doesn't advertise 3.7 and 3.8 support but hanno confirmed it's working. Bug: https://bugs.gentoo.org/702232 Signed-off-by: Amadeusz Piotr Żołnowski <aidecoe@gentoo.org> Package-Manager: Portage-2.3.76, Repoman-2.3.16

view details

David Seifert

commit sha 45a6e82bee41452295212dd7217645c39fff35f3

dev-ruby/facter: Fix for shared dev-cpp/cpp-hocon Closes: https://bugs.gentoo.org/703148 Package-Manager: Portage-2.3.81, Repoman-2.3.20 Signed-off-by: David Seifert <soap@gentoo.org>

view details

Michał Górny

commit sha a3fa913fc92e264d36d059aa683c042c50d0c259

sys-kernel/vanilla-kernel: Bump to 5.4.5 Signed-off-by: Michał Górny <mgorny@gentoo.org>

view details

Michał Górny

commit sha 26b34fa987cad2444a9f391c7655b65d4a7a1fd0

sys-devel/llvm: Update distro components Signed-off-by: Michał Górny <mgorny@gentoo.org>

view details

Michał Górny

commit sha 7c6ede3192970dadc9aab39ffde9fdc9c4b7acca

*/*: Reassign slis' packages Signed-off-by: Michał Górny <mgorny@gentoo.org>

view details

William Hubbs

commit sha 8b28d76af690b0c59e2e621f609417122cc3b7aa

dev-util/wasmer: New package, universal web assembly runtime Copyright: Sony Interactive Entertainment Inc. Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: William Hubbs <williamh@gentoo.org>

view details

Mike Pagano

commit sha b36d11813999b9187df09acc45cffe7676d7d88c

sys-kernel/gentoo-sources: Linux patch 5.3.18 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Mike Pagano <mpagano@gentoo.org>

view details

Mike Pagano

commit sha 2d84b58de33ab94923283d0887aba2c440410e4b

sys-kernel/gentoo-sources: Linux patch 5.4.5 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Mike Pagano <mpagano@gentoo.org>

view details

Sergei Trofimovich

commit sha f0866926e70e15f03e105cafefe6011a9fa12276

dev-lang/crystal: bump up to 0.32.1 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

view details

Sergei Trofimovich

commit sha 8b024a72f2df7be87a9be0a9a9cb675f40d1f922

dev-lang/crystal: drop old Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

view details

Jason A. Donenfeld

commit sha a79cf9b541aef6c5d0195e3a787c36df24af39e5

net-vpn/wireguard: bump to 0.0.20191219 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org>

view details

Zac Medico

commit sha f9091f40dd388cb20a8a7ff46655ccf336eae7b1

dev-python/snappy: PYTHON_COMPAT+=(python3_7 python3_8) Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org>

view details

Zac Medico

commit sha b09f5c01a5bc54889ce8b050b6a6f15c27c060c3

dev-python/kafka-python: Bump to version 1.4.7 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Zac Medico <zmedico@gentoo.org>

view details

Craig Andrews

commit sha 94b171f99a7ceee16f5921e2777c54479d421b26

dev-util/rocm-cmake: 3.0.0 version bump Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Craig Andrews <candrews@gentoo.org>

view details

Aaron Bauman

commit sha 68f06723685eacd78b4c857a046056ae20cfce15

net-libs/libmicrohttpd: arm64 stable (bug #703220) Signed-off-by: Aaron Bauman <bman@gentoo.org> Package-Manager: Portage-2.3.82, Repoman-2.3.20

view details

Thomas Deutschmann

commit sha e6294996e6cff5bfa27fd624a4d265c85d2a1bf5

dev-lang/php: bump to v7.2.26 Package-Manager: Portage-2.3.81, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

view details

Thomas Deutschmann

commit sha e564f5620ea5071a385262500fddd65497a7dd0f

dev-lang/php: bump to v7.3.13 Package-Manager: Portage-2.3.81, Repoman-2.3.20 Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

view details

Hans de Graaff

commit sha a1df7c6561425f81ff2c46a97cc9b00a58ebb3a0

dev-ruby/activesupport: add rails 5.2.4.1 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Hans de Graaff <graaff@gentoo.org>

view details

Hans de Graaff

commit sha 0f4eada2db4d805c4a67bcc25703f0e84fb8023b

dev-ruby/activemodel: add rails 5.2.4.1 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Hans de Graaff <graaff@gentoo.org>

view details

Hans de Graaff

commit sha 55b3bb0f08cf8d916518db6d0d0a5b70d3152a5a

dev-ruby/actioncable: add rails 5.2.4.1 Package-Manager: Portage-2.3.79, Repoman-2.3.16 Signed-off-by: Hans de Graaff <graaff@gentoo.org>

view details

push time in 2 months

pull request commentgentoo/gentoo

dev-util/rocminfo: New revision to set target.lst by env var

I have updated all other ebuilds in my repo, but need to test them. First I will wait to update rocm-opencl-runtime to 3.0.0.

Not all roc 3.0.0 packages have been tagged yet, so I'm not sure how you're doing bumps. For example, ROC LLVM 3.0.0 hasn't been released by upstream yet, and that's a dependency of dev-libs/rocm-comgr, dev-libs/rocm-device-libs, and dev-libs/rocm-opencl-driver.

justxi

comment created time in 2 months

pull request commentgentoo/gentoo

dev-util/rocminfo: New revision to set target.lst by env var

And rocminfo 3.0.0 is already in gentoo :)

justxi

comment created time in 2 months

PR closed gentoo/gentoo

net-libs/libtorrent-rasterbar: fix boost-1.72 compat assigned no bug found no signoff

net-p2p/libtorrent-rasterbar: fix boost-1.72 compat

In file included from src/http_connection.cpp:33: In file included from include/libtorrent/http_connection.hpp:62: In file included from include/libtorrent/socket.hpp:57: In file included from /usr/local/include/boost/asio/write.hpp:1262: /usr/local/include/boost/asio/impl/write.hpp:425:40: error: no type named 'executor_type' in 'libtorrent::socket_type' typedef typename AsyncWriteStream::executor_type executor_type; ~~~~~^ /usr/local/include/boost/asio/impl/write.hpp:534:7: note: in instantiation of template class 'boost::asio::detail::initiate_async_write_buffer_sequencelibtorrent::socket_type' requested here detail::initiate_async_write_buffer_sequence<AsyncWriteStream>(s), ^ src/http_connection.cpp:277:3: note: in instantiation of function template specialization 'boost::asio::async_write<libtorrent::socket_type, boost::asio::mutable_buffers_1, boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > > >' requested here async_write(m_sock, boost::asio::buffer(m_sendbuffer) ^ src/http_connection.cpp:631:3: error: no matching function for call to 'async_write' async_write(m_sock, boost::asio::buffer(m_sendbuffer) ^ /usr/local/include/boost/asio/impl/write.hpp:507:1: note: candidate template ignored: substitution failure [with AsyncWriteStream = libtorrent::socket_type, ConstBufferSequence = boost::asio::mutable_buffers_1, CompletionCondition = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >]: no type named 'executor_type' in 'libtorrent::socket_type' async_write(AsyncWriteStream& s, const ConstBufferSequence& buffers, ^ /usr/local/include/boost/asio/impl/write.hpp:526:1: note: candidate template ignored: substitution failure [with AsyncWriteStream = libtorrent::socket_type, ConstBufferSequence = boost::asio::mutable_buffers_1, WriteHandler = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >] async_write(AsyncWriteStream& s, const ConstBufferSequence& buffers, ^ /usr/local/include/boost/asio/impl/write.hpp:739:1: note: candidate template ignored: requirement 'is_dynamic_buffer_v1<typename decay<mutable_buffers_1>::type>::value' was not satisfied [with AsyncWriteStream = libtorrent::socket_type, DynamicBuffer_v1 = boost::asio::mutable_buffers_1, WriteHandler = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >] async_write(AsyncWriteStream& s, ^ /usr/local/include/boost/asio/impl/write.hpp:758:1: note: candidate template ignored: substitution failure [with AsyncWriteStream = libtorrent::socket_type, DynamicBuffer_v1 = boost::asio::mutable_buffers_1, CompletionCondition = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >]: no type named 'executor_type' in 'libtorrent::socket_type' async_write(AsyncWriteStream& s, ^ /usr/local/include/boost/asio/impl/write.hpp:782:1: note: candidate template ignored: could not match 'basic_streambuf<type-parameter-0-1>' against 'boost::asio::mutable_buffers_1' async_write(AsyncWriteStream& s, ^ /usr/local/include/boost/asio/impl/write.hpp:796:1: note: candidate template ignored: could not match 'basic_streambuf<type-parameter-0-1>' against 'boost::asio::mutable_buffers_1' async_write(AsyncWriteStream& s, ^ /usr/local/include/boost/asio/impl/write.hpp:1009:1: note: candidate template ignored: requirement 'is_dynamic_buffer_v2<mutable_buffers_1>::value' was not satisfied [with AsyncWriteStream = libtorrent::socket_type, DynamicBuffer_v2 = boost::asio::mutable_buffers_1, WriteHandler = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >] async_write(AsyncWriteStream& s, DynamicBuffer_v2 buffers, ^ /usr/local/include/boost/asio/impl/write.hpp:1026:1: note: candidate template ignored: substitution failure [with AsyncWriteStream = libtorrent::socket_type, DynamicBuffer_v2 = boost::asio::mutable_buffers_1, CompletionCondition = boost::_bi::bind_t<void, boost::_mfi::mf1<void, libtorrent::http_connection, const boost::system::error_code &>, boost::_bi::list2<boost::_bi::value<boost::shared_ptrlibtorrent::http_connection >, boost::arg<1> > >]: no type named 'executor_type' in 'libtorrent::socket_type' async_write(AsyncWriteStream& s, DynamicBuffer_v2 buffers, ^

Obtained from: upstream https://github.com/arvidn/libtorrent/commit/e4b812b50b0a

+20 -1

3 comments

4 changed files

V3n3RiX

pr closed time in 2 months

pull request commentgentoo/gentoo

net-libs/libtorrent-rasterbar: fix boost-1.72 compat

Duplicate of https://github.com/gentoo/gentoo/pull/14029/

Thanks, though!

V3n3RiX

comment created time in 2 months

PR opened gentoo/gentoo

www-misc/shellinabox: GLEP 81

I would like to reserve UID/GID 139 for shellinabox (www-misc/shellinabox)

Debian, Fedora, and Red Hat do not have UID/GIDs reserved for shellinabox. FreeBSD uses 139 so that's what I'm requesting.

https://api.gentoo.org/uid-gid.txt shows these numbers are being currently unused.

+150 -0

0 comment

5 changed files

pr created time in 2 months

create barnchcandrews/gentoo

branch : shellinabox-GLEP81

created branch time in 2 months

create barnchcandrews/gentoo

branch : bug703198

created branch time in 2 months

PR opened gentoo/gentoo

net-libs/libtorrent-rasterbar: Fix building with Boost 1.72

Closes: https://bugs.gentoo.org/703198 Package-Manager: Portage-2.3.82, Repoman-2.3.20 Signed-off-by: Craig Andrews candrews@gentoo.org

+25 -0

0 comment

2 changed files

pr created time in 2 months

pull request commentgentoo/gentoo

Bitcoin 0.18.1 & QA fixes

@luke-jr Are you going to update this PR so we can get it into Gentoo?

Also, will you be updating bitcoin to 0.19?

luke-jr

comment created time in 2 months

pull request commentxbmc/xbmc

Add missing cassert includes

Can this please be merged? Or is there anything I can do to push that along?

Thanks!

candrews

comment created time in 2 months

pull request commentgentoo/gentoo

app-portage/gentoopm and app-portage/smart-live-rebuild: Python 3.8 compatibility

I presume you've run gentoopm test suite as well

Yes, and that passes as well.

candrews

comment created time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha bbfc36f06c191d3bdea19cacc498afb86bd25404

Add missing cassert includes Without these includes, ‘assert’ was not declared in this scope errors occur.

view details

push time in 3 months

pull request commentxbmc/xbmc

Add missing cassert includes

gcc itself recommends #include <cassert> tho.

Thanks for pointing that out... after reading about that at https://stackoverflow.com/questions/43011737/is-it-better-to-include-cassert-or-assert-h I agree and I've changed this PR accordingly.

candrews

comment created time in 3 months

PR opened xbmc/xbmc

Add missing assert.h includes

Without these includes, this error occurs:

YPES_H=1 -DHAS_ALSA=1 -DHAS_AVAHI=1 -DHAS_ZEROCONF=1 -DHAVE_LIBBLURAY=1 -DHAVE_LIBBLURAY_BDJ=1 -DHAVE_LIBCEC=1 -DHAS_DBUS=1 -DHAVE_LCMS2=1 -DHAS_WEB_SERVER=1 -DHAS_WEB_INTERFACE=1 -DHAS_AIRPLAY=1 -DHAS_PULSEAUDIO=1 -DHAS_PYTHON=1 -DHAVE_L
IBUDEV=1 -DHAVE_LIBXSLT=1 -DHAVE_LIBVA=1 -DHAS_GLX=1 -DFFMPEG_VER_SHA=\"undef\" -I/usr/include/fribidi -DHAS_EGL=1 -DHAVE_X11=1 -DHAVE_LIBXRANDR=1 -DHAS_GL=1 -DHAS_UPNP=1 -DHAS_DVD_DRIVE -DHAS_CDDA_RIPPER -DHAS_AIRTUNES=1 -DBIN_INSTALL_PA
TH=\"/usr/lib64/kodi\" -DINSTALL_PATH=\"/usr/share/kodi\" -std=c++14 -MD -MT build/profiles/dialogs/CMakeFiles/profiles_dialogs.dir/GUIDialogProfileSettings.cpp.o -MF build/profiles/dialogs/CMakeFiles/profiles_dialogs.dir/GUIDialogProfile
Settings.cpp.o.d -o build/profiles/dialogs/CMakeFiles/profiles_dialogs.dir/GUIDialogProfileSettings.cpp.o -c /var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/profiles/dialogs/GUIDialogProfileSettings.cpp
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/profiles/dialogs/GUIDialogProfileSettings.cpp: In static member function ‘static bool CGUIDialogProfileSettings::ShowForProfile(unsigned int, bool)’:
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/profiles/dialogs/GUIDialogProfileSettings.cpp:174:5: error: ‘assert’ was not declared in this scope
  174 |     assert(profile);
      |     ^~~~~~
/var/tmp/portage/media-tv/kodi-9999/work/kodi-9999/xbmc/profiles/dialogs/GUIDialogProfileSettings.cpp:33:1: note: ‘assert’ is defined in header ‘<cassert>’; did you forget to ‘#include <cassert>’?
   32 | #include "utils/log.h"
  +++ |+#include <cassert>
   33 |

This change should also be backported to the Leia branch.

Description

<!--- Provide a general summary of your change in the Pull Request title above --> <!--- Describe your change in detail here --> This include is made in other .cpp files when assert is used, but is missing in these places.

I believe assert.h was transitively included from another header, but that other header no longer includes it. I haven't yet tracked down what on my system changed that caused this issue (potentially glibc or libfmt).

Motivation and Context

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here --> I'm seeing a compilation failure and this change fixes that failure.

How Has This Been Tested?

<!--- Please describe in detail how you tested your change --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc --> Compiled, ran Kodi, seems to work.

Screenshots (if appropriate):

n/a

Types of change

<!--- What type of change does your code introduce? Put an x in all the boxes that apply like this: [X] -->

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [ ] Improvement (non-breaking change which improves existing functionality)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that will cause existing functionality to change)
  • [ ] Cosmetic change (non-breaking change that doesn't touch code)
  • [ ] None of the above (please explain below)

Checklist:

<!--- Go over all the following points, and put an X in all the boxes that apply like this: [X] --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [X] My code follows the Code Guidelines of this project
  • [ ] My change requires a change to the documentation, either Doxygen or wiki
  • [ ] I have updated the documentation accordingly
  • [X] I have read the Contributing document
  • [ ] I have added tests to cover my change
  • [ ] All new and existing tests passed
+3 -0

0 comment

2 changed files

pr created time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha e8443dd412e61d1c2c75a080d31ddabd9879d1c7

Add missing assert.h includes Without these includes, ‘assert’ was not declared in this scope errors occur.

view details

push time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha 46177e4548692f994d16eec8e77f937708d4ff0c

Include assert.h

view details

push time in 3 months

push eventcandrews/xbmc

Craig Andrews

commit sha 09c7d4bb9db67f42f68767947d064ce3c98dec95

Include assert.h Without this include, this error occurs: ‘assert’ was not declared in this scope

view details

push time in 3 months

PR opened gentoo/gentoo

app-portage/gentoopm and app-portage/smart-live-rebuild: Python 3.8 compatibility
  • app-portage/gentoopm: Python 3.8 compatibility
  • app-portage/smart-live-rebuild: Python 3.8 compatibility

Tests pass and it works (I ran emerge --keep-going @smart-live-rebuild) so it seems good to me.

+4 -4

0 comment

4 changed files

pr created time in 3 months

create barnchcandrews/gentoo

branch : smart-live-rebuild-py38

created branch time in 3 months

pull request commentFreshRSS/FreshRSS

Manual update to SimplePie 1.5.3

I've updated this PR.

I now started with the current files in FreshRSS's repo and manually applied the SimpliePie 1.5.2->1.5.3 changes from https://github.com/simplepie/simplepie/compare/1.5.2..1.5.3

I believe that should be much more acceptable :)

candrews

comment created time in 3 months

push eventcandrews/FreshRSS

Craig Andrews

commit sha bdb0389e712f191c3420033fb368161977e96358

Manual update to SimplePie 1.5.3

view details

push time in 3 months

Pull request review commentFreshRSS/FreshRSS

Manual update to SimplePie 1.5.3

 public function get_type()  				return $official; 			}-			elseif ($official === 'text/html'-				|| $official === 'text/xml'	//FreshRSS

Thanks for pointing this out!

candrews

comment created time in 3 months

more