Dank!

@bramd bedankt voor de update! Ik heb 2 tekstuele correcties gedfaan in de README.md. @ijansch kun jij deze approven en mergen? ik mag niet meer

Yes, some work should be done on windows to enable it.

Understood. No bandwidth for this on our end right now, but I'm always pushing for the company to do more FOSS work. It's a giant slow moving machine - still, maybe I can justify it in the future. If anyone else does first, that'd be lovely, I'll keep watch on this project.

When deployer runs in windows (php for windows) then in this line escapeshellarg() corrupts an ssh command by replacing a '%' to a space so the printf become printf [exit_code: s] $?; : https://github.com/deployphp/deployer/blob/9a48ed0561dc52cf49e7fbf8b754d12ff12f55af/src/Component/Ssh/Client.php#L62 Maybe related to #1001

Also I see that ssh multiplexing via ControlPath is not working in windows. And it seems a known problem. So I just disable it.

• Deployer version: 7.0.0-beta.11
• Local OS: Windows 10 Enterprise Insider Preview x86_64 2004 20201.1000
• Target OS: Ubuntu 18.04.5 LTS
• php -v:

PHP 7.4.11 (cli) (built: Sep 29 2020 13:18:06) ( ZTS Visual C++ 2017 x64 )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Xdebug v2.9.8, Copyright (c) 2002-2020, by Derick Rethans

• A minimal reproducible example of deploy.php:

<?php
namespace Deployer;
set('ssh_multiplexing', false);
host('unix@ubuntu-h-v');
task('test_test', function () {
    $pwd = run('pwd');
    writeln($pwd);
});

Actual output:

$ dep test_test -vvv
[unix@ubuntu-h-v] C:\tools\openserver\modules\php\PHP_7.4\php.exe C:\Tools\OpenServer\userdata\composer\vendor\deployer\deployer\bin\dep connect --host unix@ubuntu-h-v --decorated -vvv
task test_test
[unix@ubuntu-h-v] C:\tools\openserver\modules\php\PHP_7.4\php.exe C:\Tools\OpenServer\userdata\composer\vendor\deployer\deployer\bin\dep worker --task test_test --host unix@ubuntu-h-v --port 15121 --decorated -vvv
[unix@ubuntu-h-v] ssh  -A unix@ubuntu-h-v  ": 0d84caafc8c06b09c0f7; bash -ls; printf  $?;"
[unix@ubuntu-h-v] run pwd
[unix@ubuntu-h-v] /home/unix
[unix@ubuntu-h-v] [exit_code:
[unix@ubuntu-h-v]  error  in deploy.php on line 6:
[unix@ubuntu-h-v] exit code -1 (Unknown error)
done test_test 1s 302ms

Expected output:

$ dep test_test -vvv
[localhost] /usr/bin/php7.4 /mnt/c/tools/openserver/userdata/composer/vendor/deployer/deployer/bin/dep connect --host localhost --decorated -vvv
task test_test
[localhost] /usr/bin/php7.4 /mnt/c/tools/openserver/userdata/composer/vendor/deployer/deployer/bin/dep worker --task test_test --host localhost --port 44209 --decorated -vvv
[localhost] ssh  -A localhost  ': d4ad40a034b99eb1827f; bash -ls; printf  $?;'
[localhost] run pwd
[localhost] /home/unix
[localhost] /home/unix
done on localhost
done test_test 3s 45ms

This is really strange. Let's try to investigate what is going on. Try to unarchive phar and show the content of modified files. Your deploy.php looks all right, I use something similar, and my phar dep works just fine.

Can you find a way to reproduce the problem?

Now I can't deploy anymore :( The first time I tried I got: Deployer\Exception\GracefulShutdownException in lock.php on line 14: Deploy locked. Execute "deploy:unlock" task to unlock. Then I tried it again: In ClassLoader.php line 444: include(phar:///usr/local/bin/dep/vendor/composer/../../src/Executor/Server.php): failed to open stream: phar error: internal corruption of phar "/usr/local/bin/dep" (crc32 mismatch on file "src/Executor/Server.php") and when I run dep status the first time: ParseError in Server.php on line 131: syntax error, unexpected '<', expecting end of file The second time: Error in Deployer.php on line 160: Class 'Deployer\Executor\Server' not found And the third times it works again

It’s insecure if password are getting logged somewhere. For example in history. Or ci logs. Deployer has secrets specifically for this case.

@data219 will try to have a look tonight

An update - I will have it today at evening.

For example, +3197010253162 does not pass validation. Problem is that the returned number type from getNumberTypeHelper method is UNKNOWN. Why?

Yes, for now I am using mysqladmin -u root password '%secret%'. But mysqladmin tells me it is insecure and it worries me.

Thank you :+1:

On the server are just two releases left now (26 and 27) where should be 5. Is that because Deployer adds up the duplicates? What should I look for in -v? Here is my deploy.php:

namespace Deployer;

require 'recipe/laravel.php';

// Project name
set('application', 'xyz');

// Project repository
set('repository', '[email protected]:patrickhoehn/xyz.git');

// [Optional] Allocate tty for git clone. Default value is false.
set('git_tty', true);

set('ssh_multiplexing', true);

// Shared files/dirs between deploys 
add('shared_files', [
    'public/.htaccess',
    'config/statamic/protect.php'
]);
/* add('shared_dirs', [
    'content',
    'public/assets'
]); */

set('writable_mode', 'chmod');

set('bin/php', function () {
    return '/usr/bin/php7.4-cli';
});

// Writable dirs by web server 
add('writable_dirs', []);

// http_user
set('http_user', 'u102339275');

// Hosts
host('xyz')
    ->set('remote_user', 'u102339275')
    ->set('identity_file', '~/.ssh/id_rsa')
    ->set('deploy_path', '/xyz');    
    
// Tasks
task('build', function () {
    run('composer install');
    run('npm install');
    run('npm run production');
})->local();

task('clear', function () {
    run('cd {{release_path}} && /usr/bin/php7.4-cli artisan cache:clear');
    run('cd {{release_path}} && rm -rf node_modules/');
});

task('upload', function () {
    upload(__DIR__ . "/", '{{release_path}}');
});

// TEST!

task('download', function () {
    download("{{deploy_path}}/shared/config", __DIR__ . "/test");
});

// TEST!

task('release', [
    'deploy:prepare',
    'deploy:release',
    'upload',
    'deploy:shared',
    'deploy:writable',
    'deploy:symlink',
]);

task('deploy', [
    'build',
    'release',
    'deploy:cleanup',
    'clear',
    'deploy:success'
]);

// [Optional] if deploy fails automatically unlock.
after('deploy:failed', 'deploy:unlock');```