profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/burtbeckwith/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

burtbeckwith/airbrake-grails 1

Airbrake Client for Grails

burtbeckwith/Catharsis.Grails.Widgets 1

Catharsis.Grails.Widgets is a Grails 2 tag library, which provides useful social media tags to include on web pages of your site

burtbeckwith/action-logging 0

Grails Plugin to enable a log of controller action events

burtbeckwith/activiti-spring-security 0

Activiti Spring Security Integration

burtbeckwith/AjaxAnywhere-grails-plugin 0

This plugin integrates the AjaxAnywhere (Reloaded) library seamlessly inside the Grails Framework ecosystem.

burtbeckwith/ajaxdependancyselection 0

Grails plugin using auto complete to fill first form field, using the id it binds to second form field and auto complete option of 2nd field based on first chosen auto completed box. This is in cases where domain object 1 hasMany of domainclass2 and domainclass2 belongs to domainclass1

burtbeckwith/app-report-card-grails-plugin 0

A Grails plugin that allows easy aggregation of app 'score' date sourced via the iTunes API.

burtbeckwith/aquagrails 0

case-study showing a case study ("Schwimmliga") plus solution in Grails

pull request commentmicronaut-projects/micronaut-core

Use javax Nullable instead of Nonnull

I tried this earlier, but I think my build config was messed up, so I didn't think this worked. I retried it with no issues. I might be missing some implications of this change, though, so please don't hesitate to critique if necessary.

mattmoss

comment created time in 4 hours

issue commentmicronaut-projects/micronaut-core

Allow custom HTTP response status codes

Looks ok to me, but maybe should target 3.0.x branch

debuglevel

comment created time in 4 hours

PR opened micronaut-projects/micronaut-core

Use javax Nullable instead of Nonnull

Fixes #5323

This is the simplest fix to eliminate the warning, by using the existing javax.annotation.Nullable.

This essentially punts the jsr305 issue down the road a bit until we can determine an alternative.

+1 -2

0 comment

1 changed file

pr created time in 5 hours

issue commentmicronaut-projects/micronaut-core

Allow custom HTTP response status codes

@graemerocher I ran into the same problem that @utsav0209 mentions about the getStatus() implementation of NettyMutableHttpResponse.

In order to be able to provide custom Http statuses, I considered refactoring the enum HttpStatus to an interface as well as to a class. Although both approaches seem to work, they both have one problem: the annotation @Status doesn't work, because according to the JSL, annotations don't allow an interface or a class as a member type.

Thus, to keep @Status working, I think it is necessary to keep HttpStatus as an enum, although there might be some possible refactoring I am not seeing.

I have a draft PR open about my current implementation to allow the enum to hold a custom status. According to my manual checking, it works well with the NettyHttpResponseFactory.

Regarding the API, I am considering the following on HttpResponse:

/**
  * Return a response for the given status, optionally a non-standard status.
  *
  * @param statusCode The status code
  * @param reason An alternatively reason message
  * @param <T>    The response type
  * @return The response
  */
static <T> MutableHttpResponse<T> status(int statusCode, String reason) {
    return HttpResponseFactory.INSTANCE.status(statusCode, reason);
}

/**
  * Return a response for the given status, optionally a non-standard status.
  *
  * @param statusCode The status code
  * @param <T>    The response type
  * @return The response
  */
static <T> MutableHttpResponse<T> status(int statusCode) {
    return HttpResponseFactory.INSTANCE.status(statusCode);
}

Caveats about my approach:

  • I haven't checked if my implementation works for the other implementations of HttpResponseFactory, beyond NettyHttpResponseFactory.
  • I removed final  from the attributes code and reason in HttpStatus, to allow setting a custom enum value.
  • Some tests are failing. I wanted to post my approach before going in to fix the tests.

I would appreciate to know if I am in the right track with this approach

debuglevel

comment created time in 5 hours

create barnchmicronaut-projects/micronaut-core

branch : issue-5323

created branch time in 5 hours

pull request commentmicronaut-projects/micronaut-core

WIP: Custom Http response status codes

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

HerCerM

comment created time in 5 hours

PR opened micronaut-projects/micronaut-core

WIP: Custom Http response status codes

This is a work-in-progress, created regarding issue #4791

+105 -4

0 comment

4 changed files

pr created time in 5 hours

delete branch micronaut-projects/micronaut-core

delete branch : issue-5323

delete time in 5 hours

create barnchmicronaut-projects/micronaut-core

branch : issue-5323

created branch time in 5 hours

issue openedmicronaut-projects/micronaut-core

NullPointerException NettyServerWebSocketHandler.createWebSocketSession

Calling WebsocketSession.getSubprotocol results in NPE as handshaker is set after super constructor is called so handshaker is always null in NettyRxWebSocketSession inner class.

https://github.com/micronaut-projects/micronaut-core/blob/f183e79e2506d41b035de877c3d95548aadc74d7/http-server-netty/src/main/java/io/micronaut/http/server/netty/websocket/NettyServerWebSocketHandler.java#L156

created time in 5 hours

push eventmicronaut-projects/micronaut-docs

jameskleeh

commit sha 50effaabd9679e0cbc2b2ebb59c472c6cb82ebcb

Deploying to gh-pages - 19:30:20

view details

push time in 5 hours

push eventmicronaut-projects/micronaut-core

jameskleeh

commit sha f183e79e2506d41b035de877c3d95548aadc74d7

Add test for #5618

view details

push time in 6 hours

push eventmicronaut-projects/micronaut-docs

jameskleeh

commit sha 99c65fbfb5dcf6c1d393a68c14e0ae40ec27e9d8

Deploying to gh-pages - 18:58:30

view details

push time in 6 hours

push eventmicronaut-projects/micronaut-docs

jameskleeh

commit sha c91b7553752bc889df3b84d4af491035a80d3b35

Deploying to gh-pages - 18:45:07

view details

push time in 6 hours

pull request commentmicronaut-projects/micronaut-core

Trim element collection in env property

As I said in the issue I'm not sure we can assume this is the desired behavior. It is easily avoided by simply not putting spaces in the config. This is also not backwards compatible

eutkin

comment created time in 6 hours

push eventmicronaut-projects/micronaut-core

jameskleeh

commit sha 0903b2cef71e33b51678072961332c2f14cf85c1

Fix compilation and checkstyle

view details

push time in 6 hours

PR closed micronaut-projects/micronaut-core

Check for multi-valued headers in a header map that encodes headers as strings

This is a suggested fix for issue #5425 , which is currently closed but is not fixed.

+262 -3

8 comments

2 changed files

BenTels

pr closed time in 6 hours

pull request commentmicronaut-projects/micronaut-core

Check for multi-valued headers in a header map that encodes headers as strings

I fixed this by reverting to the code that was in 2.4.x

BenTels

comment created time in 6 hours

push eventmicronaut-projects/micronaut-core

jameskleeh

commit sha 8bbdfe2b9b7bc78b1679983f98e091730e7f7e3b

Fix upgrade websocket connection. Fixes #5618

view details

push time in 6 hours

issue closedmicronaut-projects/micronaut-core

Websocket regression in 2.5.0, unable to inject WebSocketSession in Tests

It seems there is a regression in Micronaut 2.5.0. Injecting a WebSocketSession fails when running the app via EmbeddedServer.

For such as class:

@ServerWebSocket("/echo")
public class EchoServerWebSocket {
    protected static final Logger LOG = LoggerFactory.getLogger(EchoServerWebSocket.class);
    public static final String JOINED = "joined!";
    public static final String DISCONNECTED = "Disconnected!";

    private final WebSocketBroadcaster broadcaster;

    public EchoServerWebSocket(WebSocketBroadcaster broadcaster) {
        this.broadcaster = broadcaster;
    }

    @OnOpen
    public void onOpen(WebSocketSession session) {
        broadcaster.broadcastSync(JOINED, isValid(session));

Starting from 2.5.0 in the test I get:

 - GET /echo (Bad Request): Required argument [WebSocketSession session] not specified
18:58:04.769 [default-nioEventLoopGroup-1-4] TRACE i.m.h.s.netty.RoutingInBoundHandler - Encoding emitted response object [ /session - Required argument [WebSocketSession session] not specified] using codec: io.micronaut.jackson.codec.JsonMediaTypeCodec@792ee3a4
18:58:04.823 [default-nioEventLoopGroup-1-3] DEBUG i.m.h.s.netty.RoutingInBoundHandler - Respo

Steps to Reproduce

Expected Behaviour

Tests pass

Actual Behaviour

Tests fail

If you edit gradle.properties to micronaut 2.4.4 the test passes.

Environment Information

  • Operating System: MacOS
  • Micronaut Version: 2.5.0
  • JDK Version: JDK 11

Example Application

https://github.com/grails-core-issues-forks/websockets-issues

  • TODO: link to github repository with example that reproduces the issue

closed time in 6 hours

sdelamo

issue commentmicronaut-projects/micronaut-core

Websocket regression in 2.5.0, unable to inject WebSocketSession in Tests

I think this is due to https://github.com/micronaut-projects/micronaut-core/issues/5425

sdelamo

comment created time in 7 hours

issue commentmicronaut-projects/micronaut-core

When injecting a collection of strings, spaces are not trimmed.

I don't necessarily think we should do this. If you don't want a space don't put one in the config

eutkin

comment created time in 7 hours

issue commentmicronaut-projects/micronaut-core

Support Jackson Configuration for JsonFactory

@Ivan12273 Yes its still open, PR welcome

re-thc

comment created time in 7 hours

issue commentmicronaut-projects/micronaut-core

Support Jackson Configuration for JsonFactory

@graemerocher Hello, is this issue still open? I would like to contribute

re-thc

comment created time in 7 hours

push eventmicronaut-projects/micronaut-security

Sergio del Amo

commit sha 2b1bf71864994b03cc418ac395d9328e91101349

test: testcontainers webdriver see: https://www.testcontainers.org/modules/webdriver_containers/

view details

push time in 7 hours

pull request commentmicronaut-projects/micronaut-core

Include Maven configuration for javaParameters option

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

lelerabino

comment created time in 8 hours

PR opened micronaut-projects/micronaut-core

Include Maven configuration for javaParameters option

This can save people from (hard)troubleshooting especially because the micronaut-gradle-plugin automatically set the flag to true but not the micronaut-maven-plugin. Working with micronaut-data and JdbcRepository results in compiler error because of this.

+27 -1

0 comment

1 changed file

pr created time in 8 hours

issue openedmicronaut-projects/micronaut-core

Websocket regression in 2.5.0, unable to inject WebSocketSession in Tests

It seems there is a regression in Micronaut 2.5.0. Injecting a WebSocketSession fails when running the app via EmbeddedServer.

For such as class:

@ServerWebSocket("/echo")
public class EchoServerWebSocket {
    protected static final Logger LOG = LoggerFactory.getLogger(EchoServerWebSocket.class);
    public static final String JOINED = "joined!";
    public static final String DISCONNECTED = "Disconnected!";

    private final WebSocketBroadcaster broadcaster;

    public EchoServerWebSocket(WebSocketBroadcaster broadcaster) {
        this.broadcaster = broadcaster;
    }

    @OnOpen
    public void onOpen(WebSocketSession session) {
        broadcaster.broadcastSync(JOINED, isValid(session));

Starting from 2.5.0 in the test I get:

 - GET /echo (Bad Request): Required argument [WebSocketSession session] not specified
18:58:04.769 [default-nioEventLoopGroup-1-4] TRACE i.m.h.s.netty.RoutingInBoundHandler - Encoding emitted response object [ /session - Required argument [WebSocketSession session] not specified] using codec: io.micronaut.jackson.codec.JsonMediaTypeCodec@792ee3a4
18:58:04.823 [default-nioEventLoopGroup-1-3] DEBUG i.m.h.s.netty.RoutingInBoundHandler - Respo

Steps to Reproduce

Expected Behaviour

Tests pass

Actual Behaviour

Tests fail

If you edit gradle.properties to micronaut 2.4.4 the test passes.

Environment Information

  • Operating System: MacOS
  • Micronaut Version: 2.5.0
  • JDK Version: JDK 11

Example Application

https://github.com/grails-core-issues-forks/websockets-issues

  • TODO: link to github repository with example that reproduces the issue

created time in 8 hours

push eventmicronaut-projects/micronaut-security

Sergio del Amo

commit sha 56e23a36160e87471b37eba8f513b4ee94c9cc6a

test: testcontainers webdriver see: https://www.testcontainers.org/modules/webdriver_containers/

view details

push time in 9 hours

pull request commentmicronaut-projects/micronaut-core

ISSUE 5615: Trim element collection in env property

CLA assistant check <br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><hr/>e.utkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.<br/><sub>You have signed the CLA already but the status is still pending? Let us recheck it.</sub>

eutkin

comment created time in 9 hours