I tried this earlier, but I think my build config was messed up, so I didn't think this worked. I retried it with no issues. I might be missing some implications of this change, though, so please don't hesitate to critique if necessary.

Looks ok to me, but maybe should target 3.0.x branch

Fixes #5323

This is the simplest fix to eliminate the warning, by using the existing javax.annotation.Nullable.

This essentially punts the jsr305 issue down the road a bit until we can determine an alternative.

@graemerocher I ran into the same problem that @utsav0209 mentions about the getStatus() implementation of NettyMutableHttpResponse.

In order to be able to provide custom Http statuses, I considered refactoring the enum HttpStatus to an interface as well as to a class. Although both approaches seem to work, they both have one problem: the annotation @Status doesn't work, because according to the JSL, annotations don't allow an interface or a class as a member type.

Thus, to keep @Status working, I think it is necessary to keep HttpStatus as an enum, although there might be some possible refactoring I am not seeing.

I have a draft PR open about my current implementation to allow the enum to hold a custom status. According to my manual checking, it works well with the NettyHttpResponseFactory.

Regarding the API, I am considering the following on HttpResponse:

/**
  * Return a response for the given status, optionally a non-standard status.
  *
  * @param statusCode The status code
  * @param reason An alternatively reason message
  * @param <T>    The response type
  * @return The response
  */
static <T> MutableHttpResponse<T> status(int statusCode, String reason) {
    return HttpResponseFactory.INSTANCE.status(statusCode, reason);
}

/**
  * Return a response for the given status, optionally a non-standard status.
  *
  * @param statusCode The status code
  * @param <T>    The response type
  * @return The response
  */
static <T> MutableHttpResponse<T> status(int statusCode) {
    return HttpResponseFactory.INSTANCE.status(statusCode);
}

Caveats about my approach:

• I haven't checked if my implementation works for the other implementations of HttpResponseFactory, beyond NettyHttpResponseFactory.
• I removed final  from the attributes code and reason in HttpStatus, to allow setting a custom enum value.
• Some tests are failing. I wanted to post my approach before going in to fix the tests.

I would appreciate to know if I am in the right track with this approach

<br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/>_{You have signed the CLA already but the status is still pending? Let us recheck it.}

This is a work-in-progress, created regarding issue #4791

Calling WebsocketSession.getSubprotocol results in NPE as handshaker is set after super constructor is called so handshaker is always null in NettyRxWebSocketSession inner class.

https://github.com/micronaut-projects/micronaut-core/blob/f183e79e2506d41b035de877c3d95548aadc74d7/http-server-netty/src/main/java/io/micronaut/http/server/netty/websocket/NettyServerWebSocketHandler.java#L156

As I said in the issue I'm not sure we can assume this is the desired behavior. It is easily avoided by simply not putting spaces in the config. This is also not backwards compatible

This is a suggested fix for issue #5425 , which is currently closed but is not fixed.

I fixed this by reverting to the code that was in 2.4.x

It seems there is a regression in Micronaut 2.5.0. Injecting a WebSocketSession fails when running the app via EmbeddedServer.

For such as class:

@ServerWebSocket("/echo")
public class EchoServerWebSocket {
    protected static final Logger LOG = LoggerFactory.getLogger(EchoServerWebSocket.class);
    public static final String JOINED = "joined!";
    public static final String DISCONNECTED = "Disconnected!";

    private final WebSocketBroadcaster broadcaster;

    public EchoServerWebSocket(WebSocketBroadcaster broadcaster) {
        this.broadcaster = broadcaster;
    }

    @OnOpen
    public void onOpen(WebSocketSession session) {
        broadcaster.broadcastSync(JOINED, isValid(session));

Starting from 2.5.0 in the test I get:

 - GET /echo (Bad Request): Required argument [WebSocketSession session] not specified
18:58:04.769 [default-nioEventLoopGroup-1-4] TRACE i.m.h.s.netty.RoutingInBoundHandler - Encoding emitted response object [ /session - Required argument [WebSocketSession session] not specified] using codec: io.micronaut.jackson.codec.JsonMediaTypeCodec@792ee3a4
18:58:04.823 [default-nioEventLoopGroup-1-3] DEBUG i.m.h.s.netty.RoutingInBoundHandler - Respo

Steps to Reproduce

• Clone the sample application repository
• ./gradlew test

Expected Behaviour

Tests pass

Actual Behaviour

Tests fail

If you edit gradle.properties to micronaut 2.4.4 the test passes.

Environment Information

• Operating System: MacOS
• Micronaut Version: 2.5.0
• JDK Version: JDK 11

Example Application

https://github.com/grails-core-issues-forks/websockets-issues

• TODO: link to github repository with example that reproduces the issue

I think this is due to https://github.com/micronaut-projects/micronaut-core/issues/5425

I don't necessarily think we should do this. If you don't want a space don't put one in the config

@Ivan12273 Yes its still open, PR welcome

@graemerocher Hello, is this issue still open? I would like to contribute

<br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/>_{You have signed the CLA already but the status is still pending? Let us recheck it.}

This can save people from (hard)troubleshooting especially because the micronaut-gradle-plugin automatically set the flag to true but not the micronaut-maven-plugin. Working with micronaut-data and JdbcRepository results in compiler error because of this.

It seems there is a regression in Micronaut 2.5.0. Injecting a WebSocketSession fails when running the app via EmbeddedServer.

For such as class:

@ServerWebSocket("/echo")
public class EchoServerWebSocket {
    protected static final Logger LOG = LoggerFactory.getLogger(EchoServerWebSocket.class);
    public static final String JOINED = "joined!";
    public static final String DISCONNECTED = "Disconnected!";

    private final WebSocketBroadcaster broadcaster;

    public EchoServerWebSocket(WebSocketBroadcaster broadcaster) {
        this.broadcaster = broadcaster;
    }

    @OnOpen
    public void onOpen(WebSocketSession session) {
        broadcaster.broadcastSync(JOINED, isValid(session));

Starting from 2.5.0 in the test I get:

 - GET /echo (Bad Request): Required argument [WebSocketSession session] not specified
18:58:04.769 [default-nioEventLoopGroup-1-4] TRACE i.m.h.s.netty.RoutingInBoundHandler - Encoding emitted response object [ /session - Required argument [WebSocketSession session] not specified] using codec: io.micronaut.jackson.codec.JsonMediaTypeCodec@792ee3a4
18:58:04.823 [default-nioEventLoopGroup-1-3] DEBUG i.m.h.s.netty.RoutingInBoundHandler - Respo

Steps to Reproduce

• Clone the sample application repository
• ./gradlew test

Expected Behaviour

Tests pass

Actual Behaviour

Tests fail

If you edit gradle.properties to micronaut 2.4.4 the test passes.

Environment Information

• Operating System: MacOS
• Micronaut Version: 2.5.0
• JDK Version: JDK 11

Example Application

https://github.com/grails-core-issues-forks/websockets-issues

• TODO: link to github repository with example that reproduces the issue

<br/>Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.<br/><hr/>e.utkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.<br/>_{You have signed the CLA already but the status is still pending? Let us recheck it.}