profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/burningTyger/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

burningTyger/farhang-app 3

A Ruby frontend to the farhang database - can be used for other dictionaries as well.

burningTyger/goliath 2

Goliath is a non-blocking Ruby web server framework

burningTyger/bootstrap 1

HTML, CSS, and JS toolkit from Twitter

burningTyger/coffee-script-tmbundle 1

A TextMate Bundle for CoffeeScript

burningTyger/dm-is-tree 1

DataMapper plugin allowing the creation of tree structures from data models

burningTyger/dm-rest-adapter 1

REST Adapter for DataMapper

burningTyger/dm-types 1

DataMapper plugin providing extra data types

burningTyger/farhang 1

Deutsch-Persisches Lexikon

burningTyger/farhang-txt2mongo 1

A converter and integrity checker for the farhang lexicon files

burningTyger/gmail-notifr 1

A MacRuby Gmail Notifier for Mac OS X

release dbeaver/dbeaver

21.1.1

released time in a day

release usablica/intro.js

v4.1.0

released time in 4 days

issue openedsveltejs/gestures

Dead?

Is this project dead? Last commit I see is from @Rich-Harris in September 2019. Will this be worked on anytime soon?

created time in 8 days

release usablica/intro.js

4.0.0

released time in 9 days

release developit/microbundle

v0.13.3

released time in 11 days

issue commenthuyng/bashmarks

"l" question

yes, "l" is a very common alias for "ls", ideally there would be a way to prefix all bashmark commands with "b", eg "bl" instead of just "l".

Here is a fork that implements it: https://github.com/bachya/bashmarks

How do i add the prefix command? "bm"

choman

comment created time in 11 days

PR opened burningTyger/electron-pdf-bug

build(deps): bump normalize-url from 4.5.0 to 4.5.1

Bumps normalize-url from 4.5.0 to 4.5.1. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/sindresorhus/normalize-url/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

pr created time in 11 days

PR opened burningTyger/svelte-viewer

Bump normalize-url from 4.3.0 to 4.5.1

Bumps normalize-url from 4.3.0 to 4.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/sindresorhus/normalize-url/releases">normalize-url's releases</a>.</em></p> <blockquote> <h2>v4.5.0</h2> <ul> <li>Strip default MIME type and charset in data URLs (<a href="https://github-redirect.dependabot.com/sindresorhus/normalize-url/issues/100">#100</a>) 308909b</li> </ul> <p><a href="https://github.com/sindresorhus/normalize-url/compare/v4.4.1...v4.5.0">https://github.com/sindresorhus/normalize-url/compare/v4.4.1...v4.5.0</a></p> <h2>v4.4.1</h2> <ul> <li>Fix data URL should not support query strings (<a href="https://github-redirect.dependabot.com/sindresorhus/normalize-url/issues/97">#97</a>) fb92bcb</li> </ul> <p><a href="https://github.com/sindresorhus/normalize-url/compare/v4.4.0...v4.4.1">https://github.com/sindresorhus/normalize-url/compare/v4.4.0...v4.4.1</a></p> <h2>v4.4.0</h2> <ul> <li>Add data URL support (<a href="https://github-redirect.dependabot.com/sindresorhus/normalize-url/issues/95">#95</a>) 7df5aff</li> </ul> <p><a href="https://github.com/sindresorhus/normalize-url/compare/v4.3.0...v4.4.0">https://github.com/sindresorhus/normalize-url/compare/v4.3.0...v4.4.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/sindresorhus/normalize-url/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

pr created time in 12 days

release developit/microbundle

v0.13.2

released time in 15 days

created repositoryRich-Harris/svelte-knobby

created time in a month

issue closedsveltejs/svelte

[Website] Scrollbar Partially Obscured on svelte.dev

Describe the bug The scrollbar on svelte.dev is partially obscured. See the top right corner in this image. obscured-scrollbar

Logs None

To Reproduce Visit svelte.dev with a Chromium browser (tested on Opera and Chrome).

Expected behavior The scrollbar should not be obscured. visible-scrollbar

Stacktraces None

Severity Low

Additional context On svelte-community.netlify.app, a site that looks quite similar to svelte.dev, the problem does not exist.

Removing overflow-x: hidden from the main tag, seems to do the trick. This is defined in sveltejs/svelte/blob/master/site/src/routes/_layout.svelte.

closed time in a month

Acmion

issue commentsveltejs/svelte

[Website] Scrollbar Partially Obscured on svelte.dev

This can be closed as the PR that resolved it has been merged with @benmccann saying it's been resolved.

Acmion

comment created time in a month

PR opened sveltejs/svelte

01-basics/app-a/App.svelte: add structure of svelte file so it is clear to users reading the docs

It may be more clear to the user learning Svelte via this documentation to see what the typical structure of a .svelte file looks like instead of just having an h1 tag inside of the App.svelte file which just represents an HTML tag. With this proposed changed, it's much clearer what every .svelte file consists of.

Screenshot of .svelte file representation in REPL before

image

Screenshot of .svelte file representation in REPL after image

Tests

  • [x] Run the tests with npm test and lint the project with npm run lint
+11 -1

0 comment

1 changed file

pr created time in a month

issue commentsveltejs/svelte

Extended HTML rendering

HTML strings rendered by @html need to be simple HTML, they can't contain Svelte-specific things. This is the runtime-constraint I was talking about earlier.

Okay so is @html rendered at runtime? Are the HTML strings it (pre)renders not accessible in a preprocessor? In that case a preprocessor isn't the answer to this use-case. And if those strings are available in a preprocessor then is there a way to target them specifically? If not then preprocessors also aren't an answer to this use-case, because we need a way to enrich 3rd party HTML / HTML strings, not component template markup as a blanket thing.

Example

<h1>Some component</>
<article>
  <!-- HTML content to enrich with Svelte actions/components/etc -->
  {@html cmsContent}
</article>

As for documentation, totally understand not wanting to add recipes to the official docs (though maybe links out to those recipes/community resources would be good? Unless I missed that in the docs). Still though I'd argue the current svelte.preprocess docs are lacking. For example this very issue about how @html works in that context, and maybe I'm just dense but I didn't realise you could just pass back Svelte components/templates as strings and have them be rendered properly.

madeleineostoja

comment created time in a month

issue closedsveltejs/svelte

store/index.js tests don't run on `npm run test`

Describe the bug

test/store/index.js tests don't run on npm run test.

Seems like any non index.ts does not run due to this line in the test/test.ts:

const test_folders = glob('*/index.ts', { cwd: 'test' });

To Reproduce

I've made one test in test/store/index.js always fail and got following result: <details> <summary>Tail of npm run test output</summary>

stats
    ✓ basic
    ✓ returns a stats object when options.generate is false

  validate
    ✓ a11y-alt-text
    ✓ a11y-anchor-has-content
    ✓ a11y-anchor-in-svg-is-valid
    ✓ a11y-anchor-is-valid
    ✓ a11y-aria-props
    ✓ a11y-aria-role
    ✓ a11y-aria-unsupported-element
    ✓ a11y-contenteditable-element-without-child
    ✓ a11y-figcaption-in-non-element-block
    ✓ a11y-figcaption-right-place
    ✓ a11y-figcaption-wrong-place
    ✓ a11y-heading-has-content
    ✓ a11y-html-has-lang
    ✓ a11y-iframe-has-title
    ✓ a11y-img-redundant-alt
    ✓ a11y-in-foreign-namespace
    ✓ a11y-label-has-associated-control
    ✓ a11y-media-has-caption
    ✓ a11y-no-access-key
    ✓ a11y-no-autofocus
    ✓ a11y-no-distracting-elements
    ✓ a11y-no-onchange
    ✓ a11y-not-on-components
    ✓ a11y-scope
    ✓ a11y-tabindex-no-positive
    ✓ action-invalid
    ✓ action-object
    ✓ action-on-component
    ✓ animation-duplicate
    ✓ animation-missing
    ✓ animation-not-in-each
    ✓ animation-not-in-keyed-each
    ✓ animation-siblings
    ✓ attribute-expected-equals
    ✓ attribute-invalid-name
    ✓ attribute-invalid-name-2
    ✓ attribute-invalid-name-3
    ✓ attribute-invalid-name-4
    ✓ attribute-invalid-name-5
    ✓ await-component-is-used
    ✓ await-no-catch
    ✓ await-shorthand-no-catch
    ✓ await-shorthand-no-then
    ✓ binding-await-catch
    ✓ binding-await-then
    ✓ binding-await-then-2
    ✓ binding-const
    ✓ binding-const-field
    ✓ binding-dimensions-svg
    ✓ binding-dimensions-svg-child
    ✓ binding-dimensions-void
    ✓ binding-input-checked
    ✓ binding-input-type-boolean
    ✓ binding-input-type-dynamic
    ✓ binding-invalid
    ✓ binding-invalid-foreign-namespace
    ✓ binding-invalid-on-element
    ✓ binding-invalid-value
    ✓ binding-invalid-value-global
    ✓ binding-let
    ✓ binding-select-multiple-dynamic
    ✓ catch-declares-error-variable
    ✓ component-dynamic
    ✓ component-event-modifiers-invalid
    ✓ component-name-lowercase
    ✓ component-namespaced
    - component-slot-default-duplicate.skip
    ✓ component-slot-default-reserved
    ✓ component-slot-dynamic
    ✓ component-slot-dynamic-attribute
    - component-slot-named-duplicate.skip
    ✓ component-slotted-custom-element
    ✓ component-slotted-custom-element-2
    ✓ component-slotted-each-block
    ✓ component-slotted-if-block
    ✓ contenteditable-dynamic
    ✓ contenteditable-missing
    ✓ css-invalid-global-placement
    ✓ debug-invalid-args
    ✓ default-export
    ✓ directive-non-expression
    ✓ dollar-dollar-global-in-markup
    ✓ dollar-dollar-global-in-script
    ✓ dollar-global-in-markup
    ✓ dollar-global-in-script
    ✓ each-block-destructured-object-rest-comma-after
    ✓ each-block-invalid-context
    ✓ each-block-invalid-context-destructured
    ✓ each-block-invalid-context-destructured-object
    ✓ each-block-multiple-children
    ✓ empty-block
    ✓ event-modifiers-invalid
    ✓ event-modifiers-invalid-nonpassive
    ✓ event-modifiers-invalid-passive
    ✓ event-modifiers-legacy
    ✓ event-modifiers-redundant
    ✓ ignore-warning
    ✓ ignore-warnings
    ✓ ignore-warnings-cumulative
    ✓ ignore-warnings-newline
    ✓ ignore-warnings-stacked
    ✓ import-meta
    ✓ invalid-empty-css-declaration
    ✓ missing-component
    ✓ missing-component-global
    ✓ missing-custom-element-compile-options
    ✓ module-script-reactive-declaration
    ✓ multiple-script-default-context
    ✓ multiple-script-module-context
    ✓ namespace-invalid
    ✓ namespace-invalid-unguessable
    ✓ namespace-non-literal
    ✓ non-empty-block-dev
    ✓ reactive-declaration-cyclical
    ✓ reactive-declaration-non-top-level
    ✓ reactive-module-variable
    ✓ ref-not-supported
    ✓ ref-not-supported-in-css
    ✓ script-invalid-context
    ✓ select-multiple
    ✓ slot-attribute-invalid
    ✓ svelte-slot-placement
    ✓ svelte-slot-placement-2
    ✓ svg-child-component-declared-namespace
    ✓ tag-custom-element-options-missing
    ✓ tag-custom-element-options-true
    ✓ tag-invalid
    ✓ tag-non-string
    ✓ textarea-value-children
    ✓ title-no-attributes
    ✓ title-no-children
    ✓ transition-duplicate-in
    ✓ transition-duplicate-in-transition
    ✓ transition-duplicate-out
    ✓ transition-duplicate-out-transition
    ✓ transition-duplicate-transition
    ✓ transition-duplicate-transition-in
    ✓ transition-duplicate-transition-out
    ✓ transition-missing
    ✓ transition-on-component
    ✓ undefined-value
    ✓ undefined-value-global
    ✓ unreferenced-variables
    ✓ use-the-platform
    ✓ window-binding-invalid
    ✓ window-binding-invalid-innerwidth
    ✓ window-binding-invalid-value
    ✓ window-binding-invalid-width
    ✓ window-binding-online
    ✓ errors if options.name is illegal
    ✓ warns if options.name is not capitalised
    ✓ does not warn if options.name begins with non-alphabetic character
    ✓ errors if namespace is provided but unrecognised
    ✓ errors with a hint if namespace is provided but unrecognised but close
    ✓ does not throw error if 'this' is bound for foreign element

  vars
    ✓ $$props, generate: dom
    ✓ $$props, generate: ssr
    ✓ $$props, generate: false
    ✓ $$props-logicless, generate: dom
    ✓ $$props-logicless, generate: ssr
    ✓ $$props-logicless, generate: false
    ✓ actions, generate: dom
    ✓ actions, generate: ssr
    ✓ actions, generate: false
    ✓ animations, generate: dom
    ✓ animations, generate: ssr
    ✓ animations, generate: false
    ✓ assumed-global, generate: dom
    ✓ assumed-global, generate: ssr
    ✓ assumed-global, generate: false
    ✓ component-namespaced, generate: dom
    ✓ component-namespaced, generate: ssr
    ✓ component-namespaced, generate: false
    ✓ duplicate-globals, generate: dom
    ✓ duplicate-globals, generate: ssr
    ✓ duplicate-globals, generate: false
    ✓ duplicate-non-hoistable, generate: dom
    ✓ duplicate-non-hoistable, generate: ssr
    ✓ duplicate-non-hoistable, generate: false
    ✓ duplicate-vars, generate: dom
    ✓ duplicate-vars, generate: ssr
    ✓ duplicate-vars, generate: false
    ✓ implicit-reactive, generate: dom
    ✓ implicit-reactive, generate: ssr
    ✓ implicit-reactive, generate: false
    ✓ imports, generate: dom
    ✓ imports, generate: ssr
    ✓ imports, generate: false
    ✓ modules-vars, generate: dom
    ✓ modules-vars, generate: ssr
    ✓ modules-vars, generate: false
    ✓ mutated-vs-reassigned, generate: dom
    ✓ mutated-vs-reassigned, generate: ssr
    ✓ mutated-vs-reassigned, generate: false
    ✓ mutated-vs-reassigned-bindings, generate: dom
    ✓ mutated-vs-reassigned-bindings, generate: ssr
    ✓ mutated-vs-reassigned-bindings, generate: false
    ✓ props, generate: dom (46ms)
    ✓ props, generate: ssr
    ✓ props, generate: false
    ✓ referenced-from-script, generate: dom
    ✓ referenced-from-script, generate: ssr
    ✓ referenced-from-script, generate: false
    ✓ store-referenced, generate: dom
    ✓ store-referenced, generate: ssr
    ✓ store-referenced, generate: false
    ✓ store-unreferenced, generate: dom
    ✓ store-unreferenced, generate: ssr
    ✓ store-unreferenced, generate: false
    ✓ template-references, generate: dom
    ✓ template-references, generate: ssr
    ✓ template-references, generate: false
    ✓ transitions, generate: dom
    ✓ transitions, generate: ssr
    ✓ transitions, generate: false
    ✓ undeclared, generate: dom
    ✓ undeclared, generate: ssr
    ✓ undeclared, generate: false


  3332 passing (1m)
  24 pending


> svelte@3.38.2 posttest
> agadoo internal/index.mjs



Success! internal/index.mjs is fully tree-shakeable

</details>

Then I've replaced the line with const test_folders = glob('*/index.{js,ts}', { cwd: 'test' }); in test/test.ts and got following result:

<details> <summary>Tail of npm run test output</summary>

  stats
    ✓ basic
    ✓ returns a stats object when options.generate is false

  store
    writable
      1) creates a writable store
      ✓ calls provided subscribe handler
      ✓ does not assume immutable data
      ✓ only calls subscriber once initially, including on resubscriptions
    readable
      ✓ creates a readable store
    derived
      ✓ maps a single store
      ✓ maps multiple stores
      ✓ passes optional set function
      ✓ prevents glitches
      ✓ prevents diamond dependency problem
      ✓ derived dependency does not update and shared ancestor updates
      ✓ is updated with safe_not_equal logic
      ✓ calls a cleanup function
      ✓ discards non-function return values
      ✓ allows derived with different types
      ✓ works with RxJS-style observables
    get
      ✓ gets the current value of a store
      ✓ works with RxJS-style observables

  validate
    ✓ a11y-alt-text
    ✓ a11y-anchor-has-content
    ✓ a11y-anchor-in-svg-is-valid
    ✓ a11y-anchor-is-valid
    ✓ a11y-aria-props
    ✓ a11y-aria-role
    ✓ a11y-aria-unsupported-element
    ✓ a11y-contenteditable-element-without-child
    ✓ a11y-figcaption-in-non-element-block
    ✓ a11y-figcaption-right-place
    ✓ a11y-figcaption-wrong-place
    ✓ a11y-heading-has-content
    ✓ a11y-html-has-lang
    ✓ a11y-iframe-has-title
    ✓ a11y-img-redundant-alt
    ✓ a11y-in-foreign-namespace
    ✓ a11y-label-has-associated-control
    ✓ a11y-media-has-caption
    ✓ a11y-no-access-key
    ✓ a11y-no-autofocus
    ✓ a11y-no-distracting-elements
    ✓ a11y-no-onchange
    ✓ a11y-not-on-components
    ✓ a11y-scope
    ✓ a11y-tabindex-no-positive
    ✓ action-invalid
    ✓ action-object
    ✓ action-on-component
    ✓ animation-duplicate
    ✓ animation-missing
    ✓ animation-not-in-each
    ✓ animation-not-in-keyed-each
    ✓ animation-siblings
    ✓ attribute-expected-equals
    ✓ attribute-invalid-name
    ✓ attribute-invalid-name-2
    ✓ attribute-invalid-name-3
    ✓ attribute-invalid-name-4
    ✓ attribute-invalid-name-5
    ✓ await-component-is-used
    ✓ await-no-catch
    ✓ await-shorthand-no-catch
    ✓ await-shorthand-no-then
    ✓ binding-await-catch
    ✓ binding-await-then
    ✓ binding-await-then-2
    ✓ binding-const
    ✓ binding-const-field
    ✓ binding-dimensions-svg
    ✓ binding-dimensions-svg-child
    ✓ binding-dimensions-void
    ✓ binding-input-checked
    ✓ binding-input-type-boolean
    ✓ binding-input-type-dynamic
    ✓ binding-invalid
    ✓ binding-invalid-foreign-namespace
    ✓ binding-invalid-on-element
    ✓ binding-invalid-value
    ✓ binding-invalid-value-global
    ✓ binding-let
    ✓ binding-select-multiple-dynamic
    ✓ catch-declares-error-variable
    ✓ component-dynamic
    ✓ component-event-modifiers-invalid
    ✓ component-name-lowercase
    ✓ component-namespaced
    - component-slot-default-duplicate.skip
    ✓ component-slot-default-reserved
    ✓ component-slot-dynamic
    ✓ component-slot-dynamic-attribute
    - component-slot-named-duplicate.skip
    ✓ component-slotted-custom-element
    ✓ component-slotted-custom-element-2
    ✓ component-slotted-each-block
    ✓ component-slotted-if-block
    ✓ contenteditable-dynamic
    ✓ contenteditable-missing
    ✓ css-invalid-global-placement
    ✓ debug-invalid-args
    ✓ default-export
    ✓ directive-non-expression
    ✓ dollar-dollar-global-in-markup
    ✓ dollar-dollar-global-in-script
    ✓ dollar-global-in-markup
    ✓ dollar-global-in-script
    ✓ each-block-destructured-object-rest-comma-after
    ✓ each-block-invalid-context
    ✓ each-block-invalid-context-destructured
    ✓ each-block-invalid-context-destructured-object
    ✓ each-block-multiple-children
    ✓ empty-block
    ✓ event-modifiers-invalid
    ✓ event-modifiers-invalid-nonpassive
    ✓ event-modifiers-invalid-passive
    ✓ event-modifiers-legacy
    ✓ event-modifiers-redundant
    ✓ ignore-warning
    ✓ ignore-warnings
    ✓ ignore-warnings-cumulative
    ✓ ignore-warnings-newline
    ✓ ignore-warnings-stacked
    ✓ import-meta
    ✓ invalid-empty-css-declaration
    ✓ missing-component
    ✓ missing-component-global
    ✓ missing-custom-element-compile-options
    ✓ module-script-reactive-declaration
    ✓ multiple-script-default-context
    ✓ multiple-script-module-context
    ✓ namespace-invalid
    ✓ namespace-invalid-unguessable
    ✓ namespace-non-literal
    ✓ non-empty-block-dev
    ✓ reactive-declaration-cyclical
    ✓ reactive-declaration-non-top-level
    ✓ reactive-module-variable
    ✓ ref-not-supported
    ✓ ref-not-supported-in-css
    ✓ script-invalid-context
    ✓ select-multiple
    ✓ slot-attribute-invalid
    ✓ svelte-slot-placement
    ✓ svelte-slot-placement-2
    ✓ svg-child-component-declared-namespace
    ✓ tag-custom-element-options-missing
    ✓ tag-custom-element-options-true
    ✓ tag-invalid
    ✓ tag-non-string
    ✓ textarea-value-children
    ✓ title-no-attributes
    ✓ title-no-children
    ✓ transition-duplicate-in
    ✓ transition-duplicate-in-transition
    ✓ transition-duplicate-out
    ✓ transition-duplicate-out-transition
    ✓ transition-duplicate-transition
    ✓ transition-duplicate-transition-in
    ✓ transition-duplicate-transition-out
    ✓ transition-missing
    ✓ transition-on-component
    ✓ undefined-value
    ✓ undefined-value-global
    ✓ unreferenced-variables
    ✓ use-the-platform
    ✓ window-binding-invalid
    ✓ window-binding-invalid-innerwidth
    ✓ window-binding-invalid-value
    ✓ window-binding-invalid-width
    ✓ window-binding-online
    ✓ errors if options.name is illegal
    ✓ warns if options.name is not capitalised
    ✓ does not warn if options.name begins with non-alphabetic character
    ✓ errors if namespace is provided but unrecognised
    ✓ errors with a hint if namespace is provided but unrecognised but close
    ✓ does not throw error if 'this' is bound for foreign element

  vars
    ✓ $$props, generate: dom
    ✓ $$props, generate: ssr
    ✓ $$props, generate: false
    ✓ $$props-logicless, generate: dom
    ✓ $$props-logicless, generate: ssr
    ✓ $$props-logicless, generate: false
    ✓ actions, generate: dom
    ✓ actions, generate: ssr
    ✓ actions, generate: false
    ✓ animations, generate: dom
    ✓ animations, generate: ssr
    ✓ animations, generate: false
    ✓ assumed-global, generate: dom
    ✓ assumed-global, generate: ssr
    ✓ assumed-global, generate: false
    ✓ component-namespaced, generate: dom
    ✓ component-namespaced, generate: ssr
    ✓ component-namespaced, generate: false
    ✓ duplicate-globals, generate: dom
    ✓ duplicate-globals, generate: ssr
    ✓ duplicate-globals, generate: false
    ✓ duplicate-non-hoistable, generate: dom
    ✓ duplicate-non-hoistable, generate: ssr
    ✓ duplicate-non-hoistable, generate: false
    ✓ duplicate-vars, generate: dom
    ✓ duplicate-vars, generate: ssr
    ✓ duplicate-vars, generate: false
    ✓ implicit-reactive, generate: dom
    ✓ implicit-reactive, generate: ssr
    ✓ implicit-reactive, generate: false
    ✓ imports, generate: dom
    ✓ imports, generate: ssr
    ✓ imports, generate: false
    ✓ modules-vars, generate: dom
    ✓ modules-vars, generate: ssr
    ✓ modules-vars, generate: false
    ✓ mutated-vs-reassigned, generate: dom
    ✓ mutated-vs-reassigned, generate: ssr
    ✓ mutated-vs-reassigned, generate: false
    ✓ mutated-vs-reassigned-bindings, generate: dom
    ✓ mutated-vs-reassigned-bindings, generate: ssr
    ✓ mutated-vs-reassigned-bindings, generate: false
    ✓ props, generate: dom (46ms)
    ✓ props, generate: ssr
    ✓ props, generate: false
    ✓ referenced-from-script, generate: dom
    ✓ referenced-from-script, generate: ssr
    ✓ referenced-from-script, generate: false
    ✓ store-referenced, generate: dom
    ✓ store-referenced, generate: ssr
    ✓ store-referenced, generate: false
    ✓ store-unreferenced, generate: dom
    ✓ store-unreferenced, generate: ssr
    ✓ store-unreferenced, generate: false
    ✓ template-references, generate: dom
    ✓ template-references, generate: ssr
    ✓ template-references, generate: false
    ✓ transitions, generate: dom (41ms)
    ✓ transitions, generate: ssr
    ✓ transitions, generate: false
    ✓ undeclared, generate: dom
    ✓ undeclared, generate: ssr
    ✓ undeclared, generate: false


  3349 passing (2m)
  24 pending
  1 failing

  1) store
       writable
         creates a writable store:
     AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:

[
  0,
  1,
  2
]

should loosely deep-equal

0
      at Context.<anonymous> (test/store/index.js:22:11)
      at processImmediate (node:internal/timers:464:21)

</details>

Pay attention now there is store section after stats and before validate.

Expected behavior

All tests run on npm run test.

closed time in a month

subtle-byte

issue commentsveltejs/svelte

store/index.js tests don't run on `npm run test`

Fixed by #6293

subtle-byte

comment created time in a month

PR closed sveltejs/svelte

Fixing not running index.js tests

Fixes #6330

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with npm test and lint the project with npm run lint
+1 -1

2 comments

1 changed file

subtle-byte

pr closed time in a month

pull request commentsveltejs/svelte

Fixing not running index.js tests

Fixed by #6293

subtle-byte

comment created time in a month

pull request commentsveltejs/svelte

Fixing not running index.js tests

I wonder if the better fix might be to rename store/index.js to store/index.ts. It's the only one that's not TypeScript

subtle-byte

comment created time in a month

pull request commentsveltejs/svelte

make it possible to render svelte-components inside a shadow dom

@tieoneease this PR does not touch the customElement functionality. The PR is meant to render a "normal" svelte component inside a shadow dom without using custom-elements and its restrictions.

ivanhofer

comment created time in a month

pull request commentsveltejs/svelte

make it possible to render svelte-components inside a shadow dom

Quick question: if we are exporting the whole component as a web component (not mounting the app as a Svelte app), this branch wouldn't work for us, right? At least the documented Usage section.

ivanhofer

comment created time in a month

issue commentsveltejs/svelte

css property value unexpectedly modified

Indeed it has nothing to do with Svelte sorry about that. Thank you very much for your help, it is really appreciated !

mgrisole

comment created time in a month

pull request commentsveltejs/svelte

fix: allow writable/readable empty initialization

Thanks 👍

ignatiusmb

comment created time in a month

push eventsveltejs/svelte

Ignatius Bagus

commit sha b295d68ec696a00e4d52cc7f86fed149b13062d2

fix types: allow writable/readable empty initialization (#6293) Fixes #6291 Fixes #6345 Both writable and readable initialized without any arguments are already valid, but TS complains about it. This makes both allowed to be emptily initialized. It's also possible to invoke readable with one argument only.

view details

push time in a month

PR merged sveltejs/svelte

fix: allow writable/readable empty initialization

Fixes #6291 Fixes #6345

Both writable and readable initialized without any arguments are already valid, but TS complains about it. This makes both allowed to be emptily initialized. A special exception to readable, although it's valid to use empty initialization (not sure why anyone would do this), when the first argument is passed, the callback is required to be defined as well (according to the docs).

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] This message body should clearly illustrate what problems it solves.
+49 -8

5 comments

4 changed files

ignatiusmb

pr closed time in a month

issue closedsveltejs/svelte

Typescript: Second argument to readable should be optional

Describe the bug I think creating a store without a start/stop notifier is totally valid for some special use cases (e.g. SSR friendly).

I write a lot of things like this in my SvelteKit(svelte@3.38.2) app to make Typescript checker happy:

function noop() {}

export const useMedia = (query: string) => {
  if(!browser) {
    return readable(false, noop); // 1
  }
  // Do something real here
}

export const useWindowSize = ({initialWidth = Infinity, initialHeight = Infinity}) => {
  if(!browser) {
    return {
      width: readable(initialWidth, noop), // 2
      height: readable(initialHeight, noop), // 3
    }; 
  }
  // Do something real here
}

Expected behavior store = readable(neverChangedValue) etc should be accepted by TypeScript.

Sorry for my bad English

closed time in a month

langbamit

issue closedsveltejs/svelte

First argument to writable/readable should be optional

Describe the bug It's totally valid to create a store without an initial value, but TypeScript complains:

image

Expected behavior store = writable() etc should be accepted by TypeScript. I guess value: T here just needs to be value?: T (and similarly for readable)?

https://github.com/sveltejs/svelte/blob/086cff22721f9589981ba9f6ec0bedc861e25623/src/runtime/store/index.ts#L64

Information about your Svelte project: It's a SvelteKit project using svelte@3.37.0

Severity Minor — easily worked around with writable(undefined)

closed time in a month

Rich-Harris