profile
viewpoint

backstopmedia/bleeding-edge-sample-app 674

A sample app for a Bleeding Edge Press book.

brigand/babel-plugin-flow-react-proptypes 437

A babel plugin to generate React PropTypes definitions from Flow type declarations.

brigand/babel-plugin-handbook 65

How to create Babel plugins

bleeding-edge-react-sample-app/bleeding-edge-react-sample-app.github.io 48

This is a sample application that goes along with the backstop media book: React Edge 2nd edition.

brigand/AutoHotkey-Quick-Help-XML 6

XML File for AutoHotkey Help

brigand/ahk-stdlib 3

Collection of AutoHotkey scripts inteneded to be made available for all users

brigand/ahkcmd 3

The power of AutoHotkey on the commandline

brigand/AhkDll-.NET 3

Work with AutoHotkey.dll with .NET

push eventbrigand/ballet

Frankie Bagnardi

commit sha 9242e6115cc0c93a300c8cfeaf2e3f42c286a225

feat: support SL,SC,SR,S1,S2,S3 for selecting target monitor (left, center, right). Also supports two monitors

view details

Frankie Bagnardi

commit sha 060edc63dd597a491925de90c2ffab0336e007d4

fix: screen selection bugs

view details

push time in 2 days

startedsunng87/cargo-release

started time in 10 days

starteddaboross/fern

started time in 10 days

push eventpictalk/landing-page

Frankie Bagnardi

commit sha c024062d9ee2e44463341ca6a392f7b2c1267f47

feat: list video ids in comment, switch to Fed Up

view details

push time in 19 days

PR merged entwicklerstube/babel-plugin-root-import

Update eslint plugin repo url

bingqichen/eslint-import-resolver-babel-plugin-root-import has been transfered to unconfident/eslint-import-resolver-babel-plugin-root-import

See issues#14 for details.

+1 -1

0 comment

1 changed file

KarinaLisp

pr closed time in 25 days

pull request commententwicklerstube/babel-plugin-root-import

Update eslint plugin repo url

Thanks!

KarinaLisp

comment created time in 25 days

push evententwicklerstube/babel-plugin-root-import

Karina

commit sha 7e3db322dd3c5eca23b2ec3620bef1dfb44af385

Update eslint plugin repo url

view details

Frankie Bagnardi

commit sha 53cb80b7f18db70555d2d67bc60741fa03d7cc42

Merge pull request #135 from KarinaLisp/patch-2 Update eslint plugin repo url

view details

push time in 25 days

push eventpictalk/landing-page

Frankie Bagnardi

commit sha 35ce150418897910129fbfb04ea3e488eae9d438

feat: remove pricing information panel from signup; update buttont text

view details

push time in a month

created tagbrigand/babel-plugin-flow-react-proptypes

tagv26.0.0

A babel plugin to generate React PropTypes definitions from Flow type declarations.

created time in a month

push eventbrigand/babel-plugin-flow-react-proptypes

Frankie Bagnardi

commit sha 67027b99cad045f894ff9995116750c4524a6120

26.0.0

view details

push time in a month

push eventbrigand/babel-plugin-flow-react-proptypes

Frankie Bagnardi

commit sha 790419a32f471bb5064f9e64ee9dc7251a501aef

adds @babel/node

view details

Frankie Bagnardi

commit sha 9637893eda0d5e9eb603bd86d2a14ab8ea04fd52

fix: use stringLiteral for object keys to

view details

Frankie Bagnardi

commit sha 0a6417a1cf9167847cbbc1bcd752daf93fb6f775

chore: update deps

view details

Frankie Bagnardi

commit sha 850d3ffc2e33523d6888a4f1cf37211ecd71f5a6

test: update snapshots

view details

Frankie Bagnardi

commit sha ed54f7b650ffcdd470e8fbe4a2ce06a693b9ac6f

Merge pull request #226 from brigand/fb/quoted-keys

view details

push time in a month

delete branch brigand/babel-plugin-flow-react-proptypes

delete branch : fb/quoted-keys

delete time in a month

PR merged brigand/babel-plugin-flow-react-proptypes

Quoted Keys

This resolves the same issue as https://github.com/brigand/babel-plugin-flow-react-proptypes/pull/225 but in a more robust way, at the cost of slightly less clean output. All keys are now generated like { "foo": PropTypes.string }, which also solves for non-identifier keys like { "data-foo": PropTypes.string }.

Also dependencies are updated in yarn.lock, and all snapshots have changed a little.

cc @baconcheese113

+4494 -4025

1 comment

139 changed files

brigand

pr closed time in a month

PR closed brigand/babel-plugin-flow-react-proptypes

Remove extra quotes for StringLiterals

Addresses the issue brought up here https://github.com/brigand/babel-plugin-flow-react-proptypes/issues/219

Currently extra quotes are added to StringLiteral props, commonly data-cy and aria-label.

Example component

// @flow
import * as React from 'react';
import ReactDOM from 'react-dom';

type Props = {|
	'data-cy': string,
|};
function MyComponent(props: Props) {
	const { 'data-cy': dataCy } = props;
	return <div data-cy={dataCy}>hello</div>;
}

const root = document.getElementById('react-root');
if (!root) throw new Error('Could not find react dom root');
ReactDOM.render(<MyComponent data-cy="aDataCyTest" />, root);

Currently, the above Props are transpiled into:

MyComponent.propTypes = {
  "\"data-cy\"": prop_types__WEBPACK_IMPORTED_MODULE_2___default.a.string.isRequired
};

This works as long as the place we use it passes in data-cy directly:

return <div data-cy={dataCy}>hello</div>;

However for a lot of common components, props are just passed through:

return <div {...props}>hello</div>;

And in this case since "data-cy" is passed in instead of data-cy we get an error in the console: image

The work around would be to just pass in each prop directly as mentioned above, but it's not really feasible when using a 3rd party lib and it's hacky when passing an object type and having to destructure off StringLiteral props so that they don't have extra quotes concatenated.

This PR just removes the extra quotes.

+2 -2

2 comments

2 changed files

baconcheese113

pr closed time in a month

pull request commentbrigand/babel-plugin-flow-react-proptypes

Remove extra quotes for StringLiterals

Thanks for the PR. This is definitely an issue, but as you can see from the updated snapshot test, it doesn't quite solve it (the following is a syntax error).

 var bpfrpt_proptype_T = {
-   \\"read-only\\": _propTypes.default.oneOf([true]).isRequired,
+  read-only: _propTypes.default.oneOf([true]).isRequired,

Interestingly, the issues only come up with newer minor versions of babel dependencies. It is a mistake on our part as we were incorrectly calling t.identifier('"foo"') instead of t.stringLiteral('foo') in some cases, and it seems babel now generates the code for that AST node differently.

Opened https://github.com/brigand/babel-plugin-flow-react-proptypes/pull/226 to hopefully resolve these issues, while also remaining backwards compatible with older babel versions.

baconcheese113

comment created time in a month

PR opened brigand/babel-plugin-flow-react-proptypes

Quoted Keys

This resolves the same issue as https://github.com/brigand/babel-plugin-flow-react-proptypes/pull/225 but in a more robust way, at the cost of slightly less clean output. All keys are now generated like { "foo": PropTypes.string }, which also solves for non-identifier keys like { "data-foo": PropTypes.string }.

Also dependencies are updated in yarn.lock, and all snapshots have changed a little.

cc @baconcheese113

+4494 -4025

0 comment

139 changed files

pr created time in a month

create barnchbrigand/babel-plugin-flow-react-proptypes

branch : fb/quoted-keys

created branch time in a month

issue commentcouchbaselabs/couchbase-rs

Support multiple bucket open

I think my connection to the couchbase server is actually the problem here, and it's just a bug with error reporting.

I was running it with a port-forwarding layer between the client and couchbase server, and it's likely doing something weird to the connection. Even with separate processes I get "A generic / unknown error happened" when talking to that instance, but the code works fine with a local instance of couchbase.

Likely a user error on my part.

daschl

comment created time in a month

issue commentcouchbaselabs/couchbase-rs

Support multiple bucket open

I'm on the latest code from master, so maybe it's a separate issue with multiple clusters.

Using tokio=0.2, #[tokio::main], the latest stable compiler, brew install libcouchbase --head.

I unfortunately didn't commit the broken code, but this is the error from when I tried to connect to two clusters in one process.

thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: 1048', /Users/.../.cargo/git/checkouts/couchbase-rs-9bae2babc4d89f61/769b1dc/couchbase/src/io/lcb/mod.rs:86:20
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at 'attempt to subtract with overflow', /Users/.../.cargo/git/checkouts/couchbase-rs-9bae2babc4d89f61/769b1dc/couchbase/src/io/lcb/callbacks.rs:325:61
thread '[warn] event_base_loop: reentrant invocation.  Only one event_base_loop can run on each event_base at once.
tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Canceled', /Users/../.cargo/git/checkouts/couchbase-rs-9bae2babc4d89f61/769b1dc/couchbase/src/api/mod.rs:416:9
daschl

comment created time in a month

issue commentcouchbaselabs/couchbase-rs

Support multiple bucket open

I'm dealing with this issue currently. I guess the workaround is to spawn multiple processes. My use case is connecting to two clusters, and one bucket in each.

daschl

comment created time in a month

fork brigand/http-aws-es

Use the elasticsearch-js client with Amazon ES

https://www.npmjs.com/package/http-aws-es

fork in 2 months

startedtannerlinsley/react-query

started time in 3 months

pull request commentynqa/kubernetes-rust

async/await, 2018 edition, updated deps

I've learned that more work is needed to properly support the newer version of k8s-openapi.

Properly making the request is more like the following, where the tuple argument is returned by the k8s-openapi functions. This has the benefit of encoding the request/response types in one function call, rather than manually specifying the expected response type.

use tokio::stream::StreamExt;
use k8s_openapi as kapi;

// ...snip

    pub async fn request<T>(
        &self,
        request: (
            http::Request<Vec<u8>>,
            fn(_: http::StatusCode) -> kapi::ResponseBody<T>,
        ),
    ) -> Result<T>
    where
        T: kapi::Response,
    {
        let (parts, body) = request.0.into_parts();
        let uri_str = format!("{}{}", self.host, parts.uri);
        let mut req = match parts.method {
            http::Method::GET => self.client.get(&uri_str),
            http::Method::POST => self.client.post(&uri_str),
            http::Method::DELETE => self.client.delete(&uri_str),
            http::Method::PUT => self.client.put(&uri_str),
            method => {
                bail!(other(format!("Unexpected HTTP method {:?}", method)));
            }
        };

        let res = req.body(body).send().await?;
        let mut k8s_res = request.1(res.status());

        let mut stream = res.bytes_stream();

        while let Some(item) = stream.next().await {
            if let Ok(item) = item {
                k8s_res.append_slice(item.as_ref());
            }
        }

        let result = k8s_res.parse()?;

        Ok(result)
    }

Currently the PR probably shouldn't be merged.

brigand

comment created time in 3 months

push eventbrigand/ddir

Frankie Bagnardi

commit sha b15612d3fb6361f106c89047a55506d79349b51d

chore: rename test dir

view details

Frankie Bagnardi

commit sha 588f7d56600c32167f8fb009b87823d06302e143

chore: exclude sample dir from cargo

view details

Frankie Bagnardi

commit sha 8a854e1eb3a3202e4fa2dbf6a1d717159359cc04

chore: add homepage/repo

view details

push time in 3 months

create barnchbrigand/ddir

branch : master

created branch time in 3 months

created repositorybrigand/ddir

created time in 3 months

more