profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/bnookala/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Bhargav Nookala bnookala Microsoft San Francisco, CA

Azure/vscode-kubernetes-tools 386

Kubernetes extension for Visual Studio Code

bnookala/candle 2

Control chrome remotely

Azure-Samples/frontdoor-appservice-vnet-terraform 1

Provides terraform scripts to deploy Frontdoor in a Virtual Network with Global WAF, Backend Pools with predefined Voting App, Routing Rules and Caching

bnookala/bdots 1

An attempt at dotfiles

bnookala/BotBuilder-Samples 1

Welcome to the BotBuilder samples repository. Here you will find task-focused samples in C# and Node.js to help you get started with the Bot Builder SDK!

bnookala/acs-engine 0

Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.

Pull request review commentAzure/azure-sdk-for-net

Tracing batch fix

 public bool TryAddMessage(ServiceBusMessage message)             lock (_syncGuard)             {                 AssertNotLocked();-                return InnerBatch.TryAddMessage(message);++                _scopeFactory.InstrumentMessage(message);

So my understanding is that we either risk letting the batch get too large, or we ignore the changes a user makes to a message after they have added to the batch. I would prefer the former because if the batch gets too large, the user will be made aware of it via exception, whereas in the latter, they may not realize that the data they are setting is being ignored.

JoshLove-msft

comment created time in 5 hours

Pull request review commentAzure/azure-sdk-for-net

Tracing batch fix

 public bool TryAddMessage(ServiceBusMessage message)             lock (_syncGuard)             {                 AssertNotLocked();-                return InnerBatch.TryAddMessage(message);++                _scopeFactory.InstrumentMessage(message);

Ideally, we would be serializing to AMQP here and not cloning the event/message model, but we ran into issues with the AMQP library when retrying using that approach. #9569 tracks revisiting this and, hopefully, avoiding the need for paying the serialization cost twice.

JoshLove-msft

comment created time in 7 hours

Pull request review commentAzure/azure-sdk-for-net

Tracing batch fix

 public bool TryAddMessage(ServiceBusMessage message)             lock (_syncGuard)             {                 AssertNotLocked();-                return InnerBatch.TryAddMessage(message);++                _scopeFactory.InstrumentMessage(message);

With this approach, the batch can be manipulated and the size exceeded.

Event Hubs clones the message as a defensive measure to prevent changes after the measurement was done. The clone, not the original event, is stored in the batch because the caller holds a reference to the original and can modify it which invalidates the measurement. If the caller adds a message using TryAdd and then adds several user properties to the message, the size of the batch is now invalid and larger than was calculated.

JoshLove-msft

comment created time in 7 hours

push eventAzure/azure-sdk-for-net

Kamil Sobol

commit sha 91f2566acf60957b0eca0b22beaca2d8a93511d1

Update CHANGELOG.md (#19080) * Update CHANGELOG.md * Update CHANGELOG.md

view details

push time in 7 hours

delete branch Azure/azure-sdk-for-net

delete branch : kasobol-msft-patch-1

delete time in 7 hours

PR merged Azure/azure-sdk-for-net

Reviewers
Update CHANGELOG.md Storage auto-merge
+1 -1

2 comments

1 changed file

kasobol-msft

pr closed time in 7 hours

push eventAzure/azure-sdk-for-net

Azure SDK Bot

commit sha d6cd1b8b357146331045e1bf335875eee79c9e76

Increment version for objectanchors releases (#19081) Increment package version after release of Azure.MixedReality.ObjectAnchors.Conversion

view details

push time in 7 hours

PR merged Azure/azure-sdk-for-net

Reviewers
Increment version for objectanchors releases auto-merge

Increment package version after release of Azure.MixedReality.ObjectAnchors.Conversion

+4 -1

1 comment

2 changed files

azure-sdk

pr closed time in 7 hours

pull request commentAzure/azure-sdk-for-net

Update CHANGELOG.md

/check-enforcer override

kasobol-msft

comment created time in 7 hours

issue commentAzure/azure-sdk-for-net

Ability to express user-assigned managed identity in IConfiguration

Thank you for your feedback. Tagging and routing to the team member best able to assist.

mattchenderson

comment created time in 7 hours

issue commentAzure/azure-sdk-for-net

Query resource group via blob URI?

Thank you for your feedback. Tagging and routing to the team member best able to assist.

kirk-marple

comment created time in 7 hours

issue commentAzure/azure-sdk-for-net

[BUG] BlobClient.Uri.AbsoluteUri returns escaped path causing wrong file names

Just caught us too. We moved over to the new storage library and the Absolute path and URI are now only partially encoded (e.g. https://<storage account>.blob.core.windows.net/storage-default/new-folder-test**%2F**test-img.jpg). Total change from the old library and causes production problems for us as well. Totally unexpected. If this is by design it needs to be thought through again. Think before you break assumptions people clearly have had and are expecting.

fabich

comment created time in 13 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

+// Copyright (c) Microsoft Corporation. All rights reserved.+// Licensed under the MIT License.++using System;+using System.Net;+using System.Threading.Tasks;+using Azure.Iot.TimeSeriesInsights.Models;+using FluentAssertions;+using NUnit.Framework;++namespace Azure.Iot.TimeSeriesInsights.Tests+{+    public class ModelSettingsTests : E2eTestBase+    {+        public ModelSettingsTests(bool isAsync)+            : base(isAsync)+        {+        }++        [Test]+        public async Task TimeSeriesInsightsClient_ModelSettingsTest()+        {+            TimeSeriesInsightsClient client = GetClient();++            // GET model settings+            Response<TimeSeriesModelSettings> currentSettings = await client.GetModelSettingsAsync().ConfigureAwait(false);+            currentSettings.GetRawResponse().Status.Should().Be((int)HttpStatusCode.OK);+            string testName = "testModel";++            // UPDATE model settings+            Response<TimeSeriesModelSettings> updatedSettingsName = await client.UpdateModelSettingsNameAsync(testName);+            updatedSettingsName.GetRawResponse().Status.Should().Be((int)HttpStatusCode.OK);+            updatedSettingsName.Value.Name.Should().Be(testName);+            // To do: Add a test for updating default Type Id. Need existing Model type to update with associated type Id.

Can you please add a Task so we won't lose track of it?

bikamani

comment created time in 15 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 public virtual async Task<Response<TimeSeriesModelSettings>> UpdateModelSettings         }          /// <summary>-        /// Updates model name or default type Id on Time Series model settings synchronously.+        /// Updates model default type Id on Time Series model settings asynchronously.         /// </summary>-        /// <param name="options">Model settings update request body.</param>+        /// <param name="defaultTypeId">Default type id of the model that new instances will automatically belong to.</param>         /// <param name="cancellationToken">The cancellation token.</param>         /// <returns>The updated model settings with the http response <see cref="Response{TimeSeriesModelSettings}"/>.</returns>-        /// <exception cref="ArgumentNullException"> <paramref name="options"/> is null. </exception>-        public virtual Response<TimeSeriesModelSettings> UpdateModelSettings(UpdateModelSettingsOptions options, CancellationToken cancellationToken = default)+        public virtual async Task<Response<TimeSeriesModelSettings>> UpdateModelSettingsDefaultTypeIdAsync(string defaultTypeId, CancellationToken cancellationToken = default)         {-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(TimeSeriesInsightsClient)}.{nameof(UpdateModelSettings)}");+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(TimeSeriesInsightsClient)}.{nameof(UpdateModelSettingsDefaultTypeId)}");             scope.Start();             try             {                 // To do: Generate client session Id-                Argument.AssertNotNull(options, nameof(options));+                var options = new UpdateModelSettingsRequest { DefaultTypeId = defaultTypeId };

Assert for defaultTypeId notnullorempty

bikamani

comment created time in 15 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 public virtual async Task<Response<TimeSeriesModelSettings>> UpdateModelSettings         }          /// <summary>-        /// Updates model name or default type Id on Time Series model settings synchronously.+        /// Updates model default type Id on Time Series model settings asynchronously.         /// </summary>-        /// <param name="options">Model settings update request body.</param>+        /// <param name="defaultTypeId">Default type id of the model that new instances will automatically belong to.</param>

Id

bikamani

comment created time in 16 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 public virtual Response<TimeSeriesModelSettings> GetModelSettings(CancellationTo         }          /// <summary>-        /// Updates model name or default type Id on Time Series model settings asynchronously.+        /// Updates model name on Time Series model settings asynchronously.         /// </summary>-        /// <param name="options">Model settings update request body.</param>+        /// <param name="name">Model display name which is shown in the UX and mutable by the user. Initial value is &quot;DefaultModel&quot;.</param>         /// <param name="cancellationToken">The cancellation token.</param>         /// <returns>The updated model settings with the http response <see cref="Response{TimeSeriesModelSettings}"/>.</returns>-        /// <exception cref="ArgumentNullException"> <paramref name="options"/> is null. </exception>-        public virtual async Task<Response<TimeSeriesModelSettings>> UpdateModelSettingsAsync(UpdateModelSettingsOptions options, CancellationToken cancellationToken = default)+        public virtual async Task<Response<TimeSeriesModelSettings>> UpdateModelSettingsNameAsync(string name, CancellationToken cancellationToken = default)         {-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(TimeSeriesInsightsClient)}.{nameof(UpdateModelSettings)}");+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(TimeSeriesInsightsClient)}.{nameof(UpdateModelSettingsName)}");             scope.Start();             try             {                 // To do: Generate client session Id-                Argument.AssertNotNull(options, nameof(options));

Maybe keep the assertNotNullOrEmpty for the name parameter

bikamani

comment created time in 16 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 public virtual Response<TimeSeriesModelSettings> GetModelSettings(CancellationTo         }          /// <summary>-        /// Updates model name or default type Id on Time Series model settings asynchronously.+        /// Updates model name on Time Series model settings asynchronously.         /// </summary>-        /// <param name="options">Model settings update request body.</param>+        /// <param name="name">Model display name which is shown in the UX and mutable by the user. Initial value is &quot;DefaultModel&quot;.</param>

I wouldn't mention UX here as this API might not even be used by UX.

bikamani

comment created time in 16 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

  #nullable disable -namespace Azure.Iot.TimeSeriesInsights+namespace Azure.Iot.TimeSeriesInsights.Models

Same as other comment for the '.Models'

bikamani

comment created time in 16 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 using System.Text.Json; using Azure.Core; -namespace Azure.Iot.TimeSeriesInsights+namespace Azure.Iot.TimeSeriesInsights.Models

In ADT, we decided that even models should belong to the same namespace as the core implementation. So we'll probably need to follow the same pattern here.

bikamani

comment created time in 16 hours

Pull request review commentAzure/azure-sdk-for-net

[TSI] Update model settings API changes and e2e tests

 public async Task RunSamplesAsync()                  #region Snippet:TimeSeriesInsightsUpdateModelSettings

You might want to update the snippet to by more explicit that it's updating model settings by name.

bikamani

comment created time in 16 hours

issue commentAzure/azure-powershell

Feature Request: -Refresh parameter for Get-AzAccessToken

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

JustinGrote

comment created time in 16 hours

issue closedAzure/azure-sdk-for-net

[FEATURE REQ] CreateOrUpdate method for Custom Roles

https://docs.microsoft.com/en-us/azure/role-based-access-control/custom-roles-rest

closed time in 16 hours

countchivas

push eventAzure/azure-sdk-for-net

m-nash

commit sha 941df0c5a0819b9bf10731c11e08fc0328be4123

initial checkin for core / tests (#18968) * initial checkin for core / tests * Add readme.md file * Fix header in readme * remove autorest until we convert off hand written types * update azure.core reference remove sets to tags ignore tests which require credentials for now * Add the proto client which will be used until the autogen work is complete * Add missing readmes for proto client * update to require linq 4.0.0 so that don't have to upgrade bcl * add changlog for CI * change system.linq.async to update * update to use source vs binary for the temporary generation of Azure.ResourceManager.Authorization * Add changelog for azure.resourcemanager.authorization and update version to be beta * update typos in readme * update name of proto client sln * merge in changes from proto repo this week * fixed unit test failures missed a few files from the merge from proto repo updated compute and network sdk version to use latest azure.core with readonly list types * ignore tests which require live azure until 5122 is closed * Update failing scenario test

view details

push time in 17 hours

PR merged Azure/azure-sdk-for-net

Reviewers
initial checkin for core / tests

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • [x] Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • [x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [x] I have read the contribution guidelines.
  • [x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • [x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • [ ] Include updated management metadata.
  • [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly. Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

+20443 -0

6 comments

230 changed files

m-nash

pr closed time in 17 hours

PR opened Azure/azure-sdk-for-net

Meet swagger20201201

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • [ ] Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • [ ] I have read the contribution guidelines.
  • [ ] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • [ ] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • [ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • [ ] Include updated management metadata.
  • [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
  • If the check fails at the Verify Code Generation step, please ensure:
    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly. Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup

Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

+451 -87

0 comment

28 changed files

pr created time in 20 hours

PR opened Azure/azure-powershell

Update appveyor.yml

<!-- DO NOT DELETE THIS TEMPLATE -->

Description

<!-- Please add a brief description of the changes made in this PR -->

Checklist

  • [ ] I have read the Submitting Changes section of CONTRIBUTING.md
  • [ ] The title of the PR is clear and informative
  • [ ] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [ ] The PR does not introduce breaking changes
  • [ ] If applicable, the changes made in the PR have proper test coverage
  • [ ] For public API changes to cmdlets:
    • [ ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • [ ] the markdown help files have been regenerated using the commands listed here
+1 -1

0 comment

1 changed file

pr created time in 21 hours

create barnchAzure/azure-powershell

branch : yishengjin1413-patch-1

created branch time in 21 hours

delete branch Azure/azure-sdk-for-net

delete branch : sync-eng/common-UpdatePrepareRelease-1447-ForTestPipeline

delete time in 21 hours

push eventAzure/azure-sdk-for-net

Azure SDK Bot

commit sha 5b18b362030d93ed27fd3e2b887875bf367ff1b7

Update Prepare-Release script (#19083) - Remove BuildType parameter as we can default it from package properties - Stop passing BuildType and GroupId and instead defaul them from package properties - Enable StrictMode to help identify potential errors - Start passing sdktype and isnewsdk properties to devops script - Sync latest changes with devops work item to fix a couple bugs

view details

push time in 21 hours