profile
viewpoint
Bhargav Nookala bnookala Microsoft San Francisco, CA

Azure/vscode-kubernetes-tools 348

Kubernetes extension for Visual Studio Code

bnookala/candle 2

Control chrome remotely

bnookala/bdots 1

An attempt at dotfiles

bnookala/BotBuilder-Samples 1

Welcome to the BotBuilder samples repository. Here you will find task-focused samples in C# and Node.js to help you get started with the Bot Builder SDK!

bnookala/acs-engine 0

Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.

issue commentAzure/vscode-kubernetes-tools

Open dashboard not working for AKS 1.4+

But we're getting enough reports that not all our users can be mistaken about whether they have an AKS cluster. Could it be that we're not detecting whether a cluster is AKS? We've seen some oddities in telemetry around AKS detection too (cc @squillace)..

yeah, I'm curious if the annotations that we select for to determine if the cluster is AKS has changed as well - this would be a good starting point.

dfgrosso

comment created time in a month

issue commentAzure/vscode-kubernetes-tools

Open dashboard not working for AKS 1.4+

@Tatsinnit @itowlson I think I had implemented it via kubectl port-forward because it's possible that the end user may not have the azure cli installed - it's only a required install for creating a cluster, and even then we don't do any installation work for the user there, so we can use az aks dashboard, presuming it's installed - and i think we can easily check the binary is available.

the other thing, the log lines i see in the issues above suggest that the active cluster is not an AKS cluster - the extension shouldn't be invoking tee see the implementation: https://github.com/Azure/vscode-kubernetes-tools/blob/29e59d593118e081cddd3559d9f16118ea378f01/src/components/kubectl/dashboard.ts#L125

dfgrosso

comment created time in a month

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in a month

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in a month

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 2 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 2 months

delete tag bnookala/gitops-manifests

delete tag : flux-write-check

delete time in 2 months

created tagbnookala/gitops-manifests

tagflux-write-check

created time in 2 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 2 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 2 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 2 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 2 months

delete tag bnookala/gitops-manifests

delete tag : flux-write-check

delete time in 2 months

created tagbnookala/gitops-manifests

tagflux-write-check

created time in 2 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 2 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 2 months

issue openedmicrosoft/bedrock-cli

script to add hld update stage to existing pipelines yaml

As a:

bedrock user, but not necessarily a bedrock cli user

I want:

To be able to invoke a script to add an "hld-update" stage to existing pipelines yaml files.

So that:

I can bring my own custom build pipeline that produces a docker image pushed to a registry that I can use to update my HLD

Describe the solution you'd like:

  • A tool or script that accepts a path to an azure yaml file as a parameter that simply injects a stage to the pipelines yaml that updates a bedrock HLD repository with an image tag for a newly build service.

Acceptance Criteria:

  • [ ] Any such tool or script must be able to take an azure pipelines yaml file and inject a default build stage into it that will update an HLD repository. This "default" build stage does not need to be valid - and any number of warnings to let the user know of this should suffice.

The steps following are the hld update stage verbatim from fileutilts.ts in bedrock-cli:

                  `export SERVICE_NAME_LOWER=$(echo ${serviceName} | tr '[:upper:]' '[:lower:]')`,
                  `export BUILD_REPO_NAME=${BUILD_REPO_NAME(serviceName)}`,
                  `export BRANCH_NAME=DEPLOY/$BUILD_REPO_NAME-${IMAGE_TAG}`,
                  `export FAB_SAFE_SERVICE_NAME=$(echo $SERVICE_NAME_LOWER | tr . - | tr / -)`,
                  `# --- From https://raw.githubusercontent.com/Microsoft/bedrock/master/gitops/azure-devops/release.sh`,
                  `. build.sh --source-only`,
                  ``,
                  `# Initialization`,
                  `verify_access_token`,
                  `init`,
                  `helm_init`,
                  ``,
                  `# Fabrikate`,
                  `get_fab_version`,
                  `download_fab`,
                  ``,
                  `# Clone HLD repo`,
                  `git_connect`,
                  `# --- End Script`,
                  ``,
                  `# Update HLD`,
                  `git checkout -b "$BRANCH_NAME"`,
                  `export BUILD_REPO_NAME=${BUILD_REPO_NAME(serviceName)}`,
                  `export IMAGE_TAG=${IMAGE_TAG}`,
                  `export IMAGE_NAME=$BUILD_REPO_NAME:$IMAGE_TAG`,
                  `echo "Image Name: $IMAGE_NAME"`,
                  `export IMAGE_REPO=${IMAGE_REPO}`,
                  `echo "Image Repository: $IMAGE_REPO"`,
                  `cd $(Build.Repository.Name)/$FAB_SAFE_SERVICE_NAME/${SAFE_SOURCE_BRANCH}`,
                  `echo "FAB SET"`,
                  `fab set --subcomponent chart image.tag=$IMAGE_TAG image.repository=$IMAGE_REPO/$BUILD_REPO_NAME`,
                  ``,

Assuming any such build stage downloads the build.sh script that provides a number of the functions invoked above, the remaining assumption left is that any pipeline that has the build pipeline stage injected offers a number of pipeline variables for the stage to be able to invoked properly. This should be made explicit to the end user, as pipelines will differ from project to project.

Describe alternatives you've considered:

  • We've considered building custom build steps directly into spk, but decided against that solution as it can become complicated, and does not

Additional context:

  • Out of band request for tooling

Does this require updates to documentation?:

no

created time in 2 months

push eventmicrosoft/bedrock-cli

Edaena Salinas

commit sha 7bb9d5ec76f36562e9d929df231bf788190f7442

Add unit test for install build pipeline (#40) * Add unit test for install build pipeline * Remove unused import * Remove test spy Co-authored-by: Edaena Salinas <edaena@Edaenas-MBP.hsd1.ca.comcast.net>

view details

Yvonne Radsmikham

commit sha 5d9b0a4cc3f183535108117a674b1f18058792f7

Rename columns in CLI table (#42) * rename columns in CLI table * udpate docs

view details

Andre Briggs

commit sha 632d8a234f96cd7dcd90f4b206c1cdf5588261fe

Release 0.6.5 (#43)

view details

Bhargav Nookala

commit sha 6c7741e32e696a1d69ba485aec139e71f5467e20

Adding inject pipeline script

view details

push time in 2 months

push eventbnookala/spk

Dennis Seah

commit sha fc5ecdd72dbb78987de4fae12ebe868cfbe6368b

[BUG--FIX] issue 32: setup command fails to get az cli version

view details

Dennis Seah

commit sha eefedbf27f631a509297a3c509f292d2816ddaaf

Merge pull request #33 from microsoft/issue32 [BUG--FIX] issue 32: setup command fails to get az cli version

view details

Samiya Akhtar

commit sha bc6b3ba2c8ffaa6a4ac201c1d3984dbdba2272e0

Adding docs for updating generated pipelines to a new version with bedrock-cli (#30) * Adding docs for updating generated pipeliens to a new version with bedrock * Add quick note about bedrock project append-variable-group

view details

Yvonne Radsmikham

commit sha f3612e0ebff341a43afce843164f16f574682acf

Resolve infra unit tests (#31)

view details

nrose

commit sha 126d90c21adf72a42d936505d8f03f96f3f608f6

quick update to docs

view details

Nate

commit sha f806aff4566ef2968274af1f58306149810db1bc

Merge pull request #37 from NathanielRose/nate.docs.debug Quick update to docs

view details

Edaena Salinas

commit sha 26fbd184e0448ecd5aea63a8ed6a9d05412ebecc

Use service path instead of service name

view details

Dennis Seah

commit sha ca1f98f45f8f80329949f4cbdb5955240b12302f

[BUG_FIX] issue 34 bedrock setup command failure for some az cli version (#35) Co-authored-by: Samiya Akhtar <samiyaakhtar7@gmail.com>

view details

Nate

commit sha f41fa51ef376c6bbaf83ffd16f25e735229ae1b2

Merge branch 'master' into edaena-svc-bug

view details

Edaena Salinas

commit sha 2250d74a7054d8fb78407e156b12cc2e72517109

Remove packages flag from integration tests

view details

Edaena Salinas

commit sha b7fae46f2d9fba33058b79cca4715310dc6f0ebd

Merge branch 'edaena-svc-bug' of github.com:microsoft/bedrock-cli into edaena-svc-bug

view details

Edaena Salinas

commit sha 6d30fc16095e3657f7ba10a1ce0f92a9d81111e1

Add error check

view details

Edaena Salinas

commit sha 3989c3a18aff684d1f6eaeff87927a8f744f6459

Merge pull request #39 from microsoft/edaena-svc-bug Extract service path for pipeline definition location instead of service name for service install-build-pipeline

view details

Edaena Salinas

commit sha 7bb9d5ec76f36562e9d929df231bf788190f7442

Add unit test for install build pipeline (#40) * Add unit test for install build pipeline * Remove unused import * Remove test spy Co-authored-by: Edaena Salinas <edaena@Edaenas-MBP.hsd1.ca.comcast.net>

view details

Yvonne Radsmikham

commit sha 5d9b0a4cc3f183535108117a674b1f18058792f7

Rename columns in CLI table (#42) * rename columns in CLI table * udpate docs

view details

Andre Briggs

commit sha 632d8a234f96cd7dcd90f4b206c1cdf5588261fe

Release 0.6.5 (#43)

view details

Bhargav Nookala

commit sha 6c7741e32e696a1d69ba485aec139e71f5467e20

Adding inject pipeline script

view details

push time in 2 months

PR opened microsoft/bedrock-cli

Reviewers
Adding inject hld update pipeline script
  • Adds a script that injects a hld update stage into any existing azure pipelines yaml
  • This pipeline yaml is not guaranteed to be correct - it may still need modifications to make work with any pre-existing pipelines.
  • Resolves https://github.com/microsoft/bedrock/issues/1362
+103 -0

0 comment

1 changed file

pr created time in 2 months

push eventmicrosoft/bedrock-cli

Bhargav Nookala

commit sha e0f887989994e6610783b1d0c55ed8f6757ace84

Adding inject pipeline script

view details

push time in 2 months

create barnchmicrosoft/bedrock-cli

branch : hld-update-script-1362

created branch time in 2 months

issue commentmicrosoft/bedrock

bedrock service install-build-pipeline is not validating the correct pipeline definition value

@mtarng happy to remove it if it's not being used

mtarng

comment created time in 2 months

create barnchbnookala/spk

branch : hld-update-script-1362

created branch time in 2 months

push eventbnookala/spk

Nate

commit sha 7ec34439bc961e1efc01445bfe27c219d80a66eb

Merge branch 'master' into nate.test.relative-paths

view details

Nate

commit sha e3f09898bd138d35078fa8f622a8ea9418081daa

Merge branch 'master' into nate.test.relative-paths

view details

Nate

commit sha 50cba1e66adcb3f9827d64d7d2930b1ef3d1fd3d

Merge branch 'master' into nate.test.relative-paths

view details

Dennis Seah

commit sha c736b95cea4876f55747e96eba72980f9f91133c

[BUG FIX] Variable group is created too late in spk setup command

view details

Dennis Seah

commit sha f01a8f6184a09b31de6b471a09340bf0de9fa1fc

Merge branch 'master' into issue1374

view details

Dennis Seah

commit sha 2b259a5d1b576f802ba679e7c697ecfe306c4f85

Update i18n.json

view details

Dennis Seah

commit sha b940810cc9d6f759ebd69cff05145deb4f577ed3

Merge branch 'master' into issue1374

view details

Edaena Salinas

commit sha cbcf1f66420237827160b75f360374682039d6c7

Removed unused variables

view details

Nate

commit sha b1928479a12d9dad0f53b697b2f358b615e84c4d

Merge branch 'master' into nate.test.relative-paths

view details

Dennis Seah

commit sha c6b500eb9581f64c4c07991c3696b3f1641ca2a8

Merge pull request #20 from microsoft/issue1374 [BUG FIX] Variable group is created too late in spk setup command

view details

Edaena Salinas

commit sha 5b093ca2f1631b1373d67afcbebd4f1859856f57

Fix config name

view details

Edaena Salinas

commit sha d6321e453a9e789d7709a6cff1e824321c8f5229

Add test for updating services pipeline yaml

view details

Edaena Salinas

commit sha 78fdcea5adbc22ce361c8148140b24ec61dd2d94

Fix incorrect command inheritance

view details

Edaena Salinas

commit sha de660d41404ff9e4db0497cc8d5ca0b9e3210cde

Removed unused values

view details

Edaena Salinas

commit sha cf41bc8645262cc5426b9db8855e14e04ae4cf0b

Fix function comments

view details

Edaena Salinas

commit sha 516db8dcc4ccab53c2b11bae2c508a63dac9e4da

Add test to append variable group

view details

Edaena Salinas

commit sha 63200f9a0a740db4dacc20b0435b9e99fd65aa71

Update unit tests

view details

Edaena Salinas

commit sha 51de1c5f726ac5b039b25a93e7e57cca61062d3b

Update unit tests

view details

Edaena Salinas

commit sha 05fd60732f2f70176370cdfd658bdf839ddb93ef

Add documentation

view details

Edaena Salinas

commit sha e1926e3b9a6ea7b3548102f20b836fb6e8bc3a8c

Change error messages

view details

push time in 2 months

delete branch microsoft/bedrock-cli

delete branch : spk-hld-init-1212

delete time in 2 months

push eventmicrosoft/bedrock-cli

Edaena Salinas

commit sha cbcf1f66420237827160b75f360374682039d6c7

Removed unused variables

view details

Edaena Salinas

commit sha 5b093ca2f1631b1373d67afcbebd4f1859856f57

Fix config name

view details

Edaena Salinas

commit sha d6321e453a9e789d7709a6cff1e824321c8f5229

Add test for updating services pipeline yaml

view details

Edaena Salinas

commit sha 78fdcea5adbc22ce361c8148140b24ec61dd2d94

Fix incorrect command inheritance

view details

Edaena Salinas

commit sha de660d41404ff9e4db0497cc8d5ca0b9e3210cde

Removed unused values

view details

Edaena Salinas

commit sha cf41bc8645262cc5426b9db8855e14e04ae4cf0b

Fix function comments

view details

Edaena Salinas

commit sha 516db8dcc4ccab53c2b11bae2c508a63dac9e4da

Add test to append variable group

view details

Edaena Salinas

commit sha 63200f9a0a740db4dacc20b0435b9e99fd65aa71

Update unit tests

view details

Edaena Salinas

commit sha 51de1c5f726ac5b039b25a93e7e57cca61062d3b

Update unit tests

view details

Edaena Salinas

commit sha 05fd60732f2f70176370cdfd658bdf839ddb93ef

Add documentation

view details

Edaena Salinas

commit sha e1926e3b9a6ea7b3548102f20b836fb6e8bc3a8c

Change error messages

view details

Edaena Salinas

commit sha 2a3248e4aaf7be33bdb4c8ab5b35f1ca5cca3c0b

Add missing error key

view details

Edaena Salinas

commit sha 8d247d555a4f5a0e3977a0fc5152adc65a80b24f

Simplify conditionals

view details

Edaena Salinas

commit sha e224bc09c5a3ffe543161f56499e70361e9516d3

Merge branch 'master' of github.com:microsoft/bedrock-cli into edaena-vg

view details

Edaena Salinas

commit sha 7580cc957912f3135cd1a359bae183e00cf57850

Merge pull request #23 from microsoft/edaena-vg spk should allow a project to use an existing variable group

view details

Andre Briggs

commit sha 502573cf431bddff8adbb9fe5e2115ee6e398154

Release 0.6.3 (#26) * Release 0.6.3

view details

Andre Briggs

commit sha 8a62d823705ae3ca24bc5223e0d108a63cd38949

Removing references to `spk` (#27) * Removing references to `spk` * Fixing links for markdown linting * Move artifact publish to end

view details

Andre Briggs

commit sha 71f09c1502c7324218d90cc01e01c351cade6bd5

MD lint issue

view details

Andre Briggs

commit sha 620fb9b79c2fa5461be90650d665110a8177b4a0

Version bump (#28) * Version bump * Update CHANGELOG.md

view details

Andre Briggs

commit sha adb188d908384e631f17128c83aff1c209355949

Renaming test config file

view details

push time in 2 months

push eventbnookala/spk

Bhargav Nookala

commit sha 254f7a823a3d0ae86d6a5786b6f3e2059cf12c0e

Tests

view details

push time in 2 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 2 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 2 months

push eventbnookala/spk

Edaena Salinas

commit sha cbcf1f66420237827160b75f360374682039d6c7

Removed unused variables

view details

Edaena Salinas

commit sha 5b093ca2f1631b1373d67afcbebd4f1859856f57

Fix config name

view details

Edaena Salinas

commit sha d6321e453a9e789d7709a6cff1e824321c8f5229

Add test for updating services pipeline yaml

view details

Edaena Salinas

commit sha 78fdcea5adbc22ce361c8148140b24ec61dd2d94

Fix incorrect command inheritance

view details

Edaena Salinas

commit sha de660d41404ff9e4db0497cc8d5ca0b9e3210cde

Removed unused values

view details

Edaena Salinas

commit sha cf41bc8645262cc5426b9db8855e14e04ae4cf0b

Fix function comments

view details

Edaena Salinas

commit sha 516db8dcc4ccab53c2b11bae2c508a63dac9e4da

Add test to append variable group

view details

Edaena Salinas

commit sha 63200f9a0a740db4dacc20b0435b9e99fd65aa71

Update unit tests

view details

Edaena Salinas

commit sha 51de1c5f726ac5b039b25a93e7e57cca61062d3b

Update unit tests

view details

Edaena Salinas

commit sha 05fd60732f2f70176370cdfd658bdf839ddb93ef

Add documentation

view details

Edaena Salinas

commit sha e1926e3b9a6ea7b3548102f20b836fb6e8bc3a8c

Change error messages

view details

Edaena Salinas

commit sha 2a3248e4aaf7be33bdb4c8ab5b35f1ca5cca3c0b

Add missing error key

view details

Edaena Salinas

commit sha 8d247d555a4f5a0e3977a0fc5152adc65a80b24f

Simplify conditionals

view details

Edaena Salinas

commit sha e224bc09c5a3ffe543161f56499e70361e9516d3

Merge branch 'master' of github.com:microsoft/bedrock-cli into edaena-vg

view details

Edaena Salinas

commit sha 7580cc957912f3135cd1a359bae183e00cf57850

Merge pull request #23 from microsoft/edaena-vg spk should allow a project to use an existing variable group

view details

Andre Briggs

commit sha 502573cf431bddff8adbb9fe5e2115ee6e398154

Release 0.6.3 (#26) * Release 0.6.3

view details

Andre Briggs

commit sha 8a62d823705ae3ca24bc5223e0d108a63cd38949

Removing references to `spk` (#27) * Removing references to `spk` * Fixing links for markdown linting * Move artifact publish to end

view details

Andre Briggs

commit sha 71f09c1502c7324218d90cc01e01c351cade6bd5

MD lint issue

view details

Andre Briggs

commit sha 620fb9b79c2fa5461be90650d665110a8177b4a0

Version bump (#28) * Version bump * Update CHANGELOG.md

view details

Andre Briggs

commit sha adb188d908384e631f17128c83aff1c209355949

Renaming test config file

view details

push time in 2 months

PR opened microsoft/bedrock-cli

Reviewers
Check if HLD repository is empty, error and show a nice message if it is.
  • Closes https://github.com/microsoft/bedrock/issues/1212
  • tests
+46 -0

0 comment

3 changed files

pr created time in 3 months

create barnchmicrosoft/bedrock-cli

branch : spk-hld-init-1212

created branch time in 3 months

push eventbnookala/spk

Yvonne Radsmikham

commit sha 1147142ac7c550165665f1f2c3820849bbda9554

build args

view details

Yvonne Radsmikham

commit sha 42394efbbe7a569267ff3c8e126b2be002737329

resolved unit testing

view details

Yvonne Radsmikham

commit sha 2131e0a870099a8a26a22e4e76713a1c48745691

added conditionals

view details

Yvonne Radsmikham

commit sha 510e1ae5fa7530f80d104a7d4f1ec9da17ed38ef

update script

view details

Yvonne Radsmikham

commit sha 6e582305eaacb8750524f21c809946f65d36e779

add echo statements

view details

Yvonne Radsmikham

commit sha e114f1d5fd6c4e7296788b7d46e26e01819cf666

add logging

view details

Yvonne Radsmikham

commit sha 0c3899bc2a55622ca7ce0e31980dffc8ecf3f834

add quotes

view details

Yvonne Radsmikham

commit sha 29a04e89bbfe240502b5d9a33ce1b0cfa50d2d11

switch order

view details

Yvonne Radsmikham

commit sha b43a6506f8e90eed611fd2f07d0b153811f1a548

remove quotes

view details

Yvonne Radsmikham

commit sha 8fa3ad2ea3ea5c9a61b827b920c8011ed861ab2a

clean up, and updated smoke tests for validation

view details

Yvonne Radsmikham

commit sha 44fe956770b9501b5c35b321615357f5726743a0

add echo statements

view details

Yvonne Radsmikham

commit sha a1d7ce917ae933ee8541b315acaa7d01d4fd5e7e

correct env vars

view details

Yvonne Radsmikham

commit sha cc4bcf9d32683225e9846e7a424b4970ff4260d3

resolved variable in vg

view details

nrose

commit sha 2cbe8763bc12c2722cd8108566eb4a19cfe85802

update int tests for infra local paths

view details

Yvonne Radsmikham

commit sha 257e133d54e14454185295405390b98052417bc2

refinement

view details

Yvonne Radsmikham

commit sha e3223b47a2ad9ea0d278323b733ed9e19154a24f

small edits

view details

Yvonne Radsmikham

commit sha eb48dff0c7c695b5a3241df54b4eaf350743652a

updated documentation, and smoke tests

view details

Yvonne Radsmikham

commit sha d134ac062d7197426a8e1d13e74c8b8627f9604d

added validation in smoke tests

view details

Yvonne Radsmikham

commit sha a94319e48c2d8a1bc2d16d6912dea11a3388036c

validation for bedrock.yaml in smoke tests

view details

Yvonne Radsmikham

commit sha 4194aaff7de749b37d7f80eb088160e690c0664e

add variable format warning

view details

push time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

push eventbnookala/spk

Yvonne Radsmikham

commit sha 1147142ac7c550165665f1f2c3820849bbda9554

build args

view details

Yvonne Radsmikham

commit sha 42394efbbe7a569267ff3c8e126b2be002737329

resolved unit testing

view details

Yvonne Radsmikham

commit sha 2131e0a870099a8a26a22e4e76713a1c48745691

added conditionals

view details

Yvonne Radsmikham

commit sha 510e1ae5fa7530f80d104a7d4f1ec9da17ed38ef

update script

view details

Yvonne Radsmikham

commit sha 6e582305eaacb8750524f21c809946f65d36e779

add echo statements

view details

Yvonne Radsmikham

commit sha e114f1d5fd6c4e7296788b7d46e26e01819cf666

add logging

view details

Yvonne Radsmikham

commit sha 0c3899bc2a55622ca7ce0e31980dffc8ecf3f834

add quotes

view details

Yvonne Radsmikham

commit sha 29a04e89bbfe240502b5d9a33ce1b0cfa50d2d11

switch order

view details

Yvonne Radsmikham

commit sha b43a6506f8e90eed611fd2f07d0b153811f1a548

remove quotes

view details

Yvonne Radsmikham

commit sha 8fa3ad2ea3ea5c9a61b827b920c8011ed861ab2a

clean up, and updated smoke tests for validation

view details

Yvonne Radsmikham

commit sha 44fe956770b9501b5c35b321615357f5726743a0

add echo statements

view details

Yvonne Radsmikham

commit sha a1d7ce917ae933ee8541b315acaa7d01d4fd5e7e

correct env vars

view details

Yvonne Radsmikham

commit sha cc4bcf9d32683225e9846e7a424b4970ff4260d3

resolved variable in vg

view details

nrose

commit sha 2cbe8763bc12c2722cd8108566eb4a19cfe85802

update int tests for infra local paths

view details

Yvonne Radsmikham

commit sha 257e133d54e14454185295405390b98052417bc2

refinement

view details

Yvonne Radsmikham

commit sha e3223b47a2ad9ea0d278323b733ed9e19154a24f

small edits

view details

Yvonne Radsmikham

commit sha eb48dff0c7c695b5a3241df54b4eaf350743652a

updated documentation, and smoke tests

view details

Yvonne Radsmikham

commit sha d134ac062d7197426a8e1d13e74c8b8627f9604d

added validation in smoke tests

view details

Yvonne Radsmikham

commit sha a94319e48c2d8a1bc2d16d6912dea11a3388036c

validation for bedrock.yaml in smoke tests

view details

Yvonne Radsmikham

commit sha 4194aaff7de749b37d7f80eb088160e690c0664e

add variable format warning

view details

push time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

delete branch microsoft/bedrock

delete branch : mtarng-patch-2

delete time in 3 months

push eventmicrosoft/bedrock

Michael Tarng

commit sha 4659854ec5427b1dce76745345cd0219126fe74c

Updating docs to reflect full path requirement for ssh key (#1370)

view details

push time in 3 months

PR merged microsoft/bedrock

Reviewers
Updating docs to reflect full path requirement for ssh key

Just ran through the example and ran into issues with the file path path.

+6 -1

0 comment

1 changed file

mtarng

pr closed time in 3 months

push eventmicrosoft/bedrock

Michael Tarng

commit sha caa5942fecffa3adf9c0de245fe1e0512297d70e

fixing broken links in docs (#1363)

view details

push time in 3 months

PR merged microsoft/bedrock

fixing broken links in docs
+6 -6

0 comment

2 changed files

mtarng

pr closed time in 3 months

issue commentmicrosoft/bedrock

Add SPK support for services with custom dockerfiles

Closing this issue to track the up-to-date feature request here: https://github.com/microsoft/bedrock/issues/1362

erikschlegel

comment created time in 3 months

push eventbnookala/folding-on-azure

Bhargav Nookala

commit sha bbda163f2fb2e15ef2d8ae76f4ba24452a9e4ee4

Azure WIP

view details

push time in 3 months

issue openedmicrosoft/bedrock

script to add hld update stage to existing pipelines yaml

As a:

bedrock-cli user

I want:

To be able to invoke a script to add an "hld-update" stage to existing pipelines yaml files.

So that:

I can bring my own custom build pipeline that produces a docker image pushed to a registry that I can use to update my HLD

Describe the solution you'd like:

  • A tool or script that accepts a path to an azure yaml file as a parameter that simply injects a stage to the pipelines yaml that updates a bedrock HLD repository with an image tag for a newly build service.

Acceptance Criteria:

  • [] Any such tool or script must be able to take an azure pipelines yaml file and inject a default build stage into it that will update an HLD repository. This "default" build stage does not need to be valid - and any number of warnings to let the user know of this should suffice.

The steps following are the hld update stage verbatim from fileutilts.ts in bedrock-cli:

                  `export SERVICE_NAME_LOWER=$(echo ${serviceName} | tr '[:upper:]' '[:lower:]')`,
                  `export BUILD_REPO_NAME=${BUILD_REPO_NAME(serviceName)}`,
                  `export BRANCH_NAME=DEPLOY/$BUILD_REPO_NAME-${IMAGE_TAG}`,
                  `export FAB_SAFE_SERVICE_NAME=$(echo $SERVICE_NAME_LOWER | tr . - | tr / -)`,
                  `# --- From https://raw.githubusercontent.com/Microsoft/bedrock/master/gitops/azure-devops/release.sh`,
                  `. build.sh --source-only`,
                  ``,
                  `# Initialization`,
                  `verify_access_token`,
                  `init`,
                  `helm_init`,
                  ``,
                  `# Fabrikate`,
                  `get_fab_version`,
                  `download_fab`,
                  ``,
                  `# Clone HLD repo`,
                  `git_connect`,
                  `# --- End Script`,
                  ``,
                  `# Update HLD`,
                  `git checkout -b "$BRANCH_NAME"`,
                  `export BUILD_REPO_NAME=${BUILD_REPO_NAME(serviceName)}`,
                  `export IMAGE_TAG=${IMAGE_TAG}`,
                  `export IMAGE_NAME=$BUILD_REPO_NAME:$IMAGE_TAG`,
                  `echo "Image Name: $IMAGE_NAME"`,
                  `export IMAGE_REPO=${IMAGE_REPO}`,
                  `echo "Image Repository: $IMAGE_REPO"`,
                  `cd $(Build.Repository.Name)/$FAB_SAFE_SERVICE_NAME/${SAFE_SOURCE_BRANCH}`,
                  `echo "FAB SET"`,
                  `fab set --subcomponent chart image.tag=$IMAGE_TAG image.repository=$IMAGE_REPO/$BUILD_REPO_NAME`,
                  ``,

Assuming any such build stage downloads the build.sh script that provides a number of the functions invoked above, the remaining assumption left is that any pipeline that has the build pipeline stage injected offers a number of pipeline variables for the stage to be able to invoked properly. This should be made explicit to the end user, as pipelines will differ from project to project.

Describe alternatives you've considered:

  • We've considered building custom build steps directly into spk, but decided against that solution as it can become complicated, and does not

Additional context:

  • Out of band request for tooling

Does this require updates to documentation?:

created time in 3 months

issue closedmicrosoft/bedrock

Add SPK support for services with custom dockerfiles

User Story for #1111

As a: Service Developer

I want: to leverage spk add new a service to a bedrock project using my own dockerfile

So that: I can deploy a spring boot application to kubernetes

Describe the solution you'd like: I'd like SPK to support bringing my own dockerfile when setting up a new service.The customer is deploying a set of spring boot microservices to AKS. Their existing dockerfile is shown below.

FROM openjdk:8-jdk-alpine
VOLUME /tmp
ARG JAR_FILE
COPY ${JAR_FILE} app.jar
ENTRYPOINT ["java","-jar","/app.jar"]

The JAR file referenced in the docker build argument will be pre-generated from an earlier pipeline. That JAR file will need to reside within the docker context. One approach is to allow the customer to own the docker image build and publish step?

Acceptance Criteria:

  • I can deploy one of the customer's spring boot microservice to AKS through SPK's service ADO pipeline.
  • I can succesfully build and publish a docker image using the earlier mentioned Dockerfile.

Does this require updates to documentation?: Not sure

closed time in 3 months

erikschlegel

create barnchbnookala/spk

branch : spk-hld-init-1212

created branch time in 3 months

push eventbnookala/spk

Edaena Salinas

commit sha ce232d9d402007ce87c0bb76b00d84c6fd9ff7fe

Verify build pipeline for ring

view details

Andre Briggs

commit sha eab4d8a4ddd2840aa23d5aed107e7672660d3223

Added missing doc

view details

Andre Briggs

commit sha c07ac2dc0f0530797fe7f1d4aeeb05655275b758

Forgot to add file somehow

view details

Andre Briggs

commit sha b2c11c26a8b29ab2033076c6ef1618010986d16a

Adding more logging

view details

Edaena Salinas

commit sha 8981c50269b16f252800cf829d83bf31c24c8476

Update functions

view details

Edaena Salinas

commit sha 97e5423871d88e7fa77e224bd49d5408d04ccce8

undo change to file

view details

Edaena Salinas

commit sha 812016dfce3ea54d47dc9fc6ced3b595a7d3f5c8

Merge branch 'master' of github.com:microsoft/bedrock-cli into edaena-int-ring

view details

Andre Briggs

commit sha 22088dc6c5903eccb63114aff1c8f502cb5b3765

Update create.md

view details

Dennis Seah

commit sha 5f305254ff3ead8ce2fe320b47ecafe6d01843a4

Merge branch 'master' into abrig-vg-create

view details

Samiya Akhtar

commit sha 12ba317240662ce89d43e93dfb673bac60458dde

Merge branch 'master' into edaena-int-ring

view details

Samiya Akhtar

commit sha a85e54f974f13971ec86e841b9167f075e2b50cd

Merge branch 'master' into edaena-int-ring

view details

Edaena Salinas

commit sha 93ccc142502a3ccd9813330cdaded12d51ff8cc7

Merge pull request #14 from microsoft/edaena-int-ring CLI integration tests don't validate pipeline runs for "rings"

view details

Andre Briggs

commit sha 266cb84ff472549ee4ceb34f3139e9221008cdd2

Merge branch 'master' into abrig-vg-create

view details

Dennis Seah

commit sha 93c7b2179fdaccbd3b401dcc3554cfa2e477b013

Update setup.test.ts

view details

andrebriggs@users.noreply.github.com

commit sha 5a3a359bb1484b5a3d72629b981a2df559543371

Removing `variable-group`

view details

Andre Briggs

commit sha f1dce90066fb3fc57c6a29a1692bbe785ba11a2d

Merge pull request #13 from microsoft/abrig-vg-create [HOUSEKEEPING] Removing variable-group create

view details

push time in 3 months

delete tag microsoft/fabrikate-production-cluster-demo-materialized

delete tag : flux-write-check

delete time in 3 months

created tagmicrosoft/fabrikate-production-cluster-demo-materialized

tagflux-write-check

Auto-generated materialized version of our sample cluster HLD: https://github.com/Microsoft/fabrikate-production-cluster-demo

created time in 3 months

push eventbnookala/spk

Dennis Seah

commit sha 549b2bde787fefe737612c6985d67c3023e08559

[FEATURE] auto approve PR for spk setup command

view details

Dennis Seah

commit sha c253252c3dca9179639df9f3d82ed1e474f5883c

Merge branch 'master' into autoApprovePr

view details

Samiya Akhtar

commit sha 7d56791f64a6be1a9cf0885291c61c2ebf80ce97

Handle the case where multiple PRs are present

view details

Samiya Akhtar

commit sha 9d0fe6acf9cc8805bfe96a6e9c8c8f2e318483b8

Remove log statement

view details

Dennis Seah

commit sha 1a6421f4420b5958585fd3c14bafff0117aa8fd4

Merge branch 'master' into autoApprovePr

view details

Dennis Seah

commit sha 0997c89f838eb02189ce954792c8ae8624977f0f

Merge branch 'master' into autoApprovePr

view details

Dennis Seah

commit sha 1bf5e67f80182e1f82b716366640e517a70f2002

Merge branch 'master' into 1330

view details

nrose

commit sha 2d561e2cd9f1170f756527bc3121c873e1a6127b

general git repo urls to support private repos

view details

Samiya Akhtar

commit sha 80e285d8e8b4b82b57e8548ea400022e21c0fdef

Merge pull request #6 from samiyaakhtar/1330 Bug fix for smoke test failures when PR is not found

view details

Andre Briggs

commit sha 24c437911b1a8c9d472bb92f9c0b7b69cf7162e4

[DOCS] Adding Markdown file for spk deployment create (#7) * Added create.md * Update * Adding command examples about other pipelines Co-authored-by: Dennis Seah <dennis.seah@gmail.com> Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com> Co-authored-by: Samiya Akhtar <samiyaakhtar7@gmail.com>

view details

Andre Briggs

commit sha 355126335fcad4af0d5bfe082cbb5812a1ad8ad3

Merge branch 'master' into autoApprovePr

view details

Samiya Akhtar

commit sha 886c1c9aeca01233a12c4fb027bdb621e5edfe1e

Merge branch 'master' into nate.patch.relative-paths

view details

Dennis Seah

commit sha fb672f2c11848faa7a73a61a4558c0537dc55238

Update azure.ts

view details

Nate

commit sha 996e6b8d6ffb5defa51ea4707b36e3af8da69e60

Merge pull request #10 from NathanielRose/nate.patch.relative-paths Fix for relative path support for private repos

view details

Dennis Seah

commit sha 29c41781a0d939789b45d0263d514030abc3bbb9

Update setup.md

view details

Dennis Seah

commit sha 7bf5eb5f0ce383a5f76e265c69e2ecc0fbb96b76

Merge branch 'master' into autoApprovePr

view details

andrebriggs@users.noreply.github.com

commit sha 42a354e8d67e217d71d182deb73c88f932e16fbd

Renamed env to ring. Removed deploy id from deployment get

view details

andrebriggs@users.noreply.github.com

commit sha 0be19948c2a4ebe8ed137e0f0321a38feef12b3f

Remove comment

view details

andrebriggs@users.noreply.github.com

commit sha 56ca3bada6a01ffbdd0abbb187df5d69df6b20fb

Adding comment

view details

Samiya Akhtar

commit sha 12b5ca7b8382161977c72bbe60ecec26ef059ea3

Merge branch 'master' into abrig-introspection

view details

push time in 3 months

pull request commentmicrosoft/bedrock

fail pipeline if git clone fails

good catch! thanks for the PR.

jsturtevant

comment created time in 3 months

issue commentmicrosoft/bedrock

spk hld init --git-push fails when HLD repository is empty

@jsturtevant great - that's enough impetus for us to prioritize/work on this sprint i think!

bnookala

comment created time in 3 months

Pull request review commentbnookala/folding-on-azure

Working terraform workflow with docs

 variable "batch_account_name" {  variable "batch_pool_display_name" {   type = string-  default = "test-folding-pool-display-name"+  default = "azure-folding-at-home" }  variable "batch_pool_node_agent_sku_id" {   type = string   default = "batch.node.ubuntu 16.04"-  # default = "batch.node.ubuntu 18-04 LTS"+  # default = "batch.node.ubuntu 18-04 LTS" // Targeted for GPU/graphics tasks? }  variable "batch_pool_vm_size" {   type = string-  default = "Standard_A1"+  # default = "Standard_A1"   # default = "Standard_F4s"+  default = "Standard_F4s_v2"+  # default = "Standard_D4_v3" } +# variable "container_registry" {+#   type = string+#   default = "docker.io"+# }++# variable "container_user_id" {+#   type = string+# }++# variable "container_user_password" {+#   type = string+# }+ variable "resource_group_name" {   type = string }  variable "resource_group_location" {   type = string-  default = "West US 2"+  # default = "West US 2"+  default = "South Central US"+}++variable "scale_dedicated_nodes" {+  type = number+  default = 0+}++variable "scale_low_priority_nodes" {+  type = number+  default = 5 }  variable "storage_account_name" {   type = string } +variable "fah_enable_gpu" {+  type = bool+  default = false+}++variable "fah_enable_smp" {

what's this flag?

mtarng

comment created time in 3 months

Pull request review commentbnookala/folding-on-azure

Working terraform workflow with docs

 variable "batch_account_name" {  variable "batch_pool_display_name" {   type = string-  default = "test-folding-pool-display-name"+  default = "azure-folding-at-home" }  variable "batch_pool_node_agent_sku_id" {   type = string   default = "batch.node.ubuntu 16.04"-  # default = "batch.node.ubuntu 18-04 LTS"+  # default = "batch.node.ubuntu 18-04 LTS" // Targeted for GPU/graphics tasks?

can't use 18-04?

mtarng

comment created time in 3 months

Pull request review commentbnookala/folding-on-azure

Working terraform workflow with docs

-# folding-on-azure\ No newline at end of file+# folding-on-azure++The purpose of this repository is to provide an easy set of steps to deploy [Folding@Home](https://foldingathome.org/) resources on Azure.

maybe mention Azure Batch here

mtarng

comment created time in 3 months

issue commentmicrosoft/bedrock

No passphrase prompt for gitops ssh key

Related to #1241

archerpmorgan

comment created time in 3 months

issue closedmicrosoft/bedrock

Duplication markdown files in Bedrock docs

Describe the bug: We have hld-to-manifest.md and hldToManifest.md

Both appear to be the same. We should delete one

closed time in 3 months

andrebriggs

delete branch microsoft/bedrock-cli

delete branch : add-k8s-service-docs

delete time in 3 months

push eventmicrosoft/bedrock-cli

Bhargav Nookala

commit sha 02a44c56aa9e537b30b825fbe81f4da831256a57

Adding service documentation

view details

push time in 3 months

PR merged microsoft/bedrock-cli

Reviewers
Adding service documentation

Closes https://github.com/microsoft/bedrock/issues/1193

+30 -2

1 comment

2 changed files

bnookala

pr closed time in 3 months

issue closedmicrosoft/bedrock

Expand helm documentation to describe service type options

As a: spk user creating my helm chart I want: Guidance on service types. So that: I can make an informed decision when choosing my Service type on helm chart configuration Describe the solution you'd like: Expanded documentation or link on k8s service types and explaining what bedrock suggests

Author's comment- I believe we should suggest ClusterIP as the default so that services aren't exposed directly though a provisioned external IP, rather all traffic should be routed through the IP provisioned for Traefik2

Additional context: Our reference documentation points to a Service that, by default, is configured to a LoadBalancer. Does this require updates to documentation?:

closed time in 3 months

mtarng

push eventmicrosoft/bedrock-cli

Bhargav Nookala

commit sha cc6f6866458bacef471595b77dd22d28c2ebecfa

Adding service documentation

view details

push time in 3 months

push eventbnookala/spk

Samiya Akhtar

commit sha 7d56791f64a6be1a9cf0885291c61c2ebf80ce97

Handle the case where multiple PRs are present

view details

Samiya Akhtar

commit sha 9d0fe6acf9cc8805bfe96a6e9c8c8f2e318483b8

Remove log statement

view details

Dennis Seah

commit sha 1bf5e67f80182e1f82b716366640e517a70f2002

Merge branch 'master' into 1330

view details

nrose

commit sha 2d561e2cd9f1170f756527bc3121c873e1a6127b

general git repo urls to support private repos

view details

Samiya Akhtar

commit sha 80e285d8e8b4b82b57e8548ea400022e21c0fdef

Merge pull request #6 from samiyaakhtar/1330 Bug fix for smoke test failures when PR is not found

view details

Andre Briggs

commit sha 24c437911b1a8c9d472bb92f9c0b7b69cf7162e4

[DOCS] Adding Markdown file for spk deployment create (#7) * Added create.md * Update * Adding command examples about other pipelines Co-authored-by: Dennis Seah <dennis.seah@gmail.com> Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com> Co-authored-by: Samiya Akhtar <samiyaakhtar7@gmail.com>

view details

Samiya Akhtar

commit sha 886c1c9aeca01233a12c4fb027bdb621e5edfe1e

Merge branch 'master' into nate.patch.relative-paths

view details

Nate

commit sha 996e6b8d6ffb5defa51ea4707b36e3af8da69e60

Merge pull request #10 from NathanielRose/nate.patch.relative-paths Fix for relative path support for private repos

view details

Bhargav Nookala

commit sha cc6f6866458bacef471595b77dd22d28c2ebecfa

Adding service documentation

view details

push time in 3 months

push eventmicrosoft/bedrock-cli

Samiya Akhtar

commit sha 7d56791f64a6be1a9cf0885291c61c2ebf80ce97

Handle the case where multiple PRs are present

view details

Samiya Akhtar

commit sha 9d0fe6acf9cc8805bfe96a6e9c8c8f2e318483b8

Remove log statement

view details

Dennis Seah

commit sha 1bf5e67f80182e1f82b716366640e517a70f2002

Merge branch 'master' into 1330

view details

nrose

commit sha 2d561e2cd9f1170f756527bc3121c873e1a6127b

general git repo urls to support private repos

view details

Samiya Akhtar

commit sha 80e285d8e8b4b82b57e8548ea400022e21c0fdef

Merge pull request #6 from samiyaakhtar/1330 Bug fix for smoke test failures when PR is not found

view details

Andre Briggs

commit sha 24c437911b1a8c9d472bb92f9c0b7b69cf7162e4

[DOCS] Adding Markdown file for spk deployment create (#7) * Added create.md * Update * Adding command examples about other pipelines Co-authored-by: Dennis Seah <dennis.seah@gmail.com> Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com> Co-authored-by: Samiya Akhtar <samiyaakhtar7@gmail.com>

view details

Samiya Akhtar

commit sha 886c1c9aeca01233a12c4fb027bdb621e5edfe1e

Merge branch 'master' into nate.patch.relative-paths

view details

Nate

commit sha 996e6b8d6ffb5defa51ea4707b36e3af8da69e60

Merge pull request #10 from NathanielRose/nate.patch.relative-paths Fix for relative path support for private repos

view details

Bhargav Nookala

commit sha 1965aacd2fc5fd1c6470d192c1ea7474e9217afc

Adding service documentation

view details

push time in 3 months

Pull request review commentmicrosoft/bedrock-cli

[FEATURE] auto approve PR for spk setup command

 let gitApi: IGitApi | undefined; // keep track of the gitApi so it can be reused // Helpers //////////////////////////////////////////////////////////////////////////////// +/**+ * Returns azure organization URL.+ *+ * @param orgName Organization name+ */+export const getAzureOrganizationUrl = (orgName: string): string => {+  return `https://dev.azure.com/${orgName}`;

@dennisseah @andrebriggs https://github.com/microsoft/bedrock/issues/1348

dennisseah

comment created time in 3 months

issue openedmicrosoft/bedrock

SPK setup should support visualstudio.com domains

As a:

spk setup user

I want:

spk setup to support my organization hosted on visualstudio.com ie org.visualstudio.com

So that:

I can use my organization hosted on visualstudio.com to run spk setup

Describe the solution you'd like:

  • [ ] spk setup should prompt which domain (dev.azure.com or visualstudio.com to use
  • [ ] spk setup should confirm if organization hosted on the selected domain exists

Acceptance Criteria:

  • [ ] spk setup should prompt which domain (dev.azure.com or visualstudio.com to use
  • [ ] spk setup should confirm if organization hosted on the selected domain exists

Additional context:

Historically, visualstudio.com was where azure devops hosted organizations - dev.azure.com is the new domain

Does this require updates to documentation?:

yes

created time in 3 months

Pull request review commentmicrosoft/bedrock-cli

[FEATURE] auto approve PR for spk setup command

 let gitApi: IGitApi | undefined; // keep track of the gitApi so it can be reused // Helpers //////////////////////////////////////////////////////////////////////////////// +/**+ * Returns azure organization URL.+ *+ * @param orgName Organization name+ */+export const getAzureOrganizationUrl = (orgName: string): string => {+  return `https://dev.azure.com/${orgName}`;

@dennisseah okay, just looked and seems like setup assumes strict dev.azure.com domains - i'll resolve this for now, and file a ticket to make it support visualstudio.com domains

dennisseah

comment created time in 3 months

pull request commentmicrosoft/bedrock-cli

Adding service documentation

Er… ignore assigneess section

bnookala

comment created time in 3 months

PR opened microsoft/bedrock-cli

Reviewers
Adding service documentation

Closes https://github.com/microsoft/bedrock/issues/1193

+29 -1

0 comment

1 changed file

pr created time in 3 months

create barnchmicrosoft/bedrock-cli

branch : add-k8s-service-docs

created branch time in 3 months

create barnchbnookala/spk

branch : add-k8s-service-docs

created branch time in 3 months

push eventbnookala/spk

Edaena Salinas

commit sha 6e85403415607257dacb94cf178facba2db332ce

Add error codes in service create

view details

Dennis Seah

commit sha c58fe7c14630e701537edb11de445f31f122c88f

Update create.ts

view details

Dennis Seah

commit sha a034ee8219c8dfdef1cdc20f8fca61ebb1cf94b8

Update i18n.json

view details

Dennis Seah

commit sha 394976337a99a4f6ae30eaf966dcc7e5b9988265

Update constants.ts

view details

Dennis Seah

commit sha 0386f5b9ae0dfae6b11e445b51a7bb9a1307512a

Merge branch 'edaena-svc-create-err' of https://github.com/microsoft/bedrock-cli into edaena-svc-create-err

view details

Edaena Salinas

commit sha 6af4992a88701440cc5bf56348dc84cfb8ad406c

Add error code to install build pipeline

view details

Edaena Salinas

commit sha 3844277a5a9a0422979d2d37767ae86f2592a76a

Update error message

view details

Dennis Seah

commit sha 6d3e3ce572eb31817eaab2709033278fc600f3ea

Merge pull request #5 from microsoft/edaena-svc-build-err Error codes for service install build pipeline

view details

Dennis Seah

commit sha 063e51cce94e0b59fb25af1625539f942a0d42e1

Merge branch 'master' into edaena-svc-create-err

view details

Edaena Salinas

commit sha 4e82b223291bf39d9eaf262df5a1789ebfcb50e5

Fix error message

view details

Dennis Seah

commit sha df558841d9c4cf5dc0440639268a4f09fc8219a9

Update i18n.json

view details

Dennis Seah

commit sha 428023dfb26379d983151d1e09199a8c1aadc2c3

Update pipeline.test.ts

view details

Dennis Seah

commit sha 4985ca4c79128b972c1f5bbca3349de7cbf09e6c

Merge pull request #4 from microsoft/edaena-svc-create-err Add error codes in service create

view details

Michael Tarng

commit sha 3a95e233e120369fb51dac01411dffb1b0be3d27

Ring smoke tests - delete ring

view details

push time in 3 months

push eventmicrosoft/bedrock-cli

Michael Tarng

commit sha 3a95e233e120369fb51dac01411dffb1b0be3d27

Ring smoke tests - delete ring

view details

push time in 3 months

delete branch microsoft/bedrock-cli

delete branch : ring-delete-smoke-test

delete time in 3 months

PR merged microsoft/bedrock-cli

Reviewers
Ring smoke tests - delete ring

Closes https://github.com/CatalystCode/spk/pull/539

Copied over work from https://github.com/CatalystCode/spk/pull/539 and validated.

+76 -11

0 comment

2 changed files

mtarng

pr closed time in 3 months

PR closed CatalystCode/spk

Reviewers
[DO NOT MERGE] Adding ring delete to smoke test. Updating smoke tests README.

Closes: https://github.com/microsoft/bedrock/issues/1282

This should not be merged until:

  • [x] https://github.com/CatalystCode/spk/pull/537 is merged.
  • [ ] a new release (v0.6.1) is made after the above PR is merged.
+75 -11

0 comment

2 changed files

mtarng

pr closed time in 3 months

Pull request review commentmicrosoft/bedrock-cli

[FEATURE] auto approve PR for spk setup command

 let gitApi: IGitApi | undefined; // keep track of the gitApi so it can be reused // Helpers //////////////////////////////////////////////////////////////////////////////// +/**+ * Returns azure organization URL.+ *+ * @param orgName Organization name+ */+export const getAzureOrganizationUrl = (orgName: string): string => {+  return `https://dev.azure.com/${orgName}`;

i'm not aware of any api check - we've looked at the git remote to extrapolate what url scheme the url falls under in the past (see: https://github.com/microsoft/bedrock-cli/blob/60c89e1d7c09ae55bb622359baa3a6bbba2824a0/src/lib/gitutils.ts#L236) - maybe you can do a similar check based on the input git urls.

for the sake of completeness, i would ask that you have this fixed in this PR, as we have had to do bug fixes in the past to fix this issue for users - and have a learning that this is something that users will run into if they use visualstudio.com domains with the setup command.

dennisseah

comment created time in 3 months

push eventbnookala/spk

Microsoft Open Source

commit sha 6d99dc9a9c2954a0ff08ea221fad791295c48337

Initial CODE_OF_CONDUCT.md commit

view details

Microsoft Open Source

commit sha 4ef3ee0d0d82a4f4895c5e6c661869affbea6e60

Initial README.md commit

view details

Microsoft Open Source

commit sha 5f9b3072f7fec442c78d6b0a641c00a72291379f

Initial LICENSE commit

view details

Microsoft Open Source

commit sha b018954af5f830ecbac81567daea847d9f5c978f

Initial SECURITY.md commit

view details

Dennis Seah

commit sha 57d23a63dde01fd0c6d6ef2c87ea7883178ff1ad

[FEATURE] have error code for deployment get command (#511) * [FEATURE] have error code for deployment get command * Update i18n.json * Update get.ts

view details

Dennis Seah

commit sha 16641db3fbdedfed9290ca4a99e3be97fc326947

[HOUSEKEEPING] remove page wide eslint disable for service cmds (#489) Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com>

view details

Yvonne Radsmikham

commit sha b5d27730fd3f7e281a1fcfbaa72bbe1144dbf776

Design doc for `spk service create` (#480)

view details

Dennis Seah

commit sha 933746dcc63a313d94779d69f3c904c3f4a37525

[FEATURE] simplify option values inherit from config.yaml for service create rev cmd (#507) Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com>

view details

Dennis Seah

commit sha bffdf302eeb735052d10035f31c6bf4364996b0b

[HOUSEKEEPING] simplify inheriting opt values from config.yaml for svc pipeline cmd (#508) Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com>

view details

Dennis Seah

commit sha 31b1ee9199e1208baaaae5483081c9b9afc9f1e1

[FEATURE] inheritence information in operational doc (#510) * [FEATURE] inheritence information in operational doc * Update pipeline.ts * Update pipeline.test.ts Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com>

view details

Edaena Salinas

commit sha ead0d68bfcfa9f0a541e1d76f7d7518a8ddc45cd

Add error codes for project commands (#514) * Add error codes for project commands * Change error message Co-authored-by: Edaena Salinas <edaena@Edaenas-MBP.hsd1.ca.comcast.net> Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com> Co-authored-by: Dennis Seah <dennis.seah@gmail.com>

view details

Evan Louie

commit sha ea3f483485c5b920305a21675542be230cd80359

Fix: Race condition in getRemoteUrl test - Removed a race condition for the `getRemoteUrl` tests caused by the test functions being both `async` as well as using a `done` callback.

view details

Evan Louie

commit sha ce12b9f6002727f52fe1d01ad36b8266514441b1

bedrock.yaml refactor & service create spec update - Updated bedrock.yaml `services` to contain a list of services instead of a map indexed by path. - Auto-migration of bedrock.yaml is hooked into `read()` function of the `bedrockYaml.ts` file. - `read()` is now the only function used for loading the bedrock.yaml file; `Bedrock()` in `config.ts` is now noted as deprecated and now calls `read()` under the hood. - `path` property for a service now tracks the path to the service. - Documentation references all updated. - `spk service create <service-name>` now follows the spec `spk service create <service-name> <service-path>` - Documentation references all updated. - Integration tests updated.

view details

Evan Louie

commit sha 63212081a4a6c34d4a39e8059ce671b672aa82a1

Fix: Migrate Ring functions to new schema - `spk ring create` and `spk ring delete` were expecting the legacy bedrock.yaml schema where services were a map indexed by path -- it is now a list with a `path` property. Ring commands have been updated to reflect the new schema.

view details

Dennis Seah

commit sha 6b653ee1ff931f72dc382f9da72fea9c760e4f41

[BUG FIX] add proper error message when PAT is incorrect. (#515) * [BUG FIX] add proper error message when PAT is incorrect. * add unit tests Co-authored-by: Yvonne Radsmikham <yvonne.radsmikham@gmail.com>

view details

Edaena Salinas

commit sha 6901ca28e8426c1571f70d3b3b7508b5b634c284

Add markup file for hld command (#513)

view details

Michael Tarng

commit sha 7d4a50657fb17558eb24379fd9824eaf52aa7a63

Lifecycle pipeline will only trigger off changes to bedrock.yaml

view details

Michael Tarng

commit sha fd3f420f215179a33f956b115d5eea3b1acd1046

updating validation.sh smoke tests with the reduced lifecycle/manifest generation build count

view details

Dennis Seah

commit sha 5d1904c4a168670f5e81b4050780191d5b5ad4a9

[FEATURE] Specific error code for deployment onboard command (#516) * [FEATURE] Specific error code for deployment onboard command * Update onboard.test.ts Co-authored-by: Andre Briggs <andrebriggs@users.noreply.github.com>

view details

Samiya Akhtar

commit sha 01c4f28d84398f8b1881451d1aac2f1113566d74

Capture docker version in an env var while launching dashboard (#522) Co-authored-by: Dennis Seah <dennis.seah@gmail.com>

view details

push time in 3 months

Pull request review commentmicrosoft/bedrock-cli

[FEATURE] auto approve PR for spk setup command

 let gitApi: IGitApi | undefined; // keep track of the gitApi so it can be reused // Helpers //////////////////////////////////////////////////////////////////////////////// +/**+ * Returns azure organization URL.+ *+ * @param orgName Organization name+ */+export const getAzureOrganizationUrl = (orgName: string): string => {+  return `https://dev.azure.com/${orgName}`;

it's possible for an organization to be hosted on a visualstudio.com domain ie: https://${organization}.visualstudio.com/

dennisseah

comment created time in 3 months

delete branch CatalystCode/spk

delete branch : 1119-ingress-route-validation

delete time in 3 months

push eventCatalystCode/spk

Evan Louie

commit sha f6ac94650a3b91fa3d32d80d21bca2603419aaed

Added IngressRoute validation for standard and isDefault ring - Added `validate_file` calls for the `master` ring integration tests (i.e the `isDefault` ring). closes: https://github.com/microsoft/bedrock/issues/1119

view details

push time in 3 months

PR merged CatalystCode/spk

Added IngressRoute validation for standard and isDefault ring
  • Added validate_file calls for the master ring integration tests (i.e the isDefault ring).

closes: https://github.com/microsoft/bedrock/issues/1119

+9 -0

2 comments

1 changed file

evanlouie

pr closed time in 3 months

issue closedmicrosoft/bedrock

Extend SPK integration tests to validate IngressRoutes

  • [ ] TBD: Validate ring IngressRoutes. Either validate generated manifests or tbd if/when we have a test cluster to curl an endpoint with headers.

closed time in 3 months

andrebriggs

delete branch bnookala/folding-on-azure

delete branch : terraform-template

delete time in 3 months

more