Let me know if I captured the essence of your improvements in the changelog :-)

I've done this. Have we ever called telstate.clear() on a Redis server outside of unit tests?

Done.

I did try to put this into as few lines as possible, focussing on the take-home message for external users (if there are even any - let's call them less informed users :-)). #107 only affects unit tests and #112 only makes sense in unit tests, so I took some liberties here.

How about this split?

* Improve `wait_keys` responsiveness for `MemoryBackend` (#111, #116)
* Speed up telstate.clear and support older HMSET command in unit tests (#107, #112)

Let me know if I captured the essence of your improvements in the changelog :-)

Adding a feature to generate a view specifically useful for holography observations.

Do you have a way of testing this in the lab before rolling it out to site?

Merging now

github appears to suck, there is only a resolve option, and no reply option to your comment.

In the case you mention the 'else' part will be called of the if statement (i.e. it simply chooses the first antenna in the array): send_websock_cmd('logconsole("Invalid reference antenna specified, using default instead",true,true,true)',handlerkey) refantnumber=antnumbers[0]

On Tue, May 4, 2021 at 4:22 PM Bruce Merry ***@***.***> wrote:

**@. commented on this pull request.

In scripts/time_plot.py https://github.com/ska-sa/katsdpdisp/pull/84#discussion_r625824631:

•                for ant in track_ants:
  

•                    if ant in scan_ants_always:
  

•                        scan_ants.append(ant)
  

•                    else:
  

•                        newtrackants.append(ant)
  

•                track_ants=newtrackants
  

•                scan_ants=sorted(scan_ants)
  

•            if (len(args)==1 or args[1]==''):
  

•                if len(track_ants):
  

•                    refantnumber=int(track_ants[0][1:])
  

•                else:
  

•                    refantnumber=antnumbers[0]
  

•            else:#use supplied refant
  

•                refantnumberlist=parse_antennarange(','.join(args[1:]))
  

•                if (len(refantnumberlist)==1):
  

•                    refantnumber=refantnumberlist[0]
  

This is still outstanding.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ska-sa/katsdpdisp/pull/84#discussion_r625824631, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKRCLAVIYMGSVFZWU237QLTL77ITANCNFSM4ZLHZQTA .

Anything outstanding about this, can we merge with master?

On Wed, Apr 21, 2021 at 10:23 AM Bruce Merry ***@***.***> wrote:

**@. requested changes on this pull request.

In scripts/time_plot.py https://github.com/ska-sa/katsdpdisp/pull/84#discussion_r617306010:

•            obs_params=telstate.get(obs_params_key, {})
  

•            scan_ants_always=[]
  

•            scan_ants=[]
  

•            track_ants=[]
  

•            if b'scan_ants' in obs_params:
  

•                scan_ants=to_str(obs_params[b'scan_ants']).split(',')
  

•            if b'track_ants' in obs_params:
  

•                track_ants=to_str(obs_params[b'track_ants']).split(',')
  

•            if b'scan_ants_always' in obs_params:
  

•                scan_ants_always=to_str(obs_params[b'scan_ants_always']).split(',')
  

⬇️ Suggested change

•            obs_params=telstate.get(obs_params_key, {})
  

•            scan_ants_always=[]
  

•            scan_ants=[]
  

•            track_ants=[]
  

•            if b'scan_ants' in obs_params:
  

•                scan_ants=to_str(obs_params[b'scan_ants']).split(',')
  

•            if b'track_ants' in obs_params:
  

•                track_ants=to_str(obs_params[b'track_ants']).split(',')
  

•            if b'scan_ants_always' in obs_params:
  

•                scan_ants_always=to_str(obs_params[b'scan_ants_always']).split(',')
  

•            obs_params=to_str(telstate.get(obs_params_key, {}))
  

•            scan_ants_always=[]
  

•            scan_ants=[]
  

•            track_ants=[]
  

•            if 'scan_ants' in obs_params:
  

•                scan_ants=obs_params['scan_ants'].split(',')
  

•            if 'track_ants' in obs_params:
  

•                track_ants=obs_params['track_ants'].split(',')
  

•            if 'scan_ants_always' in obs_params:
  

•                scan_ants_always=obs_params['scan_ants_always'].split(',')
  

---

In scripts/time_plot.py https://github.com/ska-sa/katsdpdisp/pull/84#discussion_r617306219:

•                for ant in track_ants:
  

•                    if ant in scan_ants_always:
  

•                        scan_ants.append(ant)
  

•                    else:
  

•                        newtrackants.append(ant)
  

•                track_ants=newtrackants
  

•                scan_ants=sorted(scan_ants)
  

•            if (len(args)==1 or args[1]==''):
  

•                if len(track_ants):
  

•                    refantnumber=int(track_ants[0][1:])
  

•                else:
  

•                    refantnumber=antnumbers[0]
  

•            else:#use supplied refant
  

•                refantnumberlist=parse_antennarange(','.join(args[1:]))
  

•                if (len(refantnumberlist)==1):
  

•                    refantnumber=refantnumberlist[0]
  

This is a question that you haven't answered.

In katsdpdisp/html/help.txt https://github.com/ska-sa/katsdpdisp/pull/84#discussion_r617302388:

@@ -232,8 +232,9 @@ A spectrum plot is also produced.

You may additionally want to issue a command such as 'flags=..500,520..'

For example:

-'holo' regenerates a view using the first tracking antenna as reference of cross correlation product

+'holo' regenerates a view using the first tracking antenna as reference of cross correlation product (h pol)

'holo 4' regenerates a view using m004 as reference of cross correlation product

Help should say so then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ska-sa/katsdpdisp/pull/84#pullrequestreview-640755219, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKRCLEH5MURJH7ZZFUZKLTTJ2DOLANCNFSM4ZLHZQTA .

btw, how about killing off support for 3.4 & 3.5? both are past their end of life and it would reduce testing time

personally I used these to indicate "these are the supported & tested version, don't be surprised if it doesn't work with others" instead of relying on just "probably"

Coverage remained the same at 94.383% when pulling dd858eb56d9485e14af27b7571c655d348689f98 on dependabot/pip/urllib3-1.25.8 into 03439b96920752783d95eb7dacefa0f7c6f4015e on master.

Bumps urllib3 from 1.25.7 to 1.25.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>1.25.8</h2> <p>Release: 1.25.8</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h2>1.25.8 (2020-01-20)</h2> <ul> <li> <p>Drop support for EOL Python 3.4 (Pull <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1774">#1774</a>)</p> </li> <li> <p>Optimize _encode_invalid_chars (Pull <a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1787">#1787</a>)</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/2a57bc5758075a9248cc0d87f66a2ff678338478"><code>2a57bc5</code></a> Release 1.25.8 (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1788">#1788</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/a2697e7c6b275f05879b60f593c5854a816489f0"><code>a2697e7</code></a> Optimize _encode_invalid_chars (<a href="https://github-redirect.dependabot.com/urllib3/urllib3/issues/1787">#1787</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/d2a5a5920fffcc48e6141f4126c491343800d16a"><code>d2a5a59</code></a> Move IPv6 test skips in server fixtures</li> <li><a href="https://github.com/urllib3/urllib3/commit/d44f0e53d9b6943a270af9ce625728ab3201a148"><code>d44f0e5</code></a> Factorize test certificates serialization</li> <li><a href="https://github.com/urllib3/urllib3/commit/84abc7f897cc9ba79ac02278966bc1548373262a"><code>84abc7f</code></a> Generate IPV6 certificates using trustme</li> <li><a href="https://github.com/urllib3/urllib3/commit/6a15b1885a61b3ccf3db140e8256cd290b4762ea"><code>6a15b18</code></a> Run IPv6 Tornado server from fixture</li> <li><a href="https://github.com/urllib3/urllib3/commit/4903840bf36a05bcc8299f6553ff7a1816d4aa63"><code>4903840</code></a> Use trustme to generate IP_SAN cert</li> <li><a href="https://github.com/urllib3/urllib3/commit/9971e27e83a891ba7b832fa9e5d2f04bbcb1e65f"><code>9971e27</code></a> Empty responses should have no lines.</li> <li><a href="https://github.com/urllib3/urllib3/commit/62ef68e49edf5dabde26732a154d0e925cef7301"><code>62ef68e</code></a> Use trustme to generate NO_SAN certs</li> <li><a href="https://github.com/urllib3/urllib3/commit/fd2666e3f16c62c892e5dd9a5697f537de06628b"><code>fd2666e</code></a> Use fixture to configure NO_SAN test certs</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/1.25.7...1.25.8">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

I was going to ask whether there would be any parallactic rotation of Jupiter's radio axis with respect to (ra, dec) and now I know, thanks to the movie :-D

And the spacing between Jupiter and Saturn also seems right for the conjunction (~0.1º).

I like the radio galaxy photobombing this auspicious moment :joy: