profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/banyan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

banyan/auto-label 54

A GitHub action to add labels to Pull Request based on matched file patterns

banyan/backbone.websql.deferred 11

WebSQL adapter for Backbone with promise support

banyan/chef 5

My Chef recipes, cookbooks, etc.

banyan/accept_values_for 2

Collection of Rspec matchers to test AR models that follows BDD.

banyan/chef-cooker 2

chef-cooker will be able to create cookbook of Chef easily. yay ;)

banyan/automaticruby 1

Ruby General Automation Framework

issue commentfacebook/create-react-app

npx create-react-app is not working

Just run npm i -g create-react-app@4.0.1

Here, my error was quite same except for version which was 4.0.3

I think this work on MacBook M1 too

Waqas-Akram

comment created time in 18 minutes

issue openedfirebase/firebase-js-sdk

signInWithPopup doesn't work in Firefox (Google, Facebook)

<!-- Step 1 [READ THIS] --> <!--

Are you in the right place?

  • For issues or feature requests related to the code in this repository file a Github issue.
    • If this is a feature request make sure the issue title starts with "FR:".
  • For general technical questions, post a question on StackOverflow with the firebase tag.
  • For general Firebase discussion, use the firebase-talk google group.
  • For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel.

-->

<!-- Step 2 -->

[REQUIRED] Describe your environment

  • Operating System version: MacOS Big Sur 11.2
  • Browser version: Firefox 86
  • Firebase SDK version: 8.2.10
  • Firebase Product: auth
  • React: 17.0.1

<!-- Step 3 -->

[REQUIRED] Describe the problem

Steps to reproduce:

<!-- What happened? How can we make the problem occur? This could be a description, log/console output, etc. -->

Fails in Firefox

https://user-images.githubusercontent.com/7975158/110214232-f596c580-7ea3-11eb-8a30-183728d8e2c9.mov

Works in Safari !!!

https://user-images.githubusercontent.com/7975158/110214449-d0568700-7ea4-11eb-8a3e-3e59ae1dec82.mov

Relevant Code:

signInFirebasePopup is called with onClick, not asynchronously

const getAuthProvider = (
  providerId: "facebook" | "google" | "apple",
): Firebase.auth.AuthProvider => {
  switch (providerId) {
    case "facebook": {
      const provider = new Firebase.auth.FacebookAuthProvider();
      provider.addScope("public_profile");
      provider.addScope("email");
      return provider;
    }
    case "google": {
      const provider = new Firebase.auth.GoogleAuthProvider();
      provider.addScope("profile");
      provider.addScope("email");
      return provider;
    }
    default: {
      throw new Error("Invalid provider");
    }
  }
};
export const signInFirebasePopup = async (
  providerId: "facebook" | "google" | "apple",
): Promise<ExtractedFirebaseProfileData> => {
  try {
    const provider = getAuthProvider(providerId);
    // await reloadFirebaseUser(); // This causes errors, flow may fail because its asynchronous
    const userCredential = await Firebase.auth().signInWithPopup(provider);
    const profileData = extractProfileData(userCredential);

    return profileData;
  } catch (e) {
    await logoutFirebase(); // dump state
    throw e;
  }
};

created time in 19 minutes

issue commentfacebook/create-react-app

create-react-app my-app doesn't work

I think you should write the complete command that is "npx create-react-app my-app"

Ashlyn1997

comment created time in 27 minutes

push eventmillsp/ts-toolbelt

Pierre-Antoine Mills (via Travis CI)

commit sha 0cb6543ce29e3e881f904355e7f91df8a50a843d

Deploy millsp/ts-toolbelt to github.com/millsp/ts-toolbelt.git:gh-pages

view details

push time in 35 minutes

issue closedmillsp/ts-toolbelt

## 🐞 Bug Report

🐞 Bug Report

Describe the bug

For this signature:

function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

this works: image

however, adding a second key breaks the nested pick: image

Reproduce the bug

// REPL or a link to your repository if applicable.
// A *self-contained* demonstration of the problem.

Is it possible to use TS Toolbelt in the typescript TS Playground? If so it's easy for me to replicate this. Otherwise I can set up a branch on my package if you like.

Possible Solution

I'm not sure!

Originally posted by @mesqueeb in https://github.com/millsp/ts-toolbelt/discussions/216

closed time in 42 minutes

millsp

issue commentmillsp/ts-toolbelt

## 🐞 Bug Report

It happens that I forgot to distribute O.P utilities. I took the day to rewrite all of them. Nous you can do:

import {F, O, S} from 'ts-toolbelt'

declare function pick<T extends Record<string, any>, K extends string>(
    obj: T,
    keys: F.AutoPath<T, K>[]
): O.P.Pick<T, S.Split<K, '.'>>

type O = {
    a: {
        b: O
        c: 1
    }
}
const a = pick({} as O, ['a', 'a.b', 'a.b.a.c'])
millsp

comment created time in 42 minutes

issue openedmillsp/ts-toolbelt

## 🐞 Bug Report

🐞 Bug Report

Describe the bug

For this signature:

function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

this works: image

however, adding a second key breaks the nested pick: image

Reproduce the bug

// REPL or a link to your repository if applicable.
// A *self-contained* demonstration of the problem.

Is it possible to use TS Toolbelt in the typescript TS Playground? If so it's easy for me to replicate this. Otherwise I can set up a branch on my package if you like.

Possible Solution

I'm not sure!

Originally posted by @mesqueeb in https://github.com/millsp/ts-toolbelt/discussions/216

created time in 43 minutes

push eventmillsp/ts-toolbelt

Pierre-Antoine Mills

commit sha 1ad26389aa6a9a795d19d90d2724c73ae2bd51d9

fix(f.autopath): do not show primitive props

view details

Pierre-Antoine Mills

commit sha 2bdb4778325288154c8f71c0a5ae4a1b7e2b217f

fix(f.autopath): no primitve paths

view details

Pierre-Antoine Mills

commit sha 1f3928a70ff2a7e903a5398b53295c9c9997b42c

chore(release): 9.5.10

view details

push time in an hour

push eventmillsp/ts-toolbelt

Pierre-Antoine Mills (via Travis CI)

commit sha e9ff064e71427842ce866a7d8ad1b0422000417b

Deploy millsp/ts-toolbelt to github.com/millsp/ts-toolbelt.git:gh-pages

view details

push time in an hour

push eventmillsp/ts-toolbelt

Pierre-Antoine Mills

commit sha 29eddd99c6826696941c50681ce4858243786110

fix(f.autopath): distribute

view details

Pierre-Antoine Mills

commit sha d9415b2f85633c7c74a815c9909899114faf530c

chore(list): more flexible keys

view details

Pierre-Antoine Mills

commit sha 9d0ff6441518c2c9a01cea7726c08acd19eb37d9

chore(update): remove dirty code

view details

Pierre-Antoine Mills

commit sha 0f443626dc3b114b6784d2053510a1e0c2f7f839

chore(o.p): re-implement

view details

Pierre-Antoine Mills

commit sha 533a6ac0f7b713933c94f0962166c7a0245b055e

chore(release): 9.5.9

view details

push time in an hour

issue commentfirebase/firebase-js-sdk

Please optimize the size of libs

Is this the best place to receive updates on this issue? Would be awesome to get notified once the SDK is ready.

JosefJezek

comment created time in an hour

pull request commentfacebook/react

[Snyk]: Security Issue Fixes

Hi @gaearon : Thank you for the comment, I want to test the dependency related security issues, that is why I used that Snyk tool, Is there any other approach you are following to detect the dependency related security issues.

Thank you,

nchathu2014

comment created time in an hour

pull request commentgoogleapis/nodejs-video-transcoder

build: update gapic-generator-typescript to v1.2.10.

Codecov Report

Merging #38 (6bc8452) into master (6d17e38) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files           5        5           
  Lines        1581     1581           
  Branches       61       61           
=======================================
  Hits         1521     1521           
  Misses         59       59           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d17e38...b9915a9. Read the comment docs.

yoshi-automation

comment created time in 2 hours

PR opened googleapis/nodejs-video-transcoder

build: update gapic-generator-typescript to v1.2.10.

This PR was generated using Autosynth. :rainbow:

Synth log will be available here: https://source.cloud.google.com/results/invocations/2812cef8-9404-4275-bb51-8c6dafc1bc6f/targets

  • [ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 361273630 Source-Link: https://github.com/googleapis/googleapis/commit/5477122b3e8037a1dc5bc920536158edbd151dc4

+4 -4

0 comment

2 changed files

pr created time in 2 hours

push eventgoogleapis/nodejs-video-transcoder

Yoshi Automation Bot

commit sha e87663595f45ee80329120a28ad6d25c55d83768

docs: put FPS table in code block (#20) PiperOrigin-RevId: 348857882 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Dec 23 15:47:05 2020 -0800 Source-Repo: googleapis/googleapis Source-Sha: 2ccf8f460800e98884d1aa4ba61e344ad4cd5d04 Source-Link: https://github.com/googleapis/googleapis/commit/2ccf8f460800e98884d1aa4ba61e344ad4cd5d04

view details

Yoshi Automation Bot

commit sha c4062fda1fb19ac3dccdfd2b8ca76dee23bb7891

docs: update dates (#21) This PR was generated using Autosynth. :rainbow: Synth log will be available here: https://source.cloud.google.com/results/invocations/000b31a7-d841-4bba-9f39-9c136bef31bc/targets - [ ] To automatically regenerate this PR, check this box.

view details

Yoshi Automation Bot

commit sha 9b9ca5db8168d70b8afb7dc994659ed92d6a645a

feat: adds style enumeration (#22) This PR was generated using Autosynth. :rainbow: Synth log will be available here: https://source.cloud.google.com/results/invocations/3cbe2688-2bdb-41ef-9967-e7d03a185d83/targets - [ ] To automatically regenerate this PR, check this box.

view details

release-please[bot]

commit sha 139b47af2245bf64ad57e60daedd7fa44dba58d3

chore: release 1.2.0 (#23) :robot: I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-video-transcoder/compare/v1.1.0...v1.2.0) (2021-01-09) ### Features * adds style enumeration ([#22](https://www.github.com/googleapis/nodejs-video-transcoder/issues/22)) ([9b9ca5d](https://www.github.com/googleapis/nodejs-video-transcoder/commit/9b9ca5db8168d70b8afb7dc994659ed92d6a645a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

view details

Yoshi Automation Bot

commit sha 085318c37e4fd8a76ffed21a5970669e3be5f7ad

refactor(nodejs): move build cop to flakybot (#26) This PR was generated using Autosynth. :rainbow: Synth log will be available here: https://source.cloud.google.com/results/invocations/1bcecc39-aa5c-40f4-9453-955704c7ca01/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: https://github.com/googleapis/synthtool/commit/57c23fa5705499a4181095ced81f0ee0933b64f6

view details

Benjamin E. Coe

commit sha d006d8bfa5fee29a97e49baec65a0e3c7782e49e

test: address flaky test (#33)

view details

sofisl

commit sha c20a7784991a6833506c4ee6943d6fbed6bf1350

build: increase timeout for flaky tests (#34)

view details

Yoshi Automation Bot

commit sha 6d17e3826038e12e35cc08aab04f8af78bb09f1b

build: adds UNORDERED_LIST enum (#29)

view details

yoshi-automation

commit sha b9915a99a76d61d0f1da6cbd6f422a753c741dbe

build: update gapic-generator-typescript to v1.2.10. This update unblocks generating IAM v1 and several more libraries that were previously blocked by their package names. Committer: @alexander-fenster PiperOrigin-RevId: 361273630 Source-Author: Google APIs <noreply@google.com> Source-Date: Fri Mar 5 20:02:38 2021 -0800 Source-Repo: googleapis/googleapis Source-Sha: 5477122b3e8037a1dc5bc920536158edbd151dc4 Source-Link: https://github.com/googleapis/googleapis/commit/5477122b3e8037a1dc5bc920536158edbd151dc4

view details

push time in 2 hours

issue openedFirebaseExtended/reactfire

Firestore incompatible with Create React App / Jest / JSDOM

<!--

Thank you for contributing to the Firebase community!

Have a usage question?

We get lots of those and we love helping you, but GitHub is not the best place for them and they will be closed. Here are some resources to get help:

  • Start with the quickstart: https://github.com/firebase/reactfire/blob/master/docs/quickstart.md
  • Go through the guide: https://github.com/firebase/reactfire/blob/master/docs/guide.md
  • Read the full API reference: https://github.com/firebase/reactfire/blob/master/docs/reference.md
  • Try out some examples: https://github.com/firebase/reactfire/blob/master/examples/README.md

If the official documentation doesn't help, try asking through our official support channels:

https://firebase.google.com/support/

Please avoid double posting across multiple channels!

Think you found a bug?

Yeah, we're definitely not perfect! Please use the bug report template below and include a minimal repro when opening the issue.

Have a feature request?

Great, we love hearing how we can improve our products! Just remove the template below and provide an explanation of your feature request. Provide code samples if applicable. Try to think about what it will allow you to do that you can't do today? How will it make current workarounds straightforward? What potential bugs and edge cases does it help to avoid?

-->

Version info

<!-- What versions of the following libraries are you using? Note that your issue may already be fixed in the latest versions. -->

React: 17

Firebase: 8.2.10

ReactFire: 3.0.0-rc.0

Test case

import React from "react";
import { render, screen, waitFor } from "@testing-library/react";
import "firebase/auth";
import "firebase/firestore";
import {
  FirebaseAppProvider,
  useFirestore,
  useFirestoreDocData,
} from "reactfire";

function TestComponent() {
  const userRef = useFirestore().collection("users").doc("test");

  const { data: user, status } = useFirestoreDocData<any>(userRef);

  if (status !== "success") return <></>;

  return <>testing</>;
}

test("renders user", async () => {
  render(
    <FirebaseAppProvider
      firebaseConfig={config}
    >
      <TestComponent />
    </FirebaseAppProvider>
  );

  await waitFor(() => expect(screen.getByText("testing")).toBeInTheDocument());

  screen.debug();
});

Steps to reproduce

  1. Use a standard create-react-app template
  2. Setup a test similar to the one above
  3. Run it

Expected behavior

Test should pass

Actual behavior

Error: Uncaught [TypeError: this.timerId.unref is not a function]
        at reportException (C:\Users\Matt\Dev\reactfire-test\node_modules\jsdom\lib\jsdom\living\helpers\runtime-script-errors.js:62:24)
        at Timeout.task [as _onTimeout] (C:\Users\Matt\Dev\reactfire-test\node_modules\jsdom\lib\jsdom\browser\Window.js:396:9)
        at listOnTimeout (internal/timers.js:554:17)
        at processTimers (internal/timers.js:497:7) TypeError: this.timerId.unref is not a function
        at BackoffTimeout.unref (C:\Users\Matt\Dev\reactfire-test\node_modules\@grpc\grpc-js\src\backoff-timeout.ts:117:18)
        at new ResolvingLoadBalancer (C:\Users\Matt\Dev\reactfire-test\node_modules\@grpc\grpc-js\src\resolving-load-balancer.ts:199:25)
        at new ChannelImplementation (C:\Users\Matt\Dev\reactfire-test\node_modules\@grpc\grpc-js\src\channel.ts:242:34)
        at new Client (C:\Users\Matt\Dev\reactfire-test\node_modules\@grpc\grpc-js\src\client.ts:146:30)
        at new ServiceClientImpl (C:\Users\Matt\Dev\reactfire-test\node_modules\@grpc\grpc-js\src\make-client.ts:128:3)
        at GrpcConnection.Object.<anonymous>.GrpcConnection.ensureActiveStub (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\firestore\src\platform\node\grpc_connection.ts:90:25)
        at GrpcConnection.Object.<anonymous>.GrpcConnection.openStream (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\firestore\src\platform\node\grpc_connection.ts:175:23) 
        at PersistentListenStream.Object.<anonymous>.PersistentListenStream.startRpc (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\firestore\src\remote\persistent_stream.ts:571:28)
        at PersistentListenStream.Object.<anonymous>.PersistentStream.startStream (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\firestore\src\remote\persistent_stream.ts:443:24)
        at call (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\firestore\src\remote\persistent_stream.ts:420:16)
        at call (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\node_modules\google-closure-library\closure\goog\promise\promise.js:826:22)
        at goog.Promise.invokeCallback_ (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\node_modules\google-closure-library\closure\goog\promise\promise.js:1166:5)
        at executeCallback_ (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\node_modules\google-closure-library\closure\goog\promise\promise.js:1140:5)
        at D.call [as gc] (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\node_modules\google-closure-library\closure\goog\promise\promise.js:1111:5)
        at xc (C:\Users\Matt\Dev\reactfire-test\node_modules\@firebase\node_modules\google-closure-library\closure\goog\async\run.js:124:7)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)

      at console.error (node_modules/@testing-library/react/dist/act-compat.js:53:34)
      at VirtualConsole.<anonymous> (node_modules/jsdom/lib/jsdom/virtual-console.js:29:45)
      at reportException (node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:66:28)
      at Timeout.task [as _onTimeout] (node_modules/jsdom/lib/jsdom/browser/Window.js:396:9)

I've also raised issues elsewhere. I believe the problem is that Jest is loading Node dependencies and not the browser ones. I would be happy to find a workaround that lets me keep using create-react-app if the issues cant be fixed.

https://github.com/firebase/firebase-js-sdk/issues/4552 https://github.com/facebook/create-react-app/issues/10626

created time in 3 hours

issue closedfacebook/create-react-app

TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'

Describe the bug

When creating a react-typescript app using

npx create-react-app . --template typescript

The error:

yarn run v1.22.5
$ react-scripts start
/home/aditya/all/yt/twitter/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239
      appTsConfig.compilerOptions[option] = value;
                                          ^

TypeError: Cannot assign to read only property 'jsx' of object '#<Object>'
    at verifyTypeScriptSetup (/home/aditya/all/yt/twitter/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:239:43)
    at Object.<anonymous> (/home/aditya/all/yt/twitter/node_modules/react-scripts/scripts/start.js:31:1)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

closed time in 3 hours

aadityarajkumawat

issue commentfirebase/firebase-js-sdk

Google Sign-in not working/warning in Instagram in-app browser

Messenger browser supports no more than 1 tab at a time. So if you use signInWithPopup it removes the main page and takes you to the auth provider page which later on can't figure how to go back to the previous page. Consider using signInWithRedirect instead. It worked for me. Thanks you.... This will work in single tab browsers.. firebase.auth().signInWithRedirect(provider); And this one won't.. firebase.auth().signInWithPopup(provider);

y-yeah

comment created time in 4 hours

issue closedmillsp/ts-toolbelt

Function.AutoPath — Type instantiation is excessively deep and possibly infinite.ts(2589)

Thanks for your answer the other day!

Currently I have this issue:

Type instantiation is excessively deep and possibly infinite.ts(2589)

When using this signature:

function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

It works like a charm if I try it with a payload like so:

const doc = { name: 'n1', id: '1', filled: true, notpicked: false }
const res = pick(doc, ['name', 'filled', 'id'])

however, it gives me that infinite error when the keys array is empty:

const res = pick(doc, [])

closed time in 6 hours

mesqueeb

issue commentmillsp/ts-toolbelt

Function.AutoPath — Type instantiation is excessively deep and possibly infinite.ts(2589)

At the moment AutoPath only takes a single string:

function pick<T extends Record<string, any>, K extends string> (obj: T, path: F.AutoPath<T, K>): O.P.Pick<T, S.Split<K, '.'>>
mesqueeb

comment created time in 6 hours

issue closedmillsp/ts-toolbelt

O.P.Pick — issue with multiple nested picks from a single object

🐞 Bug Report

Describe the bug

For this signature:

function pick<T extends Record<string, any>, K extends string> (obj: T, keys: F.AutoPath<T, K>[]): O.P.Pick<T, S.Split<K, '.'>>

this works: image

however, adding a second key breaks the nested pick: image

Reproduce the bug

// REPL or a link to your repository if applicable.
// A *self-contained* demonstration of the problem.

Is it possible to use TS Toolbelt in the typescript TS Playground? If so it's easy for me to replicate this. Otherwise I can set up a branch on my package if you like.

Possible Solution

I'm not sure!

closed time in 6 hours

mesqueeb

issue commentmillsp/ts-toolbelt

O.P.Pick — issue with multiple nested picks from a single object

Yes, it works in the playground. AutoPath cannot work on arrays like this, the inference won't work. Please, set a playground up and I'll look what I can do.

mesqueeb

comment created time in 6 hours

Pull request review commentfacebook/react

Optimize: reduce double counting of isObject

 function ChildReconciler(shouldTrackSideEffects) {     // not as a fragment. Nested arrays on the other hand will be treated as     // fragment nodes. Recursion happens at the normal flow. +    let isObject = typeof newChild === 'object' && newChild !== null;+     // Handle top level unkeyed fragments as if they were arrays.     // This leads to an ambiguity between <>{[...]}</> and <>...</>.     // We treat the ambiguous cases above the same.     const isUnkeyedTopLevelFragment =-      typeof newChild === 'object' &&-      newChild !== null &&+      isObject &&       newChild.type === REACT_FRAGMENT_TYPE &&       newChild.key === null;     if (isUnkeyedTopLevelFragment) {       newChild = newChild.props.children;+      // Handle object types+      isObject = typeof newChild === 'object' && newChild !== null;

What is the profit of such a solution?

taichiyi

comment created time in 6 hours

issue commentfacebook/create-react-app

Webpack 5 support overview

I've added a CRA webpack 5 brach/draft pr for this work in case anyone want to test - https://github.com/facebook/create-react-app/pull/10656

raix

comment created time in 6 hours

PR opened facebook/create-react-app

Webpack5 update

Webpack 5 update Includes the work listed in #9994

Additional changes:

  • persistent cache
  • upgrade to dev server ´v4 (still beta)
  • terser is now included in webpack

Known issues:

  • currently the WebpackManifestPlugin is commented out due to "path undefined" error (feel free to investigate)
  • It feels like webpack emits compile twice - triggers a re print out on the screen (might be due to hook behavior change)

Things I wanted to do but left out:

  • extract loaders/plugins etc. into separate files to make the main webpack config clean / easier to read
  • allowed domains - we should allow configuration and wildcard support imho
  • print out performance stats of the build - really hard to track / compare build speeds - eg. detecting regression
  • fix the test suite or comment out failing tests - eg. the pnp test is currently failing on master not sure if this pr. makes things better or worse

Credit include @andriijas, @sebinsua and @jasonwilliams (let me know if I missed out on any)

+202 -312

0 comment

14 changed files

pr created time in 6 hours

issue commentfacebook/create-react-app

npm WARN deprecated core-js@2.6.11

me too, same thing

cseas

comment created time in 7 hours

issue closedgetsentry/sentry-javascript

Is it possible to use setContext asynchronously?

<!-- Requirements: please go through this checklist before opening a new issue -->

  • [x] Review the documentation: https://docs.sentry.io/
  • [x] Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
  • [x] Use the latest release: https://github.com/getsentry/sentry-javascript/releases
  • [ ] Provide a link to the affected event from your Sentry account

Package + Version

  • [x] @sentry/browser
  • [ ] @sentry/node
  • [ ] raven-js
  • [ ] raven-node (raven for node)
  • [ ] other:

Version:

6.0.2

Description

I'm trying to use setContext after some async code runs but it doesn't show in the performance page in my account. This doesn't work:

Sentry.init({...});

async function stall(stallTime = 3000) {
    await new Promise(resolve => setTimeout(resolve, stallTime));
}

stall().then(() => {
    Sentry.setContext("myContext", {
        "key": "value"
    });
});

However doing it synchronously does:

Sentry.init({...});

Sentry.setContext("myContext", {
    "key": "value"
});

I think this was previously discussed here #497 but it doesn't look like there was a workaround for it.

closed time in 7 hours

jahvi

push eventfirebase/firebase-js-sdk

Feiyang

commit sha 168f1d622e189f6e2f0ad6f5ad2a1d0932b77ac6

Fix a typings issue in Database exp (#4506) * import FirebaseApp from app-exp * fix lint error

view details

Yuchen Shi

commit sha 145c62bd86edc8680b5064ac6f3b99fa04a17253

Run integration tests on Node.js. (#4494) * Run integration tests on Node.js. * Update packages-exp/auth-exp/test/helpers/integration/helpers.ts

view details

Christina Holland

commit sha 938dc1a9d644a361be962aaef3f5b1af2ac7f7fa

Remove storage-types/exp (#4507)

view details

renovate[bot]

commit sha bd1691c13a813bfb8636417987aa6acb93efedbe

Lock file maintenance (#4431) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Feiyang

commit sha 70af481cd741cc3e147645b3e86f6488ab49450c

do not build storage-types (#4508)

view details

Sebastian Schmidt

commit sha 6a86a1b9be4ec92f7b77127c0956ec1f289a5c6d

Tree-Shake Repo (#4489)

view details

Christina Holland

commit sha 1003b8d91d9bb786b971a39e26bde880f69cc09a

Remove functions-types-exp and clean up stray app-types-exp (#4511)

view details

Feiyang1

commit sha 43d7520d2efd7ee77cad3332c586830c7ec24d51

Publish firebase@exp 0.900.15

view details

Christina Holland

commit sha 04b4986879c7652bfcd31d7024f6161637297d36

Add generics to httpsCallable (#4466)

view details

Feiyang

commit sha 08e2aa3ccd90d5823e68cb900f3bfb6e2af212ca

Remove remote-config-types-exp (#4496) * remove remote-config-types exp * fix remote-config-compat * remove api report for types * correct d.ts path

view details

Feiyang

commit sha 20a88da5d935fdb8c1ff38e358c84e1939145abb

remove auth-types-exp (#4487) * remove auth-types package * remove dependencies * save progress * Use named imports * fix tests * auth-compat update * remove classes from public types * fix links in comments * update auth-compat * remove problematic link * uncomment build rules * remove unnecessary renaming * remove stray reference to auth-types-exp

view details

renovate[bot]

commit sha 39a8be6f1dcfa263c79defa6fffbefc1961e61ed

Update dependency @rollup/plugin-commonjs to v17 (#4161) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Christina Holland

commit sha 97f7e38819cda74cafbb7e9a8b86fdfead47d7fc

Tree-shake RepoInfo (#4515)

view details

Sam Horlbeck Olsen

commit sha bc9f84149fe3793e7dade72f673d6365b16119ba

Movie client-side popup origin validation to _after_ popup is opened (#4514) * Make origin validation happen asynchronously from the popup * Formatting

view details

Sam Horlbeck Olsen

commit sha 02c1761854b3037a0e2b75a5cd55d2e6c7e009f1

Fix the OAuth credential logic, and add support for OIDC (#4512) * Fix oauth credential and test for OIDC * Formatting * Formatting

view details

Feiyang

commit sha 928e43933488f0685e4785af981585cf2b0253a5

fix getAuth for non browser entry points (#4519)

view details

Christina Holland

commit sha 636dd78eab0641448ed87487abf1db321a07f578

Implement analytics-compat package (#4460)

view details

Sebastian Schmidt

commit sha c3739f338d46ac470252979d9582a3e442db9806

Remove RepoManager (#4520)

view details

Feiyang

commit sha 07d6b2c425554d9290b8ddcdd6cedb7d4f3d81d0

skip problematic exports and log the errors (#4516)

view details

Feiyang

commit sha d84e137d701c43a0eae5384ad323d0990621d902

Remove messaging-types-exp (#4498) * save * save * fix tsdoc * export public types * remove the package from changeset config

view details

push time in 7 hours

push eventfirebase/firebase-js-sdk

Renovate Bot

commit sha 52c5ddc3c3890c332c2cb5be5f79f1bdc658ff95

Update all non-major dependencies

view details

push time in 7 hours

issue openedfacebook/react

Bug: error in effect cleanup function no longer catchable

<!-- Please provide a clear and concise description of what the bug is. Include screenshots if needed. Please test using the latest version of the relevant React packages to make sure your issue has not already been fixed. -->

React version: 17.0.1

Steps To Reproduce

  1. Throw in an effect cleanup
  2. Try to catch it when wrapped in act()

Link to code example: React 16 React 17

I also tested it locally and jest and couldn't catch the error as well.

The current behavior

The error is uncatchable and does not include the component stack ("The above error occurred").

The expected behavior

The error is catchable and does include the component stack i.e. React 16 behavior.

Context

I understand that the cleanup is now async but it's still flushed in act() so I would expect that an error thrown is catchable.

created time in 10 hours