profile
viewpoint

abadi199/datetimepicker 90

📅 Date and Time Picker

avh4/binwrap 26

Distribute binaries via npm

avh4/burndown-charts 5

A library for plotting burndown charts

avh4/apro 2

rubigen components for my projects (and perhaps your projects as well)

avh4/avh4-util 2

Useful things for Java

avh4/avh4.github.com 2

My github pages repository

avh4/assertj-android 1

A set of AssertJ assertion helpers geared toward testing Android.

avh4/avh4_soloist 1

Mac OSX workstation setup

avh4/avh4_workstation 1

Chef cookbook for workstation setup (See also pivotal/pivotal_workstation)

issue commentavh4/elm-format

GLIBC_2.27' not found in 0.8.4

Also note that I want to switch the linux binaries to be statically linked (see https://github.com/avh4/elm-format/issues/589) which I think would also solve this issue once that can be done.

sporto

comment created time in 5 hours

issue commentavh4/elm-format

GLIBC_2.27' not found in 0.8.4

Adding to the notes:

apparently the default node docker images are based on buildpack-deps:stretch (Debian 9), but there's also a corresponding -buster (Debian 10) version of each. And as sporto notes, apparently stretch has glibc-2.24.

sporto

comment created time in 5 hours

issue commentavh4/elm-format

GLIBC_2.27' not found in 0.8.4

Hmm, not that this is necessarily a viable solution, but apparently there are buster variants of the node docker images.

node:12.14 fails with the GLIBC_2.27 not found error:

docker run -it node:12.14 /bin/sh -c "npm i elm-format && node_modules/.bin/elm-format --help"

node:12.14-buster works:

docker run -it node:12.14-buster /bin/sh -c "npm i elm-format && node_modules/.bin/elm-format --help"
sporto

comment created time in 5 hours

issue commentavh4/elm-format

GLIBC_2.27' not found in 0.8.4

Thanks, there was a report of this on slack too.. Can you tell which version of glibc is available? 2.27 was apparently released in Feb 2018 which seems like it should be old enough to be supported most places. But also I didn't do anything specific to set the glibc version either (and the elm-format linux binaries are built in a docker container).

I don't know that much about modern linux, so if anyone has advice here (esp w/r to haskell), let me know!

sporto

comment created time in 5 hours

issue commentavh4/elm-format

Single-line case-expressions branches?

(split off timjs's suggestion for top-level and let declarations to https://github.com/avh4/elm-format/issues/708 )

rtfeldman

comment created time in 14 hours

issue openedavh4/elm-format

Single-line let declarations (and top-level declarations)

Should single-line let declaractions (and possibly also top-level declaractions) be allowed? If so, what should the rules related to that be?

  • One proposal from https://github.com/avh4/elm-format/issues/507#issuecomment-426995482 is to only allow it for declarations that have no arguments

created time in 14 hours

delete branch avh4/nixpkgs

delete branch : elm-format-0.8.4

delete time in 16 hours

issue commentavh4/elm-format

problem using elm-format in Alpine docker image

oh, great, thanks for the link. I tried that ghc option earlier and got "/usr/bin/ld.gold: error: /usr/lib/gcc/x86_64-linux-gnu/9/crtbeginT.o: requires dynamic R_X86_64_32 reloc against 'TMC_END' which may overflow at runtime; recompile with -fPIC" but looking at that docker file you linked to, I'm realizing the fix for that is to build it from an alpine image that has all the c libs prepped for static linking.

woylie

comment created time in a day

pull request commentavh4/elm-format

Never transform links to autolinks

0.8.4 is now released with this fix: https://github.com/avh4/elm-format/releases/tag/0.8.4

rlefevre

comment created time in a day

issue commentavh4/elm-format

Negative hex numbers get corrupted

0.8.4 is now released with this fix: https://github.com/avh4/elm-format/releases/tag/0.8.4

Janiczek

comment created time in a day

issue commentavh4/elm-format

Multiline tuples in type declarations are not allowed

0.8.4 is now released with this fix: https://github.com/avh4/elm-format/releases/tag/0.8.4

edkv

comment created time in a day

issue commentavh4/elm-format

Backticks-within-backticks in documentation is destroyed by elm-format

0.8.4 is now released with this fix: https://github.com/avh4/elm-format/releases/tag/0.8.4

malaire

comment created time in a day

create barnchavh4/nixpkgs

branch : elm-format-0.8.4

created branch time in a day

push eventavh4/elm-format

Rémi Lefèvre

commit sha 1e57bfee1e18ddf94d72bd4f556d5a1bb2e684ba

Never transform links to autolinks This fixes one bug raised in https://github.com/avh4/elm-format/issues/339 that was causing links to modules like [Module](Module) being transformed to invalid autolinks like <Module>.

view details

Andrew McNutt

commit sha e554da8f2d795fd2c20d1b1b01ef11afc54aab51

VSCode elm language support is depricated See: https://marketplace.visualstudio.com/items?itemName=sbrink.elm This change updates the link to point the same link as shown in the now depreciated marketplace page

view details

Aaron VonderHaar

commit sha 5c7fbad2a5d212a5d7e14944f344ed72bb79b466

Update publishing instructions

view details

Aaron VonderHaar

commit sha e3064d736071c58ee19bf0018c269482e4f47625

Bump version to 0.8.4

view details

Aaron VonderHaar

commit sha 595b95459d416eb16b47018fa534566dae0a59e8

Merge remote-tracking branch 'origin/main' into release/0.8.4

view details

Aaron VonderHaar

commit sha 7c6924a3c85a9c3bad48e6840432d03c23149b5e

Build release binaries on release branches

view details

Aaron VonderHaar

commit sha 0a8f88387bf66c1990e94fdd223ca6e3d07a9957

Build CI on all branches

view details

Aaron VonderHaar

commit sha 8569fa05a795d0532e3d55661aa7119a0f14dada

Update 'Build release' workflow

view details

Aaron VonderHaar

commit sha 5f75c881322470a3eda662843504ba82d22cc024

Give workflow jobs different names

view details

Aaron VonderHaar

commit sha ad6d39a30a27e5228fb7749992d88093be5fcf58

Update 'Building from source' instructions

view details

Aaron VonderHaar

commit sha 74a2bcb69eb2defe37d2af9c4c0e3b2a5a71375b

Don't turn markdown links into autolinks that would be invalid

view details

Aaron VonderHaar

commit sha a061c9f5b0498466344d435ab124c1dc925cbba0

Merge branch 'fix-markdown-module-links' of https://github.com/rlefevre/elm-format into safe-autolinks

view details

Aaron VonderHaar

commit sha c83f19fc1cc6ba82ba0b0f92a72f1e662033db18

Merge pull request #700 from avh4/safe-autolinks Safe autolinks

view details

Aaron VonderHaar

commit sha 30c7a1f14b07d9e51cb049bb75e696be09b49c58

No need to build Mac CI; it's close enough to Linux

view details

Aaron VonderHaar

commit sha 76742e705aff32a220febc58fcbbf93c7e75f047

Update release notes

view details

Aaron VonderHaar

commit sha 50adeb1cb64be6ad919824b44799177a1a1f3599

Update elm-vim instructions to be more clear for advanced users

view details

Aaron VonderHaar

commit sha 5f81628c856fae039e22eb2c476a8cd5c60f3398

Update emacs installation instructions

view details

Aaron VonderHaar

commit sha 20bd9bde5bb1cb4884e41d1521c546a857dd4225

Merge branch 'patch-1' of https://github.com/mcnuttandrew/elm-format into vim-instructions

view details

Aaron VonderHaar

commit sha 9adc4079e4c3d329372ca99fce785ec36b2f7f78

Update Visual Studio Code installation instructions

view details

Aaron VonderHaar

commit sha 6995f9bbe86901fc6439e166e358c51479f6eaf5

Update JetBrains installation instructions

view details

push time in a day

delete branch avh4/elm-format

delete branch : release/0.8.4

delete time in a day

PR merged avh4/elm-format

Never transform links to autolinks bug

This fixes one bug raised in https://github.com/avh4/elm-format/issues/339 that was causing links to modules like [Module](Module) being transformed to invalid autolinks like <Module>.

+43 -17

1 comment

4 changed files

rlefevre

pr closed time in a day

PR merged avh4/elm-format

VSCode elm language support is deprecated documentation

See: https://marketplace.visualstudio.com/items?itemName=sbrink.elm This change updates the link to point the same link as shown in the now depreciated marketplace page

+1 -1

3 comments

1 changed file

mcnuttandrew

pr closed time in a day

PR merged avh4/elm-format

Prepare 0.8.4 release

TODO:

  • [x] review open PRs for anything else to include
  • [x] npm release
  • [ ] nixpkgs release https://github.com/NixOS/nixpkgs/pull/98617
+836 -515

1 comment

38 changed files

avh4

pr closed time in a day

issue closedavh4/elm-format

automate build of Windows binaries

What is the best way to do this?

  • Windows docker containers? http://blog.contino.io/getting-started-with-windows-containers
  • Cross-compilation with ghc?

closed time in a day

avh4

issue commentavh4/elm-format

automate build of Windows binaries

Fixed in https://github.com/avh4/elm-format/pull/694 and https://github.com/avh4/elm-format/pull/705

(Though it would still be preferable to figure out a way to do cross-compilation inside of a linux docker container, but that'll be for a future issue :) )

avh4

comment created time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 3e57641b4992a7c696a06f5bc81d72cbb583bba7

Update packaging scripts for Windows binaries

view details

Aaron VonderHaar

commit sha a25d810c2bdab98231a5217eb832aa94f288d8ff

Update nix packaging script

view details

push time in a day

PR opened NixOS/nixpkgs

elm-format: 0.8.3 -> 0.8.4

<!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions -->

Motivation for this change

New release of elm-format: https://github.com/avh4/elm-format/releases/tag/0.8.4

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ ] NixOS
    • [ ] macOS
    • [x] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
+8 -20

0 comment

2 changed files

pr created time in a day

created tagavh4/elm-format

tag0.8.4

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

created time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 5bd4fbe591fe8b456160c180cb875ef60bc57890

Update changelog

view details

push time in a day

issue openedavh4/elm-format

Make new binwrap release

See https://github.com/avh4/binwrap/pulls

created time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 837725f7dee92e721b9e06172f91b64e6d94bf33

Workaround for github CI corrupting tag annotations

view details

Aaron VonderHaar

commit sha ac1553f92bce50b3b1e4d942ac77764f1fcce2e5

Update linux packaging script

view details

Aaron VonderHaar

commit sha 6152590eb3216fe18f09a50c63e8b9e685f74265

Remove unused files

view details

Aaron VonderHaar

commit sha 06d6d400d6afabda29450abfe6438248fdfc9973

Add shake dependencies targets

view details

push time in a day

created tagavh4/elm-format

tag0.8.4-rc4

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

created time in a day

created tagavh4/elm-format

tag0.8.4-rc3

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

created time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha f5829af7386d331b3861fad4c1d1976ec7c52467

Remove unused files

view details

Aaron VonderHaar

commit sha b4109ab6adc1496c0ed27e700e136060c58a67ab

Update publishing instructions

view details

Aaron VonderHaar

commit sha 19d2fde45e6c106b767a55dcd06980c44d02553d

Check git describe output

view details

push time in a day

created tagavh4/elm-format

tag0.8.4-rc2

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

created time in a day

delete branch avh4/elm-format

delete branch : release/sign-artifacts

delete time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 66d6c12700bdfc6574aca9f582b8c7923e7a013c

Build release CI: sign artifacts

view details

Aaron VonderHaar

commit sha e22a3d8633d10d4b6094ebd1921e65c2fcd5cd2e

Clean up Build release CI

view details

Aaron VonderHaar

commit sha 6308c67b4a32f8095b047394e76f921d5e81550c

Show test output

view details

Aaron VonderHaar

commit sha b9e8963cde90b28c6acc09fdacef6a3f685fcc6a

Update collect_files.sh to validate signatures

view details

Aaron VonderHaar

commit sha aa996d1e773bc126d04faeb6f4c59e98bd9677a6

Update publishing instructions

view details

Aaron VonderHaar

commit sha c4449dfd4de884dc2fdad4a061644a563d397666

Merge pull request #706 from avh4/release/sign-artifacts Build release CI: sign artifacts

view details

push time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha b9e8963cde90b28c6acc09fdacef6a3f685fcc6a

Update collect_files.sh to validate signatures

view details

Aaron VonderHaar

commit sha aa996d1e773bc126d04faeb6f4c59e98bd9677a6

Update publishing instructions

view details

push time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha e22a3d8633d10d4b6094ebd1921e65c2fcd5cd2e

Clean up Build release CI

view details

Aaron VonderHaar

commit sha 6308c67b4a32f8095b047394e76f921d5e81550c

Show test output

view details

push time in a day

PR opened avh4/elm-format

Build release CI: sign artifacts
+12 -0

0 comment

1 changed file

pr created time in a day

create barnchavh4/elm-format

branch : release/sign-artifacts

created branch time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha b644374aed8cefb4034863493f780f615392f24d

Update docker build

view details

Aaron VonderHaar

commit sha e3e8f95d3f0f53075554ea89048c4aae6883aae2

Update release notes

view details

push time in a day

delete branch avh4/elm-format

delete branch : release/drop-stack

delete time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 9aa944e235dd09f89083eeb4e98c8bd2e8ec616c

Switch from stack to cabal-install

view details

Aaron VonderHaar

commit sha 9473c42dbfff3620c8712654e759a4800693b16c

Don't require ghcup in build.sh

view details

Aaron VonderHaar

commit sha fbe7a817d05c874923282871c59e3e35bd0fd17a

fix CI

view details

Aaron VonderHaar

commit sha 1f5c8e7bdaa2f6b9878d7a5cc607e4c935b62375

Merge pull request #705 from avh4/release/drop-stack Switch from stack to cabal-install

view details

push time in a day

PR merged avh4/elm-format

Switch from stack to cabal-install
+237 -291

0 comment

15 changed files

avh4

pr closed time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha fbe7a817d05c874923282871c59e3e35bd0fd17a

fix CI

view details

push time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha bc771d0b19844966150614a6afeba3042e9d29f0

WIP: fix CI

view details

push time in a day

issue openedactions/setup-haskell

ghcup set is not run when the desired ghc version is found in the cache

I am having this issue on a MacOS github hosted runner with this action:

    - uses: actions/setup-haskell@v1.1
      name: Setup Haskell
      id: setup-haskell
      with:
        ghc-version: 8.8.4

The output from setup-haskell is:

Preparing to setup a Haskell environment
Resolved latest to 3.2.0.0
▼ Installing ghc version 8.8.4
  Found ghc 8.8.4 in cache at path /Users/runner/.ghcup/ghc/8.8.4/bin. Setup successful.
▶︎ Installing cabal version 3.2.0.0
▶︎ Setting up cabal

But running ghcup list later in the workflow shows

   Tool  Version     Tags                                 Notes
✗  ghc   7.10.3      base-4.8.2.0                              
... (many other version) ...
✗  ghc   8.8.3       base-4.13.0.0                             
✓  ghc   8.8.4       recommended,base-4.13.0.0        
✗  ghc   8.10.1      base-4.14.0.0                             
✔✔ ghc   8.10.2      latest,base-4.14.1.0             
✗  cabal 2.4.1.0                                               
✗  cabal 3.0.0.0                                               
✔✔ cabal 3.2.0.0     latest,recommended      
✗  cabal 3.4.0.0-rc3 prerelease                       
✗  ghcup 0.1.11      latest,recommended      

and any ghc commands use ghc-8.10.2 instead of the requested version (8.8.4).

created time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 5f9525128e98b2924bc0cf52e8fffdefec2d70e7

WIP: fix CI

view details

push time in a day

push eventavh4/elm-format

Aaron VonderHaar

commit sha 9dfa85ac6c2a1027393265480720b620431eee0c

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 6f834926b02bff0f0b35ed0b15c780bb5b3f4aea

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 65b2dbeade62113c5bce02959f2ed3015a7463ec

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 63e45c084589aa8517c5dc2908edd625bb7a6468

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 1546b37ec33760ed2ab516a10fafa35ebae7e3d7

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 03fc2d023404d2bd1f11b5b9cce8d015dc029881

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 9f23e37bd8bca9123fe4ee87fad1da7cebf19960

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 12e2c45346a70c5bc6b26f8fb384ccd6b3733379

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha db268b7ccbbf50aab1b19f17eaae4782a4798e2e

WIP: fix CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 23abc0aa5502294683251f453e953af83b228083

github CI: disable cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 068192c6667ce0bfe99fc6a225daa6cba914dfd9

github CI: disable cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha c1fe4e9abbb3a52c9e9d9ae0b4cc957a1346fd01

github CI: disable cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha a9e27a87d8e36a25f3491306ecc5d2e6a741c65c

github CI: disable cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 14052cd81ca27e52d26c4fb7f53657218e916fde

github CI: disable cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 2697c82a7136b42894146ba26ffabf25c11c0483

fix Windows CI

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 9473c42dbfff3620c8712654e759a4800693b16c

Don't require ghcup in build.sh

view details

Aaron VonderHaar

commit sha 10f832f37be3f98ddff9d681ef0dd2f67d70dadc

fix Windows CI

view details

push time in 2 days

PR opened avh4/elm-format

Switch from stack to cabal-install
+192 -285

0 comment

15 changed files

pr created time in 2 days

create barnchavh4/elm-format

branch : release/drop-stack

created branch time in 2 days

delete branch avh4/elm-format

delete branch : release/package-with-shake

delete time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 14d5ea9ee140e6bfdb1f08001cc0ba20137fcf97

Update version number in sthe style guide

view details

Aaron VonderHaar

commit sha 11f1c35e4ece6e87d4c06d363dc7cd4ef2bfe4ab

Update to stack 2.3.1

view details

Aaron VonderHaar

commit sha 572822df98599f86a1e35d14b61f40545b0c5ed2

Add shake dist target to build optimized binary

view details

Aaron VonderHaar

commit sha d5d14eca0bfd3e27d57a444c5981cf4d260e8e35

shake dist builds stripped binary for current platform

view details

Aaron VonderHaar

commit sha f2f777f7fefbf13564100da888d28b29dc8f8796

Build tgz files with shake

view details

Aaron VonderHaar

commit sha 98839929fec3034c2cfff08273c5bb14ff10682e

Handle Mac and Windows platforms in shake dist

view details

Aaron VonderHaar

commit sha b50af49bdfdef795d111dc6a88545865506302f6

Bump CI cache

view details

Aaron VonderHaar

commit sha ea3f87f9cb586eb58c72f4626160ac673da07578

github CI: build more dependencies before building the project

view details

Aaron VonderHaar

commit sha 283bfb794c1a8aba5d09d171ccbcfd41550b3629

Build release CI builds stack dist target

view details

Aaron VonderHaar

commit sha 4f40d6546a5f74a08be294a749d39c0a5a2bf16b

Bump CI cache

view details

Aaron VonderHaar

commit sha ab38762a403f9e3c4512a705cfb4af0427fa270a

github CI: add retry to stack build --only-snapshot

view details

Aaron VonderHaar

commit sha d2ba1d87bd8492afda860e0b7395d67d212edd35

github CI: add retry to stack install shake

view details

Aaron VonderHaar

commit sha 47314444bd9cbf0f3bee3249a14161f85a629b75

Build release CI: remove stack cache

view details

Aaron VonderHaar

commit sha bc0d72340bf7b8deca4be53594b64512552e6052

Build zip files with shake

view details

Aaron VonderHaar

commit sha 73d06b9ef855008866a549cd872f2940dbc5d025

Remove unused imports

view details

Aaron VonderHaar

commit sha 587a5ad8e4959c56cdd5d7e6e18cb40edef86c79

Build release CI: upload artifacts created by shake dist

view details

Aaron VonderHaar

commit sha ed5eb6c8276fa37484108c1beba2f4a08a567964

Build release CI: ensure latest tag is fetched

view details

Aaron VonderHaar

commit sha f281d96a8c89f807701e3fe0a953881d61104c97

github CI: Increase retries for stack install

view details

Aaron VonderHaar

commit sha d2523e37feaf4a376b05089c18753571974beaab

Merge pull request #704 from avh4/release/package-with-shake package with shake

view details

push time in 2 days

PR merged avh4/elm-format

package with shake packaging
+93 -60

0 comment

10 changed files

avh4

pr closed time in 2 days

issue commentcommercialhaskell/stack

Timeout when accessing `casa.fpcomplete.com`

The casa.fpcomplete.com server seems quite bad today: I've had to make my CI builds retry stack install up to 10 times to start getting successful builds due to the POST /v1/pull timing out. I also had this happen locally with stack install shake on a clean machine, and I had to retry 3 times before it completed successfully.

Here's an example build where stack build --only-snapshot took 5 retries on windows, and 5 retries on mac: https://github.com/avh4/elm-format/actions/runs/267891714 (to see the logs, click into either build job in the left sidebar, and then expand the "stack build --only-snapshot" step).

brandon-leapyear

comment created time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha f281d96a8c89f807701e3fe0a953881d61104c97

github CI: Increase retries for stack install

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha ed5eb6c8276fa37484108c1beba2f4a08a567964

Build release CI: ensure latest tag is fetched

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 73d06b9ef855008866a549cd872f2940dbc5d025

Remove unused imports

view details

Aaron VonderHaar

commit sha 587a5ad8e4959c56cdd5d7e6e18cb40edef86c79

Build release CI: upload artifacts created by shake dist

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha bc0d72340bf7b8deca4be53594b64512552e6052

Build zip files with shake

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 47314444bd9cbf0f3bee3249a14161f85a629b75

Build release CI: remove stack cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha d2ba1d87bd8492afda860e0b7395d67d212edd35

github CI: add retry to stack install shake

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha ab38762a403f9e3c4512a705cfb4af0427fa270a

github CI: add retry to stack build --only-snapshot

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 4f40d6546a5f74a08be294a749d39c0a5a2bf16b

Bump CI cache

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha ea3f87f9cb586eb58c72f4626160ac673da07578

github CI: build more dependencies before building the project

view details

Aaron VonderHaar

commit sha 283bfb794c1a8aba5d09d171ccbcfd41550b3629

Build release CI builds stack dist target

view details

push time in 2 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha b50af49bdfdef795d111dc6a88545865506302f6

Bump CI cache

view details

push time in 3 days

push eventavh4/elm-format

Aaron VonderHaar

commit sha 98839929fec3034c2cfff08273c5bb14ff10682e

Handle Mac and Windows platforms in shake dist

view details

push time in 3 days

PR opened avh4/elm-format

package with shake packaging
+48 -6

0 comment

5 changed files

pr created time in 3 days

create barnchavh4/elm-format

branch : release/package-with-shake

created branch time in 3 days

issue commentavh4/elm-format

problem using elm-format in Alpine docker image

I tried compiling a static linux binary, but got this error requires dynamic R_X86_64_32 reloc against '__TMC_END__' which may overflow at runtime; recompile with -fPIC, but adding -fPIC to the gcc options didn't fix it. I think this is going to take quite a bit more work to figure out, so I'm not gonna block the 0.8.4 release on it.

woylie

comment created time in 3 days

issue closedavh4/elm-format

are there incorrect things happening with square brackets in the doc comments?

In 0.8.4-rc1, the following was reported (a weird change to some admittedly-invalid markdown):

Example from slack:

{-| conditionalBool display fields based on the boolean value of another field.
conditionalBool "inventory.fruit"
[ ( True
, txt "How many apples?" "num_apples" )
)
]
-}
conditionalBool =
    "whatever"

:arrow_down:

{-| conditionalBool display fields based on the boolean value of another field.
conditionalBool "inventory.fruit"
[ ( True
, txt "How many apples?" "num\_apples" )
)
][ ( True
, txt "How many apples?" "num_apples" )
)
]
-}
conditionalBool =
    "whatever"

This seems to be related to https://github.com/avh4/elm-format/pull/700 though I didn't realize that would affect reference links, and also should this even be parsing as a reference link when there are newlines in the square brackets?

closed time in 3 days

avh4

issue commentavh4/elm-format

are there incorrect things happening with square brackets in the doc comments?

Okay, learned about the details of markdown, and determined that the current behavior is correct: square brackets, even when containing newlines, will be parsed as reference links (in this case, a shortcut reference link); then, elm-format will escape confusing characters in the link text to make sure the user knows when those characters won't have special meaning; but elm-format must not change the link label because the link reference definitions are matched with the labels before backlash escaping is processed.

Reference: https://spec.commonmark.org/0.29/#reference-link

avh4

comment created time in 3 days

issue openedavh4/elm-format

Markdown reference labels should be normalized

See rules here: https://spec.commonmark.org/0.29/#example-537

created time in 3 days

issue openedavh4/elm-format

are there incorrect things happening with square brackets in the doc comments?

In 0.8.4-rc1, the following was reported (a weird change to some admittedly-invalid markdown):

Example from slack:

{-| conditionalBool display fields based on the boolean value of another field.
conditionalBool "inventory.fruit"
[ ( True
, txt "How many apples?" "num_apples" )
)
]
-}
conditionalBool =
    "whatever"

:arrow_down:

{-| conditionalBool display fields based on the boolean value of another field.
conditionalBool "inventory.fruit"
[ ( True
, txt "How many apples?" "num\_apples" )
)
][ ( True
, txt "How many apples?" "num_apples" )
)
]
-}
conditionalBool =
    "whatever"

This seems to be related to https://github.com/avh4/elm-format/pull/700 though I didn't realize that would affect reference links, and also should this even be parsing as a reference link when there are newlines in the square brackets?

created time in 6 days

delete branch avh4/elm-review-unused

delete branch : patch-1

delete time in 6 days

PR closed jfmengels/elm-review-unused

TEST: DO NOT MERGE; try elm-format 0.8.4-rc1

This is just a hack to try out the rc elm-format. This hack shouldn't be merged, as the elm-format dependency can be updated normally once it is officially published.

+7 -0

3 comments

1 changed file

avh4

pr closed time in 6 days

pull request commentjfmengels/elm-review-unused

TEST: DO NOT MERGE; try elm-format 0.8.4-rc1

I think I'll just clone the repo and try it locally :D

avh4

comment created time in 6 days

issue commentavh4/elm-format

Bugs with two consecutive lists in doc comment

oh, hmm, did you check with an actual published elm package? or only with elm-doc-preview so far?

malaire

comment created time in 6 days

pull request commentjfmengels/elm-review-unused

TEST: DO NOT MERGE; try elm-format 0.8.4-rc1

oh, looks like github actions doesn't use the new workflow in the build for this branch :cry:

avh4

comment created time in 7 days

push eventavh4/elm-review-unused

Aaron VonderHaar

commit sha 588f50dd7b54cf1f4fbbcf5b33924fcf9f70a416

TEST: DO NOT MERGE; try elm-format 0.8.4-rc1

view details

push time in 7 days

pull request commentavh4/elm-format

Prepare 0.8.4 release

To Elm slack:

well I no longer have access to the NoRedInk codebase :slightly_smiling_face: so I guess I should ask for help testing the elm-format release. If you want to help, just run it on your project and lmk if there's anything weird. (this is a minor release, so there should be no formatting changes unless related to a bug fix). Here's 0.8.4-rc1: linux: https://ipfs.globalupload.io/QmPoDMWqhsnddeb2qRPD6eoYFNhQrMyJhUkiggyMk1zp8h (sorry, it's a tgz inside a zip) mac: https://ipfs.globalupload.io/Qmesb3Sxg6VEbCko4PS3y5X8R9iRdBdNM6YfBkTEP5dSEK (sorry, it's a tgz inside a zip) windows: https://ipfs.globalupload.io/QmRVUH7sy4Z6dsqqTty7TvxdhyxKSAC6onyVS1httytyuz changelog: https://github.com/avh4/elm-format/blob/0.8.4-rc1/CHANGELOG.md#084

avh4

comment created time in 7 days

created tagavh4/elm-format

tag0.8.4-rc1

elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide

created time in 7 days

issue commentavh4/elm-format

Elm format changes large integer literals

okay, thanks! I think I'm gonna punt on this for 0.8.4, and look at this (and the related float issue #680 in 0.8.5)

harrysarson

comment created time in 7 days

issue commentavh4/elm-format

Elm format changes large integer literals

oh, I just realized... can elm-review actually report large ints? Because elm-review rules are written in Elm and executed as javascript, so it probably won't be able to detect overly large ints because those will get rounded down by nodejs before elm-review sees them?

harrysarson

comment created time in 7 days

PR closed avh4/elm-format

Reviewers
Suggest simplify test running instructions documentation

I noticed that the step stack install shake was duplicated under both headings, so this is an attempt to simplify. Does that make sense?

+2 -1

0 comment

1 changed file

objarni

pr closed time in 7 days

delete branch avh4/elm-format

delete branch : master

delete time in 7 days

more