profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ashkan18/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ashkan Nasseri ashkan18 Artsy New York

ashkan18/colorify 1

See your Spotify playlists in colors

ashkan18/Convey 1

Alternative Fact Generator

ashkan18/absinthe 0

The GraphQL toolkit for Elixir

ashkan18/alexa-app 0

A framework for Alexa (Amazon Echo) apps using Node.js

ashkan18/APR 0

Artsy Public Radio

ashkan18/aprb 0

Artsy public radio notifications in Slack.

ashkan18/artsy-auth 0

Ruby Gem for adding Artsy's omniauth based authentication to your app.

created tagartsy/aprd

tagproduction--2021-06-18--21-05-02

Artsy's Real-time Slack Notification Service (aka Artsy Public Radio)

created time in 6 hours

push eventartsy/aprd

Tanjie McMeans

commit sha 828a169370e36befdc7318588c87e3654dd0a49d

doc: remove justin from point people on README

view details

artsy-peril[bot]

commit sha 5bce3e3b3c3582ed515ad2794e99e4427c7646c9

doc: remove Justin from point people on README (#172) doc: remove Justin from point people on README

view details

Artsy

commit sha 76102933fd8dd6ba3a0d3db7fc72e1550034981a

Merge pull request #173 from artsy/staging

view details

push time in 6 hours

delete branch artsy/aprd

delete branch : staging

delete time in 6 hours

PR merged artsy/aprd

Deploy

This is an automatically generated release PR!

+1 -3

1 comment

1 changed file

artsyit

pr closed time in 6 hours

push eventartsy/eigen

Dima Tretyak (Dzmitry Tratsiak)

commit sha 67da6a9bfc72cc29b1a24d902e1337b5f3e95544

fix: correct round cm values during inch convert (#4993) * fix: round cm values during convert inches * fix: eslint errors * feat: pass optional arg for round values in inToCm

view details

push time in 11 hours

delete branch artsy/eigen

delete branch : dimatretyak/fix/correct-convert-in-to-cm

delete time in 11 hours

PR merged artsy/eigen

Reviewers
fix: correct round cm values during inch convert

The type of this PR is: FIX

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

Rounding the value when converting from inches to centimeters globally

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- 💡 This checklist is experimental. MX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have tested my changes on iOS and Android.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [ ] I have added a CHANGELOG.yml entry or my changes do not require one.
+17 -7

3 comments

3 changed files

dimatretyak

pr closed time in 11 hours

startedaesmail/kaffy

started time in 11 hours

push eventartsy/reaction

Renovate Bot

commit sha b693131c6d7a2771512cec815fa24ac8e6f2b415

Update dep @artsy/lint-changed from 3.1.0 to v3.3.0

view details

push time in 11 hours

pull request commentartsy/lint-changed

Update dep typescript from 4.3.3 to v4.3.4

<!-- GITHUB_RELEASE COMMENT: released --> :rocket: PR was released in v3.3.0 :rocket:

renovate[bot]

comment created time in 11 hours

pull request commentartsy/lint-changed

UPDATE iterating logic

<!-- GITHUB_RELEASE COMMENT: released --> :rocket: PR was released in v3.3.0 :rocket:

RecuencoJones

comment created time in 11 hours

created tagartsy/lint-changed

tagv3.3.0

Lint files that have changed since master

created time in 11 hours

push eventartsy/lint-changed

Artsy

commit sha 847b41928967047efc8babe082c64775656f2b7b

Update CHANGELOG.md [skip ci]

view details

Artsy

commit sha d74fb985ea2540262598092f2ff62a7b6feb9af9

Bump version to: 3.3.0 [skip ci]

view details

push time in 11 hours

push eventartsy/lint-changed

Recuenco, David

commit sha 31d2b662abdd36aa6900b063f48a1fda017bc331

UPDATE iterating logic

view details

Recuenco, David

commit sha 57a9a506a6e25cc74a5867f7907bb31ab2326806

RESTORE p-limit usage

view details

Christopher Pappas

commit sha db664b9b2625fbaba2c7cfb513f3a905daa34aa9

Merge pull request #43 from RecuencoJones/master UPDATE iterating logic

view details

push time in 11 hours

PR merged artsy/lint-changed

UPDATE iterating logic Version: Minor

Hey again!

After digging a bit more into the logic for iterating globs and commands I noticed some issues with it:

  • All commands would be ran for a file even if some previous command failed
  • Not all files are awaited to be executed before exiting

I've changed it to use Promise.all and for-of so all executions are properly awaited even though executed in parallel, this seems to make p-each-series unnecessary.

Please, let me know what you think about it!

+29 -38

0 comment

3 changed files

RecuencoJones

pr closed time in 11 hours

Pull request review commentartsy/lint-changed

UPDATE iterating logic

     "await-to-js": "^2.1.1",     "kleur": "^3.0.3",     "micromatch": "^4.0.2",-    "p-each-series": "^2.1.0",

Thank you!

RecuencoJones

comment created time in 11 hours

pull request commentartsy/eigen

[WIP] feat: convert saved search criteria to filter params

<!-- 0 failure: 0 warning:

1 markdown notices DangerID: danger-id-Peril; -->

Hi there! :wave:

We're trialing semantic commit formatting which has not been detected in your PR title.

Refer to this RFC and Conventional Commits for PR/commit formatting guidelines. <p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 8fde6a0b5ec3834090a9f71a3b436be7cc9c3f80 </p>

dimatretyak

comment created time in 12 hours

push eventartsy/eigen

Dima Tretyak

commit sha 8fde6a0b5ec3834090a9f71a3b436be7cc9c3f80

fix: return previous shape of Aggregations

view details

push time in 12 hours

push eventartsy/eigen

Dima Tretyak

commit sha 4acf367c690cb464de6a713c422dc1683e1b8f84

docs: add task name in changelog

view details

push time in 12 hours

push eventartsy/eigen

artsyit

commit sha aaacb1fa9f6b2c5a5b9122716095090a454b5a74

Update metaphysics schema

view details

artsy-peril[bot]

commit sha 494c5fa66550d25469f72b04efc0942e2162f08a

Update metaphysics schema (#4990) Update metaphysics schema

view details

Siarhei Krauchonak

commit sha 8f71d6d35f3846702402bc81dbbfec26788ebec5

fix: Invalid user name + acronym for country name (PX-4241) and OrderSummary fixes (PX-4212) (#4985) * Country name, paddings, shipping address fixes * Tests fix * Shipping name fix Co-authored-by: Serge0n <siarhei.krauchonak@artsymail.com>

view details

artsyit

commit sha 05fbca739630ee3224a64b15a7bb65d58859e6af

Update metaphysics schema

view details

artsy-peril[bot]

commit sha 28b4e7fa8e102b77cfa31eec5b4704e1bab852da

Update metaphysics schema (#4991) Update metaphysics schema

view details

Dima Tretyak

commit sha 3470f91dce29073a58ac3d75589f47eec73eb983

Add parse price range label helper

view details

Dima Tretyak

commit sha 28d9b2315130b7531549d1c74ff24bf6ae7254dc

Add parsers for saved search logic

view details

Dima Tretyak

commit sha fdf7e1ceb4844410b6d8f3f9ba169849942ff612

Improve code readability for parseSizeForFilterParams

view details

Dima Tretyak

commit sha 8a1621d0b7a91e2fa83d00d5e1caa0b7fd4a80d2

Add parser for colors from search criteria

view details

Dima Tretyak

commit sha c2a7e27dc76742334b8d29118ff61a8f94ff67e6

Add parser for aggregations names

view details

Dima Tretyak

commit sha af2b83599540fcb56a0528fe96201fb436e37598

Add parser for attributions

view details

Dima Tretyak

commit sha b3b67404335d3e85178f7f76bf28ed4d9906c39d

Add parser for ways to buy

view details

Dima Tretyak

commit sha bee7f1c777528f59857c42f08873326f5b5e1d22

Update tests for price parser

view details

Dima Tretyak

commit sha 4360798a0ff7e317fa68a960abf5e15d0b8d955f

Add parser for search criteria

view details

Dima Tretyak

commit sha ada14e50bc45d31bafcf1ae0fcbb57645c33c04c

Rename parser to converters

view details

Dima Tretyak

commit sha 86d9bd9328482c6230829eac16bf5c3ae9b0675d

Use price range label helper for Price filter

view details

Dima Tretyak

commit sha 8c6af0483db7a53e4b44112cc5f32d964abe5392

refactor!: improve code readability

view details

Dima Tretyak

commit sha 13d3bdec6221f9c0a0ad43931c84b75e905cb130

feat: extract color names only from avaialable in aggregation

view details

Dima Tretyak

commit sha e33756ad43d8ab1cdad16934ddfc383a8a65d4b1

feat: extract from agggregation only values

view details

Dima Tretyak

commit sha 66051a2c6eac525e5a888255bd22a343d806c325

feat: add converter for filter param for major periods

view details

push time in 12 hours

push eventartsy/eigen

Dima Tretyak

commit sha 67332df3ba6ff4fa88cfcc528613eedbbbcea299

feat: add converter for filter param for major periods

view details

push time in 12 hours

push eventartsy/eigen

nastassia

commit sha c57b02e4b5717e3776b92932e5e795aa91c970e2

Removed negative margin of empty results block, added returning separator only when there is no artworks

view details

push time in 12 hours

PullRequestEvent

push eventartsy/eigen

Dima Tretyak

commit sha 3726ee7d21303d0dbece3014e87e5d13f6f10ab4

feat: pass optional arg for round values in inToCm

view details

push time in 12 hours

pull request commentartsy/eigen

fix: correct round cm values during inch convert

Could also add an option to round and default it to true

dimatretyak

comment created time in 13 hours

push eventartsy/eigen

edez1t

commit sha 4f2f3355bf77642f3c425991afdbef42e57c067d

fix auth

view details

push time in 13 hours

PR closed artsy/eigen

Reviewers
fix: correct round cm values during inch convert

The type of this PR is: FIX

<!-- Bugfix/Feature/Enhancement/Documentation -->

<!-- If applicable, write the Jira ticket number in square brackets e.g. [PROJECT-XXXX] The Jira integration will turn it into a clickable link for you. -->

This PR resolves []

Description

Rounding the value when converting from inches to centimeters globally

<!-- Implementation description -->

PR Checklist (tick all before merging)

<!-- 💡 This checklist is experimental. MX warmly welcomes any feedback about the list or how it impacts your workflow -->

  • [ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • [x] I have tested my changes on iOS and Android.
  • [x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • [x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
  • [x] I have documented any follow-up work that this PR will require, or it does not require any.
  • [x] I have added an app state migration, or my changes do not require one. (What are migrations?)
  • [ ] I have added a CHANGELOG.yml entry or my changes do not require one.
+11 -6

2 comments

3 changed files

dimatretyak

pr closed time in 13 hours

pull request commentartsy/eigen

fix: correct round cm values during inch convert

I'm fine with this, just wondering how this cropped up in a bug? We'd never want to keep the precision?

I agree with you. Perhaps I was too hasty with the changes. I was thinking of doing the rounding globally so that we don't have to manually round each time

dimatretyak

comment created time in 13 hours

push eventartsy/eigen

JenqaaaBY

commit sha 8c33f569d02b7e71388b6f08f4fc312a80cc060e

update changelog

view details

push time in 13 hours

create barnchartsy/eigen

branch : anastasiapyzhik/sticky-header-on-show-screen

created branch time in 13 hours