profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/armandofox/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Armando Fox armandofox UC Berkeley San Francisco, CA http://www.armandofox.com I teach software engineering and CS pedagogy at UC Berkeley.

armandofox/audience1st 9

A zero-installation, zero-maintenance, open-source, all-in-one system for ticketing, subscriptions, development, and backoffice functions, designed expressly for the needs, budgets and constraints of small to medium community theaters.

armandofox/glomop 5

Source code, internal design docs, etc. for UC Berkeley GloMop/Pythia/TranSend compression-based Web proxy and scalable network server

armandofox/cucumber-virtualii 4

Cucumber steps and step definitions for Apple II integration testing using Virtual-II

armandofox/alexa-marantz-py 3

Alexa skill to control my Marantz SR6005 AVR

armandofox/basic 3

my evolving monograph "In Praise of BASIC"

armandofox/alexa-noaa 2

Alexa skill for getting National Weather Service/NOAA daily synopsis and discussion

armandofox/kindle-highlights 2

Get your Kindle highlights.

ace-lab/2014-dagstuhl-mooc 1

Final report for 2014-03 Dagstuhl-seminar on MOOCs

armandofox/dynamic-software 1

Applesoft programs of my youth

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

       @s.reload       expect(@s.description).to eq("updated description")     end++    it "should update the reminder type" do+      @s = create(:show, :name => "valid name")+      expect(@s.reminder_type).to eq("Never")+      response = post :update, :id => @s.id, :show => { :reminder_type => "24 hours before curtain time" }+      expect(response).to redirect_to edit_show_path(@s)++      @s.reload+      expect(@s.reminder_type).to eq("24 hours before curtain time")

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

           name: "some show",           description: "desc",           bad_param: "bad",-          listing_date: Date.today+          listing_date: Date.today,+          reminder_type: "12 hours before curtain time"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

         expect( @post_show.name ).to eq("some show")         expect( @post_show.description ).to eq("desc")         expect( @post_show.listing_date ).to eq(Date.today)+        expect( @post_show.reminder_type ).to eq("12 hours before curtain time")

Layout/SpaceInsideParens: Space inside parentheses detected.<br>Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

       @s.reload       expect(@s.description).to eq("updated description")     end++    it "should update the reminder type" do+      @s = create(:show, :name => "valid name")

Style/HashSyntax: Use the new Ruby 1.9 hash syntax.<br>Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

       @s.reload       expect(@s.description).to eq("updated description")     end++    it "should update the reminder type" do

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

 module StagingHelper   end   def self.switch_to_staging!     abort_if_production!-    abort "Only a1-staging and sandbox are valid tenants" unless ['a1-staging','sandbox'].include?(StagingHelper::TENANT)+    abort "Only a1-staging and sandbox are valid tenants" unless ['a1-staging','sandbox','calvisitor'].include?(StagingHelper::TENANT)

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Layout/SpaceAfterComma: Space missing after comma.<br>Metrics/LineLength: Line is too long. [134/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

+module FeatureFlagHelpers+  def enable_new_feature(feature_name)+    Option.enable_feature!(feature_name)+  end++  def disable_new_feature(feature_name)+    Option.disable_feature!(feature_name)+  end+end++World(FeatureFlagHelpers)

Layout/TrailingBlankLines: Final newline missing.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

       @s.reload       expect(@s.description).to eq("updated description")     end++    it "should update the reminder type" do+      @s = create(:show, :name => "valid name")+      expect(@s.reminder_type).to eq("Never")

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

       @s.reload       expect(@s.description).to eq("updated description")     end++    it "should update the reminder type" do+      @s = create(:show, :name => "valid name")+      expect(@s.reminder_type).to eq("Never")+      response = post :update, :id => @s.id, :show => { :reminder_type => "24 hours before curtain time" }

Style/HashSyntax: Use the new Ruby 1.9 hash syntax.<br>Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Metrics/LineLength: Line is too long. [106/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

+module FeatureFlagHelpers

Style/Documentation: Missing top-level module documentation comment.<br>Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

 # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 20210224173731) do+ActiveRecord::Schema.define(version: 20210418205452) do

Metrics/BlockLength: Block has too many lines. [293/25]<br>Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

   end end +When /^I enable the reminder email feature$/ do

Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "customers", ["ticket_sales_import_id"], name: "index_customers_on_ticket_sales_import_id", using: :btree+  add_index "customers", ["ticket_sales_import_id"], name: "index_customers_on_ticket_sales_import_id"    create_table "customers_labels", id: false, force: :cascade do |t|     t.integer "customer_id"     t.integer "label_id"   end -  add_index "customers_labels", ["customer_id", "label_id"], name: "index_customers_labels_on_customer_id_and_label_id", unique: true, using: :btree+  add_index "customers_labels", ["customer_id", "label_id"], name: "index_customers_labels_on_customer_id_and_label_id", unique: true

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Style/WordArray: Use %w or %W for an array of words.<br>Metrics/LineLength: Line is too long. [133/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "customers", ["ticket_sales_import_id"], name: "index_customers_on_ticket_sales_import_id", using: :btree+  add_index "customers", ["ticket_sales_import_id"], name: "index_customers_on_ticket_sales_import_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Metrics/LineLength: Line is too long. [102/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"+  add_index "items", ["order_id"], name: "index_items_on_order_id"+  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id"+  add_index "items", ["seat"], name: "index_items_on_seat"+  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"+  add_index "items", ["order_id"], name: "index_items_on_order_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"+  add_index "items", ["order_id"], name: "index_items_on_order_id"+  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id"+  add_index "items", ["seat"], name: "index_items_on_seat"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id", using: :btree-  add_index "orders", ["external_key"], name: "index_orders_on_external_key", using: :btree-  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id", using: :btree-  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id", using: :btree-  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id", using: :btree+  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id"+  add_index "orders", ["external_key"], name: "index_orders_on_external_key"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"+  add_index "items", ["order_id"], name: "index_items_on_order_id"+  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.datetime "sold_on"   end -  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id", using: :btree-  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id", using: :btree-  add_index "items", ["customer_id"], name: "index_items_on_customer_id", using: :btree-  add_index "items", ["finalized"], name: "index_items_on_finalized", using: :btree-  add_index "items", ["order_id"], name: "index_items_on_order_id", using: :btree-  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id", using: :btree-  add_index "items", ["seat"], name: "index_items_on_seat", using: :btree-  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id", using: :btree-  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id", using: :btree+  add_index "items", ["account_code_id"], name: "index_items_on_account_code_id"+  add_index "items", ["bundle_id"], name: "index_items_on_bundle_id"+  add_index "items", ["customer_id"], name: "index_items_on_customer_id"+  add_index "items", ["finalized"], name: "index_items_on_finalized"+  add_index "items", ["order_id"], name: "index_items_on_order_id"+  add_index "items", ["processed_by_id"], name: "index_items_on_processed_by_id"+  add_index "items", ["seat"], name: "index_items_on_seat"+  add_index "items", ["showdate_id"], name: "index_items_on_showdate_id"+  add_index "items", ["vouchertype_id"], name: "index_items_on_vouchertype_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "order_timeout",                                                      default: 5,                                                                                                                               null: false     t.datetime "last_sweep",                                                         default: '2019-12-24 17:59:23',                                                                                                           null: false     t.text     "html_email_template",                                                default: "<!DOCTYPE html><html><head></head><body>{{body}}</body></html>",                                                                null: false+    t.string   "reminder_emails",                                                    default: "Never"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Metrics/LineLength: Line is too long. [101/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id", using: :btree-  add_index "orders", ["external_key"], name: "index_orders_on_external_key", using: :btree-  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id", using: :btree-  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id", using: :btree-  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id", using: :btree+  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id"+  add_index "orders", ["external_key"], name: "index_orders_on_external_key"+  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id"+  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id", using: :btree-  add_index "orders", ["external_key"], name: "index_orders_on_external_key", using: :btree-  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id", using: :btree-  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id", using: :btree-  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id", using: :btree+  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id", using: :btree-  add_index "orders", ["external_key"], name: "index_orders_on_external_key", using: :btree-  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id", using: :btree-  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id", using: :btree-  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id", using: :btree+  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id"+  add_index "orders", ["external_key"], name: "index_orders_on_external_key"+  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Metrics/LineLength: Line is too long. [82/80]

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.text     "access_instructions"   end -  add_index "showdates", ["seatmap_id"], name: "index_showdates_on_seatmap_id", using: :btree-  add_index "showdates", ["show_id"], name: "index_showdates_on_show_id", using: :btree+  add_index "showdates", ["seatmap_id"], name: "index_showdates_on_seatmap_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

kkhus5

comment created time in 17 hours

Pull request review commentarmandofox/audience1st

Reminder Options for Create/Edit Show Views

     t.integer  "ticket_sales_import_id"   end -  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id", using: :btree-  add_index "orders", ["external_key"], name: "index_orders_on_external_key", using: :btree-  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id", using: :btree-  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id", using: :btree-  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id", using: :btree+  add_index "orders", ["customer_id"], name: "index_orders_on_customer_id"+  add_index "orders", ["external_key"], name: "index_orders_on_external_key"+  add_index "orders", ["processed_by_id"], name: "index_orders_on_processed_by_id"+  add_index "orders", ["purchaser_id"], name: "index_orders_on_purchaser_id"+  add_index "orders", ["ticket_sales_import_id"], name: "index_orders_on_ticket_sales_import_id"

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Metrics/LineLength: Line is too long. [96/80]

kkhus5

comment created time in 17 hours