profile
viewpoint
Andrew Bonventre andybons Google NYC https://andybons.com Engineering Lead on the @golang Team

dvyukov/go-fuzz 3632

Randomized testing for Go

Medium/medium-sdk-go 126

A Golang SDK for Medium's OAuth2 API

andybons/hipchat 107

This project implements a Go client library for the Hipchat API.

dvyukov/go-fuzz-corpus 87

Corpus for github.com/dvyukov/go-fuzz examples

andybons/gogif 21

The (no longer) missing GIF encoder for #golang

andybons/baseline 7

Starting point for Go web services

andybons/grge 4

iOS garage door opener compatible with https://github.com/bradfitz/android-garage-opener

andybons/propnotes 2

A tool to help generate Go proposal review meeting minutes

andybons/ABVariants 1

Experiments/Mods system for iOS and OS X

andybons/ascii 1

A library to convert an image.Image to ascii art

issue closedgolang/go

access: +2 and Editors for roland@

@rolandshoemaker joined the Go Security team 🎉

Please grant him access to GitHub (https://github.com/orgs/golang/teams/go-approvers, @rolandshoemaker) and Gerrit (https://go-review.googlesource.com/#/admin/groups/1005,members, rolandshoemaker@gmail.com).

See https://golang.org/wiki/GithubAccess. /cc @golang/osp-team

closed time in 11 days

FiloSottile

issue commentgolang/go

access: +2 and Editors for roland@

Done. Welcome, Roland!

FiloSottile

comment created time in 11 days

issue commentgolang/go

cmd/asm: VMOVQ misassembled to VMOVD on 386

@cherrymui

fuzxxl

comment created time in 15 days

issue commentgolang/go

go tool trace not work

Duplicate of #29707

Feel free to comment or open a new issue if this is not the case.

tiny1990

comment created time in 15 days

issue closedgolang/go

go tool trace not work

What version of Go are you using (go version)?

<pre> $ go version go version go1.11.13 linux/amd64 or go version go1.14 or go version go1.15 </pre>

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/root/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/root/go" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build933204170=/tmp/go-build -gno-record-gcc-switches" </pre></details>

What did you do?

wget -O trace.out  127.0.0.1:5555/debug/pprof/trace?seconds=5
# go tool trace trace.out
2020/09/09 21:31:18 Parsing trace...
failed to parse trace: no consistent ordering of events possible

# docker version
Server: Docker Engine - Community
 Engine:
  Version:          19.03.12
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.13.10

What did you expect to see?

2020/09/09 21:31:18 Parsing trace... 2019/12/17 10:19:28 Opening browser. Trace viewer is listening on http://127.0.0.1:42335

closed time in 15 days

tiny1990

issue commentgolang/go

cmd/go: inconsistent result when go build output path is not a exists directory

@bcmills @matloob @jayconrod

XSAM

comment created time in 15 days

issue commentgolang/go

x/pkgsite: show more search results per page or give users a setting for that

That’s helpful. Thanks.

ainar-g

comment created time in 17 days

issue commentgolang/go

cmd/go: breakage with go version command and GOFLAGS environment variable

@bcmills @jayconrod @matloob

williamh

comment created time in 17 days

issue commentgolang/go

os/exec: Timeout (and unclosed Stdin) not working correctly

@bradfitz @ianlancetaylor

martinrode

comment created time in 17 days

issue commentgolang/go

downloading 1.0.3 while asking for 1.0.4

@bcmills

bukowa

comment created time in 17 days

issue commentgolang/go

time: TZ/DST AddDate() problem - Two consecutive days with 23h duration

@ianlancetaylor

marko-gacesa

comment created time in 17 days

issue closedgolang/go

access: @empijei should be added to https://github.com/orgs/golang/teams/go-approvers

See https://golang.org/wiki/GithubAccess

I @empijei would like to be added to https://github.com/orgs/golang/teams/go-approvers since I am helping maintaining some stdlib packages.

closed time in 17 days

empijei

issue commentgolang/go

x/pkgsite: show more search results per page or give users a setting for that

Can you provide some examples of what you searched for and what the expected results were?

ainar-g

comment created time in 17 days

issue commentgolang/go

net/http: ConfigureTransport does not work for Transport with custom DialTLS

/cc @FiloSottile

fqrious

comment created time in 17 days

issue closedgolang/go

net/http, x/net/http2: http.readTrackingBody data race after received GOAWAY frame

<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions -->

What version of Go are you using (go version)?

<pre> $ go version go version go1.15 linux/amd64 </pre>

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/root/.cache/go-build" GOENV="/root/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/go/src/k8s.io/kubernetes/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build142705141=/tmp/go-build -gno-record-gcc-switches" </pre></details>

What did you do?

  1. Set up a HTTP2 server with a handler which will send GOAWAY frame
  2. Use a HTTP client to request HTTP2 server with POST method and data in multi goroutines in concurrency
  3. http.readTrackingBody cause data race

Example codes: https://github.com/answer1991/go-workspace/blob/master/pkg/goaway/goaway_test.go , run with go test -race failed:

WARNING: DATA RACE
Read at 0x00c00031ed38 by goroutine 181:
  bytes.(*Reader).Read()
      /usr/local/go/src/bytes/reader.go:41 +0x5e
  io/ioutil.(*nopCloser).Read()
      <autogenerated>:1 +0x87
  net/http.(*readTrackingBody).Read()
      /usr/local/go/src/net/http/transport.go:621 +0x8a
  golang.org/x/net/http2.(*clientStream).writeRequestBody()
      /Users/Joe/go/src/golang.org/x/net/http2/transport.go:1293 +0x761
  golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
      /Users/Joe/go/src/golang.org/x/net/http2/transport.go:2564 +0x13d

Previous write at 0x00c00031ed38 by goroutine 218:
  bytes.(*Reader).Read()
      /usr/local/go/src/bytes/reader.go:46 +0x14b
  io/ioutil.(*nopCloser).Read()
      <autogenerated>:1 +0x87
  net/http.(*readTrackingBody).Read()
      /usr/local/go/src/net/http/transport.go:621 +0x8a
  golang.org/x/net/http2.(*clientStream).writeRequestBody()
      /Users/Joe/go/src/golang.org/x/net/http2/transport.go:1293 +0x761
  golang.org/x/net/http2.(*Transport).getBodyWriterState.func1()
      /Users/Joe/go/src/golang.org/x/net/http2/transport.go:2564 +0x13d

Root Cause

Error timeline:

  1. http2 Transport read request body in a goroutine(let's named body reading goroutine):

https://github.com/golang/net/blob/62affa334b73ec65ed44a326519ac12c421905e3/http2/transport.go#L2630

  1. http2 Transport.RoundTrip return PROTOCOL_ERROR error after received GOAWAY frame, but the body reading goroutine is still on going and the request.Body(wrapped as http.readTrackingBody) has not been read.
  2. http Transport retry the request, found http.readTrackingBody.didRead == false, then re-use the http.readTrackingBody
  3. then there are 2 body reading goroutine try to read the same http.readTrackingBody instance.

closed time in 17 days

answer1991

issue commentgolang/go

cmd/cover: //line directives frequently handled incorrectly

@golang/tools-team

pjweinb

comment created time in 17 days

create barnchandybons/andybons

branch : master

created branch time in 19 days

created repositoryandybons/andybons

created time in 19 days

issue closedgolang/go

proposal: dep: move out of github.com/golang

Hi there,

This is effectively a recreation of #29639, to request another evaluation based on the current state of the world and in relation to this issue: https://github.com/golang/go/issues/38158.

Cheers! -Tim

closed time in 20 days

theckman

issue commentgolang/go

proposal: dep: move out of github.com/golang

Closing as a duplicate of #29639.

As I stated in the original issue:

We will not be transferring the dep repo. It is an important part of Go’s development history and still a useful tool for many. It will remain in the golang organization indefinitely.

That has not changed, even in light of official deprecation.

You are welcome and encouraged to fork the repo if you’d like to continue working on it.

Thanks

theckman

comment created time in 20 days

issue commentgolang/go

dep: officially deprecate the "dep" experiment

@mvdan @ALTree you are both admins now.

daenney

comment created time in 21 days

issue commentgolang/go

dep: officially deprecate the "dep" experiment

Thank you very much @mvdan and @ALTree for volunteering to do this work.

daenney

comment created time in 21 days

issue commentgolang/go

dep: officially deprecate the "dep" experiment

Yep that’s me. Happy to help. Invited you both as maintainers. If you need admin access just let me know.

daenney

comment created time in 21 days

MemberEvent
MemberEvent

issue openedgolang/go

x/pkgsite: improve frontend development ergonomics

There are multiple items likely associated with these improvements, so it may make sense to break them out and label this an umbrella issue.

  • A JS style guide (to complement https://golang.org/wiki/CSSStyleGuide) is needed to guide contributors through best practices when developing on frontend.
  • It’s not clear that the JS compiler is providing a ton of value, as it takes a very long time to compile and we don’t have much JS to serve. A minifier written in Go (and therefore easily embeddable) could be used (https://github.com/tdewolff/minify is one such minifier with one major issue: it does not generate source maps).
  • When developing locally, a separate compile step should not be needed to have the changes be served. We could serve the files individually and uncompiled, or serve a minified version with a source map.
  • Each page should only have the assets that it needs and nothing more. We serve a lot of unused CSS on pages that don’t need it.
  • Given our browser support matrix and the user agents visiting us, it may make sense to migrate fully to JavaScript Modules (<script type="module">) so that older, unsupported browsers don’t attempt to load our JS and barf in our error logs.
  • A mechanism to easily test pages with no JS at all. This would help keep us honest for when someone has JS disabled (are we doing our best to provide a degraded but functional experience?)
  • A testing methodology. Do we pull in Jest or run our own tests using Russ’ webdriver package?

I’m sure we can come up with bundling functionality using Go that gets us most of the way there without needing to pull in third-party tooling that requires NPM. Testing is another story, so we’ll have to figure out where we draw the line on whether to pull in NPM or not for that.

created time in a month

issue openedgolang/go

x/pkgsite: use system fonts instead of Google Fonts

We should use system-installed fonts on pkg.go.dev and drop our dependency on fonts.google.com

This is to reduce the number of render-blocking requests and hopefully improve latency (whether perceived or actual) for users.

created time in a month

issue openedgolang/go

x/pkgsite: track JS errors and latency metrics via Google Tag Manager

https://philipwalton.com/articles/the-google-analytics-setup-i-use-on-every-site-i-build/ has some good info for tracking JS errors and latency metrics via Google Analytics. Since we use GTM we have to pipe the info through there.

As a note, we should not implement all recommendations in the doc above like recording client and window IDs.

Also worth looking into https://web.dev/vitals/ to see if those are more appropriate to record as well.

The implementation details can be outlined in this issue or a public doc (plus the CL will be public).

created time in a month

issue commentgolang/go

x/pkgsite: auto-expand left sidebar

  • Functions and types are now expanded by default as of https://golang.org/cl/248183. My guess is that we haven’t deployed that change yet and/or the documentation needs to be reprocessed.
  • The fix to not show the scrollbar when there’s nothing to scroll has also been landed.

There’s a lot of other feedback in this bug. May be worth splitting that out to separate issues. The original issue of not having the functions and types be expanded by default has been fixed (just not deployed).

jayconrod

comment created time in a month

issue commentgolang/go

x/pkgsite: is the initial parenthesis really necessary for left hand side menu?

@pjebs it concerns the design of the left-hand nav and the presentation of its contents, so I merged it into that issue.

pjebs

comment created time in a month

issue commentgolang/go

x/pkgsite: LHS navigation panel is "lossy"

It’s worth noting that at wide-enough viewports, it may make sense to fully expand an entry in the nav such that

(entry) Debugf(format, args)func (entry *Entry) Debugf(format string, args ...interface{})

in addition to allowing users to change the sizenav size manually and collapse it if necessary.

myitcv

comment created time in a month

issue commentgolang/go

x/pkgsite: is the initial parenthesis really necessary for left hand side menu?

Duplicate of #40612

pjebs

comment created time in a month

issue commentgolang/go

x/pkgsite: horizontal scrollbar shows needlessly

@myitcv something looks like it’s overflowing. Can you repro this in an incognito window as well?

myitcv

comment created time in a month

issue commentgolang/go

x/pkgsite: LHS navigation panel is "lossy"

The CL above attempts to make some quick and relatively easy changes to alleviate some concerns, but please keep in mind we are not done yet.

The following screenshots show the results. There is no more max width of the header content, the left nav is flush left, and the main documentation takes up the rest of the screen up to 80rem (1280px). As the window gets larger, the side nav also gets wider (at particular breakpoints, though we will likely experiment with a percentage of window size in a follow-up).

In the screenshots below, the red border is meant to show the width of the side navigation.

As I said above, this is just one step in addressing everyone’s concerns, which we’ve heard loud and clear.

Screen Shot 2020-08-18 at 5 34 36 PM Screen Shot 2020-08-18 at 5 34 56 PM Screen Shot 2020-08-18 at 5 35 03 PM Screen Shot 2020-08-18 at 5 35 11 PM

myitcv

comment created time in a month

issue commentgolang/go

x/pkgsite: LHS navigation panel is "lossy"

As I pointed out in #40715 (which is mostly a duplicate of this bug) there is one additional problem here: even if the LHS panel was expanded by default, it would take way more space than it used to. Moreover it is limited in horizontal space so signatures that are too long require a painfully slow mousehover to be read.

Thanks for the additional feedback. That CL is just a first step toward addressing things. It is not meant to solve all the issues described here.

(Note: Considering that not everyone is able to use a mouse and that there doesn't seem to be another way to get that information in a visual way this might be also classified as an accessibility issue.)

I’d like to hear more about this if you could elaborate further. We put a lot of effort to ensure it follows best practices for accessibility (supports keyboard navigation; proper ARIA roles for screen readers).

myitcv

comment created time in a month

issue commentgolang/go

pkg.go.dev: Is the initial parenthesis really necessary for left hand side menu?

It’s important to be able to discern between a method and a function that returns that type.

https://pkg.go.dev/time?tab=doc#Date shows an example of this.

Is there an alternative you suggest?

pjebs

comment created time in a month

issue closedgolang/go

could not import fmt (no package for import fmt)compiler

Hi everyone, I just learned golang, this problem has troubled me for a long time, can you help me solve it? thank you very much

go env

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/alex/Library/Caches/go-build"
GOENV="/Users/alex/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/alex/workspace/learngo"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/t2/g3snv2xs0ll_114bqxhz2t6h0000gn/T/go-build374694917=/tmp/go-build -gno-record-gcc-switches -fno-common"

image

gopls -rpc.trace -v check /Users/alex/workspace/test.go

2020/08/14 00:33:25 Info:2020/08/14 00:33:25 Build info
----------
golang.org/x/tools/gopls 0.4.4
    golang.org/x/tools/gopls@v0.4.4 h1:8djGYsaZ0ByP0vaXg4T+mnyfDcHpWKSZ+tpQSGv9ahk=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/google/go-cmp@v0.5.0 h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.3.0 h1:RM4zey1++hCTbCVQfnWeKs9/IEsaBLA8vTkd0WVtmH4=
    golang.org/x/sync@v0.0.0-20200625203802-6e8e738ad208 h1:qwRHBd0NqMbJxfbotnDhm2ByMI1Shq4Y6oRJo21SGJA=
    golang.org/x/tools@v0.0.0-20200729181040-64cdafbe085c h1:jLQLIAedRoS9I2Py7l/ZAGGzUxLFsdg42JXEpS/a+ow=
    golang.org/x/xerrors@v0.0.0-20191204190536-9bdfabe68543 h1:E7g+9GITq07hpfrRu66IVDexMakfv52eLZ2CXBWiKr4=
    honnef.co/go/tools@v0.0.1-2020.1.4 h1:UoveltGrhghAA7ePc+e+QYDHXrBps2PqFZiHkGR/xK8=
    mvdan.cc/gofumpt@v0.0.0-20200709182408-4fd085cb6d5f h1:gi7cb8HTDZ6q8VqsUpkdoFi3vxwHMneQ6+Q5Ap5hjPE=
    mvdan.cc/xurls/v2@v2.2.0 h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=

Go info
-------
go version go1.14.4 darwin/amd64


2020/08/14 00:33:25 Info:2020/08/14 00:33:25 go env for /Users/alex/workspace/learngo/bin
(root /Users/alex/workspace/learngo/bin)
(valid build configuration = false)
(build flags: [])
GOINSECURE=
GOMOD=
GOPATH=/Users/alex/workspace/learngo
GOPRIVATE=
GOROOT=/usr/local/go
GO111MODULE=
GOCACHE=/Users/alex/Library/Caches/go-build
GOFLAGS=
GOMODCACHE=
GONOPROXY=
GOSUMDB=sum.golang.org
GOPROXY=https://goproxy.cn,direct
GONOSUMDB=

2020/08/14 00:33:25 Info:2020/08/14 00:33:25 go/packages.Load
	snapshot=0
	directory=/Users/alex/workspace/learngo/bin
	query=[./ builtin]
	packages=2
2020/08/14 00:33:25 Info:2020/08/14 00:33:25 go/packages.Load
	snapshot=0
	directory=/Users/alex/workspace/learngo/bin
	query=[./]
	packages=1

closed time in a month

balainit

issue commentgolang/go

could not import fmt (no package for import fmt)compiler

Hi there,

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For asking questions, see:

Please ask the question on one of the above forums.

(Quoted from https://golang.org/wiki/Questions)

balainit

comment created time in a month

issue commentgolang/go

proposal: net/http: accept "x-gzip" content encoding value

@melardev are you experiencing this in the wild? Which servers still serve x-gzip as their content-encoding?

melardev

comment created time in a month

issue commentgolang/go

proposal: net/http: accept "x-gzip" content encoding value

@neild @bradfitz

melardev

comment created time in a month

issue closedgolang/go

github api empty for releases

What version of Go are you using (go version)?

https://api.github.com/repos/golang/go/releases is empty and does not match https://github.com/golang/go/releases

What did you expect to see?

$ curl --silent https://api.github.com/repos/golang/go/releases | jq -r '.[].name'
  go1.15
  go1.15rc2
  go1.14.7
  go1.13.15
  ...

What did you see instead?

$ curl --silent https://api.github.com/repos/golang/go/releases
  [
  
  ]

closed time in a month

vvitayau

issue commentgolang/go

github api empty for releases

This seems to be a GitHub UX issue, as we don’t create explicit GitHub releases, but they list the git tags.

Not sure what to do, here.

vvitayau

comment created time in a month

issue commentgolang/go

cmd/link: SDYNIMPORT on arm results in incorrect assembly

@cherrymui @rsc @mdempsky @ianlancetaylor @mwhudson @thanm

4a6f656c

comment created time in a month

issue commentgolang/go

cmd/go: `go test -v` can interleave summary and test output

@bcmills @matloob @jayconrod

mattmoor

comment created time in a month

issue commentgolang/go

x/pkgsite: remove package from go dev website

@jba @jamalc

ZiyaoQiao

comment created time in a month

issue commentgolang/go

top-level: Go binary checked in to git repository?

@matloob you’ll have to reland the changes that were dropped. @cherrymui you’ll have to redo the merge.

kevinburkemeter

comment created time in a month

issue closedgolang/go

top-level: Go binary checked in to git repository?

It looks like commit cfbd1c765a455d18187bb234b6cce0ea5a8b76a6 added a go binary at the root of the Git repository.

0s kevin in ~/src/github.com/golang/go
± (master) $ ls -al
total 14M
drwxr-xr-x  22 kevin staff  704 Aug 12 13:20 .
drwxr-xr-x   9 kevin staff  288 Feb 19 16:20 ..
drwxr-xr-x  13 kevin staff  416 Aug 12 13:23 .git
-rw-r--r--   1 kevin staff  639 Jun  8 09:13 .gitattributes
drwxr-xr-x   6 kevin staff  192 Jan  6  2020 .github
-rw-r--r--   1 kevin staff  928 Aug  5  2019 .gitignore
-rw-r--r--   1 kevin staff  55K Jul  8 11:07 AUTHORS
-rw-r--r--   1 kevin staff 1.4K Aug  5  2019 CONTRIBUTING.md
-rw-r--r--   1 kevin staff  94K Aug 11 10:55 CONTRIBUTORS
-rw-r--r--   1 kevin staff 1.5K Aug  5  2019 LICENSE
-rw-r--r--   1 kevin staff 1.3K Aug  5  2019 PATENTS
-rw-r--r--   1 kevin staff 1.6K Aug  5  2019 README.md
-rw-r--r--   1 kevin staff  397 Sep 26  2019 SECURITY.md
drwxr-xr-x  21 kevin staff  672 Jul 16 20:30 api
drwxr-xr-x  46 kevin staff 1.5K Aug 12 10:37 doc
-rw-r--r--   1 kevin staff 5.6K Aug  5  2019 favicon.ico
-rwxr-xr-x   1 kevin staff  14M Aug 12 13:20 go
drwxr-xr-x   3 kevin staff   96 Aug  5  2019 lib
drwxr-xr-x  14 kevin staff  448 Oct 23  2019 misc
-rw-r--r--   1 kevin staff   26 Aug  5  2019 robots.txt
drwxr-xr-x  70 kevin staff 2.2K Jul 25 22:36 src
drwxr-xr-x 328 kevin staff  11K Jul 30 13:59 test

It's executable on Darwin, here is what prints out.

$ ./go version
go version devel +0ea11145ff Tue Jun 30 15:04:06 2020 -0400 darwin/amd64

closed time in a month

kevinburkemeter

issue commentgolang/go

top-level: Go binary checked in to git repository?

This is now done.

kevinburkemeter

comment created time in a month

issue commentgolang/go

top-level: Go binary checked in to git repository?

Reverting to 2bfa45cfa994512c47da2d98f3baca5bb474ec9b (the commit right before)

kevinburkemeter

comment created time in a month

issue commentgolang/go

top-level: Go binary checked in to git repository?

I’ll take this as I’m on call.

kevinburkemeter

comment created time in a month

issue commentgolang/go

top-level: Go binary checked in to git repository?

Let’s rewrite history to remove it.

kevinburkemeter

comment created time in a month

issue commentgolang/go

x/pkgsite: landing page for docs provides no structural information at a glance.

@empijei I have a CL to expand all items by default. While I understand this doesn’t cover all of your concerns, would you consider that mitigation sufficient for this bug? We can track further improvements on #40612.

Let me know what you think.

empijei

comment created time in a month

issue commentgolang/go

cmd/link: merge dev.link into master branch for Go 1.16 early

This seems reasonable to me. Let’s plan to merge tomorrow when we open the tree to large changes.

aclements

comment created time in a month

issue closedgolang/go

x/crypto/scrypt: memory not released after hash is calculated

<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions -->

What version of Go are you using (go version)?

<pre> $ go version go version go1.14.1 linux/amd64 </pre>

What did you do?

when I concurrent call scrypt.Key ,the memory not released after FreeOSMemory,here is the code

package main

import (
	"fmt"
	"log"
	"runtime/debug"
	"time"

	"golang.org/x/crypto/scrypt"
)

func main() {
	for i := 0; i < 30; i++ {
		go func() {
			key, _ := scrypt.Key(
				[]byte(""), // Input data.
				[]byte(""), // Salt.
				1<<18,      // Scrypt parameter N.
				16,         // Scrypt parameter r.
				1,          // Scrypt parameter p.
				64)         // Output hash length.

			fmt.Println(key)
		}()
	}

	time.Sleep(20 * time.Second)
	log.Println("free")
	debug.FreeOSMemory()

	// Keep the process running.
	time.Sleep(500 * time.Second)
}

closed time in a month

cheng762

issue commentgolang/go

time: UnixNano thinks year 1 comes after 1720

@ianlancetaylor

vsekhar

comment created time in a month

issue commentgolang/go

cmd/go: go get is selecting incorrect module, when using multiple proxies

@bcmills @jayconrod @matloob

slon

comment created time in a month

issue closedgolang/go

all: Go 1.15 release status

Issue tracking the go1.15 release by releasebot.

closed time in a month

andybons

issue commentgolang/go

all: Go 1.15 release status

release process go brrr

andybons

comment created time in a month

issue commentgolang/go

x/crypto/scrypt: memory not released after hash is calculated

@davecheney is correct. Closing for now as there does not seem to be anything to do. Please feel free to comment if you feel otherwise.

cheng762

comment created time in a month

issue commentgolang/go

all: Go 1.15 release status

Latest build: go1.15

  • src (tar.gz)
  • linux-386 (tar.gz)
  • linux-armv6l (tar.gz)
  • linux-amd64 (tar.gz)
  • linux-arm64 (tar.gz)
  • freebsd-386 (tar.gz)
  • freebsd-amd64 (tar.gz)
  • windows-386 (zip) (msi)
  • windows-amd64 (zip) (msi)
  • darwin-amd64 (tar.gz)
  • linux-s390x (tar.gz)
  • linux-ppc64le (tar.gz)
  • linux-amd64-longtest (test only) - not built
    • skipped because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag
  • windows-amd64-longtest (test only) - not built
    • skipped because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag

Log

2020/08/11 15:03:06 starting
2020/08/11 15:03:06 working in /Users/andybons/go-releasebot-work/go1.15
2020/08/11 15:03:06 $ git fetch origin master
2020/08/11 15:03:07 $ git fetch origin release-branch.go1.15
2020/08/11 15:03:08 $ git clone --reference /Users/andybons/go-releasebot-work/go1.15/gitmirror -b release-branch.go1.15 https://go.googlesource.com/go /Users/andybons/go-releasebot-work/go1.15/gitwork
2020/08/11 15:03:12 $ git codereview change relwork
2020/08/11 15:03:13 $ git config gc.auto 0
2020/08/11 15:03:14 an associated security release branch "release-branch.go1.15-security" does not exist; assuming it has been merged and deleted, so proceeding as usual
2020/08/11 15:03:14 Release status issue title: "all: Go 1.15 release status"
2020/08/11 15:03:14 Release status issue: https://golang.org/issue/40668
2020/08/11 15:03:14 $ git rev-parse go1.15
2020/08/11 15:08:34 $ git tag go1.15 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339
2020/08/11 15:08:34 $ git push origin go1.15
2020/08/11 15:08:39 $ go get golang.org/x/build/cmd/release
2020/08/11 15:16:29 skipping test-only target linux-amd64-longtest because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag
2020/08/11 15:16:29 skipping test-only target windows-amd64-longtest because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target src -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target darwin-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-armv6l -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target freebsd-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-s390x -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target freebsd-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-ppc64le -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target windows-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-arm64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:16:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target windows-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/0fdc3801bfd43d6f55e4ea5bf095e1ea55430339_555847640 -rev 0fdc3801bfd43d6f55e4ea5bf095e1ea55430339 -skip_tests
2020/08/11 15:48:17 changing milestone of issue 38544 to Go1.16
2020/08/11 15:48:18 changing milestone of issue 40255 to Go1.16
2020/08/11 15:48:19 closing milestone Go1.15
2020/08/11 15:48:19 

The release stage has completed. Thanks for riding with releasebot today!

Please refer to the playbook for the next steps.
andybons

comment created time in a month

issue commentgolang/go

all: Go 1.15 release status

Log

2020/08/11 14:06:18 starting
2020/08/11 14:06:18 working in /Users/andybons/go-releasebot-work/go1.15
2020/08/11 14:06:18 $ git fetch origin master
2020/08/11 14:06:18 $ git fetch origin release-branch.go1.15
2020/08/11 14:06:19 $ git clone --reference /Users/andybons/go-releasebot-work/go1.15/gitmirror -b release-branch.go1.15 https://go.googlesource.com/go /Users/andybons/go-releasebot-work/go1.15/gitwork
2020/08/11 14:06:23 $ git codereview change relwork
2020/08/11 14:06:23 $ git config gc.auto 0
2020/08/11 14:06:24 an associated security release branch "release-branch.go1.15-security" does not exist; assuming it has been merged and deleted, so proceeding as usual
2020/08/11 14:06:24 $ git rev-parse go1.15
2020/08/11 14:06:24 Release status issue title: "all: Go 1.15 release status"
2020/08/11 14:06:24 Release status issue: https://golang.org/issue/40668
2020/08/11 14:06:24 $ git add VERSION
2020/08/11 14:06:24 $ git commit -m go1.15

Change-Id: Id2262ff66e750e798ebe7ecfcc13d2653cb85b71
 VERSION
2020/08/11 14:06:24 $ git codereview mail -trybot
2020/08/11 14:06:32 $ go get golang.org/x/build/cmd/release
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target darwin-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 skipping test-only target linux-amd64-longtest because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target windows-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target src -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 skipping test-only target windows-amd64-longtest because of -skip-test="linux-amd64-longtest windows-amd64-longtest" flag
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target freebsd-386 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-s390x -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target freebsd-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-arm64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-armv6l -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target windows-amd64 -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:12:29 $ /Users/andybons/go-releasebot-work/go1.15/gopath/bin/release -target linux-ppc64le -user andybons -version go1.15 -staging_dir /Users/andybons/go-releasebot-work/go1.15/release-staging/e58591aeb114effd4829877cba291dd31538a1b9_802314727 -rev e58591aeb114effd4829877cba291dd31538a1b9
2020/08/11 14:38:39 

The prepare stage has completed.

Please review and submit https://go-review.googlesource.com/q/Id2262ff66e750e798ebe7ecfcc13d2653cb85b71
and then run the release stage.
andybons

comment created time in a month

issue commentgolang/go

all: Go 1.15 release status

PROBLEMS WITH RELEASE

  • open issue #37419 is tagged release-blocker
  • Found errors during release. Stopping!

Log

2020/08/11 13:56:44 starting
2020/08/11 13:56:44 working in /Users/andybons/go-releasebot-work/go1.15
2020/08/11 13:56:44 $ git fetch origin master
2020/08/11 13:56:45 $ git fetch origin release-branch.go1.15
2020/08/11 13:56:47 $ git clone --reference /Users/andybons/go-releasebot-work/go1.15/gitmirror -b release-branch.go1.15 https://go.googlesource.com/go /Users/andybons/go-releasebot-work/go1.15/gitwork
2020/08/11 13:56:50 $ git codereview change relwork
2020/08/11 13:56:51 $ git config gc.auto 0
2020/08/11 13:56:53 an associated security release branch "release-branch.go1.15-security" does not exist; assuming it has been merged and deleted, so proceeding as usual
2020/08/11 13:56:53 $ git rev-parse go1.15
2020/08/11 13:56:53 Release status issue title: "all: Go 1.15 release status"
2020/08/11 13:56:53 Release status issue: https://golang.org/issue/40668

There were problems with the release, see above for details.

andybons

comment created time in a month

issue commentgolang/go

x/tools/internal/lsp/regtest: regression tests for on-disk file changes failing on darwin builders

Bumping this up as other failures may be hidden by this if they’re not fixed.

We should investigate further using gomote and if no underlying cause can be found soon, we should at least disable the test with a bug to track re-enabling it.

dmitshur

comment created time in a month

issue commentgolang/go

database/sql: Rows.Scan does not use the %w verb when wrapping errors

sgtm. marking as early-in-cycle

sfllaw

comment created time in a month

issue commentgolang/go

all: Go 1.15 release status

PROBLEMS WITH RELEASE

  • open issue #11811 is tagged release-blocker
  • open issue #12042 is tagged release-blocker
  • open issue #27155 is tagged release-blocker
  • open issue #37419 is tagged release-blocker
  • open issue #40554 is tagged release-blocker
  • Found errors during release. Stopping!

Log

2020/08/10 12:49:59 starting
2020/08/10 12:49:59 working in /Users/andybons/go-releasebot-work/go1.15
2020/08/10 12:49:59 $ git fetch origin master
2020/08/10 12:49:59 $ git fetch origin release-branch.go1.15
2020/08/10 12:50:00 $ git clone --reference /Users/andybons/go-releasebot-work/go1.15/gitmirror -b release-branch.go1.15 https://go.googlesource.com/go /Users/andybons/go-releasebot-work/go1.15/gitwork
2020/08/10 12:50:03 $ git codereview change relwork
2020/08/10 12:50:03 $ git config gc.auto 0
2020/08/10 12:50:04 an associated security release branch "release-branch.go1.15-security" does not exist; assuming it has been merged and deleted, so proceeding as usual
2020/08/10 12:50:04 $ git rev-parse go1.15
2020/08/10 12:50:04 Release status issue title: "all: Go 1.15 release status"
2020/08/10 12:50:06 Release status issue: https://golang.org/issue/40668

There were problems with the release, see above for details.

andybons

comment created time in a month

issue openedgolang/go

all: Go 1.15 release status

Issue tracking the go1.15 release by releasebot.

created time in a month

issue commentgolang/go

database/sql: Rows.Scan does not use the %w verb when wrapping errors

@neild @jba what do y’all think? Should we do this early in the 1.16 cycle and see what breaks?

sfllaw

comment created time in a month

issue commentgolang/go

x/sys: fsnotify module demo cannot recv sysevents on mips64le

@ianlancetaylor

duchuanLX

comment created time in a month

issue commentgolang/go

cmd/go: go test log output associated with wrong test

@bcmills

davidvanlaatum

comment created time in a month

issue closedgolang/go

proxy.golang.org:

<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions -->

What version of Go are you using (go version)?

<pre> $ go version 1.14.6 </pre>

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="~/go/bin" GOCACHE="~/Library/Caches/go-build" GOENV="~/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="~/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/Cellar/go/1.14.6/libexec" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.14.6/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lk/1yyswjf11xn090cy46x9387m0000gn/T/go-build733499197=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details>

What did you do?

Fetch the versions for etcd via: curl https://proxy.golang.org/github.com/etcd-io/etcd/@v/list

What did you expect to see?

I expected to see all published git tags of this module.

What did you see instead?

I saw all tags except the v3.4.* tags (which started being published Aug 2019)

closed time in a month

tiegz

issue commentgolang/go

proxy.golang.org:

This looks to be https://github.com/etcd-io/etcd/issues/11154

tiegz

comment created time in a month

issue commentgolang/go

x/pkgsite: LHS navigation panel is "lossy"

Thanks all for the valuable feedback and suggestions.

I’m in agreement that we are not using the amount of horizontal space effectively (see #40577).

As this is the most viewed page on pkg.go.dev by far, we want to ensure everyone that we’re taking this feedback into account and prioritizing accordingly. We understand how crucial this page is to everyone’s workflow and we’ll be working with our UX partners and the community to improve things.

In short, we hear you.

myitcv

comment created time in 2 months

issue commentgolang/go

x/build/cmd/gopherbot: x/tools gerrit change imported from GH constantly shown as just updated

Seeing a number of CLs that can no longer be changed due to this:

2020/08/06 19:24:57 No reviewers or cc: https://go-review.googlesource.com/c/net/+/187478
2020/08/06 19:24:57 Setting review on https://go-review.googlesource.com/c/net/+/187478: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:mikioh.public.networking@gmail.com State:}]}
2020/08/06 19:24:57 Could not set review for change "net~187478": HTTP status 409 Conflict; Change 187478 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/223779
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/223779: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:dmitshur@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~223779": HTTP status 409 Conflict; Change 223779 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/231464
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/231464: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:dmitshur@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~231464": HTTP status 409 Conflict; Change 231464 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/239498
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/239498: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:matloob@golang.org State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~239498": HTTP status 409 Conflict; Change 239498 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/240018
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/240018: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:1080@62eb7196-b449-3ce5-99f1-c037f21e1705 State:}]}
2020/08/06 19:24:58 Could not set review for change "tools~240018": HTTP status 400 Bad Request; )]}'
{
  "reviewers": {
    "1080@62eb7196-b449-3ce5-99f1-c037f21e1705": {
      "input": "1080@62eb7196-b449-3ce5-99f1-c037f21e1705",
      "error": "Account \u00271080@62eb7196-b449-3ce5-99f1-c037f21e1705\u0027 not found\n1080@62eb7196-b449-3ce5-99f1-c037f21e1705 does not identify a registered user or group"
    }
  },
  "error": "error adding reviewer"
}
2020/08/06 19:24:58 No reviewers or cc: https://go-review.googlesource.com/c/tools/+/246737
2020/08/06 19:24:58 Setting review on https://go-review.googlesource.com/c/tools/+/246737: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:matloob@golang.org State:}]}
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/text/+/238119
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/text/+/238119: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:mpvl@golang.org State:}]}
2020/08/06 19:25:01 Could not set review for change "text~238119": HTTP status 409 Conflict; Change 238119 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/212839
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/212839: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:01 Could not set review for change "mobile~212839": HTTP status 409 Conflict; Change 212839 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/231681
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/231681: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:01 Could not set review for change "mobile~231681": HTTP status 409 Conflict; Change 231681 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:01 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/234239
2020/08/06 19:25:01 Setting review on https://go-review.googlesource.com/c/mobile/+/234239: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:02 Could not set review for change "mobile~234239": HTTP status 409 Conflict; Change 234239 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:02 No reviewers or cc: https://go-review.googlesource.com/c/mobile/+/240009
2020/08/06 19:25:02 Setting review on https://go-review.googlesource.com/c/mobile/+/240009: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:hyangah@gmail.com State:}]}
2020/08/06 19:25:02 Could not set review for change "mobile~240009": HTTP status 409 Conflict; Change 240009 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.
2020/08/06 19:25:02 No reviewers or cc: https://go-review.googlesource.com/c/go/+/223118
2020/08/06 19:25:02 Setting review on https://go-review.googlesource.com/c/go/+/223118: {Message: Labels:map[] Comments:map[] Reviewers:[{Reviewer:bradfitz@golang.org State:}]}
2020/08/06 19:25:02 Could not set review for change "go~223118": HTTP status 409 Conflict; Change 223118 may not exceed 5000 updates. It may still be abandoned or submitted. To continue working on this change, recreate it with a new Change-Id, then abandon this one.

@stamblerre

ALTree

comment created time in 2 months

issue commentgolang/go

x/build: some Gerrit CLs are getting into a state where they can't be updated

I’m going to temporarily disabled assigning reviewers to CLs, as it’s possible that there’s an infinite loop there.

dmitshur

comment created time in 2 months

issue commentgolang/go

go.dev: the website doesn't prevent viewport resize

This is because a few pieces of text on https://pkg.go.dev/crypto/tls?tab=doc are causing overflow. Adding word-break: break-word to the appropriate CSS styles should solve the issue.

ucirello

comment created time in 2 months

issue commentgolang/go

x/blog: Link does not exist given in blog post of playground

I wonder if we should also add a note to the blog explaining that it does not describe the current version.

We should definitely do this.

dsaw

comment created time in 2 months

issue commentgolang/go

x/blog: Link does not exist given in blog post of playground

Should be relatively easy to point to a previous commit (instead of master) where this file exists.

dsaw

comment created time in 2 months

issue openedgolang/go

x/pkgsite: make better use of horizontal space

With the new side navigation changes launched for documentation, we aren’t taking advantage of the amount of horizontal space we have (especially on wider viewports). This is to track investigating alternatives so that we can better use the space available.

https://stripe.com/docs/api does this rather well in my opinion.

created time in 2 months

issue commentgolang/go

x/pkgsite: remove autocomplete experiment code

@findleyr sgtm!

andybons

comment created time in 2 months

issue openedgolang/go

pkgsite: remove autocomplete experiment code

Given the code churn on the homepage and header, autocomplete no longer works when turned on. As far as I know, no one is actively maintaining it. We should remove the code until we are ready to launch it to users.

created time in 2 months

issue commentgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

Sorry yeah. I meant to say casing should be preserved.

andybons

comment created time in 2 months

issue openedgolang/go

pkgsite: various UI cleanups due to new fixed header on details page

  • [ ] The version string in the sticky header is all uppercase, which renders as GO1.14.6 on standard library packages. This should just be all lowercase
  • [ ] Determine whether to keep uppercase “Package”, “Command”, etc.
  • [ ] The :target selector in stylesheet.css (and in sidenav.css) that’s used to ensure that anchor targets aren’t scrolled below the sticky headers isn’t needed for pages that don’t have them (and need to be adjusted for the new sticky header on the details pages)
  • [ ] Should the homepage should have smart quotes around example searches?

/cc @julieqiu @jamalc

created time in 2 months

issue commentgolang/go

pkgsite: Google Tag Manager is loaded twice

But there is another problem with restoring the noscript iframe: the GTM ID is now in the DOM (rather than part of the template data). Can it be accessed without JS?

Can we include it in the template data?

andybons

comment created time in 2 months

issue openedgolang/go

pkgsite: mixed content warning on overview pages with links to third-party, insecure content

https://pkg.go.dev/github.com/sirupsen/logrus@v1.6.0?tab=overview triggers a mixed-content warning “Not Secure” in Chrome’s location bar.

GitHub (https://github.com/sirupsen/logrus/blob/v1.6.0/README.md) serves these assets themselves via https with a data-canonical-url attribute containing the original source.

NPM serves mixed content (https://www.npmjs.com/package/moment).

created time in 2 months

issue commentgolang/go

crypto/ed25519: differences in edge case handling between s390x KDSA implementation and Go implementation

@FiloSottile as the tree is still frozen, if the change lands in the master branch it will be merged into the 1.15 release branch before the next RC or final release.

mundaym

comment created time in 2 months

GollumEvent

issue closedgolang/go

blog: sidebar sometimes overlaps with the code blocks

On some articles the sidebar will overlap with the code blocks: https://blog.golang.org/error-handling-and-go

closed time in 2 months

andybons

issue openedgolang/go

pkgsite: Google Tag Manager is loaded twice

The following snippet:

f = document.createElement("iframe")
f.src = gtmURL;
f.height = "0";
f.width = "0";
f.style = "display:none;visibility:hidden"
s = document.createElement("noscript");
s.appendChild(f);
document.head.appendChild(s);

Is meant to replace the following:

<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-W8MVQXG" height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>

However, the <noscript> tag is explicitly a fallback for when JavaScript is not available, so replacing it with JavaScript doesn’t achieve its desired purpose (and ends up loading the GTM snippet again within the iframe).

As I understand it, this was done for security reasons.

/cc @jba @jamalc

created time in 2 months

issue commentgolang/go

database/sql: context cancellation allows statements to execute after rollback [1.14 backport]

Thank you very much for the quick review, @kardianos.

gopherbot

comment created time in 2 months

GollumEvent

issue closedgolang/go

all: Go 1.13.14 release status

Issue tracking the go1.13.14 release by releasebot.

closed time in 2 months

andybons

issue closedgolang/go

all: Go 1.14.6 release status

Issue tracking the go1.14.6 release by releasebot.

closed time in 2 months

andybons

issue closedgolang/go

x/website: golang.org "https://golang.org/VERSION?m=text" not return newest version of Go

URL:https://golang.org/VERSION?m=text respond go version go1.14.4

but

URL:https://golang.org/dl/?mode=json respond newest go version go1.14.5

closed time in 2 months

gsymons
more