This fixes the window is not defined error when doing server side rendering. The suggestions dependency is what was causing this issue and this issue has been fixed in v1.7.1. PR that fixed the issue https://github.com/tristen/suggestions/pull/42.

Overview

When using the geocoder outside of a map, as part of a form, pressing the Enter key in another field will bring the focus of the form to the geocoder input. This is unexpected behavior which prevents users from submitting forms via Enter and breaks the overall flow of filling out a form.

Library Version

• v4.7.0

Reproducible Example

• Visit https://codepen.io/zoran/pen/RwRXxKj
• Click into any of the non-geocoder fields
• Press the Enter key

Expected Behavior

• The Enter button should behave as it normally would in a form (i.e. submitting form when appropriate).

Current Behavior

• The form changes focus to the geocoder input.

Notes

• This issue doesn't seem to happen when the geocoder input is placed after the submit button, e.g.:

<!-- This order does not produce the focus-on-Enter issue -->
<input type="text" name="example_email" placeholder="Email">
<input type="submit" value="Submit" tabindex="-1">
<div class="geocoder"></div>

Published v1.7.1

Bumps handlebars from 3.0.7 to 3.0.8. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/handlebars-lang/handlebars.js/blob/v3.0.8/release-notes.md">handlebars's changelog</a>.</em></p> <blockquote> <h2>v3.0.8 - February 23rd, 2020</h2> <p>Bugfixes:</p> <ul> <li>backport some (but not all) of the security fixes from 4.x - 156061e</li> </ul> <p>Compatibility notes:</p> <ul> <li>The properties <code>proto</code>, <code>defineGetter</code>, <code>defineSetter</code> and <code>lookupGetter</code> have been added to the list of "dangerous properties". If a property by that name is found and not an own-property of its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent Remote-Code-Execution exploits that have been published in npm advisories <a href="https://www.npmjs.com/advisories/1324">1324</a> and <a href="https://www.npmjs.com/advisories/1316">1316</a>.</li> <li>The check for dangerous properties has been changed from "propertyIsEnumerable" to "hasOwnProperty", as it is now done in Handlebars 4.6.0 and later.</li> </ul> <p>Security issues resolved:</p> <ul> <li><a href="https://www.npmjs.com/advisories/1324">npm advisory 1324</a></li> <li><a href="https://www.npmjs.com/advisories/1316">npm advisory 1316</a></li> <li><a href="https://www.npmjs.com/advisories/1325">npm advisory 1325</a></li> <li><a href="https://www.npmjs.com/advisories/1164">npm advisory 1164</a></li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v3.0.7...v3.0.8">Commits</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/16bd606fec0ada4c811eb7afe6bfd619d88f3d37"><code>16bd606</code></a> v3.0.8</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/90ad8d97ad2933852fb83fcc054699dc99e094db"><code>90ad8d9</code></a> Update release notes</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/156061eb7707575293613d7fdf90e2bdaac029ee"><code>156061e</code></a> backport fixes from 4.x</li> <li><a href="https://github.com/handlebars-lang/handlebars.js/commit/8ba91592aa28e1360c4d5099c46521c50d237ac1"><code>8ba9159</code></a> update package-lock.json</li> <li>See full diff in <a href="https://github.com/wycats/handlebars.js/compare/v3.0.7...v3.0.8">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Thanks for the PR!

This prevents window is not defined error when using SSR frameworks such as Next.js.

Sample Next.js app that demonstrates error when trying to import suggestions module: https://github.com/SamSamskies/suggestions-demo

Screenshot of error:

I completely agree with you on this, this is why we are aligning on micro location if it is necessary.

How will you alter road alignment? Peru has a very rough terrain, which gives issues with imagery alignment. All imagery sources I've found so far had alignment issues. You could align it on one position, but a few 100m further, it would start to deviate.

Even GPS is often imprecise next to cliffs and under trees.

I don't think bad alignment is a huge issue. If the relative alignment is correct, and features get named, this already give a whole lot of valuable information on the map. But I would refrain from aligning complete street layouts to a certain imagery source.

This behavior was recently introduced via https://github.com/mapbox/mapbox-gl-geocoder/pull/345.

I could not get around the issue with the dynamic import (works on dev, but vercel rebuilds the node_modules folder based on package.json)

What do you mean by this? You shouldn't be editing the files inside of the node_modules folder. The only time I'd do this is when trying to debug issues with dependencies.

Specifying { ssr: false } as an option to your dynamic import should get around the window is not defined issue because then the import will only execute in the browser.

Here are some that I just found

Sullana way 707870466 way 874693174

Catacaos way 532326293 way 863865787

Lambayeque way 666163227 way 91014053

Puente Piedra way 292232424 way 872866003

Thank you so much for the quick response and for sharing such great examples!

We are aligning a network to the existing network, and even though we are trying to avoid such cases, sometimes it is not possible at all since the geometry of the buildings isn't exact, but the approximation of the footprint.

There are such bad cases like you've shared:

We will try to avoid making new logical issues in the future, but it would be great if the community can organize a mapathlon and fix such irregular buildings. We are aligning the road network to the existing one, so we are very often unable to avoid such crossings since whoever done building footprints, haven't check whether aerial imagery is aligned to the road network before they have started tracing the footprints.

Thanks once again, Nemanja

Here are some that I just found

Sullana way 707870466 way 874693174

Catacaos way 532326293 way 863865787

Lambayeque way 666163227 way 91014053

Puente Piedra way 292232424 way 872866003

Hello, thanks for the post.

Please send exact samples for further investigation. If there is a barrier and you have a local knowledge, please feel free to add a proper barrier on a node of the highway.

I could not get around the issue with the dynamic import. The vercel builder still throws an error on deployment. I was able to deploy my website through firebase hosting though. Here is a link to a simple deployment method if you are a firebase user. NextJS and Firebase Hosting

how do i "npm install suggestions" with this pull request? next js deployment installs the version without this change and errors out my build

That's actually exactly why I made this PR. I think you can import this library using Next.js dynamic imports to get around the issue for now. https://nextjs.org/docs/advanced-features/dynamic-import#with-no-ssr.

You could also fork this repo and merge this PR in your fork and use your forked version. Last release for this library was 13 months ago, so I'm not sure if it's being maintained anymore.

Hello, I have noticed in Piura several street crossings with buildings, in the same way I just saw in Huaral a barrier crossing with a street. Please avoid these street crossings when adding streets in Peru.

how do i npm install suggestions with this pull request? next js deployment installs the version without this change and errors out my build

https://github.com/mapbox/mapbox-gl-geocoder/blob/master/API.md#setinput is used to only populate the input (at least 4.5.1).

So, for intstance, if I call

geocoder.setInput("New York")

I get this:

but in the latest version (4.7.0) it has changed and now it shows the results dropdown:

Is that a bug or intentional new behaviour?

Hi,

when I am use compare.remove(); it will show the after map, can we show the before map ?

compare = new mapboxgl.Compare(before, after, container, { mousemove: true, // Optional. Set to true to enable swiping during cursor movement. orientation: 'vertical' // Optional. Sets the orientation of swiper to horizontal or vertical, defaults to vertical }); compare.remove();

Thanks

Hi,

when I am use compare.remove(); it will remove the before map, there is away to remove the after map ?

compare = new mapboxgl.Compare(before, after, container, { mousemove: true, // Optional. Set to true to enable swiping during cursor movement. orientation: 'vertical' // Optional. Sets the orientation of swiper to horizontal or vertical, defaults to vertical }); compare.remove();

Thanks

This adds the Tilesets.replaceTilesetSource method to the Tilesets service. https://docs.mapbox.com/api/maps/#replace-a-tileset-source

I'm reading through the development requirements, and think I need to verify a few things:

• https://github.com/mapbox/mapbox-sdk-js/blob/main/docs/development.md#service-method-naming-conventions suggests PUT methods should be named put*, so should I rename this to Tilesets.putTilesetSource? Happy to change it!
• I considered adding a replace: true option to Tilesets.createTilesetSource method instead of an entirely new method. This would effectively change POST to PUT, but I wasn't able to find any instances of this pattern in the rest of the SDK. Thoughts on this idea?

Also massive h/t to @andrewharvey for adding the Tilesets service to the SDK originally. So good!

cc @katydecorah @andrewharvey