profile
viewpoint
Anders Kaseorg andersk @zulip San Francisco, CA

andersk/barnowl 1

A multi-protocol curses IM client.

andersk/bluechips 1

Finances for people with shared expenses

andersk/500-empty-jest-tests 0

Test nothing, very carefully (for facebook/jest#9554)

andersk/6.004_courseware 0

Courseware used in the 6.004 Labs (jsim, tmsim, bsim)

andersk/agda 0

Agda is a dependently typed programming language / interactive theorem prover.

andersk/allrgb 0

Code for allRGB submissions

andersk/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

andersk/appstream-glib 0

This library provides objects and helper methods to help reading and writing AppStream metadata.

andersk/are-we-learning-yet 0

How ready is Rust for Machine Learning?

pull request commentzulip/zulip

settings: Rework user_group save_discard widget.

Hi @timabbott @showell could you review this one? Thanks!

aniketsonu

comment created time in 25 minutes

push eventmit/police-logs

mitbot

commit sha 68206d7645b37f41ab88616c8e6d1d4e1530c1da

Tue Nov 24 11:00:00 2020 -0400

view details

push time in an hour

issue commentmobile-shell/mosh

mosh causes emacs remote directory tracking to fail

According to the discussion in [emacs-libvterm/issues/454(https://github.com/akermu/emacs-libvterm/issues/454), mosh needs support for OSC 51.

greened

comment created time in 3 hours

issue commentzulip/zulip

xi.zulipchat.com: After deactivating account, I cannot re-register anymore

Sure, makes sense.

@timabbott I forgot to mention, I did contact the administrators of the Xi instance and got access again, so all's well from my end. Thanks for the helpful hint though! :)

runiq

comment created time in 4 hours

issue commentzulip/zulip

Sync LDAP users before first login

Hello , is this created yet? his is a must in my opinion and all other platforms offer it .

amartin3225

comment created time in 5 hours

PR opened zulip/zulip

[WIP]actions: Refactor check_message to return a dataclass instead of Dict.

<!-- What's this PR for? (Just a link to an issue is fine.) --> This PR refactors the check_message function in zerver/lib/actions.py to return a dataclass instead of Dict. Also added few prep commits.

Testing plan: <!-- How have you tested? --> Modified the tests.

<!-- If a UI change. See: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html -->

<!-- Also be sure to make clear, coherent commits: https://zulip.readthedocs.io/en/latest/contributing/version-control.html -->

+175 -139

0 comment

7 changed files

pr created time in 6 hours

issue commentzulip/zulip

Migrate all backend tests to use `assertLogs`.

@zulipbot claim

chdinesh1089

comment created time in 6 hours

issue commentzulip/zulip

Migrate all backend tests to use `assertLogs`.

@zulipbot abandon

chdinesh1089

comment created time in 6 hours

issue openedzulip/zulip

Single quotes in usenames double-escaped on emoji-reaction hover

A username like foo'bar shows up as foo&#39;bar in the emoji-reaction hover tooltip on web. See attached screenshot from the Recurse zulip instance.

screenshot

correct username

created time in 7 hours

pull request commentzulip/zulip

full profile popover: show groups and streams

The other feedback I'd have is that toggle looks out of line with the rest of the UI, both visually/CSS wise and in terms of positioning. The first part should be relatively easy -- use the same CSS classes we that define that widget in "subscription settings".

@YashRE42 do you have ideas for how to make the visuals great?

For the css, I am copying that part from the subscription settings. The visuals what do you mean by this part? The one currently is center aligned.

Abhirup-99

comment created time in 7 hours

created repositorynelhage/llama

created time in 11 hours

issue commentzulip/zulip

Move markdown help to a frontend template without hardcoded rendered markdown

@zulipbot abandon

timabbott

comment created time in 14 hours

pull request commentzulip/zulip

left_sidebar: Add tooltip/title for shortcut key associated with "Recent Topics".

I did a change similar to #16784 in your commit.

smitpatel24

comment created time in 14 hours

PR opened zulip/zulip

left_sidebar: Show title when mouse hover anywhere on the button.

Instead of showing title text when user hovers over the text in the button, show title when user hovers anywhere on the button.

+2 -2

0 comment

1 changed file

pr created time in 14 hours

PR closed zulip/zulip

left_sidebar: Add tooltip/title for shortcut key associated with "Recent Topics".

Issue: Missing tooltip/title for "Recent Topics" on the left sidebar.

Testing plan: I have tested it visually by hovering over the "Recent Topics". I have also used the tools/test-js-with-node suite.

GIFs or screenshots:

Before After
before after2
+1 -1

5 comments

1 changed file

smitpatel24

pr closed time in 15 hours

pull request commentzulip/zulip

left_sidebar: Add tooltip/title for shortcut key associated with "Recent Topics".

Cherry picked this PR on top of #15650, it will merged along with it. Closing this, @smitpatel24 thanks!!

smitpatel24

comment created time in 15 hours

pull request commentzulip/zulip

left_sidebar: Add tooltip/title for shortcut key associated with "Recent Topics".

I am ok with us promoting t as a short key for recent topics narrow rather than esc. esc is used for so many purposes and user will eventually figure out that escape key also for to go to RT narrow. t key is more accessible in keyboard and all keyboard types have it so we should promote it.

smitpatel24

comment created time in 15 hours

pull request commentzulip/zulip

Show recent topics as a view.

The build is failing due to some urls missing from the stable version of zulip readthedocs.

amanagr

comment created time in 15 hours

issue openedzulip/zulip

Sentry integration has incorrect url when configured as a webhook

We have the sentry integration for zulip configured as a webhook, and the issue url in the notification is broken -- it has event in the path where it should have events. I think the bug is here: https://github.com/zulip/zulip/blob/master/zerver/webhooks/sentry/view.py#L239

We're loving the new integration overall. Thank you!

created time in 15 hours

pull request commentzulip/zulip

left_sidebar: Add tooltip/title for shortcut key associated with "Recent Topics".

@amanagr do we have a plan for how to get to "All messages" view keyboard shortcuts after this change? We have "Narrow to all unmuted messages" in keyboard shortcuts popover for this. Which is frankly not clear that it is same as All messages. I would say we rename it to All messages for simplicity or add another column for it?

smitpatel24

comment created time in 16 hours

issue openedmobile-shell/mosh

mosh causes emacs remote directory tracking to fail

I use libvterm inside emacs to run terminals. As described here, libvterm-emacs relies on various escape sequences in the shell prrompt to track the curernt directory. The tracking works with ssh but does not work with mosh.

I have filed a comapnion issue against libvterm-emacs. I do not know for certain what is going on but I suspect maybe mosh is neglecting to send some of the escape sequences through.

created time in 16 hours

issue commentzulip/python-zulip-api

Make it easier to find custom bot modules when using zulip-botserver

I saw this and wondered if at least for our packaged bots the registration implementation which I started working on in #517 may be useful?

timabbott

comment created time in 17 hours

pull request commentzulip/zulip

full profile popover: show groups and streams

The other feedback I'd have is that toggle looks out of line with the rest of the UI, both visually/CSS wise and in terms of positioning. The first part should be relatively easy -- use the same CSS classes we that define that widget in "subscription settings".

@YashRE42 do you have ideas for how to make the visuals great?

Abhirup-99

comment created time in 17 hours

pull request commentzulip/zulip

full profile popover: show groups and streams

@Abhirup-99 it looks like your commit messages don't use imperative tone; can you fix that?

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Abhirup-99

comment created time in 17 hours

issue openedzulip/python-zulip-api

Make it easier to find custom bot modules when using zulip-botserver

I don't have a specific proposal, but probably some combination of documenting PYTHONPATH and adjusting how we search for bot modules is well worth doing to make it easier to help folks who are not deeply familiar with Python get bots running successfully. This thread has discussion https://chat.zulip.org/#narrow/stream/92-learning/topic/bot.20basics/near/1068769.

The first step for this issue is coming up with specific proposals for how to improve the implementation or documentation.

created time in 17 hours

pull request commentzulip/zulip

webhooks: Do not log RateLimited exception to webhook logger.

I'd probably prefer to just try to figure out solving those problems; as a subclass of JsonableError, we can write whatever custom code we want for it in its data method (including continuing to have that process_exception handler).

What I'm thinking is basically this:

class RateLimited(JsonableError):
    def data(...):
        result = super(...)
        result['retry-after'] = ...
        return result
alexmv

comment created time in 17 hours

pull request commentzulip/zulip

webhooks: Do not log RateLimited exception to webhook logger.

Aha, OK -- thanks for digging! Can you push a commit to the end of this branch that adds a comment to the RateLimited class (and/or the RateLimitedMiddleware) that distills your above discoveries, for future reference?

alexmv

comment created time in 20 hours

pull request commentzulip/python-zulip-api

api : Encoded certain endpoint parameters.

Hey , @andersk @neiljp , Could you review it again ?

aryanshridhar

comment created time in 21 hours

IssuesEvent

issue commentzulip/zulip

xi.zulipchat.com: After deactivating account, I cannot re-register anymore

@runiq It's worth having this open until the fix is merged, just to keep track of things - so I'll go ahead and reopen for now

runiq

comment created time in 21 hours

more