Hi @timabbott @showell could you review this one? Thanks!

According to the discussion in [emacs-libvterm/issues/454(https://github.com/akermu/emacs-libvterm/issues/454), mosh needs support for OSC 51.

Sure, makes sense.

@timabbott I forgot to mention, I did contact the administrators of the Xi instance and got access again, so all's well from my end. Thanks for the helpful hint though! :)

Hello , is this created yet? his is a must in my opinion and all other platforms offer it .

<!-- What's this PR for? (Just a link to an issue is fine.) --> This PR refactors the check_message function in zerver/lib/actions.py to return a dataclass instead of Dict. Also added few prep commits.

Testing plan: <!-- How have you tested? --> Modified the tests.

<!-- If a UI change. See: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html -->

<!-- Also be sure to make clear, coherent commits: https://zulip.readthedocs.io/en/latest/contributing/version-control.html -->

@zulipbot claim

@zulipbot abandon

A username like foo'bar shows up as foo'bar in the emoji-reaction hover tooltip on web. See attached screenshot from the Recurse zulip instance.

The other feedback I'd have is that toggle looks out of line with the rest of the UI, both visually/CSS wise and in terms of positioning. The first part should be relatively easy -- use the same CSS classes we that define that widget in "subscription settings".

@YashRE42 do you have ideas for how to make the visuals great?

For the css, I am copying that part from the subscription settings. The visuals what do you mean by this part? The one currently is center aligned.

@zulipbot abandon

I did a change similar to #16784 in your commit.

Instead of showing title text when user hovers over the text in the button, show title when user hovers anywhere on the button.

Issue: Missing tooltip/title for "Recent Topics" on the left sidebar.

Testing plan: I have tested it visually by hovering over the "Recent Topics". I have also used the tools/test-js-with-node suite.

GIFs or screenshots:

Before	After

Cherry picked this PR on top of #15650, it will merged along with it. Closing this, @smitpatel24 thanks!!

I am ok with us promoting t as a short key for recent topics narrow rather than esc. esc is used for so many purposes and user will eventually figure out that escape key also for to go to RT narrow. t key is more accessible in keyboard and all keyboard types have it so we should promote it.

The build is failing due to some urls missing from the stable version of zulip readthedocs.

We have the sentry integration for zulip configured as a webhook, and the issue url in the notification is broken -- it has event in the path where it should have events. I think the bug is here: https://github.com/zulip/zulip/blob/master/zerver/webhooks/sentry/view.py#L239

We're loving the new integration overall. Thank you!

@amanagr do we have a plan for how to get to "All messages" view keyboard shortcuts after this change? We have "Narrow to all unmuted messages" in keyboard shortcuts popover for this. Which is frankly not clear that it is same as All messages. I would say we rename it to All messages for simplicity or add another column for it?

I use libvterm inside emacs to run terminals. As described here, libvterm-emacs relies on various escape sequences in the shell prrompt to track the curernt directory. The tracking works with ssh but does not work with mosh.

I have filed a comapnion issue against libvterm-emacs. I do not know for certain what is going on but I suspect maybe mosh is neglecting to send some of the escape sequences through.

I saw this and wondered if at least for our packaged bots the registration implementation which I started working on in #517 may be useful?

The other feedback I'd have is that toggle looks out of line with the rest of the UI, both visually/CSS wise and in terms of positioning. The first part should be relatively easy -- use the same CSS classes we that define that widget in "subscription settings".

@YashRE42 do you have ideas for how to make the visuals great?

@Abhirup-99 it looks like your commit messages don't use imperative tone; can you fix that?

Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

I don't have a specific proposal, but probably some combination of documenting PYTHONPATH and adjusting how we search for bot modules is well worth doing to make it easier to help folks who are not deeply familiar with Python get bots running successfully. This thread has discussion https://chat.zulip.org/#narrow/stream/92-learning/topic/bot.20basics/near/1068769.

The first step for this issue is coming up with specific proposals for how to improve the implementation or documentation.

I'd probably prefer to just try to figure out solving those problems; as a subclass of JsonableError, we can write whatever custom code we want for it in its data method (including continuing to have that process_exception handler).

What I'm thinking is basically this:

class RateLimited(JsonableError):
    def data(...):
        result = super(...)
        result['retry-after'] = ...
        return result

Aha, OK -- thanks for digging! Can you push a commit to the end of this branch that adds a comment to the RateLimited class (and/or the RateLimitedMiddleware) that distills your above discoveries, for future reference?

Hey , @andersk @neiljp , Could you review it again ?

@runiq It's worth having this open until the fix is merged, just to keep track of things - so I'll go ahead and reopen for now