profile
viewpoint

aloucks/directx_math 2

DirectXMath for Rust

aloucks/dacite 1

Mirror of https://gitlab.com/dennis-hamester/dacite

aloucks/ash 0

Vulkan bindings for Rust

aloucks/atom-build-cargo 0

Cargo task runner plugin for atom-build

aloucks/backtrace-rs 0

Backtraces in Rust

aloucks/borderless-window 0

A minimal borderless window with the Windows API

aloucks/bucket 0

AWS Bucket Synchronization Tool

aloucks/cargo 0

The Rust package manager

aloucks/cgmath 0

A linear algebra and mathematics library for computer graphics.

PR merged rust-analyzer/rust-analyzer

add let and letm postfix to turn expressions into variables

Partially resolve #6426

+61 -0

5 comments

2 changed files

bnjjj

pr closed time in 2 minutes

push eventrust-analyzer/rust-analyzer

Benjamin Coenen

commit sha 775c69183cd6c7a2a5c9f27e23e4f4b7bc67f06f

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

Benjamin Coenen

commit sha 474ebd60d1ae1057165e189bb539ba6a410e1d68

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

bors[bot]

commit sha f8726d781a971752a6918a20eea10cddca2114ed

Merge #6601 6601: add let and letm postfix to turn expressions into variables r=matklad a=bnjjj Partially resolve #6426 Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

push time in 2 minutes

issue closedrust-analyzer/rust-analyzer

Introduce postfixes to turn expressions into variables (like IntelliJ's .var).

Create two new postfixes: let and letm.

let:

"Hello, World!".let
let $0 = "Hello, World!";

and letm

"Hello, World!".letm
let mut $0 = "Hello, World!";

If possible, creating variables for expressions being called would be awesome:

vec![1, 2, 3].into_iter().map(|foo| foo * 2);

calling .let after vec![1, 2, 3] would turn into:

let $0 = vec![1, 2, 3];
$0.into_iter().map(|foo| foo * 2);

closed time in 2 minutes

SaiintBrisson

pull request commentrust-analyzer/rust-analyzer

add new assist to change visibility of all struct fields

Not sure it pulls its weight -- there's "change visibility" for a single field already, so you can just repeat that. And there are always multiple cursors to do this change manually...

bnjjj

comment created time in 7 minutes

push eventrust-analyzer/rust-analyzer

Benjamin Coenen

commit sha 775c69183cd6c7a2a5c9f27e23e4f4b7bc67f06f

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

Benjamin Coenen

commit sha 474ebd60d1ae1057165e189bb539ba6a410e1d68

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

bors[bot]

commit sha f8726d781a971752a6918a20eea10cddca2114ed

Merge #6601 6601: add let and letm postfix to turn expressions into variables r=matklad a=bnjjj Partially resolve #6426 Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

push time in 9 minutes

delete branch rust-analyzer/rust-analyzer

delete branch : staging.tmp

delete time in 9 minutes

push eventrust-analyzer/rust-analyzer

Benjamin Coenen

commit sha 775c69183cd6c7a2a5c9f27e23e4f4b7bc67f06f

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

Benjamin Coenen

commit sha 474ebd60d1ae1057165e189bb539ba6a410e1d68

add let and letm postfix to turn expressions into variables Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>

view details

bors[bot]

commit sha 3bb44db170c2fcc34d71a58f3873b741bf9979b9

[ci skip][skip ci][skip netlify] -bors-staging-tmp-6601

view details

push time in 9 minutes

create barnchrust-analyzer/rust-analyzer

branch : staging.tmp

created branch time in 9 minutes

pull request commentrust-analyzer/rust-analyzer

add let and letm postfix to turn expressions into variables

bors r+

bnjjj

comment created time in 9 minutes

issue commentrust-analyzer/rust-analyzer

Odd markdown language IDs

Yeah, we should fix it. Rust documentation format assumes rust as the default language, and adds various meta info after backtics. At the moment, we send md to the client mostly as is. Instead, we should restore the implied rust there, and probably strip rustdoc's meta.

rwols

comment created time in 11 minutes

push eventrust-analyzer/rust-analyzer

bors[bot]

commit sha 04a06011a407edc7b1732ec8484515508471adff

deploy: 68910d2f341ddd7635265c3847712cc7e44ef75e

view details

push time in 14 minutes

pull request commentocornut/imgui

Override 3 more functions for stb_truetype

Hello, why closing the PR?

BerkanYildiz

comment created time in 16 minutes

PR merged rust-analyzer/rust-analyzer

Allow renaming between self and first param with owned parameters

This fixes renaming owned SelfParams turning the parameter into a reference, as in, for a type Foo, fn foo(self) {} became fn foo(renamed_name: &Foo) {} prior to this.

Similarly for the other way around, we now support renaming non-ref parameters to self. Additionally we do more checks now than before. We check:

  • that the function has an impl block
  • that we are renaming the first parameter(prior we ignored which parameter was renamed and always picked the first nevertheless)
  • that the parameter's type aligns with the impl block(minus one level of reference abstraction to account for &self/&mut self)
+152 -14

2 comments

1 changed file

Veykril

pr closed time in 17 minutes

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha f4a77f34da3d0d849c1e0b78b95df77485a57a3d

Fix renaming owned self to parameter emitting ref

view details

Lukas Wirth

commit sha 4c33ae33e96a0087f9f8451fc100b8681237d05f

Reject more cases of invalid parameter to self renames

view details

bors[bot]

commit sha 68910d2f341ddd7635265c3847712cc7e44ef75e

Merge #6670 6670: Allow renaming between self and first param with owned parameters r=matklad a=Veykril This fixes renaming owned SelfParams turning the parameter into a reference, as in, for a type `Foo`, `fn foo(self) {}` became `fn foo(renamed_name: &Foo) {}` prior to this. Similarly for the other way around, we now support renaming non-ref parameters to `self`. Additionally we do more checks now than before. We check: - that the function has an impl block - that we are renaming the first parameter(prior we ignored which parameter was renamed and always picked the first nevertheless) - that the parameter's type aligns with the impl block(minus one level of reference abstraction to account for `&self`/`&mut self`) Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 17 minutes

Pull request review commentrust-analyzer/rust-analyzer

Support self in reference search

 pub(crate) fn find_all_refs(         get_struct_def_name_for_struct_literal_search(&sema, &syntax, position)     {         (Some(name), ReferenceKind::StructLiteral)+    } else if let Some(res) = try_find_self_references(&syntax, position) {+        return Some(res);

r=me with this fixed.

Veykril

comment created time in 18 minutes

Pull request review commentrust-analyzer/rust-analyzer

Support self in reference search

 pub(crate) fn find_all_refs(         get_struct_def_name_for_struct_literal_search(&sema, &syntax, position)     {         (Some(name), ReferenceKind::StructLiteral)+    } else if let Some(res) = try_find_self_references(&syntax, position) {+        return Some(res);

The control flow in this one is weird. Let's just move this as a guarded return before the let?

Veykril

comment created time in 19 minutes

delete branch rust-analyzer/rust-analyzer

delete branch : staging.tmp

delete time in 23 minutes

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha f4a77f34da3d0d849c1e0b78b95df77485a57a3d

Fix renaming owned self to parameter emitting ref

view details

Lukas Wirth

commit sha 4c33ae33e96a0087f9f8451fc100b8681237d05f

Reject more cases of invalid parameter to self renames

view details

bors[bot]

commit sha 68910d2f341ddd7635265c3847712cc7e44ef75e

Merge #6670 6670: Allow renaming between self and first param with owned parameters r=matklad a=Veykril This fixes renaming owned SelfParams turning the parameter into a reference, as in, for a type `Foo`, `fn foo(self) {}` became `fn foo(renamed_name: &Foo) {}` prior to this. Similarly for the other way around, we now support renaming non-ref parameters to `self`. Additionally we do more checks now than before. We check: - that the function has an impl block - that we are renaming the first parameter(prior we ignored which parameter was renamed and always picked the first nevertheless) - that the parameter's type aligns with the impl block(minus one level of reference abstraction to account for `&self`/`&mut self`) Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

view details

push time in 23 minutes

push eventrust-analyzer/rust-analyzer

Lukas Wirth

commit sha f4a77f34da3d0d849c1e0b78b95df77485a57a3d

Fix renaming owned self to parameter emitting ref

view details

Lukas Wirth

commit sha 4c33ae33e96a0087f9f8451fc100b8681237d05f

Reject more cases of invalid parameter to self renames

view details

bors[bot]

commit sha f56d580e15bb89173d82d3670de3352ef3a48d64

[ci skip][skip ci][skip netlify] -bors-staging-tmp-6670

view details

push time in 23 minutes

create barnchrust-analyzer/rust-analyzer

branch : staging.tmp

created branch time in 23 minutes

Pull request review commentrust-windowing/winit

Windows: Changed thread_event_target_callback's WM_DESTROY to WM_NCDESTROY

 unsafe extern "system" fn thread_event_target_callback<T: 'static>(     // the closure to catch_unwind directly so that the match body indendation wouldn't change and     // the git blame and history would be preserved.     let callback = || match msg {-        winuser::WM_DESTROY => {+        winuser::WM_NCDESTROY => {

The documentation says WM_DESTROY is for destruction of the main window, while WM_NCDESTROY is for child windows.

Looking at the docs, it seems like winit should be using WM_DESTROY, what makes you believe that WM_NCDESTROY is the better choice?

VZout

comment created time in 28 minutes

issue closedCedricGuillemet/ImGuizmo

ImGuizmo the Scaling not shown

ImGuizmo Hi . The e1,e2,e3 axis vector doesn't seem to be showing. Please help. Thank you

closed time in an hour

jeroentyx

issue commentCedricGuillemet/ImGuizmo

ImGuizmo the Scaling not shown

Ahhh.... i got it. Thank you i really appreciate your help :)

jeroentyx

comment created time in an hour

PR closed ocornut/imgui

Override 3 more functions for stb_truetype

Just redefining 3 more macros for stb_truetype, because I am not using the default implementations and stbtt throws. This way, stbtt will compile without any more modifications (if the user properly redefined the math functions, obviously [#ifdef/#endif]).

I'm not sure for STBTT_strlen, I havn't seen a strlen function in ImGui, only one for wide chars I believe. Feel free to modify if there is actually one.

Those 2 functions can also be overriden:

STBTT_memcpy
STBTT_memset

It throws because I am not implementing the default ones, and instead use/define my own functions (using SS3/AVX-512) :

image

+3 -0

0 comment

1 changed file

BerkanYildiz

pr closed time in an hour

issue commentrust-analyzer/rust-analyzer

Feature request: Run check or clippy without saving

This would be a great feature !

danielhuang

comment created time in an hour

issue commentCedricGuillemet/ImGuizmo

ImGuizmo the Scaling not shown

The values of the matrix should look like this: 10, 0, 0, 0 0, 10, 0, 0 0, 0, 1, 0 0, 0, 0, 1

Are you multiplying viewproj to the model matrix?

jeroentyx

comment created time in an hour

release 4bb4/implot-rs

v0.3.0

released time in an hour

more