profile
viewpoint
Allen Sun allencloud @alibaba Hangzhou, China An Open Source Guy skilled at Container Technology, docker , PaaS, Linux, etc. I like to help people. We are hiring!

alibaba/Sentinel 10825

A lightweight powerful flow control component enabling reliability and monitoring for microservices. (面向云原生微服务的流量控制、熔断降级组件)

alibaba/pouch 4143

An Efficient Enterprise-class Container Engine

allencloud/docker-changelog-chinese 108

docker变更日志中文版

alibaba/containerd 17

A daemon to control OCI container runtimes

allencloud/daoker 5

A tool to manage Docker environment regardless of docker daemon's failure

allencloud/docker 3

Docker - the open-source application container engine

allencloud/allocate-memory 2

A simple web app to dynamically allocate memory due to api request

allencloud/awesome-docker 1

:whale: A curated list of Docker resources and projects

allencloud/cobra 1

A Commander for modern Go CLI interactions

allencloud/containerd 1

An open and reliable container runtime, by Docker

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

1 comment

1 changed file

pouchrobot

pr closed time in 3 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 6dd69a9c6845255bd2b858bf76f916c41032f4b6

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 8712de35558e6fbcd6e4575b39951ef51fe2bc2a

Merge pull request #1228 from pouchrobot/auto-doc-2020-02-20 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 3 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

1 comment

1 changed file

pouchrobot

pr closed time in 3 days

delete branch allencloud/Dragonfly

delete branch : remove-gitter

delete time in 4 days

push eventdragonflyoss/Dragonfly

Allen Sun

commit sha 2d41e64cab6841fd1b0262d87b673b3fc45267fb

docs: remove gitter from realtime chatting tools Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>

view details

Allen Sun

commit sha fc56458cae0cad14b8de22515bea4edf7d09ec2b

Merge pull request #1215 from allencloud/remove-gitter docs: remove gitter from realtime chatting tools

view details

push time in 4 days

PR merged dragonflyoss/Dragonfly

docs: remove gitter from realtime chatting tools LGTM areas/docs size/XS

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

This PR removed gitter from realtime chatting tools, since I think we are no longer at the gitter tools. While we suggest that github issue and dingtalk is the direct way we could use to communicate in real time.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

+1 -3

1 comment

1 changed file

allencloud

pr closed time in 4 days

push eventdragonflyoss/Dragonfly

Lu Fengqi

commit sha 58ccd6a3ed3fc48a4c092db1571a8583899932f1

pkg/fileutils: constructing errors following conventions Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

view details

Allen Sun

commit sha dcd35d50e4f2b3ad1cc520c9aefe5dbcddb4a697

Merge pull request #1225 from littleroad/construct_error_with_conventions Construct errors following conventions

view details

push time in 4 days

PR merged dragonflyoss/Dragonfly

Construct errors following conventions kind/bug size/M

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

According to the suggestions given by Allen, reconstruct all errors in pkg/fileutils following conventions.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+23 -22

4 comments

1 changed file

littleroad

pr closed time in 4 days

pull request commentdragonflyoss/Dragonfly

Construct errors following conventions

LGTM

littleroad

comment created time in 4 days

pull request commentdragonflyoss/Dragonfly

Construct errors following conventions

Please squash all your commits into a single one. @littleroad thx

littleroad

comment created time in 5 days

push eventdragonflyoss/Dragonfly

Guangwen Feng

commit sha d1fbbd3908048978a2479abd1bb206953971a356

test: add unit test case for func GetAllPeerIDs Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>

view details

Allen Sun

commit sha caad9fd9367a3e6eeb6e85e994278d4ac6a342e9

Merge pull request #1194 from fenggw-fnst/work2 test: add unit test case for func GetAllPeerIDs

view details

push time in 5 days

PR merged dragonflyoss/Dragonfly

Reviewers
test: add unit test case for func GetAllPeerIDs LGTM areas/test size/S

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Add unit test case for func GetAllPeerIDs

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

go test github.com/dragonflyoss/Dragonfly/supernode/daemon/mgr/peer -run Test -v

Ⅴ. Special notes for reviews

+32 -0

4 comments

1 changed file

fenggw-fnst

pr closed time in 5 days

pull request commentdragonflyoss/Dragonfly

test: add unit test case for func GetAllPeerIDs

LGTM

fenggw-fnst

comment created time in 5 days

push eventdragonflyoss/Dragonfly

Zhou Hao

commit sha e33b08fd8c6a3e7d159e7d23eb7cbac5e078d23e

pkg/fileutils: add unit test for IsRegularFile Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>

view details

Allen Sun

commit sha a88b5f094e7a155db585360bb941d6442c282f95

Merge pull request #1219 from q384566678/add-fileutils-test pkg/fileutils: add unit test for IsRegularFile

view details

push time in 5 days

PR merged dragonflyoss/Dragonfly

pkg/fileutils: add unit test for IsRegularFile areas/test size/S

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+14 -0

2 comments

1 changed file

q384566678

pr closed time in 5 days

pull request commentdragonflyoss/Dragonfly

pkg/fileutils: add unit test for IsRegularFile

LGTM

q384566678

comment created time in 5 days

Pull request review commentdragonflyoss/Dragonfly

Construct errors following conventions

 func CopyFile(src string, dst string) (err error) { 		d *os.File 	) 	if !IsRegularFile(src) {-		return fmt.Errorf("copy file:%s error, is not a regular file", src)+		return fmt.Errorf("failed to copy %s to %s: src is not a regular file", src, dst) 	} 	if s, err = os.Open(src); err != nil {-		return err+		return fmt.Errorf("failed to copy %s to %s when opening src file: %v", src, dst, err) 	} 	defer s.Close()  	if PathExist(dst) {-		return fmt.Errorf("copy file:%s error, dst file already exists", dst)+		return fmt.Errorf("failed to copy %s to %s: dst file already exists", src, dst) 	}  	if d, err = OpenFile(dst, os.O_RDWR|os.O_TRUNC|os.O_CREATE, 0755); err != nil {-		return err+		return fmt.Errorf("failed to copy %s to %s when opening dst file: %v", src, dst, err)

Please make this distinguished from the Line 114 of this file, since when log shows the error message, you will be confused whether it is from L114 or L123. I am wondering if I am right. Thanks.

littleroad

comment created time in 5 days

push eventdragonflyoss/Dragonfly

Guangwen Feng

commit sha 46593a5fa8ac9e34c13b1fe27291d16159e1d6b0

fix typo: fix comment for const var DefaultFailureCountLimit Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>

view details

Allen Sun

commit sha 6dd279b09629deb3c429400a503fe08b973b6258

Merge pull request #1226 from fenggw-fnst/work fix typo: fix comment for const var DefaultFailureCountLimit

view details

push time in 5 days

PR merged dragonflyoss/Dragonfly

fix typo: fix comment for const var DefaultFailureCountLimit

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Fix comment for const var in supernode/config/constants.go, 'DefaultFailCountLimit' -> 'DefaultFailureCountLimit'

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+1 -1

2 comments

1 changed file

fenggw-fnst

pr closed time in 5 days

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2020-01-03 to 2020-01-10

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
193 (↑1) 4510 (↑9) 594 (↑5) 59 (↑1) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 8 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

bugfix 🐛 🔪

  • fix: use StringArrayVar to parse http header (#1166)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1169)

test ✅ ☑️

  • test: add unit test case for func GetAsInt (#1170)
  • test: add unit test case for func Remove (#1167)
  • test: add unit test case for func ParsePieceIndex (#1160)

others

  • fix typo: fix comment for func Print (#1165)
  • fix typo: fix comment for func ParseNodesString (#1163)
  • Refactor: make version subcommand as a public subcommand (#1159)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@lowzj 10
@xujihui1985 1
@truongnh1992 1
@Starnop 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 6 days

pouchrobot

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2020-01-10 to 2020-01-17

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
194 (↑1) 4525 (↑15) 602 (↑8) 62 (↑3) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 21 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feat: generate task per http range (#1180)

bugfix 🐛 🔪

  • bugfix: retry multi times if failed to report pieces (#1185)
  • bugfix: update cdn fail when the content is being read and the source server is down (#1152)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1188)
  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1182)
  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1169)
  • docs: add more detail steps in workspace preparation (#1156)
  • docs: update docs about deploy with Physical Machines (#1120)
  • docs: add a doc about using dragonfly with harbor registry (#1028)
  • docs: optimize the config documents (#1024)

test ✅ ☑️

  • test: add unit test case for func GetAsBitset (#1187)
  • test: add unit test case for func GetAsMap (#1184)
  • test: add util test for atomiccount (#1178)
  • test: add unit test case for func GetAsBool (#1176)
  • test: add test case in unit test TestParseFilter (#1173)
  • test: add unit test case for func GetAsString (#1172)
  • test: add unit test case for func GetAsInt (#1170)

others

  • code clean: remove tmp file (dfget-31028-1577713727.584.tmp-027362658) (#1183)
  • add unit test for GetMsgByCode (#1179)
  • Securing many http links to https links (#1174)
  • Configure dfclient/dfdaemon/dfget log file path via 'logConfig.path' property (#1145)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@lowzj 23
@Starnop 4
@xujihui1985 1
@YanzheL 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 6 days

pouchrobot

issue closeddragonflyoss/Dragonfly

Weekly Digest (26 January, 2020 - 2 February, 2020)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 2 issues were created. Of these, 1 issues have been closed and 1 issues are still open.

OPEN ISSUES

:green_heart: #1201 WeeklyReport of Dragonfly from 2020-01-24 to 2020-01-31, by pouchrobot

CLOSED ISSUES

:heart: #1202 docs: trivial fix some typos, by truongnh1992

NOISY ISSUE

:speaker: #1202 docs: trivial fix some typos, by truongnh1992 It received 1 comments.


PULL REQUESTS

Last week, 8 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 7 pull requests were updated. :yellow_heart: #1181 feature: Hijack HTTPS by generating leaf TLS certs on the fly issued by user provided CA., by YanzheL :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 1 pull request was merged. :purple_heart: #1202 docs: trivial fix some typos, by truongnh1992


COMMITS

Last week there were 2 commits. :hammer_and_wrench: Merge pull request #1202 from truongnh1992/typo docs: trivial fix some typos by yeya24 :hammer_and_wrench: docs: trivial fix some typos Although it is spelling mistakes, it might make an affects while reading. Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com by truongnh1992


CONTRIBUTORS

Last week there were 2 contributors. :bust_in_silhouette: yeya24 :bust_in_silhouette: truongnh1992


STARGAZERS

Last week there were 8 stagazers. :star: sdbrain :star: poooooooooke :star: XrosLiang :star: HansonLu :star: AndrewOYLK :star: kiwionly :star: Jane-fine :star: Redxtorm You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in 6 days

weekly-digest[bot]

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2020-02-07 to 2020-02-14

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
195 (↑0) 4569 (↑7) 607 (↑1) 63 (↑1) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 5 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feature: add client stream writer for Streaming (#1186)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1218)

others

  • pkg/syncmap: add unit test for GetAsAtomicInt (#1216)
  • pkg/constants: improve GetMsgByCode test (#1214)
  • Fix markdown syntax in documentation (#1212)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@allencloud 13
@wangforthinker 4
@q384566678 3
@lowzj 1
@yeya24 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 6 days

pouchrobot

issue closeddragonflyoss/Dragonfly

Weekly Digest (9 February, 2020 - 16 February, 2020)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 12 issues were created. Of these, 4 issues have been closed and 8 issues are still open.

OPEN ISSUES

:green_heart: #1223 pkg/fileutils: add verifications and unit test for SymboliLlink, by littleroad :green_heart: #1222 WeeklyReport of Dragonfly from 2020-02-07 to 2020-02-14, by pouchrobot :green_heart: #1221 add unit test for NodeWightSlice2StringSlice, by q384566678 :green_heart: #1220 docs: add data integrity theory of distributing files and blocks, by allencloud :green_heart: #1219 pkg/fileutils: add unit test for IsRegularFile, by q384566678 :green_heart: #1217 Feature: extract dfget lib, by wangforthinker :green_heart: #1215 docs: remove gitter from realtime chatting tools, by allencloud :green_heart: #1213 feature: support source cdn pattern, by Starnop

CLOSED ISSUES

:heart: #1218 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :heart: #1216 pkg/syncmap: add unit test for GetAsAtomicInt, by q384566678 :heart: #1214 pkg/constants: improve GetMsgByCode test, by q384566678 :heart: #1212 Fix markdown syntax in documentation, by truongnh1992

NOISY ISSUE

:speaker: #1216 pkg/syncmap: add unit test for GetAsAtomicInt, by q384566678 It received 3 comments.


PULL REQUESTS

Last week, 22 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 17 pull requests were updated. :yellow_heart: #1223 pkg/fileutils: add verifications and unit test for SymboliLlink, by littleroad :yellow_heart: #1221 add unit test for NodeWightSlice2StringSlice, by q384566678 :yellow_heart: #1220 docs: add data integrity theory of distributing files and blocks, by allencloud :yellow_heart: #1219 pkg/fileutils: add unit test for IsRegularFile, by q384566678 :yellow_heart: #1217 Feature: extract dfget lib, by wangforthinker :yellow_heart: #1215 docs: remove gitter from realtime chatting tools, by allencloud :yellow_heart: #1213 feature: support source cdn pattern, by Starnop :yellow_heart: #1194 test: add unit test case for func GetAllPeerIDs, by fenggw-fnst :yellow_heart: #1191 [WIP]refactor: split CDN as a separate module, by Starnop :yellow_heart: #1106 [WIP] check docs update only commit, by yeya24 :yellow_heart: #1098 [WIP] docs: update the FAQ doc, by Starnop :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 5 pull requests were merged. :purple_heart: #1218 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #1216 pkg/syncmap: add unit test for GetAsAtomicInt, by q384566678 :purple_heart: #1214 pkg/constants: improve GetMsgByCode test, by q384566678 :purple_heart: #1212 Fix markdown syntax in documentation, by truongnh1992 :purple_heart: #1186 feature: add client stream writer for Streaming, by jim3ma


COMMITS

Last week there were 9 commits. :hammer_and_wrench: Merge pull request #1216 from q384566678/add-suncmap-unit-test pkg/syncmap: add unit test for GetAsAtomicInt by allencloud :hammer_and_wrench: pkg/syncmap: add unit test for GetAsAtomicInt Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678 :hammer_and_wrench: Merge pull request #1214 from q384566678/add-test pkg/constants: improve GetMsgByCode test by allencloud :hammer_and_wrench: Merge pull request #1218 from pouchrobot/auto-doc-2020-02-13 docs: auto generate Dragonfly cli/api/contributors docs via code by allencloud :hammer_and_wrench: docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot pouch-dev@list.alibaba-inc.com by pouchrobot :hammer_and_wrench: Merge pull request #1186 from antsystem/add-client-stream-writer feature: add client stream writer for Streaming by lowzj :hammer_and_wrench: pkg/constants: improve GetMsgByCode test Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678 :hammer_and_wrench: Merge pull request #1212 from truongnh1992/Typo Fix markdown syntax in documentation by yeya24 :hammer_and_wrench: Fix markdown syntax in documentation Although it is small mistake, it might make an affects while reading. Signed-off-by: Nguyen Hai Truong truongnh@vn.fujitsu.com by truongnh1992


CONTRIBUTORS

Last week there were 6 contributors. :bust_in_silhouette: allencloud :bust_in_silhouette: q384566678 :bust_in_silhouette: pouchrobot :bust_in_silhouette: lowzj :bust_in_silhouette: yeya24 :bust_in_silhouette: truongnh1992


STARGAZERS

Last week there were 10 stagazers. :star: 851091009 :star: weinformatics :star: sinkcoder :star: benmarsden :star: geonux :star: joshw123 :star: x0rzkov :star: zydc2010 :star: westfly :star: yubo You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in 6 days

weekly-digest[bot]

pull request commentdragonflyoss/Dragonfly

test: add unit test case for func GetAllPeerIDs

Any update? @fenggw-fnst

fenggw-fnst

comment created time in 6 days

pull request commentdragonflyoss/Dragonfly

docs: remove gitter from realtime chatting tools

LGTM, please take a look. @Starnop @lowzj

allencloud

comment created time in 6 days

Pull request review commentdragonflyoss/Dragonfly

pkg/fileutils: add verifications and unit test for SymboliLlink

 func Link(src string, linkName string) error {  // SymbolicLink creates target as a symbolic link to src. func SymbolicLink(src string, target string) error {-	// TODO Add verifications.+	if !PathExist(src) {+		return fmt.Errorf("Symlink %s to %s: error, src no such file or directory", target, src)+	}+	if PathExist(target) {+		if IsDir(target) {+			return fmt.Errorf("Symlink %s to %s: error, link name already exists and is a directory", target, src)+		}+		if err := DeleteFile(target); err != nil {+			return err

why not to add more details in the error message rather than directly return the error? for example:

return fmt.Errorf("failed to symlink %s to %s when deleting target file: %v", target, src, err)
littleroad

comment created time in 6 days

Pull request review commentdragonflyoss/Dragonfly

pkg/fileutils: add verifications and unit test for SymboliLlink

 func Link(src string, linkName string) error {  // SymbolicLink creates target as a symbolic link to src. func SymbolicLink(src string, target string) error {-	// TODO Add verifications.+	if !PathExist(src) {+		return fmt.Errorf("Symlink %s to %s: error, src no such file or directory", target, src)

when constructing an error, we usually use failed to do sth: <detailed failing reason>, in this case:

fmt.Errorf("failed to symlink %s to %s: src no such file or directory", target, src)

And please follow this rule in other places, thx.

littleroad

comment created time in 7 days

Pull request review commentdragonflyoss/Dragonfly

add unit test for NodeWightSlice2StringSlice

 func (suit *SupernodeValueSuite) TestHandleNodes() { 		} 	} }++func (suit *SupernodeValueSuite) TestNodeWightSlice2StringSlice() {

I think the Wight should be the word Weight, do you think so ? @Starnop @lowzj If that, would change all the Wight into Weightin file https://github.com/dragonflyoss/Dragonfly/blob/b32d1ca03b4111978b2d8a0f398704946e071d99/dfget/config/supernode_value.go and some other files?

q384566678

comment created time in 7 days

push eventdragonflyoss/Dragonfly

Zhou Hao

commit sha 11ce918401303f1004ad147edad335cacb724b25

pkg/syncmap: add unit test for GetAsAtomicInt Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>

view details

Allen Sun

commit sha a3924632a61d9029c92261159416b5970228dcc6

Merge pull request #1216 from q384566678/add-suncmap-unit-test pkg/syncmap: add unit test for GetAsAtomicInt

view details

push time in 9 days

PR merged dragonflyoss/Dragonfly

pkg/syncmap: add unit test for GetAsAtomicInt areas/test size/S

Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+15 -0

3 comments

1 changed file

q384566678

pr closed time in 9 days

pull request commentdragonflyoss/Dragonfly

pkg/syncmap: add unit test for GetAsAtomicInt

LGTM

q384566678

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

pkg/syncmap: add unit test for GetAsAtomicInt

 func (suite *SyncMapUtilSuite) TestGetAsTime(c *check.C) { 	result, _ := mmap.GetAsTime("aaa") 	c.Check(result, check.DeepEquals, expected) }++func (suite *SyncMapUtilSuite) TestGetAsAtomicInt(c *check.C) {+	expected := atomiccount.NewAtomicInt(10)+	mmap := NewSyncMap()+	mmap.Add("aaa", expected)++	result, _ := mmap.GetAsAtomicInt("aaa")+	c.Check(result, check.DeepEquals, expected)++	result, err := mmap.GetAsAtomicInt("nonexist")+	c.Check(err, check.NotNil)+}

Please add c.Check(result, check.IsNil)

q384566678

comment created time in 9 days

pull request commentdragonflyoss/Dragonfly

pkg/syncmap: add unit test for GetAsAtomicInt

CI failed, PTAL:

./hack/golangci-lint.sh
Begin to check gocode with golangci-lint locally
Detected that golangci-lint has already been installed. Start linting...
pkg/syncmap/syncmap_test.go:145:2: SA4006: this value of `result` is never used (staticcheck)
	result, err := mmap.GetAsAtomicInt("nonexist")
	^
Makefile:160: recipe for target 'golangci-lint' failed
make: *** [golangci-lint] Error 1
q384566678

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

+/*+ * Copyright The Dragonfly Authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package p2p++import (+	"context"+	"fmt"+	"io"+	"os"+	"path/filepath"+	"strings"+	"time"++	"github.com/dragonflyoss/Dragonfly/dfdaemon/config"+	dfgetcfg "github.com/dragonflyoss/Dragonfly/dfget/config"+	"github.com/dragonflyoss/Dragonfly/dfget/core"+	"github.com/dragonflyoss/Dragonfly/dfget/core/api"+	"github.com/dragonflyoss/Dragonfly/dfget/core/regist"+)++type DFClient struct {+	config       config.DFGetConfig+	dfGetConfig  *dfgetcfg.Config+	supernodeAPI api.SupernodeAPI+	register     regist.SupernodeRegister+	dfClient     core.DFGet+}++func (c *DFClient) DownloadContext(ctx context.Context, url string, header map[string][]string, name string) (string, error) {+	//	startTime := time.Now()+	dstPath := filepath.Join(c.config.DFRepo, name)+	// r, err := c.doDownload(ctx, url, header, dstPath)+	// if err != nil {+	// 	return "", fmt.Errorf("dfget fail %v", err)+	// }+	// log.Infof("dfget url:%s [SUCCESS] cost:%.3fs", url, time.Since(startTime).Seconds())+	return dstPath, nil+}++func (c *DFClient) DownloadStreamContext(ctx context.Context, url string, header map[string][]string, name string) (io.Reader, error) {+	dstPath := filepath.Join(c.config.DFRepo, name)+	r, err := c.doDownload(ctx, url, header, dstPath)+	if err != nil {+		return nil, fmt.Errorf("dfget fail %v", err)+	}+	return r, nil+}++func convertToDFGetConfig(cfg config.DFGetConfig) *dfgetcfg.Config {+	return &dfgetcfg.Config{+		Nodes:    cfg.SuperNodes,+		DFDaemon: true,+		Pattern:  dfgetcfg.PatternCDN,+		Sign: fmt.Sprintf("%d-%.3f",+			os.Getpid(), float64(time.Now().UnixNano())/float64(time.Second)),+		RV: dfgetcfg.RuntimeVariable{+			LocalIP:  cfg.LocalIP,+			PeerPort: cfg.PeerPort,+		},+	}+}++func NewClient(cfg config.DFGetConfig) *DFClient {+	supernodeAPI := api.NewSupernodeAPI()+	dfGetConfig := convertToDFGetConfig(cfg)+	register := regist.NewSupernodeRegister(dfGetConfig, supernodeAPI)++	client := &DFClient{+		config:       cfg,+		dfGetConfig:  dfGetConfig,+		supernodeAPI: supernodeAPI,+		register:     register,+		dfClient:     core.NewDFGet(),+	}+	client.init()+	return client+}++func (c *DFClient) init() {+	c.dfGetConfig.RV.Cid = getCid(c.dfGetConfig.RV.LocalIP, c.dfGetConfig.Sign)+}++func (c *DFClient) doDownload(ctx context.Context, url string, header map[string][]string, destPath string) (io.Reader, error) {+	runtimeConfig := *c.dfGetConfig+	runtimeConfig.URL = url+	runtimeConfig.RV.TaskURL = url+	runtimeConfig.RV.TaskFileName = getTaskFileName(destPath, c.dfGetConfig.Sign)+	runtimeConfig.Header = flattenHeader(header)+	runtimeConfig.Output = destPath+	runtimeConfig.RV.RealTarget = destPath+	runtimeConfig.RV.TargetDir = filepath.Dir(destPath)+	// if err := fileutils.CreateDirectory(runtimeConfig.RV.TargetDir); err != nil {+	// 	return err+	// }+	//+	// tempTarget, err := createTempTargetFile(runtimeConfig.RV.TargetDir, runtimeConfig.Sign)+	// if err != nil {+	// 	return err+	// }+	// runtimeConfig.RV.TempTarget = tempTarget+	//+	// register := regist.NewSupernodeRegister(&runtimeConfig, c.supernodeAPI)+	// result, e := register.Register(c.dfGetConfig.RV.PeerPort)+	// if e != nil {+	// 	if e.Code == constants.CodeNeedAuth {+	// 		return e+	// 	}+	// 	c.dfGetConfig.BackSourceReason = dfgetcfg.BackSourceReasonRegisterFail+	// 	return e+	// }+	// c.dfGetConfig.RV.FileLength = result.FileLength+	return c.dfClient.GetReader(ctx, &runtimeConfig)+}++func getTaskFileName(realTarget string, sign string) string {+	return filepath.Base(realTarget) + "-" + sign+}++func getCid(localIP string, sign string) string {+	return localIP + "-" + sign+}++func flattenHeader(header map[string][]string) []string {

unit tests are needed.

wangforthinker

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 package app  import (-	"bytes" 	"fmt" 	"os"-	"os/exec" 	"os/user" 	"path/filepath" 	"runtime" 	"time"  	"github.com/dragonflyoss/Dragonfly/dfdaemon/config" 	"github.com/dragonflyoss/Dragonfly/dfdaemon/constant"+	dfgetcfg "github.com/dragonflyoss/Dragonfly/dfget/config"+	"github.com/dragonflyoss/Dragonfly/dfget/util" 	"github.com/dragonflyoss/Dragonfly/pkg/dflog" 	"github.com/dragonflyoss/Dragonfly/pkg/errortypes" 	"github.com/dragonflyoss/Dragonfly/pkg/fileutils"+	"github.com/dragonflyoss/Dragonfly/pkg/httputils"+	"github.com/dragonflyoss/Dragonfly/pkg/netutils" 	statutil "github.com/dragonflyoss/Dragonfly/pkg/stat"+	"github.com/dragonflyoss/Dragonfly/pkg/stringutils"  	"github.com/pkg/errors" 	"github.com/sirupsen/logrus" ) +// adjustSupernodeList adjusts the super nodes [a,b] to [a,b,b,a]+func adjustSupernodeList(nodes []string) []string {+	switch nodesLen := len(nodes); nodesLen {+	case 0:+		return nodes+	case 1:+		return append(nodes, nodes[0])+	default:+		util.Shuffle(nodesLen, func(i, j int) {+			nodes[i], nodes[j] = nodes[j], nodes[i]+		})+		return append(nodes, nodes...)+	}+}++// checkConnectSupernode return the localIP which connects to supper node+func checkConnectSupernode(nodes []string) (localIP string) {+	var (+		e error+	)+	for _, n := range nodes {+		ip, port := netutils.GetIPAndPortFromNode(n, dfgetcfg.DefaultSupernodePort)+		if localIP, e = httputils.CheckConnect(ip, port, 1000); e == nil {+			return localIP+		}+		logrus.Errorf("Connect to node:%s error: %v", n, e)

I am afraid that we had better use a Warn log level for this line of log.

wangforthinker

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 package app  import (-	"bytes" 	"fmt" 	"os"-	"os/exec" 	"os/user" 	"path/filepath" 	"runtime" 	"time"  	"github.com/dragonflyoss/Dragonfly/dfdaemon/config" 	"github.com/dragonflyoss/Dragonfly/dfdaemon/constant"+	dfgetcfg "github.com/dragonflyoss/Dragonfly/dfget/config"+	"github.com/dragonflyoss/Dragonfly/dfget/util" 	"github.com/dragonflyoss/Dragonfly/pkg/dflog" 	"github.com/dragonflyoss/Dragonfly/pkg/errortypes" 	"github.com/dragonflyoss/Dragonfly/pkg/fileutils"+	"github.com/dragonflyoss/Dragonfly/pkg/httputils"+	"github.com/dragonflyoss/Dragonfly/pkg/netutils" 	statutil "github.com/dragonflyoss/Dragonfly/pkg/stat"+	"github.com/dragonflyoss/Dragonfly/pkg/stringutils"  	"github.com/pkg/errors" 	"github.com/sirupsen/logrus" ) +func adjustSupernodeList(nodes []string) []string {

Why to do this? Could you be more specific?

wangforthinker

comment created time in 9 days

issue commentdragonflyoss/Dragonfly

Dfdaemon produced error when pulling image

Do I just to add the environment variable to the dockerfile and compile the source code ?

Yes, if that is the answer, you can add the env in dockerfile's RUN command to build the binary via source code.

liy516

comment created time in 9 days

push eventallencloud/Dragonfly

Allen Sun

commit sha 5e94ef22de6b9becf3d47e70f2103271d5978bdc

docs: add data integrity theory of distributing files and blocks Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>

view details

push time in 9 days

push eventallencloud/Dragonfly

Allen Sun

commit sha 4ebcbcbd8900d6bfa8fe800e1a3b3c20f86ce8b0

docs: add data integrity theory of distributing files and blocks Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>

view details

push time in 9 days

PR opened dragonflyoss/Dragonfly

docs: add data integrity theory of distributing files and blocks

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

docs: add data integrity theory of distributing files and blocks https://github.com/dragonflyoss/Dragonfly/issues/1205 asked the data integrity of Dragonfly, we think it should be a document to present all the details.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> fix https://github.com/dragonflyoss/Dragonfly/issues/1205

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need, just docs.

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

+48 -0

0 comment

1 changed file

pr created time in 9 days

create barnchallencloud/Dragonfly

branch : docs-data-integrity

created branch time in 9 days

issue commentdragonflyoss/Dragonfly

[Question] How to guarantee the data integrity of the images and the blocks?

I think we could add this into the FAQ or a separate documentation.

allencloud

comment created time in 9 days

pull request commentdragonflyoss/Dragonfly

[WIP] docs: update the FAQ doc

Any update on this ? @Starnop

Starnop

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

[WIP] docs: update the FAQ doc

 Supernode will maintain a bitmap which records the correspondence between peers  **NOTE**: The scheduler will decide whether to download from the supernode or other peers. As for the detail of the scheduler, please refer to [scheduler algorithm](#what-is-the-peer-scheduling-algorithm-by-default) +## What is the size of block(piece) when distribution++Dragonfly tries to make block(piece) size dynamically to ensure efficiency.++The size of pieces which is calculated as per the following strategy:++- If file's total size is less than 200MB, then the piece size is `4MB` by default.+- Otherwise, it equals to `min{ totalSize/100MB + 2 MB, 15MB }`.++## What is the peer scheduling algorithm by default++- Distribute the number of pieces evenly. Select the pieces with the smallest number in the entire P2P network so that the distribution of each piece in the P2P network is balanced to avoid "Nervous resources".++- Nearest distance priority. For a peer, the piece closest to the piece currently being downloaded is preferentially selected, so that the peer can achieve the effect of sequential read and write approximately, which will improve the I/O efficiency of file.++- Local blacklist and global blacklist. An example is easier to understand: When peer A fails to download from peer B, B will become the local blacklist of A, and then the download tasks of A will filter B out; When the number of failed downloads from B reaches a certain threshold, B will become the global blacklist, and all the download tasks will filter B out.++- Self-isolation. PeerA will only download files from the supernode after it fails to download multiple times from other peers, and will also be added to the global blacklist. So the peer A will no longer interact with peers other than the supernode.++- Peer load balancing. This mechanism will control the number of upload pieces and download pieces that each peer can provide simultaneously and the priority as the target peer.+ ## How do supernode and peers manage file cache which is ready for other peer's pulling -Supernode will download files and cache them via CDN. For more information, please refer to [The sequence of supernode's CDN functionality](#what-is-the-sequence-of-supernode's-cdn-functionality).+For supernode, it will download files and cache them via CDN. For more information, please refer to [The sequence of supernode's CDN functionality](#what-is-the-sequence-of-supernode's-cdn-functionality). -After finishing distributing file from other peers, `dfget` should do two kinds of things:+For one peer, after finishing distributing file from other peers, `dfget` will do these things: -- first, construct all the pieces into unioned file(s);+- first, construct all the pieces into a unioned file(s);

I think it should be a rather than an. @yeya24

Starnop

comment created time in 9 days

pull request commentdragonflyoss/Dragonfly

[WIP] check docs update only commit

@yeya24 Any progress with the privilege? How about assign the privilege to you?

yeya24

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

test: add unit test case for func GetAllPeerIDs

 func (s *PeerMgrTestSuite) TestGet(c *check.C) { 	c.Check(info, check.DeepEquals, expected) } +func (s *PeerMgrTestSuite) TestGetAllPeerIDs(c *check.C) {+	manager, _ := NewManager(prometheus.NewRegistry())++	// the first data+	request := &types.PeerCreateRequest{+		IP:       "192.168.10.11",+		HostName: "foo",+		Port:     65001,+		Version:  version.DFGetVersion,+	}+	resp, err := manager.Register(context.Background(), request)+	c.Check(err, check.IsNil)+	id := resp.ID++	// the second data+	request = &types.PeerCreateRequest{+		IP:       "192.168.10.11",+		HostName: "bar",+		Port:     65001,+		Version:  version.DFGetVersion,+	}+	resp, err = manager.Register(context.Background(), request)+	c.Check(err, check.IsNil)+	id2 := resp.ID++	// get all peer ids+	ids := manager.GetAllPeerIDs(context.Background())+	c.Check(ids, check.DeepEquals, []string{id, id2})

CI fails here:

----------------------------------------------------------------------
FAIL: manager_test.go:130: PeerMgrTestSuite.TestGetAllPeerIDs

manager_test.go:157:
    c.Check(ids, check.DeepEquals, []string{id, id2})
... obtained []string = []string{"bar-192.168.10.11-1579514426165976773", "foo-192.168.10.11-1579514426165782207"}
... expected []string = []string{"foo-192.168.10.11-1579514426165782207", "bar-192.168.10.11-1579514426165976773"}

OOPS: 3 passed, 1 FAILED
--- FAIL: Test (0.01s)
FAIL
coverage: 86.2% of statements
FAIL	github.com/dragonflyoss/Dragonfly/supernode/daemon/mgr/peer	0.400s
make: *** [Makefile:109: unit-test] Error 1

Maybe you can change the code to sort the slice.

fenggw-fnst

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

pkg/fileutils: add unit test for IsRegularFile

 func (s *FileUtilTestSuite) TestLoadYaml(c *check.C) {  	} }++func (s *FileUtilTestSuite) TestIsRegularFile(c *check.C) {+	pathStr := filepath.Join(s.tmpDir, "TestIsRegularFile")+	c.Assert(IsRegularFile(pathStr), check.Equals, false)++	os.Create(pathStr)+	c.Assert(IsRegularFile(pathStr), check.Equals, true)+	os.Remove(pathStr)++	os.OpenFile(pathStr, 0, 0666)+	c.Assert(IsRegularFile(pathStr), check.Equals, false)

could you add a comment here why it equals to false? It makes more readable.

q384566678

comment created time in 9 days

Pull request review commentdragonflyoss/Dragonfly

pkg/syncmap: add unit test for GetAsAtomicInt

 func (suite *SyncMapUtilSuite) TestGetAsTime(c *check.C) { 	result, _ := mmap.GetAsTime("aaa") 	c.Check(result, check.DeepEquals, expected) }++func (suite *SyncMapUtilSuite) TestGetAsAtomicInt(c *check.C) {+	expected := atomiccount.NewAtomicInt(10)+	mmap := NewSyncMap()+	mmap.Add("aaa", expected)++	result, _ := mmap.GetAsAtomicInt("aaa")+	c.Check(result, check.DeepEquals, expected)

You could add code here to check the non-existent one, then check the non-nil error:

result, err := mmap.GetAsAtomicInt("nonexist")
q384566678

comment created time in 9 days

push eventdragonflyoss/Dragonfly

Zhou Hao

commit sha 78504d7796d7437bd305ff84112a88675e81542e

pkg/constants: improve GetMsgByCode test Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>

view details

Allen Sun

commit sha bc736eda5d4ed364298b77ee97494e81782bcf2e

Merge pull request #1214 from q384566678/add-test pkg/constants: improve GetMsgByCode test

view details

push time in 9 days

PR merged dragonflyoss/Dragonfly

pkg/constants: improve GetMsgByCode test LGTM areas/test size/XS

Complete tests in other situations. Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+3 -0

2 comments

1 changed file

q384566678

pr closed time in 9 days

pull request commentdragonflyoss/Dragonfly

pkg/constants: improve GetMsgByCode test

LGTM

q384566678

comment created time in 9 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 2b004ceb43bd50fed5a07457614e6441e795e3d4

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 1481da331efb6c709fa463b1e1ce2eabf3505450

Merge pull request #1218 from pouchrobot/auto-doc-2020-02-13 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 10 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

1 comment

1 changed file

pouchrobot

pr closed time in 10 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 package app  import (-	"bytes" 	"fmt" 	"os"-	"os/exec" 	"os/user" 	"path/filepath" 	"runtime" 	"time"  	"github.com/dragonflyoss/Dragonfly/dfdaemon/config" 	"github.com/dragonflyoss/Dragonfly/dfdaemon/constant"+	dfgetcfg "github.com/dragonflyoss/Dragonfly/dfget/config"+	"github.com/dragonflyoss/Dragonfly/dfget/util" 	"github.com/dragonflyoss/Dragonfly/pkg/dflog" 	"github.com/dragonflyoss/Dragonfly/pkg/errortypes" 	"github.com/dragonflyoss/Dragonfly/pkg/fileutils"+	"github.com/dragonflyoss/Dragonfly/pkg/httputils"+	"github.com/dragonflyoss/Dragonfly/pkg/netutils" 	statutil "github.com/dragonflyoss/Dragonfly/pkg/stat"+	"github.com/dragonflyoss/Dragonfly/pkg/stringutils"  	"github.com/pkg/errors" 	"github.com/sirupsen/logrus" ) +func adjustSupernodeList(nodes []string) []string {+	switch nodesLen := len(nodes); nodesLen {+	case 0:+		return nodes+	case 1:+		return append(nodes, nodes[0])+	default:+		util.Shuffle(nodesLen, func(i, j int) {+			nodes[i], nodes[j] = nodes[j], nodes[i]+		})+		return append(nodes, nodes...)+	}+}++func checkConnectSupernode(nodes []string) (localIP string) {

please add comment for this function.

wangforthinker

comment created time in 10 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 package app  import (-	"bytes" 	"fmt" 	"os"-	"os/exec" 	"os/user" 	"path/filepath" 	"runtime" 	"time"  	"github.com/dragonflyoss/Dragonfly/dfdaemon/config" 	"github.com/dragonflyoss/Dragonfly/dfdaemon/constant"+	dfgetcfg "github.com/dragonflyoss/Dragonfly/dfget/config"+	"github.com/dragonflyoss/Dragonfly/dfget/util" 	"github.com/dragonflyoss/Dragonfly/pkg/dflog" 	"github.com/dragonflyoss/Dragonfly/pkg/errortypes" 	"github.com/dragonflyoss/Dragonfly/pkg/fileutils"+	"github.com/dragonflyoss/Dragonfly/pkg/httputils"+	"github.com/dragonflyoss/Dragonfly/pkg/netutils" 	statutil "github.com/dragonflyoss/Dragonfly/pkg/stat"+	"github.com/dragonflyoss/Dragonfly/pkg/stringutils"  	"github.com/pkg/errors" 	"github.com/sirupsen/logrus" ) +func adjustSupernodeList(nodes []string) []string {

please add comment for this function.

wangforthinker

comment created time in 10 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 func initDfdaemon(cfg config.Properties) error { 			"ensure local repo %s exists", cfg.DFRepo, 		) 	}+	cfg.SuperNodes = adjustSupernodeList(cfg.SuperNodes)+	if stringutils.IsEmptyStr(cfg.LocalIP) {+		cfg.LocalIP = checkConnectSupernode(cfg.SuperNodes)+	}  	go cleanLocalRepo(cfg.DFRepo) -	dfgetVersion, err := exec.Command(cfg.DFPath, "version").CombinedOutput()-	if err != nil {-		return errors.Wrap(err, "get dfget version")-	}-	logrus.Infof("use %s from %s", bytes.TrimSpace(dfgetVersion), cfg.DFPath)+	// dfgetVersion, err := exec.Command(cfg.DFPath, "version").CombinedOutput()

just remove them if you think the code is useless

wangforthinker

comment created time in 10 days

Pull request review commentdragonflyoss/Dragonfly

Feature: extract dfget lib

 func (p *Properties) Validate() error { 		) 	} -	if _, err := os.Stat(p.DFPath); err != nil && os.IsNotExist(err) {-		return dferr.Newf(-			constant.CodeExitDfgetNotFound,-			"dfpath %s not found", p.DFPath,-		)-	}-+	// if _, err := os.Stat(p.DFPath); err != nil && os.IsNotExist(err) {

just remove them if you think the code is useless

wangforthinker

comment created time in 10 days

pull request commentcncf/toc

Dragonfly Incubating Stage Review

Thanks @amye can you kick off the vote tomorrow?

@caniszczyk Sig Storage and @chira001 made a very detailed review for Dragonfly. While I am afraid that we still need a TOC sponsor and Due Diligence which is requested in the cncf-toc channel https://lists.cncf.io/g/cncf-toc/topic/67574577#3930.

/cc @amye

allencloud

comment created time in 10 days

PR opened dragonflyoss/Dragonfly

docs: remove gitter from realtime chatting tools

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

This PR removed gitter from realtime chatting tools, since I think we are no longer at the gitter tools. While we suggest that github issue and dingtalk is the direct way we could use to communicate in real time.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

+1 -3

0 comment

1 changed file

pr created time in 11 days

create barnchallencloud/Dragonfly

branch : remove-gitter

created branch time in 11 days

push eventallencloud/Dragonfly

SataQiu

commit sha 992496d411667c4ff41cce0c6f7b7e714ffce3d4

feature: add 'config default' command to print the default configuration of components Signed-off-by: SataQiu <1527062125@qq.com>

view details

fengzixu

commit sha a32f2fd5bd1fac8ae5576e0f9fab04d75f16dc7c

feature: add yamllint tool to format yaml files 1. add the yamllint into the circleci config 2. format the yaml files according to yamllint Signed-off-by: fengzixu <hnustphoenix@gmail.com>

view details

Allen Sun

commit sha 6235fe182e97c2e5b059cf9bb15c1624877680f6

Merge pull request #1125 from fengzixu/master feature: add the yamlint tool to check check all yaml files

view details

pouchrobot

commit sha 3dccb97c54215f5b68027cec29df3e106307bc6c

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha e77febc67cace01ba79e41bc770b69a4ef649905

Merge pull request #1131 from pouchrobot/auto-doc-2019-12-09 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

Aresforchina

commit sha d33ea4c4c03ccd93c80643653a0955f82a309529

bugfix:modify the words spelling mistakes Signed-off-by: Aresforchina <18845641183@163.com>

view details

yunfeiyangbuaa

commit sha 5f458067c577ea9b6964b261475052761ed8c2ff

modify 1.0 bridge Signed-off-by: yunfeiyangbuaa <yunfeiyang@buaa.edu.cn>

view details

liuyuxing

commit sha 39efe6425a5135d7b8b8e5320dac8f0c6f8e3d8b

Merge pull request #1133 from Aresforchina/Dragonfly-update bugfix:modify the words spelling mistakes

view details

pouchrobot

commit sha 00538be75e714e6a6053d974140eaed0a3f2adcb

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 2d0c65a6537952a35f169cec7a3ef03ad2756da8

Merge pull request #1137 from pouchrobot/auto-doc-2019-12-17 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

Aresforchina

commit sha c3b7c6b7c3f0c81daf162a4250f4b6bb244e10b2

bugfix:modify the words spelling mistakes Signed-off-by: Aresforchina <18845641183@163.com>

view details

Allen Sun

commit sha df32ce2b5041d4189c53e5cfdee3e437e6b2282e

Merge pull request #1134 from Aresforchina/Drangonflu-update02 bugfix:Improve the readability of code

view details

Guangwen Feng

commit sha d1d7b0a7e4d9bb99493341e379fb8b56e62e0234

test: add unit test case for func TransRate Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>

view details

liuyuxing

commit sha b552a124c22cc7db170b5ecd15afbc62abc4e82f

Merge pull request #1148 from fenggw-fnst/work test: add unit test case for func TransRate

view details

liuyuxing

commit sha f2428a5e8ff464e865990ea4dce72761c9a6e970

Merge pull request #1084 from SataQiu/add-dfdaemon-config-cmd-20191118 feature: add 'config default' command to print the default configuration of components

view details

liuyuxing

commit sha 509945a440ea75cb656e5af47d94cb4c723832fa

Merge pull request #1065 from yunfeiyanggzq/bridge_1 feature:modify supernode 1.0 bridge

view details

pouchrobot

commit sha 2d8dec616bed80993da73b6e815689434647fc95

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Guangwen Feng

commit sha e1c58f38d929d6d6d4c51f6a4d119177af355232

fix typo: 'the the' -> 'the' Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>

view details

Ben Ye

commit sha 3f7ee576400aada9344c8fd8e53b58bec9b80841

Merge pull request #1155 from fenggw-fnst/work fix typo: 'the the' -> 'the'

view details

Allen Sun

commit sha 9aaea247b9d083bad82dc7ed5fccbd618288bf07

Merge pull request #1151 from pouchrobot/auto-doc-2019-12-31 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 11 days

issue closeddragonflyoss/Dragonfly

Weekly Digest (2 February, 2020 - 9 February, 2020)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 7 issues were created. Of these, 2 issues have been closed and 5 issues are still open.

OPEN ISSUES

:green_heart: #1208 Dfdaemon produced error when pulling image, by liy516 :green_heart: #1207 [feature request] a new dfdaemon sub command for CA generation, by inoc603 :green_heart: #1206 Dfget is downloading large file (5GB), and out of memory or killed (trigger system OOM) appears, by kivis-online :green_heart: #1205 [Question] How to guarantee the data integrity of the images and the blocks?, by allencloud :green_heart: #1204 [feature request] support configurable hashing and crypto algorithms for Dragonfly, by Starnop

CLOSED ISSUES

:heart: #1210 WeeklyReport of Dragonfly from 2020-01-31 to 2020-02-07, by pouchrobot :heart: #1209 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot

LIKED ISSUE

:+1: #1207 [feature request] a new dfdaemon sub command for CA generation, by inoc603 It received :+1: x1, :smile: x0, :tada: x0 and :heart: x0.

NOISY ISSUE

:speaker: #1209 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot It received 2 comments.


PULL REQUESTS

Last week, 10 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 8 pull requests were updated. :yellow_heart: #1191 [WIP]refactor: divide CDN as a separate module, by Starnop :yellow_heart: #1186 feature: add client stream writer for Streaming, by jim3ma :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 2 pull requests were merged. :purple_heart: #1209 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #1181 feature: Hijack HTTPS by generating leaf TLS certs on the fly issued by user provided CA., by YanzheL


COMMITS

Last week there were 8 commits. :hammer_and_wrench: Merge pull request #1209 from pouchrobot/auto-doc-2020-02-06 docs: auto generate Dragonfly cli/api/contributors docs via code by allencloud :hammer_and_wrench: docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot pouch-dev@list.alibaba-inc.com by pouchrobot :hammer_and_wrench: Merge pull request #1181 from YanzheL/feature-https-mitm feature: Hijack HTTPS by generating leaf TLS certs on the fly issued by user provided CA. by inoc603 :hammer_and_wrench: Hijack HTTPS by generating leaf TLS certs on the fly issued by user provided CA Signed-off-by: YanzheL lee.yanzhe@yanzhe.org by YanzheL :hammer_and_wrench: Merge pull request #1197 from q384566678/add-supernode-test test: add unit test for supernode errors by lowzj :hammer_and_wrench: test: add unit tests for supernode errors Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678 :hammer_and_wrench: Merge pull request #1196 from q384566678/add-errortypes-test test: add unit tests for pkg/errortypes by lowzj :hammer_and_wrench: test: add unit tests for pkg/errortypes Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678


CONTRIBUTORS

Last week there were 6 contributors. :bust_in_silhouette: allencloud :bust_in_silhouette: pouchrobot :bust_in_silhouette: inoc603 :bust_in_silhouette: YanzheL :bust_in_silhouette: lowzj :bust_in_silhouette: q384566678


STARGAZERS

Last week there were 12 stagazers. :star: anonymousch :star: ashim-k-saha :star: karl-tech :star: mitghi :star: XudongLiuHarold :star: snczl :star: lyyyuna :star: CharlesWqh :star: lttzz :star: fhqidx :star: 13477940 :star: roya-grimm You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in 12 days

weekly-digest[bot]

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2020-01-31 to 2020-02-07

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
195 (↑2) 4562 (↑11) 606 (↑0) 62 (↑0) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 3 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feature: Hijack HTTPS by generating leaf TLS certs on the fly issued by user provided CA. (#1181)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1209)
  • docs: trivial fix some typos (#1202)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@YanzheL 3
@inoc603 2
@yeya24 1
@Starnop 1
@lowzj 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 15 days

pouchrobot

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha f292c815a897f8b826ae4e66becc825b68dedfed

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha aa99056a01aca5d5ee7d1849ad38aa87a6be1706

Merge pull request #1209 from pouchrobot/auto-doc-2020-02-06 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 16 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

2 comments

1 changed file

pouchrobot

pr closed time in 16 days

issue commentdragonflyoss/Dragonfly

How to guarantee the data integrity of the images and the blocks?

the block format does not appear to include a checksum.

No, the block format does not include a checksum.

However, for each distributing file, we record all blocks' checksum into a separate file, which is named by block metadata file.

What is a block metadata file?

Each block metadata file maps each distributing file. The block metadata file includes the following three parts:

  • every block's MD5 info;
  • the whole distributing file's MD5 info;
  • the SHA1 info of the above data;

How is a block metadata file produced?

Here is the procedure of how to produce a metadata file in Dragonfly:

  • STEP1: When dfget agents trigger to distribute a file, Supernode makes the CDN manager to download the target file.
  • STEP2: As downloading the file, CDN manager will cut the file into blocks.
  • STEP3: Each time finishing to produce a block, the CDN manager would calculate MD5 for the block, and the store the MD5 in memory.
  • STEP4: When finishing to calculate all MD5 for all blocks, the CDN manager will continue to calculate MD5 for the downloading file.
  • STEP5: The CDN manager continues to calculate SHA1 of all calculated MD5 values.
  • STEP6: The CDN managers write each block's MD5, the whole file's MD5 and SHA1 of all MD5 values into the block metadata file.

The following is the brief example of a block metadata file:

blablabla

How is a block metadata file consumed?

Here is the procedure of how to consume a metadata file in Dragonfly:

  1. When distributing a block to a peer, supernode will fetch the MD5 of this block and send this MD5 to peer along with block;
  2. After finishing to download the block and MD5, dfget will generate another MD5 of the downloaded block, and check the newly-generated MD5 value with downloaded MD5 value.
  3. If they match, we can trust the data integrity. If they don't match, dfget will report this mismatch to supernode including block info and incorrect peer, and then dfget will try to download the block from other peers;
  4. Supernode gets aware of which peer providing incorrect data integrity, and then supernode isolates this peer from the whole peer network.

dragonfly服务端会将分片的checksum记录在一个单独的文件内,分片元信息文件;该文件内保存了每个分片的md5,以及整个镜像文件的md5,同时为了防止该元文件被篡改,记录上述数据 sha1值。服务端在读取元信息文件时,会校验sha1值,若不匹配则会重新回源下载。服务端在分配每个分片信息给dragonfly客户端(peer节点)时,同时会将分片md5值也下发下去。客户端在下载完一个分片后,会进行md5比对校验,以保证数据的正确性。若分片md5校验不通过,则会上报给服务端,同时会重试到其他peer节点。服务端会将该错误的peer节点加入黑名单,从p2p网络中剔除出去。

allencloud

comment created time in 19 days

issue openeddragonflyoss/Dragonfly

How to guarantee the data integrity of the images and the blocks?

Question

<!-- You can ask any question about this project -->

today, the block format does not appear to include a checksum and I think that this could potentially lead to a bad block (either through corruption or alternatively via a malicious actor) being distributed through the P2P network and potentially poisoning the cache.   You mentioned in the SIG presentation that there were some protections for this but I could not understand the specifics - would it be possible to explain how the data integrity of the images and the blocks are maintained please?

created time in 19 days

issue closedalibaba/pouch

Weekly Digest (19 January, 2020 - 26 January, 2020)

Here's the Weekly Digest for alibaba/pouch:


ISSUES

Last week, no issues were created.


PULL REQUESTS

Last week, 1 pull request was created, updated or merged.

MERGED PULL REQUEST

Last week, 1 pull request was merged. :purple_heart: #3008 upgrade: bump critest and k8s e2e test to 1.16, by zhuangqh


COMMITS

Last week there was 1 commit. :hammer_and_wrench: upgrade: bump critest and k8s e2e test to 1.16 Signed-off-by: zhuangqh zhuangqhc@gmail.com by zhuangqh


CONTRIBUTORS

Last week there was 1 contributor. :bust_in_silhouette: zhuangqh


STARGAZERS

Last week there were 4 stagazers. :star: yanjerry9133 :star: chong0808 :star: chankamlam :star: aeonve You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository alibaba/pouch to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in a month

weekly-digest[bot]

issue closedalibaba/pouch

Weekly Digest (12 January, 2020 - 19 January, 2020)

Here's the Weekly Digest for alibaba/pouch:


ISSUES

Last week, no issues were created.


PULL REQUESTS

Last week, no pull requests were created, updated or merged.


COMMITS

Last week there were no commits.


CONTRIBUTORS

Last week there were no contributors.


STARGAZERS

Last week there were 8 stagazers. :star: wmussack :star: xkcp0324 :star: yemuapp :star: tanhaipeng :star: EaconTang :star: lianghappy :star: qu823110460 :star: palvarezcordoba You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository alibaba/pouch to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in a month

weekly-digest[bot]

issue closeddragonflyoss/Dragonfly

Weekly Digest (19 January, 2020 - 26 January, 2020)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 9 issues were created. Of these, 2 issues have been closed and 7 issues are still open.

OPEN ISSUES

:green_heart: #1199 WeeklyReport of Dragonfly from 2020-01-17 to 2020-01-24, by pouchrobot :green_heart: #1198 supernode 1.0.0 http: panic serving, by vissible :green_heart: #1197 Add supernode errors unit test, by q384566678 :green_heart: #1196 Add errortypes util test, by q384566678 :green_heart: #1195 optimize the cacheDetector to decrease downloading time, by lowzj :green_heart: #1194 test: add unit test case for func GetAllPeerIDs, by fenggw-fnst :green_heart: #1191 [WIP]refactor: divide CDN as a separate module, by Starnop

CLOSED ISSUES

:heart: #1193 test: add unit test case for func GetAsTime, by fenggw-fnst :heart: #1192 Add digest util test, by q384566678

NOISY ISSUE

:speaker: #1192 Add digest util test, by q384566678 It received 2 comments.


PULL REQUESTS

Last week, 15 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 12 pull requests were updated. :yellow_heart: #1197 Add supernode errors unit test, by q384566678 :yellow_heart: #1196 Add errortypes util test, by q384566678 :yellow_heart: #1194 test: add unit test case for func GetAllPeerIDs, by fenggw-fnst :yellow_heart: #1191 [WIP]refactor: divide CDN as a separate module, by Starnop :yellow_heart: #1186 feature: add client stream writer for Streaming, by jim3ma :yellow_heart: #1122 feature: dfdaemon supports hot reload, by SataQiu :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 3 pull requests were merged. :purple_heart: #1193 test: add unit test case for func GetAsTime, by fenggw-fnst :purple_heart: #1192 Add digest util test, by q384566678 :purple_heart: #1189 test: add unit test case for func GetAsInt64, by hs0210


COMMITS

Last week there were 6 commits. :hammer_and_wrench: Merge pull request #1193 from fenggw-fnst/work test: add unit test case for func GetAsTime by lowzj :hammer_and_wrench: Merge pull request #1192 from q384566678/add-digest-test Add digest util test by lowzj :hammer_and_wrench: test: add unit test case for func GetAsTime Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com by fenggw-fnst :hammer_and_wrench: add unit test for Sha1 Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678 :hammer_and_wrench: add unit test for Sha256 Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com by q384566678 :hammer_and_wrench: Merge pull request #1189 from hs0210/work test: add unit test case for func GetAsInt64 by lowzj


CONTRIBUTORS

Last week there were 3 contributors. :bust_in_silhouette: lowzj :bust_in_silhouette: fenggw-fnst :bust_in_silhouette: q384566678


STARGAZERS

Last week there were 18 stagazers. :star: 404-not-find :star: sjp00556 :star: xuchaoi :star: frtmelody :star: tunzhao :star: HayaCode :star: ctianlong :star: nashtsai :star: lichunlong :star: slyn :star: inkinworld :star: chenrui333 :star: danilopopeye :star: phpjsnerd :star: udhos :star: kinganeng :star: maximum-wong :star: benner You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in a month

weekly-digest[bot]

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2020-01-17 to 2020-01-24

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
193 (↑-1) 4543 (↑18) 603 (↑1) 62 (↑0) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 5 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1188)

test ✅ ☑️

  • test: add unit test case for func GetAsTime (#1193)
  • test: add unit test case for func GetAsInt64 (#1189)
  • test: add unit test case for func GetAsBitset (#1187)

others

  • Add digest util test (#1192)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@lowzj 4
@jim3ma 3
@Starnop 2
@inoc603 1
@YanzheL 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in a month

pouchrobot

startedvesoft-inc/nebula

started time in 2 months

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XL

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+301 -216

1 comment

8 changed files

pouchrobot

pr closed time in 2 months

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XL

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+301 -216

1 comment

8 changed files

pouchrobot

pr closed time in 2 months

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 2d8dec616bed80993da73b6e815689434647fc95

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 9aaea247b9d083bad82dc7ed5fccbd618288bf07

Merge pull request #1151 from pouchrobot/auto-doc-2019-12-31 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 2 months

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XL

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+301 -216

4 comments

8 changed files

pouchrobot

pr closed time in 2 months

pull request commentdragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code

Please help check if the API doc change satisfies the corresponding pull request https://github.com/dragonflyoss/Dragonfly/pull/1065 @yunfeiyanggzq . Thanks a lot.

pouchrobot

comment created time in 2 months

push eventdragonflyoss/Dragonfly

Aresforchina

commit sha c3b7c6b7c3f0c81daf162a4250f4b6bb244e10b2

bugfix:modify the words spelling mistakes Signed-off-by: Aresforchina <18845641183@163.com>

view details

Allen Sun

commit sha df32ce2b5041d4189c53e5cfdee3e437e6b2282e

Merge pull request #1134 from Aresforchina/Drangonflu-update02 bugfix:Improve the readability of code

view details

push time in 2 months

PR merged dragonflyoss/Dragonfly

bugfix:Improve the readability of code LGTM kind/bug size/S

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Increase the quality of articles and correct spelling mistakes

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+6 -6

7 comments

5 changed files

Aresforchina

pr closed time in 2 months

pull request commentdragonflyoss/Dragonfly

bugfix:Improve the readability of code

LGTM

Aresforchina

comment created time in 2 months

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2019-12-06 to 2019-12-13

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
192 (↑-3) 4456 (↑22) 578 (↑2) 56 (↑0) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 3 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feature: add the yamlint tool to check check all yaml files (#1125)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1131)

others

  • [chore] fix bad link (#1127)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@allencloud 1
@yeya24 1
@zhouhaibing089 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 2 months

pouchrobot

issue closeddragonflyoss/Dragonfly

Weekly Digest (8 December, 2019 - 15 December, 2019)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 6 issues were created. Of these, 4 issues have been closed and 2 issues are still open.

OPEN ISSUES

:green_heart: #1135 WeeklyReport of Dragonfly from 2019-12-06 to 2019-12-13, by pouchrobot :green_heart: #1133 bugfix:modify the words spelling mistakes, by Aresforchina

CLOSED ISSUES

:heart: #1134 bugfix:Improve the readability of code, by Aresforchina :heart: #1132 What is the difference between P2P and CDN download modes in dfget?, by LeslieSun :heart: #1131 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :heart: #1129 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot

LIKED ISSUE

:+1: #1133 bugfix:modify the words spelling mistakes, by Aresforchina It received :+1: x2, :smile: x0, :tada: x0 and :heart: x0.

NOISY ISSUE

:speaker: #1133 bugfix:modify the words spelling mistakes, by Aresforchina It received 6 comments.


PULL REQUESTS

Last week, 11 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 10 pull requests were updated. :yellow_heart: #1122 Refactor cmd/dfdaemon to use unified sub commands, by SataQiu :yellow_heart: #1120 docs: update docs about deploy with Physical Machines, by Starnop :yellow_heart: #1106 [WIP] check docs update only commit, by yeya24 :yellow_heart: #1024 docs: optimize the config documents, by Starnop :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 1 pull request was merged. :purple_heart: #1131 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot


COMMITS

Last week there were 2 commits. :hammer_and_wrench: Merge pull request #1131 from pouchrobot/auto-doc-2019-12-09 docs: auto generate Dragonfly cli/api/contributors docs via code by allencloud :hammer_and_wrench: docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot pouch-dev@list.alibaba-inc.com by pouchrobot


CONTRIBUTORS

Last week there were 2 contributors. :bust_in_silhouette: allencloud :bust_in_silhouette: pouchrobot


STARGAZERS

Last week there were 22 stagazers. :star: xingfudeshi :star: igorlimansky :star: ubuntulover09 :star: aijun198600 :star: progkix :star: raphaeloliveiro :star: xing0821 :star: kuops :star: 0605 :star: qq358860528 :star: bbutkovic :star: singleway :star: a-beloglazov :star: wordgod123 :star: fortranlee :star: totobraga :star: juezhe :star: sofire :star: kokizzu :star: JimmyZhuang :star: Kdecherf :star: 915111502 You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in 2 months

weekly-digest[bot]

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 00538be75e714e6a6053d974140eaed0a3f2adcb

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 2d0c65a6537952a35f169cec7a3ef03ad2756da8

Merge pull request #1137 from pouchrobot/auto-doc-2019-12-17 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 2 months

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

2 comments

1 changed file

pouchrobot

pr closed time in 2 months

pull request commentdragonflyoss/Dragonfly

bugfix:modify the words spelling mistakes

I found lots of such issue in this repo: https://github.com/dragonflyoss/Dragonfly/search?q=unknow&unscoped_q=unknow Could you help to fix them all? @Aresforchina Thanks

Aresforchina

comment created time in 2 months

issue closeddragonflyoss/Dragonfly

Pulling a image with dragonfly is actually slower

Question

<!-- You can ask any question about this project --> I am use docker registry, When using Dragonfly to pull two nodes at the same time: real 12m39.620s user 0m2.326s sys 0m0.892s

When not using Dragonfly to pull two nodes at the same time: real 6m57.331s user 0m0.475s sys 0m0.432s

closed time in 2 months

JiaDong007

issue commentdragonflyoss/Dragonfly

Pulling a image with dragonfly is actually slower

I am closing this issue. I am not sure if my answer satisfies you. If you have further questions, please feel free to re-open this issue. Thanks. @JiaDong007

JiaDong007

comment created time in 2 months

issue closeddragonflyoss/Dragonfly

Weekly Digest (1 December, 2019 - 8 December, 2019)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 20 issues were created. Of these, 10 issues have been closed and 10 issues are still open.

OPEN ISSUES

:green_heart: #1128 Pulling a image with dragonfly is actually slower, by JiaDong007 :green_heart: #1124 dragonfly 1.0.0 failed to pull the image, by Fize :green_heart: #1123 [Help Wanted] make Dragonfly managed by systemd, by Starnop :green_heart: #1122 Refactor cmd/dfdaemon to use unified sub commands, by SataQiu :green_heart: #1120 docs: update docs about deploy with Physical Machines, by Starnop :green_heart: #1119 How to upload general files to dragonfly??, by everpeace :green_heart: #1118 [design][feature request]only register a peer for the same node download many tasks, by yunfeiyanggzq :green_heart: #1117 Download with dragonfly is much slower than normal download, please help to have a look, thank you, by gttcc :green_heart: #1115 [feature request][help wanted]implement supernode /preheat api, by yunfeiyanggzq :green_heart: #1111 [feature request] build deb and rpm package in goreleaser, by yeya24

CLOSED ISSUES

:heart: #1127 [chore] fix bad link, by yeya24 :heart: #1126 WeeklyReport of Dragonfly from 2019-11-29 to 2019-12-06, by pouchrobot :heart: #1125 feature: add the yamlint tool to check check all yaml files, by fengzixu :heart: #1121 fix: unset the default value of totallimit, by lowzj :heart: #1116 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :heart: #1114 feature:modify client api, by yunfeiyanggzq :heart: #1113 bugfix:fix api response status code , by yunfeiyanggzq :heart: #1112 Add yamlint in CI system for all the yaml files in this repo, by allencloud :heart: #1110 cleanup unused scripts and Makefile, by yeya24 :heart: #1109 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot

LIKED ISSUE

:+1: #1111 [feature request] build deb and rpm package in goreleaser, by yeya24 It received :+1: x2, :smile: x0, :tada: x0 and :heart: x0.

NOISY ISSUE

:speaker: #1125 feature: add the yamlint tool to check check all yaml files, by fengzixu It received 11 comments.


PULL REQUESTS

Last week, 23 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 13 pull requests were updated. :yellow_heart: #1122 Refactor cmd/dfdaemon to use unified sub commands, by SataQiu :yellow_heart: #1120 docs: update docs about deploy with Physical Machines, by Starnop :yellow_heart: #1084 feature: add 'config default' command to print the default configuration of components, by SataQiu :yellow_heart: #1065 feature:modify supernode 1.0 bridge, by yunfeiyanggzq :yellow_heart: #1028 docs: add a doc about using dragonfly with harbor registry, by Starnop :yellow_heart: #1024 docs: optimize the config documents, by Starnop :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #789 fix valid ip not support ipv6, by zgfh :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 10 pull requests were merged. :purple_heart: #1127 [chore] fix bad link, by yeya24 :purple_heart: #1125 feature: add the yamlint tool to check check all yaml files, by fengzixu :purple_heart: #1121 fix: unset the default value of totallimit, by lowzj :purple_heart: #1116 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #1114 feature:modify client api, by yunfeiyanggzq :purple_heart: #1113 bugfix:fix api response status code , by yunfeiyanggzq :purple_heart: #1110 cleanup unused scripts and Makefile, by yeya24 :purple_heart: #1109 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #1107 fix broken grafana dashboard, by yeya24 :purple_heart: #1099 fix the "index out of range" error when the length of speed is 0., by widy21


COMMITS

Last week there were 18 commits. :hammer_and_wrench: Merge pull request #1125 from fengzixu/master feature: add the yamlint tool to check check all yaml files by allencloud :hammer_and_wrench: feature: add yamllint tool to format yaml files 1. add the yamllint into the circleci config 2. format the yaml files according to yamllint Signed-off-by: fengzixu hnustphoenix@gmail.com by fengzixu :hammer_and_wrench: Merge pull request #1127 from yeya24/fix-link [chore] fix bad link by allencloud :hammer_and_wrench: fix bad link Signed-off-by: yeya24 yb532204897@gmail.com by yeya24 :hammer_and_wrench: Merge pull request #1121 from lowzj/fix-totallimit fix: unset the default value of totallimit by Starnop :hammer_and_wrench: fix: unset the default value of totallimit Signed-off-by: lowzj zj3142063@gmail.com by lowzj :hammer_and_wrench: Merge pull request #1114 from yunfeiyanggzq/bridge_3 feature:modify client api by Starnop :hammer_and_wrench: feature:modify client api Signed-off-by: yunfeiyangbuaa yunfeiyang@buaa.edu.cn by yunfeiyanggzq :hammer_and_wrench: Merge pull request #1110 from yeya24/remove-check cleanup unused scripts and Makefile by allencloud :hammer_and_wrench: Merge pull request #1116 from pouchrobot/auto-doc-2019-12-02 docs: auto generate Dragonfly cli/api/contributors docs via code by allencloud :hammer_and_wrench: docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot pouch-dev@list.alibaba-inc.com by pouchrobot :hammer_and_wrench: Merge pull request #1113 from yunfeiyanggzq/bridge_2 bugfix:fix api response status code by allencloud :hammer_and_wrench: bugfix:fix swagger wrong Signed-off-by: yunfeiyangbuaa yunfeiyang@buaa.edu.cn by yunfeiyanggzq :hammer_and_wrench: Merge pull request #1107 from yeya24/fix-dashboard fix broken grafana dashboard by allencloud :hammer_and_wrench: Merge pull request #1099 from widy21/master fix the "index out of range" error when the length of speed is 0. by Starnop :hammer_and_wrench: cleanup unused scripts and Makefile Signed-off-by: yeya24 yb532204897@gmail.com by yeya24 :hammer_and_wrench: Merge pull request #1109 from pouchrobot/auto-doc-2019-12-01 docs: auto generate Dragonfly cli/api/contributors docs via code by yeya24 :hammer_and_wrench: docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot pouch-dev@list.alibaba-inc.com by pouchrobot


CONTRIBUTORS

Last week there were 7 contributors. :bust_in_silhouette: allencloud :bust_in_silhouette: fengzixu :bust_in_silhouette: yeya24 :bust_in_silhouette: Starnop :bust_in_silhouette: lowzj :bust_in_silhouette: yunfeiyanggzq :bust_in_silhouette: pouchrobot


STARGAZERS

Last week there were 60 stagazers. :star: AndrewTsao :star: byte16 :star: SongHeX :star: wangsquirrel :star: LuaxY :star: Skgwd2018 :star: jihongrui :star: metalfordream :star: DERDRAGON :star: bbbmj :star: jacknyi :star: tinylee :star: israelzuniga :star: Taik :star: xingyunsishen :star: chikamim :star: donjan-deng :star: tsysahhu :star: gpsbird :star: kinglionsoft :star: OpenAndrus :star: drinktee :star: wh0isroot :star: yemuapp :star: aweyonhub :star: akitana-airtanker :star: dreamrepo :star: johnnyeven :star: kopimaniz :star: johnyhi :star: shunza :star: jarus :star: LiuBodong :star: dgarcia7 :star: sunlianqiang :star: anudeepdwaram :star: forecho :star: dollarkillerx :star: TomasHubelbauer :star: madnezzm :star: ddding :star: nguyenvanduocit :star: SeasonLee :star: zsf513 :star: YPLI2015 :star: zhcn :star: jojoLockLock :star: MFrank2016 :star: DKY10000 :star: supermanCJH :star: xilu0 :star: donnyyou :star: Nachimak28 :star: kenasel :star: lanseyujie :star: shishujuan :star: DanielTimLee :star: gonjay :star: yunge :star: chpengzh You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in 2 months

weekly-digest[bot]

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/S

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+13 -13

1 comment

1 changed file

pouchrobot

pr closed time in 2 months

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 3dccb97c54215f5b68027cec29df3e106307bc6c

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha e77febc67cace01ba79e41bc770b69a4ef649905

Merge pull request #1131 from pouchrobot/auto-doc-2019-12-09 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 2 months

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/S

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+13 -13

2 comments

1 changed file

pouchrobot

pr closed time in 2 months

push eventdragonflyoss/Dragonfly

fengzixu

commit sha a32f2fd5bd1fac8ae5576e0f9fab04d75f16dc7c

feature: add yamllint tool to format yaml files 1. add the yamllint into the circleci config 2. format the yaml files according to yamllint Signed-off-by: fengzixu <hnustphoenix@gmail.com>

view details

Allen Sun

commit sha 6235fe182e97c2e5b059cf9bb15c1624877680f6

Merge pull request #1125 from fengzixu/master feature: add the yamlint tool to check check all yaml files

view details

push time in 3 months

more