profile
viewpoint
Allen Sun allencloud @alibaba Hangzhou, China An Open Source Guy skilled at Container Technology, docker , PaaS, Linux, etc. I like to help people. We are hiring!

Pull request review commentdragonflyoss/Dragonfly

optimize: reduce the waiting time for starting dfget server

 func launch(cfg *config.Config, p2pPtr *unsafe.Pointer) error { 	return fmt.Errorf("start peer server error and retried at most %d times", retryCount) } -func waitForStartup(result chan error, p2pPtr *unsafe.Pointer) error {-	select {-	case err := <-result:-		tmp := loadSrvPtr(p2pPtr)-		if err == nil {-			logrus.Infof("reuse exist server on port:%d", tmp.port)-			tmp.setFinished()-		}-		return err-	case <-time.After(100 * time.Millisecond):-		// The peer server go routine will block and serve if it starts successfully.-		// So we have to wait a moment and check again whether the peer server is-		// started.-		tmp := loadSrvPtr(p2pPtr)-		if tmp == nil {-			return fmt.Errorf("initialize peer server error")-		}-		if !uploaderAPI.PingServer(tmp.host, tmp.port) {-			return fmt.Errorf("can't ping port:%d", tmp.port)+func waitForStartup(result chan error, p2pPtr *unsafe.Pointer) (err error) {+	ticker := time.NewTicker(5 * time.Millisecond)+	defer ticker.Stop()+	timeout := time.After(233 * time.Millisecond)

why to use this value 233 * time.Millisecond. How about declaring it a const value?

lowzj

comment created time in 9 hours

Pull request review commentdragonflyoss/Dragonfly

optimize: reduce the waiting time for starting dfget server

 type Downloader interface { // the given timeout duration. func DoDownloadTimeout(downloader Downloader, timeout time.Duration) error { 	if timeout <= 0 {-		logrus.Warnf("invalid download timeout(%.3fs)", timeout.Seconds())+		logrus.Debugf("invalid download timeout(%.3fs), use default:(%.3fs)",

I think it is better to use Warnf, since it is a useful message for operators.

lowzj

comment created time in 9 hours

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2019-11-01 to 2019-11-08

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
191 (↑0) 4291 (↑18) 552 (↑5) 56 (↑1) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 6 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feature: add weight for node config (#1021)

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1058)
  • docs: delete Yum China as a Dragonfly adopter (#1057)
  • docs: auto generate Dragonfly cli/api/contributors docs via code (#1044)

others

  • Using path/filepath instead of path for file operations (#1052)
  • dfdaemon: specify context when invokes dfget (#1041)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@Starnop 7
@zhouhaibing089 7
@jyizheng 5
@zcc35357949 4
@yeya24 3
@allencloud 1
@xzy256 1
@yaRammaG 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in 10 days

pouchrobot

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

1 comment

1 changed file

pouchrobot

pr closed time in 11 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha c8619a1d286fc38b243076b7a805a9d891ee4d52

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha e026d27278e10c6a108f648740404c98dea16d7b

Merge pull request #1061 from pouchrobot/auto-doc-2019-11-10 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 11 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

2 comments

1 changed file

pouchrobot

pr closed time in 11 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

1 comment

1 changed file

pouchrobot

pr closed time in 13 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha b42a14c24571417104b768f2da82a586d1783c47

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha b6a0a649d8f29342c919acf4462527a16ccb1f29

Merge pull request #1058 from pouchrobot/auto-doc-2019-11-08 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 13 days

PR merged dragonflyoss/Dragonfly

docs: delete Yum China as a Dragonfly adopter LGTM areas/docs size/XS

docs: delete Yum China as a Dragonfly adopter

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+0 -1

6 comments

1 changed file

yaRammaG

pr closed time in 13 days

push eventdragonflyoss/Dragonfly

岁月摧锋断吴钩

commit sha 744bccfd0ff9c24fc3b7c8d62ddd9b538c096606

Update adopters.md docs: delete Yum China as a Dragonfly adopter Signed-off-by: gcz8183 <gray.zhu@yumchina.com>

view details

Allen Sun

commit sha 5c9a513848da8120518c5f740fd163d481b26b15

Merge pull request #1057 from yaRammaG/master docs: delete Yum China as a Dragonfly adopter

view details

push time in 13 days

pull request commentdragonflyoss/Dragonfly

docs: delete Yum China as a Dragonfly adopter

LGTM if we solve the DCO issue.

yaRammaG

comment created time in 14 days

pull request commentdragonflyoss/Dragonfly

docs: delete Yum China as a Dragonfly adopter

delete Yum China as a Dragonfly adopter

talked with @yaRammaG that maybe it is not the best time to post YumChina here.

yaRammaG

comment created time in 14 days

push eventdragonflyoss/Dragonfly

zhouhaibing089

commit sha 5444a8e526c0c7892ca5c6479ef294e0e261cacb

dfdaemon: specify context when invokes dfget This change is meant to fix #997. The dfget process is supposed to be terminated when client closes the connection. Signed-off-by: zhouhaibing089 <zhouhaibing089@gmail.com>

view details

Allen Sun

commit sha ed3f40991465544544fcec2f41d73fa5c054fcc7

Merge pull request #1041 from zhouhaibing089/dfdaemon-ctx dfdaemon: specify context when invokes dfget

view details

push time in 14 days

PR merged dragonflyoss/Dragonfly

dfdaemon: specify context when invokes dfget areas/test size/S

This change is meant to fix #997. The dfget process is supposed to be terminated when client closes the connection.

+15 -11

3 comments

3 changed files

zhouhaibing089

pr closed time in 14 days

issue closeddragonflyoss/Dragonfly

Dfdaemon calls dfget and zombie mileage occurs

Question

docker pull 后,dfget出现了僵尸进程。采用dragonflyoss/dfclient:0.4.3 镜像部署 [root@host-192-168-55-118 logs]# ps -ef | grep dfget root 8717 18498 0 13:58 ? 00:00:00 [dfget] <defunct> root 8725 18498 0 13:58 ? 00:00:00 [dfget] <defunct> root 8727 18498 0 13:58 ? 00:00:00 [dfget] <defunct> root 8738 18498 0 13:58 ? 00:00:00 [dfget] <defunct> root 18198 22070 0 14:20 pts/1 00:00:00 grep --color=auto dfget root 18910 18498 0 13:02 ? 00:00:00 [dfget] <defunct> root 18917 18498 0 13:02 ? 00:00:00 [dfget] <defunct> root 18926 18498 0 13:02 ? 00:00:00 [dfget] <defunct> root 18933 18498 0 13:02 ? 00:00:00 [dfget] <defunct> root 21832 18498 0 13:10 ? 00:00:00 [dfget] <defunct>

closed time in 14 days

ftlynx

Pull request review commentdragonflyoss/Dragonfly

bugfix: avoid creating dup-process of dfget server.

+/*+ * Copyright The Dragonfly Authors.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *      http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */++package fileutils++import (+	"fmt"+	"os"+	"sync"+	"syscall"+)++// FileLock define a file lock implemented by syscall.Flock+type FileLock struct {+	fileName string+	fd       *os.File+	mutex    sync.Mutex+}++// NewFileLock create a FileLock instance+func NewFileLock(name string) *FileLock {+	return &FileLock{+		fileName: name,+	}+}++// Lock locks file.+// If the file is already locked, the calling goroutine blocks until the file is unlocked.+// If lock has been invoked without unlock, lock again will return an error.+func (l *FileLock) Lock() error {+	fd, err := os.Open(l.fileName)+	if err != nil {+		return err+	}++	l.mutex.Lock()+	if l.fd != nil {+		l.mutex.Unlock()+		return fmt.Errorf("invoke Unlock() before lock %s again", l.fileName)+	}+	l.fd = fd+	l.mutex.Unlock()++	err = syscall.Flock(int(l.fd.Fd()), syscall.LOCK_EX)+	if err != nil {+		return fmt.Errorf("file %s lock failed error: %s", l.fileName, err)+	}+	return nil+}++// Unlock unlocks file.+// If lock has not been invoked before unlock, unlock will return an error.+func (l *FileLock) Unlock() error {+	l.mutex.Lock()+	if l.fd == nil {+		l.mutex.Unlock()+		return fmt.Errorf("file %s descriptor is nil", l.fileName)+	}+	fd := l.fd+	l.fd = nil+	l.mutex.Unlock()++	defer fd.Close()

no, I do not think so.

zcc35357949

comment created time in 17 days

push eventdragonflyoss/website

ringtail

commit sha 2ad11e80567a71bf5d9a77c4fae452cacc2de256

Update quickstart.md Signed-off-by: ringtail <zhongwei.lzw@alibaba-inc.com>

view details

Allen Sun

commit sha 723d0fce45667dce7d089192797ada80dcd7e14f

Merge pull request #43 from ringtail/master Update quickstart.md

view details

push time in 19 days

PR merged dragonflyoss/website

Update quickstart.md

Fix spelling errors.

+1 -1

1 comment

1 changed file

ringtail

pr closed time in 19 days

pull request commentdragonflyoss/website

Update quickstart.md

LGTM

ringtail

comment created time in 19 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha ff8d91ff1fbbcb1ac8893ecc3fedf6d0433bebd1

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 7300a6b27364296e2ace6993963fea12ca62cd21

Merge pull request #1044 from pouchrobot/auto-doc-2019-11-02 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 19 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -1

2 comments

1 changed file

pouchrobot

pr closed time in 19 days

push eventdragonflyoss/Dragonfly

Starnop

commit sha dd99a67bf3096f0d46f25e5883e82296510813c6

feature: add weight for node config Signed-off-by: Starnop <starnopg@gmail.com>

view details

Allen Sun

commit sha 095c86ad1af475d64260924bf68f7d741218b44e

Merge pull request #1021 from Starnop/supernode-priority feature: add weight for node config

view details

push time in 20 days

PR merged dragonflyoss/Dragonfly

Reviewers
feature: add weight for node config kind/feature size/XL

Signed-off-by: Starnop starnopg@gmail.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Now we choose the supernodes randomly and fairly. In the actual scenario, the service capabilities of multiple supernodes may be different. And we hope that the machine with good serviceability will be selected more times. So I add a weight configuration for supernode which defined by dfget.

For now, users can specify the supernode with weight like format: host:port/weight. For example: Using cli flagdfget --node 192.168.33.21/2 --node 127.0.0.1/1 or using config file

# cat /etc/dragonfly/dfget.yml
nodes:
    - 192.168.33.21/2
    - 127.0.0.1/1 

And then the supernode with 192.168.33.21 and the supernode with 127.0.0.1 will be selected in a 2:1 ratio.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> NONE.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

The host is necessary, port and weight is optional Added

Ⅳ. Describe how to verify it

Take a look at dfclient.log file and search do register to one of

And then you will find something like this

do register to one of [192.168.33.21:8002 192.168.33.21:8002 127.0.0.1:8002 192.168.33.21:8002 192.168.33.21:8002 127.0.0.1:8002]

And the order in which you perform download or from different clients is random each time.

Ⅴ. Special notes for reviews

+498 -54

4 comments

11 changed files

Starnop

pr closed time in 20 days

Pull request review commentdragonflyoss/Dragonfly

pkg: add error handling

 func Sha256(value string) string { func Sha1(contents []string) string { 	h := sha1.New() 	for _, content := range contents {-		io.WriteString(h, content)+		if _, err := io.WriteString(h, content); err != nil {+			fmt.Fprintf(os.Stderr, "fail to write string to io.Write %v", err)

failed to write string to io.Write: %v

please use failed and :

hwdef

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

pkg: add error handling

 func Sha256(value string) string { func Sha1(contents []string) string { 	h := sha1.New() 	for _, content := range contents {-		io.WriteString(h, content)+		if _, err := io.WriteString(h, content); err != nil {+			fmt.Println(err)

I do not mean return err, but stream error message into stderr rather than stdout.

hwdef

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

dfdaemon: specify context when invokes dfget

  package downloader +import "context"+ // Interface specifies on how an plugin can download a file. type Interface interface { 	// Download download url file to file name 	// return dst path and download error 	Download(url string, header map[string][]string, name string) (string, error)

I am wondering if we could directly remove Download(url string, header map[string][]string, name string) (string, error) . @Starnop @yeya24 @lowzj

zhouhaibing089

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

docs: optimize the config documents

 # This file is the template of dfdaemon configuration file. # You can configure your dfdaemon by change the parameter according your requirement. -# RegistryMirror configures the mirror of the official docker registry

Is it https://github.com/adrienverge/yamllint?

Starnop

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

feature: add weight for node config

 import ( // Since 0.2.0, the INI config is just to be compatible with previous versions. // The YAML config will have more properties: // 		nodes:-// 		    - 127.0.0.1-// 		    - 10.10.10.1+// 		    - 127.0.0.1/1+// 		    - 10.10.10.1:8002/2 // 		localLimit: 20M // 		totalLimit: 20M // 		clientQueueSize: 6 type Properties struct {-	// Nodes specify supernodes.-	Nodes []string `yaml:"nodes,omitempty" json:"nodes,omitempty"`+	// Supernodes specify supernodes with weight.

please add an example in code. ["aaaaaa:1233", "sdfghj"]

Starnop

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

feature: add weight for node config

 func transFilter(filter string) []string { 	return strings.Split(filter, "&") } -func handleNodes() error {+func handleNodes(nodeWithWeightList []string) ([]string, error) { 	nodes := make([]string, 0)+	weightTree := make(map[int][]string)+	weightKey := make([]int, 0) -	for _, v := range cfg.Nodes {-		// TODO: check the validity of v.-		if strings.IndexByte(v, ':') > 0 {-			nodes = append(nodes, v)-			continue+	for _, v := range nodeWithWeightList {+		node, weight, err := splitNodeAndWight(v)+		if err != nil {+			return nil, errors.Wrapf(errortypes.ErrInvalidValue, "node: %s %v", v, err) 		}-		nodes = append(nodes, fmt.Sprintf("%s:%d", v, config.DefaultSupernodePort))+		weightKey = append(weightKey, weight)++		node, err = handleDefaultPort(node)+		if err != nil {+			return nil, errors.Wrapf(errortypes.ErrInvalidValue, "node: %s %v", v, err)+		}+		weightTree[weight] = append(weightTree[weight], node) 	}-	cfg.Nodes = nodes-	return nil++	// get the the greatest common divisor of the weight slice and+	gcdNumber := gcdSlice(weightKey)+	for k, v := range weightTree {+		for i := 0; i < (k / gcdNumber); i++ {+			nodes = append(nodes, v...)+		}+	}++	return nodes, nil+}++// gcdSlice returns the greatest common divisor of a slice.+func gcdSlice(s []int) int {+	length := len(s)+	if length == 1 {+		return s[0]+	}++	return gcd(s[length-1], gcdSlice(s[:length-1]))+}++// gcd returns the greatest common divisor of x and y.+func gcd(x, y int) int {+	var z int+	for y != 0 {+		z = x % y+		x = y+		y = z+	}+	return x+}++func handleDefaultPort(node string) (string, error) {+	result := strings.Split(node, ":")+	splitLength := len(result)++	if splitLength == 2 {+		if result[0] == "" || result[1] == "" {+			return "", errortypes.ErrInvalidValue+		}+		return node, nil+	}++	if splitLength == 1 {+		return fmt.Sprintf("%s:%d", node, config.DefaultSupernodePort), nil+	}++	return "", errortypes.ErrInvalidValue+}++func splitNodeAndWight(value string) (string, int, error) {+	result := strings.Split(value, "/")+	splitLength := len(result)++	if splitLength < 1 || splitLength > 2 {+		return "", 0, errortypes.ErrInvalidValue+	}+	if splitLength == 2 {+		v, err := strconv.Atoi(result[1])+		if err != nil {+			return "", 0, err+		}+		return result[0], v, nil+	}+	return result[0], 1, nil

1 is the default value? If that, please add more comment in the function annotation.

Starnop

comment created time in 22 days

Pull request review commentdragonflyoss/Dragonfly

feature: add weight for node config

 func transFilter(filter string) []string { 	return strings.Split(filter, "&") } -func handleNodes() error {+func handleNodes(nodeWithWeightList []string) ([]string, error) { 	nodes := make([]string, 0)+	weightTree := make(map[int][]string)+	weightKey := make([]int, 0) -	for _, v := range cfg.Nodes {-		// TODO: check the validity of v.-		if strings.IndexByte(v, ':') > 0 {-			nodes = append(nodes, v)-			continue+	for _, v := range nodeWithWeightList {+		node, weight, err := splitNodeAndWight(v)+		if err != nil {+			return nil, errors.Wrapf(errortypes.ErrInvalidValue, "node: %s %v", v, err) 		}-		nodes = append(nodes, fmt.Sprintf("%s:%d", v, config.DefaultSupernodePort))+		weightKey = append(weightKey, weight)++		node, err = handleDefaultPort(node)+		if err != nil {+			return nil, errors.Wrapf(errortypes.ErrInvalidValue, "node: %s %v", v, err)+		}+		weightTree[weight] = append(weightTree[weight], node) 	}-	cfg.Nodes = nodes-	return nil++	// get the the greatest common divisor of the weight slice and+	gcdNumber := gcdSlice(weightKey)+	for k, v := range weightTree {+		for i := 0; i < (k / gcdNumber); i++ {+			nodes = append(nodes, v...)+		}+	}++	return nodes, nil+}++// gcdSlice returns the greatest common divisor of a slice.+func gcdSlice(s []int) int {+	length := len(s)+	if length == 1 {+		return s[0]+	}++	return gcd(s[length-1], gcdSlice(s[:length-1]))+}++// gcd returns the greatest common divisor of x and y.+func gcd(x, y int) int {+	var z int+	for y != 0 {+		z = x % y+		x = y+		y = z+	}+	return x+}++func handleDefaultPort(node string) (string, error) {+	result := strings.Split(node, ":")+	splitLength := len(result)++	if splitLength == 2 {+		if result[0] == "" || result[1] == "" {+			return "", errortypes.ErrInvalidValue+		}+		return node, nil+	}++	if splitLength == 1 {+		return fmt.Sprintf("%s:%d", node, config.DefaultSupernodePort), nil+	}++	return "", errortypes.ErrInvalidValue+}++func splitNodeAndWight(value string) (string, int, error) {

s/splitNodeAndWight/splitNodeAndWeight ?

Starnop

comment created time in 22 days

issue commentdragonflyoss/Dragonfly

[Community] Prepare for the new version

Could we nail down specific time for the detailed work? @Starnop Otherwise, maybe little productivity could be guaranteed.

Starnop

comment created time in 22 days

push eventallencloud/Dragonfly

alan

commit sha ed5a3effe89da11e910b7e63a02dfc27b6a5dc9b

feature: add tasks create actions in client pkg of golang sdk Signed-off-by: alan <zg.zhu@daocloud.io>

view details

wybzju

commit sha a0331aa3b4ec70306894640dfcfd109de78df7f3

bugfix: the dfget will wait forever when the final piece failed Signed-off-by: wybzju <552044481@qq.com>

view details

Starnop

commit sha fc4099bca3e18dd4e158ac8b1b9f9e034f368523

bugfix: return error when the url is unreachable Signed-off-by: Starnop <starnop@163.com>

view details

lowzj

commit sha 5fc963546319b27f88ee03a1bfc52033ea94d75a

Merge pull request #739 from Starnop/supernode-not-found bugfix: return error when the url is unreachable

view details

yeya24

commit sha 144060c09c627841e32ecc597ea90cfbff59362b

change log level Signed-off-by: yeya24 <yb532204897@gmail.com>

view details

liuyuxing

commit sha 0a64c59b5e5f2541259a072cb2f95af48c278156

Merge pull request #774 from yeya24/change-log-level move some log level to debug

view details

pouchrobot

commit sha 865be5e43bd16395e1f576f81816517f129e5a9a

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 68ba7b484d93656b3ce84eff257ec2679e326058

Merge pull request #780 from pouchrobot/auto-doc-2019-08-03 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

Starnop

commit sha 1599fa20e003da1aa6ddf4f60a8fb299fc32817b

feature: add golbal dfget params in the dfdaemon config Signed-off-by: Starnop <starnop@163.com>

view details

lowzj

commit sha 24aa469dcd503e0a5b0a4cb2ff3d39f77e4e856f

Merge pull request #771 from Starnop/bug-ip feature: add golbal dfget params to the dfdaemon config

view details

yeya24

commit sha 4c17e18d49e0c269e52296c85bc4af2b3b2942ec

fix bug unknown profile Signed-off-by: yeya24 <yb532204897@gmail.com>

view details

liuyuxing

commit sha 5b1ecaabbde805c3ed056c4d4158b782de631e32

Merge pull request #786 from yeya24/fix/fix-unknown-pprof bugfix: fix bug unknown profile

view details

dzzg

commit sha b543c7d25453907c568178da6a5abc827e01f603

cleanup: log message typo fix Signed-off-by: dzzg <zhengguang.zhu@daocloud.io>

view details

pouchrobot

commit sha b28ef5394634fd34e57e219f7aa3d3cd1d92d004

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

lowzj

commit sha 41f23b0ed2590f25fc1c6078aa294d7592f864c2

Merge pull request #787 from dzzg/patch-2 cleanup: log message typo fix

view details

liuyuxing

commit sha 49c1fd2dcb816473b6ea7ca28f1962ecbbf5a8e5

Merge pull request #790 from pouchrobot/auto-doc-2019-08-06 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

宋文杰

commit sha edf7259c862ce96993b6c7a540477c30dbfc52ff

docs: improve docs Signed-off-by: 宋文杰 <wenjie.song@daocloud.io>

view details

Allen Sun

commit sha e659d7f770737065cea38eb41a399d25c2a872b4

Merge pull request #763 from Songjoy/master docs: improve docs

view details

pouchrobot

commit sha b7fff9cc7a114150d9ddd578456f971a95971a25

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha c0ecd2933b0dccca5e711cee8849d8030cd28b99

Merge pull request #793 from pouchrobot/auto-doc-2019-08-07 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 23 days

PR opened dragonflyoss/Dragonfly

docs: add Yum China as a Dragonfly adopter

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Actually now Yum China is already an adopter of Dragonfly, see from https://github.com/dragonflyoss/Dragonfly/issues/219#issuecomment-545705738

This adds Yum China in repo adopters.md.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> no need

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

no need

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

+2 -2

0 comment

2 changed files

pr created time in 23 days

create barnchallencloud/Dragonfly

branch : add-yumchina

created branch time in 23 days

Pull request review commentdragonflyoss/Dragonfly

pkg: add error handling

 func DeleteFile(filePath string) error { func DeleteFiles(filePaths ...string) { 	if len(filePaths) > 0 { 		for _, f := range filePaths {-			DeleteFile(f)+			if err := DeleteFile(f); err != nil {+				fmt.Println(err)

same issue.

hwdef

comment created time in 23 days

Pull request review commentdragonflyoss/Dragonfly

pkg: add error handling

 func Sha256(value string) string { func Sha1(contents []string) string { 	h := sha1.New() 	for _, content := range contents {-		io.WriteString(h, content)+		if _, err := io.WriteString(h, content); err != nil {+			fmt.Println(err)

fmt.Println(err) would send error message to the stdout, I am wondering if we should send it to stderr.

In addition, I wish to see the principle that where indeed we should handle the returned error?

hwdef

comment created time in 23 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -0

2 comments

1 changed file

pouchrobot

pr closed time in 23 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 5370a9a97a1f1140fe98c103d55079c7da2a683c

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 6e396a3d473a0fa0ecf4f70a39551c151454cfe6

Merge pull request #1035 from pouchrobot/auto-doc-2019-10-29 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 23 days

issue commentdragonflyoss/Dragonfly

We need more detailed http configuration

Yes, I think that is what we need. Could you put forwards pull requests to make it? @ww3122000 Thanks.

ww3122000

comment created time in 24 days

issue commentdragonflyoss/Dragonfly

More flexible pieces size settings

Please see https://github.com/dragonflyoss/Dragonfly/blob/master/FAQ.md#what-is-the-size-of-blockpiece-when-distribution

ww3122000

comment created time in 24 days

pull request commentdragonflyoss/Dragonfly

bug fix dfget client timeout set error when fileLength is 0

In addition, if you need to real-time chatting, please see https://github.com/dragonflyoss/Dragonfly/issues/291 to join us.

ww3122000

comment created time in 24 days

pull request commentdragonflyoss/Dragonfly

bug fix dfget client timeout set error when fileLength is 0

Thanks for your contribution, Please help to sign https://github.com/dragonflyoss/Dragonfly/pull/1032/checks?check_run_id=277021510. @ww3122000

ww3122000

comment created time in 24 days

MemberEvent

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -1

2 comments

1 changed file

pouchrobot

pr closed time in 24 days

pull request commentdragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code

duplicate with https://github.com/dragonflyoss/Dragonfly/pull/1031, closing

pouchrobot

comment created time in 24 days

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -1

2 comments

1 changed file

pouchrobot

pr closed time in 24 days

pull request commentdragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code

duplicate with https://github.com/dragonflyoss/Dragonfly/pull/1031, closing

pouchrobot

comment created time in 24 days

PR merged dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code LGTM areas/docs size/XS

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+1 -1

1 comment

1 changed file

pouchrobot

pr closed time in 24 days

push eventdragonflyoss/Dragonfly

pouchrobot

commit sha 3ffe4a2dcf037a17ae0004c68611ca36cecbce50

docs: auto generate Dragonfly cli/api docs via code Signed-off-by: pouchrobot <pouch-dev@list.alibaba-inc.com>

view details

Allen Sun

commit sha 5dd6fbb19a0c54a8d6f580d300811c916aabd1ec

Merge pull request #1031 from pouchrobot/auto-doc-2019-10-28 docs: auto generate Dragonfly cli/api/contributors docs via code

view details

push time in 24 days

PR opened dragonflyoss/community

docs: add cncf sig storage feedback

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

+29 -0

0 comment

2 changed files

pr created time in a month

create barnchallencloud/community

branch : add-sig-storage

created branch time in a month

issue closeddragonflyoss/Dragonfly

Weekly Digest (13 October, 2019 - 20 October, 2019)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 14 issues were created. Of these, 5 issues have been closed and 9 issues are still open.

OPEN ISSUES

:green_heart: #1013 Pull image encounter 502 Bad Gateway, by zhujian7 :green_heart: #1012 WeeklyReport of Dragonfly from 2019-10-11 to 2019-10-18, by pouchrobot :green_heart: #1011 All client nodes always prompt for waitting, and then a few seconds later prompt for download failure., by sodwell :green_heart: #1010 Error response from daemon: Get https://mydocker-registry/v2/: Not Found, by jessiezhou0424 :green_heart: #1007 docker pull images via dfget: read piece cont error, by KeepCaim :green_heart: #1004 add err handling in /test/command/, by tanjunchen :green_heart: #1002 [feature request]load the scheduleMgr by compile a file of plug-ins, by yunfeiyanggzq :green_heart: #1001 [help request][docs] add config doc for dfget and dfdaemon, by yunfeiyanggzq :green_heart: #1000 feature: add schedule plugin, by yunfeiyanggzq

CLOSED ISSUES

:heart: #1009 update pouchlinter to 0.2.4, by yeya24 :heart: #1008 docs: add qihoo 360 as adopter, by allencloud :heart: #1006 df, by KeepCaim :heart: #1005 feature: upgrade golang version to 1.12.10, by fengzixu :heart: #1003 version: add error handling, by hwdef

LIKED ISSUE

:+1: #1000 feature: add schedule plugin, by yunfeiyanggzq It received :+1: x2, :smile: x0, :tada: x0 and :heart: x0.

NOISY ISSUE

:speaker: #1000 feature: add schedule plugin, by yunfeiyanggzq It received 6 comments.


PULL REQUESTS

Last week, 19 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 13 pull requests were updated. :yellow_heart: #1004 add err handling in /test/command/, by tanjunchen :yellow_heart: #1000 feature: add schedule plugin, by yunfeiyanggzq :yellow_heart: #990 bugfix:fix debug mod and homedir config in yaml, by yunfeiyanggzq :yellow_heart: #943 Using GOPROXY environment variables if set instead of default value, by SataQiu :yellow_heart: #942 feature:registry mirror support direct param., by zcc35357949 :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #802 Add dfget and dfdaemon properties document, by xzy256 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #757 feature: support multi https backend, by wybzju :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 6 pull requests were merged. :purple_heart: #1009 update pouchlinter to 0.2.4, by yeya24 :purple_heart: #1008 docs: add qihoo 360 as adopter, by allencloud :purple_heart: #1005 feature: upgrade golang version to 1.12.10, by fengzixu :purple_heart: #1003 version: add error handling, by hwdef :purple_heart: #981 feature: enable viper for supernode, by SataQiu :purple_heart: #953 feature: add a warn log for long gc duration, by SataQiu


COMMITS

Last week there were 11 commits. :hammer_and_wrench: Merge pull request #1008 from allencloud/add-360 docs: add qihoo 360 as adopter by Starnop :hammer_and_wrench: Merge pull request #953 from SataQiu/add-long-gc-warn-20190923 feature: add a warn log for long gc duration by allencloud :hammer_and_wrench: feature: add a warn log for long gc duration Signed-off-by: SataQiu qiushida@beyondcent.com by SataQiu :hammer_and_wrench: Merge pull request #1009 from yeya24/update-pouchlinter update pouchlinter to 0.2.4 by allencloud :hammer_and_wrench: update pouchlinter to 0.2.4 Signed-off-by: yeya24 yb532204897@gmail.com by yeya24 :hammer_and_wrench: docs: add qihoo 360 as adopter Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com by allencloud :hammer_and_wrench: Merge pull request #1003 from hwdef/add-err-handling3 version: add error handling by allencloud :hammer_and_wrench: version: add error handling Signed-off-by: hwdef hwdef97@gmail.com by hwdef :hammer_and_wrench: Merge pull request #1005 from fengzixu/upgrade-golang-version feature: upgrade golang version to 1.12.10 by allencloud :hammer_and_wrench: feature: upgrade golang version to 1.12.10 Related to: https://github.com/dragonflyoss/Dragonfly/issues/989 Signed-off-by: fengzixu hnustphoenix@gmail.com by fengzixu :hammer_and_wrench: Merge pull request #981 from SataQiu/viper-supernode-20191002 feature: enable viper for supernode by Starnop


CONTRIBUTORS

Last week there were 6 contributors. :bust_in_silhouette: Starnop :bust_in_silhouette: allencloud :bust_in_silhouette: SataQiu :bust_in_silhouette: yeya24 :bust_in_silhouette: hwdef :bust_in_silhouette: fengzixu


STARGAZERS

Last week there were 19 stagazers. :star: vixrant :star: aprasadh :star: leverz :star: MaXiaoFei9527 :star: Fe-Nik-S :star: SomniVertix :star: yokoyang :star: dangdennis :star: liuxintong :star: scwall :star: xiaohu159 :star: the-coffee-coder :star: nasacj :star: hwangjr :star: Feeeenng :star: agarwalarjun123 :star: FreezeSoul :star: gandalf1024 :star: cnyy7 You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in a month

weekly-digest[bot]

startedoam-dev/rudr

started time in a month

pull request commentdragonflyoss/Dragonfly

feature:registry mirror support direct param.

Could we make this move on? @zcc35357949 @inoc603 @lowzj @Starnop

zcc35357949

comment created time in a month

push eventdragonflyoss/Dragonfly

SataQiu

commit sha f1a48828e27100a5762606e0ee7fd6932af7cdae

feature: add a warn log for long gc duration Signed-off-by: SataQiu <qiushida@beyondcent.com>

view details

Allen Sun

commit sha 40f71566b988f4547ae4e2a64551aab3a6798501

Merge pull request #953 from SataQiu/add-long-gc-warn-20190923 feature: add a warn log for long gc duration

view details

push time in a month

PR merged dragonflyoss/Dragonfly

feature: add a warn log for long gc duration LGTM areas/log kind/feature size/S

Signed-off-by: SataQiu qiushida@beyondcent.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

feature: add a warn log for long gc duration

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

/cc @Starnop @yeya24

+34 -2

5 comments

3 changed files

SataQiu

pr closed time in a month

pull request commentdragonflyoss/Dragonfly

feature: add a warn log for long gc duration

LGTM

SataQiu

comment created time in a month

Pull request review commentdragonflyoss/Dragonfly

feature: add a warn log for long gc duration

 import ( 	"github.com/sirupsen/logrus" ) +const (+	// downloadPieceTimeoutSeconds specifies the timeout for piece downloading.+	// If the actual execution time exceeds this threshold, a warning will be thrown.+	downloadPieceTimeoutSeconds = 2.0

I would like to see it as downloadPieceTimeout = 2.0 * time.Second Actually we usually directly use duration rather than digital number. Since it would be more readable.

SataQiu

comment created time in a month

push eventdragonflyoss/Dragonfly

yeya24

commit sha 1ecd2cf6450b91e6266761711b45bd099412921b

update pouchlinter to 0.2.4 Signed-off-by: yeya24 <yb532204897@gmail.com>

view details

Allen Sun

commit sha e6351e31d4a1aa856b2325a00f4b9222b916a6ba

Merge pull request #1009 from yeya24/update-pouchlinter update pouchlinter to 0.2.4

view details

push time in a month

PR merged dragonflyoss/Dragonfly

update pouchlinter to 0.2.4 size/XS

Signed-off-by: yeya24 yb532204897@gmail.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Update pouchlinter

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> fixes #989

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+1 -6

1 comment

2 changed files

yeya24

pr closed time in a month

issue closeddragonflyoss/Dragonfly

update golang 1.12.6 to 1.12.10

Ⅰ. Issue Description

There is a CVE for Go and this vulnerability is fixed in 1.12.10. We should update it. See: https://nvd.nist.gov/vuln/detail/CVE-2019-16276

Some work need to do for updating go

  • update ci

closed time in a month

yeya24

Pull request review commentdragonflyoss/Dragonfly

update pouchlinter to 0.2.4

 script:  # after_success: #   - bash <(curl -s https://codecov.io/bash) || echo "Failed to report code coverage!"--cache:

No, we don't.

yeya24

comment created time in a month

Pull request review commentdragonflyoss/Dragonfly

update pouchlinter to 0.2.4

 script:  # after_success: #   - bash <(curl -s https://codecov.io/bash) || echo "Failed to report code coverage!"--cache:

Why to delete this, is this related to pouchlinter?

yeya24

comment created time in a month

pull request commentdragonflyoss/Dragonfly

update pouchlinter to 0.2.4

LGTM

yeya24

comment created time in a month

issue commentdragonflyoss/Dragonfly

update golang 1.12.6 to 1.12.10

I believe that we also need to update pouch linter as well. @allencloud see pouchcontainer/pouchlinter#20

I have release a new version 0.2.4 of pouchlinter, see https://github.com/pouchcontainer/pouchlinter/blob/v0.2.4/Dockerfile#L23. And I also have pushed image pouchcontainer/pouchlinter:v0.2.4 to dockerhub.

Please check. If it is OK, I think we could close this, right> If not, please feel free to contact me. Thanks. @yeya24

yeya24

comment created time in a month

MemberEvent

pull request commentpouchcontainer/pouchlinter

update to go 1.12.10

I know your point. While I think this project provides general functionalities. It is OK to be here. If you wish to make it move on fast, I would authorize you as an administrator of this repo.

yeya24

comment created time in a month

created tagpouchcontainer/pouchlinter

tagv0.2.4

pouchlinter is a very useful container image used in all pouch-related open source golang repositories

created time in a month

release pouchcontainer/pouchlinter

v0.2.4

released time in a month

push eventpouchcontainer/pouchlinter

yeya24

commit sha 21eb7b343839eb37caf68a8e97399019302c6ee9

update to go 1.12.10 Signed-off-by: yeya24 <yb532204897@gmail.com>

view details

Allen Sun

commit sha e88a6cd2ff1a99d6905b806783167e416c70ffba

Merge pull request #20 from yeya24/update-1.12.10 update to go 1.12.10

view details

push time in a month

PR merged pouchcontainer/pouchlinter

update to go 1.12.10

Signed-off-by: yeya24 yb532204897@gmail.com

+1 -1

1 comment

1 changed file

yeya24

pr closed time in a month

pull request commentpouchcontainer/pouchlinter

update to go 1.12.10

LGTM

yeya24

comment created time in a month

Pull request review commentdragonflyoss/Dragonfly

add err handling in /test/command/

 func (s *Starter) KillAll() { func (s *Starter) Clean() { 	s.KillAll() 	if s.Home != "" {-		os.RemoveAll(s.Home)+		if err := os.RemoveAll(s.Home); err != nil {

I do not think every error should be declared and printed. Even printed, not necessary as a Error level. You can see lots of docs, like: https://travix.io/unhandled-errors-in-go-3f341f2704dd

tanjunchen

comment created time in a month

PR opened dragonflyoss/Dragonfly

docs: add qihoo 360 as adopter

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Like the comment https://github.com/dragonflyoss/Dragonfly/issues/219#issuecomment-535476035 here, qihoo 360 has adopted Dragonfly already.

This PR adds qihoo 360 in the adopters.md.

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" --> none

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

none

Ⅳ. Describe how to verify it

none

Ⅴ. Special notes for reviews

none

+1 -0

0 comment

2 changed files

pr created time in a month

create barnchallencloud/Dragonfly

branch : add-360

created branch time in a month

push eventdragonflyoss/Dragonfly

hwdef

commit sha 4d50854459f06056ee918d561f05bf547d4a08a0

version: add error handling Signed-off-by: hwdef <hwdef97@gmail.com>

view details

Allen Sun

commit sha 8b120a8899bc89f101440afd9a6929275ec5e485

Merge pull request #1003 from hwdef/add-err-handling3 version: add error handling

view details

push time in a month

PR merged dragonflyoss/Dragonfly

version: add error handling LGTM kind/bug size/XS

Signed-off-by: hwdef hwdef97@gmail.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

add error handling

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

Ref: #952

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

+2 -1

2 comments

1 changed file

hwdef

pr closed time in a month

pull request commentdragonflyoss/Dragonfly

version: add error handling

LGTM,code format is the way you talk, communicate. We are always bringing convenience when delivering code. Thanks for your update. Wish to write strict and friendly code together. @hwdef

hwdef

comment created time in a month

startedAliyunContainerService/image-syncer

started time in a month

Pull request review commentdragonflyoss/Dragonfly

version: add error handling

 func Handler(w http.ResponseWriter, r *http.Request) { 		http.Error(w, fmt.Sprintf("error encoding JSON: %s", err), http.StatusInternalServerError) 	} else { 		w.WriteHeader(http.StatusOK)-		w.Write(data)+		if _, err := w.Write(data); err != nil {+			http.Error(w, fmt.Sprintf("error writing the data to the connection: %s", err), http.StatusInternalServerError)+		}

If that, you can combine the code like:

if err != nil {
    http.Error(w, fmt.Sprintf("error encoding JSON: %s", err), http.StatusInternalServerError)
} else if _, err := w.Write(data); err != nil {
    http.Error(w, fmt.Sprintf("error writing the data to the connection: %s", err), http.StatusInternalServerError)
} else {
    w.WriteHeader(http.StatusOK)
}

And in this way, you could reduce the ident? right? WDYT

hwdef

comment created time in a month

issue closeddragonflyoss/Dragonfly

update golang 1.12.6 to 1.12.10

Ⅰ. Issue Description

There is a CVE for Go and this vulnerability is fixed in 1.12.10. We should update it. See: https://nvd.nist.gov/vuln/detail/CVE-2019-16276

Some work need to do for updating go

  • update ci

closed time in a month

yeya24

issue commentdragonflyoss/Dragonfly

update golang 1.12.6 to 1.12.10

fixed by https://github.com/dragonflyoss/Dragonfly/pull/1005

yeya24

comment created time in a month

push eventdragonflyoss/Dragonfly

fengzixu

commit sha 3bf86b884b31585e24aa509f4624edb4a6426753

feature: upgrade golang version to 1.12.10 Related to: https://github.com/dragonflyoss/Dragonfly/issues/989 Signed-off-by: fengzixu <hnustphoenix@gmail.com>

view details

Allen Sun

commit sha 46d417f64bd21c8b41ff63ce4fb385b3961ba20a

Merge pull request #1005 from fengzixu/upgrade-golang-version feature: upgrade golang version to 1.12.10

view details

push time in a month

PR merged dragonflyoss/Dragonfly

feature: upgrade golang version to 1.12.10 LGTM kind/feature size/S

Signed-off-by: fengzixu hnustphoenix@gmail.com

<!-- Please make sure you have read and understood the contributing guidelines; https://github.com/dragonflyoss/dragonfly/blob/master/CONTRIBUTING.md -->

Ⅰ. Describe what this PR did

Due to the golang vulnerability, we need to upgrade golang version

Ⅱ. Does this pull request fix one issue?

<!--If that, add "fixes #xxxx" below in the next line, for example, fixes #15. Otherwise, add "NONE" -->

#989

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

I run make build and make unit-test to verify

Ⅴ. Special notes for reviews

+13 -13

6 comments

11 changed files

fengzixu

pr closed time in a month

pull request commentdragonflyoss/Dragonfly

feature: upgrade golang version to 1.12.10

LGTM

fengzixu

comment created time in a month

Pull request review commentdragonflyoss/Dragonfly

feature: upgrade golang version to 1.12.10

 dfdaemon version [flags] dfdaemon version  0.4.1   Git commit:     6fd5c8f   Build date:     20190717-15:57:52-  Go version:     go1.12.6+  Go version:     go1.12.10

Actually you do not need to update this file. But it is OK.

fengzixu

comment created time in a month

Pull request review commentdragonflyoss/Dragonfly

version: add error handling

 func Handler(w http.ResponseWriter, r *http.Request) { 		http.Error(w, fmt.Sprintf("error encoding JSON: %s", err), http.StatusInternalServerError) 	} else { 		w.WriteHeader(http.StatusOK)-		w.Write(data)+		if _, err := w.Write(data); err != nil {+			http.Error(w, fmt.Sprintf("error writing the data to the connection: %s", err), http.StatusInternalServerError)+		}

How about:

if _, err := w.Write(data); err != nil {
    http.Error(w, fmt.Sprintf("error writing the data to the connection: %s", err), http.StatusInternalServerError)
} else {
    w.WriteHeader(http.StatusOK)
}
hwdef

comment created time in a month

issue closeddragonflyoss/Dragonfly

Weekly Digest (6 October, 2019 - 13 October, 2019)

Here's the Weekly Digest for dragonflyoss/Dragonfly:


ISSUES

Last week 11 issues were created. Of these, 2 issues have been closed and 9 issues are still open.

OPEN ISSUES

:green_heart: #998 Is there an option to disabling back source downloading for images?, by NikiChr :green_heart: #997 Dfdaemon calls dfget and zombie mileage occurs, by ftlynx :green_heart: #996 Can I pause in downloading and continue downloading it after a pause?, by YCait :green_heart: #993 If the file source is updated more frequently (e.g. once an hour), dfget will have files that cannot be updated in time., by huerlei :green_heart: #992 WeeklyReport of Dragonfly from 2019-10-04 to 2019-10-11, by pouchrobot :green_heart: #991 support katacoda scenario for Dragonfly, by yeya24 :green_heart: #990 bugfix:fix debug mod and homedir config in yaml, by yunfeiyanggzq :green_heart: #989 update golang 1.12.6 to 1.12.10, by yeya24 :green_heart: #988 doc: add a config doc for supernode, by yunfeiyanggzq

CLOSED ISSUES

:heart: #995 镜像仓库回源问题 | Return of Mirror Warehouse, by ftlynx :heart: #994 bugfix: remove duplicate rate.MB, by Starnop

LIKED ISSUE

:+1: #991 support katacoda scenario for Dragonfly, by yeya24 It received :+1: x2, :smile: x0, :tada: x0 and :heart: x0.

NOISY ISSUE

:speaker: #990 bugfix:fix debug mod and homedir config in yaml, by yunfeiyanggzq It received 5 comments.


PULL REQUESTS

Last week, 18 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 13 pull requests were updated. :yellow_heart: #990 bugfix:fix debug mod and homedir config in yaml, by yunfeiyanggzq :yellow_heart: #988 doc: add a config doc for supernode, by yunfeiyanggzq :yellow_heart: #981 feature: enable viper for supernode, by SataQiu :yellow_heart: #980 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :yellow_heart: #973 bugfix: set tls config if existed when dfget downloads from the sourc…, by zcc35357949 :yellow_heart: #953 feature: add a warn log for long gc duration, by SataQiu :yellow_heart: #826 feature: support dfget params for each proxy, by yeya24 :yellow_heart: #791 feature: add part of tasks HTTP API, by Starnop :yellow_heart: #758 feature:add a cli command to ha pattern (HA third part), by yunfeiyanggzq :yellow_heart: #757 feature: support multi https backend, by wybzju :yellow_heart: #741 feature:Use rpc to get file information from other supernodes(HA second part), by yunfeiyanggzq :yellow_heart: #740 feature: install the swagger if it has not been installed, by Starnop :yellow_heart: #694 feature:Use etcd to manager supernode ha cluster(HA first part), by yunfeiyanggzq

MERGED PULL REQUEST

Last week, 5 pull requests were merged. :purple_heart: #994 bugfix: remove duplicate rate.MB, by Starnop :purple_heart: #983 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #979 docs: auto generate Dragonfly cli/api/contributors docs via code, by pouchrobot :purple_heart: #975 dfget&&supernode: cleanup code based on staticcheck warnings, by hwdef :purple_heart: #964 fix(dfdaemon): add error handling , by hwdef


COMMITS

Last week there were 8 commits. :hammer_and_wrench: Merge pull request #994 from Starnop/double-MB bugfix: remove duplicate rate.MB by lowzj :hammer_and_wrench: bugfix: remove duplicate rate.MB Signed-off-by: Starnop starnopg@gmail.com by Starnop :hammer_and_wrench: Merge pull request #975 from hwdef/fix-staticcheck-warning3 dfget&&supernode: cleanup code based on staticcheck warnings by allencloud :hammer_and_wrench: Merge pull request #979 from pouchrobot/auto-doc-2019-10-01 docs: auto generate Dragonfly cli/api/contributors docs via code by Starnop :hammer_and_wrench: dfget&&supernode: cleanup code based on staticcheck warnings Signed-off-by: hwdef hwdef97@gmail.com by hwdef :hammer_and_wrench: Merge pull request #964 from hwdef/add-err-handling fix(dfdaemon): add error handling by Starnop :hammer_and_wrench: fix(dfdaemon): add error handling Signed-off-by: hwdef hwdef97@gmail.com by hwdef :hammer_and_wrench: Merge pull request #983 from pouchrobot/auto-doc-2019-10-03 docs: auto generate Dragonfly cli/api/contributors docs via code by Starnop


CONTRIBUTORS

Last week there were 4 contributors. :bust_in_silhouette: lowzj :bust_in_silhouette: Starnop :bust_in_silhouette: allencloud :bust_in_silhouette: hwdef


STARGAZERS

Last week there were 15 stagazers. :star: SmileTower :star: sglmsn :star: wysl :star: damonchen :star: tansyss :star: materliu :star: Wondertan :star: denlaku :star: xiaoyongit520 :star: relearn1 :star: jingminglang :star: ChitoseRaame :star: nextsecs :star: xinke2411 :star: nikitavoloboev You all are the stars! :star2:


RELEASES

Last week there were no releases.


That's all for last week, please <kbd>:eyes: Watch</kbd> and <kbd>:star: Star</kbd> the repository dragonflyoss/Dragonfly to receive next weekly updates. :smiley:

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. :calendar:

closed time in a month

weekly-digest[bot]

pull request commentdragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code

This is duplicate with https://github.com/dragonflyoss/Dragonfly/pull/984. Close it now.

pouchrobot

comment created time in a month

PR closed dragonflyoss/Dragonfly

docs: auto generate Dragonfly cli/api/contributors docs via code areas/docs size/S

Signed-off-by: pouchrobot pouch-dev@alibaba-inc.com

1.Describe what this PR did This PR is automatically done by AI-based collaborating robot. Pouchrobot will auto-generate cli/api document via https://github.com/spf13/cobra/tree/master/doc every day.

2.Does this pull request fix one issue? None

3.Describe how you did it We use the following user input CLI document generating command in pouchrobot to generate CLI doc: make build && make install && make docs

For API part, we use a tool swagger2markup to make it.

4.Describe how to verify it None

5.Special notes for reviews The cli/api doc must be automatically generated.

+9 -9

2 comments

2 changed files

pouchrobot

pr closed time in a month

issue commentdragonflyoss/Dragonfly

update golang 1.12.6 to 1.12.10

Seems this is fixed in 1.12.10. I suggest we should update to 1.12.10 first

That is great. We can update the golang runtime version to 1.12.10. Could you help to submit a PR? @yeya24

yeya24

comment created time in a month

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2019-10-04 to 2019-10-11

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
191 (↑2) 4228 (↑13) 539 (↑-1) 55 (↑1) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 5 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

doc 📜 📝

  • docs: auto generate Dragonfly cli/api/contributors docs via code (#984)
  • docs: auto generate Dragonfly cli/api/contributors docs via code (#983)
  • docs: auto generate Dragonfly cli/api/contributors docs via code (#979)

others

  • dfget&&supernode: cleanup code based on staticcheck warnings (#975)
  • fix(dfdaemon): add error handling (#964)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@yunfeiyanggzq 6
@Starnop 3
@yeya24 1
@SataQiu 1
@zcc35357949 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in a month

pouchrobot

issue commentdragonflyoss/Dragonfly

update golang 1.12.6 to 1.13.1

Do we have a link of this CVE's impact? @yeya24

The following description seems to be not clear.

Go before 1.12.10 and 1.13.x before 1.13.1 allow HTTP Request Smuggling.
yeya24

comment created time in a month

issue closeddragonflyoss/Dragonfly

WeeklyReport of Dragonfly from 2019-09-27 to 2019-10-04

Weekly Report of Dragonfly

This is a weekly report of Dragonfly. It summarizes what have changed in the project during the passed week, including pr merged, new contributors, and more things in the future. It is all done by @AliGHRobot which is an AI robot. See: https://github.com/pouchcontainer/pouchrobot.

Repo Update

Watch Star Fork Contributors New Issues Closed Issues
189 (↑0) 4215 (↑38) 540 (↑5) 54 (↑-1) 0 0

PR Update

Thanks to contributions from community, Dragonfly team merged 10 pull requests in the repository last week. All these pull requests could be divided into feature, bugfix, doc, test and others:

feature 🆕 🔫

  • feature: add gc disks metrics (#966)
  • feature:make cli better (#909)
  • feature: add grafana dashboard (#902)

bugfix 🐛 🔪

  • bugfix: reduce error logs when download home dir not exist (#960)

doc 📜 📝

  • docs: update stale metrics docs (#972)
  • docs:add FAQ.md abot how dfget connect to supernodes in mul-supernode mode (#954)

others

  • fix(supernode/config): add error handling (#974)
  • pkg, supernode: cleanup code based on static check warning (#969)
  • clinte, dfget, supernode: delete unused functions based on static check (#967)
  • make the struct Properties embedded into config Ref#933 (#936)

Code Review Statistics 🐞 🐞 🐞

This project encourages everyone to participant in code review, in order to improve software quality. Every week @pouchrobot would automatically help to count pull request reviews of single github user as the following. So, try to help review code in this project.

Contributor ID Pull Request Reviews
@allencloud 12
@yunfeiyanggzq 5
@inoc603 4
@hwdef 3
@Starnop 3
@yeya24 2
@xzy256 2
@SataQiu 2
@tanjunchen 1

New Contributors 🎖 🎖 🎖

We have no new contributors in this project this week. Dragonfly team encourages everything about contribution from community. For more details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md . 🍻

Thank all of you!

closed time in a month

pouchrobot
more