aheckmann ( Aaron Heckmann )

If you call createCollection() with null for options, you get a "Cannot read property 'writeConcern' of null" error. Not a problem in TypeScript because technically this function doesn't accept null as a parameter, but might be worth fixing in case JS developers run into it.

Are there any files to ignore?

+1 -1

1 commit in vkarpov15/node-mongodb-native/tree/patch-9 mongodb/node-mongodb-native/tree/4.0

0 comment

1 changed file

pr created time in a day

startedsix2dez/reconftw

started time in a day

starteddocumentationjs/documentation

started time in a day

startedaheckmann/gm

started time in a day

startedWebReflection/dom-identifier

started time in 2 days

created repositoryWebReflection/dom-identifier

An utility to retrieve a unique node path, and find it later on.

created time in 2 days

startedbnkamalesh/webgo

started time in 2 days

issue openedaheckmann/mquery

Typescript support

This library is great! Is it planned to support typescript ?

created time in 2 days

issue openedkoajs/parameter

你好，请问数组如何进行校验？

数据格式如下： [ { "type": "article", "objectId": "5ffd6f8f3b75108c28b1bebf", "name": "articleLike", "email": "xd.qq.com" }, { "type": "article", "objectId": "5ffd6f8f3b75108c28b9bebf", "name": "articleLike", "email": "xd.qq.com" } ]

created time in 2 days

startedkettanaito/naming-cheatsheet

started time in 2 days

Pull request review commentmongodb/node-mongodb-native

fix: Compatibility with mongodb-client-encryption

 export const OPTIONS = {   passphrase: { type: 'any' },   pfx: { type: 'any' },   secureProtocol: { type: 'any' },-  index: { type: 'any' }+  index: { type: 'any' },+  // Legacy Options, these are unused but left here to avoid errors with CSFLE lib+  useNewUrlParser: { type: 'boolean' } as OptionDescriptor,+  useUnifiedTopology: { type: 'boolean' } as OptionDescriptor

And here that's supporting the old options. These still aren't listed in the props for MongoClientOptions (which is why we have the as casting). I would add that they are deprecated but then our CSFLE lib would emit the warnings with no way to disable.

nbbeeken

comment created time in 2 days

Pull request review commentmongodb/node-mongodb-native

fix: Compatibility with mongodb-client-encryption

 export class Collection {     options?: InsertOneOptions | Callback<InsertOneResult>,     callback?: Callback<InsertOneResult>   ): Promise<InsertOneResult> | void {-    if (typeof options === 'function') (callback = options), (options = {});+    if (typeof options === 'function') {+      callback = options;+      options = {};+    }++    // CSFLE passes in { w: 'majority' } to ensure the lib works in both 3.x and 4.x+    // we support that option style here only+    if (options && Reflect.get(options, 'w')) {+      options.writeConcern = WriteConcern.fromOptions(Reflect.get(options, 'w'));+    }

Here that is just checking for the legacy writeConcern shape

nbbeeken

comment created time in 2 days

PR opened mongodb/node-mongodb-native

fix: Compatibility with mongodb-client-encryption

Permits legacy options being used by mongodb-client-encryption's use of the MongoClient constructor. Permits legacy WC option style in insertOne.

NODE-3006

+18 -6

1 commit in mongodb/node-mongodb-native/tree/NODE-3006/CSFLE-fixes mongodb/node-mongodb-native/tree/4.0

0 comment

4 changed files

pr created time in 2 days

create barnchmongodb/node-mongodb-native

branch : NODE-3006/CSFLE-fixes

created branch time in 2 days

push eventmongodb/node-mongodb-native

Anna Henningsen

commit sha 25ef87026bca935b00d30ad943ddd28784f801e8

fix: restore `createAutoEncrypter()` functionality (#2710) Corrects the import name of the AutoEncrypter class. Passes through client constructor options to CSFLE lib. NODE-3042

view details

push time in 2 days

PR merged mongodb/node-mongodb-native

fix: restore `createAutoEncrypter()` functionality

See the ticket description in NODE-3042 for details.

+12 -7

1 commit in addaleax/node-mongodb-native/tree/3042-dev mongodb/node-mongodb-native/tree/4.0

0 comment

2 changed files

addaleax