@slhck I would request to let the issue be there for few more days until we complete our investigation from our side. i will try to provide as much info as possible

tarun-discovery

comment created time in 25 minutes

issue commentNetflix/vmaf

Different VMAF score coming for different runs on same video

@li-zhi I suggest closing this issue, as it has nothing to do with VMAF itself, but ffmpeg and network transmission issues.

tarun-discovery

comment created time in 26 minutes

issue commentNetflix/vmaf

Different VMAF score coming for different runs on same video

This indicates a transmission issue. Without the requested additional information or a reproducible example, I am afraid no one else will be able to help you further though.

tarun-discovery

comment created time in 27 minutes

issue commentNetflix/conductor

Deploying Conductor with HA and DR in mind

@TwoUnderscorez thanks for sharing info regarding dynomite. But the activity in dynomite seems very low (just 3 PRs merged during 2020). And also, I believe netflix is no longer using dynomite as the backend for conductor ... at least not for the queues.

TwoUnderscorez

comment created time in 2 hours

issue commentJedWatson/react-select

The react-select works incorrectly when I remove the react-modal component from DOM

Clicking on the drop-down icon or navigating with the keyboard after closing the modal works fine.

Clicking the component as is (not the icon) does nothing. This is usually expected behavior if the <input> is already focused. The problem is that the onFocus handler on the <input> itself is not being triggered by react-modal returning the focus (i.e. inputElement.focus()).

I remember that this was a React issue, but I can't remember where I saw it mentioned.

fmva

comment created time in 2 hours

issue commentJedWatson/react-select

state value when no options are found

@cseas You could easily make a wrapper which would add this functionality.

Because the component adds a NoOptionsMessage component if there are no options found, we can create a custom component to set a state value if this component renders:

const NoOptionsMessage = ({ selectProps: { setNoOptions }, ...props }) => {
  React.useEffect(() => {
    setNoOptions(true);

    return () => setNoOptions(false);
  }, [setNoOptions]);

  return <components.NoOptionsMessage {...props} />;
}

const customControlStyle = (provided, state) => ({
  ...provided,
  color: state.selectProps.noOptions ? 'red' : null
});

const NoOptionsSelect = () => {
  const [noOptions, setNoOptions] = React.useState(false);

  return <Select
    setNoOptions={setNoOptions}
    noOptions={noOptions}
    components={{ NoOptionsMessage }}
    styles={{ control: customControlStyle }}
  />
}

Only caveat is that the state is being reset to false if the focus is lost / the menu is closed.

cseas

comment created time in 2 hours

push eventNetflix/sureal

Zhi Li

commit sha 50b785f0a881e643374f345a8a05d08d97d21f53

Fix __main__.

Impacted Files	Coverage Δ	Complexity Δ
...onductor/core/execution/WorkflowRepairService.java	`70.27% <85.71%> (+1.69%)`	`13.00 <9.00> (+5.00)`
...ductor/dao/cassandra/CassandraEventHandlerDAO.java	`65.78% <0.00%> (-10.53%)`	`15.00% <0.00%> (ø%)`
.../conductor/dao/cassandra/CassandraMetadataDAO.java	`53.88% <0.00%> (-4.15%)`	`24.00% <0.00%> (ø%)`
...e/execution/tasks/SystemTaskWorkerCoordinator.java	`83.33% <0.00%> (+2.08%)`	`18.00% <0.00%> (+1.00%)`

Codecov Report

Steps to reproduce

Screenshot

Codecov Report