profile
viewpoint

adamawang/spotify-playlist-picker 2

Picks a playlist or song from your Spotify profile

adamawang/react-express-boilerplate 1

React, Redux, Webpack, Express, Node

adamawang/angular-tictactoe 0

Simple angular based tic tac toe game

adamawang/AreWeThereYet 0

Distance Calculator using Google DistanceMatrix API

adamawang/BTT-config 0

BTT Config file

adamawang/hello-world 0

My first repository

issue commentreact-native-community/react-native-video

Version 4.4.4 IOS14 has the wrong video screen size.

@funkju remove the +++++, that just there to show what lines were added

foxempire

comment created time in 4 days

issue commentreact-native-community/react-native-video

Version 4.4.4 IOS14 has the wrong video screen size.

@coschmit RCTVideo.m

Also confirming the patch is working with latest v5.1.0-alpha8

foxempire

comment created time in 5 days

PR opened shahen94/react-native-video-processing

Update Trimmer.java

Add FFmpegMediaMetadataRetriever.OPTION_CLOSEST option to line 480 where bmp is generated to retrieve a frame that may or may not be a sync frame but is closest to or the same as time.

In reference to #255

+1 -1

0 comment

1 changed file

pr created time in 12 days

push eventadamawang/react-native-video-processing

Adam Wang

commit sha 4ebaf981834bcc3aaad478878eda1c5dc182b575

Update Trimmer.java Add FFmpegMediaMetadataRetriever.OPTION_CLOSEST option to line 480 where bmp is generated

view details

push time in 12 days

issue commentshahen94/react-native-video-processing

getPreviewForSecond on android throwing error setDataSource failed

@sidpauhal it seems the problem is not the URL but rather to find the exact frame for the given second.

If you have a look at the code of the Trimmer.java file on line 552 you will see this code for function getFrameAtTime()

FFmpegMediaMetadataRetriever.IN_PREFERRED_CONFIG = Bitmap.Config.ARGB_8888;
metadataRetriever.setDataSource(source);

bmp = metadataRetriever.getFrameAtTime((long) (sec * 1000000));
if(bmp == null){
  promise.reject("Failed to get preview at requested position.");
   return;
}

If there is no frame on that exact position the variable bmp will be null and hence, no image will be returned.

To overcome that a prop should be added to find the next available frame nearby.

bmp = metadataRetriever.getFrameAtTime((long) (sec * 1000000), FFmpegMediaMetadataRetriever.OPTION_CLOSEST);

I would open a PR @shahen94 but I have unfortunately no time right now.

I hope that helps.

Can confirm adding the FFmpegMediaMetadataRetriever.OPTION_CLOSEST option fixes thumbnail generation for certain videos that may not have an image at that exact time.

sidpauhal

comment created time in 12 days

push eventbunchtogether/react-native-video-processing

Adam Wang

commit sha 7d25ac15aa860a8ba1f1562093983d0d8ec5df0c

Add closest option to thumbnail generation to prevent empty bmp

view details

push time in 12 days

startedjemise111/react-native-swipe-list-view

started time in 2 months

startedleecade/react-native-swiper

started time in 3 months

more