aaronrenner ( Aaron Renner )

At the opened issue on LiveView, there is a comment in which José talks about setting the test to be async false, and further a new integration facililty to help test LiveView, so you could use that instead of Wallaby when testing LV

bartblast

comment created time in 8 hours

startedsabiwara/aja

started time in 9 hours

startedaaronrenner/heroku-buildpack-rgeo-prep

started time in a day

startedaesmail/kaffy

started time in a day

created repositorykeathley/sync_dispatch

created time in a day

startedrclone/rclone

started time in a day

PR opened aaronrenner/phx_gen_auth

Fixed a typo

+1 -1

1 commit in adamtew/phx_gen_auth/tree/patch-1 aaronrenner/phx_gen_auth/tree/master

0 comment

1 changed file

pr created time in a day

fork adamtew/phx_gen_auth

An authentication system generator for Phoenix 1.5 applications.

aaronrenner/phx_gen_auth adamtew/phx_gen_auth

fork in a day

created repositoryjjcarstens/disc_golf

created time in 2 days

startedaaronrenner/phx_gen_auth

started time in 2 days

startedplausible/analytics

started time in 2 days

startedseancribbs/datalog-elixir

started time in 2 days

startedaaronrenner/phx_gen_auth

started time in 2 days

startedaaronrenner/phx_gen_auth

started time in 2 days

issue commentaaronrenner/phx_gen_auth

Create tests that are adaptable

I agree with you that your way of doing things work but:

As a new user, I get 90 errors if I add a name to a user because every test that supposes that the only valid fields are user and password will fail. It is not only to create the fixture, but on user registration you are hardcoding the fields needed, user and password, while my model has 7.
I needed to perform a code review to understand why and modify a good portion of the list of tests. It took make time to do so, and then I needed to add my own tests for name, surname, telephone, etc. It is not a daunting task, but still I believe is easier to extend the tests when you start from a fully valid user attibutes list.

With the valid_user_attributes, I have a way to control what is going on. You can create the user directly, but it makes it easier to understand what is going on: I have valid attributes, I modify one of them for the test (nil, valid, or invalid), I try to create or update the user, see the results and test what happens with the original values. Actually, it allows me to use fixture generators (my phone numbers or names are different every time I create a user, so there is a chance I catch more errors). And all of that without needing to change my tests when I add a new field (all my tests will still be valid, even if I don't assert the new fields).

chargio