Issue

Wallaby.Element.attr("innerHTML") doesn't work anymore with 91.0.4472.19 (after updating from 90.x.x.x). I always get nil, although the element is present. The same for outerHTML.

Is there anything known that the Chromedriver in the latest version has changed in this respect? (BTW. I also did a test with Hound, there it is exactly the same problem, so I kind of assume that the Chromedriver is the problem, but of course I could be completely wrong).

Details

Elixir: 1.12.0 Erlang: 24.0.1 OS: Ubuntu 18.04 Webdriver (selenium, chromedriver, geckodriver, etc): Chromedriver 91.0.4472.19 Browser (Chrome, Firefox, Safari, etc): Chrome Local or CI:

I'm using Wallaby 0.28.0.

Test Code & HTML

Thanks for the update @WernerBuchert :)

Finally there is a new Chromedriver Version: 91.0.4472.101 And it work's again.

its happening https://iacobson.medium.com/phx-gen-auth-and-oauth-for-a-phoenix-liveview-app-a19a27e6befa

I'm also having this warning

Hi @josevalim your tip about Phoenix.HTML JavaScript helped a lot. The line import "phoenix_html" was missing from app.js and putting it in there made the DELETE HTTP verb sign-out links function correctly. Thank you for your quick reply and for creating such an exciting language in the first place!

Perfect - after thinking about it a bit longer, I totally agree about the user experience aspect. I keep your approach and will provide the functionalities by checking if the user has already confirmed or is in certain user-group. Thank you @josevalim 👍 - Elixir changed my live!

Hi @aaronrenner,

I was wondering about the strategy to log in a user right away after the registration. In my case, the login should only be possible if the user confirmed the mail address.

https://github.com/aaronrenner/phx_gen_auth/blob/a9e92df94afb8eef8dae0a41a9c1654863607874/priv/templates/phx.gen.auth/registration_controller.ex#L24

I know, all requirements are somehow special and that's why you created this project. Thank you for that - I learned a lot about it!

I just was wondering if there are any special considerations about logging in right away after registration.

Kind regards and thank you for this template! Martin

You can remove the login call if you prefer and then add a check where the user cannot login until he confirms his e-mail. Or alternatively, allow him to access only part of the application until he confirms.

The reason why we login after registration without confirmation is because that may be a better experience in many cases. If you ask users to wait for an e-mail to arrive... they may lose interest and go elsewhere.

Hi @aaronrenner,

I was wondering about the strategy to log in a user right away after the registration. In my case, the login should only be possible if the user confirmed the mail address.

https://github.com/aaronrenner/phx_gen_auth/blob/a9e92df94afb8eef8dae0a41a9c1654863607874/priv/templates/phx.gen.auth/registration_controller.ex#L24

I know, all requirements are somehow special and that's why you created this project. Thank you for that - I learned a lot about it!

I just was wondering if there are any special considerations about logging in right away after registration.

Kind regards and thank you for this template! Martin

There is a bug with the attribute selector in chromedriver v 91 - see https://bugs.chromium.org/p/chromium/issues/detail?id=1205107
hopefully they will fix it soon

In the meantime I came up with an ugly workaround to get an elements value (aside from downgrading chromedriver)

  defp get_value_attribute(session, css_string) do
    session
    |> execute_script("val = document.querySelector('#{css_string}').value; document.cookie = 'automation_val=' + val")
    |> cookies()
    |> Enum.find(fn x -> x["name"] == "automation_val" end)
    |> Map.get("value")
  end

I'm wondering if somebody else came up with something better