profile
viewpoint
ZYSzys ZYSzys Hangzhou, China https://twitter.com/ZYSzys_ Node.js Core Collaborator @nodejs

gatsbyjs/gatsby 47102

Build blazing fast, modern apps and websites with React

hustcc/canvas-nest.js 3633

:cancer: Interactive Particle / Nest System With JavaScript and Canvas, no jQuery.

ZYSzys/awesome-captcha 493

:key: Curated list of awesome captcha libraries and crack tools.

ZYSzys/Mzitu_Spider 11

:truck:一只爬取mzitu.com美女图片的小爬虫,不说了赶紧上车~

ZYSzys/commodity-management-system 8

:convenience_store:简易商品管理系统(Commodity Management System)

ZYSzys/generator-nm-boilerplate 3

:clipboard: Boilerplate for scaffold out a node module.

ZYSzys/github-personal-stars 3

:star: Count your personal repos' total stars.

ZYSzys/cmd-trans 2

Translate something in the command line.

ZYSzys/NeteaseMusicAnalysis 2

网易云音乐数据分析[Deprecated]

ZYSzys/pre-work-todolist 1

A pre-work-todolist for internship. 👇前后端交互。👉纯前端[Deprecated]

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+205 -109

0 comment

20 changed files

pull[bot]

pr closed time in 2 days

push eventzys-contrib/node

Anna Henningsen

commit sha ff38165820da2a9eaddabbce23f3e75aa502900b

src: allow N-API addon in `AddLinkedBinding()` `AddLinkedBinding()` can be used to load old-style Node.js addons, but currently not N-API addons. There’s no good reason not to support N-API addons as well, so add that. PR-URL: https://github.com/nodejs/node/pull/35301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Anatoly Korniltsev

commit sha ff028016ffd1e5a157b8665c07356966c0ea9f2a

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER Pass SA_SIGINFO to sa_flags so the TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage PR-URL: https://github.com/nodejs/node/pull/35282 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Rich Trott

commit sha 325df03a6e29c1fd51294767235273e8a2ec3977

test,child_process: add tests for signalCode value Prior to this change, none of the child_process tests checked the signalCode property for a value other than null. Add a check to an existing test. PR-URL: https://github.com/nodejs/node/pull/35327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

NickNaso

commit sha d7dfa66baa4c3e8c69841455bb170479147889cf

doc: added version 7 to N-API version matrix Node.js version 14.12.0 released the N-API version 7, but it's not present on the N-API version matrix. This change should fix the problem in the documentation. PR-URL: https://github.com/nodejs/node/pull/35319 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Danielle Adams

commit sha b15ed6515323ec6cae2bde78feabf805c2fbb6b1

doc: add gpg key export directions to releases doc Adds an extra step with instructions for exporting a gpg key to be uploaded to the key server. PR-URL: https://github.com/nodejs/node/pull/35298 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 days

push eventzys-contrib/node

Guy Bedford

commit sha 226b186a9371cf9781c676e18f69bb241e4ab21b

doc: refine require/import conditions constraints PR-URL: https://github.com/nodejs/node/pull/35311 Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Shelley Vohr

commit sha aa99bb47bfbfc0fdf0d0ca4f452b527b02b83d2d

deps: upgrade to c-ares v1.16.1 PR-URL: https://github.com/nodejs/node/pull/35324 Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_1 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+20 -20

0 comment

3 changed files

pull[bot]

pr closed time in 4 days

push eventzys-contrib/node

Rich Trott

commit sha 163030eded94c010837e8cf62a618b5d973e0305

doc: revise dependency redirection text in policy.md PR-URL: https://github.com/nodejs/node/pull/35276 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 9687348577347cf41f10617a6b3b457825347cf2

doc: replace "this guide" link text with guide title PR-URL: https://github.com/nodejs/node/pull/35283 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Linn Dahlgren

commit sha e36ffb72bebae55091304da51837ca204367dc16

doc: change type of child_process.signalCode to string During testing, and interfacing with child_processes, I found that the child_process.signalCode property to be the string representation of the signal, not number. PR-URL: https://github.com/nodejs/node/pull/35223 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 4 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+795 -569

0 comment

46 changed files

pull[bot]

pr closed time in 6 days

push eventzys-contrib/node

Filip Skokan

commit sha fb88257b72bb6aba8f7c30cf78917299647697fe

doc: update crypto.createSecretKey accepted types PR-URL: https://github.com/nodejs/node/pull/35246 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Christoph Tavan

commit sha 219e9fe600339cf0b1773ef9e6d84bff94890402

module: fix crash on multiline named cjs imports The node process crashes when trying to parse a multiline import statement for named exports of a CommonJS module: TypeError: Cannot read property '0' of null at ModuleJob._instantiate (internal/modules/esm/module_job.js:112:77) at async ModuleJob.run (internal/modules/esm/module_job.js:137:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25), The reason is that the regexp that is currently used to decorate the original error fails for multi line import statements. Unfortunately the undecorated error stack only contains the single line which causes the import to fail: file:///***/node/test/fixtures/es-modules/package-cjs-named-error/multi-line.mjs:2 comeOn, ^^^^^^ SyntaxError: The requested module './fail.cjs' does not provide an export named 'comeOn' at ModuleJob._instantiate (internal/modules/esm/module_job.js:98:21) at async ModuleJob.run (internal/modules/esm/module_job.js:141:5) at async Loader.import (internal/modules/esm/loader.js:165:24) at async rejects.name (file:///***/node/test/es-module/test-esm-cjs-named-error.mjs:56:3) at async waitForActual (assert.js:721:5) at async rejects (assert.js:830:25) Hence, for multiline import statements we cannot create an equivalent piece of code that uses default import followed by an object destructuring assignment. In any case the node process should definitely not crash. So until we have a more sophisticated way of extracting the entire problematic multiline import statement, show the code example only for single-line imports where the current regexp approach works well. Refs: https://github.com/nodejs/node/issues/35259 PR-URL: https://github.com/nodejs/node/pull/35275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Antoine du Hamel

commit sha 0b8fdb70acc2fbd47c2c89755585e042baf9588a

tools,doc: upgrade dependencies PR-URL: https://github.com/nodejs/node/pull/35244 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Antoine du Hamel

commit sha 7794d36a372b7cb448f5a637765a8fe2e1431d95

tools,doc: enforce alphabetical order for md refs PR-URL: https://github.com/nodejs/node/pull/35244 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Ruy Adorno

commit sha 25d845656380d824a75a4f21c517d89fe3107896

2020-09-22, Version 14.12.0 (Current) Notable changes: - deps: - update to uvwasi 0.0.11 (Colin Ihrig) [#35104](https://github.com/nodejs/node/pull/35104) - n-api: - create N-API version 7 (Gabriel Schulhof) [#35199](https://github.com/nodejs/node/pull/35199) - add more property defaults (Gerhard Stoebich) [#35214](https://github.com/nodejs/node/pull/35214) PR-URL: https://github.com/nodejs/node/pull/35285

view details

Dan Fabulich

commit sha 3b10f7f933dee3607649b6bd1ca24876704222ac

process: change default --unhandled-rejections=throw This is a semver-major change that resolves DEP0018. All users that have set an unhandledRejection hook or set a non-default value for the --unhandled-rejections flag will see no change in behavior after this change. Refs: https://nodejs.org/dist/latest/docs/api/deprecations.html#deprecations_dep0018_unhandled_promise_rejections PR-URL: https://github.com/nodejs/node/pull/33021 Fixes: https://github.com/nodejs/node/issues/20392 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>

view details

push time in 6 days

push eventzys-contrib/node

Daijiro Wachi

commit sha a8971f87d3573ac247110e6afde0dc475fe21264

url: support non-special URLs Fixes: https://github.com/nodejs/node/issues/34899 Refs: https://github.com/whatwg/url/pull/505 Refs: https://github.com/web-platform-tests/wpt/pull/25113 PR-URL: https://github.com/nodejs/node/pull/34925 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 9 days

create barnchzys-contrib/react

branch : smoosh-mode

created branch time in 9 days

push eventzys-contrib/react

Andrew Clark

commit sha b93f3e7d2d595444c6ee2964d4cce2e17f4ffa28

Fix `act` bundle size regression (#19832) Adds back the `TestUtils.act` implementation that I had removed in #19745. This version of `act` is implemented in "userspace" (i.e. not the reconciler), so it doesn't add to the production bundle size. I had removed this in #19745 in favor of the `act` exported by the reconciler because I thought we would remove support for `act` in production in the impending major release. (It currently warns.) However, we've since decided to continue supporting `act` in prod for now, so that it doesn't block people from upgrading to v17. We'll drop support in a future major release. So, to avoid bloating the production bundle size, we need to move the public version of `act` back to "userspace", like it was before. This doesn't negate the main goal of #19745, though, which was to decouple the public version(s) of `act` from the internal one that we use to test React itself.

view details

Brian Vaughn

commit sha 16fb2b6f9e8fb17e2c468384e870cab635e4b1bb

Moved resetChildLanes into complete work (#19836) This allows us to inline a few checks that are specific to a certain tag-type.

view details

Adnaan Bheda

commit sha 36df9185c53ce4e90dc1f7362f74533ecf0607db

chore(docs): Removed outdated comment about fb.me link (#19830)

view details

Dan Abramov

commit sha 6fddca27e75950adda92ab4f4946442907dc3bb7

Remove passive intervention flag (#19849)

view details

Brian Vaughn

commit sha 26857ecfa924c05119773dae7e59577e730f8faf

Revert "DevTools: Improve browser extension iframe support (#19827)" (#19852) This reverts commit ec39a5e9017dfa2c3311bc2b74a4d535ea2630a2.

view details

Johnny Pribyl

commit sha b3b1bb9ce282c107fe898e53ef70485c530d8f3c

Enable source maps for DevTools production builds (#19773) Co-authored-by: Brian Vaughn <bvaughn@fb.com>

view details

Brian Vaughn

commit sha 50d9451f320a9aaf94304209193562cc385567d8

Improve DevTools editing interface (#19774) * Improve DevTools editing interface This commit adds the ability to rename or delete keys in the props/state/hooks/context editor and adds tests to cover this functionality. DevTools will degrade gracefully for older versions of React that do not inject the new reconciler rename* or delete* methods. Specifically, this commit includes the following changes: * Adds unit tests (for modern and legacy renderers) to cover overriding props, renaming keys, and deleting keys. * Refactor backend override methods to reduce redundant Bridge/Agent listeners and methods. * Inject new (DEV-only) methods from reconciler into DevTools to rename and delete paths. * Refactor 'inspected element' UI components to improve readability. * Improve auto-size input to better mimic Chrome's Style editor panel. (See this Code Sandbox for a proof of concept.) It also contains the following code cleanup: * Additional unit tests have been added for modifying values as well as renaming or deleting paths. * Four new DEV-only methods have been added to the reconciler to be injected into the DevTools hook: overrideHookStateDeletePath, overrideHookStateRenamePath, overridePropsDeletePath, and overridePropsRenamePath. (DevTools will degrade gracefully for older renderers without these methods.) * I also took this as an opportunity to refactor some of the existing code in a few places: * Rather than the backend implementing separate methods for editing props, state, hooks, and context– there are now three methods: deletePath, renamePath, and overrideValueAtPath that accept a type argument to differentiate between props, state, context, or hooks. * The various UI components for the DevTools frontend have been refactored to remove some unnecessary repetition. This commit also adds temporary support for override* commands with mismatched backend/frontend versions: * Add message forwarding for older backend methods (overrideContext, overrideHookState, overrideProps, and overrideState) to the new overrideValueAtPath method. This was done in both the frontend Bridge (for newer frontends passing messages to older embedded backends) and in the backend Agent (for older frontends passing messages to newer backends). We do this because React Native embeds the React DevTools backend, but cannot control which version of the frontend users use. * Additional unit tests have been added as well to cover the older frontend to newer backend case. Our DevTools test infra does not make it easy to write tests for the other way around.

view details

Andrew Clark

commit sha 8b2d3783e58d1acea53428a10d2035a8399060fe

Use Passive flag to schedule onPostCommit (#19862) Instead of calling `onPostCommit` in a separate phase, we can fire them during the same traversal as the rest of the passive effects. This works because effects are executed depth-first. So by the time we reach a Profiler node, we'll have already executed all the effects in its subtree.

view details

push time in 9 days

PR merged zys-contrib/react

[pull] master from facebook:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+5186 -1693

0 comment

107 changed files

pull[bot]

pr closed time in 9 days

push eventzys-contrib/node

zhangyongsheng

commit sha 2593cc8abbfe4ae6a4f90698764b20d51b0d4343

fix: cleanup!

view details

push time in 9 days

create barnchzys-contrib/node

branch : esm-opt

created branch time in 10 days

create barnchZYSzys/fastmac

branch : master

created branch time in 10 days

created repositoryZYSzys/fastmac

created time in 10 days

startedumijs/umi

started time in 10 days

startedeslint/espree

started time in 10 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+4 -4

0 comment

3 changed files

pull[bot]

pr closed time in 12 days

push eventzys-contrib/node

Tom Atkinson

commit sha d4aac8399247ceb57cc517cb51ccdb24696ab4b5

doc: fix missing word in dgram.md The word "cannot" is missing from this sentence PR-URL: https://github.com/nodejs/node/pull/35231 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

Beth Griggs

commit sha 524123fbf064ff64bb6fcd83485cfc27db932f68

doc: update releaser in v12.18.4 changelog PR-URL: https://github.com/nodejs/node/pull/35217 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Rich Trott

commit sha 18462e0c1d5f3b3a3e86b7b40fb65975f1e27381

doc: replace "you should do X" with "do X" PR-URL: https://github.com/nodejs/node/pull/35194 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 12 days

push eventzys-contrib/node

Shelley Vohr

commit sha 06212bda66fc66a5609244c8e5ed4431765be5fe

doc: add missing copyFile change history PR-URL: https://github.com/nodejs/node/pull/35056 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha fb1ab198945d9ed8a9572d7838862ba9b9b106de

doc: fix broken links in modules.md PR-URL: https://github.com/nodejs/node/pull/35182 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

schamberg97

commit sha 571dff81d5481efc30a6b8fd495611b5c2674037

doc: update process.release `process.release` documentation is out of date. This commit makes it up to date. PR-URL: https://github.com/nodejs/node/pull/35167 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 6eb15ce8a3bebeda605b88972ae007bafb3a1133

doc: update eventLoopUtilization documentation PR-URL: https://github.com/nodejs/node/pull/35155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 2b3eb101b57ff99cb1e3917dfe6f3064a37ea220

tools: update ESLint to 7.9.0 Update ESLint to 7.9.0 PR-URL: https://github.com/nodejs/node/pull/35170 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 26e660f9627f776678106d0afa7da428c44c45cf

doc: remove problematic auto-linking of curl man pages The only instance of curl man page linking is in repl.md and it is explicit. The magic autolinking in html.js creates a superfluous empty link. Remove it. Before, two adjacent links generated, with the first one having no text: ```html <a href="https://curl.haxx.se/docs/manpage.html"></a> <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` After, just one link: ```html <a href="https://curl.haxx.se/docs/manpage.html"><code>curl(1)</code></a> ``` PR-URL: https://github.com/nodejs/node/pull/35174 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha ae257ca0008cd6d01d477d927fa9962d8f406c5f

test: improve pummel/test-timers.js * use Date.now() instead of new Date() because only the timestamp is ever used, so we don't need the full Date object * use separate start times recorded for the two different test cases * improve assertion messages PR-URL: https://github.com/nodejs/node/pull/35175 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

view details

Fedor Indutny

commit sha cb90248c145763502ee8fae67960d45293c9e0bf

deps: update llhttp to 2.1.2 - update llhttp to 2.1.2 - modify test to support the latest llhttp PR-URL: https://github.com/nodejs-private/node-private/pull/215 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Matteo Collina

commit sha df08d527c2083b852d8456b88b39114f30525236

http: add requestTimeout This commits introduces a new http.Server option called requestTimeout with a default value in milliseconds of 0. If requestTimeout is set to a positive value, the server will start a new timer set to expire in requestTimeout milliseconds when a new connection is established. The timer is also set again if new requests after the first are received on the socket (this handles pipelining and keep-alive cases). The timer is cancelled when: 1. the request body is completely received by the server. 2. the response is completed. This handles the case where the application responds to the client without consuming the request body. 3. the connection is upgraded, like in the WebSocket case. If the timer expires, then the server responds with status code 408 and closes the connection. CVE-2020-8251 PR-URL: https://github.com/nodejs-private/node-private/pull/208 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Co-Authored-By: Paolo Insogna <paolo@cowtech.it> Co-Authored-By: Robert Nagy <ronagy@icloud.com>

view details

Beth Griggs

commit sha 3bdac31c4b177e13a895a8541b35fa046a557174

2020-09-15, Version 10.22.1 'Dubnium' (LTS) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8252: fs.realpath.native on may cause buffer overflow (Medium). PR-URL: https://github.com/nodejs-private/node-private/pull/222

view details

Michaël Zasso

commit sha 9ab5c6b96ceef1ac53729e243d5f8de8641d05ae

2020-09-15, Version 12.18.4 'Erbium' (LTS) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8201: HTTP Request Smuggling due to CR-to-Hyphen conversion (High). - CVE-2020-8252: fs.realpath.native on may cause buffer overflow (Medium). PR-URL: https://github.com/nodejs-private/node-private/pull/223

view details

Richard Lau

commit sha 8e173836538efb95f5ac5e898f177efff681d2aa

2020-09-15, Version 14.11.0 (Current) This is a security release. Notable changes: Vulnerabilities fixed: - CVE-2020-8251: Denial of Service by resource exhaustion CWE-400 due to unfinished HTTP/1.1 requests (Critical). - CVE-2020-8201: HTTP Request Smuggling due to CR-to-Hyphen conversion (High). PR-URL: https://github.com/nodejs-private/node-private/pull/225

view details

Antoine du HAMEL

commit sha d24eecd7d73959872058ea5cee5cd83a9825fa13

module: use isURLInstance instead of instanceof PR-URL: https://github.com/nodejs/node/pull/34951 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Gus Caplan

commit sha 05771279affce857e9b4d684f9afe77606b30f35

src: enable wasm trap handler on windows PR-URL: https://github.com/nodejs/node/pull/35033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Jordan Harband

commit sha 9cf9e4aebccd3dc946d1ccb8d3f00b31d3e6371c

fs: loosen validation to allow objects with an own toString function PR-URL: https://github.com/nodejs/node/pull/34993 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Michaël Zasso

commit sha eb9d7a437e960753a7344d7e7885e6e3df4370aa

test: update WPT harness and tests PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Michaël Zasso

commit sha 4831278a16d0cbe9e54ba89f1bf4f114aed06e69

url: remove U+0000 case in the fragment state Port of https://github.com/whatwg/url/pull/486 PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Michaël Zasso

commit sha 69ef4c2375b5110886b08957cd2305ce8aa8eb32

url: verify domain is not empty after "ToASCII" Port of https://github.com/whatwg/url/pull/497 PR-URL: https://github.com/nodejs/node/pull/33770 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Rich Trott

commit sha 3aab64cd5f60ff2cfb6e902846df21942c910884

doc: fix broken link in crypto.md URL that lacks a scheme gets treated as a relative URL. Add missing `https://`. PR-URL: https://github.com/nodejs/node/pull/35181 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Antoine du HAMEL

commit sha dfa2dada07ce5804d392f6ed0f8ff1503e530ce1

doc: fix deprecation documentation inconsistencies PR-URL: https://github.com/nodejs/node/pull/35082 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 12 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+17590 -2161

0 comment

185 changed files

pull[bot]

pr closed time in 12 days

startedalibaba/pipcook

started time in 14 days

startedfastai/fastmac

started time in 14 days

push eventzys-contrib/react

Andrew Clark

commit sha 1f38dcff67d12828be771403e183652f5e93909a

Remove withSuspenseConfig (#19724) Removes `withSuspenseConfig` and migrates relevant tests to `startTransition` instead. We only had one caller in www, which I've removed.

view details

Kevin Weber

commit sha b7d18c4daf244b991858cc9b0706b64589f4fd60

Support Babel's envName option in React Refresh plugin (#19009) * Fix envName bug * Replace getEnv with env

view details

Bhumij Gupta

commit sha 53e622ca7f643cc9d18c9c4896b68ab14549e292

Fix instances of function declaration after return (#19733) * Add ESLint plugin to check for any function declare after return * Refactor code to move function declarations before return and fix failing lint

view details

Brian Vaughn

commit sha 98dba66ee1e5fcf3b88a0fe0331c8d84e9ddfbed

Add ⎇ + arrow key navigation to DevTools (#19741) ⎇ + left/right navigates between owners (similar to owners tree) and ⎇ + up/down navigations between siblings.

view details

Ikko Ashimine

commit sha 2cfd73c4d02cfe4c745a1862ef4a9c44e8a41da4

Fix typo in comment (Noticable→Noticeable) (#19737)

view details

Brian Vaughn

commit sha 99cae887f3a8bde760a111516d254c1225242edf

Add failing test for passive effect cleanup functions and memoized components (#19750) * Add failing tests for passive effects cleanup not being called for memoized components * Bubble passive static subtreeTag even after bailout This prevents subsequent unmounts from skipping over any pending passive effect destroy functions

view details

Meghnath Pillay

commit sha 835c11eba713ea836af6dae67b4d0e835c0eabdf

Add checkbox toggle for boolean values (#19714) * added a checkbox which appears to the right of a value when value is boolean * checkbox with toggle capability created for boolean props Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>

view details

E-Liang Tan

commit sha 93400833956d4aa5b3136fb5883142a70a4f54e6

Scheduling Profiler: Add Fast Refresh (#19757)

view details

E-Liang Tan

commit sha e9454894ff1715d6d51558fb05c1344440901069

Scheduling Profiler: Extract and test scroll state from horizontal pan and zoom view (#19682) * Extract reusable scroll logic from HorizontalPanAndZoomView * Change VerticalScrollView to use scrollState * Clarify test name

view details

Dan Abramov

commit sha bcc0aa4633760352c6c56f559d1e2d374d302f5a

Revert "Revert "Remove onScroll bubbling flag (#19535)" (#19655)" (#19761) This reverts commit 64ddef44c69a18038b1683e04c4558a72af1b91a.

view details

E-Liang Tan

commit sha 38a512acade57578738e2c5ebbb0709cd56a9bbd

Scheduling Profiler: Redesign with DevTools styling (#19707) Co-authored-by: Brian Vaughn <bvaughn@fb.com>

view details

E-Liang Tan

commit sha eabd18c73f0df5e38431e47b0549566a6f41e15f

Scheduling Profiler: Move preprocessing to web worker and add loading indicator (#19759) * Move preprocessData into a web worker * Add UI feedback for loading/import error states * Terminate worker when done handling profile * Add display density CSS variables

view details

Ricky

commit sha 36df483af4a626fd4021c060fcb0f62471e82af1

Add feature flag to disable scheduler timeout in work loop (#19771)

view details

Andrew Clark

commit sha 708fa77a783bbe729cfcebdd513d23eafc455b8b

Decrease expiration time of input updates (#19772) Changes the expiration time of input updates from 1000ms to 250ms, to match the corresponding constant in Scheduler.js. When we made it larger, a product metric in www regressed, suggesting there's a user interaction that's being starved by a series of synchronous updates. If that theory is correct, the proper solution is to fix the starvation. However, this scenario supports the idea that expiration times are an important safeguard when starvation does happen. Also note that, in the case of user input specifically, this will soon no longer be an issue because we plan to make user input synchronous by default (until you enter `startTransition`, of course.) If weren't planning to make these updates synchronous soon anyway, I would probably make this number a configurable parameter.

view details

Andrew Clark

commit sha 16654436039dd8f16a63928e71081c7745872e8f

Rename effect fields (#19755) - `effectTag` -> `flags` - `subtreeTag` -> `subtreeFlags`

view details

Andrew Clark

commit sha 7baf9d4128d41903de125527b50285ea9862cf9a

Combine Flags and SubtreeFlags types (#19775) Because the `subtreeFlags` is the union of all the flags present in a subtree, we can use the same type as `flags`. One practical benefit is that we can bubble up the flags from the children with a single `|=` operator. Structurally, everything else about the effect algorithm is unchanged.

view details

Andrew Clark

commit sha 4f3f7eeb7f467be7a8c5e7c2cdf64cb95a6099c3

Bugfix: Effect clean up when deleting suspended tree (#19752) * Bug: Effect clean up when deleting suspended tree Adds a failing unit test. * Re-use static flags from suspended primary tree When switching to a Suspense boundary's fallback, we need to be sure to preserve static subtree flags from the primary tree.

view details

Joseph Savona

commit sha d38ec17b1d6ab75715c4ec06f2793c2986dcd549

[Flight] Set dispatcher for duration of performWork() (#19776)

view details

Andrew Clark

commit sha d17086c7c813402a550d15a2f56dc43f1dbd1735

Decouple public, internal act implementation (#19745) In the next major release, we intend to drop support for using the `act` testing helper in production. (It already fires a warning.) The rationale is that, in order for `act` to work, you must either mock the testing environment or add extra logic at runtime. Mocking the testing environment isn't ideal because it requires extra set up for the user. Extra logic at runtime is fine only in development mode — we don't want to slow down the production builds. Since most people only run their tests in development mode, dropping support for production should be fine; if there's demand, we can add it back later using a special testing build that is identical to the production build except for the additional testing logic. One blocker for removing production support is that we currently use `act` to test React itself. We must test React in both development and production modes. So, the solution is to fork `act` into separate public and internal implementations: - *public implementation of `act`* – exposed to users, only works in development mode, uses special runtime logic, does not support partial rendering - *internal implementation of `act`* – private, works in both development and productionm modes, only used by the React Core test suite, uses no special runtime logic, supports partial rendering (i.e. `toFlushAndYieldThrough`) The internal implementation should mostly match the public implementation's behavior, but since it's a private API, it doesn't have to match exactly. It works by mocking the test environment: it uses a mock build of Scheduler to flush rendering tasks, and Jest's mock timers to flush Suspense placeholders. --- In this first commit, I've added the internal forks of `act` and migrated our tests to use them. The public `act` implementation is unaffected for now; I will leave refactoring/clean-up for a later step.

view details

Andrew Clark

commit sha e7b255341b059b4e2a109847395d0d0ba2633999

Internal `act`: Flush timers at end of scope (#19788) If there are any suspended fallbacks at the end of the `act` scope, force them to display by running the pending timers (i.e. `setTimeout`). The public implementation of `act` achieves the same behavior with an extra check in the work loop (`shouldForceFlushFallbacks`). Since our internal `act` needs to work in both development and production, without additional runtime checks, we instead rely on Jest's mock timers. This doesn't not affect refresh transitions, which are meant to delay indefinitely, because in that case we exit the work loop without posting a timer.

view details

push time in 15 days

PR merged zys-contrib/react

[pull] master from facebook:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+3829 -1861

0 comment

154 changed files

pull[bot]

pr closed time in 15 days

push eventzys-contrib/node

Tobias Nießen

commit sha cb2b82bddc1dd8d434847388c460d507433aeae2

crypto: fix randomInt range check Refs: https://github.com/nodejs/node/pull/34600 PR-URL: https://github.com/nodejs/node/pull/35052 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Rich Trott

commit sha ac6ba6b625c5a60754e7e1ee187dbbec070d45d4

crypto: simplify KeyObject constructor Inline a function that only gets called in the constructor. Make call to `super()` more straightforward in the process by removing conditional involving the function as it only ever returns `undefined` or else throws. That made the code a little hard to understand, as without looking at the function, one would likely expect it to return `true` on success rather than `undefined`. PR-URL: https://github.com/nodejs/node/pull/35064 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha c4b3b2341383369ccbd0fa68e51266f580e9a5fd

doc: use present tense in events.md Present tense should be default choice. It is usually easier to read and understand. Refs: https://docs.microsoft.com/en-us/style-guide/grammar/verbs PR-URL: https://github.com/nodejs/node/pull/35068 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Rich Trott

commit sha e56da0625a82880f6329df4d5ef8849ff018956a

doc: use correct Error type for EventEmitter.defaultMaxListener If a bad value is assigned to EventEmitter.defaultMaxListener, a RangeError is thrown and not a TypeError. Update documentation to reflect this. PR-URL: https://github.com/nodejs/node/pull/35069 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha e06037abc4e319d30604000f430e94e6ae5393c1

test: add more valid results to test-trace-atomics-wait The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: https://github.com/nodejs/node/issues/35059 PR-URL: https://github.com/nodejs/node/pull/35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha e0d3b758a016bd926e890e5acc71d321faf9bc09

stream: improve Writable.destroy performance Avoid nextTick if there are no pending callbacks. PR-URL: https://github.com/nodejs/node/pull/35067 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Rich Trott

commit sha 6f2af082459e8a07a11fd1aed7aa19988434323a

Revert "build: require "allow edits" to be checked" This reverts commit 07423b5472c27d86b4b8047d150d75756ad01f3c. Refs: https://github.com/nodejs/node/pull/35002#issuecomment-688363345 PR-URL: https://github.com/nodejs/node/pull/35094 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Leko

commit sha 7913ac569419668c8727295ee787169a6a662362

test: separate the test fixtures between ICU and URL We need to emit dependency of ICU's toASCII in order to update the WPT fixtures. Since ICU and URL isn't the same implementation and they also follow different specifications. ICU's toASCII shouldn't have a dependency on WPT fixtures. Refs: https://github.com/nodejs/node/pull/33770#issuecomment-680853608 PR-URL: https://github.com/nodejs/node/pull/35077 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Rich Trott

commit sha ccdd1bd82acf8d2c92ae08dcfad327f5adb030ac

doc: fix incorrectly marked Buffer in quic.md Angle brackets are being used where curly brackets are intended. PR-URL: https://github.com/nodejs/node/pull/35075 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Richard Lau

commit sha b5a47ca2d1f3b8e885164c5f1a6b3db0cdffa1c2

2020-09-08, Version 14.10.0 (Current) Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) https://github.com/nodejs/node/pull/34960 - crypto: add randomInt function (Oli Lalonde) https://github.com/nodejs/node/pull/34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) https://github.com/nodejs/node/pull/34938 - stream: simpler and faster Readable async iterator (Robert Nagy) https://github.com/nodejs/node/pull/34035 - stream: save error in state (Robert Nagy) https://github.com/nodejs/node/pull/34103 PR-URL: https://github.com/nodejs/node/pull/35023 Conflicts: src/node_version.h

view details

Rich Trott

commit sha 665330134cafb6d40e39d134f3bef03b09fbd9ae

doc: make minor improvements to module.md * sort references in ASCII order * replace abbreviation * split comma splice into two sentences and add appropriate punctuation * replace future tense with present tense PR-URL: https://github.com/nodejs/node/pull/35083 Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

Tobias Nießen

commit sha 1204400d6411694d08bde0c3c197c9a72b72f570

test: fix comment about DNS lookup test PR-URL: https://github.com/nodejs/node/pull/35080 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha d7d0fab70e45f2866dd6db0a489540cbbf434b97

crypto: improve randomInt out-of-range error message Previously, the crypto.randomInt() message when "max" was less than or equal to "min" made it sound like the lower bound for "max" was hard-coded. Make it clear that it is instead dynamic based on the value of "min". For crypto.randomInt(10,0): Before: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be > 10. Received 0 After: RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It must be greater than the value of "min" (10). Received 0 PR-URL: https://github.com/nodejs/node/pull/35088 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Rich Trott

commit sha 40633351bc64a093a7e0a88b7e65a4c9e4a091f6

crypto: improve invalid arg type message for randomInt() Use "must be a safe integer" rather than "must be safe integer". I believe the former is more easily understood/clear. PR-URL: https://github.com/nodejs/node/pull/35089 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Tobias Nießen

commit sha f07f4207522075fb5b3062afac24a19ecbb83825

test: remove setMaxListeners in test-crypto-random This appears to be a remnant from 413d38c43bc3fa6828e10c75736f81c3d6b7e944. PR-URL: https://github.com/nodejs/node/pull/35079 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 4c9b79ed5a776b6e1b99703ec9976312ae9b5fae

doc: avoid double-while sentence in perf_hooks.md This improves readability, as well as awkward reptition of the word _while_ with two different meanings in a single sentence. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while PR-URL: https://github.com/nodejs/node/pull/35078 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Rich Trott

commit sha 661b770e11cd6d7decfb3232037ff1ba00efdbe4

doc: restore color for visited links A previous change altered the rendering of visited links. This restores it. PR-URL: https://github.com/nodejs/node/pull/35108 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Tobias Nießen

commit sha a03e15f571dc54455896489589504df7ce45a0c8

doc: add note about path.basename on Windows PR-URL: https://github.com/nodejs/node/pull/35065 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 7fc1a4a893e080d0e55d7af9638938d00889dc24

test: revise test-policy-integrity * eliminate unneeded Set deletion/cleanup * use number of CPUs as limit for processes spawned rather than hard-coding the limit PR-URL: https://github.com/nodejs/node/pull/35101 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Richard Lau

commit sha b7f3e8308661c3e370b4ebb863109655653d106f

2020-09-10, Version 14.10.1 (Current) Notable changes: Node.js 14.10.0 included a streams regression with async generators and a docs rendering regression that are being fixed in this release. PR-URL: https://github.com/nodejs/node/pull/35137

view details

push time in 16 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1202 -700

0 comment

110 changed files

pull[bot]

pr closed time in 16 days

startedkentcdodds/babel-plugin-macros

started time in 16 days

starteddavidtheclark/cosmiconfig

started time in 16 days

PullRequestReviewEvent

push eventzys-contrib/node

Shelley Vohr

commit sha 3268a9fcaa97c4b378188ebbb280bf02f796a226

test: make .out checks embedder-friendly PR-URL: https://github.com/nodejs/node/pull/35040 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Milad Farazmand

commit sha b460c5c5240f5c1cb34fea6eea088e882a2dd802

deps: V8: backport 3f071e3e7e15 Original commit message: PPC: Optimize clearing higher bits of mulhw/mulhwu Change-Id: Ie3e14a6ef4531349e81a8ae741bc7470c7e547ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2349468 Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69343} Refs: https://github.com/v8/v8/commit/3f071e3e7e15af187267af6c3b369029e27c8cf5 PR-URL: https://github.com/nodejs/node/pull/35036 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Antoine du HAMEL

commit sha ec5958f38e27f1005fe77719f180d48363677b27

doc: remove style for empty links PR-URL: https://github.com/nodejs/node/pull/35034 Refs: https://github.com/nodejs/node/pull/34955 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Anna Henningsen

commit sha e326c41fbc3ac6533630704bf438db860731dcc6

src: shutdown libuv before exit() This ensures that no operations will be running on the libuv threadpool, which is important because they may run into race conditions with the global destructors being triggered from `exit()`, such as in the added test example here. PR-URL: https://github.com/nodejs/node/pull/35021 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 226eabb1aa4b178c32c002b641bef3688c4097ba

doc: fix incorrect URL in cli.md Remove incorrect second `#` in URl. PR-URL: https://github.com/nodejs/node/pull/35043 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Rich Trott

commit sha 53f7d3ee2c598e7ce18f5026102cd1658b435957

crypto: align parameter names with documentation Change _cb_ to _callback_ to align with documentation. This is so that stack traces and error messages align with the documentation. If the documentation says "callback", then the stack traces and error messages should indicate that "callback" needs to be function or whatever, rather than "cb". PR-URL: https://github.com/nodejs/node/pull/35054 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Rich Trott

commit sha 2b2208e01a9ddb09276484e10cf4065a1f9a61a1

doc: update syntax highlighting color for accessibility Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: https://github.com/nodejs/node/pull/35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Antoine du HAMEL

commit sha 8ae2f479549be295250867d20cfe17ceb68f72c4

tools: fix doc build targets Adds doc output directory as order-only prerequisite for build target. PR-URL: https://github.com/nodejs/node/pull/35060 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Derek Lewis

commit sha ff0aad0f747470d33d85fba4deb795a79c55c1a6

doc: spruce up user journey to local docs browsing This patch improves the means by which the docs are viewed locally. * Remove extraneous code in the `docserve` Makefile target * Document the `docserve` task for all to know * Bring all code snippets in this section up to speed * Clarify the purpose of each documentation browsing method Fixes: https://github.com/nodejs/node/issues/34977 PR-URL: https://github.com/nodejs/node/pull/34986 Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Antoine du HAMEL

commit sha 441c03de50069d0c9662c87a3ecfd43837d39cae

tools: fix docopen target Adds to prerequisites the output file to open. Previously, this would open an out-of-date version of the file, or fail if it hasn't been built before. PR-URL: https://github.com/nodejs/node/pull/35062 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

Antoine du HAMEL

commit sha 181ba95819565f8f76acffe538d3f06a50499d05

doc: add deprecated badge to legacy URL methods PR-URL: https://github.com/nodejs/node/pull/34931 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

Antoine du HAMEL

commit sha b0cc6572b0d6d3f302af5bb4aa3f098c9d8003c8

doc: add ESM examples in `module` API doc page PR-URL: https://github.com/nodejs/node/pull/34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

Benjamin Coe

commit sha 6d9a3162bfa6c119c5eb1dd2422fe65bef025685

deps: V8: cherry-pick 6be2f6e26e8d Original commit message: [coverage] IncBlockCounter should not be side-effect Incrementing coverage counter was triggering EvalError for evaluateOnCallFrame when throwOnSideEffect is true. R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org Bug: v8:10856 Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#69628} Refs: https://github.com/v8/v8/commit/6be2f6e26e8ddfbc1a48c510672b319809674a34 PR-URL: https://github.com/nodejs/node/pull/35055 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Tobias Nießen

commit sha 699fae1f2cb6d460cf85dca712dd936194b27ce1

doc: format exponents better The `2^n` notation is common in mathematics, but even then it often requires parentheses or braces. In JavaScript and C++, the `^` operator stands for bitwise xor, and should be avoided in the docs. In code tags, the JavaScript operator `**` can be used. Otherwise, the `sup` tag can be used for formatting. PR-URL: https://github.com/nodejs/node/pull/35050 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tobias Nießen

commit sha cc60347f02514d69b9d52886f6fcaa3c9820c7b4

doc: add link to safe integer definition Refs: https://github.com/nodejs/node/pull/34600 Co-authored-by: Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35049 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Guy Bedford

commit sha 04865cf6f060c917cce8dbffd38c3f44db1e16f3

bootstrap: correct --frozen-intrinsics override fix PR-URL: https://github.com/nodejs/node/pull/35041 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha bb9117ee9f8fb42ac8efd1dab30b3faee5463587

doc: change stablility-2 color for accessibility Current contrast ratio (2.51) does not pass WCAG AA. This PR increases the contrast to 4.50, which passes WCAG AA. The color, of course, is still green. PR-URL: https://github.com/nodejs/node/pull/35061 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

push time in 21 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+200 -81

0 comment

28 changed files

pull[bot]

pr closed time in 21 days

startedstreamich/memfs

started time in 22 days

PullRequestReviewEvent

startedTypeStrong/ts-loader

started time in 24 days

startedsindresorhus/np

started time in 24 days

push eventzys-contrib/node

Rich Trott

commit sha 4f7440cd88dd6e6fb08945f85fc72eec9156f5fa

test: remove incorrect debug() in test-policy-integrity The instructions to use `test:policy-integrity:NUMBER` do not work, I'm afraid. This removes them. PR-URL: https://github.com/nodejs/node/pull/34961 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Turner Jabbour

commit sha b90fff42afce756e870dd8461d024e5a019a08a2

doc: change effected to affected PR-URL: https://github.com/nodejs/node/pull/34989 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 42a793eba323e55bc4ed581e298e809ef0a0a909

buffer: also alias BigUInt methods These were overlooked in 5864fca7bc96b because of the extra `Big` in the name. :) Refs: https://github.com/nodejs/node/pull/34729 PR-URL: https://github.com/nodejs/node/pull/34960 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

James M Snell

commit sha df1023bb224d7ac79315308e2b9b18f3b3b01d39

events: allow use of AbortController with on Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34912 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha cc9ac42111c3a9aed4b191f8d6d56929d7b50519

doc,tools: remove malfunctioning Linux manpage linker The Linux manpage auto-linking is resulting in extraneous links with empty text in the docs. Remove it as the only thing it affects is linked explicitly in the one document that uses it. PR-URL: https://github.com/nodejs/node/pull/34985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Phillip Johnsen

commit sha d89cc98e4775869bc2d3a537f1d0a40e9f8d82ce

build: close stalled issues and PRs with github action This introduces a GitHub Action workflow to close issues and PRs which has been labelled `stalled` 30 days ago (or more). `stale` labelling and unlabelling of issues and PRs are still done manually by collaborators. Refs https://github.com/nodejs/github-bot/issues/261 PR-URL: https://github.com/nodejs/node/pull/34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Phillip Johnsen

commit sha b23a932bfd22cc58829dd86fb9ac8e5da7caec98

build: comment about auto close when stalled via with github action As part of automatically closing issues and PRs 30 days after they got labelled with `stalled`, these changes adds a GitHub Action workflow posting a comment information about what will happen in 30 days upon being labelled. PR-URL: https://github.com/nodejs/node/pull/34555 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Antoine du Hamel

commit sha 79ea22a531c8446710b43df5f6eeb0497719f302

tools,doc: fix global table of content active element Assign active class to the correct HTML element when one nav-id is a subset of another one (E.G.: `nav-module` and `nav-modules`). Fixes: https://github.com/nodejs/node/issues/34975 PR-URL: https://github.com/nodejs/node/pull/34976 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Rich Trott

commit sha 449f73e05fdb17b76a11f6e122cadf80fdbdf9ba

quic: remove undefined variable The `reason` variable never gets defined. It's use in a template string will always end up as the string `'undefined'`. PR-URL: https://github.com/nodejs/node/pull/35007 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 69b8a394237aeffc4af951ce099e98ef6a2e4dd2

doc: revise commit-queue.md Make minor fixes to the text. PR-URL: https://github.com/nodejs/node/pull/35006 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha f9c362ff6c4fad4cf67df5a94ba5fdb9321a3d2b

doc: revise AbortSignal text and example using events.once() Add a line to the example code to clarify what happens if an event is emitted after listening is canceled. Make minor revisions to surrounding text. PR-URL: https://github.com/nodejs/node/pull/35005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha cc754f2985c2c9afc9fdb185e15974644e459860

doc: make AbortSignal text consistent in events.md Further minor modifications to AbortSignal text in events.md for consistency. PR-URL: https://github.com/nodejs/node/pull/35005 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 85b424e56612288a1e2e63b6a418b52dbbcbcdde

doc: use period consistently in man page PR-URL: https://github.com/nodejs/node/pull/34939 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

Antoine du HAMEL

commit sha d2c5e891658cc2601dceff1ca0bc9812fe88e61f

tools,doc: allow page titles to contain inline code Previously the HTML title would be cut to the first text node only. PR-URL: https://github.com/nodejs/node/pull/35003 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

view details

cjihrig

commit sha 385ae17b4d4a976aae8283398f58ec9811909117

tools: update ESLint to 7.8.0 Update ESLint to 7.8.0 PR-URL: https://github.com/nodejs/node/pull/35004 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

cjihrig

commit sha d0ee7d66bcd4c59baa2d87043688c08074586bb4

tools: update ESLint to 7.8.1 Update ESLint to 7.8.1 PR-URL: https://github.com/nodejs/node/pull/35004 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Guy Bedford

commit sha ef4e3b5f69450fc18eea6bdfbf8b2b9d4286e55c

doc: error code fix in resolver spec PR-URL: https://github.com/nodejs/node/pull/34998 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Rich Trott

commit sha e5116b304f67e4989a8ff87fd558eca6363947a5

quic: remove unused function arguments validateTransportParams() only takes (and only uses) one argument. PR-URL: https://github.com/nodejs/node/pull/35010 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Jordan Harband

commit sha 07423b5472c27d86b4b8047d150d75756ad01f3c

build: require "allow edits" to be checked PR-URL: https://github.com/nodejs/node/pull/35002 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Daijiro Wachi

commit sha 3b925219c341062a9fc648049e217fea79f0ea3d

querystring: manage percent character at unescape Related: https://github.com/nodejs/node/issues/33892 Fixes: https://github.com/nodejs/node/issues/35012 PR-URL: https://github.com/nodejs/node/pull/35013 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 25 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+5880 -469

0 comment

110 changed files

pull[bot]

pr closed time in 25 days

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+21 -8

0 comment

4 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Igor Mikhalev

commit sha 33eda8046e59b672dbdc57183446bfa922f96ce5

doc: add a note about possible missing lines to readline.asyncIterator Fixes: https://github.com/nodejs/node/issues/33463 PR-URL: https://github.com/nodejs/node/pull/34675 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 4fa439c5feafd31b26e083ce9f6642faf51c981e

test: make test-tls-reuse-host-from-socket pass without internet Start up a TLS server on localhost rather than using example.org. PR-URL: https://github.com/nodejs/node/pull/34953 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 5c020762bb5b2b33a11b816c7fba12cce0df2e65

test: add readline test for escape sequence Tests do not cover a small piece of code in lib/internal/readline/utils.js for consuming an escape sequence. This adds a minimal test to cover the code. Refs: https://coverage.nodejs.org/coverage-0848f56cb3943209/lib/internal/readline/utils.js.html#L327 PR-URL: https://github.com/nodejs/node/pull/34952 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Daijiro Wachi

commit sha a1faa8d8521886c6a444ed2c6ba8cd735448bb8c

test: fix typo in test/parallel/test-icu-punycode.js coverter => converter PR-URL: https://github.com/nodejs/node/pull/34934 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

push time in a month

starteduuidjs/uuid

started time in a month

startedjgraph/drawio

started time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+14 -14

0 comment

5 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Rich Trott

commit sha f461a66822a807d7f6c5eb7300fd69638beee1f8

doc: make minor fixes to maintaining-openssl.md PR-URL: https://github.com/nodejs/node/pull/34926 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

Rich Trott

commit sha e985fcebda33081750acd92aadccd7750a7c78c2

doc: simplify "make use of" to "use" PR-URL: https://github.com/nodejs/node/pull/34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 496c174d14bc4b95b82ab84264df27739ddc32fe

doc,quic: simplify "make use of" to "use" in quic.md PR-URL: https://github.com/nodejs/node/pull/34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

push time in a month

startedgetsentry/sentry-javascript

started time in a month

startedai/nanoid

started time in a month

push eventzys-contrib/node

Maksim Sinik

commit sha ac3049d3312732da97a80f7db9572e846e13b7ee

doc: fix ESM/CJS wrapper example PR-URL: https://github.com/nodejs/node/pull/34853 Refs: https://github.com/nodejs/node/issues/34714 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

João Lucas Lucchetta

commit sha f5102fbcf4d959629413e7b8ddb37275286a50d8

http2: fix Http2Response.sendDate The `sendDate` flag was not being respected by the current implementation and the `Date` header was being sent regardless of the config. This commit fixes that and adds tests for this case. Fixes: https://github.com/nodejs/node/issues/34841 PR-URL: https://github.com/nodejs/node/pull/34850 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Jeremy Rose

commit sha 8e8d429277a8bbf40bca53ba8dd4edef4e7e4871

tls: enable renegotiation when using BoringSSL PR-URL: https://github.com/nodejs/node/pull/34832 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 9c55970c332eb60046419d7854a3c7009b973b02

doc: improve wording in deprecations.md * utilize -> use * may -> can/might as appropriate PR-URL: https://github.com/nodejs/node/pull/34860 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Antoine du HAMEL

commit sha 22e3ada0c12e61d17e9bbd28a3ab456daec17d75

doc: rename module pages Using a "Modules:" prefix groups all the related pages together when using alphabetical order. Refs: https://github.com/nodejs/modules/issues/539 PR-URL: https://github.com/nodejs/node/pull/34663 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Yash Ladha

commit sha c3d337db5d4535840cd4dfaf438d6062eec6d60c

src: usage of modernize-use-equals-default Update the destructor and constructor calls to use the default member function. This will bascially enable the compiler to do better optimization as the functions as explicitly defined as trivial. Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html PR-URL: https://github.com/nodejs/node/pull/34807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ben Noordhuis

commit sha b8ab49fc53b4d6c5bbae9a639103da058beaa84a

src: fix abort on uv_loop_init() failure Fixes: https://github.com/nodejs/node/issues/34855 PR-URL: https://github.com/nodejs/node/pull/34874 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Danny Guo

commit sha 0dae5d93809450a7dce1f9370473a1ffc480657d

doc: indicate the format of process.version PR-URL: https://github.com/nodejs/node/pull/34872 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Jim Schlight

commit sha cb315d2dd36d5ef1a9f7354662ee7e2e1e8fa696

doc,n-api: add link to n-api tutorial website PR-URL: https://github.com/nodejs/node/pull/34870 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 010383a1745a989d27d3462a3beb9fc159000cb4

doc: improve fs doc intro Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34843 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 62443686d9cf0915186d696ba48a0ae1f4926625

deps: upgrade to libuv 1.39.0 Notable changes: - uv_metrics_idle_time() and UV_METRICS_IDLE_TIME have been added for measuring the amount of time the event loop spends idle. - uv_udp_using_recvmmsg() has been added to determine if a buffer is large enough for multiple datagrams should be allocated in the allocation callback of uv_udp_recvstart(). - On MinGW, the installation location has been updated to match Unix systems rather than Windows. - uv_fs_copyfile() now tries to use copy_file_range() when possible. - The test suite is now reported to pass on Darwin ARM64 (Apple Silicon). - uv_{get,set}_process_title() now returns an error on platforms where uv_setup_args() is required, but has not yet been called. - The _POSIX_PATH_MAX constant is no longer used, which could lead to buffer overflows in uv_fs_readlink() and uv_fs_realpath(). PR-URL: https://github.com/nodejs/node/pull/34915 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Rich Trott

commit sha b93325cb267e4bb55387b2158140542438a3c371

doc: use links to MS guide in style guide Avoid repeating too much from the Microsoft guide by providing links to it. PR-URL: https://github.com/nodejs/node/pull/34871 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha a8db32a5042782c5426e229f466ba80bf5995c9d

test: simplify test-vm-memleak PR-URL: https://github.com/nodejs/node/pull/34881 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Rich Trott

commit sha ad2c22df61be67db5764e7e72d02d8351663bcee

doc: use "previous"/"preceding" instead of "above" as modifier Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/above PR-URL: https://github.com/nodejs/node/pull/34877 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Evan Lucas

commit sha 4b6036a07b9767ecdb9b04f1effb5170c3f7dd4e

build,deps: add gen-openssl target This adds a new make target to generate platform dependent files for openssl on non-linux machines. The scripts we currently have in place require linux. This adds a Dockerfile that installs the necessary dependencies to be able to generate these files. Previously, it was necessary to run `make -C deps/openssl/config` on a linux machine. Now, as long as docker is installed and in your `PATH`, it is possible to run `make gen-openssl`. PR-URL: https://github.com/nodejs/node/pull/34642 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Evan Lucas

commit sha d06ff289a058ff3ae97dc87456e9129f6d792a7f

deps: add openssl support for arm64 This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in https://github.com/openssl/openssl/pull/12369 to generate the required files. PR-URL: https://github.com/nodejs/node/pull/34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>

view details

Evan Lucas

commit sha e3b79e3bbe635fc7f57ff3df0c99dbb8f63ce05e

build: add support for build on arm64 Ref: https://github.com/nodejs/TSC/issues/886 Ref: https://github.com/nodejs/node/issues/34043 PR-URL: https://github.com/nodejs/node/pull/34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>

view details

gengjiawen

commit sha c6b96895cc74bc6bd658b4c6d5ea152d6e686d20

meta: enable wasi for CODEOWNERS PR-URL: https://github.com/nodejs/node/pull/34889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

zhangyongsheng

commit sha 5163b782a8965b05addd152fbef1ea6e176a2291

esm: cleanup resolve

view details

push time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+8 -0

0 comment

1 changed file

pull[bot]

pr closed time in a month

push eventzys-contrib/node

gengjiawen

commit sha c6b96895cc74bc6bd658b4c6d5ea152d6e686d20

meta: enable wasi for CODEOWNERS PR-URL: https://github.com/nodejs/node/pull/34889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

push time in a month

startedjstime/jstime

started time in a month

push eventzys-contrib/node

James M Snell

commit sha c788be2e6ecee66759f769c35f8940ea74b39da6

deps: update ngtcp2 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 757bac671117f8fbb68f808d4bbbe83035e4940d

deps: update nghttp3 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha c6e1edcc2802224cb9b312e9051e6bcdfc7935e4

src: add Update(const sockaddr*) variant Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 2a807372782470698ec8ecb216589c30ff0723cf

quic: fixups after ngtcp2/nghttp3 update Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 44e6a6af67fe5038540af73f5e3456bc29243550

quic: use qlog fin flag Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34752 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

zhangyongsheng

commit sha 3e2b05331c1fdfde62947130f558b350e57d9b24

esm: cleanup resolve

view details

push time in a month

push eventzys-contrib/node

zhangyongsheng

commit sha c55ec0bb440a644558702ba604ac147f69d7e983

esm: cleanup resolve

view details

push time in a month

create barnchzys-contrib/node

branch : esm-cleanup-resolve

created branch time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+81 -17

0 comment

10 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Anna Henningsen

commit sha 5acc69cdad3c8f1670f5eeeaa4c8ffa8b86bf6b3

doc: move addaleax to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/34809 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Dennis Ameling

commit sha 03293aa3a1e810c5ae6938cae41bf62ae418bb5f

build,win: use x64 Node when building for ARM64 Uses x64 node executable for running .js files in arm64 cross-compilation scenarios. MSI can now be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/34009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

view details

Bartosz Sosnowski

commit sha de565ad1b2de6d173a9ea5e1932e3d85472d4c23

process: correctly parse Unicode in NODE_OPTIONS Fixes an issue on Windows, where Unicode in NODE_OPTIONS was not parsed correctly. Fixes: https://github.com/nodejs/node/issues/34399 PR-URL: https://github.com/nodejs/node/pull/34476 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Rich Trott

commit sha 6130cdd190eaf334c8a12185b7ffa02ae25a88d6

test: run REPL preview test regardless of terminal type PR-URL: https://github.com/nodejs/node/pull/34798 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Rich Trott

commit sha 9d81d1266cc6062418812357115cd647a473bfbc

doc: sort references lexically Keep references sorted in ASCII order in module.md. PR-URL: https://github.com/nodejs/node/pull/34848 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Rich Trott

commit sha 9fd71a9964a9fdfd3647ae99097e10df634bb1ed

doc: fix bulleted list punctuation in BUILDING.md Remove/add periods as appropriate in bulleted lists in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/34849 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Rich Trott

commit sha 796317fb6552053846a96d02d6b36113cb7accc6

test: fix test-cluster-net-listen-relative-path.js to run in / test-cluster-net-listen-relative-path fails if run from the root directory on POSIX because the socket filename isn't quite long enough. Increase it by 2 so that the path length always exceeds 100 characters. PR-URL: https://github.com/nodejs/node/pull/34820 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Shelley Vohr

commit sha 7aeff6b8c8e1b7df2e9c1b7638c1c441af6ff45d

doc: claim ABI version for Electron v12 PR-URL: https://github.com/nodejs/node/pull/34816 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in a month

push eventzys-contrib/react

Sebastian Silbermann

commit sha ffb6c6c07b1a6dcabd04b22a6a5afeab96d53ae2

fix: skip dangerouslySetInnerHtml hydration warning if it's undefined (#18676) * test: Add failing case for dangerouslySetInnerHtml=undefined * fix: skip dangerouslySetInnerHtml warning if it's undefined * test: add similar test that should trigger the warning * chore: Remove redundant nullish check * Poke yarn_test_www_variant which timed out * test: Add smaller test for innerHTML=string to innerHTML=undefined

view details

Sebastian Silbermann

commit sha 707478e68a65734501b7f9189e89ff0fca1642d5

chore: Build react-dom/server in codesandbox CI (#18679)

view details

Dominic Gannaway

commit sha a152827ef697c55f89926f9b6b7aa436f1c0504e

Refine the heuristics around beforeblur/afterblur (#18668) * Refine the heuristics around beforeblur/afterblur

view details

Dominic Gannaway

commit sha 4f59a149b8dd99e0e3f2b515e15b069c276c085b

Modern event system: fix selectionchange bug (#18680)

view details

Naman Goel

commit sha 5f7b175b35fa6faccb0da14e897dcda9c13d6031

Pressable click fix (#18625) * Update press-legacy to use native click events * update tests for pressable change * fix formatting issue * Address comments. Bring back some tests, remove others. Cleanup * Fix flow and lint errors * formatting fix missed by yarn lint

view details

Sebastian Markbåge

commit sha 0960b7ba580b620202f7d245bb696aca71c63e37

Upgrade fbjs-scripts (#18684) * Upgrade fbjs-scripts This script takes into account the NODE_ENV as part of jest cache keys. This avoids flaky tests since we depend on different transforms in prod and dev. * Upgrade Fresh test to Babel 7 transform

view details

Dominic Gannaway

commit sha 80d39d8b5733d4ab22033aaf8b805de723e28fd1

Remove null sibling (#18687)

view details

Dominic Gannaway

commit sha 7b3934b34fe51ceb115ed9bb7836386bd8a7abc2

Revert "Pressable click fix (#18625)" (#18688) This reverts commit 5f7b175b35fa6faccb0da14e897dcda9c13d6031.

view details

Dominic Gannaway

commit sha ff431b7fc43ee9022db094a673afbac7088bcfa2

Remove ReactDOM.useEvent and associated types+tests (#18689)

view details

Sebastian Markbåge

commit sha 940f48b999a3131e77b2545bd7ae252ef27ae6d1

Avoid passing custom stacks to console.error (#18685) * Detect double stacks in the new format in tests * Remove unnecessary uses of getStackByFiberInDevAndProd These all execute in the right execution context already. * Set the debug fiber around the cases that don't have an execution context * Remove stack detection in our console log overrides We never pass custom stacks as part of the args anymore. * Bonus: Don't append getStackAddendum to invariants We print component stacks for every error anyway so this is just duplicate information.

view details

Brian Vaughn

commit sha 36cab2720ae2dbcaa63a90562ddb042101944f86

DevTools: Improved "native" component stacks (#18656) * DevTools console override handles new component stack format DevTools does not attempt to mimic the default browser console format for its component stacks but it does properly detect the new format for Chrome, Firefox, and Safari.

view details

Brian Vaughn

commit sha 9025949d840c89619bed9bf06f5c14c25c141c5a

Pin RNW to canary (#18692) This unbreaks DevTools shell with the latest ReactDOM in master.

view details

Nick Reiley

commit sha e5cc1462b3e7be78306a1f6961ce82d942eb36d2

Fix mistyped script arbitrary code execution vulnerability (#18660) * add test to trustedTypes-test.internal.js * fix mistyped script arbitrary code execution * Removed redundant .toLowerCase() call Co-authored-by: Brian Vaughn <brian.david.vaughn@gmail.com>

view details

Sebastian Markbåge

commit sha 2325375f4faaa77db6671e914da5220a879a1da8

Nit: add suffix _TIMEOUT consistently in scheduler (#18696)

view details

Sebastian Markbåge

commit sha 571f5ad2d695e6373ffbd8e86b27c11dad3d22cf

Temporarily Remove DebugTracing from the New Reconciler (#18697) * Remove priority field from tracing * Remove DebugTracing mode from new reconciler (temporarily) * Run DebugTracing tests in the *other* variant so it's no on for new reconciler

view details

Sebastian Markbåge

commit sha b0cb137bcbd3a11d8eff3c2229cd6b8379d29785

Don't dedupe using the stack (#18693) We currently use the stack to dedupe warnings in a couple of places. This is a very heavy weight way of computing that a warning doesn't need to be fired. This uses parent component name as a heuristic for deduping. It's not perfect but as soon as you fix one you'll uncover the next. It might be a little annoying but having many logs is also annoying. We now have no special cases for stacks. The only thing that uses stacks in dev is the console.error and dev tools. This means that we could externalize this completely to an console.error patching module and drop it from being built-in to react. The only prod/dev behavior is the one we pass to error boundaries or the error we throw if you don't have an error boundary.

view details

Brian Vaughn

commit sha b9fc3d8d59b0de5e4cec1619a3645494af169bae

DevTools temporarily disable prepareStackTrace before creating custom component stacks (#18717)

view details

Sebastian Markbåge

commit sha a2fb84bebdc282e026d2b16ed2825c6f564095a7

Disable prepareStackTrace while we're generating stacks (#18708) This could be used to do custom formatting of the stack trace in a way that isn't compatible with how we use it. So we disable it while we use it. In theory we could call this ourselves with the result of our stack. It would be a lot of extra production code though. My personal opinion is that this should always be done server side instead of on the client. We could expose a custom parser that converts it and passes it through prepareStackTrace as structured data. That way it's external and doesn't have to be built-in to React.

view details

Sebastian Markbåge

commit sha b58dec979a19d75d8f62fa5e8570ce33fbe50310

Remove unnecessary stack (#18707)

view details

Dominic Gannaway

commit sha 4e3545fd6fc62842d7dbf772923214474f59871a

ReactDOMEventListener: clean up module (#18713)

view details

push time in a month

PR merged zys-contrib/react

[pull] master from facebook:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+51529 -41351

0 comment

704 changed files

pull[bot]

pr closed time in a month

started5to6/5to6-codemod

started time in a month

push eventzys-contrib/node

Voltra

commit sha 9594b54f966c90c5c0270490a8b750e437a3cddb

http: add RFC references for each status code Reference format: `RFC <rfc id> <section path>` PR-URL: https://github.com/nodejs/node/pull/33671 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Anna Henningsen

commit sha ba5c64bf4541f540880cf35facdb8c24666072eb

quic: use AbortController with correct name/message On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: https://github.com/nodejs/node/pull/34763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 5d179cb2eccac38205b6f03ecf6403df65deea51

timers: use AbortController with correct name/message On the web, `AbortError` is the error name, not the error message. Change the code to match that. PR-URL: https://github.com/nodejs/node/pull/34763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

davkor

commit sha 375b859428e1c525f0cc9d3c4324f51740316722

build: add build flag for OSS-Fuzz integration Refs: https://github.com/google/oss-fuzz/pull/3860 Fixes: https://github.com/nodejs/node/issues/33724 PR-URL: https://github.com/nodejs/node/pull/34761 Fixes: https://github.com/nodejs/node/issues/33724 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 97d9b9c90eb5ba9943d451e85e115ddf95f9f1d4

test: allow ENFILE in test-worker-init-failure Refs: https://github.com/nodejs/node/pull/34727#issuecomment-672862034 PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Rich Trott

commit sha 0e1fd8d0b42340039ae4086fa23c062d1a2dee74

test: allow ENOENT in test-worker-init-failure PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Rich Trott

commit sha 42a3a7f97d3b565763671047c774c858c1e0d5c1

test: remove common.rootDir The three tests that use common.rootDir do not need the root dir. They just need an arbitrary directory that will exist. Use tmpdir.path instead. PR-URL: https://github.com/nodejs/node/pull/34772 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Alba Mendez

commit sha f5c0e282ccf98e17f295c11850649ad19a6fff51

http2: allow Host in HTTP/2 requests The HTTP/2 spec allows Host to be used instead of :authority in requests, and this is in fact *preferred* when converting from HTTP/1. We erroneously treated Host as a connection header, thus disallowing it in requests. The patch corrects this, aligning Node.js behaviour with the HTTP/2 spec and with nghttp2: - Treat Host as a single-value header instead of a connection header. - Don't autofill :authority if Host is present. - The compatibility API (request.authority) falls back to using Host if :authority is not present. This is semver-major because requests are no longer guaranteed to have :authority set. An explanatory note was added to the docs. Fixes: https://github.com/nodejs/node/issues/29858 PR-URL: https://github.com/nodejs/node/pull/34664 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Carlos Lopez

commit sha 0e30c5bc261756dffaa874e4a9ef9858f16ba1d9

http2: use and support non-empty DATA frame with END_STREAM flag Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. When writing to a stream, uses a END_STREAM flag on final DATA frame instead of adding an empty DATA frame. BREAKING: http2 client now expects servers to properly support END_STREAM flag Fixes: https://github.com/nodejs/node/issues/31309 Fixes: https://github.com/nodejs/node/issues/33891 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback PR-URL: https://github.com/nodejs/node/pull/33875 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Luigi Pinca

commit sha 92167e272be9dff7441f061ef8eac00bafa667e5

doc: fix broken links in commit-queue.md Fixes: https://github.com/nodejs/node/issues/34787 PR-URL: https://github.com/nodejs/node/pull/34789 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Mary Marchini

commit sha 8b818cf92515e77138e14dd2819856c3414c132e

build: add CODEOWNERS linter action PR-URL: https://github.com/nodejs/node/pull/34739 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

James M Snell

commit sha 1e6e5c3ef33112f8cec97ab700411b93adf26baf

quic: resolve minor TODO in QuicSocket PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 34165f03aa33d58c1a4fbbad0b2c3306a97b0657

quic: resolve some minor TODOs PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 344c5e4e508ee6c7fad98bb5a34daa98ff43df68

quic: limit push check to http/3 PR-URL: https://github.com/nodejs/node/pull/34655 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 10d5047a4fbe2cbae4c0895dee4509341e8e77a0

quic: fixup set_socket, fix skipped test PR-URL: https://github.com/nodejs/node/pull/34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 442968c92a0f131c153dba40e607e081811e5eb3

quic: check setSocket natRebinding argument, extend test PR-URL: https://github.com/nodejs/node/pull/34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha c17eaa3f3fe1ed18aef661540b07e80404172431

quic: add natRebinding argument to docs PR-URL: https://github.com/nodejs/node/pull/34669 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

James M Snell

commit sha 240592228bc794918443d46a8fcee85fe25a80d7

quic: fixup session ticket app data todo comments PR-URL: https://github.com/nodejs/node/pull/34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 19e712b9b2982404bbb4b8e1f9e1700ee8048d6f

quic: resolve InitializeSecureContext TODO comment Using a static label is sufficient. PR-URL: https://github.com/nodejs/node/pull/34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 94aa29134830b7ff1f99211ecd3ef0d12b32a793

quic: clarify TODO statements PR-URL: https://github.com/nodejs/node/pull/34741 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1442 -633

0 comment

105 changed files

pull[bot]

pr closed time in a month

PR merged zys-contrib/babel

[pull] master from babel:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+59 -40

0 comment

9 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/babel

Nicolò Ribaudo

commit sha fd3c76941e2e826cacab8844672f1d985f7ea564

[gitpod] Run "make watch" in a second terminal (#11718) Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> [skip ci]

view details

Huáng Jùnliàng

commit sha e498bee10f0123bb208baa228ce6417542a2c3c4

replace whitelist by allowlist in parser-tests (#11727)

view details

push time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+121 -79

0 comment

18 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Tobias Nießen

commit sha 4a9e312591fcb773a76a0493ee2adaaa262e58e3

crypto: avoid unitializing ECDH objects on error The previous code changed the private key of the ECDH object, but removed the public key if deriving it from the private key failed. Instead, if deriving the public key fails, neither the private nor the public key stored in the ECDH object should be updated. PR-URL: https://github.com/nodejs/node/pull/34302 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha 8640cd6066b858f7499d175b18dfc1947653063f

doc: avoid _may_ in collaborator guide Many style guides (including Microsoft's) suggest avoiding _may_ because it can be unclear. Using _can_ or _might_ tends to increase clarity. An example in this change: > They may not change to a Runtime Deprecation until the next major > release. It's not clear if that means "They can not change until the next major release" or "They might not change until the next major release but also might change before then". Using _can_ or _might_ instead of _may_ clears up the ambiguity. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may PR-URL: https://github.com/nodejs/node/pull/34749 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha 1e59f31555d547cebadc3f647cc4693cb98b5690

test,doc: add missing uv_setup_args() calls libuv 1.39.0 will begin requiring uv_setup_args() to be called before attempting to access the process title. This commit adds uv_setup_args() calls that were missing in order for the test suite to pass (and updates the documentation). PR-URL: https://github.com/nodejs/node/pull/34751 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

João Reis

commit sha c2771dc07c29a0cda7f009f046d99c542d2b2ca4

build: move compiling for Windows ARM64 to Tier 2 PR-URL: https://github.com/nodejs/node/pull/34721 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Mary Marchini

commit sha 5f78dea1a42eba373df57beac18a252aad74df65

meta: add TSC as owner of governance-related docs PR-URL: https://github.com/nodejs/node/pull/34737 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Derek Lewis

commit sha 0347574834ab1a0714c2c97bf6bb07592556abd8

module: fix check for package.json at volume root This patch converts the "read package scope" algorithm's while loop into a do-while loop enabling items at the filesystem root dir to be considered within the scope of a sibling package.json also at the filesystem root dir. Fixes: https://github.com/nodejs/node/issues/33438 Co-authored-by: Guy Bedford <guybedford@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34595 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Denys Otrishko

commit sha 8da8ec9c7e66e8f249757d3bdccc8588135c2ed7

errors: improve ERR_INVALID_OPT_VALUE error * use util.inspect for value presentation * allow to optionally specify error reason PR-URL: https://github.com/nodejs/node/pull/34671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

push time in a month

startedreorx/httpstat

started time in a month

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1256 -662

0 comment

31 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Yash Ladha

commit sha 56b25e7a6f741c8181c55f3d40d0cab6ffa1eb4d

benchmark: add benchmark script for resourceUsage Added a benchmark script for process method to benchmark the method resourceUsage. PR-URL: https://github.com/nodejs/node/pull/34691 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Guy Bedford

commit sha f8976a76bbb49d678056d6d2ddd57064cf9e63c2

module: share CJS/ESM resolver fns, refactoring PR-URL: https://github.com/nodejs/node/pull/34744 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Bradley Farias

commit sha e155d9601429057a34adbcdcb790a1c12bd2a163

policy: support conditions for redirects PR-URL: https://github.com/nodejs/node/pull/34414 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

Mary Marchini

commit sha a84716a21b3a4a17f67c95227e9eaf3968910171

build: implement a Commit Queue in Actions This is a (still experimental) implementation of a Commit Queue on GitHub Actions, using labels and the scheduler event to land Pull Requests. It uses `node-core-utils` to validate Pull Requests and to prepare the commit message, and then it uses a GitHub personal token to push changes back to the repository. If the Queue fails to land a Pull Request, that PR will be removed from the queue and the `node-core-utils` output will be pasted in the Pull Request. An overview of the implementation is provided in doc/guides/commit-queue.md, as well as current limitations. Ref: https://github.com/mmarchini-oss/automated-merge-test Ref: https://github.com/nodejs/build/issues/2201 PR-URL: https://github.com/nodejs/node/pull/34112 Refs: https://github.com/mmarchini-oss/automated-merge-test Refs: https://github.com/nodejs/build/issues/2201 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Rich Trott

commit sha 9861962a5f165f8a325013bf665fe76e8433cfd7

test: remove error message checking in test-worker-init-failure Let the check for the error code suffice and don't check for a particular string in the message. PR-URL: https://github.com/nodejs/node/pull/34727 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Matthew McEachen

commit sha 7b8c6b0c00f5e321e431047794fde8b84d0c4c3f

lib: add UNC support to url.pathToFileURL() Fixes: https://github.com/nodejs/node/issues/34736 PR-URL: https://github.com/nodejs/node/pull/34743 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha 5864fca7bc96ba701558f2b641c1e4cd1640f9f5

buffer: alias UInt ➡️ Uint in buffer methods It’s *so* hard to remember that it’s `UintXArray` but not `(write|read)UintX`. Let’s fix that by just providing aliases. 😊 PR-URL: https://github.com/nodejs/node/pull/34729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha a0f87aab102580503788e15467013a05ab794b5d

fs: guard against undefined behavior Calling close on a file description which is currently in use is undefined behavior due to implementation details in libuv. Add a guard against this when using FileHandle. PR-URL: https://github.com/nodejs/node/pull/34746 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 888eb5a987ffa8b5a2a36caf372cc0def67f79c9

test: use process.env.PYTHON to spawn python Co-authored-by: Jérémy Lal <kapouer@melix.org> Fixes: https://github.com/nodejs/node/issues/34699 PR-URL: https://github.com/nodejs/node/pull/34700 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

push time in a month

PublicEvent

push eventzys-contrib/nodejs.dev

dependabot[bot]

commit sha b47ae42554fc83d1a4ce187d9057cd68c7d6922c

build(deps): bump npm in /.github/action/result-poster (#381) Bumps [npm](https://github.com/npm/cli) from 6.11.2 to 6.13.4. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/CHANGELOG.md) - [Commits](https://github.com/npm/cli/compare/v6.11.2...v6.13.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Rich Trott

commit sha c51f56c1ef9964bccc1df28e70c603d7f19eae03

chore: update dependencies (#379) Results of yarn upgrade gatsby. This will quell a warning in the GitHub interface.

view details

Nick Schonning

commit sha a7f83242f573ff29ff1be61e2ec00f50bf3d46b9

chore: bump remark-preset-lint-node to 1.10.1 (#356) Supress newly failing rules to be fixed separatley

view details

Brian Harrington

commit sha 4e721460e71f6ff27680e7310c11a6cc8227d41a

grammar, update times and references (#360)

view details

Masashi Hirano

commit sha a5715c4030c0a4648bd10c7bd6bc84f51116bed0

fix: Stream.Readable example (#367) Co-Authored-By: Nick Schonning <nschonni@gmail.com>

view details

kajaharish

commit sha 0b4d08c6d7f7a56726acff1dc21da11e51668936

Update index.md (#374) In the copy a buffer section, there is a mistake: buf.copy(bufcopy, 0, 2,2) //it will print nothing since the source start and source end is specified as 2 in the original code correction: buf.copy(bufcopy, 0, 0, 2) // it will print the desired output that is 'He'

view details

Brian Clark

commit sha 0edef663913781357903dae4df6ac330615d67eb

docs: correct azure documentation link (#377) Co-authored-by: Nick Schonning <nschonni@gmail.com>

view details

Saqib Ameen

commit sha 013dd75032bd88700a5ce95ef7b8e8e86a86b447

Add a note (#363) Add a note (condition) for running the `node.js` command.

view details

Nick Schonning

commit sha 9ba9304c373e39210c9612e53ae994f3f073cf0a

fix: remark-lint minor suppressed rules (#351)

view details

Aymen Naghmouchi

commit sha 9a294407d23fc53981322668dd65095a62d007ca

doc: add MEAN and Loopback (#372) Co-Authored-By: Nick Schonning <nschonni@gmail.com>

view details

dependabot[bot]

commit sha a6d48f9688fabd7a42784bdb4757ebe034f97d55

build(deps): bump handlebars in /.github/action/result-poster (#384) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 8c3e8195913a5a8a4ac7313af55dce6465b9e521

build(deps): bump handlebars from 4.1.2 to 4.5.3 (#385) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Manil Chowdhury

commit sha aa613a02bb075d9392cf636d9de39fb3d428dfb7

Notes for meeting on 2020-01-30 (#391) * Create 2020-01-30.md Thank you for taking notes, @jonchurch and @SMotaal 👍🏽 * fix: Tweak meeting minutes to fix md linting errors Co-authored-by: Jonathan Church <me@jonchurch.com>

view details

Liz Parody

commit sha 9534d9d8ad729c5953b3b23fdbd0a44fdc898e92

Update examples (#393) Updated the examples to use a more recent version of Node.js

view details

dependabot[bot]

commit sha f0c49a932cdd493d86ca2b44a71c2d95135552d9

build(deps-dev): bump codecov from 3.5.0 to 3.6.5 (#411) Bumps [codecov](https://github.com/codecov/codecov-node) from 3.5.0 to 3.6.5. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

Juan Sebastian velez Posada

commit sha 2d092204e67e3f02dde27472e3e7bcb0fd5743f8

Fix typo on statSync method (#400)

view details

Basavanagowda Kanur

commit sha 287356abd5c9967999e400a1dae7d434f275de0f

Fix typo on 'How to use the Node.js REPL' page (#432)

view details

Saleh Abdel Motaal

commit sha 3e024a43e647ed111a506897461776907bb58b3c

docs: add OKR.md (#394) * docs: add OKR.md This adds an OKR.md doc deriving from https://github.com/nodejs/community-committee/blob/3d0329d82fe5d85d8050027c4f4683ab88a01a08/OKR.md based on Node.js Foundation Website Redesign Strategic Initiative Meeting 2020-01-30 discussion minutes in https://docs.google.com/document/d/17IuIy9Ir7SHSq7O7UwOsnsoI3vRGL4z1XH-tUeClgMw/edit?pli=1. * Update OKR explainer Co-Authored-By: Joe Shindelar <eojthebrave@gmail.com> * Commit current suggestions Agreed to merge as is, future updates can happen after. Co-Authored-By: Onur Laru <2481234+LaRuaNa@users.noreply.github.com> Co-authored-by: Manil Chowdhury <manil.chowdhury@gmail.com> Co-authored-by: Joe Shindelar <eojthebrave@gmail.com> Co-authored-by: Onur Laru <2481234+LaRuaNa@users.noreply.github.com>

view details

dependabot[bot]

commit sha f691f2ca8d1c7562b1ba6c8b97bfb233355cd3a8

build(deps): bump acorn from 5.7.3 to 5.7.4 (#430) Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

dependabot[bot]

commit sha ad86d9e8649e15445c6689591dacfddc4668a149

build(deps): bump acorn in /.github/action/result-poster (#429) Bumps [acorn](https://github.com/acornjs/acorn) from 6.0.5 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/6.0.5...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a month

PR merged zys-contrib/nodejs.dev

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+38625 -26253

25 comments

240 changed files

pull[bot]

pr closed time in a month

push eventzys-contrib/node

Rich Trott

commit sha 49a1f7f15d1e8d996459ce4b503251a0be762763

test: use block-scoping in test/pummel/test-timers.js PR-URL: https://github.com/nodejs/node/pull/34630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Rich Trott

commit sha bbfb01459096cd8933ce6f7115faa599adf2256b

test: split test-crypto-dh-hash test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: https://github.com/nodejs/node/pull/34631 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

gengjiawen

commit sha a7477704c417f9d51eb8e859db148f12423732a2

quic: prefer modernize-make-unique PR-URL: https://github.com/nodejs/node/pull/34692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Nikolay Krashnikov

commit sha 10ed48bef487e4870158930c355247526312707d

doc: add HPE_UNEXPECTED_CONTENT_LENGTH error description PR-URL: https://github.com/nodejs/node/pull/34596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Anna Henningsen

commit sha 9f47e5a7f74c866571512bef91e661b69a18a03e

test: fix test_worker_terminate_finalization The test was missing an initialization of the global `ref` variable because there was also an unused local one, leading to failures like the one seen in https://github.com/nodejs/node/pull/34625. PR-URL: https://github.com/nodejs/node/pull/34726 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>

view details

Shelley Vohr

commit sha 6e1f6ec57398689740ab29acb6ce49bc94b95c79

2020-08-11, Version 14.8.0 (Current) Notable changes: async_hooks: * (SEMVER-MINOR) add AsyncResource.bind utility (James M Snell) https://github.com/nodejs/node/pull/34574 doc: * add Ricky Zhou to collaborators (rickyes) https://github.com/nodejs/node/pull/34676 * add release key for Ruy Adorno (Ruy Adorno) https://github.com/nodejs/node/pull/34628 * add DerekNonGeneric to collaborators (Derek Lewis) https://github.com/nodejs/node/pull/34602 module: * (SEMVER-MINOR) unflag Top-Level Await (Myles Borins) https://github.com/nodejs/node/pull/34558 n-api: * (SEMVER-MINOR) support type-tagging objects (Gabriel Schulhof) https://github.com/nodejs/node/pull/28237 n-api,src: * (SEMVER-MINOR) provide asynchronous cleanup hooks (Anna Henningsen) https://github.com/nodejs/node/pull/34572 PR-URL: https://github.com/nodejs/node/pull/34704

view details

James M Snell

commit sha 1f9b20b6376e0949807729ef46727a4fafad7f1d

net: introduce net.BlockList `net.BlockList` provides an object intended to be used by net APIs to specify rules for disallowing network activity with specific IP addresses. This commit adds the basic mechanism but does not add the specific uses. PR-URL: https://github.com/nodejs/node/pull/34625 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>

view details

Antoine du HAMEL

commit sha c093f6b4d1745521f0b0239158ee81b21b786f67

doc: use semantically appropriate tag for lines The HTML <hr> element represents a thematic break between paragraph-level elements: for example, a change of scene in a story, or a shift of topic within a section. The HTML Content Division element (<div>) is the generic container for flow content and does not inherently represent anything. The <hr> tag semantically fits better the meaning of the line between the lists. Refs: https://html.spec.whatwg.org/multipage/grouping-content.html#the-hr-element PR-URL: https://github.com/nodejs/node/pull/34660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Antoine du HAMEL

commit sha f280d2c85cf5bcf2cbe277de5a1f410a68c7a562

doc: add padding in the sidebar column PR-URL: https://github.com/nodejs/node/pull/34665 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Evan Lucas <evanlucas@me.com>

view details

Tobias Nießen

commit sha 1be7bbdc3b533759072cfc3d13766511197e3d01

src: prefer C++ empty() in boolean expressions PR-URL: https://github.com/nodejs/node/pull/34432 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

view details

Jim Schlight

commit sha bbdb0133dc084cdb5107a56b48b7c5fdb0deeec9

doc: n-api environment life cycle APIs are stable PR-URL: https://github.com/nodejs/node/pull/34641 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha 9dac8cbbc32cac824cc8415df3b610cee6d47c99

benchmark: update function_args addon code Make the code linter-conformant and remove usage of deprecated APIs. PR-URL: https://github.com/nodejs/node/pull/34725 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 420da0ccd195adfd36bf160d59af92567a8df74f

build: cover all benchmark addons with C++ linter PR-URL: https://github.com/nodejs/node/pull/34725 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Guy Bedford

commit sha 77a515c31aa4383e54e032bebdc399b3704e8a3d

module: custom --conditions flag option PR-URL: https://github.com/nodejs/node/pull/34637 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>

view details

Rich Trott

commit sha f86e3ea9dfc90b96d2e198a33dea07a491a608d7

doc: remove typo in crypto.md Change "its[sic] recommended to" to "be sure to". This fixes a typo and also improves the passive and indirect phrasing to a more concise active and direct phrasing. PR-URL: https://github.com/nodejs/node/pull/34698 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha fd038a1f1556e4d525ffb9ba07b2951e14e81cda

worker: fix --abort-on-uncaught-exception handling The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: https://github.com/nodejs/node/pull/34724 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Anna Henningsen

commit sha cf5d7c0140cd41d2cb251b0b3b8947a797d192b1

test: skip node-api/test_worker_terminate_finalization The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: https://github.com/nodejs/node/issues/34731 PR-URL: https://github.com/nodejs/node/pull/34732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>

view details

Mary Marchini

commit sha 2f27f1144edd5772467597da26c8faf41a1dbd99

doc: reduce repetitiveness on Consensus Seeking Rearrange Consensus Seeking section to reduce repetitiveness. Ref: https://github.com/nodejs/node/pull/34639#discussion_r466447930 Ref: https://github.com/nodejs/node/pull/34639#discussion_r466450850 PR-URL: https://github.com/nodejs/node/pull/34702 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Priyank Singh

commit sha 3b84048260ba57277b327c1913ca19d826c49158

http2: add maxHeaderSize option to http2 add maxHeaderSize to http2 as an alias for maxHeaderListSize. Fixes: https://github.com/nodejs/node/issues/33517 PR-URL: https://github.com/nodejs/node/pull/33636 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Mary Marchini

commit sha b5e3fca04cda736d4a3edcdd4f61d7686291821b

build: set --v8-enable-object-print by default The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: https://github.com/nodejs/node/pull/32834 PR-URL: https://github.com/nodejs/node/pull/34705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1707 -266

0 comment

57 changed files

pull[bot]

pr closed time in 2 months

startedPepsRyuu/nollup

started time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+409 -154

0 comment

25 changed files

pull[bot]

pr closed time in 2 months

push eventzys-contrib/node

Gabriele Greco

commit sha b0e4970b8fe0dbd6bf437b3b06d0438d906ea94d

tools: add debug entitlements for macOS 10.15+ To debug native modules node should be a debuggable process, that will require the **com.apple.security.get-task-allow** entitlement to be added to the codesign procedure. PR-URL: https://github.com/nodejs/node/pull/34378 Fixes: https://github.com/nodejs/node/issues/34340 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha 6b0b33cd4ca647865457be2199c31b16bab14648

quic: cleanup some outstanding todo items PR-URL: https://github.com/nodejs/node/pull/34618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 6d1f0aed52b890e4f4bfa2281894df4d423cf1c6

src: add SocketAddressLRU Utility Adds a LRU cache for information associated with a SocketAddress. PR-URL: https://github.com/nodejs/node/pull/34618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha f75e69a94bef9246c24b0494485421c8f4741177

quic: use SocketAddressLRU to track known SocketAddress info Using the `SocketAddressLRU` utility allows us to put an upper bound on the amount of memory that will be used to track known SocketAddress information (such as current number of connections, validation status, reset and retry counts, etc. The LRU is bounded by both max size and time, with any entry older than 10 seconds dropped whenever another item is accessed or updated. PR-URL: https://github.com/nodejs/node/pull/34618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 5b6cd6fa1a0b54393d96ee0b34bd5d9334a9faec

quic: use the SocketAddressLRU to track validation status PR-URL: https://github.com/nodejs/node/pull/34618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha b8b5e1e5d0bff0103446f92c07cbea73df174e1f

deps: V8: cherry-pick e06ace6b5cdb Original commit message: [api] Fix empty Maybe crash in GetRealNamedPropertyAttributes `Object::GetRealNamedPropertyAttributes()` can crash if an empty `Maybe` is returned by `JSReceiver::GetPropertyAttributes()` because it was not checking for that. Fix that. Refs: https://github.com/nodejs/node/issues/34606 Change-Id: Ic83f904ba7134786bcd8f786eb2ce98adb4fea1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335057 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69258} Refs: https://github.com/v8/v8/commit/e06ace6b5cdb64b6abfe8e1229f2159b7a38b4e7 PR-URL: https://github.com/nodejs/node/pull/34673 Fixes: https://github.com/nodejs/node/issues/34606 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46

test: add vm crash regression test Refs: https://github.com/nodejs/node/issues/34606 PR-URL: https://github.com/nodejs/node/pull/34673 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Bradley Farias

commit sha bcfb1762a3e613e71ac68ab8a6420e2f33c0f603

util: add debug and debuglog.enabled PR-URL: https://github.com/nodejs/node/pull/33424 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 8a8416f84169c553380704ab3a754db0a1735877

lib: use full URL to GitHub issues in comments Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: https://github.com/nodejs/node/pull/34686 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha ea5eb8fc9cf137350862a046cc4f05c2f29300db

test: remove test-child-process-fork-args flaky designation test-child-process-fork-args does not appear in results from `ncu-ci walk commit` and no one has reported it failing for several months. A stress test also passed. Closes: https://github.com/nodejs/node/issues/32863 PR-URL: https://github.com/nodejs/node/pull/34684 Fixes: https://github.com/nodejs/node/issues/32863 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>

view details

Renato Mariscal

commit sha f8a0e62bbf4a9ad6a526bc7d26bdb77132be994a

doc: update http server response 'close' event Two places emits `close` events: `resOnFinish` calls `emitCloseNT`, which happens when the result is completed: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L695 It gets attached once the socket is assigned: https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L226 And detached if the response is completed: https://github.com/nodejs/node/blob/master/lib/_http_server.js#L709 https://github.com/nodejs/node/blob/687dbd85263f433cc351c6daa83f9296a1d0bb4f/lib/_http_server.js#L232 Which means, it can only be reached in this case, for premature socket termination. PR-URL: https://github.com/nodejs/node/pull/34472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+164 -153

0 comment

22 changed files

pull[bot]

pr closed time in 2 months

push eventzys-contrib/node

Rich Trott

commit sha 6f12643142039bd099f8c021923ac4deea1ae725

doc: use _Static method_ instead of _Class Method_ Our docs describe static methods as Class Methods which seems idiosyncratic for JavaScript. Align with MDN which calls them static methods. Refs: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/API_references/What_does_an_API_reference_need JSON format for our docs will still use the key name `classMethods` for this. I would like to change it to `staticMethods` but I don't know if that will break things for consumers. So, leaving it alone. It's a machine-consumable label more than a human-readable so I can live with that. PR-URL: https://github.com/nodejs/node/pull/34659 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Mary Marchini

commit sha 84ef92f7cb93c00cf164e611e7496ac29554c2c5

meta: uncomment all codeowners A recent feature was added to github-bot to ping codeowners defined on the CODEOWNERS file even if the team doesn't have write permission to the repository. That means we can enable codeowners everywhere in the repository. Ref: https://github.com/nodejs/github-bot/pull/265 Fix: https://github.com/nodejs/node/issues/33984 PR-URL: https://github.com/nodejs/node/pull/34670 Fixes: https://github.com/nodejs/node/issues/33984 Refs: https://github.com/nodejs/github-bot/pull/265 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Denys Otrishko

commit sha 6914b3798c6c4cc6b2f64a206674505b4b5adf80

test: add tests for validateNumber/validateString PR-URL: https://github.com/nodejs/node/pull/34672 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Guy Bedford

commit sha 0f4b4ea5c61d0655a5bf3365845b12b26fe4e09c

module: use cjsCache over esm injection PR-URL: https://github.com/nodejs/node/pull/34605 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Mary Marchini

commit sha 71aeea1061024f0d896956f3d133cfb0aa66cbe1

doc: harden policy around objections Harden policy around objections to avoid misunderstanding and to encourage collaboration between pull request authors and objectors. Fixes: https://github.com/nodejs/node/issues/34564 PR-URL: https://github.com/nodejs/node/pull/34639 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Priyank Singh

commit sha 3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a

doc: add writable and readable options to Duplex docs Fixes: https://github.com/nodejs/node/issues/34382 PR-URL: https://github.com/nodejs/node/pull/34383 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Mary Marchini

commit sha dd0c5228acaf5695f96809e50771ead3167b0f44

build: add flag to build V8 with OBJECT_PRINT Add a configure flag to build V8 with `-DOBJECT_PRINT`, which will expose auxiliar functions to inspect heap objects using native debuggers. Fixes: https://github.com/nodejs/node/issues/32402 Signed-off-by: Mary Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32834 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 2 months

push eventzys-contrib/node

rickyes

commit sha e1eb56fc94f4a345dfde51847e551b132cf98da8

doc: add Ricky Zhou to collaborators PR-URL: https://github.com/nodejs/node/pull/34676 Fixes: https://github.com/nodejs/node/issues/34441 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

gengjiawen

commit sha f32114441c4aca6fc432897f92fc26135bf490a0

test: fix wrong method call PR-URL: https://github.com/nodejs/node/pull/34629 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha e948ef351b4111d78ae8ba08f29eb138af22fa0b

module: handle Top-Level Await non-fulfills better Handle situations in which the main `Promise` from a TLA module is not fulfilled better: - When not resolving the `Promise` at all, set a non-zero exit code (unless another one has been requested explicitly) to distinguish the result from a successful completion. - When rejecting the `Promise`, always treat it like an uncaught exception. In particular, this also ensures a non-zero exit code. Refs: https://github.com/nodejs/node/pull/34558 PR-URL: https://github.com/nodejs/node/pull/34640 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

Rich Trott

commit sha 614298d0113aa5b9783a12dd9adba6023954bf9b

repl: use _REPL_ in user-facing text User-facing error messages should use _REPL_ for the general REPL and not _repl_ which should be reserved for referring to the module itself, etc. _REPL_ is an acronym, so it should be capitalized, as it generally is in documentation in other technologies, and is usually in our own documentation. This fixes a few inconsistent usages in lib/repl.js. PR-URL: https://github.com/nodejs/node/pull/34643 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Robey Pointer

commit sha c0be31f0efd162f0edd416ed23f5aac082edd2aa

net: don't return the stream object from onStreamRead CallJSOnreadMethod expects the return value to be undefined or a new buffer, so make sure to return nothing, even when an error causes us to destroy the stream. Fixes: https://github.com/nodejs/node/issues/34346 PR-URL: https://github.com/nodejs/node/pull/34375 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Rich Trott

commit sha 989d82fe013def851f76309bcadd2e8847c8ee73

repl: use _Node.js_ in user-facing REPL text We use _node (REPL)_ in one place and _Node.js (REPL)_ in another place in error messages in repl.js. Use _Node.js_ in both places. PR-URL: https://github.com/nodejs/node/pull/34644 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha bdfc59893d4d797c1fd2e22349faf96cf57fd067

doc: tidy some addons.md text PR-URL: https://github.com/nodejs/node/pull/34654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Shelley Vohr

commit sha 8825eb4d734c78ccdaa06811a5b033e59f7fa978

lib: use non-symbols in isURLInstance check PR-URL: https://github.com/nodejs/node/pull/34622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 2 months

push eventzys-contrib/node

Rich Trott

commit sha a11aa9b9806380b22308af2f0b327946b2b7f557

meta: enable http2 team for CODEOWNERS PR-URL: https://github.com/nodejs/node/pull/34534 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Mary Marchini

commit sha 46bef7b7716b377055260490bb6f713ffb593672

test: add Actions annotation output It's possible to annotate failures in Actions by printing "::error file={},line={},col={}::{message}". This methos is preferrable over using a problem matcher because problem matchers only allow single-line messages, whereas ::error allows multi-line messages. PR-URL: https://github.com/nodejs/node/pull/34590 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Mateusz Krawczuk

commit sha 33060703cc214b4056718eaaf5738f8fc83130f7

crypto: add OP flag constants added in OpenSSL v1.1.1 PR-URL: https://github.com/nodejs/node/pull/33929 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

aetheryx

commit sha 0fd73696a5bc324adcddad6953ab8984b3d30937

doc: fix typo in path.md PR-URL: https://github.com/nodejs/node/pull/34550 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

iandrc

commit sha 0dff5bc2d8d03733093848d6691a347755f914cc

doc: update fs.watch() availability for IBM i Add a line that IBM i does not support `fs.watch()`. Fixes: https://github.com/nodejs/node/issues/34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: https://github.com/nodejs/node/pull/34611 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 57c8549c561c9892c0c1efb948728b92ddb78516

test: add debugging for test-https-foafssl.js The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 93959b22b197e2e9fdb4a21e65e567729d76338d

test: add debugging for callbacks in test-https-foafssl.js The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha bfebfdb149cf2d68ceee19f207ba65e0d8357a7f

src: fix linter failures Fix linter failures when running the linter on all source files. PR-URL: https://github.com/nodejs/node/pull/34582 Refs: https://github.com/nodejs/node/pull/34565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 318c982f3b1cd2d836de0e03ca9c9ecb634b546c

tools: fix C++ import checker argument expansion Makefile assumes that it can pass a list of files to the import checker, whereas the import checker expects a single argument that is interpreted as a blob. Fix that mismatch by accepting multiple arguments in the import checker. Refs: https://github.com/nodejs/node/pull/34565 PR-URL: https://github.com/nodejs/node/pull/34582 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha 607183efff97a78e4daf9b624b7d973b207db9f9

doc: edit process.title note for brevity and clarity PR-URL: https://github.com/nodejs/node/pull/34627 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 0a3ac681c2f58a3c4f4ef9045b90f5a3bc30c184

deps: update to uvwasi 0.0.10 Notable changes: - The uvwasi_preopen_t now uses const char* for the mapped_path and real_path fields. Previously, these were not `const`. - uvwasi_path_filestat_get() now properly handles the UVWASI_LOOKUP_SYMLINK_FOLLOW flag. - uvwasi_options_init() has been added to reduce the boilerplate code associated with initializing uvwasi_options_t's. - The DEBUG() macro has been renamed to UVWASI_DEBUG() to reduce naming conflicts with other projects. - A compilation error on NetBSD 8.2 has been fixed. - The uvwasi_fd_filestat_set_times() and uvwasi_path_filestat_set_times() functions now have proper implementations. Fixes: https://github.com/nodejs/node/issues/34510 PR-URL: https://github.com/nodejs/node/pull/34623 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

cjihrig

commit sha 33505e2dbdee3f4197f54b28dc24007110b46d3a

wasi: add __wasi_fd_filestat_set_times() test PR-URL: https://github.com/nodejs/node/pull/34623 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Gerhard Stoebich

commit sha 014feecc445c7dfc754378f2626cd43ee30a448d

async_hooks: avoid GC tracking of AsyncResource in ALS Manually destroy the AsyncResource created by AsyncLocalStore.run() to avoid unneeded GC tracking in case a destroy hooks is present. PR-URL: https://github.com/nodejs/node/pull/34653 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 9511261f350bf4791f6edf567a1c68e3ad540722

src: fix `size` underflow in CallbackQueue Only decrease the size when actually removing items. PR-URL: https://github.com/nodejs/node/pull/34662 Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 09c5942bfd0efe92e0a4f6791681be915752283d

src: spin shutdown loop while immediates are pending This allows using `SetImmediate()` and friends at any point during cleanup. PR-URL: https://github.com/nodejs/node/pull/34662 Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 262d0d0482ffd2fe7d654422df9df1f350045635

n-api: fix use-after-free with napi_remove_async_cleanup_hook Fixes: https://github.com/nodejs/node/issues/34657 Refs: https://github.com/nodejs/node/pull/34572 PR-URL: https://github.com/nodejs/node/pull/34662 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Evan Lucas

commit sha ac5773b1c302409c472aafea19ab13bb17320ba9

build: do not run auto-start-ci on forks Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: https://github.com/nodejs/node/pull/34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 2 months

create barnchzys-contrib/node

branch : http-no-socket-error

created branch time in 2 months

Pull request review commentnodejs/node

http2: allow Host in HTTP/2 requests

+'use strict';++const common = require('../common');+if (!common.hasCrypto)+  common.skip('missing crypto');+const assert = require('assert');+const h2 = require('http2');++// Requests using host instead of :authority should be allowed+// and Http2ServerRequest.authority should fall back to hos
// and Http2ServerRequest.authority should fall back to host

Typo ?

mildsunrise

comment created time in 2 months

issue commentnodejs/node

Dynamic imports don't respect the experimental-json-modules flag

Can't reproduce on macOS X 10.15.5.

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension

@nathanblair Could you please provide the whole error stack ?

nathanblair

comment created time in 2 months

push eventzys-contrib/node

Shelley Vohr

commit sha e43bb2f101870949f8332175f4eb80acdb0034e0

build: run CI on release branches PR-URL: https://github.com/nodejs/node/pull/34649 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>

view details

Gerhard Stoebich

commit sha 48249889b6b1af69d3c2b6fb9e59fea08d2bd023

async_hooks: avoid unneeded AsyncResource creation Inspired by the callstack at https://github.com/nodejs/node/issues/34556#issuecomment-666743528 If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: https://github.com/nodejs/node/issues/34556#issuecomment-666743528 PR-URL: https://github.com/nodejs/node/pull/34616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

view details

Gerhard Stoebich

commit sha a4e1755df2f9bb8c712d7ca767a5944d9d71e33b

async_hooks: don't read resource if ALS is disabled Only call executionAsyncResource() in getStore() if the ALS instance is enabled because the resource is not needed otherwise. PR-URL: https://github.com/nodejs/node/pull/34617 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 22cbbcf9d9374d4b663bf1409f292212fa57623a

n-api,src: provide asynchronous cleanup hooks Sometimes addons need to perform cleanup actions, for example closing libuv handles or waiting for requests to finish, that cannot be performed synchronously. Add C++ API and N-API functions that allow providing such asynchronous cleanup hooks. Fixes: https://github.com/nodejs/node/issues/34567 PR-URL: https://github.com/nodejs/node/pull/34572 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Rich Trott

commit sha e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa

doc: use _Class Method_ in async_hooks.md We use _Class Method_ rather than _static_ in documentation headers in buffer.md and crypto.md. We use _static_ in one place in async_hooks.md. Change to _Class Method_ for consistency. PR-URL: https://github.com/nodejs/node/pull/34626 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

push time in 2 months

push eventzys-contrib/node

zhangyongsheng

commit sha beb941b9a71c584b06e647e4dd92625bf07f28a5

fix: cleanup!

view details

push time in 2 months

delete branch zys-contrib/node

delete branch : esm-get-source

delete time in 2 months

create barnchzys-contrib/node

branch : esm-get-source

created branch time in 2 months

push eventzys-contrib/node

cjihrig

commit sha b0d4eb37c728d36f6942c878d253607e4323b66e

tools: update ESLint to 7.4.0 Update ESLint to 7.4.0 PR-URL: https://github.com/nodejs/node/pull/34205 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 375166290681b209c7465d250dcd1e95543945f5

deps: upgrade to libuv 1.38.1 Notable changes: - A probable compiler bug in VS2019 was causing a failed assertion in libuv which appeared to the user as though the system clock was drifting. The `uv_hrtime()` code on Windows has been rearranged to work around the issue. - On Linux, `uv_loadavg()` attempts to read from `/proc/loadavg` before falling back to calling `sysinfo()`. This works around a bug in LXC. - A deadlock in the Windows TTY code has been fixed. - An issue on macOS related to monotonic clocks jumping back in time has been worked around. PR-URL: https://github.com/nodejs/node/pull/34187 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

view details

Robert Nagy

commit sha 4e3f6f355b892d047e7e5a8ef5a65fb189e47f89

stream: cleanup and fix Readable.wrap Cleans up Readable.wrap and also ensures destroy is called for certain events. PR-URL: https://github.com/nodejs/node/pull/34204 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha a98426a771957ce37792e4666b3606e55df2adf7

test: add issue ref for known_issues test PR-URL: https://github.com/nodejs/node/pull/34267 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha ac6ecd6b7f5949950d600de21488440f9f98c961

doc: reword warnings about sockets passed to subprocesses Make the docs more concise. Make warnings direct ("do not use" and "should") rather than "is not recommended" or "is recommended". PR-URL: https://github.com/nodejs/node/pull/34273 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Rich Trott

commit sha 62c44af5c5f2964849bba92ff90c32e867d63f83

doc: move sebdeckers to emeritus Confirmed in email with sebdeckers that they can be moved to emeritus. PR-URL: https://github.com/nodejs/node/pull/34298 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha f9402b23fd0eeae317af593498c3434e984310ae

src: add GetCipherValue function This commit extracts the code that is the same in GetCipherName, GetCipherStandardName, and GetCipherVersion into function named GetCipherValue. The motivation for this change is to improve readabilty by removing the duplicated code. PR-URL: https://github.com/nodejs/node/pull/34287 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha eabe22b73371e59838f5ff501804aca3aae9f4a9

src: use FromMaybe instead of ToLocal in GetCert PR-URL: https://github.com/nodejs/node/pull/34276 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Mateusz Krawczuk

commit sha 2e6c3e2301cb443a72c3659fffa24815b4660815

tls: make 'createSecureContext' honor more options Added options: `ticketKeys` and `sessionTimeout`, that are honored by `createServer`, that calls `createSecureContext`. This also introduces a minor code simplification. PR-URL: https://github.com/nodejs/node/pull/33974 Fixes: https://github.com/nodejs/node/issues/20908 Reviewed-By: Alba Mendez <me@alba.sh> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

view details

Michaël Zasso

commit sha 913d36d97da187a3804f6cfa96b4d24a8b7be78a

build: recommend Python 3.8 to build on Windows PR-URL: https://github.com/nodejs/node/pull/34182 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Michaël Zasso

commit sha 12478684aab233942e0d5dc24f195930c8a5e59d

deps: update V8 to 8.4.371.19 PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha eba5aafae007a859986bb19238ed5d8e97b879f6

build: reset embedder string to "-node.0" PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Michaël Zasso

commit sha b7cf8234100b0527cae325b5470f03dd137e3a94

src: update NODE_MODULE_VERSION to 86 Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.4. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>

view details

Refael Ackermann

commit sha 95743dcd2501f104ecce104bdc9bf91932bd4b92

deps: V8: un-cherry-pick bd019bd Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=​machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Ujjwal Sharma

commit sha b78847c99acd2f5342a1d40f422a24ab420a127f

deps: patch V8 to run on older XCode versions Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 34d8c079886efeae41ba190559da98fbd313e3a2

deps: V8: patch register-arm64.h Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Refael Ackermann

commit sha 5682e6eed74a9c9f6b185c0e9472e08345a9d356

deps: V8: forward declaration of `Rtl*FunctionTable` This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Joao Reis

commit sha b1456e3a7bee9733720081843711cc943f031abc

deps: make v8.h compatible with VS2015 There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Michaël Zasso

commit sha 106a4f4be5e07de364083cea5b995a82044faf16

deps: V8: silence irrelevant warnings PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Matheus Marchini

commit sha edaa56bb60eac20554de807cfcd9d873081b0ab6

deps: patch V8 to run on Xcode 8 Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by: Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 2 months

push eventzys-contrib/node

James M Snell

commit sha bfbdc84738e87e0aa067b067e4b68cabbe75a793

timers: allow promisified timeouts/immediates to be canceled Using the new experimental AbortController... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33833 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Robert Nagy

commit sha 16116f5f5f96b6d4295eda34e0cbf9c9e687ad29

quic: remove noop code this.unidirectional depends on #id which is never set in the constructor, hence this condition will never run and can be removed. PR-URL: https://github.com/nodejs/node/pull/33914 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

view details

James M Snell

commit sha d7d79f2163b9c7585d187769142da1ca1fa096be

quic: avoid memory fragmentation issue Original PR: https://github.com/nodejs/quic/pull/388 Previously, QuicPacket was allocating an std::vector<uint8_t> of NGTCP2_MAX_PKT_SIZE bytes, then the packet would be serialized into the buffer, and the std::vector would be resized based on the number of bytes serialized. I suspect the memory fragmentation that you're seeing is because of those resize operations not freeing memory in chunks that are aligned with the allocation. This changes QuicPacket to use a stack allocation that is always NGTCP2_MAX_PKT_SIZE bytes and the size of the serialized packet is just recorded without any resizing. When the memory is freed now, it should be freed in large enough chunks to cover subsequent allocations. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33912 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Benjamin Gruenbaum

commit sha ea866dc81b81a71f6ff4c9cb44f8953ce5b398a6

events: use property, primordials PR-URL: https://github.com/nodejs/node/pull/33775 Fixes: https://github.com/nodejs/node/issues/33773 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha 9dcde529a47011c67e928a15f900198ba52637ee

doc: specify default encoding in writable.write Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33765 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Pranshu Srivastava

commit sha ddfed6916829aa56814e3d8b125d59d61cf4bd4b

doc: link readable._read in stream.md Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/33767 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Stephen Belanger

commit sha 56967afdcab0b3c2dbcd120a0a761a041961754d

deps: V8: cherry-pick eec10a2fd8fa Original commit message: [promisehook] Add before/after hooks to thenable tasks This will allow Node.js to properly track async context in thenables. Change-Id: If441423789a78307a57ad7e645daabf551cddb57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Gus Caplan <me@gus.host> Cr-Commit-Position: refs/heads/master@{#68207} Refs: https://github.com/v8/v8/commit/eec10a2fd8fa4d0e7f5e32dedbd239d938a5dd87 PR-URL: https://github.com/nodejs/node/pull/33778 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Daniel Bevenius

commit sha 1bd88a3ac6df409f03842c0c45d3710914a6b2c6

quic: fix up node_quic_stream includes This commit removes the unused <array> and <limits> includes, and adds <memory> (for std::unique_ptr), and <utility> (for std::move). PR-URL: https://github.com/nodejs/node/pull/33921 Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Daniel Bevenius

commit sha 88ef15812ce09d28187114d04a9c43076d945a92

quic: remove unused string include http3_application PR-URL: https://github.com/nodejs/node/pull/33926 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Sarat Addepalli

commit sha f0fb511e3ba9a80618ddb616c1678d046246fe4f

dgram: allow typed arrays in .send() PR-URL: https://github.com/nodejs/node/pull/22413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

rickyes

commit sha 9918bdf5cb07f58d230522244a372cbb1b510956

lib: replace charCodeAt with fixed Unicode PR-URL: https://github.com/nodejs/node/pull/32758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>

view details

Rich Trott

commit sha d1d412b413d2f8febb1795459ff04c36c9c87f2c

doc: use sentence-case for headings in docs PR-URL: https://github.com/nodejs/node/pull/33889 Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings Refs: https://docs.microsoft.com/en-us/style-guide/capitalization Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 563062eddf3ee9582730b6ef61c439b6cfb2d849

doc: standardize on sentence case for headers Previously, our documentation headers were a mixture of title case, sentence case, and things that were neither. For technical documentation, the _de facto_ standard seems to be sentence case. (See refs below.) So let's standardize on that. This commit follows a commit implementing this standard. This commit adds it to the style guide. Refs: https://developers.google.com/style/capitalization#capitalization-in-titles-and-headings Refs: https://docs.microsoft.com/en-us/style-guide/capitalization PR-URL: https://github.com/nodejs/node/pull/33889 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha 2899588f28f4d02a61a19ecc8454ddaf14c7b6b3

src: simplify alignment-handling code Use a common function to handle alignment computations in multiple places. PR-URL: https://github.com/nodejs/node/pull/33884 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Anna Henningsen

commit sha 52de4cb107a6fc1a06f7c98f4fd36c7f7fd539d5

src: minor updates to FastHrtime - Don’t use 12 as a magic number for the buffer size - Mark the object as weak (which is conceptually the right thing to do, even if there is little practical impact) - Keep a reference to the `ArrayBuffer` in question for memory tracking PR-URL: https://github.com/nodejs/node/pull/33851 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Ruben Bridgewater

commit sha 2c4864762d2b97a55ef15fe44b7691d67de51766

util: gracefully handle unknown colors This makes sure colors that are unknown won't cause an error. This is especially important in case a library wants to use colors defined by Node.js core, if available and fall back to the default otherwise. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33797 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Stephen Belanger

commit sha 59e6230a30954f78836048b581d8db61582242ef

async_hooks: callback trampoline for MakeCallback PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Stephen Belanger

commit sha 646e5a471766e27e8317bb54d1fd1d2c72cffb69

domain: remove native domain code With the async_hooks callback trampoline, domains no longer need any native code. With this, domains can exist in pure JavaScript. PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

view details

Michaël Zasso

commit sha a86a295fd7162a7fdf406a21b3c3c679819c60b5

lib: remove NodeError from the prototype of errors with code Signed-off-by: Michaël Zasso <targos@protonmail.com> PR-URL: https://github.com/nodejs/node/pull/33857 Refs: https://github.com/nodejs/node/pull/33770 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Gus Caplan

commit sha 8f000ea09f6ee20b50cb83e6f7b2cb25671ef6f2

deps: V8: cherry-pick 767e65f945e7 Original commit message: [API] Fix microtask message reporting RunSingleMicrotask calls Runtime::ReportMessage, but the implementation of ReportMessage would unconditionally discard these exceptions. This CL removes all of the intermediate logic and directly calls MessageHandler::ReportMessage, restoring the ability of RunSingleMicrotask to report exceptions that occur in microtasks. Bug: v8:8326 Change-Id: I493de74383b2ab191d786611fb9eba9d27e7a243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162121 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67630} Refs: https://github.com/v8/v8/commit/767e65f945e7caa4becc2bd4b5e9ea8562da0ca4 PR-URL: https://github.com/nodejs/node/pull/33859 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

create barnchzys-contrib/node

branch : debug/node-main-process

created branch time in 2 months

issue commentnodejs/node

REPL throws on requiring a package with `exports` field

Look like this was fixed by #32261.

JLHwung

comment created time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+102 -40

0 comment

9 changed files

pull[bot]

pr closed time in 2 months

push eventzys-contrib/node

Robert Nagy

commit sha 849d9e7b90ebaae930a28a7994b3a56ec4f280c6

http: provide keep-alive timeout response header In http 1.1 persistent connection protocol there is a timing race where the client sends the request and then the server kills the connection (due to inactivity) before receiving the client's request. By providing a keep-alive header it is possible to provide the client a hint of when idle timeout would occur and avoid the race. Fixes: https://github.com/nodejs/node/issues/34560 PR-URL: https://github.com/nodejs/node/pull/34561 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>

view details

Mary Marchini

commit sha 4268c6112feaf82d7ca171c381b269ebfcf403f7

build: fix auto-start-ci script path PR-URL: https://github.com/nodejs/node/pull/34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Mary Marchini

commit sha 9b6c16c5acb4e47794fec4f2c7aa4d79fecda46d

build: don't run auto-start-ci on push PR-URL: https://github.com/nodejs/node/pull/34588 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Derek Lewis

commit sha 45fa216ee533abc189d4b9bf0fc8f40430af7ef4

esm: fix hook mistypes and links to types Prior to this commit, the custom loader hooks were: * missing the Node.js API ref docs types * missing the function signature from their sections * linking directly to the specification (not customary) * had an inconsistent non-nullable JSDoc promise return * had JSDoc object properties that weren't alpha-sorted * designated set of non-nullable types when single was fine Notes: https://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D PR-URL: https://github.com/nodejs/node/pull/34240 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

Rich Trott

commit sha aeaf16194bac6510a48019b4b55481006f11f714

doc: revise N-API versions matrix text Revise text for clarity, brevity, and conformance with our style guide. PR-URL: https://github.com/nodejs/node/pull/34566 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 73d713b16e764a2b52028803e14ce4ed8343a0a5

test: change Fixes: to Refs: Tests don't fix things generally, so use "Refs:" to refer people to GitHub issues. PR-URL: https://github.com/nodejs/node/pull/34568 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 2 months

startedtc39/proposal-Number.range

started time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+55 -24

0 comment

5 changed files

pull[bot]

pr closed time in 2 months

push eventzys-contrib/node

Rich Trott

commit sha 2d2a812645db794698abec602a10366e41305b98

test: remove unneeded flag check in test-vm-memleak The `common` module checks that necessary flags are being used, so a check in the test itself is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/34528 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Gus Caplan

commit sha dc00a07426f0b2dee9bfe39c766a703eb9b5b880

Revert "module: disable cjs snapshotting into esm loader" This reverts commit 1fe39f0b4bad8da38e5f02542c176d5999ad3ecb. PR-URL: https://github.com/nodejs/node/pull/34562 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>

view details

push time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+140 -67

0 comment

8 changed files

pull[bot]

pr closed time in 2 months

push eventzys-contrib/node

Ruy Adorno

commit sha 168b22ba073ee1cbf8d0bcb4ded7ff3099335d04

2020-07-29, Version 14.7.0 (Current) Notable changes: deps: * upgrade npm to 6.14.7 (claudiahdz) https://github.com/nodejs/node/pull/34468 dgram: * (SEMVER-MINOR) add IPv6 scope id suffix to received udp6 dgrams (Pekka Nikander) https://github.com/nodejs/node/pull/14500 doc: * add AshCripps to collaborators (AshCripps) https://github.com/nodejs/node/pull/34494 * add HarshithaKP to collaborators (Harshitha K P) https://github.com/nodejs/node/pull/34417 * add rexagod to collaborators (Pranshu Srivastava) https://github.com/nodejs/node/pull/34457 * add release key for Richard Lau (Richard Lau) https://github.com/nodejs/node/pull/34397 events: * (SEMVER-MINOR) expand NodeEventTarget functionality (Anna Henningsen) https://github.com/nodejs/node/pull/34057 src: * (SEMVER-MINOR) allow preventing SetPromiseRejectCallback (Shelley Vohr) https://github.com/nodejs/node/pull/34387 * (SEMVER-MINOR) allow setting a dir for all diagnostic output (AshCripps) https://github.com/nodejs/node/pull/33584 worker: * (SEMVER-MINOR) make MessagePort inherit from EventTarget (Anna Henningsen) https://github.com/nodejs/node/pull/34057 zlib: * switch to lazy init for zlib streams (Andrey Pechkurov) https://github.com/nodejs/node/pull/34048 PR-URL: https://github.com/nodejs/node/pull/34542

view details

Michael Dawson

commit sha 15333ad552b3e81cc325f31c9920ea7bbb07be0c

doc: clarify N-API version 1 Refs: https://github.com/nodejs/node-addon-api/issues/760 Clarify which version of 8.x in which N-API version 1 matches the shape in later versions like 10.x Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/34344 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

Guy Bedford

commit sha 1fe39f0b4bad8da38e5f02542c176d5999ad3ecb

module: disable cjs snapshotting into esm loader PR-URL: https://github.com/nodejs/node/pull/34467 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

view details

Gireesh Punathil

commit sha 4692e284e305e3ec2418f7f5005bed8d3e62ad11

lib: absorb `path` error cases Absorb low level libuv failure in the process initialization phase Fixes: https://github.com/nodejs/node/issues/33759 Refs: https://github.com/nodejs/node/issues/33759#issuecomment-663980558 PR-URL: https://github.com/nodejs/node/pull/34519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>

view details

push time in 2 months

startedgetredash/redash

started time in 2 months

startedanuraghazra/github-readme-stats

started time in 2 months

PR merged zys-contrib/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+5562 -5726

0 comment

345 changed files

pull[bot]

pr closed time in 2 months

more