profile
viewpoint
ZYSzys ZYSzys @nodejs Hangzhou, China https://twitter.com/ZYSzys_ Node.js Core Collaborator.

hustcc/canvas-nest.js 3362

:cancer: Interactive Particle / Nest System With JavaScript and Canvas, no jQuery.

ZYSzys/awesome-captcha 352

:key: Curated list of awesome captcha libraries and crack tools.

ZYSzys/Mzitu_Spider 10

:truck:一只爬取mzitu.com美女图片的小爬虫,不说了赶紧上车~

ZYSzys/commodity-management-system 8

:convenience_store:简易商品管理系统(Commodity Management System)

ZYSzys/generator-nm-boilerplate 3

:clipboard: Boilerplate for scaffold out a node module.

ZYSzys/github-personal-stars 3

:star: Count your personal repos' total stars.

ZYSzys/react-sharing 3

:earth_asia: Simple react social media sharing.

ZYSzys/NeteaseMusicAnalysis 2

网易云音乐数据分析[Deprecated]

ZYSzys/SendEmail 2

发送带压缩包附件的邮件小脚本~~by Python

ZYSzys/cmd-trans 1

Translate something in the command line.

startedAlvin9999/new-pac

started time in 2 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+10 -10

0 comment

4 changed files

pull[bot]

pr closed time in 2 days

push eventzys-contribs/node

Samuel Attard

commit sha 093639614fa1cea7a1bc3493d28119a924c97bc9

doc: claim ABI version 82 for Electron 10 PR-URL: https://github.com/nodejs/node/pull/31778 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 26e49d83323c78e89b2664b6eeaee90757d52868

worker: unroll file extension regexp Refs: https://github.com/nodejs/node/pull/31662#discussion_r377016190 PR-URL: https://github.com/nodejs/node/pull/31779 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jeff

commit sha e028ea0291b845e4bec3c7cff7319a027b8c815e

doc: fix typos in doc/api/https.md PR-URL: https://github.com/nodejs/node/pull/31793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Jeremiah Senkpiel

commit sha 4d6c861800cc6ac1dc6a0fd9d3a8b0053baec62a

doc: move @Fishrock123 to a previous releaser I have not done a release in well over a year, maybe even two. I also don't really plan to do more, as Node.js releases are very tedious. PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 928c210a611fb6b4575843708e7cb921f311ebde

doc: move @Fishrock123 to TSC Emeriti It was a good run. Almost 5 years. I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'. I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me. (So long and thanks for all the fish!) PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 30e6049c75590dec8d5edbf033edbc20e79efcb7

doc: pronouns for @Fishrock123 might as well while I'm at it feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gireesh Punathil

commit sha 4c746a6cfda980c1cd0de6246781c0083d9e416c

doc: move gireeshpunathil to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/31770 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

push time in 2 days

startedevanw/esbuild

started time in 3 days

startedsindresorhus/execa

started time in 4 days

startedwhatwg/html

started time in 4 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+457 -256

0 comment

102 changed files

pull[bot]

pr closed time in 5 days

push eventzys-contribs/node

Robert Nagy

commit sha 087583741716969edf12874d4f1f1774de581f50

stream: fix async iterator destroyed error order There was an edge case where if _destroy calls the error callback later than one tick the iterator would complete early and not propgate the error. PR-URL: https://github.com/nodejs/node/pull/31314 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/31700 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 5 days

push eventzys-contribs/node

Ben Noordhuis

commit sha b32fa7bcc69aec0acb63792c799a22eeae7424c6

src: add ExclusiveAccess class Similar to Rust's `std::sync::Mutex` in that it requires one to unwrap the object before accessing it, acquiring the mutex in the process. PR-URL: https://github.com/nodejs/node/pull/31717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Ben Noordhuis

commit sha 303e2fdc598cbc82af401f12f3cc9169ed31598b

src: wrap HostPort in ExclusiveAccess I found it exceedingly hard to figure out if there is a race condition where one thread reads the inspector agent's HostPort's properties while another modifies them concurrently. I think the answer is "no, there isn't" but with this commit use sites are forced to unwrap the object (and acquire the mutex in the process), making it a great deal easier to reason about correctness. PR-URL: https://github.com/nodejs/node/pull/31717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 481fa1ca989a36f850f844f1df50a6db0cfb1dd3

util: add coverage for util.inspect.colors alias setter Add test to confirm that the setter for aliases in `util.inspect.colors` keeps the alias reference-equal to the target value. Refs: https://coverage.nodejs.org/coverage-5b0308cd823a5110/lib/internal/util/inspect.js.html#L357 Refs: https://codecov.io/gh/nodejs/node/src/5b0308cd823a511098dadf9ddd5a35e3a9dbb424/lib/internal/util/inspect.js#L357 PR-URL: https://github.com/nodejs/node/pull/31743 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha a18b437e6a6115e30309a1f200f614e27e650aa4

util: throw if unreachable TypedArray checking code is reached If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: https://github.com/nodejs/node/pull/31737 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Rich Trott

commit sha a3eb6f2b5255d87ea5e207598ef87be5be204eba

meta: move calvinmetcalf to emeritus calvinmetcalf confirmed in email that moving to emeritus seemed like the right move for them right now. Move a separate entry that wasn't in the correct place in the list. PR-URL: https://github.com/nodejs/node/pull/31736 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>

view details

Rich Trott

commit sha c3cebf55129d5337cc446163d63ae1405069595c

meta: move vkurchatkin to emeritus vkurchatkin confirmed in email that it's time to move to emeritus. PR-URL: https://github.com/nodejs/node/pull/31729 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Rich Trott

commit sha ff82b76ff044ea66f2f7155a1b154e333b827b6d

meta: move princejwesley to emeritus princejwesley confirmed in email that moving to emeritus at this time was appropriate. PR-URL: https://github.com/nodejs/node/pull/31730 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Tobias Nießen

commit sha 09b6894fe8b5eb8a0625effdc701d6da765078ab

doc: update foundation name in onboarding PR-URL: https://github.com/nodejs/node/pull/31719 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha 5e41765f47a4dfb519047428026dff9be4f7e0a9

doc: expand C++ README with information about exception handling Add more information about why it is advisable not to use `.FromJust()` etc. on Maybe(Local)s, and general information about termination exceptions. PR-URL: https://github.com/nodejs/node/pull/31720 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Danielle Adams

commit sha e5e011d9bc71c7d651db47950a5af0e738f68784

doc: add directions to mark a release line as lts Moves directions for LTS release from the Release repo to Node docs. Fixes: https://github.com/nodejs/Release/issues/530 PR-URL: https://github.com/nodejs/node/pull/31724 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Rich Trott

commit sha d5650418762ed3562db8f7fabbca575a2fde35a5

test: improve test-fs-stat-bigint Remove magic number and measure amount of difference should be allowable between consecutive stat() calls. PR-URL: https://github.com/nodejs/node/pull/31726 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 9da57a86ee7d9cb7b27ab8fa9ee241dc047bbd0e

test: fix flaky parallel/test-repl-history-navigation test Two scenarios should be tested: 1. The completion is triggered and the result is printed before the next invocation. 2. The completion is triggered multiple times right after each other without waiting for the result. In that case only the last result should be printed. The first scenario did not need a timeout while the latter did not need a timeout for the second invocation. PR-URL: https://github.com/nodejs/node/pull/31708 Fixes: https://github.com/nodejs/node/issues/31094 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Denys Otrishko

commit sha bc55b57e64a374e5b677644c857c3d26247c72ef

lib: fix few comment typos in fs/watchers.js PR-URL: https://github.com/nodejs/node/pull/31705 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha b9a7625fdf0a8217195300f5a8844b6da1a5a35a

stream: removed outdated TODO Was resolved in https://github.com/nodejs/node/commit/e559842188f541b884abff2ffad4d2d3e1b841a6. PR-URL: https://github.com/nodejs/node/pull/31701 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Andrey Pechkurov

commit sha 26cb448b0d74fa6440ca77ca83b1adba6cc50a87

doc: fix default server timeout description for https PR-URL: https://github.com/nodejs/node/pull/31692 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Ujjwal Sharma

commit sha 917914112341da2de7215d304dcc1bf33184e53b

doc: update contact email for @ryzokuken Update my personal email address from usharma1998@gmail.com (tired) to ryzokuken@disroot.org (wired). PR-URL: https://github.com/nodejs/node/pull/31670 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

view details

Juan José Arboleda

commit sha 94eb0f907bd4023c4ed4647b38d049be8c1c8826

doc: fix typo on fs docs PR-URL: https://github.com/nodejs/node/pull/31620 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Antoine du HAMEL

commit sha 611a158f1ad53720b0ca2bf30f42abb3c2fe0c47

worker: add support for .cjs extension PR-URL: https://github.com/nodejs/node/pull/31662 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

Ujjwal Sharma

commit sha 9e805b1fbf3ae7658dfbf2aca22d6d2f1e099474

doc: add prerequisites information for Arch Add prerequisites for Arch Linux and derivatives in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/31669 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Alex Ramirez

commit sha d0ed4310412e0848a8b071cb04b49e22e9a633a5

benchmark: swap var for let in benchmarks In benchmark directory this changes for loops using var to let when it applies for consistency PR-URL: https://github.com/nodejs/node/pull/28958 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 5 days

delete branch zys-contribs/node

delete branch : fs-test

delete time in 6 days

delete branch zys-contribs/node

delete branch : fs-refactor

delete time in 6 days

delete branch zys-contribs/node

delete branch : fs-promise-validate-before-open

delete time in 6 days

PR closed nodejs/node

fs: validate the input data before opening file author ready fs

Now running python tools/test.py test/parallel/test-fs-append-file in our master branch, there was a file called foobar generated, which was caused by this line:

https://github.com/nodejs/node/blob/fb437c49cf52a1519f5f079afce6214bae61dacb/test/parallel/test-fs-append-file.js#L143

This was because firstly we opened foobar file and then validating the input data in our fs.promise module.

So I think the more reasonable method is validating the input data first and then opening the file, to be consistent with fs module.

Refs: https://github.com/nodejs/node/pull/31030

/cc @BridgeAR

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+28 -9

3 comments

2 changed files

ZYSzys

pr closed time in 6 days

pull request commentnodejs/node

fs: validate the input data before opening file

Landed in 3e9302b2b3.

ZYSzys

comment created time in 6 days

push eventnodejs/node

ZYSzys

commit sha 3e9302b2b34ab0309de8eda45c17efc8fd9cc2f5

fs: validate the input data before opening file PR-URL: https://github.com/nodejs/node/pull/31731 Refs: https://github.com/nodejs/node/pull/31030 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

view details

push time in 6 days

startedokonet/lint-staged

started time in 7 days

push eventzys-contribs/node

Myles Borins

commit sha 1c11ea43883256b6bc9e64a28bbc22f88c5c2b38

2020-02-11, Version 12.16.0 'Erbium' (LTS) Notable changes: New assert APIs The `assert` module now provides experimental `assert.match()` and `assert.doesNotMatch()` methods. They will validate that the first argument is a string and matches (or does not match) the provided regular expression This is an experimental feature. Ruben Bridgewater [#30929](https://github.com/nodejs/node/pull/30929). Advanced serialization for IPC The `child_process` and `cluster` modules now support a `serialization` option to change the serialization mechanism used for IPC. The option can have one of two values: * `'json'` (default): `JSON.stringify()` and `JSON.parse()` are used. This is how message serialization was done before. * `'advanced'`: The serialization API of the `v8` module is used. It is based on the HTML structured clone algorithm. and is able to serialize more built-in JavaScript object types, such as `BigInt`, `Map`, `Set` etc. as well as circular data structures. Anna Henningsen [#30162](https://github.com/nodejs/node/pull/30162). CLI flags The new `--trace-exit` CLI flag makes Node.js print a stack trace whenever the Node.js environment is exited proactively (i.e. by invoking the `process.exit()` function or pressing Ctrl+C). legendecas [#30516](https://github.com/nodejs/node/pull/30516). ___ The new `--trace-uncaught` CLI flag makes Node.js print a stack trace at the time of throwing uncaught exceptions, rather than at the creation of the `Error` object, if there is any. This option is not enabled by default because it may affect garbage collection behavior negatively. Anna Henningsen [#30025](https://github.com/nodejs/node/pull/30025). ___ The `--disallow-code-generation-from-strings` V8 CLI flag is now whitelisted in the `NODE_OPTIONS` environment variable. Shelley Vohr [#30094](https://github.com/nodejs/node/pull/30094). New crypto APIs For DSA and ECDSA, a new signature encoding is now supported in addition to the existing one (DER). The `verify` and `sign` methods accept a `dsaEncoding` option, which can have one of two values: * `'der'` (default): DER-encoded ASN.1 signature structure encoding `(r, s)`. * `'ieee-p1363'`: Signature format `r || s` as proposed in IEEE-P1363. Tobias Nießen [#29292](https://github.com/nodejs/node/pull/29292). ___ A new method was added to `Hash`: `Hash.prototype.copy`. It makes it possible to clone the internal state of a `Hash` object into a new `Hash` object, allowing to compute the digest between updates. Ben Noordhuis [#29910](https://github.com/nodejs/node/pull/29910). Dependency updates libuv was updated to 1.34.0. This includes fixes to `uv_fs_copyfile()` and `uv_interface_addresses()` and adds two new functions: `uv_sleep()` and `uv_fs_mkstemp()`. Colin Ihrig [#30783](https://github.com/nodejs/node/pull/30783). ___ V8 was updated to 7.8.279.23. This includes performance improvements to object destructuring, RegExp match failures and WebAssembly startup time. The official release notes are available at https://v8.dev/blog/v8-release-78. Michaël Zasso [#30109](https://github.com/nodejs/node/pull/30109). New EventEmitter APIs The new `EventEmitter.on` static method allows to async iterate over events. Matteo Collina [#27994](https://github.com/nodejs/node/pull/27994). ___ It is now possible to monitor `'error'` events on an `EventEmitter` without consuming the emitted error by installing a listener using the symbol `EventEmitter.errorMonitor`. Gerhard Stoebich [#30932](https://github.com/nodejs/node/pull/30932). ___ Using `async` functions with event handlers is problematic, because it can lead to an unhandled rejection in case of a thrown exception. The experimental `captureRejections` option in the `EventEmitter` constructor or the global setting change this behavior, installing a `.then(undefined, handler)` handler on the `Promise`. This handler routes the exception asynchronously to the `Symbol.for('nodejs.rejection')` method if there is one, or to the `'error'` event handler if there is none. Setting `EventEmitter.captureRejections = true` will change the default for all new instances of `EventEmitter`. This is an experimental feature. Matteo Collina [#27867](https://github.com/nodejs/node/pull/27867). Performance Hooks are no longer experimental The `perf_hooks` module is now considered a stable API. legendecas [#31101](https://github.com/nodejs/node/pull/31101). Introduction of experimental WebAssembly System Interface (WASI) support A new core module, `wasi`, is introduced to provide an implementation of the [WebAssembly System Interface](https://wasi.dev/) specification. WASI gives sandboxed WebAssembly applications access to the underlying operating system via a collection of POSIX-like functions. This is an experimental feature. Colin Ihrig [#30258](https://github.com/nodejs/node/pull/30258). PR-URL: https://github.com/nodejs/node/pull/31691

view details

Matteo Collina

commit sha 9fdb6e6aaf45b2364bac89a8f240772f49503ee6

async_hooks: add executionAsyncResource Remove the need for the destroy hook in the basic APM case. Co-authored-by: Stephen Belanger <admin@stephenbelanger.com> PR-URL: https://github.com/nodejs/node/pull/30959 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 3eba33eb07353b8b642792d928425b4c4977767e

util: throw if unreachable code is reached If a comparison code path that is supposed to be unreachable is reached, throw. Add a c8 comment to ignore coverage for the line, as it should be unreachable. PR-URL: https://github.com/nodejs/node/pull/31712 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

push time in 7 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1167 -59

0 comment

22 changed files

pull[bot]

pr closed time in 7 days

push eventzys-contribs/node

ZYSzys

commit sha 8c7e8c22ca932fb48f768d5ac7bd36cbd15560ab

fixup! fs: validate the input data before opening file

view details

push time in 8 days

create barnchzys-contribs/node

branch : fs-test

created branch time in 8 days

push eventzys-contribs/node

Rich Trott

commit sha 7e386295c553a009edfa21aa66596919f2612863

doc: improve strict assertion mode color text Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: https://github.com/nodejs/node/pull/31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 8 days

PR opened nodejs/node

fs: validate the input data before opening file

Now running python tools/test.py test/parallel/test-fs-append-file in our master branch, there was a file called foobar generated, which was caused by this line:

https://github.com/nodejs/node/blob/fb437c49cf52a1519f5f079afce6214bae61dacb/test/parallel/test-fs-append-file.js#L143

This was because firstly we opened foobar file and then validating the input data in our fs.promise module.

So I think the more reasonable method is validating the input data first and then opening the file, to be consistent with fs module.

Refs: https://github.com/nodejs/node/pull/31030

/cc @BridgeAR

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+25 -8

0 comment

2 changed files

pr created time in 8 days

push eventzys-contribs/node

Duncan Healy

commit sha acfb78b5319bf44cdf368e3b2b9d7caca75d0dd6

test: fix flaky test-fs-stat-bigint Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: https://github.com/nodejs/node/issues/24593 PR-URL: https://github.com/nodejs/node/pull/30437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha fb437c49cf52a1519f5f079afce6214bae61dacb

test: remove flaky designation for test-fs-stat-bigint PR-URL: https://github.com/nodejs/node/pull/30437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

ZYSzys

commit sha 34177022cf0fd30bdce46b2467ec4ce06544b001

fs: validate the input data before opening file

view details

push time in 8 days

push eventzys-contribs/node

ZYSzys

commit sha ee4b6b1f471795c099f86c0c02d621b145121a90

fs: validate the input data before opening file

view details

push time in 8 days

push eventzys-contribs/node

ZYSzys

commit sha 9e8e45213912ffe7fb63de52c05cae999a4f19ca

fs: validate the input data before opening file

view details

push time in 8 days

push eventzys-contribs/node

ZYSzys

commit sha ef073eb55798456baf4d2cabcbcc2075046a66e9

fs: validate the input data before opening file

view details

push time in 8 days

push eventzys-contribs/node

ZYSzys

commit sha ecb96a2a0846d3eab8ae749494cecc3a1df089f8

fixup!

view details

push time in 8 days

create barnchzys-contribs/node

branch : fs-promise-validate-before-open

created branch time in 8 days

push eventzys-contribs/node

Brian White

commit sha b862a0c6d69bac6e7deaf7c53802a5d3bc05099e

benchmark: check for and fix multiple end() PR-URL: https://github.com/nodejs/node/pull/31624 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Brian White

commit sha 43783b5b3fa0a0d477ae34aeb0405956fb534dc4

stream: improve writable.write() performance PR-URL: https://github.com/nodejs/node/pull/31624 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Brian White

commit sha 74291e4a7ba6185c1b78a110538ed3db3bc6b244

buffer: improve from() performance PR-URL: https://github.com/nodejs/node/pull/31615 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha b70741ea438b4df01cca416949a22e9350b58258

benchmark: refactor helper into a class This is the basis to refactor the helper to use modern class language features such as private fields. It also refactors the exports to use module.exports. That way it's immediately clear what parts are exported. PR-URL: https://github.com/nodejs/node/pull/31396 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha dac579516ca662e731ac502c15e75009a2b9a8c9

benchmark: add `test` and `all` options and improve errors This adds a new `test` option. Using it automatically uses a single minimal option matrix to verify the benchmark works as expected. Using the new `all` option makes sure all test suites are run. On top of that the benchmarks will from now on report properly what category might have a typo, if any. The http duration was also refactored to use a option instead of relying on a configuration setting. The fixture folder is ignored as test suite from now on. PR-URL: https://github.com/nodejs/node/pull/31396 Fixes: https://github.com/nodejs/node/issues/31083 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 78aa348f4e0c504cf949aea73a8e1bdcedc7f8b0

test: refactor all benchmark tests to use the new test option PR-URL: https://github.com/nodejs/node/pull/31396 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 357230f4b7174380467edfb0a65a00b65b0af66c

benchmark: remove special test entries It was necessary to have fallbacks to run the original tests. This is obsolete with the new test mode. PR-URL: https://github.com/nodejs/node/pull/31396 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Ruben Bridgewater

commit sha 1450ea7bf608a54640863e5ba23c6f0ce430e14f

test: improve logged errors To indicate which lines are test lines and which from Node.js core, it's good to rely on `util.inspect()` while inspecting errors. The stack was accessed directly instead in multiple cases and logging that does not provide as much information as using `util.inspect()`. PR-URL: https://github.com/nodejs/node/pull/31425 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yihong Wang <yh.wang@ibm.com>

view details

Ruben Bridgewater

commit sha 36f328e21fe19f9767e1bc04481bdd921ab49615

assert: align character indicators properly This makes sure color codes are not taken into account in case util.inspect's default value was changed. PR-URL: https://github.com/nodejs/node/pull/31429 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 0f6fed4f070391563c40a6c88d25deb734785274

test: stricter assert color test Make sure the assertion is actually triggered by using `assert.throws()` instead of `try/catch`. PR-URL: https://github.com/nodejs/node/pull/31429 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ruben Bridgewater

commit sha 63f10b9f0da0539b499a076f2951526ecae8260a

tty: do not end in an infinite warning recursion It was possible that this warning ends up in an infinite recursion. The reason is that printing the warning triggered a color check and that triggered another warning. Limiting it to a single warning prevents this. PR-URL: https://github.com/nodejs/node/pull/31429 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

cjihrig

commit sha efec6811b667b6cf362d648bc599b667eebffce0

readline: remove intermediate variable This commit removes an extrea intermediate variable. This makes the call consistent with other uses of validateUint32() in the codebase. PR-URL: https://github.com/nodejs/node/pull/31676 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha cd0f5a239e5c0d1f6fd374741173d62d2df64340

doc: update pr-url for DEP0016 EOL Refs: https://github.com/nodejs/node/pull/31167 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

cjihrig

commit sha 17e3f3be763cb440bb315911f3e926044ddb128c

doc: update pr-url for DEP0022 EOL Refs: https://github.com/nodejs/node/pull/31169 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

cjihrig

commit sha a2d6f98e1a4b43bdd57fdfa253e3a13c6dcbe09c

doc: fix typo Refs: https://github.com/nodejs/node/pull/31169 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

cjihrig

commit sha 009a9c475b70d2c35a176ba20514034238024d53

doc,src,test: assign missing deprecation code PR-URL: https://github.com/nodejs/node/pull/31674 Refs: https://github.com/nodejs/node/pull/28396 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha 743c28104f3db504963409e8e91700e430131221

test,dns: add coverage for dns exception Add test coverage for dns.promises.resolve() handling an exception from c-ares. Refs: https://coverage.nodejs.org/coverage-d213f21c72f77da6/lib/internal/dns/promises.js.html#L198 PR-URL: https://github.com/nodejs/node/pull/31678 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Anna Henningsen

commit sha 0649225be47647b63a029ba3b64eadc517b06d05

test: fix flaky test-trace-sigint-on-idle Previously, the test could fail on slow machines because the child process was still in the process of starting up after one second, and not yet idle. To resolve this: - Wait for a message from the child process indicating that it had started. - Wait some time after that, but make it platform-dependent to account for timing differences. - Remove the timer in the child process. PR-URL: https://github.com/nodejs/node/pull/31645 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 6f14db4cbf4e34d8e6ddb8c8eb0cbd1d458dd21d

doc,net: reword Unix domain path paragraph in net.md Reword the paragraph on Unix domain paths. Hopefully, it is a little bit more clear and easier to read now. PR-URL: https://github.com/nodejs/node/pull/31684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Rich Trott

commit sha d0413ae8f92aa0591506ff115f21ec0ae2591e62

doc,util: revise util.md introductory paragraph Minor edits to improve introductory test for util module documentation. PR-URL: https://github.com/nodejs/node/pull/31685 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 9 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+702 -864

0 comment

141 changed files

pull[bot]

pr closed time in 9 days

push eventzys-contribs/node

Robert Nagy

commit sha 234de6f1fd90ece1edc1a12d989ab0f15a1f19b8

stream: fix finished w/ 'close' before 'finish' Emitting 'close' before 'finish' on a Writable should result in a premature close error. PR-URL: https://github.com/nodejs/node/pull/31534 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha c1da4e4aa4583c14f87c8d230ce7580f3b157ff0

src: fix inspecting `MessagePort` from `init` async hook During the `init()` async hook, the C++ object is not finished creating yet (i.e. it is an `AsyncWrap`, but not yet a `HandleWrap` or `MessagePort`). Accessing the `handle_` field is not valid in that case. However, the custom inspect function for `MessagePort`s calls `HasRef()` on the object, which would crash when the object is not fully constructed. Fix that by guarding the access of the libuv handle on that condition. PR-URL: https://github.com/nodejs/node/pull/31600 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Conor ONeill

commit sha 7e911d8b03a838e5ac6bb06c5b313533e89673ef

doc: add example to fs.promises.readdir PR-URL: https://github.com/nodejs/node/pull/31552 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

James M Snell

commit sha 907c07fa850e128c695482cd47554b5bce5e4b0c

stream: move _writableState.buffer to EOL API was deprecated back in the 0.11 days. PR-URL: https://github.com/nodejs/node/pull/31165 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

view details

James M Snell

commit sha bffa5044c576003198ccfee5a751c23036d0744f

crypto: move pbkdf2 without digest to EOL API has been being incrementally deprecated since 6.0.0 PR-URL: https://github.com/nodejs/node/pull/31166 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ec0dd6fa1cfa03b3983419acedb27ef95d297c82

lib: move GLOBAL and root aliases to EOL GLOBAL and root have been long deprecated. PR-URL: https://github.com/nodejs/node/pull/31167 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

James M Snell

commit sha ab4115f17cf2859f336b3c0588d2bf9eca0e65b8

os: move tmpDir() to EOL The tmpDir alias was deprecated in 7.0.0 PR-URL: https://github.com/nodejs/node/pull/31169 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

view details

Joyee Cheung

commit sha 0effc9845f74e7351487644cbd1691196000b93e

doc: ask more questions in the bug report template Inspired by the defect report template of the V8 issue tracker PR-URL: https://github.com/nodejs/node/pull/31611 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Beth Griggs

commit sha f0f2583c912d4c7abf6fb5a9ccd380976f1ab092

2020-02-06, Version 13.8.0 (Current) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/196

view details

Beth Griggs

commit sha e65ae4278578e51761bf9253a7c68ade0f9b897c

2020-02-06, Version 12.15.0 'Erbium' (LTS) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/197

view details

Beth Griggs

commit sha d602e586bf2baf5889586bde8e072e556db2b273

2020-02-06, Version 10.19.0 'Dubnium' (LTS) This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/198

view details

James M Snell

commit sha e001710219906b45bb5ac94d7e9cb4b56a83c134

meta: fix collaborator list errors in README.md Add missing `-` characters in the list. PR-URL: https://github.com/nodejs/node/pull/31655 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Anna Henningsen

commit sha 06a43d4dcacc0c39506b8a3a1bb77411add6d9d7

test: fix flaky test-http2-stream-destroy-event-order Alternative to https://github.com/nodejs/node/pull/31590. It appears that the issue here is that the test falsely assumed that closing the client (which also currently destroys the socket rather than gracefully shutting down the connection) would still leave enough time for the server side to receive the stream error. Address that by explicitly waiting for the server side to receive the stream error before closing the client and the connection with it. Refs: https://github.com/nodejs/node/pull/31590 Refs: https://github.com/nodejs/node/issues/20750 PR-URL: https://github.com/nodejs/node/pull/31610 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Sam Roberts

commit sha f8e75512951b5060409b0c80e246ffc81ee9e72e

benchmark: support optional headers with wrk wrk did not support sending optional headers, they were silently ignored. This appears to be an oversight, they were supported for autocannon. PR-URL: https://github.com/nodejs-private/node-private/pull/189 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Sam Roberts

commit sha fe3975783cc4fdba47c2e25442ca891aab31e805

http: strip trailing OWS from header values HTTP header values can have trailing OWS, but it should be stripped. It is not semantically part of the header's value, and if treated as part of the value, it can cause spurious inequality between expected and actual header values. Note that a single SPC of leading OWS is common before the field-value, and it is already handled by the HTTP parser by stripping all leading OWS. It is only the trailing OWS that must be stripped by the parser user. header-field = field-name ":" OWS field-value OWS ; https://tools.ietf.org/html/rfc7230#section-3.2 OWS = *( SP / HTAB ) ; https://tools.ietf.org/html/rfc7230#section-3.2.3 Fixes: https://hackerone.com/reports/730779 PR-URL: https://github.com/nodejs-private/node-private/pull/189 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Fedor Indutny

commit sha 861d3f7a61f543c253337cfc1a967fa84f96c653

crypto: fix assertion caused by unsupported ext `X509V3_EXT_print` can return value different from `1` if the X509 extension does not support printing to a buffer. Instead of failing with an unrecoverable assertion - replace the relevant value in the hashmap with a JS null value. Fixes: https://hackerone.com/reports/746733 PR-URL: https://github.com/nodejs-private/node-private/pull/175 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Beth Griggs

commit sha 4c5b8dd7d80b6010c4d3e914f7e8c61cc297a1ad

deps: update llhttp to 2.0.4 PR-URL: https://github.com/nodejs-private/node-private/pull/199 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Sam Roberts

commit sha efd5a6b2eda54dd846d2bdf34f64d34701411d0e

test: using TE to smuggle reqs is not possible See: https://hackerone.com/reports/735748 PR-URL: https://github.com/nodejs-private/node-private/pull/199 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

view details

Rich Trott

commit sha a9e26268f5b464f508a033129c1ffaa694e5d361

doc,assert: rename "mode" to "assertion mode" Rename "strict mode" in the assert module to "strict assertion mode". This is to avoid confusion with the more typical meaning of "strict mode" in ECMAScript. This necessitates a corresponding change of "legacy mode" to "legacy assertion mode". PR-URL: https://github.com/nodejs/node/pull/31635 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Gabriel Schulhof

commit sha 884e287199901853a30781a0b398e6c3e4a07eb1

n-api: free instance data as reference Instance data associated with a `napi_env` is no longer stored on the env itself but is instead rendered as a reference. Since `v8impl::Reference` is tied to a JS object, this modification factors out the `v8impl::Reference` refcounting and the deletion process into a base class for `v8impl::Reference`, called `v8impl::RefBase`. The instance data is then stored as a `v8impl::RefBase`, along with other references, preventing a segfault that arises from the fact that, up until now, upon `napi_env` destruction, the instance data was freed after all references had already been forcefully freed. If the addon freed a reference during the `napi_set_instance_data` finalizer callback, such a reference had already been freed during environment teardown, causing a double free. Re: https://github.com/nodejs/node-addon-api/pull/663 PR-URL: https://github.com/nodejs/node/pull/31638 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 12 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1174 -552

0 comment

42 changed files

pull[bot]

pr closed time in 12 days

startedSamVerschueren/tsd

started time in 13 days

startedmongodb/mongo

started time in 13 days

startedhighcharts/highcharts

started time in 14 days

startedrecharts/recharts

started time in 14 days

startedgoogle/styleguide

started time in 14 days

startedGoogleChromeLabs/quicklink

started time in 14 days

startedgoogle/WebFundamentals

started time in 14 days

startedChromeDevTools/devtools-frontend

started time in 14 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+66 -102

0 comment

11 changed files

pull[bot]

pr closed time in 16 days

push eventzys-contribs/node

ConorDavenport

commit sha 99c8c6d80ff97ac7d53e01722142ac37756aabf1

src: remove duplicate field env in CryptoJob class Removed field env from cryptojob class, replaced with function env() inherited from ThreadPoolWork PR-URL: https://github.com/nodejs/node/pull/31554 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Sam Roberts

commit sha dbaa4ca166a5da08f933ec99eee5f41b740bd13c

test: simplify test-https-simple.js It had an unused `Agent` option (no such option exists), and some code that common.must(Not)Call makes redundant. PR-URL: https://github.com/nodejs/node/pull/31584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha f7a1ef6fb51f814223e3c26fffb9d39b08f91b1b

benchmark: clean up config resolution in multiple benchmarks This removes 'to Number' casting in multiple benchmarks (which is handled by the benchmark runner) and cleans up some var usage in changed benchmarks. PR-URL: https://github.com/nodejs/node/pull/31581 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 16 days

startedcli/cli

started time in 18 days

startedFiloSottile/mkcert

started time in 20 days

startedtc39/proposal-object-iteration

started time in 21 days

push eventzys-contribs/node

Robert Nagy

commit sha 90e6e18f33d1f0f9e4d9775ee283b9a5f2642959

stream: add async iterator support for v1 streams PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha a6d63c44a2b3273d4e09576c52011e3197d6a4b3

stream: normalize async iterator stream destroy PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 2c54459378039199d8362b3109908a0dd29aa2b3

stream: implement throw for async iterator PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha c6bf9539cc1645fe768bff6ce2eee85636d341a7

stream: simplify pipeline PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 07915db233dcb03ea9586086cc4f599b96fa9000

stream: re-use legacy destroyer PR-URL: https://github.com/nodejs/node/pull/31316 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

cjihrig

commit sha a2f9ccd3d2bffc6f72f02acf7fc4813c670a64ed

deps: uvwasi: cherry-pick 7b5b6f9 Original commit message: allow windows to detect tty types uv_fs_fstat() fails on TTYs on Windows. This commit updates uvwasi__get_filetype_by_fd() to detect this case and map the fd to the WASI character device type. Refs: https://github.com/nodejs/node/issues/31461 Fixes: https://github.com/nodejs/node/issues/31461 PR-URL: https://github.com/nodejs/node/pull/31495 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Brian White

commit sha 886965963ac55825e91887e973226ef010f8fc64

deps: switch to chromium's zlib implementation This implementation provides optimizations not included upstream. PR-URL: https://github.com/nodejs/node/pull/31201 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

view details

Brian White

commit sha 59cba9a5c20c4a9fee34a3f6601025666aa6f9f6

buffer: improve fill(number) performance PR-URL: https://github.com/nodejs/node/pull/31489 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Justin Ridgewell

commit sha 0214b90308404b18efd60ce07cb89014073ee161

process: fix two overflow cases in SourceMap VLQ decoding These both have to do with extremely large numbers, so it's unlikely to cause a problem in practice. Still, correctness. First, encoding `-2147483648` in VLQ returns the value `"B"`. When decoding, we get the value `1` after reading the base64. We then check if the first bit is set (it is) to see if we should negate it, then we shift all bits right once. Now, `value` will be `0` and `negate` will be `true`. So, we'd return `-0`. Which is a bug! `-0` isn't `-2147483648`, and we've broken a round trip. Second, encoding any number with the 31st bit set, we'd return the opposite sign. Let's use `1073741824`. Encoding, we get `"ggggggC"`. When decoding, we get the value `-2147483648` after reading the base64. Notice, it's already negative (the 32nd bit is set, because the 31st was set and we shifted everything left once). We'd then check the first bit (it's not) and shift right. But we used `>>`, which does not shift the sign bit. We actually wanted `>>>`, which will. Because of that bug, we get back `-1073741824` instead of the positive `1073741824`. It's even worse if the 32nd and 31st bits are set, `-1610612736` becomes `536870912` after a round trip. I recently fixed the same two bugs in Closure Compiler: https://github.com/google/closure-compiler/commit/584418eb PR-URL: https://github.com/nodejs/node/pull/31490 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>

view details

Richard Lau

commit sha 8e245cd4e31628def8e886302619b3f033f2f636

build: build docs in GitHub Actions CI workflow PR-URL: https://github.com/nodejs/node/pull/31504 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

bcoe

commit sha f2842904c2b6ea2e770f9b3d38115c958fa55c22

fs: bail on permission error in recursive directory creation When creating directories recursively, the logic should bail immediately on UV_EACCES and bubble the error to the user. PR-URL: https://github.com/nodejs/node/pull/31505 Fixes: https://github.com/nodejs/node/issues/31481 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Anna Henningsen

commit sha a5d4a397d63871dee3bfd5f174b64e41bc878be0

test: make test-http2-buffersize more correct Previously, this code could have closed the server before the connection was actually received by the server, as the `'close'` event on the client side can be emitted before the connection is established. The following commit exacerbates this problem, so fix the test first. PR-URL: https://github.com/nodejs/node/pull/31502 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Anna Henningsen

commit sha 78743f8e3912fa04670ceab5365f081b3079507b

src: simplify native immediate queue running Make `SetImmediate()` behave more like `process.nextTick()` (which matches how we use it) by also running tasks that have been added during previous `SetImmediate()` calls. PR-URL: https://github.com/nodejs/node/pull/31502 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

legendecas

commit sha 7b7e7bd185aa606cf2845747dd3844a9b12ec9ab

src,lib: make ^C print a JS stack trace If terminating the process with ctrl-c / SIGINT, prints a JS stacktrace leading up to the currently executing code. The feature would be enabled under option `--trace-sigint`. Conditions of no stacktrace on sigint: - has (an) active sigint listener(s); - main thread is idle (i.e. uv polling), a message instead of stacktrace would be printed. PR-URL: https://github.com/nodejs/node/pull/29207 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Christopher Hiller <boneskull@boneskull.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Brian White

commit sha 59a1981a226045bce30aeb2889b29c829c285a80

crypto: improve randomBytes() performance PR-URL: https://github.com/nodejs/node/pull/31519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Justin Ridgewell

commit sha f2ec64fbcff03753a3e1afd9f5fc9bffd805263d

lib: delete dead code in SourceMap This seems to be a leftover from the chromium project. Nothing uses `#reverseMappingsBySourceURL`, so constructing it isn't necessary. PR-URL: https://github.com/nodejs/node/pull/31512 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

kenzo-spaulding

commit sha 3d456b1868939b0d6aae8698f969abc802525090

doc: update maintaining-V8.md Updated to conform to style guide. PR-URL: https://github.com/nodejs/node/pull/31503 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

XhmikosR

commit sha 70c32a6d190e2b5d7b9ff9d5b6a459d14e8b7d59

doc: remove redundant properties from headers PR-URL: https://github.com/nodejs/node/pull/31492 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Robert Nagy

commit sha b851d7b98644bc81adcd905dbebda102eeedd888

stream: fix finished writable/readable state writable/readable does not indicate whether as stream is a Writable/Readable. This implements a better check for whether a object is a Writable/Readable. PR-URL: https://github.com/nodejs/node/pull/31527 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Denys Otrishko

commit sha 2462a2c5d7b5ae7e28a0fdefdf4fd5e8eb0ff5ed

src: fix ignore GCC -Wcast-function-type for older compilers Fixes: https://github.com/nodejs/node/issues/31517 PR-URL: https://github.com/nodejs/node/pull/31524 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in 21 days

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+12400 -39995

0 comment

349 changed files

pull[bot]

pr closed time in 21 days

startedmicrosoft/playwright

started time in a month

startednodejs/node

started time in a month

push eventzys-contribs/node

Matheus Marchini

commit sha cf5624c4d8f16397c6d12aaf13bcc3ecfe10b8fe

test: add promises metadata to postmortem test type_JSPromise__JS_PROMISE_TYPE and type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to identify Promises in memory and core dumps: https://github.com/nodejs/llnode/pull/272. Add these to our postmortem test so we're aware of any changes to this metadata. PR-URL: https://github.com/nodejs/node/pull/31357 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Harshitha KP

commit sha e43ee3712fd21710d6da07c4b7892fd1aa84d5e9

doc: explain `hex` encoding in Buffer API fixes: https://github.com/nodejs/node/issues/29786 refs: https://github.com/nodejs/node/pull/29792 refs: https://github.com/nodejs/node/issues/24491 PR-URL: https://github.com/nodejs/node/pull/31352 Fixes: https://github.com/nodejs/node/issues/29786 Refs: https://github.com/nodejs/node/pull/29792 Refs: https://github.com/nodejs/node/issues/24491 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 12ff6164985979505c97a07de224ccfa0aea6119

deps,test: update to uvwasi 0.0.4 This commit updates the uvwasi dependency to version 0.0.4. The most notable change is a refactor of the way paths are resolved. All paths, including symlinks, are now resolved in terms of sandboxed paths instead of leaking host system paths. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha 87ffc6e4a422d54194d8825da95694382b8bbcd0

deps: port uvwasi@676ba9a to gyp This commit ports https://github.com/cjihrig/uvwasi/commit/676ba9a from CMake to gyp. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

cjihrig

commit sha d43e94548253e49769126c62c59fc40e2993583f

deps: uvwasi: cherry-pick 941bedf Original commit message: https://github.com/cjihrig/uvwasi/commit/20fd9e2 was accidentally reverted in https://github.com/cjihrig/uvwasi/pull/73. This commit relands it. PR-URL: https://github.com/nodejs/node/pull/31363 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Anna Henningsen

commit sha 3199996de3cfd08b01a674dbe6c2b5522a183dbb

doc: correct added version for --abort-on-uncaught-exception PR-URL: https://github.com/nodejs/node/pull/31360 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

himself65

commit sha e588ed7391fb2a92b3936e0011d6fbe0df903fc2

doc: fix a broken link in fs.md PR-URL: https://github.com/nodejs/node/pull/31373 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 7b78ff04283e735d421d7dce4433969c5a71e2e8

stream: support passing generator functions into pipeline() PR-URL: https://github.com/nodejs/node/pull/31223 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ben Noordhuis

commit sha cc0748f509140b7b42d157348300a5581db98a37

test: export public symbols in addons tests Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: https://github.com/nodejs/node/pull/28647 Refs: https://github.com/nodejs/node-gyp/pull/1828 PR-URL: https://github.com/nodejs/node/pull/28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Anna Henningsen

commit sha 7864c53629b11d69746a4fc1f041900eeb358d31

fs: unset FileHandle fd after close - Do not set the fd as a property on the native object. - Use the already-existent `GetFD()` method to pass the fd from C++ to JS. - Cache the fd in JS to avoid repeated accesses to the C++ getter. - Set the fd to `-1` after close, thus reliably making subsequent calls using the `FileHandle` return `EBADF`. Fixes: https://github.com/nodejs/node/issues/31361 PR-URL: https://github.com/nodejs/node/pull/31389 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Matheus Marchini

commit sha b3189266347fa05395860f9f6e8949e447977284

test: update postmortem test with v12 constants Ref: https://github.com/nodejs/llnode/pull/330 PR-URL: https://github.com/nodejs/node/pull/31391 Refs: https://github.com/nodejs/llnode/pull/330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+1001 -150

0 comment

23 changed files

pull[bot]

pr closed time in a month

startedremarkjs/remark

started time in a month

startedamireh/happypack

started time in a month

startedpikapkg/snowpack

started time in a month

startedfullcalendar/fullcalendar

started time in a month

startedmbasso/awesome-wasm

started time in a month

startedtc39/proposal-async-iteration

started time in a month

push eventzys-contribs/node

Sebastien Ahkrin

commit sha eca22d5565ced362b35c8f053b18f3b87f591a8d

lib: add Uint16Array primordials PR-URL: https://github.com/nodejs/node/pull/31210 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

push eventnodejs/node

Sebastien Ahkrin

commit sha eca22d5565ced362b35c8f053b18f3b87f591a8d

lib: add Uint16Array primordials PR-URL: https://github.com/nodejs/node/pull/31210 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

PR closed nodejs/node

lib: add Uint16Array primordials author ready util

Hello, For this PR I have added Uint16Array in the primordials eslint And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Uint16Array 
      message: "Use `const { Uint16Array } = primordials;` instead of the global."

And just add Uint16Array.

const {
  // [...]
  Uint16Array,
} = primordials;

I hope this new PR will help you :x

+3 -0

4 comments

2 changed files

Sebastien-Ahkrin

pr closed time in a month

pull request commentnodejs/node

lib: add Uint16Array primordials

Landed in eca22d5 .

Sebastien-Ahkrin

comment created time in a month

PR merged zys-contribs/quic

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+436 -54

0 comment

7 changed files

pull[bot]

pr closed time in a month

push eventzys-contribs/quic

James M Snell

commit sha 2a313e2f48ea7fe008bde7147066ad5348e3ceb8

deps: update ngtcp2 PR-URL: https://github.com/nodejs/quic/pull/276 Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a month

startedsofastack/sofa-rpc-node

started time in a month

issue openednodejs/node

repl: bug when the length of preview output is exactly equal to the terminal width

<!-- Thank you for reporting a possible bug in Node.js.

Please fill in as much of the template below as you can.

Version: output of node -v Platform: output of uname -a (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify the affected core module name

If possible, please provide code that demonstrates the problem, keeping it as simple and free of external dependencies as you can. -->

  • Version: master
  • Platform: macOS
  • Subsystem: repl

<!-- Please provide more details below this comment. -->

When the length of preview output is exactly equal to the terminal width, the cursor's position move to the end of current line, which seems to be a bug.

Kapture 2020-01-10 at 17 56 23

/cc @BridgeAR

created time in a month

startedpvdz/tenko

started time in a month

startedmikeal/reg

started time in a month

push eventzys-contribs/node

Ben Noordhuis

commit sha 93b0e39ce2bbbf35c0e77e6d4b8e0e2d909d21c4

src: remove uses of node::InitializeV8Platform() This requires minor changes to src/env.cc to deal with `node::tracing::AgentWriterHandle::GetTracingController()` now possibly returning a nullptr, because the cctest doesn't set one. It seems plausible to me that embedders won't set one either so that seems like an okay change to make. It avoids embedders having to track down nullptr segfaults. PR-URL: https://github.com/nodejs/node/pull/31245 Refs: https://github.com/nodejs/node/pull/31217 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Ben Noordhuis

commit sha cd4a41c92ed55fe71234f59362e4a334a3c43174

src: remove node::InitializeV8Platform() This API method was introduced in commit 90ae4bd0c9 ("src: add InitializeV8Platform function") from July 2018 but wasn't properly exported and therefore not usable on Windows or with shared library builds. The motivation from the commit log is mainly about making it easier to wire up the cctests and there are better ways to do that. Refs: https://github.com/nodejs/node/pull/31217 PR-URL: https://github.com/nodejs/node/pull/31245 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in a month

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+124 -123

0 comment

14 changed files

pull[bot]

pr closed time in a month

push eventzys-contribs/node

Andrew Hughes

commit sha 41dd175f6d55a665f4c10d3b66ba701507102265

doc: prefer server vs srv and client vs clt PR-URL: https://github.com/nodejs/node/pull/31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Andrew Hughes

commit sha b0f67f2fc72c8c0418c1caf1de860eace1fe5fe0

test: prefer server over srv PR-URL: https://github.com/nodejs/node/pull/31224 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

antsmartian

commit sha aff6fffec584eb08a6a5e774c5b613fcb073c94c

stream: clean up definition using defineProperties PR-URL: https://github.com/nodejs/node/pull/31236 Refs: https://github.com/nodejs/node/pull/31187 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

push eventzys-contribs/node

Sebastien Ahkrin

commit sha 607be0c78a6bd33a105d2a690f6e71264016252c

stream: replace Function.prototype with primordial PR-URL: https://github.com/nodejs/node/pull/31204 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

legendecas

commit sha b3b0ae565ab6155258eeae00b18e532f3303623d

benchmark: benchmarking impacts of async hooks on promises PR-URL: https://github.com/nodejs/node/pull/31188 Refs: https://github.com/nodejs/diagnostics/issues/124 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

gengjiawen

commit sha 85ef944f639532b230424b3c6b3a0c35caa80957

win: change to use Python in install tool PR-URL: https://github.com/nodejs/node/pull/31221 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Adam Majer

commit sha f2a089a754046c1bd950cebefd8bdb2960fdce32

test: fix unit test logging with python3 A logfile must be opened as a text file and encoding is specified. Then it can accept a string. Current behaviour we get, Message: 'ok 2834 sequential/test-worker-prof' Arguments: () --- Logging error --- Traceback (most recent call last): File "/usr/lib64/python3.7/logging/__init__.py", line 1037, in emit stream.write(msg + self.terminator) TypeError: a bytes-like object is required, not 'str' Call stack: File "tools/test.py", line 1734, in <module> sys.exit(Main()) File "tools/test.py", line 1710, in Main if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests): File "tools/test.py", line 933, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 141, in Run self.RunSingle(False, 0) File "tools/test.py", line 202, in RunSingle self.HasRun(output) File "tools/test.py", line 365, in HasRun logger.info(' ---') PR-URL: https://github.com/nodejs/node/pull/31156 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

view details

push time in a month

push eventzys-contribs/node

cjihrig

commit sha b8922e8924a3da170878c9982342258f5deb0a7f

wasi: improve use of primordials PR-URL: https://github.com/nodejs/node/pull/31212 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

push time in a month

startedfacebook/docusaurus

started time in a month

startedjanl/mustache.js

started time in a month

Pull request review commentnodejs/github-bot

labels: add "wasi" label

 tap.test('label: "libuv" when ./deps/uv/ files has been changed', (t) => {   t.end() }) +tap.test('label: "wasi" when ./deps/uv/ files has been changed', (t) => {

Fixed, Thanks !

ZYSzys

comment created time in a month

push eventzys-contribs/github-bot

ZYSzys

commit sha adb5eb3fb633c1fdc8e3e59b7ca467547f2e9d0b

fixup!

view details

push time in a month

startednodejs/github-bot

started time in a month

push eventzys-contribs/github-bot

ZYSzys

commit sha 592b8a63974d5385edcf17174fb667b2c3060f3d

labels: add "wasi" label

view details

push time in a month

PR opened nodejs/github-bot

labels: add "wasi" label
+11 -1

0 comment

2 changed files

pr created time in a month

create barnchzys-contribs/github-bot

branch : wasi

created branch time in a month

delete branch zys-contribs/node

delete branch : http2-enable-connect-protocol-2

delete time in a month

delete branch zys-contribs/node

delete branch : http2-enable-connect-protocol

delete time in a month

startedyewstack/yew

started time in a month

startedswc-project/swc

started time in a month

push eventzys-contribs/fastify

Robert Nagy

commit sha 62bc4b3845579e7ab8af2b5e11afcf5d11ec53f4

fix: premature close test (#1833) There was an incorrect test count on the premature close tests where it never actually tested whether 'close' was emitted. `'close'` is actually not emitted and to fix these test we need to increment the test count and instead listen for `'aborted'`.

view details

Matteo Collina

commit sha 39301d1275db5df87b6a1975a0a566f46bdf7f5d

Added Zeit Now docs (#1824)

view details

Manuel Spigolon

commit sha f5e3f33a7b4c6fc93d37f886044a7499dd29bf67

greenkeeper ignore @typescript-eslint/eslint-plugin (#1835)

view details

Matteo Collina

commit sha 667514db630b470d3d96b989bc66b29b2a1d0d15

Bumped v2.8.0

view details

Ryan Albon

commit sha db2f922161b72a7ed2eeaa83fab9eba19222b5c4

Improving Getting Started documentation (#1837)

view details

Dustin Deus

commit sha 120aa2e6095cccea7163c7b31be8239fc1a72d00

feat - Implement pluginName (#1836) * imlement pluginName * remove newline, improve test headline * add docs, build plugin name chain * improve docs * fix order * add test * Update docs/Server.md Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com> * improve tests

view details

Rafael Gonzaga

commit sha 6f27942e4852851d66339f91579c13798fd09a22

feature: add onResponse hook in route declaration (#1838)

view details

Michael Chris Lopez

commit sha 2d882e2edd8585dc9046c79345a6cecd4e5dc597

Fix eslint "no-misused-promises" error in hooks (#1843) * fix eslint "no-misused-promises" error in hooks * test hook async function typescript

view details

Chia Wei Ong

commit sha 90b5d338cc72e5ade1c97d8fbe1b3334e98503b6

Update Validation-and-Serialization.md (#1846)

view details

Zoron

commit sha 6b58e1cc91d8911c3a83d6ceaf4903afd35fa0ab

docs(Reply): fix Errors (#1848) add 'code' to error struct

view details

lw

commit sha 1d19738056e00d75af718c33f4f0d526ed09f3d2

First batch of documentation fixes (#1850) * docs(Benchmarking): Improve grammar * docs(ContentTypeParser): Improve grammar * docs(Decorators): Improve grammar * docs(Errors): Improve grammar * docs(FluentSchema): Improve grammar * docs(GettingStarted): Improve grammar * docs(Hooks): Improve grammar * docs(HTTP2): Improve grammar * docs(Logging): Improve grammar * docs(Middleware): Improve grammar * docs(PluginsGuide): Improve grammar * Update middleware docs link * Always put Content-Type in backticks * docs(Hooks): Fix typo

view details

Toru Nagashima

commit sha c288d1d5f78a3c1145f66c3bc3767682e5de720b

add FastifyReply#removeHeader method to fastify.d.ts (#1849) * add FastifyReply#removeHeader method to fastify.d.ts * add test * Update test/types/index.ts Co-Authored-By: Manuel Spigolon <behemoth89@gmail.com>

view details

Rich Trott

commit sha d365b8501563bd7223b7243efe448a7e74ab65bc

randomize file name in test (#1856) To avoid side effects from other processes, avoid using a predictable file name for the socket in the OS tmp directory.

view details

Nathan Woltman

commit sha ccdb1727a47ce9ef6329588c6b8fc722e8eb47e8

Move Nathan Woltman to Past Collaborators (#1857)

view details

Dustin Deus

commit sha 4db6471c401a603dca5505e40c6f1ada44c461ca

add github workflow for CI and website, (#1853) add github workflow for CI and website,remove travis

view details

Dustin Deus

commit sha b0dbdd3f523c5cc076c01b4b05143d03c71fc6dc

possible fixes (#1861) * possible fixes * generate lcov file for coveralls * run tests only one time * dont generate html report

view details

Dustin Deus

commit sha 8016bdda92b6216273bf13259f75cd45a408a068

fix (#1862)

view details

Dustin Deus

commit sha 44a40061e05c9c8226a8f75eb604a7e337391446

Fix/pkg manager ci (#1863) run script with package manager, install eslint as dev dep to avoid typescript-eslint error

view details

Dustin Deus

commit sha 1ba2d4d4ae9cd37d0ca818a974a0e0d90a45a930

install yarn and pnpm in the host env (#1865) * install yarn and pnpm in the host env * use pnpm to run test * fix typo

view details

Manuel Spigolon

commit sha 4858ff5e6497bfd9a5ae04fed9ef0cc1d55ec8de

Rules to contributing to plugins (#1842)

view details

push time in a month

PR merged zys-contribs/fastify

[pull] master from fastify:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+3550 -626

0 comment

71 changed files

pull[bot]

pr closed time in a month

push eventzys-contribs/node

ZYSzys

commit sha 8f7d363da6618300e9a960a97a5f853fd27da742

fixup! http2: add constants

view details

push time in a month

push eventzys-contribs/node

ZYSzys

commit sha 3e99eda4929f9b2d14eb14468a6cc2818fe4475c

fixup! http2: add constants

view details

push time in a month

create barnchzys-contribs/node

branch : http2-enable-connect-protocol-2

created branch time in a month

issue commentnodejs/node

http2 - allow option for setting the local window size of a session

IIUC, #26962 is a workaround.

CrucialDrew

comment created time in a month

pull request commentnodejs/node

http2: window size connection control

Ping @migounette , can you rebase and add some tests so that we can move forward ?

migounette

comment created time in a month

startedbytecodealliance/wasmtime

started time in a month

startedbasarat/typescript-book

started time in a month

PR closed ZengTianShengZ/resume-vue

remove vue-resource

Ref: #1

+1 -4

0 comment

2 changed files

ZYSzys

pr closed time in a month

PR merged zys-contribs/node

[pull] master from nodejs:master :arrow_heading_down: pull

See Commits and Changes for more details.


Created by <img src="https://prod.download/pull-18h-svg" valign="bottom"/> pull[bot]. Want to support this open source service? Please star it : )

+170 -140

0 comment

8 changed files

pull[bot]

pr closed time in a month

push eventzys-contribs/node

Ruben Bridgewater

commit sha f64842adebe5cc89039488d2e54a6dfc89cd56d3

doc: use code markup/markdown in headers This also allows us to remove backslash escaping for `[` and `]` inside of header code, which makes the bare markdown more readable. Refs: https://github.com/nodejs/node/pull/31086 PR-URL: https://github.com/nodejs/node/pull/31149 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Vighnesh Raut

commit sha fa946983cc56d8263b583d40cfa094771573421a

https: prevent options object from being mutated Previously, when passing options object to the agent.createConnection method, the same options object got modified within the method. Now, any modification will happen on only a copy of the object. Fixes: https://github.com/nodejs/node/issues/31119 PR-URL: https://github.com/nodejs/node/pull/31151 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Beth Griggs

commit sha d845915d46d21b01d5fdc46ab67402a25a4e6021

doc: mark Node.js 8 End-of-Life in CHANGELOG PR-URL: https://github.com/nodejs/node/pull/31152 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>

view details

push time in a month

push eventzys-contribs/node

ZYSzys

commit sha 8dfddd555a0e02bc3d00cb52f3d762c4898813ce

fixup!

view details

push time in 2 months

push eventzys-contribs/node

ZYSzys

commit sha 6b224dd0e8b17f99e023eeb20f94fa1872bf35ee

fixup!

view details

push time in 2 months

push eventzys-contribs/node

ZYSzys

commit sha 3c18d00f0fffd52e49cf38d17e85923b79e7f23f

fixup!

view details

push time in 2 months

push eventzys-contribs/node

ZYSzys

commit sha 44c94cc18e5277fbb5e09ab030c456c39a67f569

fixup!

view details

push time in 2 months

more