profile
viewpoint
Yasser Asmi YasserAsmi United States https://www.linkedin.com/in/yasserasmi/ Programmer at Microsoft

YasserAsmi/lev 38

Lightweight C++ wrapper for LibEvent 2 API

YasserAsmi/jvar 18

JS inspired Variants and JSON parsing for C++

MSRCCS/DLWorkspace 15

Deep Learning Workspace

YasserAsmi/regexp 3

Easier CPP interface to PCRE regex engine with global match and replace

YasserAsmi/buildmk 1

Simple and easy makefile setup for C++

YasserAsmi/libwebsock 0

C library for easy WebSockets server.

YasserAsmi/nativejson-benchmark 0

C/C++ JSON parser/generator benchmark

YasserAsmi/SublimeGDB 0

GDB integration with Sublime Text 2

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

Heya @amcasey, I'm starting to run the perf test suite on this PR at 9909496ab8827574d3cf1f0b6a3c178c60328b88. Hold tight - I'll update this comment with the log link once the build has been queued.

amcasey

comment created time in 2 minutes

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

@typescript-bot perf test this

amcasey

comment created time in 3 minutes

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

@amcasey The results of the perf run you requested are in! <details><summary> Here they are:</summary><p> <b>Comparison Report - master..41662</b> <table border="0" cellpadding="0" cellspacing="0" > <thead> <tr> <th align=left><sub>Metric</sub></th> <th align=right><sub>master</sub></th> <th align=right><sub>41662</sub></th> <th align=right><sub>Delta</sub></th> <th align=right><sub>Best</sub></th> <th align=right><sub>Worst</sub></th> </tr> </thead> <tr class="group"><th align=left colspan="6"><sub>Angular - node (v10.16.3, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>344,501k (± 0.03%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-344,501k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.99s (± 0.77%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-1.99s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.83s (± 0.58%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.83s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.97s (± 0.44%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-4.97s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>5.37s (± 0.68%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-5.37s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host0"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>13.15s (± 0.32%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-13.15s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Monaco - node (v10.16.3, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>354,721k (± 0.02%)</sub></td> <td align=right><sub>354,693k (± 0.03%)</sub></td> <td align=right><sub>-28k (- 0.01%)</sub></td> <td align=right><sub>354,508k</sub></td> <td align=right><sub>354,930k</sub></td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.61s (± 0.55%)</sub></td> <td align=right><sub>1.60s (± 0.45%)</sub></td> <td align=right><sub>-0.01s (- 0.50%)</sub></td> <td align=right><sub>1.59s</sub></td> <td align=right><sub>1.62s</sub></td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.73s (± 0.41%)</sub></td> <td align=right><sub>0.72s (± 0.47%)</sub></td> <td align=right><sub>-0.01s (- 0.69%)</sub></td> <td align=right><sub>0.72s</sub></td> <td align=right><sub>0.73s</sub></td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.13s (± 0.56%)</sub></td> <td align=right><sub>5.10s (± 0.61%)</sub></td> <td align=right><sub>-0.04s (- 0.74%)</sub></td> <td align=right><sub>5.03s</sub></td> <td align=right><sub>5.18s</sub></td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.81s (± 0.54%)</sub></td> <td align=right><sub>2.81s (± 0.61%)</sub></td> <td align=right><sub>-0.00s (- 0.04%)</sub></td> <td align=right><sub>2.77s</sub></td> <td align=right><sub>2.85s</sub></td> </tr> <tr class="measurement total scenario0 host0"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>10.29s (± 0.35%)</sub></td> <td align=right><sub>10.23s (± 0.38%)</sub></td> <td align=right><sub>-0.06s (- 0.55%)</sub></td> <td align=right><sub>10.15s</sub></td> <td align=right><sub>10.30s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>TFS - node (v10.16.3, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>307,856k (± 0.01%)</sub></td> <td align=right><sub>307,822k (± 0.02%)</sub></td> <td align=right><sub>-34k (- 0.01%)</sub></td> <td align=right><sub>307,650k</sub></td> <td align=right><sub>307,930k</sub></td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.24s (± 0.81%)</sub></td> <td align=right><sub>1.24s (± 0.67%)</sub></td> <td align=right><sub>-0.01s (- 0.64%)</sub></td> <td align=right><sub>1.22s</sub></td> <td align=right><sub>1.25s</sub></td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.68s (± 1.56%)</sub></td> <td align=right><sub>0.68s (± 0.59%)</sub></td> <td align=right><sub>+0.00s (+ 0.30%)</sub></td> <td align=right><sub>0.67s</sub></td> <td align=right><sub>0.69s</sub></td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.58s (± 0.46%)</sub></td> <td align=right><sub>4.57s (± 0.41%)</sub></td> <td align=right><sub>-0.01s (- 0.33%)</sub></td> <td align=right><sub>4.53s</sub></td> <td align=right><sub>4.61s</sub></td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.94s (± 0.92%)</sub></td> <td align=right><sub>2.92s (± 1.13%)</sub></td> <td align=right><sub>-0.02s (- 0.54%)</sub></td> <td align=right><sub>2.85s</sub></td> <td align=right><sub>3.01s</sub></td> </tr> <tr class="measurement total scenario0 host0"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>9.44s (± 0.51%)</sub></td> <td align=right><sub>9.41s (± 0.48%)</sub></td> <td align=right><sub>-0.03s (- 0.33%)</sub></td> <td align=right><sub>9.32s</sub></td> <td align=right><sub>9.51s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>material-ui - node (v10.16.3, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>489,326k (± 0.01%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-489,326k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.06s (± 0.47%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.06s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.65s (± 0.68%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.65s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>13.60s (± 0.69%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-13.60s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>0.00s (± 0.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s ( NaN%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host0"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>16.31s (± 0.57%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-16.31s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Angular - node (v12.1.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>322,386k (± 0.03%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-322,386k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.97s (± 0.76%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-1.97s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.81s (± 0.82%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.81s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.91s (± 1.11%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-4.91s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>5.49s (± 0.36%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-5.49s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host1"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>13.19s (± 0.53%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-13.19s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Monaco - node (v12.1.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>336,778k (± 0.01%)</sub></td> <td align=right><sub>336,834k (± 0.01%)</sub></td> <td align=right><sub>+56k (+ 0.02%)</sub></td> <td align=right><sub>336,725k</sub></td> <td align=right><sub>336,941k</sub></td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.59s (± 0.82%)</sub></td> <td align=right><sub>1.58s (± 0.65%)</sub></td> <td align=right><sub>-0.01s (- 0.75%)</sub></td> <td align=right><sub>1.55s</sub></td> <td align=right><sub>1.59s</sub></td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.71s (± 0.63%)</sub></td> <td align=right><sub>0.71s (± 1.15%)</sub></td> <td align=right><sub>-0.00s (- 0.28%)</sub></td> <td align=right><sub>0.69s</sub></td> <td align=right><sub>0.73s</sub></td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.94s (± 0.50%)</sub></td> <td align=right><sub>4.90s (± 0.43%)</sub></td> <td align=right><sub>-0.04s (- 0.77%)</sub></td> <td align=right><sub>4.85s</sub></td> <td align=right><sub>4.96s</sub></td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.86s (± 0.62%)</sub></td> <td align=right><sub>2.88s (± 1.16%)</sub></td> <td align=right><sub>+0.02s (+ 0.63%)</sub></td> <td align=right><sub>2.82s</sub></td> <td align=right><sub>2.99s</sub></td> </tr> <tr class="measurement total scenario0 host1"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>10.10s (± 0.39%)</sub></td> <td align=right><sub>10.06s (± 0.53%)</sub></td> <td align=right><sub>-0.03s (- 0.35%)</sub></td> <td align=right><sub>10.00s</sub></td> <td align=right><sub>10.25s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>TFS - node (v12.1.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>292,156k (± 0.02%)</sub></td> <td align=right><sub>292,097k (± 0.02%)</sub></td> <td align=right><sub>-59k (- 0.02%)</sub></td> <td align=right><sub>291,916k</sub></td> <td align=right><sub>292,258k</sub></td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.26s (± 0.75%)</sub></td> <td align=right><sub>1.25s (± 0.71%)</sub></td> <td align=right><sub>-0.01s (- 0.71%)</sub></td> <td align=right><sub>1.24s</sub></td> <td align=right><sub>1.28s</sub></td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.66s (± 0.76%)</sub></td> <td align=right><sub>0.66s (± 1.41%)</sub></td> <td align=right><sub>+0.00s (+ 0.46%)</sub></td> <td align=right><sub>0.64s</sub></td> <td align=right><sub>0.68s</sub></td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.53s (± 0.73%)</sub></td> <td align=right><sub>4.50s (± 0.54%)</sub></td> <td align=right><sub>-0.03s (- 0.68%)</sub></td> <td align=right><sub>4.44s</sub></td> <td align=right><sub>4.55s</sub></td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.97s (± 1.14%)</sub></td> <td align=right><sub>2.97s (± 0.90%)</sub></td> <td align=right><sub>+0.01s (+ 0.27%)</sub></td> <td align=right><sub>2.93s</sub></td> <td align=right><sub>3.06s</sub></td> </tr> <tr class="measurement total scenario0 host1"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>9.41s (± 0.61%)</sub></td> <td align=right><sub>9.39s (± 0.45%)</sub></td> <td align=right><sub>-0.02s (- 0.23%)</sub></td> <td align=right><sub>9.27s</sub></td> <td align=right><sub>9.47s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>material-ui - node (v12.1.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>467,325k (± 0.05%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-467,325k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.09s (± 0.59%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.09s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.64s (± 1.21%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.64s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>12.09s (± 0.67%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-12.09s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>0.00s (± 0.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s ( NaN%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host1"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>14.82s (± 0.56%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-14.82s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Angular - node (v8.9.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>347,048k (± 0.02%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-347,048k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.52s (± 0.53%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.52s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.87s (± 0.79%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.87s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.62s (± 0.56%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-5.62s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>6.36s (± 1.36%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-6.36s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host2"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>15.37s (± 0.74%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-15.37s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Monaco - node (v8.9.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>358,533k (± 0.02%)</sub></td> <td align=right><sub>358,558k (± 0.01%)</sub></td> <td align=right><sub>+26k (+ 0.01%)</sub></td> <td align=right><sub>358,412k</sub></td> <td align=right><sub>358,642k</sub></td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.94s (± 0.46%)</sub></td> <td align=right><sub>1.93s (± 0.19%)</sub></td> <td align=right><sub>-0.01s (- 0.62%)</sub></td> <td align=right><sub>1.92s</sub></td> <td align=right><sub>1.93s</sub></td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.91s (± 0.71%)</sub></td> <td align=right><sub>0.91s (± 0.54%)</sub></td> <td align=right><sub>+0.00s (+ 0.22%)</sub></td> <td align=right><sub>0.90s</sub></td> <td align=right><sub>0.92s</sub></td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.66s (± 0.46%)</sub></td> <td align=right><sub>5.62s (± 0.42%)</sub></td> <td align=right><sub>-0.04s (- 0.64%)</sub></td> <td align=right><sub>5.58s</sub></td> <td align=right><sub>5.68s</sub></td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>3.42s (± 0.83%)</sub></td> <td align=right><sub>3.42s (± 0.61%)</sub></td> <td align=right><sub>+0.01s (+ 0.29%)</sub></td> <td align=right><sub>3.36s</sub></td> <td align=right><sub>3.46s</sub></td> </tr> <tr class="measurement total scenario0 host2"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>11.92s (± 0.38%)</sub></td> <td align=right><sub>11.88s (± 0.31%)</sub></td> <td align=right><sub>-0.04s (- 0.33%)</sub></td> <td align=right><sub>11.78s</sub></td> <td align=right><sub>11.95s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>TFS - node (v8.9.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>310,419k (± 0.01%)</sub></td> <td align=right><sub>310,363k (± 0.01%)</sub></td> <td align=right><sub>-56k (- 0.02%)</sub></td> <td align=right><sub>310,283k</sub></td> <td align=right><sub>310,481k</sub></td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.58s (± 0.73%)</sub></td> <td align=right><sub>1.57s (± 0.30%)</sub></td> <td align=right><sub>-0.01s (- 0.63%)</sub></td> <td align=right><sub>1.56s</sub></td> <td align=right><sub>1.58s</sub></td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.69s (± 0.50%)</sub></td> <td align=right><sub>0.69s (± 0.48%)</sub></td> <td align=right><sub>+0.00s (+ 0.44%)</sub></td> <td align=right><sub>0.68s</sub></td> <td align=right><sub>0.70s</sub></td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.33s (± 0.36%)</sub></td> <td align=right><sub>5.33s (± 0.45%)</sub></td> <td align=right><sub>-0.00s (- 0.09%)</sub></td> <td align=right><sub>5.27s</sub></td> <td align=right><sub>5.38s</sub></td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.98s (± 0.69%)</sub></td> <td align=right><sub>2.96s (± 0.35%)</sub></td> <td align=right><sub>-0.02s (- 0.57%)</sub></td> <td align=right><sub>2.94s</sub></td> <td align=right><sub>2.98s</sub></td> </tr> <tr class="measurement total scenario0 host2"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>10.57s (± 0.39%)</sub></td> <td align=right><sub>10.55s (± 0.30%)</sub></td> <td align=right><sub>-0.03s (- 0.27%)</sub></td> <td align=right><sub>10.49s</sub></td> <td align=right><sub>10.63s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>material-ui - node (v8.9.0, x64)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>496,318k (± 0.01%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-496,318k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.50s (± 0.48%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.50s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.82s (± 1.52%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.82s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>18.15s (± 0.69%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-18.15s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>0.00s (± 0.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s ( NaN%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host2"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>21.48s (± 0.60%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-21.48s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Angular - node (v8.9.0, x86)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>198,970k (± 0.03%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-198,970k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.44s (± 0.92%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.44s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>1.02s (± 0.79%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-1.02s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.03s (± 0.38%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-5.03s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>6.14s (± 0.86%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-6.14s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host3"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>14.63s (± 0.43%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-14.63s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>Monaco - node (v8.9.0, x86)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>203,088k (± 0.03%)</sub></td> <td align=right><sub>203,071k (± 0.01%)</sub></td> <td align=right><sub>-17k (- 0.01%)</sub></td> <td align=right><sub>203,013k</sub></td> <td align=right><sub>203,135k</sub></td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.98s (± 0.74%)</sub></td> <td align=right><sub>1.97s (± 0.70%)</sub></td> <td align=right><sub>-0.01s (- 0.25%)</sub></td> <td align=right><sub>1.95s</sub></td> <td align=right><sub>2.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.72s (± 1.17%)</sub></td> <td align=right><sub>0.71s (± 0.51%)</sub></td> <td align=right><sub>-0.01s (- 0.70%)</sub></td> <td align=right><sub>0.71s</sub></td> <td align=right><sub>0.72s</sub></td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>5.74s (± 1.49%)</sub></td> <td align=right><sub>5.63s (± 1.96%)</sub></td> <td align=right><sub>-0.11s (- 1.88%)</sub></td> <td align=right><sub>5.38s</sub></td> <td align=right><sub>5.79s</sub></td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.82s (± 3.83%)</sub></td> <td align=right><sub>2.89s (± 4.16%)</sub></td> <td align=right><sub>+0.08s (+ 2.70%)</sub></td> <td align=right><sub>2.72s</sub></td> <td align=right><sub>3.15s</sub></td> </tr> <tr class="measurement total scenario0 host3"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>11.25s (± 0.34%)</sub></td> <td align=right><sub>11.21s (± 0.31%)</sub></td> <td align=right><sub>-0.04s (- 0.37%)</sub></td> <td align=right><sub>11.16s</sub></td> <td align=right><sub>11.30s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>TFS - node (v8.9.0, x86)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>177,494k (± 0.03%)</sub></td> <td align=right><sub>177,531k (± 0.03%)</sub></td> <td align=right><sub>+38k (+ 0.02%)</sub></td> <td align=right><sub>177,411k</sub></td> <td align=right><sub>177,667k</sub></td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>1.62s (± 1.64%)</sub></td> <td align=right><sub>1.62s (± 1.00%)</sub></td> <td align=right><sub>+0.01s (+ 0.31%)</sub></td> <td align=right><sub>1.60s</sub></td> <td align=right><sub>1.68s</sub></td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.65s (± 0.77%)</sub></td> <td align=right><sub>0.65s (± 0.46%)</sub></td> <td align=right><sub>+0.00s (+ 0.47%)</sub></td> <td align=right><sub>0.64s</sub></td> <td align=right><sub>0.65s</sub></td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>4.87s (± 0.42%)</sub></td> <td align=right><sub>4.86s (± 0.74%)</sub></td> <td align=right><sub>-0.02s (- 0.33%)</sub></td> <td align=right><sub>4.79s</sub></td> <td align=right><sub>4.94s</sub></td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>2.86s (± 0.65%)</sub></td> <td align=right><sub>2.83s (± 0.80%)</sub></td> <td align=right><sub>-0.03s (- 1.08%)</sub></td> <td align=right><sub>2.78s</sub></td> <td align=right><sub>2.89s</sub></td> </tr> <tr class="measurement total scenario0 host3"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>10.00s (± 0.37%)</sub></td> <td align=right><sub>9.96s (± 0.39%)</sub></td> <td align=right><sub>-0.04s (- 0.44%)</sub></td> <td align=right><sub>9.89s</sub></td> <td align=right><sub>10.07s</sub></td> </tr> </tbody> <tr class="group"><th align=left colspan="6"><sub>material-ui - node (v8.9.0, x86)</sub></th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left><sub>Memory used</sub></td> <td align=right><sub>279,452k (± 0.02%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>🟩-279,452k (-100.00%)</sub></td> <td align=right><sub>0k</sub></td> <td align=right><sub>0k</sub></td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left><sub>Parse Time</sub></td> <td align=right><sub>2.56s (± 0.62%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-2.56s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left><sub>Bind Time</sub></td> <td align=right><sub>0.75s (± 6.65%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-0.75s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left><sub>Check Time</sub></td> <td align=right><sub>16.60s (± 0.85%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-16.60s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left><sub>Emit Time</sub></td> <td align=right><sub>0.00s (± 0.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s ( NaN%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> <tr class="measurement total scenario0 host3"> <td align=left><sub>Total Time</sub></td> <td align=right><sub>19.91s (± 0.54%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>🟩-19.91s (-100.00%)</sub></td> <td align=right><sub>0.00s</sub></td> <td align=right><sub>0.00s</sub></td> </tr> </tbody> </table> <div> <b>System</b> <table cellpadding="0" cellspacing="0" border="0" > <tr><th align=right><sub>Machine Name</sub></th><td><sub>ts-ci-ubuntu</sub></td></tr> <tr><th align=right><sub>Platform</sub></th><td><sub>linux 4.4.0-166-generic</sub></td></tr> <tr><th align=right><sub>Architecture</sub></th><td><sub>x64</sub></td></tr> <tr><th align=right><sub>Available Memory</sub></th><td><sub>16 GB</sub></td></tr> <tr><th align=right><sub>Available Memory</sub></th><td><sub>1 GB</sub></td></tr> <tr><th align=right><sub>CPUs</sub></th><td><sub>4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz</sub></td></tr> </table> </div> <div> <b>Hosts</b> <ul> <li>node (v10.16.3, x64)</li> <li>node (v12.1.0, x64)</li> <li>node (v8.9.0, x64)</li> <li>node (v8.9.0, x86)</li> </ul> </div> <div> <b>Scenarios</b> <ul> <li>Angular - node (v10.16.3, x64)</li> <li>Angular - node (v12.1.0, x64)</li> <li>Angular - node (v8.9.0, x64)</li> <li>Angular - node (v8.9.0, x86)</li> <li>Monaco - node (v10.16.3, x64)</li> <li>Monaco - node (v12.1.0, x64)</li> <li>Monaco - node (v8.9.0, x64)</li> <li>Monaco - node (v8.9.0, x86)</li> <li>TFS - node (v10.16.3, x64)</li> <li>TFS - node (v12.1.0, x64)</li> <li>TFS - node (v8.9.0, x64)</li> <li>TFS - node (v8.9.0, x86)</li> <li>material-ui - node (v10.16.3, x64)</li> <li>material-ui - node (v12.1.0, x64)</li> <li>material-ui - node (v8.9.0, x64)</li> <li>material-ui - node (v8.9.0, x86)</li> </ul> </div> <div> <table cellspacing="0" cellpadding="0" border="0" > <tr> <th align=left><sub>Benchmark</sub></th> <th align=left><sub>Name</sub></th> <th align=left><sub>Iterations</sub></th> </tr> <tr> <td><sub>Current</sub></td> <td><sub>41662</sub></td> <td><sub>10</sub></td> </tr> <tr> <td><sub>Baseline</sub></td> <td><sub>master</sub></td> <td><sub>10</sub></td> </tr> </table> </div>

</p></details>

amcasey

comment created time in 4 minutes

issue commentelectron/electron

How can users help prioritize features?

Open source is largely volunteer-driven and collaborative. Because of this, time and energy to get things done are often the scarcest resources. We want Electron to be the best that it can be, but we also have to be realistic about what the team maintaining Electron can achieve. This means that:

  • We might not have an ETA for when an issue will get investigated or fixed.
  • Something you want implemented might not get implemented.
  • A change you want merged might not get merged.
  • Insisting on or making demands for any of the above is considered against the Electron Code of Conduct

For additional context, I'd read https://github.community/t/creators-contributors-and-collaborators/10219.

lacymorrow

comment created time in 4 minutes

PR opened atom/atom

Fix handling of "empty" language injections with Tree-sitter

Identify the Bug

https://github.com/atom/atom/issues/21093

There was a bug would occur in documents with language injections, where the injected document is empty. Examples include:

  • An empty string assigned to a node's innerHTML property in JavaScript. Usually, we highlight the contents of these strings as HTML.

    node.innerHTML = "";
    
  • An empty script tag in an HTML document. Usually, we would parse the tag's contents this script tag as JavaScript:

    <div>
      <script></script>
    </div>
    
  • In Ruby or JavaScript, a regular expression literal whose entire contents consist of escape sequences. Usually we highlight the contents of the regular expression using regex syntax:

    s.search /\n/
    

The bug would cause us to accidentally skip highlighting large sections of the document.

Description of the Change

These injected syntax trees are each associated with a Marker in the LanguageMode's injectionsMarkerLayer. This PR ensures that, when a language injection is empty, its marker is destroyed.

I also upgraded to the latest version of tree-sitter-rust in order to fix the last two issues mentioned in #21093, which were. unrelated, but easy to address.

Verification Process

Create files containing all of the code examples in #21093. See that the syntax highlighting is all correct. Edit this files in a variety of ways and see that syntax highlighting stays correct.

Release Notes

Fixed a syntax highlighting bug that caused inconsistent and missing highlighting in several languages.

+71 -10

0 comment

4 changed files

pr created time in 6 minutes

push eventcode-dot-org/code-dot-org

Jillian Khoo

commit sha 28e76428fd9205581d5c1afd153e896010b0b234

remove debug console when in readonly workspace

view details

Jillian Khoo

commit sha d29ce89849163916b8976f37370109f05504f75a

Merge pull request #37979 from code-dot-org/jk-applab-readonly-debug AppLab: remove debug console when in readonly workspace

view details

Pegasus

commit sha 495e0ed2e13e244bf0554e3198603ea4a06700c6

Merge pull request #37986 from code-dot-org/staging DTT (Staging > Test) [robo-dtt]

view details

push time in 11 minutes

PR opened code-dot-org/code-dot-org

DTT (Staging > Test) [robo-dtt]
+5 -2

0 comment

1 changed file

pr created time in 11 minutes

Pull request review commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

 namespace ts {                         if (maybeSuppress) {
                             overrideNextErrorInfo--;
                         }
-                        if (source.flags & TypeFlags.Object && target.flags & TypeFlags.Object) {
+                        if (sourceFlags & TypeFlags.Object && targetFlags & TypeFlags.Object) {

This is one of the incorrectly captured flags since target might have changed from a union to an object:

                if (target.flags & TypeFlags.Union && source.flags & TypeFlags.Object &&
                    (target as UnionType).types.length <= 3 && maybeTypeOfKind(target, TypeFlags.Nullable)) {
                    const nullStrippedTarget = extractTypesOfKind(target, ~TypeFlags.Nullable);
                    if (!(nullStrippedTarget.flags & (TypeFlags.Union | TypeFlags.Never))) {
                        if (source === nullStrippedTarget) return Ternary.True;
                        target = nullStrippedTarget;
                    }
                }
amcasey

comment created time in 12 minutes

push eventcode-dot-org/code-dot-org

Jillian Khoo

commit sha 28e76428fd9205581d5c1afd153e896010b0b234

remove debug console when in readonly workspace

view details

Jillian Khoo

commit sha d29ce89849163916b8976f37370109f05504f75a

Merge pull request #37979 from code-dot-org/jk-applab-readonly-debug AppLab: remove debug console when in readonly workspace

view details

push time in 12 minutes

delete branch code-dot-org/code-dot-org

delete branch : jk-applab-readonly-debug

delete time in 12 minutes

PR merged code-dot-org/code-dot-org

AppLab: remove debug console when in readonly workspace

This removes the debug console in applab readonly mode since it isn't necessary and is a security issue.

Before, readonly looked like this with the debug console at the bottom: Screen Shot 2020-11-23 at 3 53 38 PM

Now, it looks like this without the debug console: Screen Shot 2020-11-23 at 3 52 57 PM

<!-- ### Background --> <!-- ### Privacy --> <!--

  1. Does the Project involve the collection, use or sharing of new Personal Data? no
  2. Does the Project involve a new or changed use or sharing of existing Personal Data? no --> <!-- ### Security --> <!-- Link to Jira Task where sensitive security issues are discussed privately. --> <!-- ### Caching --> <!-- ### Deployment strategy --> <!-- ### Future work -->

Links

<!-- Any relevant links to external resources; ie, specification documents, jira items, related PRs, honeybadger errors, etc -->

Testing story

<!-- Does your change include appropriate tests?

If so, please describe how the tests included in this PR are sufficient

If not, please explain why this change does not need to be tested. -->

Reviewer Checklist:

  • [ ] Tests provide adequate coverage
  • [ ] Privacy and Security impacts have been assessed
  • [ ] Code is well-commented
  • [ ] New features are translatable or updates will not break translations
  • [ ] Relevant documentation has been added or updated
  • [ ] User impact is well-understood and desirable
  • [ ] Pull Request is labeled appropriately
  • [ ] Follow-up work items (including potential tech debt) are tracked and linked
+5 -2

0 comment

1 changed file

JillianK

pr closed time in 12 minutes

create barnchatom/atom

branch : mb-fix-tree-sitter-injection

created branch time in 17 minutes

pull request commentelectron/electron

chore: use relative links in docs

@dsanders11 Can you rebase again? The lint is failing for some other files.

dsanders11

comment created time in 20 minutes

PR opened code-dot-org/code-dot-org

add strings for the new AI/ML banner

Add the strings; the banner itself is coming in a follow up PR.

<!-- Your description goes here: A summary of the change, including any relevant motivation and context.

If relevant, include a description both of the existing behavior and of the new behavior. -->

<!-- Other aspects to consider. uncomment and add detail for any that seem necessary: -->

<!-- ### Background --> <!-- ### Privacy --> <!--

  1. Does the Project involve the collection, use or sharing of new Personal Data?

  2. Does the Project involve a new or changed use or sharing of existing Personal Data? --> <!-- ### Security --> <!-- Link to Jira Task where sensitive security issues are discussed privately. --> <!-- ### Caching --> <!-- ### Deployment strategy --> <!-- ### Future work -->

Links

<!-- Any relevant links to external resources; ie, specification documents, jira items, related PRs, honeybadger errors, etc -->

Testing story

<!-- Does your change include appropriate tests?

If so, please describe how the tests included in this PR are sufficient

If not, please explain why this change does not need to be tested. -->

Reviewer Checklist:

  • [ ] Tests provide adequate coverage
  • [ ] Privacy and Security impacts have been assessed
  • [ ] Code is well-commented
  • [ ] New features are translatable or updates will not break translations
  • [ ] Relevant documentation has been added or updated
  • [ ] User impact is well-understood and desirable
  • [ ] Pull Request is labeled appropriately
  • [ ] Follow-up work items (including potential tech debt) are tracked and linked
+3 -0

0 comment

1 changed file

pr created time in 21 minutes

pull request commentelectron/electron

docs: app distribution page

@malept Please check the reviewed version. Sorry for long fix, didn't see the mentions

bandantonio

comment created time in 21 minutes

create barnchcode-dot-org/code-dot-org

branch : ai-ml-banner-strings

created branch time in 22 minutes

push eventelectron/electron

Electron Bot

commit sha 7f0c6ea47ab5a612a29ac9456ccc9ae43ceab027

Bump v12.0.0-nightly.20201022

view details

Charles Kerr

commit sha c934d1386b02437a59195ae460503aa4d3bc648c

docs: add discord link to docs community page (#26048)

view details

David Sanders

commit sha d9db9873fddf96c8f92b6b6355cab9eb30a7a198

fix: return early on promise rejection (#26095)

view details

David Sanders

commit sha 554ad93d45beb8f565b788afb3e3e27c74c1a144

chore: prefer empty() check for readability (#26109)

view details

Antonio

commit sha 722903f06808964084c69f5dce6f397c907508d8

docs: revised the application progress bar feature page (#26003) * docs: revised the application progress bar feature page * docs: fixed mentions, added screenshots to make the guide more consistent * docs: added an extra phrase about indeterminate mode * docs: revised paragraph about indeterminate mode * docs: fixed lint errors, broken links

view details

Jeremy Rose

commit sha 2d49d820726c1f443e822bdba3810322efcf2ea4

chore: synchronously destroy WebContents on event prevented (#26090)

view details

Shelley Vohr

commit sha 6181c03df03f298779db071315103ff5a8bd99ab

fix: setSimpleFullScreen shows traffic light in frameless window (#26096)

view details

Samuel Attard

commit sha 9d18f9d54f86943c90ce56c68f65e3794bd4ae86

fix: re-enable the spellchecker when new language list set (#26119) * fix: re-enable the spellchecker when new language list set Chromium recently added prefs logic to disable the spellchecker if the list of languages is empty, but the logic to re-enable if the languages are provided again lives in another part of Chromium. This change makes it so our API re-enables the spellchecker correctly when required. * chore: fix lint

view details

Electron Bot

commit sha c89ce5eecf61430bb038860eba928428229bdd22

Bump v12.0.0-nightly.20201023

view details

Shelley Vohr

commit sha e89abed924f15a14bf166f3edf7b2a54ad89523f

fix: disable use of the vm module in the renderer (#26087)

view details

David Sanders

commit sha 4379a14335d81e996a5287fb6915ad63f16f09b0

chore: bump @electron/docs-parser version (#26088)

view details

David Sanders

commit sha 30b5e15ddc86806ead4143863f060e7624b6b121

chore: bump @typescript-eslint version (#25986) * chore: bump @typescript-eslint version * chore: update config for newer @typescript-eslint * chore: disable eslint no-undef rule for typescript

view details

Milan Burda

commit sha aa157c3f0568d1ff166bbe547d02f3faa478c8e8

feat: add osProcessId / name properties to webFrameMain (#26093) * feat: add osProcessId / name properties to webFrameMain * Update docs/api/web-frame-main.md Co-authored-by: Jeremy Rose <jeremya@chromium.org> Co-authored-by: Jeremy Rose <jeremya@chromium.org>

view details

Fabio Spampinato

commit sha d4191c4a269fe29b6b5c50de9e9be09a51cd0f8d

fix: optimized asar paths checks (#26024) * fix: optimized asar paths checks * fix: ensuring the linter is happy

view details

Antonio

commit sha ecb758dae548db6f5b18ddedc9482f1a0e83d416

docs: revised the represented file feature page (#26018) * docs: revised the represented file feature page * docs: fixed mentions, updated screenshot to be more consistent

view details

Chris Patterson

commit sha 6a0c5a8a656b22e3e8f212703983e3e3bf38962b

docs: add snapcraft + electron-packager example (#25750) * docs: add snapcraft + electron-packager example Add example to snap electron app (electron-quick-start) using snapcraft & electron-packager. Include notes on how to apply this to an existing project. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> * Update snapcraft.md * Update snapcraft.md * Update snapcraft.md * Update docs/tutorial/snapcraft.md Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Cheng Zhao <github@zcbenz.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

view details

Electron Bot

commit sha 93e786d1b501a6e97eae5f4ebc27334cf51dfc04

Bump v12.0.0-nightly.20201026

view details

Valentin Hăloiu

commit sha 2d1bbd2e3828889d2bdfd000361b19d23ebba282

refactor: remove x11 logic from filenames.gni (#26146)

view details

LuoJinghua

commit sha 0fc5f18b63576570b4a32be66093180d0fe814fb

fix: Don't sort the headers of ClientRequest (#26134)

view details

David Sanders

commit sha 29016b42c76931192a5bd5bf607abfb598688b7b

docs: Windows Security modifies Chromium checkout (#26151)

view details

push time in 23 minutes

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

FYI @DanielRosenwasser

amcasey

comment created time in 23 minutes

Pull request review commentmicrosoft/TypeScript

fix(41268): Replace leading tabs in diagnostic code with spaces

 namespace ts {             const lineStart = getPositionOfLineAndCharacter(file, i, 0);
             const lineEnd = i < lastLineInFile ? getPositionOfLineAndCharacter(file, i + 1, 0) : file.text.length;
             let lineContent = file.text.slice(lineStart, lineEnd);
-            lineContent = lineContent.replace(/\s+$/g, "");  // trim from end
-            lineContent = lineContent.replace("\t", " ");    // convert tabs to single spaces
+
+            // Trim from end
+            lineContent = lineContent.replace(/\s+$/g, "");
+
+            // Convert all leading tabs to single spaces
+            lineContent = lineContent.replace(/\t/gy, " ");

So the iterative nature of replace combined with y=sticky means that the regex stops matching after the initial run, right? If so, that's pretty subtle.

I'd rather have this explicitly documented, adding "(the sticky flag 'y' means that the regex stops matching after the initial run of tabs)" or something like it.

Also, the MDN page says the g is ignored for regexes with y.

thdk

comment created time in 27 minutes

issue openedsindresorhus/awesome-nodejs

File Formidable

Heard about this:

https://github.com/node-formidable/formidable' "A node.js module for parsing form data, especially file uploads."

Don't see it it the list. Is it considerable good? Any similar in the list, instead?

Best Regards, Tom

created time in 27 minutes

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

Heya @amcasey, I'm starting to run the perf test suite on this PR at 8f62ec1a3a8af122ebc4f1ae86b8d26970bbcd8d. Hold tight - I'll update this comment with the log link once the build has been queued.

amcasey

comment created time in 28 minutes

pull request commentmicrosoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

@typescript-bot perf test this

amcasey

comment created time in 28 minutes

PR opened microsoft/TypeScript

Extract consts for repeated accesses to Type.flags in hot paths

Speculative perf improvement.

+72 -64

0 comment

1 changed file

pr created time in 28 minutes

issue commentmoby/moby

name resolution not happening for services within Swarm

@mukuntharajaa I guess they intended to mention you not me.

Oops, I have fixed that. Thanks for pointing out my typo!

mukuntharajaa

comment created time in 31 minutes

push eventmicrosoft/TypeScript

Oleksandr T

commit sha d163ab67c82460b7177e7e93a3e80659a9ef75fb

fix(41240): allow emitting numeric with underscored separators as-is in esnext target (#41435)

view details

push time in 34 minutes

PR merged microsoft/TypeScript

fix(41240): Support emitting numerics with separators as-is in target: esnext For Backlog Bug

Fixes #41240

+278 -5

0 comment

27 changed files

a-tarasyuk

pr closed time in 34 minutes

issue closedmicrosoft/TypeScript

Support emitting numerics with separators as-is in target: esnext

<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

  • Search: https://github.com/Microsoft/TypeScript/search?type=Issues
  • Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: typescript@next This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> TypeScript Version: 4.1.0-beta (playground)

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: numeric separator

Code

// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
2021_10_26

Expected behavior: 2021_10_26

Actual behavior: 20211026

Playground Link: https://www.typescriptlang.org/play?target=99&ts=4.1.0-beta#code/EwBmEYH1xTgNiA

Related Issues: <!-- Did you find other bugs that looked similar? -->

closed time in 34 minutes

saschanaz

push eventelectron/electron

Electron Bot

commit sha b0862a6e63173c4c919bd5ed27d257235bbfe7d2

Bump v11.0.3

view details

push time in 34 minutes

more