Heya @amcasey, I'm starting to run the perf test suite on this PR at 9909496ab8827574d3cf1f0b6a3c178c60328b88. Hold tight - I'll update this comment with the log link once the build has been queued.

@typescript-bot perf test this

@amcasey The results of the perf run you requested are in! <details><summary> Here they are:</summary><p> <b>Comparison Report - master..41662</b> <table border="0" cellpadding="0" cellspacing="0" > <thead> <tr> <th align=left>_Metric</th> <th align=right>_master</th> <th align=right>₄₁₆₆₂</th> <th align=right>_Delta</th> <th align=right>_Best</th> <th align=right>_Worst</th> </tr> </thead> <tr class="group"><th align=left colspan="6">_{Angular - node (v10.16.3, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left>_{Memory used}</td> <td align=right>_{344,501k (± 0.03%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-344,501k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left>_{Parse Time}</td> <td align=right>_{1.99s (± 0.77%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-1.99s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left>_{Bind Time}</td> <td align=right>_{0.83s (± 0.58%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.83s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left>_{Check Time}</td> <td align=right>_{4.97s (± 0.44%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-4.97s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left>_{Emit Time}</td> <td align=right>_{5.37s (± 0.68%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-5.37s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host0"> <td align=left>_{Total Time}</td> <td align=right>_{13.15s (± 0.32%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-13.15s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Monaco - node (v10.16.3, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left>_{Memory used}</td> <td align=right>_{354,721k (± 0.02%)}</td> <td align=right>_{354,693k (± 0.03%)}</td> <td align=right>_{-28k (- 0.01%)}</td> <td align=right>_354,508k</td> <td align=right>_354,930k</td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left>_{Parse Time}</td> <td align=right>_{1.61s (± 0.55%)}</td> <td align=right>_{1.60s (± 0.45%)}</td> <td align=right>_{-0.01s (- 0.50%)}</td> <td align=right>_1.59s</td> <td align=right>_1.62s</td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left>_{Bind Time}</td> <td align=right>_{0.73s (± 0.41%)}</td> <td align=right>_{0.72s (± 0.47%)}</td> <td align=right>_{-0.01s (- 0.69%)}</td> <td align=right>_0.72s</td> <td align=right>_0.73s</td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left>_{Check Time}</td> <td align=right>_{5.13s (± 0.56%)}</td> <td align=right>_{5.10s (± 0.61%)}</td> <td align=right>_{-0.04s (- 0.74%)}</td> <td align=right>_5.03s</td> <td align=right>_5.18s</td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left>_{Emit Time}</td> <td align=right>_{2.81s (± 0.54%)}</td> <td align=right>_{2.81s (± 0.61%)}</td> <td align=right>_{-0.00s (- 0.04%)}</td> <td align=right>_2.77s</td> <td align=right>_2.85s</td> </tr> <tr class="measurement total scenario0 host0"> <td align=left>_{Total Time}</td> <td align=right>_{10.29s (± 0.35%)}</td> <td align=right>_{10.23s (± 0.38%)}</td> <td align=right>_{-0.06s (- 0.55%)}</td> <td align=right>_10.15s</td> <td align=right>_10.30s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{TFS - node (v10.16.3, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left>_{Memory used}</td> <td align=right>_{307,856k (± 0.01%)}</td> <td align=right>_{307,822k (± 0.02%)}</td> <td align=right>_{-34k (- 0.01%)}</td> <td align=right>_307,650k</td> <td align=right>_307,930k</td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left>_{Parse Time}</td> <td align=right>_{1.24s (± 0.81%)}</td> <td align=right>_{1.24s (± 0.67%)}</td> <td align=right>_{-0.01s (- 0.64%)}</td> <td align=right>_1.22s</td> <td align=right>_1.25s</td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left>_{Bind Time}</td> <td align=right>_{0.68s (± 1.56%)}</td> <td align=right>_{0.68s (± 0.59%)}</td> <td align=right>_{+0.00s (+ 0.30%)}</td> <td align=right>_0.67s</td> <td align=right>_0.69s</td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left>_{Check Time}</td> <td align=right>_{4.58s (± 0.46%)}</td> <td align=right>_{4.57s (± 0.41%)}</td> <td align=right>_{-0.01s (- 0.33%)}</td> <td align=right>_4.53s</td> <td align=right>_4.61s</td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left>_{Emit Time}</td> <td align=right>_{2.94s (± 0.92%)}</td> <td align=right>_{2.92s (± 1.13%)}</td> <td align=right>_{-0.02s (- 0.54%)}</td> <td align=right>_2.85s</td> <td align=right>_3.01s</td> </tr> <tr class="measurement total scenario0 host0"> <td align=left>_{Total Time}</td> <td align=right>_{9.44s (± 0.51%)}</td> <td align=right>_{9.41s (± 0.48%)}</td> <td align=right>_{-0.03s (- 0.33%)}</td> <td align=right>_9.32s</td> <td align=right>_9.51s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{material-ui - node (v10.16.3, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host0"> <td align=left>_{Memory used}</td> <td align=right>_{489,326k (± 0.01%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-489,326k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host0"> <td align=left>_{Parse Time}</td> <td align=right>_{2.06s (± 0.47%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.06s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host0"> <td align=left>_{Bind Time}</td> <td align=right>_{0.65s (± 0.68%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.65s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host0"> <td align=left>_{Check Time}</td> <td align=right>_{13.60s (± 0.69%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-13.60s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host0"> <td align=left>_{Emit Time}</td> <td align=right>_{0.00s (± 0.00%)}</td> <td align=right>_0.00s</td> <td align=right>_{0.00s ( NaN%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host0"> <td align=left>_{Total Time}</td> <td align=right>_{16.31s (± 0.57%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-16.31s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Angular - node (v12.1.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left>_{Memory used}</td> <td align=right>_{322,386k (± 0.03%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-322,386k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left>_{Parse Time}</td> <td align=right>_{1.97s (± 0.76%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-1.97s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left>_{Bind Time}</td> <td align=right>_{0.81s (± 0.82%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.81s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left>_{Check Time}</td> <td align=right>_{4.91s (± 1.11%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-4.91s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left>_{Emit Time}</td> <td align=right>_{5.49s (± 0.36%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-5.49s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host1"> <td align=left>_{Total Time}</td> <td align=right>_{13.19s (± 0.53%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-13.19s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Monaco - node (v12.1.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left>_{Memory used}</td> <td align=right>_{336,778k (± 0.01%)}</td> <td align=right>_{336,834k (± 0.01%)}</td> <td align=right>_{+56k (+ 0.02%)}</td> <td align=right>_336,725k</td> <td align=right>_336,941k</td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left>_{Parse Time}</td> <td align=right>_{1.59s (± 0.82%)}</td> <td align=right>_{1.58s (± 0.65%)}</td> <td align=right>_{-0.01s (- 0.75%)}</td> <td align=right>_1.55s</td> <td align=right>_1.59s</td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left>_{Bind Time}</td> <td align=right>_{0.71s (± 0.63%)}</td> <td align=right>_{0.71s (± 1.15%)}</td> <td align=right>_{-0.00s (- 0.28%)}</td> <td align=right>_0.69s</td> <td align=right>_0.73s</td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left>_{Check Time}</td> <td align=right>_{4.94s (± 0.50%)}</td> <td align=right>_{4.90s (± 0.43%)}</td> <td align=right>_{-0.04s (- 0.77%)}</td> <td align=right>_4.85s</td> <td align=right>_4.96s</td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left>_{Emit Time}</td> <td align=right>_{2.86s (± 0.62%)}</td> <td align=right>_{2.88s (± 1.16%)}</td> <td align=right>_{+0.02s (+ 0.63%)}</td> <td align=right>_2.82s</td> <td align=right>_2.99s</td> </tr> <tr class="measurement total scenario0 host1"> <td align=left>_{Total Time}</td> <td align=right>_{10.10s (± 0.39%)}</td> <td align=right>_{10.06s (± 0.53%)}</td> <td align=right>_{-0.03s (- 0.35%)}</td> <td align=right>_10.00s</td> <td align=right>_10.25s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{TFS - node (v12.1.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left>_{Memory used}</td> <td align=right>_{292,156k (± 0.02%)}</td> <td align=right>_{292,097k (± 0.02%)}</td> <td align=right>_{-59k (- 0.02%)}</td> <td align=right>_291,916k</td> <td align=right>_292,258k</td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left>_{Parse Time}</td> <td align=right>_{1.26s (± 0.75%)}</td> <td align=right>_{1.25s (± 0.71%)}</td> <td align=right>_{-0.01s (- 0.71%)}</td> <td align=right>_1.24s</td> <td align=right>_1.28s</td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left>_{Bind Time}</td> <td align=right>_{0.66s (± 0.76%)}</td> <td align=right>_{0.66s (± 1.41%)}</td> <td align=right>_{+0.00s (+ 0.46%)}</td> <td align=right>_0.64s</td> <td align=right>_0.68s</td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left>_{Check Time}</td> <td align=right>_{4.53s (± 0.73%)}</td> <td align=right>_{4.50s (± 0.54%)}</td> <td align=right>_{-0.03s (- 0.68%)}</td> <td align=right>_4.44s</td> <td align=right>_4.55s</td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left>_{Emit Time}</td> <td align=right>_{2.97s (± 1.14%)}</td> <td align=right>_{2.97s (± 0.90%)}</td> <td align=right>_{+0.01s (+ 0.27%)}</td> <td align=right>_2.93s</td> <td align=right>_3.06s</td> </tr> <tr class="measurement total scenario0 host1"> <td align=left>_{Total Time}</td> <td align=right>_{9.41s (± 0.61%)}</td> <td align=right>_{9.39s (± 0.45%)}</td> <td align=right>_{-0.02s (- 0.23%)}</td> <td align=right>_9.27s</td> <td align=right>_9.47s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{material-ui - node (v12.1.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host1"> <td align=left>_{Memory used}</td> <td align=right>_{467,325k (± 0.05%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-467,325k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host1"> <td align=left>_{Parse Time}</td> <td align=right>_{2.09s (± 0.59%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.09s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host1"> <td align=left>_{Bind Time}</td> <td align=right>_{0.64s (± 1.21%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.64s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host1"> <td align=left>_{Check Time}</td> <td align=right>_{12.09s (± 0.67%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-12.09s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host1"> <td align=left>_{Emit Time}</td> <td align=right>_{0.00s (± 0.00%)}</td> <td align=right>_0.00s</td> <td align=right>_{0.00s ( NaN%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host1"> <td align=left>_{Total Time}</td> <td align=right>_{14.82s (± 0.56%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-14.82s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Angular - node (v8.9.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left>_{Memory used}</td> <td align=right>_{347,048k (± 0.02%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-347,048k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left>_{Parse Time}</td> <td align=right>_{2.52s (± 0.53%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.52s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left>_{Bind Time}</td> <td align=right>_{0.87s (± 0.79%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.87s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left>_{Check Time}</td> <td align=right>_{5.62s (± 0.56%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-5.62s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left>_{Emit Time}</td> <td align=right>_{6.36s (± 1.36%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-6.36s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host2"> <td align=left>_{Total Time}</td> <td align=right>_{15.37s (± 0.74%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-15.37s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Monaco - node (v8.9.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left>_{Memory used}</td> <td align=right>_{358,533k (± 0.02%)}</td> <td align=right>_{358,558k (± 0.01%)}</td> <td align=right>_{+26k (+ 0.01%)}</td> <td align=right>_358,412k</td> <td align=right>_358,642k</td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left>_{Parse Time}</td> <td align=right>_{1.94s (± 0.46%)}</td> <td align=right>_{1.93s (± 0.19%)}</td> <td align=right>_{-0.01s (- 0.62%)}</td> <td align=right>_1.92s</td> <td align=right>_1.93s</td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left>_{Bind Time}</td> <td align=right>_{0.91s (± 0.71%)}</td> <td align=right>_{0.91s (± 0.54%)}</td> <td align=right>_{+0.00s (+ 0.22%)}</td> <td align=right>_0.90s</td> <td align=right>_0.92s</td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left>_{Check Time}</td> <td align=right>_{5.66s (± 0.46%)}</td> <td align=right>_{5.62s (± 0.42%)}</td> <td align=right>_{-0.04s (- 0.64%)}</td> <td align=right>_5.58s</td> <td align=right>_5.68s</td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left>_{Emit Time}</td> <td align=right>_{3.42s (± 0.83%)}</td> <td align=right>_{3.42s (± 0.61%)}</td> <td align=right>_{+0.01s (+ 0.29%)}</td> <td align=right>_3.36s</td> <td align=right>_3.46s</td> </tr> <tr class="measurement total scenario0 host2"> <td align=left>_{Total Time}</td> <td align=right>_{11.92s (± 0.38%)}</td> <td align=right>_{11.88s (± 0.31%)}</td> <td align=right>_{-0.04s (- 0.33%)}</td> <td align=right>_11.78s</td> <td align=right>_11.95s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{TFS - node (v8.9.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left>_{Memory used}</td> <td align=right>_{310,419k (± 0.01%)}</td> <td align=right>_{310,363k (± 0.01%)}</td> <td align=right>_{-56k (- 0.02%)}</td> <td align=right>_310,283k</td> <td align=right>_310,481k</td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left>_{Parse Time}</td> <td align=right>_{1.58s (± 0.73%)}</td> <td align=right>_{1.57s (± 0.30%)}</td> <td align=right>_{-0.01s (- 0.63%)}</td> <td align=right>_1.56s</td> <td align=right>_1.58s</td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left>_{Bind Time}</td> <td align=right>_{0.69s (± 0.50%)}</td> <td align=right>_{0.69s (± 0.48%)}</td> <td align=right>_{+0.00s (+ 0.44%)}</td> <td align=right>_0.68s</td> <td align=right>_0.70s</td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left>_{Check Time}</td> <td align=right>_{5.33s (± 0.36%)}</td> <td align=right>_{5.33s (± 0.45%)}</td> <td align=right>_{-0.00s (- 0.09%)}</td> <td align=right>_5.27s</td> <td align=right>_5.38s</td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left>_{Emit Time}</td> <td align=right>_{2.98s (± 0.69%)}</td> <td align=right>_{2.96s (± 0.35%)}</td> <td align=right>_{-0.02s (- 0.57%)}</td> <td align=right>_2.94s</td> <td align=right>_2.98s</td> </tr> <tr class="measurement total scenario0 host2"> <td align=left>_{Total Time}</td> <td align=right>_{10.57s (± 0.39%)}</td> <td align=right>_{10.55s (± 0.30%)}</td> <td align=right>_{-0.03s (- 0.27%)}</td> <td align=right>_10.49s</td> <td align=right>_10.63s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{material-ui - node (v8.9.0, x64)}</th></tr> <tbody> <tr class="measurement memory scenario0 host2"> <td align=left>_{Memory used}</td> <td align=right>_{496,318k (± 0.01%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-496,318k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host2"> <td align=left>_{Parse Time}</td> <td align=right>_{2.50s (± 0.48%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.50s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host2"> <td align=left>_{Bind Time}</td> <td align=right>_{0.82s (± 1.52%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.82s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host2"> <td align=left>_{Check Time}</td> <td align=right>_{18.15s (± 0.69%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-18.15s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host2"> <td align=left>_{Emit Time}</td> <td align=right>_{0.00s (± 0.00%)}</td> <td align=right>_0.00s</td> <td align=right>_{0.00s ( NaN%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host2"> <td align=left>_{Total Time}</td> <td align=right>_{21.48s (± 0.60%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-21.48s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Angular - node (v8.9.0, x86)}</th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left>_{Memory used}</td> <td align=right>_{198,970k (± 0.03%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-198,970k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left>_{Parse Time}</td> <td align=right>_{2.44s (± 0.92%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.44s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left>_{Bind Time}</td> <td align=right>_{1.02s (± 0.79%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-1.02s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left>_{Check Time}</td> <td align=right>_{5.03s (± 0.38%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-5.03s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left>_{Emit Time}</td> <td align=right>_{6.14s (± 0.86%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-6.14s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host3"> <td align=left>_{Total Time}</td> <td align=right>_{14.63s (± 0.43%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-14.63s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{Monaco - node (v8.9.0, x86)}</th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left>_{Memory used}</td> <td align=right>_{203,088k (± 0.03%)}</td> <td align=right>_{203,071k (± 0.01%)}</td> <td align=right>_{-17k (- 0.01%)}</td> <td align=right>_203,013k</td> <td align=right>_203,135k</td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left>_{Parse Time}</td> <td align=right>_{1.98s (± 0.74%)}</td> <td align=right>_{1.97s (± 0.70%)}</td> <td align=right>_{-0.01s (- 0.25%)}</td> <td align=right>_1.95s</td> <td align=right>_2.00s</td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left>_{Bind Time}</td> <td align=right>_{0.72s (± 1.17%)}</td> <td align=right>_{0.71s (± 0.51%)}</td> <td align=right>_{-0.01s (- 0.70%)}</td> <td align=right>_0.71s</td> <td align=right>_0.72s</td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left>_{Check Time}</td> <td align=right>_{5.74s (± 1.49%)}</td> <td align=right>_{5.63s (± 1.96%)}</td> <td align=right>_{-0.11s (- 1.88%)}</td> <td align=right>_5.38s</td> <td align=right>_5.79s</td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left>_{Emit Time}</td> <td align=right>_{2.82s (± 3.83%)}</td> <td align=right>_{2.89s (± 4.16%)}</td> <td align=right>_{+0.08s (+ 2.70%)}</td> <td align=right>_2.72s</td> <td align=right>_3.15s</td> </tr> <tr class="measurement total scenario0 host3"> <td align=left>_{Total Time}</td> <td align=right>_{11.25s (± 0.34%)}</td> <td align=right>_{11.21s (± 0.31%)}</td> <td align=right>_{-0.04s (- 0.37%)}</td> <td align=right>_11.16s</td> <td align=right>_11.30s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{TFS - node (v8.9.0, x86)}</th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left>_{Memory used}</td> <td align=right>_{177,494k (± 0.03%)}</td> <td align=right>_{177,531k (± 0.03%)}</td> <td align=right>_{+38k (+ 0.02%)}</td> <td align=right>_177,411k</td> <td align=right>_177,667k</td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left>_{Parse Time}</td> <td align=right>_{1.62s (± 1.64%)}</td> <td align=right>_{1.62s (± 1.00%)}</td> <td align=right>_{+0.01s (+ 0.31%)}</td> <td align=right>_1.60s</td> <td align=right>_1.68s</td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left>_{Bind Time}</td> <td align=right>_{0.65s (± 0.77%)}</td> <td align=right>_{0.65s (± 0.46%)}</td> <td align=right>_{+0.00s (+ 0.47%)}</td> <td align=right>_0.64s</td> <td align=right>_0.65s</td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left>_{Check Time}</td> <td align=right>_{4.87s (± 0.42%)}</td> <td align=right>_{4.86s (± 0.74%)}</td> <td align=right>_{-0.02s (- 0.33%)}</td> <td align=right>_4.79s</td> <td align=right>_4.94s</td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left>_{Emit Time}</td> <td align=right>_{2.86s (± 0.65%)}</td> <td align=right>_{2.83s (± 0.80%)}</td> <td align=right>_{-0.03s (- 1.08%)}</td> <td align=right>_2.78s</td> <td align=right>_2.89s</td> </tr> <tr class="measurement total scenario0 host3"> <td align=left>_{Total Time}</td> <td align=right>_{10.00s (± 0.37%)}</td> <td align=right>_{9.96s (± 0.39%)}</td> <td align=right>_{-0.04s (- 0.44%)}</td> <td align=right>_9.89s</td> <td align=right>_10.07s</td> </tr> </tbody> <tr class="group"><th align=left colspan="6">_{material-ui - node (v8.9.0, x86)}</th></tr> <tbody> <tr class="measurement memory scenario0 host3"> <td align=left>_{Memory used}</td> <td align=right>_{279,452k (± 0.02%)}</td> <td align=right>_0k</td> <td align=right>_{🟩-279,452k (-100.00%)}</td> <td align=right>_0k</td> <td align=right>_0k</td> </tr> <tr class="measurement parse-time scenario0 host3"> <td align=left>_{Parse Time}</td> <td align=right>_{2.56s (± 0.62%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-2.56s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement bind-time scenario0 host3"> <td align=left>_{Bind Time}</td> <td align=right>_{0.75s (± 6.65%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-0.75s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement check-time scenario0 host3"> <td align=left>_{Check Time}</td> <td align=right>_{16.60s (± 0.85%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-16.60s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement emit-time scenario0 host3"> <td align=left>_{Emit Time}</td> <td align=right>_{0.00s (± 0.00%)}</td> <td align=right>_0.00s</td> <td align=right>_{0.00s ( NaN%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> <tr class="measurement total scenario0 host3"> <td align=left>_{Total Time}</td> <td align=right>_{19.91s (± 0.54%)}</td> <td align=right>_0.00s</td> <td align=right>_{🟩-19.91s (-100.00%)}</td> <td align=right>_0.00s</td> <td align=right>_0.00s</td> </tr> </tbody> </table> <div> <b>System</b> <table cellpadding="0" cellspacing="0" border="0" > <tr><th align=right>_{Machine Name}</th><td>_ts-ci-ubuntu</td></tr> <tr><th align=right>_Platform</th><td>_{linux 4.4.0-166-generic}</td></tr> <tr><th align=right>_Architecture</th><td>_x64</td></tr> <tr><th align=right>_{Available Memory}</th><td>_{16 GB}</td></tr> <tr><th align=right>_{Available Memory}</th><td>_{1 GB}</td></tr> <tr><th align=right>_CPUs</th><td>_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}</td></tr> </table> </div> <div> <b>Hosts</b> <ul> <li>node (v10.16.3, x64)</li> <li>node (v12.1.0, x64)</li> <li>node (v8.9.0, x64)</li> <li>node (v8.9.0, x86)</li> </ul> </div> <div> <b>Scenarios</b> <ul> <li>Angular - node (v10.16.3, x64)</li> <li>Angular - node (v12.1.0, x64)</li> <li>Angular - node (v8.9.0, x64)</li> <li>Angular - node (v8.9.0, x86)</li> <li>Monaco - node (v10.16.3, x64)</li> <li>Monaco - node (v12.1.0, x64)</li> <li>Monaco - node (v8.9.0, x64)</li> <li>Monaco - node (v8.9.0, x86)</li> <li>TFS - node (v10.16.3, x64)</li> <li>TFS - node (v12.1.0, x64)</li> <li>TFS - node (v8.9.0, x64)</li> <li>TFS - node (v8.9.0, x86)</li> <li>material-ui - node (v10.16.3, x64)</li> <li>material-ui - node (v12.1.0, x64)</li> <li>material-ui - node (v8.9.0, x64)</li> <li>material-ui - node (v8.9.0, x86)</li> </ul> </div> <div> <table cellspacing="0" cellpadding="0" border="0" > <tr> <th align=left>_Benchmark</th> <th align=left>_Name</th> <th align=left>_Iterations</th> </tr> <tr> <td>_Current</td> <td>₄₁₆₆₂</td> <td>₁₀</td> </tr> <tr> <td>_Baseline</td> <td>_master</td> <td>₁₀</td> </tr> </table> </div>

</p></details>

Open source is largely volunteer-driven and collaborative. Because of this, time and energy to get things done are often the scarcest resources. We want Electron to be the best that it can be, but we also have to be realistic about what the team maintaining Electron can achieve. This means that:

• We might not have an ETA for when an issue will get investigated or fixed.
• Something you want implemented might not get implemented.
• A change you want merged might not get merged.
• Insisting on or making demands for any of the above is considered against the Electron Code of Conduct

For additional context, I'd read https://github.community/t/creators-contributors-and-collaborators/10219.

Identify the Bug

https://github.com/atom/atom/issues/21093

There was a bug would occur in documents with language injections, where the injected document is empty. Examples include:

• An empty string assigned to a node's innerHTML property in JavaScript. Usually, we highlight the contents of these strings as HTML.

  node.innerHTML = "";
  

• An empty script tag in an HTML document. Usually, we would parse the tag's contents this script tag as JavaScript:

  <div>
    <script></script>
  </div>
  

• In Ruby or JavaScript, a regular expression literal whose entire contents consist of escape sequences. Usually we highlight the contents of the regular expression using regex syntax:

  s.search /\n/
  

The bug would cause us to accidentally skip highlighting large sections of the document.

Description of the Change

These injected syntax trees are each associated with a Marker in the LanguageMode's injectionsMarkerLayer. This PR ensures that, when a language injection is empty, its marker is destroyed.

I also upgraded to the latest version of tree-sitter-rust in order to fix the last two issues mentioned in #21093, which were. unrelated, but easy to address.

Verification Process

Create files containing all of the code examples in #21093. See that the syntax highlighting is all correct. Edit this files in a variety of ways and see that syntax highlighting stays correct.

Release Notes

Fixed a syntax highlighting bug that caused inconsistent and missing highlighting in several languages.

This is one of the incorrectly captured flags since target might have changed from a union to an object:

                if (target.flags & TypeFlags.Union && source.flags & TypeFlags.Object &&
                    (target as UnionType).types.length <= 3 && maybeTypeOfKind(target, TypeFlags.Nullable)) {
                    const nullStrippedTarget = extractTypesOfKind(target, ~TypeFlags.Nullable);
                    if (!(nullStrippedTarget.flags & (TypeFlags.Union | TypeFlags.Never))) {
                        if (source === nullStrippedTarget) return Ternary.True;
                        target = nullStrippedTarget;
                    }
                }

This removes the debug console in applab readonly mode since it isn't necessary and is a security issue.

Before, readonly looked like this with the debug console at the bottom:

Now, it looks like this without the debug console:

<!-- ### Background --> <!-- ### Privacy --> <!--

1. Does the Project involve the collection, use or sharing of new Personal Data? no
2. Does the Project involve a new or changed use or sharing of existing Personal Data? no --> <!-- ### Security --> <!-- Link to Jira Task where sensitive security issues are discussed privately. --> <!-- ### Caching --> <!-- ### Deployment strategy --> <!-- ### Future work -->

Links

<!-- Any relevant links to external resources; ie, specification documents, jira items, related PRs, honeybadger errors, etc -->

• jira
• slack conversation

Testing story

<!-- Does your change include appropriate tests?

If so, please describe how the tests included in this PR are sufficient

If not, please explain why this change does not need to be tested. -->

Reviewer Checklist:

• [ ] Tests provide adequate coverage
• [ ] Privacy and Security impacts have been assessed
• [ ] Code is well-commented
• [ ] New features are translatable or updates will not break translations
• [ ] Relevant documentation has been added or updated
• [ ] User impact is well-understood and desirable
• [ ] Pull Request is labeled appropriately
• [ ] Follow-up work items (including potential tech debt) are tracked and linked

@dsanders11 Can you rebase again? The lint is failing for some other files.

Add the strings; the banner itself is coming in a follow up PR.

<!-- Your description goes here: A summary of the change, including any relevant motivation and context.

If relevant, include a description both of the existing behavior and of the new behavior. -->

<!-- Other aspects to consider. uncomment and add detail for any that seem necessary: -->

<!-- ### Background --> <!-- ### Privacy --> <!--

1. Does the Project involve the collection, use or sharing of new Personal Data?

2. Does the Project involve a new or changed use or sharing of existing Personal Data? --> <!-- ### Security --> <!-- Link to Jira Task where sensitive security issues are discussed privately. --> <!-- ### Caching --> <!-- ### Deployment strategy --> <!-- ### Future work -->

Links

<!-- Any relevant links to external resources; ie, specification documents, jira items, related PRs, honeybadger errors, etc -->

• jira

Testing story

<!-- Does your change include appropriate tests?

If so, please describe how the tests included in this PR are sufficient

If not, please explain why this change does not need to be tested. -->

Reviewer Checklist:

• [ ] Tests provide adequate coverage
• [ ] Privacy and Security impacts have been assessed
• [ ] Code is well-commented
• [ ] New features are translatable or updates will not break translations
• [ ] Relevant documentation has been added or updated
• [ ] User impact is well-understood and desirable
• [ ] Pull Request is labeled appropriately
• [ ] Follow-up work items (including potential tech debt) are tracked and linked

@malept Please check the reviewed version. Sorry for long fix, didn't see the mentions

FYI @DanielRosenwasser

So the iterative nature of replace combined with y=sticky means that the regex stops matching after the initial run, right? If so, that's pretty subtle.

I'd rather have this explicitly documented, adding "(the sticky flag 'y' means that the regex stops matching after the initial run of tabs)" or something like it.

Also, the MDN page says the g is ignored for regexes with y.

Heard about this:

https://github.com/node-formidable/formidable' "A node.js module for parsing form data, especially file uploads."

Don't see it it the list. Is it considerable good? Any similar in the list, instead?

Best Regards, Tom

Heya @amcasey, I'm starting to run the perf test suite on this PR at 8f62ec1a3a8af122ebc4f1ae86b8d26970bbcd8d. Hold tight - I'll update this comment with the log link once the build has been queued.

@typescript-bot perf test this

Speculative perf improvement.

@mukuntharajaa I guess they intended to mention you not me.

Oops, I have fixed that. Thanks for pointing out my typo!

@andrewbranch Got it! Thanks.

Fixes #41240

<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a bug, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!

Please help us by doing the following steps before logging an issue:

• Search: https://github.com/Microsoft/TypeScript/search?type=Issues
• Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ

Please fill in the entire template below. -->

<!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: typescript@next This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> TypeScript Version: 4.1.0-beta (playground)

<!-- Search terms you tried before logging this (so others can find this issue more easily) --> Search Terms: numeric separator

Code

// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
2021_10_26

Expected behavior: 2021_10_26

Actual behavior: 20211026

Playground Link: https://www.typescriptlang.org/play?target=99&ts=4.1.0-beta#code/EwBmEYH1xTgNiA

Related Issues: <!-- Did you find other bugs that looked similar? -->