profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/TheSavior/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Eli White TheSavior @facebook Redwood City, CA http://eli-white.com React Native @facebook. Circus Enthusiast. Dessert Fanatic. Ex. @wealthfront @airbnb @google @microsoft

microsoft/react-native-windows 13607

A framework for building native Windows apps with React.

reactjs/react-docgen 3040

A CLI and toolbox to extract information from React component files for documentation generation purposes.

microsoft/react-native-macos 1796

A framework for building native macOS apps with React.

cpojer/js-codemod 1078

Codemod scripts to transform code to next generation JS

TheSavior/ESLint-Formatter 139

Sublime Text 3 Plugin to Autoformat with Eslint

TheSavior/covid19-changes 13

View the diff of CDC's COVID-19 updates

TheSavior/clean-git-ref 4

Clean an input string into a usable git ref

TheSavior/2048 1

A small clone of 1024 (https://play.google.com/store/apps/details?id=com.veewo.a1024)

TheSavior/apt-tracker 1

Track prices of apartments over time

TheSavior/conservice-charges 1

Visualize your conservice charges over time.

issue commentreact-native-community/discussions-and-proposals

TurboModules (NativeModules Re-architecture)

@mrousavy follow up question... when passing the invoker to the cpp-adapter.cpp file, what is the proper way to cast the invoker?

extern "C" JNIEXPORT void JNICALL Java_com_MyAwesomeModule_initialize(JNIEnv* env, jclass clazz, jlong jsi, jobject invoker) { installMyAwesomeModule(*reinterpret_cast<facebook::jsi::Runtime *>(jsi), invoker); }

my cpp file has this declaration void installMyAwesomeModule(jsi::Runtime& jsiRuntime, std::shared_ptr<react::CallInvoker> jsInvoker)

fkgozali

comment created time in a day

issue commentreact-native-community/releases

Road to v0.65.0 - RC2 phase

Flipper version bump for ios merged to master. https://github.com/facebook/react-native/commit/848d59947c4c31b35fcd66459afc0068e767ecae

kelset

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC2 phase

@janicduplessis @beetlebum I recommend to stick to the defaults (use_flipper!()) for now, that is on 0.91.x. Version 0.93 doesn't introduce anything new for iOS, but has some build conflicts due to (unrelated) issues in fmt + RTC-folly which need to be solved first before we can even attempt to update Flipper. The overrides are only meant to be used in case the default settings don't suffice (anymore) for some reason. Does removing the version specifier remove the issue?

kelset

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC2 phase

Hey folks, thanks to @Titozzz and @ShikaSD we managed to find a way to correctly fix the Android artifacts not being generated on CI, so we did a couple of re-reverts and added the fix on top and now RC2 is out and Android works 🚀 (or well at least it doesn't crash on startup which is nice 😅)

I've updated the top post to reflect the status.


@janicduplessis @beetlebum can either of you setup some repro steps for the issue you are reporting? @mweststrate has this PR up https://github.com/facebook/react-native/pull/31708 so if the issue is around Flipper 0.93 on iOS that'd be the place to fix it.

I've naively thought that these steps would repro:

  • npx react-native init RN065RC2 --version 0.65.0-rc.2
  • change in Podfile use_flipper!({ 'Flipper' => '0.93.0' }) and pod install
  • yarn ios

But at least on my machine iOS builds successfully anyway.


@YaoHuiJi I think I can understand your confusion, and while I don't have the correct answer I'm going to assume that FB internally still uses DatePickerIOS. I think that you should ask the maintainers of datetimepicker if they will make sure to "repeat" those changes in their repo, and keep using their library.

kelset

comment created time in 2 days

release wix/Detox

18.18.0

released time in 2 days

release mochajs/mocha

v9.0.1

released time in 2 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

hi, I am confused after I read the change log of v0.65.0, since DatePicker was deprecated and removed from react-native, why these changes are committed to react-native not @react-native-datetimepicker/datetimepicker ? should I use DatePicker back again ?

  • Expose UIDatePickerStyles as a prop for DatePickerIOS (266b21baf3)

  • Expose UIDatePickerStyles as a prop for DatePickerIOS (2b62e19a78)

kelset

comment created time in 2 days

startedprojectdiscovery/nuclei-templates

started time in 2 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

RC1 still has issue with android!

Cherry picking this will hopefully definitely solve it : https://github.com/facebook/react-native/commit/6be4f2b2c8c66c4f5eb47717353f59c768c0889f

Also we can revert both reverts as they are not needed for the fix to work.

kelset

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

@kelset I tried to run and the RC release continues to crash on Android.

When I ran it for the first time, it appeared in the build logs:

> Task :app:stripReleaseDebugSymbols
Unable to strip the following libraries, packaging them as they are: libevent-2.1.so, libevent_core-2.1.so, libevent_extra-2.1.so, libflipper.so, libhermes.so, libimagepipeline.so, libnative-filters.so, libnative-imagetranscoder.so.

And when I opened the app and it crashed:

2021-06-17 16:22:01.372 4551-4551/? I/com.rn065: Not late-enabling -Xcheck:jni (already on)
2021-06-17 16:22:01.392 4551-4551/? E/com.rn065: Unknown bits set in runtime_flags: 0x8000
2021-06-17 16:22:01.394 4551-4551/? W/com.rn065: Unexpected CPU variant for X86 using defaults: x86_64
2021-06-17 16:22:01.811 4551-4551/com.rn065 D/SoLoader: init start
2021-06-17 16:22:01.812 4551-4551/com.rn065 D/SoLoader: adding system library source: /vendor/lib64
2021-06-17 16:22:01.814 4551-4551/com.rn065 D/SoLoader: adding system library source: /system/lib64
2021-06-17 16:22:01.815 4551-4551/com.rn065 D/SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
2021-06-17 16:22:01.821 4551-4551/com.rn065 V/fb-UnpackingSoSource: locked dso store /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.823 4551-4551/com.rn065 I/fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.824 4551-4551/com.rn065 V/fb-UnpackingSoSource: releasing dso store lock for /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.824 4551-4551/com.rn065 D/SoLoader: init finish: 4 SO sources prepared
2021-06-17 16:22:01.824 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:01.845 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:01.845 4551-4551/com.rn065 D/SoLoader: About to load: libjscexecutor.so
2021-06-17 16:22:01.846 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /data/data/com.rn065/lib-main
2021-06-17 16:22:01.847 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
2021-06-17 16:22:01.848 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /vendor/lib64
2021-06-17 16:22:01.848 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /system/lib64
2021-06-17 16:22:01.850 4551-4551/com.rn065 E/SoLoader: couldn't find DSO to load: libjscexecutor.so
    	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
    	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
    	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
    	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
    	Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
2021-06-17 16:22:01.860 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:02.166 4551-4551/com.rn065 D/NetworkSecurityConfig: No Network Security Config specified, using platform default
2021-06-17 16:22:02.206 4551-4588/com.rn065 D/SoLoader: About to load: libfbjni.so
2021-06-17 16:22:02.212 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /data/data/com.rn065/lib-main
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /vendor/lib64
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /system/lib64
2021-06-17 16:22:02.216 4551-4588/com.rn065 E/SoLoader: couldn't find DSO to load: libfbjni.so
    	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
    	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
    	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
    	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
    	Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
2021-06-17 16:22:02.218 4551-4589/com.rn065 E/AndroidRuntime: FATAL EXCEPTION: FlipperConnectionThread
    Process: com.rn065, PID: 4551
    java.lang.NoClassDefFoundError: <clinit> failed for class com.facebook.flipper.android.EventBase; see exception in other thread
        at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)
2021-06-17 16:22:02.221 4551-4588/com.rn065 E/AndroidRuntime: FATAL EXCEPTION: FlipperEventBaseThread
    Process: com.rn065, PID: 4551
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so
    	SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
    	SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
    	SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
    	SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
    	Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:918)
        at com.facebook.soloader.SoLoader.loadLibraryBySoNameImpl(SoLoader.java:740)
        at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:654)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:634)
        at com.facebook.soloader.NativeLoaderToSoLoaderDelegate.loadLibrary(NativeLoaderToSoLoaderDelegate.java:29)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:51)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:30)
        at com.facebook.jni.HybridData.<clinit>(HybridData.java:34)
        at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)
2021-06-17 16:22:02.221 4551-4588/com.rn065 I/Process: Sending signal. PID: 4551 SIG: 9

I hope I have helped in something.

kelset

comment created time in 3 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

thanks so much, I'll give it a go

kelset

comment created time in 3 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

kelset

comment created time in 3 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

I'm experiencing an error on 0.65.0-rc.1 building for iOS

  • Intel Mac with Xcode 12.5
  • With Hermes enabled
  • Flipper upgraded to 0.93 via Podfile use_flipper!({ 'Flipper' => '0.93.0' }) (same error occurs without this)
duplicate symbol 'folly::detail::str_to_bool(folly::Range<char const*>*)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
duplicate symbol 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
ld: 2 duplicate symbols for architecture x86_64

From the Podfile.lock:

    - RCT-Folly (= 2021.04.26.00)
  - Flipper (0.93.0):
    - Flipper-Folly (~> 2.6)
    - Flipper-RSocket (~> 1.4)
  - Flipper-Boost-iOSX (1.76.0.1.11)
  - Flipper-DoubleConversion (3.1.7)
  - Flipper-Fmt (7.1.7)
  - Flipper-Folly (2.6.7):
    - Flipper-Boost-iOSX
    - Flipper-DoubleConversion
    - Flipper-Fmt (= 7.1.7)
    - Flipper-Glog
    - libevent (~> 2.1.12)
    - OpenSSL-Universal (= 1.1.180)
    ```


I have cleaned the project, reinstalled pods etc.

Any ideas? Thanks
kelset

comment created time in 3 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

@kelset yes the android startup crash is still there IOS is building fine for me on a none M1 machine. ( with / without heremes ).

kelset

comment created time in 3 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC1 phase

hey folks - we did testing and because we had a double ✅ (two different machines doing the full suite of local e2e tests successfully) we proceeded with RC1.

But it seems that the Android startup crash is still there, at least on my machine. So the investigation is still open for that... 😓

kelset

comment created time in 3 days

issue commentreact-native-community/discussions-and-proposals

Accessibility focus order in React Native

Thanks so much for creating this, @louy. Does anyone know if there is any movement on RN accessibility enhancements and focus order control? Given that so many of us are having to hack together multiple workarounds, a tabIndex-type option or more accessibility options and control should definitely be prioritized.

louy

comment created time in 4 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC0 phase

@janicduplessis thanks for the pointer Janic! I saw @PeteTheHeat's commit but when I read in the PR body that it was fixing an issue for CircleCI I assumed it wasn't needed - but I guess cherry picking it wouldn't harm anyway?

kelset

comment created time in 4 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC0 phase

I'm unable to build my app on iOS using Xcode 12.5 (intel macOS 11.4). It built fine on 0.64.2. I've used react-native-clean-project and the result is still the same after reinstalling everything.

CompileC Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o Pods/RCT-Folly/folly/Singleton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods')
    cd Pods
    export LANG\=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -target x86_64-apple-ios9.0-simulator -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=c++14 -stdlib\=libc++ -fmodules -fmodules-cache-path\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Werror\=deprecated-objc-isa-usage -Werror\=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -g -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path Index/DataStore -IBuild/Products/Debug-iphonesimulator/RCT-Folly/include -IPods/Headers/Private -IPods/Headers/Private/RCT-Folly -IPods/Headers/Public -IPods/Headers/Public/DoubleConversion -IPods/Headers/Public/RCT-Folly -IPods/Headers/Public/fmt -IPods/Headers/Public/glog -IPods/Headers/Public/libevent -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/Headers/Public/libevent/event -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources-normal/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources -FBuild/Products/Debug-iphonesimulator/RCT-Folly -DFOLLY_NO_CONFIG -DFOLLY_MOBILE\=1 -DFOLLY_USE_LIBCPP\=1 -DFOLLY_HAVE_PTHREAD\=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-documentation -w -Xanalyzer -analyzer-disable-all-checks -include Pods/Target\ Support\ Files/RCT-Folly/RCT-Folly-prefix.pch -MMD -MT dependencies -MF Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.d --serialize-diagnostics Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.dia -c Pods/RCT-Folly/folly/Singleton.cpp -o Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:648:29: error: no matching function for call to 'compile'
  constexpr auto compiled = detail::compile<Args...>(S());
                            ^~~~~~~~~~~~~~~~~~~~~~~~
Pods/RCT-Folly/folly/Singleton.cpp:161:25: note: in instantiation of function template specialization 'fmt::v7::format<FMT_COMPILE_STRING, folly::Range<const char *>, 0>' requested here
  auto const msg = fmt::format(FOLLY_FMT_COMPILE(
                        ^
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:582:16: note: candidate template ignored: requirement 'is_compile_string<FMT_COMPILE_STRING>::value' was not satisfied [with Args = <folly::Range<const char *>>, S = FMT_COMPILE_STRING]
constexpr auto compile(S format_str) -> detail::compiled_format<S, Args...> {
               ^
Pods/Headers/Public/fmt/fmt/compile.h:589:6: note: candidate template ignored: could not match 'const Char [N]' against 'FMT_COMPILE_STRING'
auto compile(const Char (&format_str)[N])
     ^
1 error generated.

You can add pod "fmt", "~> 6.2.1" to your podfile and it should fix that build issue. Looks like https://github.com/facebook/react-native/commit/d208e7d6ad4738bc85a0ab78a50c59bddac07174#diff-5de3520951eb222bc3b5b734cc1003e84a53fb42220159fedc58768bda2e2cf3 fixes it on master. We should cherry-pick that.

kelset

comment created time in 4 days

issue commentreact-native-community/releases

Road to v0.65.0 - RC0 phase

quick update: commits so far have been reverted/cherry-picked according to top post (which should include all suggestions from the comments so far) and it will be tested for a bit, if testing shows that we have fixed the Android problem we'll likely to do an RC1 before end of the week.

kelset

comment created time in 4 days

issue openedreact-native-community/discussions-and-proposals

Expose property to modify the Alert button colours in Alert on Android platform

Hi,

There is a requirement to update the Alert button colours in android as per the application's colour theme dynamically. Is there any roadmap in future that plans to implement this and expose a property to set the text colour of Alert buttons on Android platform. If yes, by when the feature should be available. If no, what is the alternative solution without rewriting the complete code?

created time in 4 days

pull request commentreact-native-community/releases

Fix typo

thanks!

matinzd

comment created time in 4 days

push eventreact-native-community/releases

Matin Zadehdolatabad

commit sha 996f11d08c5c163aeac361bc2ad7c01b4a6cf4ce

Fix typo (#237)

view details

push time in 4 days

PR merged react-native-community/releases

Fix typo

Fix typo in the changelog suppport to support

+2 -2

0 comment

1 changed file

matinzd

pr closed time in 4 days

PR opened react-native-community/releases

Fix typo

Fix typo in the changelog suppport to support

+2 -2

0 comment

1 changed file

pr created time in 5 days

release nodejs/node

v14.17.1

released time in 5 days

issue closedreact-native-community/discussions-and-proposals

Integrating react-native-web to an Existing React-Project without using expo-cli

Introduction My team and I are trying to re-use existing code from React-Native Projects for React (Web) projects, the documentation we used to follow this particular line-of-action was https://necolas.github.io/react-native-web/docs/installation/ This is the documentation for the package React-Native-Web, However, you might observe that while installing the react-native-web package the default CLI used in the installation steps is Expo-CLI, this is a tool we are trying to prevent using. Expo-CLI has several limitations which we want to avoid at this phase of our development process! Limitations of EXPO-CLI - https://docs.expo.io/introduction/why-not-expo/

DETAILS - To install react-native-web package in an existing project - In the repo. of the existing project, we execute the following commands - npm install react-dom react-native-web npx expo-cli start

Now this works fine, but my team has decided not to use the expo-cli, expo-cli has a lot of limitations, which we are trying to avoid in production, and we are leaning towards using bare react-native cli only. One resource that I had suggested was this https://medium.com/@aureliomerenda/create-a-native-web-app-with-react-native-web-419acac86b82

However this is not official documentation, and my team was looking for an official(community-supported) way of doing the exact same thing that has been done in the above blog!

Conclusion In the official documentation, The only methodology available is that of using expo-cli, an alternative way to do the same, i.e integrating react-native-web in an existing react-native project in production will be appreciated! We had also raised an issue here - https://github.com/react-native-community/discussions-and-proposals/issues/352 But it was shunned away, quite quickly, I hope the community understands our concerns first fully and then closes this issue!

closed time in 5 days

nairsajjal

issue commentreact-native-community/discussions-and-proposals

Integrating react-native-web to an Existing React-Project without using expo-cli

👋 there - as stated in the README and the issue template, this repo is for long-form discussions on React Native. Yours seems more a question for StackOverflow instead.

This is not a support forum to ask questions, I hope you can understand that :)

nairsajjal

comment created time in 5 days

issue closedreact-native-community/discussions-and-proposals

Scrollview zoom option for android

<!-- Thank you for starting a discussion about React Native!

Please follow the structure shown below.

Note: Issues should be limited to long-form discussions. If you have a proposal, please add it via a Pull Request. -->

Introduction

Hi, I think it would be great if scrollview's zoom option has android support.

<!-- A brief intro about the topic you want to discuss. -->

Details

Since there is so lack of lib for react native zoom lib, It is so hard to implement pinch to zoom function for android.

The zoom function for ios is great and It would be even greater if we could implement using just scrollview. (with same code)

<!-- Details about what you want to discuss. -->

Discussion points

Android support for Scrollview's zoom options.

<!-- Summarize the main points you want to focus the discussion on. -->

closed time in 5 days

ktjd123

pull request commentreact-native-community/releases

Update CHANGELOG.md - typo

thanks!

adrien-may

comment created time in 5 days

push eventreact-native-community/releases

Adrien Brunet

commit sha 16fa8ff714fcf04bb3ce368417397b20538feda9

Update CHANGELOG.md - typo (#236)

view details

push time in 5 days