profile
viewpoint
Bartosz Kaszubowski Simek @vizum & @SentiOne Gdańsk, Poland simek.dev Full Stack Developer & UI/UX Designer. Scala, Rust, JS & any form of React.

Simek/css_browser_selector 3

A very small javascript library that allows you to create browser, platform, device, and even version specific CSS to be merged into your normal classes. No more hacks or mischievous code in your CSS.

SakulK/htmlcleaner 0

Fork http://sourceforge.net/projects/htmlcleaner/

Simek/babel 0

Babel is a compiler for writing next generation JavaScript.

Simek/boinc 0

Open-source software for volunteer computing and grid computing.

Simek/brackets 0

An open source code editor for the web, written in JavaScript, HTML and CSS.

Simek/desktop 0

Simple collaboration from your desktop

Simek/dolphin 0

Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.

Simek/es6features 0

Overview of ECMAScript 6 features

PR opened facebook/react-native-website

add deprecation notice to the Geolocation page

Refs #1554

This small PR adds deprecation notice to the Geolocation page to prevent confusion and similar problems mentioned in issue linked above.

Screenshot 2020-02-27 at 10 30 03

+3 -1

0 comment

1 changed file

pr created time in 2 hours

create barnchSimek/react-native-website

branch : geolocation-deprecation-note

created branch time in 2 hours

issue commentfacebook/react-native-website

Documentation links are broken

@suraneti LGTM right now, can we close this issue?

suraneti

comment created time in 2 hours

pull request commentfacebook/react-native-website

docs: update typescript template for 0.61

@Naturalclar You did not commit changes generated by Docuosaurus while running site:

Screenshot 2020-02-27 at 09 47 51

@rachelnabors Is there any way we can config deploy bot to fail in such situation?

Naturalclar

comment created time in 3 hours

PR opened facebook/react-native-website

extract two sections from the Performance docs to separate pages

After latest changes to the docs structure and sidebar I have noticed that Performance page is quite long and extensive in comparison to the other pages.

This PR extracts Profiling and RAM Bundles and Inline Requires sections to the separate pages under "Performance" menu. Also main performance related page has been renamed to Performance Overview.

I'm not sure about proposed pages order in the sidebar and naming but overall this changes should improve readability (I have adjusted headings also to produce better secondary navigation - located on the right side - for the new pages). I'm open to feedback for the changes and I can improve this PR if it will be requested.

Refs #1659 - due to latest changes related to URL it was easier to repost PR rather than force push it.

Preview: Screenshot 2020-02-24 at 16 13 48

+343 -325

0 comment

5 changed files

pr created time in 3 hours

push eventSimek/react-native-website

simek

commit sha 9ecddbe702667ce594174bdde15373deed625489

extract two sections from the Performance docs to separate pages

view details

push time in 3 hours

create barnchSimek/react-native-website

branch : extract-performance-sections

created branch time in 3 hours

PR closed facebook/react-native-website

Reviewers
extract two sections from the Performance docs to separate pages

After latest changes to the docs structure and sidebar I have noticed that Performance page is quite long and extensive in comparison to the other pages.

This PR extracts Profiling and RAM Bundles and Inline Requires sections to the separate pages under "Performance" menu. Also main performance related page has been renamed to Performance Overview.

I'm not sure about proposed pages order in the sidebar and naming but overall this changes should improve readability (I have adjusted headings also to produce better secondary navigation - located on the right side - for the new pages). I'm open to feedback for the changes and I can improve this PR if it will be requested.

Preview: Screenshot 2020-02-24 at 16 13 48

+340 -325

1 comment

5 changed files

Simek

pr closed time in 3 hours

delete branch Simek/react-native-website

delete branch : extract-performance-sections

delete time in 3 hours

push eventSimek/react-native-website

Justin Ross

commit sha 7f7f9261f10629eb6e8152e5c2c487ab9c8802d0

Clarify installation recommendation for react-native CLI. (#1657) * Clarify installation recommendation for react-native CLI. * Add react-native CLI installation recommendations to .60 and .61 docs. * Add RN CLI usage recommendation to .60 and .61 docs.

view details

NBC News Channel

commit sha b57f7712c5a2a740181a28714600ab3db9c28b30

Updated location of Developer Options (#1658) Developer options are under Settings -> System

view details

Jesse Katsumata

commit sha 34f45747125cbfe674cfe81f2be0504039272e83

docs: fix link for segmented control community package (#1656)

view details

Luiz Celso de Faria Alves

commit sha 2bc24996cbefd18fe96ebc067a9ef4074788070e

Update page stylesheet (#1626) Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>

view details

Miguel Alejandro Bolivar Portilla

commit sha aa1d0059e5e36adbd72b7fa508fbb89f5a0f41d6

docs: Modal updated API and examples (#1605) * New structure for class and functional components examples - Adding new code blocks as shown by @rachelnabors - Adding better styling for example - Only initial functional example added * Updating example of class based component * Prettier code and adding correct SnackPlayer naming * Adding toggles for function or class component and fixing 'setModalVisible' call * Adding missing this.setModalVisible on class example * Update modal.md Seems like modal should work on Web Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>

view details

Tahir Awan

commit sha 844db2333d116103dbf0130f5db7569442c373a0

added functional component examples with hooks (#1623) * added functional component examples with hooks added functional component examples with hooks * Prettifying text snack Also, I don't think we need class component examples pas the first! * Removing stray endBlcok Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>

view details

R Nabors

commit sha 1a7c586883b73e1515a208e5adf780308b6b4332

New domain for RN Docs: reactnative.dev (#1662) * update config * Updating readme * replacing http://.. * updating /docs/ links * updating versioned docs and website * updating all links to /blog/ * updating absolute path img assetsmostly in demo code * Fixing old broken blog links * last of the absolute URLs * replacing inline root md links to (/react-native/.. * making sure .md links aren't broken. Doesn't seem an issue in /docs/ but was an issue in /blog * last of the /react-native/s * Mergery!

view details

R Nabors

commit sha f2a5ad1ca335e5fab2f302270c1301beca023a21

Adding new domain cname to siteconfig

view details

Jesse Katsumata

commit sha ef283c9072e3b6e746e8e9e7f2ba6b569e22c56a

docs: update typescript template for 0.61 (#1668)

view details

Kaio Duarte

commit sha eacf788bf3b08c10966d638443d8f395a2ce57de

add Shadow Props example (#1664)

view details

Jesse Katsumata

commit sha 14f861accb073cd9bf97a71f0f523c52b85af708

chore: renew url (#1667) * chore: renew url * Making inputaccessoryview link more flexible Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>

view details

Tahir Awan

commit sha 49afce0c473e279e77bd0442b39d34202b505565

updated example to use functional components and hooks (#1666) * updated example to use functional components and hooks updated example to use functional components and hooks * Prettier-ed the code + added styling Co-authored-by: R Nabors <rachelnabors@users.noreply.github.com>

view details

R Nabors

commit sha 65a011fa6517537768425075b6b59f5ba5178fa7

Add class component example to View (#1653) * Add class component example to View Seemed like the right thing to do * Update view.md Typo in snack player!

view details

push time in 3 hours

startedalpinejs/alpine

started time in 20 hours

pull request commentfacebook/react-native-website

New domain for RN Docs: reactnative.dev

Repository description also needs an update. But unfortunately currently I cannot access website by https://reactnative.dev/ URL due to SSL certificate signing/configuration issue.

rachelnabors

comment created time in 3 days

pull request commentfacebook/react-native-website

New domain for RN Docs: reactnative.dev

Also some of .md extensions were removed from the links but there are still 250+ occurrences in the master docs. Is it desirable to remove all of them?

rachelnabors

comment created time in 3 days

Pull request review commentfacebook/react-native-website

New domain for RN Docs: reactnative.dev

 You can also use the `async` / `await` syntax in a React Native app: ```jsx async function getMoviesFromApiAsync() {   try {+<<<<<<< HEAD

There are Git merge chunks committed in docs/network.md.

rachelnabors

comment created time in 3 days

issue commentfacebook/react-native-website

Component Docs Drive

@rachelnabors Sorry for bringing up this topic here. I have some basic knowledge about versioning in Docasurus but in my opinion the right process depends on final effect you want to archive. We can continue discussion on the Discord, since I'm not a frequent user of my Twitter. My Discord handle is Simek#2069.

rachelnabors

comment created time in 3 days

issue openedreact-navigation/react-navigation

Allow passing custom `containerStyle` for StackItem or add ability to override default behaviour

Currently due to implementation when user is using headerTransparent: true and custom header (headerBackground) it's not possible to retain top margin (safe area) under header element.

https://github.com/react-navigation/stack/blob/ee241aacd5dab42e27302df78f0cef8a43d99126/src/views/Stack/StackItem.tsx#L141-L145

It will be nice if we can pass headerContainerStyle object or alternatively headerMode === 'float' && !headerTransparent && !hasCustomHeader logic could be overridden by flag.

created time in 3 days

push eventSimek/react-native-website

simek

commit sha 40d671e6865456b95afdf86bbcfab24e150f4ab4

extract two sections from the Performance docs to separate pages

view details

push time in 3 days

PR opened facebook/react-native-website

extract two sections from the Performance docs to separate pages

After latest changes to the docs structure and sidebar I have noticed that "Performance" page is quite long and extensive in comparison to the other pages.

This PR extracts "Profiling" and "RAM Bundles and Inline Requires" sections to the separate pages under "Performance" menu. Also main performance related page has been renamed to "Performance Overview".

I'm not sure about proposed pages order in the sidebar and naming but overall this changes should improve readability (I have adjusted headings also to produce better secondary navigation - located on the right side - for the new pages). I'm open to feedback for the changes and I can improve this PR if it will be requested.

Preview: Screenshot 2020-02-24 at 16 13 48

+341 -325

0 comment

5 changed files

pr created time in 3 days

create barnchSimek/react-native-website

branch : extract-performance-sections

created branch time in 3 days

issue commentfacebook/react-native-website

Component Docs Drive

@rachelnabors Can you claryfiy how you would like to perform changes to deprecated components mentioned in https://github.com/facebook/react-native-website/issues/1579#issuecomment-588361038? I have created an explanation why I'm not sure how to do this properly here: https://github.com/facebook/react-native-website/issues/1579#issuecomment-588812978. If my explanation is still foggy or confusing instead of clarifying I can try explain it again in different words.

rachelnabors

comment created time in 3 days

push eventSimek/react-native-website

MJ Studio

commit sha a8a44d6f78f1e69bd7b944acb0046ca1cdc107a9

ImagePicker RequestCode update (#1634) 467081 for startActivityForResult request code is upper 16bit. so Error will be invoked.

view details

Afolabi Aiyeloja

commit sha 8f7e1f80a926ebb156df29e678c12e28398988b7

Updated running-on-device.md making signing for Test more noticeable (#1547) * Update running-on-device.md * Update running-on-device.md

view details

Nieck Bennink

commit sha 8fbca1f997d6ac1c019e563903eefba702b1c320

Fix (communication-ios): Link to Geolocation library (#1581)

view details

Bartosz Kaszubowski

commit sha d8ed2e39b53fa642afff6b707909a1bdd7f73b5d

add fetch class component example (#1652) * add fetch class component example * remove unnecessary line break

view details

Jesse Katsumata

commit sha 4b58762fb964a6f1548884c8d1971dd2da4eb5c3

docs: arrange Image Props in alphabetical order (#1651)

view details

Pablo Espinosa

commit sha 601baa6768b86f543ef9f672e959df54c7f00506

TouchableNativeFeedback: Added Snack example using Hooks and Functional Components (#1646) Removed formatting

view details

luism3861

commit sha 19a484e9f7536c5e0ad17bd447df4e8f802de627

Update Example state.md with Hooks (#1627) * update example state to hooks * change for new suggestion

view details

Seth

commit sha fd9a179f618f3928914e6566ee92ea1180736c1a

Update conferences information (#1625) Add React Conf 2019 playlist and remove reference to previous conference, its out of date.

view details

Marta Dabrowka

commit sha fac2ae356350b2c7f1805ef8ad81faee91367f54

Refactor AccessibilityInfo Example into React Hooks (#1629) * Rewrite jsx example using React Hooks * Add a SnackPlayer example * Remove redundant character * Embed functional and class component in toggler syntax

view details

Abraham Nnaji

commit sha 2b37a56d4c19b390e1b1740fdae87fca707401b6

Added snack example for virtualized list (#1632)

view details

push time in 4 days

push eventSimek/react-native-website

simek

commit sha e53edd5f814e30fd3840f9429856875e93d23a52

remove unnecessary line break

view details

push time in 6 days

PR opened facebook/react-native-website

add fetch class component example

Refs #1649.

This PR adds fetch Class Component example to the Networking page. Also function names in code blocks above example has been corrected and one of variables has been renamed to match naming used in examples below. ES version and "proposal" mention has been deleted since async is widely used and it's not a very meaningful detail after all.

+70 -7

0 comment

1 changed file

pr created time in 6 days

create barnchSimek/react-native-website

branch : fetch-class-component-example

created branch time in 6 days

push eventSimek/react-native-website

Kacper Wiszczuk

commit sha 241c0e675cb35091ea3a79cfcad6b46fac52ee7e

fix: Snack samples from progress things

view details

Shahzore Qureshi

commit sha ba47abdeb36a20c8d48ff986c739a3808d336c66

Update textinput.md Added missing prop for textAlign.

view details

paulshelestovich

commit sha 600c1113dab2718ce615ebdd615b7fdac2c2632e

Bug with extra back-ticks is fixed unnecessary back-ticks are breaking the layout of the page and the last example

view details

Pablo Espinosa

commit sha f0bf1e19e75c657bcac3b3ee3193342aac4644fd

Updated docs to reflect exceptions when using the Linking API with a simulator https://github.com/facebook/react-native/pull/26607

view details

Kacper Wiszczuk

commit sha b06d9137a68de46c44e70c3e0186e83989abd900

Merge remote-tracking branch 'origin' into images-5

view details

Kacper Wiszczuk

commit sha 826b73ce73eb94e6126fe828a1dd16b75b8cea6a

Update platform specific thing

view details

Blake Knight

commit sha cb4f2157ed09679dd1a8265c543dafbe0357e478

:pencil: fix the PushNotificationIOS Podfile example

view details

kyarik

commit sha 26b8c13c215a6f5e27044f002418c8ebcbc2d7f2

Fixes to Layout with Flexbox

view details

kyarik

commit sha 42c2769ec0dac154c8f603b4177362ab375b8c74

More fixes

view details

Pavol Fulop

commit sha fdb9fbdb0d77a1c45f492275fa3ec8357d7b74ca

Option to put android modal behind statusbar

view details

Enes Poyraz

commit sha 5e3b5b2a62bffb3d0adaccccd1097590cd33393b

Update text to Node 12 LTS

view details

Alireza Ghamkhar

commit sha 62440acfcb18107adf08433733d49d3fec865f73

Sort props in picker.md

view details

Alireza Ghamkhar

commit sha 4cf8c4dfdcfc1127ff865c5292a4d47065431da4

Add snack player for the example in picker.md

view details

haruelrovix

commit sha aaba5997685b1965a3219a2ced3eb0ebc107a03e

fix: Invalid DOM property and unique key warnings

view details

dependabot[bot]

commit sha f0f6ea11f5fe7f3d15d2ec97ab1719ac741abb25

Bump lodash.merge from 4.6.1 to 4.6.2 in /website Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

StephenDocP

commit sha 5caa6ed994a23e8ff975f5a21ce7d041697f743c

Add warning about AAB and Hermes

view details

Isabel Bolger

commit sha 9e5df15c349d098a59af51f1fa5b3d4a6641a378

removed the line that says onSubmitEditing is invalid if multiline={true}

view details

Isabel Bolger

commit sha 4f918e0c45b3c88172b59594437c968859c9da50

removed additional lines from other textinput files

view details

Grzegorz Dominiczak

commit sha 327792306c8c6b762cca0b3ff2488cf722b45a71

Fix application:didReceiveRemoteNotification:fetchCompletionHandler: documentation link

view details

Omar López

commit sha 07e77597e31abb058f2b67417128241e29650c7d

Fixes link to cheatsheet

view details

push time in 6 days

pull request commentfacebook/react-native-website

rewrite fetch example using hooks

No problem 😉 I'll prepare separate PR with rewritten component class example and tabs later today.

Simek

comment created time in 6 days

startedsaadpasta/react-blog-github

started time in 6 days

delete branch Simek/react-native-website

delete branch : patch-11

delete time in 7 days

PR opened facebook/react-native-website

rewrite fetch example using hooks

Refs #1579, #1272.

Same as with earlier PR, this page is not a part of "Component Docs Drive" but I think it will be a good supplementary improvement to those changes.

@rachelnabors Question is if class component example should be rewritten and retained (using tabs) or we can just replace it?

+24 -46

0 comment

1 changed file

pr created time in 7 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha c4c9f7839e59c3d08f97d420e50dfbc3c6712ff4

rewrite fetch example using hooks

view details

push time in 7 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 85fb4fbc9639f57fc349eb90990aedc2a832bff6

rewrite fetch example using hooks

view details

push time in 7 days

issue commentfacebook/react-native-website

Component Docs Drive

@lcelso I think that Slack/Teams/Discord channel will help with communication but you should remember that this is still a Facebook repo which is not officially maintained by the community.

In my opinion creating this kind of communication platform should be approved and managed by FB employees (maintainers). If your idea got a green light of course I will join along.

rachelnabors

comment created time in 7 days

issue commentfacebook/react-native-website

Component Docs Drive

@rachelnabors I think that "API" link in top bar which leads to ActivityIndicator instead of Components and APIs in next docs do not help either 😉

Back to the deprecation discussion - I would like to help with those changes but I'm still not 100% sure how to perform them.

In my opinion, in some point in time 0.61 docs should be regenerated to include all the work from this issue and more changes that landed on the next docs during last months (I assume this should happen before or on 0.62 release?).

Merging sidebar and Components and APIs deprecation cleanup PRs before refreshing 0.61 will cause a loss of some improvements (mainly deprecation indicators and notes because they are currently only on the next docs and are targeted to be deleted before/on 0.62 release). That is also the reason why I was talking about generating 0.62 docs when you asked about sidebar changes in earlier discussion.

rachelnabors

comment created time in 7 days

issue commentfacebook/react-native-website

Component Docs Drive

@rachelnabors Are there any planned changes for the Components and APIs page? Would you like to mark in some way or even remove deprecated pages listed in there?

rachelnabors

comment created time in 8 days

delete branch Simek/react-native-website

delete branch : patch-11

delete time in 9 days

delete branch Simek/react-native-website

delete branch : patch-12

delete time in 9 days

PR opened facebook/react-native-website

simplify "Using a ScrollView" docs example

Refs #1579.

This is not a part of API documentation but I think that current example on the "Using a ScrollView" page could be improved as well.

+44 -42

0 comment

1 changed file

pr created time in 9 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha e0b0cadc9c7fedd42c0d682d0b00a3b6eab0dd21

simplify "Using a ScrollView" docs example

view details

push time in 9 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha c751d8b363ebe118b742244e9d9ca045741638ec

simplify "Using a ScrollView" docs example

view details

push time in 9 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha ad59ff1a0e9a40174f50975734f09782435b1e33

Simplify "Using a ScrollView" docs example

view details

push time in 9 days

pull request commentfacebook/react-native-website

Image & View: add snack examples to use functional components

@amandeepmittal No problem, thank you for the contribution! 😄

amandeepmittal

comment created time in 9 days

issue commentfacebook/react-native-website

Component Docs Drive

@rachelnabors Could you asses the idea proposed in https://github.com/facebook/react-native-website/issues/1579#issuecomment-583735028?

rachelnabors

comment created time in 9 days

Pull request review commentfacebook/react-native-website

Image & View: add snack examples to use functional components

 The most fundamental component for building a UI, `View` is a container that sup  This example creates a `View` that wraps two boxes with color and a text component in a row with padding. -```jsx-class ViewBoxesWithColorAndText extends Component {-  render() {-    return (-      <View-        style={{-          flexDirection: 'row',-          height: 100,-          padding: 20,-        }}>-        <View style={{backgroundColor: 'blue', flex: 0.3}} />-        <View style={{backgroundColor: 'red', flex: 0.5}} />-        <Text>Hello World!</Text>-      </View>-    );-  }+```SnackPlayer name=Example%20Code+import React from 'react';+import { View, Text } from 'react-native';++const ViewBoxesWithColorAndText= () => {

Missing space 😉

amandeepmittal

comment created time in 10 days

Pull request review commentfacebook/react-native-website

Image & View: add snack examples to use functional components

 The most fundamental component for building a UI, `View` is a container that sup  This example creates a `View` that wraps two boxes with color and a text component in a row with padding. -```jsx-class ViewBoxesWithColorAndText extends Component {-  render() {-    return (-      <View-        style={{-          flexDirection: 'row',-          height: 100,-          padding: 20,-        }}>-        <View style={{backgroundColor: 'blue', flex: 0.3}} />-        <View style={{backgroundColor: 'red', flex: 0.5}} />-        <Text>Hello World!</Text>-      </View>-    );-  }+```SnackPlayer name=Example%20Code+import React from 'react';+import { View, Text } from 'react-native';++const ViewBoxesWithColorAndText= () => {+  return (+    <View+      style={{+        flexDirection: 'row',+        height: 100,+        padding: 20,+      }}>+      <View style={{ backgroundColor: 'blue', flex: 0.3 }} />+      <View style={{ backgroundColor: 'red', flex: 0.5 }} />+      <Text>Hello World!</Text>+    </View>+  ); }

Missing semicolon 😉

amandeepmittal

comment created time in 10 days

Pull request review commentfacebook/react-native-website

Image & View: add snack examples to use functional components

 export default class DisplayAnImageWithStyle extends Component {     );   } }

Missing semicolon 😉

amandeepmittal

comment created time in 10 days

Pull request review commentfacebook/react-native-website

Image & View: add snack examples to use functional components

 This example shows fetching and displaying an image from local storage as well a  > Note that for network and data images, you will need to manually specify the dimensions of your image! -```SnackPlayer name=Image+<div class="toggler">+  <ul role="tablist" class="toggle-syntax">+    <li id="functional" class="button-functional" aria-selected="false" role="tab" tabindex="0" aria-controls="functionaltab" onclick="displayTabs('syntax', 'functional')">+      Function Component Example+    </li>+    <li id="classical" class="button-classical" aria-selected="false" role="tab" tabindex="0" aria-controls="classicaltab" onclick="displayTabs('syntax', 'classical')">+      Class Component Example+    </li>+  </ul>+</div>++<block class="functional syntax" />++```SnackPlayer name=Function%20Component%20Example++import React from 'react';+import { View, Image, StyleSheet } from 'react-native';++const styles = StyleSheet.create({+  container: {+    paddingTop: 50,+  },+  tinyLogo: {+    width: 50, +    height: 50,+  },+  logo: {+    width: 66, +    height: 58,+  },+});++const DisplayAnImage = () => {+  return (+    <View style={styles.container}>+      <Image+        style={styles.tinyLogo}+        source={require('@expo/snack-static/react-native-logo.png')}+      />+      <Image+        style={styles.tinyLogo}+        source={{+          uri: 'https://facebook.github.io/react-native/img/tiny_logo.png',+        }}+      />+      <Image+        style={styles.logo}+        source={{+          uri:+            'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADMAAAAzCAYAAAA6oTAqAAAAEXRFWHRTb2Z0d2FyZQBwbmdjcnVzaEB1SfMAAABQSURBVGje7dSxCQBACARB+2/ab8BEeQNhFi6WSYzYLYudDQYGBgYGBgYGBgYGBgYGBgZmcvDqYGBgmhivGQYGBgYGBgYGBgYGBgYGBgbmQw+P/eMrC5UTVAAAAABJRU5ErkJggg==',+        }}+      />+    </View>+  );+}++export default DisplayAnImage;+```++<block class="classical syntax" />++```SnackPlayer name=Class%20Component%20Example+ import React, { Component } from 'react';-import { View, Image } from 'react-native';+import { AppRegistry, View, Image, StyleSheet } from 'react-native';++const styles = StyleSheet.create({+  container: {+    paddingTop: 50,+  },+  tinyLogo: {+    width: 50, +    height: 50,+  },+  logo: {+    width: 66, +    height: 58,+  },+});  export default class DisplayAnImage extends Component {   render() {     return (-      <View>+      <View style={styles.container}>         <Image-          style={{width: 50, height: 50}}+          style={styles.tinyLogo}           source={require('@expo/snack-static/react-native-logo.png')}         />         <Image-          style={{width: 50, height: 50}}+          style={styles.tinyLogo}           source={{uri: 'https://facebook.github.io/react-native/img/tiny_logo.png'}}         />         <Image-          style={{width: 66, height: 58}}+          style={styles.logo}           source={{uri: 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADMAAAAzCAYAAAA6oTAqAAAAEXRFWHRTb2Z0d2FyZQBwbmdjcnVzaEB1SfMAAABQSURBVGje7dSxCQBACARB+2/ab8BEeQNhFi6WSYzYLYudDQYGBgYGBgYGBgYGBgYGBgZmcvDqYGBgmhivGQYGBgYGBgYGBgYGBgYGBgbmQw+P/eMrC5UTVAAAAABJRU5ErkJggg=='}}         />       </View>     );   } }

Missing semicolon 😉

amandeepmittal

comment created time in 10 days

startedCSSEGISandData/COVID-19

started time in 14 days

pull request commentfacebook/react-native-website

added clipboard example

@brunokiafuka Hi and thank you for your contribution. Currently we need to wait for maintainers decision, please check out my comment for the more details: https://github.com/facebook/react-native-website/issues/1579#issuecomment-583735028

brunokiafuka

comment created time in 17 days

startednysamnang/react-native-raw-bottom-sheet

started time in 19 days

issue commentfacebook/react-native-website

Component Docs Drive

@lcelso I agree that developing examples could be a bit more difficult due to fact that code is embedded in Markdown. Having examples in separate JS files would be nice (for example we can setup linter than etc.) but changing project architecture and converting all docs could be a challenging and daunting process. I don't even know if it's possible within Docusaurus. Also switch to Gatsby is not likely since Docusaurus is a Facebook product and Gatsby is not (also purpose of those platforms is bit different).

Many code editors/IDEs this days can highlight JS code properly inside other type files (screenshot). Running website on localhost and developing with live preview also helps a lot.

But back to main topic. Since Clipboard API is being deprecated (#1608) I would like to propose removal of this API from the TODO list. I'm sorry for that to the #1599 and #1604 authors.

It's also a good opportunity to start conversation about removing ALL existing examples from the deprecated components (leaving short description and reference only) before next major release. This whole idea started here https://github.com/facebook/react-native-website/pull/1583#issuecomment-583345444.

Few pages in the master docs right now follow this pattern (ImageEditor, PickerIOS, Slider) but most of deprecated pages include examples. In my opinion removing those examples can force (mainy new) users to follow deprecation notice and use the proper maintained and up to date package which always contains an example or a few of them in the README.

rachelnabors

comment created time in 19 days

issue commentfacebook/react-native-website

Component Docs Drive

I was reviewing today a few PRs related to this issue and I would like to summarize some tips according to code quality and best practices of those new examples.

There are minor things but overall this code could be used by many developers and mistakes or negligence here could be replicated further. There is no bad intent I just assume that we all want to have the best examples here 😉

Please pay a bit attention for those details if possible:

  • work on master docs (docs/*.md) not versioned ones (website/versioned_docs/version-0.*/*.md)
  • extract styles to StyleSheet outside of component if necessary
  • use arrow function instead of function keyword
  • sort imports alphabetically
  • remember about semicolons (especially after exports)
  • use same quotation marks across whole example (I don't know which are prefered here " or ' but be consistent)
  • remember about specifying supportedPlatforms for the Snack if component requires that (example: c7c7929dfa0c20af5bf953c45708ce21ca0019f8)
  • brake lines even more often than in your IDE - Snack code block fits only 66 characters per line
  • do not overcomplicate Snack names

That's all from me. Thank you all for your contributions. Keep up the good work!

rachelnabors

comment created time in 20 days

PR opened facebook/react-native-website

design: use same color for tabs divider as used for TOC border

This PR introduce small UI/design tweak which changes tabs divider color to the same used for TOC border:

a

Also I have made a small CSS cleanup and I have removed unnecessary code (probably leftover from the older design) for the vertical devices. As you can see below only visible change is that tabs divider is present now:

a2s

+3 -16

0 comment

1 changed file

pr created time in 20 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 16be46034257ee15367710b92474c7a2bd666e58

use same color for tabs border as TOC border and a small `tabs.css` file cleanup

view details

push time in 20 days

pull request commentfacebook/react-native-website

DatePickerIOS - Added Snack Examples 🍿

@rickhanlonii I think that @rachelnabor want only to remove entries for the deprecated components from the Sidebar and leave pages intact under versioned 0.62 urls.

@rachelnabors I can help with that, no problem. It should help if you describe exactly what is desirable effect of that change. Currently I'm assuming that you want me to to generate versioned docs for 0.62 (they do not exist ATM) and remove those pages ONLY form the Sidebar in there. Is that right?

DaniAkash

comment created time in 20 days

pull request commentfacebook/react-native-website

[#1579] update ImageBackground component doc

@lcelso I'm not here to decide, we should wait until one of maintainers take part in the discussion.

alvessteve

comment created time in 20 days

pull request commentfacebook/react-native-website

[#1579] update ImageBackground component doc

@lcelso Thank you for your suggestion.

I would change two more things, since you have extracted styles and URL to consts line breaking is no longer required:

export default App = () => (
  <View style={styles.container}>
    <ImageBackground source={image} style={styles.image}>
      <Text style={styles.text}>Inside</Text>
    </ImageBackground>
  </View>
);

and I would leave URL in original format, not shortened. Also semicolon is missing after styles const but other than that LGTM 😃

alvessteve

comment created time in 20 days

Pull request review commentfacebook/react-native-website

added snackplayer/functional component with hooks Statusbar

 Component to control the app status bar.  It is possible to have multiple `StatusBar` components mounted at the same time. The props will be merged in the order the `StatusBar` components were mounted. -```jsx-<View>-  <StatusBar backgroundColor="blue" barStyle="light-content" />-  <View>-    <StatusBar hidden={route.statusBarHidden} />-    ...-  </View>-</View>+```SnackPlayer name=rn-statusbar

I think that StatusBar will be a friendlier name 😉

Also web should be disabled using supportedPlatforms parameter since StatusBar has no visual representation on that platform.

Browndini

comment created time in 20 days

pull request commentfacebook/react-native-website

Image & View: add snack examples to use functional components

Few semicolons are missing mainly after export statements and I would prefer arrow functions over function keyword but other than that LGTM.

amandeepmittal

comment created time in 20 days

Pull request review commentfacebook/react-native-website

added clipboard example

 title: Clipboard  --- ++## Example++```SnackPlayer name=Clipboard%20API%20Example

I think that Clipboard would be a sufficient name 😉

brunokiafuka

comment created time in 20 days

Pull request review commentfacebook/react-native-website

ActivityIndicator: add snackplayer/functional component with hooks

       "toastandroid": {         "title": "ToastAndroid"       },-      "toolbarandroid": {

Thank you for the changes.

As @rachelnabors said (which apply for the both PRs) you should be updating:

  • master docs (docs/activityindicator.md)

not:

  • versioned docs (website/versioned_docs/version-0.61/activityindicator.md)
ronnyiscoding

comment created time in 20 days

pull request commentfacebook/react-native-website

docs: add deprecation notice for ProgressBars

Thank you for this PR but those changes has been requested and made within #1493 which is now merged.

Naturalclar

comment created time in 20 days

Pull request review commentfacebook/react-native-website

ActivityIndicator: added snackplayer/functional component with hooks

       "toastandroid": {         "title": "ToastAndroid"       },-      "toolbarandroid": {

@ronnyiscoding Same problem here.

ronnyiscoding

comment created time in 20 days

Pull request review commentfacebook/react-native-website

docs: add Image Style Props examples

       "toastandroid": {         "title": "ToastAndroid"       },-      "toolbarandroid": {

So it seems that someone forget to add a change generated after building app to their PR which landed on master. Regardless that this change should not be a part of this PR in my opinion.

ronnyiscoding

comment created time in 20 days

Pull request review commentfacebook/react-native-website

[#1579] update ImageBackground component doc

 You might not want to use `<ImageBackground>` in some cases, since the implement  Note that you must specify some width and height style attributes. -## Example- ```jsx-return (   <ImageBackground source={...} style={{width: '100%', height: '100%'}}>     <Text>Inside</Text>   </ImageBackground>-);+```++## Example++```SnackPlayer name=ImageBackground+  import React from 'react';+  import {View, ImageBackground, Text} from 'react-native'++  export default function App() {+    return (+      <View>+        <ImageBackground source={{uri: 'https://facebook.github.io/react/logo-og.png'}} style={{width: '100%', height: '100%'}}>

I would place source and style in separate lines (like for example https://facebook.github.io/react-native/docs/next/touchablenativefeedback) since Snack code editor is quite narrow.

alvessteve

comment created time in 20 days

Pull request review commentfacebook/react-native-website

[#1579] update ImageBackground component doc

 You might not want to use `<ImageBackground>` in some cases, since the implement  Note that you must specify some width and height style attributes. -## Example- ```jsx-return (   <ImageBackground source={...} style={{width: '100%', height: '100%'}}>     <Text>Inside</Text>   </ImageBackground>-);+```++## Example++```SnackPlayer name=ImageBackground+  import React from 'react';+  import {View, ImageBackground, Text} from 'react-native'++  export default function App() {+    return (+      <View>+        <ImageBackground source={{uri: 'https://facebook.github.io/react/logo-og.png'}} style={{width: '100%', height: '100%'}}>+          <Text style ={{color: 'white', fontSize: 20, alignSelf: 'center'}}>Inside</Text>+        </ImageBackground>+      </View>+    )+  }

Missing semicolon.

alvessteve

comment created time in 20 days

Pull request review commentfacebook/react-native-website

[#1579] update ImageBackground component doc

 You might not want to use `<ImageBackground>` in some cases, since the implement  Note that you must specify some width and height style attributes. -## Example- ```jsx-return (   <ImageBackground source={...} style={{width: '100%', height: '100%'}}>     <Text>Inside</Text>   </ImageBackground>-);+```++## Example++```SnackPlayer name=ImageBackground+  import React from 'react';+  import {View, ImageBackground, Text} from 'react-native'++  export default function App() {+    return (+      <View>+        <ImageBackground source={{uri: 'https://facebook.github.io/react/logo-og.png'}} style={{width: '100%', height: '100%'}}>+          <Text style ={{color: 'white', fontSize: 20, alignSelf: 'center'}}>Inside</Text>

Unnecessary space after style.

alvessteve

comment created time in 20 days

Pull request review commentfacebook/react-native-website

[#1579] update ImageBackground component doc

 You might not want to use `<ImageBackground>` in some cases, since the implement  Note that you must specify some width and height style attributes. -## Example- ```jsx-return (   <ImageBackground source={...} style={{width: '100%', height: '100%'}}>     <Text>Inside</Text>   </ImageBackground>-);+```++## Example++```SnackPlayer name=ImageBackground+  import React from 'react';+  import {View, ImageBackground, Text} from 'react-native'++  export default function App() {

Arrow function.

alvessteve

comment created time in 20 days

Pull request review commentfacebook/react-native-website

[#1579] update ImageBackground component doc

 You might not want to use `<ImageBackground>` in some cases, since the implement  Note that you must specify some width and height style attributes. -## Example- ```jsx-return (   <ImageBackground source={...} style={{width: '100%', height: '100%'}}>     <Text>Inside</Text>   </ImageBackground>-);+```++## Example++```SnackPlayer name=ImageBackground+  import React from 'react';+  import {View, ImageBackground, Text} from 'react-native'

Imports alphabetic order + missing semicolon.

alvessteve

comment created time in 20 days

pull request commentfacebook/react-native-website

Dimensions 📐 - updated Docs 📑 & new snack examples ✨

In the first example documentation is suggesting rounding Dimensions values before usage. This part was added in #1274. I don't know the exact reason behind this but I would assume that in some cases/on some devices this value could return float.

Currently proposed examples do not utilize Math.round. I'm not sure which approach to handling those values is better but I think that someone should decide about that for the consistency and after that some parts of code should be updated.

DaniAkash

comment created time in 20 days

Pull request review commentfacebook/react-native-website

docs: add Image Style Props examples

       "toastandroid": {         "title": "ToastAndroid"       },-      "toolbarandroid": {

Am I assuming correctly that this change was added to the commit by mistake?

ronnyiscoding

comment created time in 20 days

pull request commentfacebook/react-native-website

docs: add deprecation notice for clipboard

You should also update website/i18n/en.json file and add deprecation emoji to the title field. Strings from this file are used in the sidebar.

Naturalclar

comment created time in 20 days

pull request commentfacebook/react-native-website

move props related pages to separate section in sidebar

@rachelnabors What do you think about those changes? If you don't like that idea I can close this PR.

Simek

comment created time in 20 days

pull request commentfacebook/react-native-website

DatePickerIOS - Added Snack Examples 🍿

It seems that Rachel got similar concerns to my: https://github.com/facebook/react-native-website/issues/1579#issuecomment-582448869

Also after thinking about this a bit more I would like to start discussion about removing all examples form the deprecated components after #1493 will be merged.

DaniAkash

comment created time in 20 days

issue closedfacebook/prepack

Missing main app JS file after adding 'prepack-webpack-plugin' to project

It was another attempt to include Prepack to my project after #2540. No fancy configuration just plain entry in Webpack plugins array: new PrepackWebpackPlugin({})

Build succeeded with no error message. All chunks/modules declared in code splitting configuration are exposed and linked in HTML, but main index.js file is missing witch causes blank page. Webpack logged that file has been built: 1.57 kB 196 ./src/index.js built.

Removing prepack-webpack-plugin from plugins array fixes that issue.

I have no clue why this happening. Is there any way to provide you a log or extract valuable debug information?

closed time in 21 days

Simek

pull request commentfacebook/react-native-website

DatePickerIOS - Added Snack Examples 🍿

I'm not sure if adding an example for the the deprecated components is a good idea.

They will be sooner or later completely removed form the codebase and not providing examples for them could be a good way to discourage usage of those components.

DaniAkash

comment created time in 21 days

Pull request review commentfacebook/react-native-website

DatePickerIOS - Added Snack Examples 🍿

 Use `DatePickerIOS` to render a date/time picker (selector) on iOS. This is a co  ### Example -```jsx+<div class="toggler">+  <ul role="tablist" class="toggle-syntax">+    <li id="functional" class="button-functional" aria-selected="false" role="tab" tabindex="0" aria-controls="functionaltab" onclick="displayTabs('syntax', 'functional')">+      Function Component Example+    </li>+    <li id="classical" class="button-classical" aria-selected="false" role="tab" tabindex="0" aria-controls="classicaltab" onclick="displayTabs('syntax', 'classical')">+      Class Component Example+    </li>+  </ul>+</div>++<block class="functional syntax" />++```SnackPlayer name=DatePickerIOS&supportedPlatforms=ios+import React, {useState} from 'react';+import {DatePickerIOS, View, StyleSheet, Text, Platform} from 'react-native';++export default function App () {++  const [chosenDate, setChosenDate] = useState(new Date());++  return (+    <View style={styles.container}>+      <DatePickerIOS+        date={chosenDate}+        onDateChange={setChosenDate}+      />+    </View>+  );+}++const styles = StyleSheet.create({+  container: {+    flex: 1,+    justifyContent: 'center',+  },+});+```++<block class="classical syntax" />++```SnackPlayer name=DatePickerIOS&supportedPlatforms=ios import React, {Component} from 'react';-import {DatePickerIOS, View, StyleSheet} from 'react-native';+import {DatePickerIOS, View, StyleSheet, Text, Platform} from 'react-native';

Platform and Text imports are unnecessary after af16849a7ffc97bb402c117867385cd2084d09a0 commit.

DaniAkash

comment created time in 21 days

Pull request review commentfacebook/react-native-website

DatePickerIOS - Added Snack Examples 🍿

 Use `DatePickerIOS` to render a date/time picker (selector) on iOS. This is a co  ### Example -```jsx+<div class="toggler">+  <ul role="tablist" class="toggle-syntax">+    <li id="functional" class="button-functional" aria-selected="false" role="tab" tabindex="0" aria-controls="functionaltab" onclick="displayTabs('syntax', 'functional')">+      Function Component Example+    </li>+    <li id="classical" class="button-classical" aria-selected="false" role="tab" tabindex="0" aria-controls="classicaltab" onclick="displayTabs('syntax', 'classical')">+      Class Component Example+    </li>+  </ul>+</div>++<block class="functional syntax" />++```SnackPlayer name=DatePickerIOS&supportedPlatforms=ios+import React, {useState} from 'react';+import {DatePickerIOS, View, StyleSheet, Text, Platform} from 'react-native';

Platform and Text imports are unnecessary after af16849a7ffc97bb402c117867385cd2084d09a0 commit.

DaniAkash

comment created time in 21 days

pull request commentfacebook/react-native-website

deprecation indicator and deprecation notes standardization

I have updated both pages. Hope I have used the right community repos for those components.

Simek

comment created time in 21 days

push eventSimek/react-native-website

simek

commit sha 182d799373f6f32daed9a927f8d69ad5674a4726

update ProgressBarAndroid and ProgressViewIOS

view details

push time in 21 days

startedfilsv/iPhoneOSDeviceSupport

started time in 21 days

startedcli/cli

started time in 24 days

starteddeezer/spleeter

started time in 24 days

push eventSimek/yuzu

bunnei

commit sha 2a822f33785468052608bd8e294b807f45ce13f1

bsd: Stub several more functions. - Required for Little Town Hero to boot further.

view details

Bartosz Kaszubowski

commit sha f68bb4f55e082dd824157bb8fe67ff4dc441e3a3

dark themes refinements and cleanup

view details

ReinUsesLisp

commit sha d17dfa610418e2057e65b2fd3ab28a46249f4b83

gl_texture_cache: Properly implement depth/stencil sampling This addresses the long standing issue of compatibility vs. core profiles on OpenGL, properly implementing depth vs. stencil sampling depending on the texture swizzle.

view details

bunnei

commit sha acfb0b485239ed2ac034c6a45fe2dceb20753960

Merge pull request #3346 from bunnei/bsd-stub bsd: Stub several more functions.

view details

ReinUsesLisp

commit sha abae7959865ec45a1a6bd5d4994d5ef4c6588fef

gl_texture_cache: Silence implicit sign cast warnings

view details

bunnei

commit sha bea6327d7492004229e7875b1f550ad65fcbea7f

Merge pull request #3354 from ReinUsesLisp/depth-stencil gl_texture_cache: Properly implement depth/stencil sampling

view details

bunnei

commit sha 283f3253bc9f4bebc95dd80e167dff21bec08cc0

Merge pull request #3352 from Simek/dark-theme-refinements GUI: dark themes refinements and QSS cleanup

view details

ReinUsesLisp

commit sha 8178fe89606f19a976de6844c7dfb127e6305dfa

gl_shader_decompiler: Remove UNIMPLEMENTED for gl_PointSize This was implemented by a previous commit and it's no longer required.

view details

bunnei

commit sha c457e47297c1ea9bd723907b11e402f9b9dd3796

Merge pull request #3359 from ReinUsesLisp/assert-point-size gl_shader_decompiler: Remove UNIMPLEMENTED for gl_PointSize

view details

bunnei

commit sha 91f79225e78082df5aee28727e63b0e4882beadc

Merge pull request #3358 from ReinUsesLisp/implicit-texture-cache gl_texture_cache: Silence implicit sign cast warnings

view details

push time in a month

startedlemire/simdjson

started time in a month

startedoblador/diglett

started time in a month

PR opened yuzu-emu/yuzu

GUI: dark themes refinements and QSS cleanup

This PR introduce a lot of small changes and improvements for dark themes and supplement changes introduced in #3339. Most important things that has been updated:

  • user control/interaction elements design has been standardized and proper disabled state for all of them has been added
  • tabs design has been based more on light theme and simplified
  • Main Menu and Context Menu has been refined to mimic native menu better and disabled styling has been updated
  • game list now dimms instead of being lighten up while loading

Other than that a lot of small tweaks and changes has been applied across whole dark themes stylesheet.

Config, Tabs and user interaction elements

yc1

Main Menu

yc2

Game List while loading

yc3

+112 -110

0 comment

1 changed file

pr created time in a month

create barnchSimek/yuzu

branch : dark-theme-refinements

created branch time in a month

startedJetBrains/JetBrainsMono

started time in a month

push eventSimek/yuzu

Fernando Sahmkow

commit sha a1667a7b46cef31a493721b6c193749ee54f730f

Shader_IR: Implement TXD Array. This commit extends the compilation of TXD to support array samplers on TXD.

view details

ReinUsesLisp

commit sha 3ce28342a29610da7652247e2ec5b6b9176e5e4f

gl_shader_cache: Disable fastmath on Nvidia

view details

Michael Scire

commit sha 5a7eecc3adfb179335d921725a3b60c622e92836

loader: provide default arguments (zero byte) to NSOs Certain newer unity games (Terraria, Pokemon Mystery Dungeon) require that the argument region be populated. Failure to do so results in an integer underflow in argument count, and eventually an unmapped read at 0x800000000. Providing this default fixes this. Note that the behavior of official software is as yet unverified, arguments-wise.

view details

bunnei

commit sha ed76c7131903f180ebc2f49c148a8a0339bf05fa

service: time: Implement ToPosixTimeWithMyRule. - Used by Pokemon Mystery Dungeon.

view details

Fernando Sahmkow

commit sha 9c6b5cae681a517b3e8e7b6cf0c374911b3f6588

Merge pull request #3338 from ReinUsesLisp/no-fastmath gl_shader_cache: Disable fastmath on Nvidia

view details

bunnei

commit sha a167da4278df6d864a8990f846cf3ede1158f3db

Merge pull request #3341 from bunnei/time-posix-myrule service: time: Implement ToPosixTimeWithMyRule.

view details

fearlessTobi

commit sha ac3690f2057fb93ce18f156ff5ffd720a6d6f60c

Input: UDP Client to provide motion and touch controls An implementation of the cemuhook motion/touch protocol, this adds the ability for users to connect several different devices to citra to send direct motion and touch data to citra. Co-Authored-By: jroweboy <jroweboy@gmail.com>

view details

FearlessTobi

commit sha 0fe11746fcb37de2465cdbbe74be6ad4a59228e5

Address review comments

view details

FearlessTobi

commit sha bbd85a495a3576a5ec99cd69b54e983653b38ea4

Address second part of review comments

view details

FearlessTobi

commit sha d01eb12f369eedae704c0e7ce0611f360302475b

Replace GetString with Get function This should hopefully fix compilation errors.

view details

BreadFish64

commit sha a31ed02ae48eaeb3ee6ac1c45f21d5dd3a9ac376

common/logging: don't use regex for path trimming

view details

FearlessTobi

commit sha d0e4f1c6f43f51df8fdc8a056801a297c2706d56

yuzu/configuration: create UI tab and move gamelist settings there

view details

bunnei

commit sha deb97f6a8e48c17f8e16efadc24872a860d529a7

Merge pull request #2800 from FearlessTobi/port-4049 Port citra-emu/citra#4049: "Input: UDP Client to provide motion and touch controls"

view details

ReinUsesLisp

commit sha 1690f1adba2c6971256d939f260d865689f517ce

vk_shader_decompiler: Disable default values on unwritten render targets Some games like The Legend of Zelda: Breath of the Wild assign render targets without writing them from the fragment shader. This generates Vulkan validation errors, so silence these I previously introduced a commit to set "vec4(0, 0, 0, 1)" for these attachments. The problem is that this is not what games expect. This commit reverts that change.

view details

bunnei

commit sha f64adcfc37f15e31e8c6f772f56d8681512392d3

Merge pull request #3340 from SciresM/pmdx loader: provide default arguments (zero byte) to NSOs

view details

bunnei

commit sha a104b985a850f272831397c656e2fb01e5c1e52b

Merge pull request #3273 from FernandoS27/txd-array Shader_IR: Implement TXD Array.

view details

bunnei

commit sha dfd998216cb83f040dcc3bb5d94b5159b0ca6149

Merge pull request #3344 from ReinUsesLisp/vk-botw vk_shader_decompiler: Disable default values on unwritten render targets

view details

bunnei

commit sha 2b1d66eda3065d3e04ba04053f6fa313d973c7c9

Merge pull request #3326 from FearlessTobi/port-5039 Port citra-emu/citra#5039: "common/logging: don't use regex for path trimming"

view details

bunnei

commit sha 05df4a8c9452269a340fdd8490eeb064696ccb10

Merge pull request #3343 from FearlessTobi/ui-tab yuzu/configuration: create UI tab and move gamelist settings there

view details

push time in a month

startedmicrosoft/playwright

started time in a month

push eventSimek/yuzu

Léo Lam

commit sha f98cd210abb40e487b30952db25c97e28726dbb4

CMake: Create thin archives on Linux This significantly reduces unnecessary disk writes and space usage when building Citra. libcore.a is now only ~1MB rather than several hundred megabytes.

view details

Bartosz Kaszubowski

commit sha 9a22b6dced0e6ca9746269db5389fa8bff534ac2

GUI: fix minor issues with dark themes GUI: rename and reorder themes

view details

Bartosz Kaszubowski

commit sha c7055f3670f48b82e01d11b9ea2abf0117c3dfba

fix qss stylesheet whitespaces

view details

Zach Hilman

commit sha d8e0d839bd9c958233e6c57ff7e35b783daaf2d5

Merge pull request #3339 from Simek/dark-theme-update GUI: fix minor issues with dark themes + rename and reorder themes

view details

bunnei

commit sha 89b326e396729ae9188bc5906c758ed2fb010cc0

Merge pull request #3324 from FearlessTobi/port-5037 Port citra-emu/citra#5037: "CMake: Create thin archives on Linux"

view details

push time in a month

pull request commentyuzu-emu/yuzu

GUI: fix minor issues with dark themes + rename and reorder themes

@DarkLordZach Thank you for the quick review and merge.

Just one more question: What about changes mentioned in https://github.com/yuzu-emu/yuzu/pull/3339#issuecomment-577414387? Are they needed/welcome?

Simek

comment created time in a month

pull request commentyuzu-emu/yuzu

GUI: fix minor issues with dark themes + rename and reorder themes

Thank you for the comment and good suggestion about rows coloring. But it seems that both issues mentioned by you occurs on all themes and they will need some CPP and/or UI files changes (not only QSS).

As those issues are not exclusive to dark themes I can look on them separately and prepare new PR if I can manage to fix them.

Preview

yl yl2

Simek

comment created time in a month

pull request commentyuzu-emu/yuzu

GUI: fix minor issues with dark themes + rename and reorder themes

Two more things came to my mind after pushing this PR. I can add them If they seems meaningful:

  • darker background for active ComboBoxes (same color like for example "Limit Speed" value input)
  • minimal width and padding for Buttons based on "Default" style - currently for example "OK" button in Configuration seems a bit too small
Simek

comment created time in a month

push eventSimek/yuzu

Bartosz Kaszubowski

commit sha c7055f3670f48b82e01d11b9ea2abf0117c3dfba

fix qss stylesheet whitespaces

view details

push time in a month

PR opened yuzu-emu/yuzu

GUI: fix minor issues with dark themes + rename and reorder themes

This PR fixes few minor UI issues with dark themes also trying to mimic more "Default" ("Light") mode styling and component sizes to avoid resize on theme change. The following changes has been made:

  • mimic "Default" theme list headers styling - use list background color, border omission, no extra padding - Screenshot 1
  • decrease contrast of even rows on the lists to mimic "Default" theme styling and differentiate it more from Status Bar or Filter Bar - Screenshot 1
  • update tabs size and padding to roughly match "Default" theme styling - Screenshot 2
  • fix Main Menu and context menu checkbox position and items padding - Screenshot 3
  • fix ComboBox currently selected value being repositioned on options list open - Preview 1

I have also changed the themes names a bit and reorder them. It's completely optional change, rather proposition, which I can ditch if you don't like it. Currently themes list looks like:

  • Default
  • Dark
  • Colorful
  • Colorful Dark

Proposed names and order (also visible in Preview 1):

  • Light
  • Light Colorful
  • Dark
  • Dark Colorful

Screenshot 1

y1

Screenshot 2

y2

Screenshot 3

y3

Preview 1

yuzucb

+20 -19

0 comment

2 changed files

pr created time in a month

create barnchSimek/yuzu

branch : dark-theme-update

created branch time in a month

push eventSimek/yuzu

bunnei

commit sha 5135b74179e99507cc5eee374e76c3f0ac3ee717

core: Initialize several structs that make use of Common::UUID.

view details

bunnei

commit sha 78f977c980e125e92b86261335447d0a254f18ee

service: time: Rewrite implementation of glue services.

view details

bunnei

commit sha 4414640285b0f87bc5efed46127dcc80632e7892

system_archive: Add a basic HLE implementation for time zone binary.

view details

bunnei

commit sha fab2607c6bae25f50912b32e1cbbfb5a6191916c

service: time: Implement IsStandardNetworkSystemClockAccuracySufficient.

view details

bunnei

commit sha a4e840181c1e704a49e37c802ff36344ac18ca10

service: time: Implement GetClockSnapshotFromSystemClockContext.

view details

bunnei

commit sha 361285add978c5720bc16344a9fe41fa93374505

time: Remove overflow error checking (currently breaks ADO builds).

view details

bunnei

commit sha be5c149d374a7caaead4b7d1bfbd7ae4670fc229

service: time: Implement GetStandardLocalSystemClock.

view details

Bartosz Kaszubowski

commit sha da3049aa744bc905ef920a772287bc164be99634

GUI: add few missing hotkeys to main menu

view details

ReinUsesLisp

commit sha 2b2712fa95b99d1761270131b2604b7c9e99eac5

texture_cache/surface_params: Make GetNumLayers public

view details

ReinUsesLisp

commit sha 09e17fbb0ff70a62b4cff1cafae0ab579956c648

vk_texture_cache: Implement generic texture cache on Vulkan It currently ignores PBO linearizations since these should be dropped as soon as possible on OpenGL.

view details

ReinUsesLisp

commit sha 02624c35ec2d99c1157608e7aeeae7fb641729c2

gl_texture_cache: Use Snorm internal format for ABGR8S

view details

ReinUsesLisp

commit sha 2d09467f6f6cddba057c72af65341b4a659076b5

gl_texture_cache: Use Snorm internal format for RG8S

view details

ReinUsesLisp

commit sha cdb00546f02b99b1e9118db9c5238ce6e6bb6a2e

gl_texture_cache: Fix format for RGBX16F

view details

ReinUsesLisp

commit sha 66a1c777c9ce6a19e9205534f3f4910940722f26

gl_texture_cache: Use local variables to simplify DownloadTexture

view details

Lioncash

commit sha 06d30fbcca92728655dad708be3bdc5a8f7ff54b

renderer_opengl/utils: Forward declare private structs Keeps the definitions hidden and allows changes to the structs without needing to recompile all users of classes containing said structs.

view details

Lioncash

commit sha 7af56dfa7645249f9c5d420365ad78b44e43eadd

renderer_opengl/utils: Remove unused header inclusions Nothing from these headers are used, so they can be removed.

view details

ReinUsesLisp

commit sha c375d735e66b275d70de7c8a29113cf1e1e41d7e

gl_state: Implement PROGRAM_POINT_SIZE For gl_PointSize to have effect we have to activate GL_PROGRAM_POINT_SIZE.

view details

James Rowe

commit sha b429095b615918eca05a4a586d5974f8f07a9bda

Fix git version in scm_rev.cpp

view details

Lioncash

commit sha 9e874898f500a736d764ec7f615b4ae59b6f5768

maxwell_3d: Make dirty_pointers private This isn't used outside of the class itself, so we can make it private for the time being.

view details

bunnei

commit sha a43ac8c79e5dae76a5a64f388045f0fa8c16b0cc

Merge pull request #3307 from jroweboy/fix-git Fix git version in scm_rev.cpp

view details

push time in a month

startedgogcom/galaxy-integrations-python-api

started time in a month

push eventSimek/yuzu

Bartosz Kaszubowski

commit sha 3ddf01a4fc511a6a04cabdc97db4f385b3abfdbc

fix clang-format warnings

view details

push time in a month

more