profile
viewpoint
Bartosz Kaszubowski Simek @vizum & @SentiOne Gdańsk, Poland simek.dev Full Stack Developer & UI/UX Designer. Scala, Rust, JS & any form of React.

facebook/react-native-website 1118

The site and docs for React Native

react-native-directory/website 404

A searchable and filterable directory of React Native libraries

Simek/css_browser_selector 3

A very small javascript library that allows you to create browser, platform, device, and even version specific CSS to be merged into your normal classes. No more hacks or mischievous code in your CSS.

SakulK/htmlcleaner 0

Fork http://sourceforge.net/projects/htmlcleaner/

Simek/async-storage 0

An asynchronous, persistent, key-value storage system for React Native.

Simek/babel 0

Babel is a compiler for writing next generation JavaScript.

Simek/boinc 0

Open-source software for volunteer computing and grid computing.

Simek/brackets 0

An open source code editor for the web, written in JavaScript, HTML and CSS.

Simek/cli 0

React Native command line tools

pull request commentmicrosoft/react-native-macos

fix default Text color in DarkMode

@tom-un After 'order tweak' commit all known to me issues with the JS implementation has been solved so this PR should be ready for a re-review.

Simek

comment created time in an hour

PR opened react-native-directory/website

remove 'react-native-macos' entry

Why

This PR removes the 'react-native-macos' entry because:

  • it's a platform not a library
  • it's an old and unmaintained fork of RN for macOS which has been replaced by Microsoft fork (microsoft/react-native-macos)

Checklist

If you added a new library:

  • [ ] Added it to react-native-libraries.json

If you added a feature or fixed a bug:

  • [ ] Documented in this PR how to use the feature or replicate the bug.
  • [ ] Documented in this PR how you fixed or created the feature.
+0 -6

0 comment

1 changed file

pr created time in 2 hours

create barnchreact-native-directory/website

branch : Simek-remove-old-platform

created branch time in 2 hours

startedreact-native-directory/website

started time in 15 hours

PR opened react-native-directory/website

fix sort select appearance on Windows

Why

This small PR fixes the sort select appearance on Windows (Chrome, Edge, Opera). Options inherits the color style of the Picker so on Windows text inside options list were white. This change or any other Picker.Item color property is not affecting macOS since system context menu (not the browser implementation) is used there.

Checklist

<!-- Check completed item, when applicable, via: [X] -->

If you added a new library:

  • [ ] Added it to react-native-libraries.json

If you added a feature or fixed a bug:

  • [ ] Documented in this PR how to use the feature or replicate the bug.
  • [X] Documented in this PR how you fixed or created the feature.

Preview

Before

Untitled-2

After

Untitled-1

+6 -1

0 comment

1 changed file

pr created time in 15 hours

create barnchSimek/website-1

branch : fix-select-on-windows

created branch time in 15 hours

PR opened react-native-directory/website

add 'macOS' platform to 'async-storage'

Why

This small PR adds 'macOS' to the supported platforms by 'async-storage'.

Refs: https://github.com/react-native-community/async-storage/releases/tag/v1.8.1

Checklist

<!-- Check completed item, when applicable, via: [X] -->

If you added a new library:

  • [ ] Added it to react-native-libraries.json

If you added a feature or fixed a bug:

  • [ ] Documented in this PR how to use the feature or replicate the bug.
  • [ ] Documented in this PR how you fixed or created the feature.
+1 -0

0 comment

1 changed file

pr created time in 18 hours

push eventSimek/website-1

Bartosz Kaszubowski

commit sha 79b0f75a14286edc2e2b78c0b823df8f4f7e468e

add 'macOS' platform to 'async-storage'

view details

push time in 18 hours

fork Simek/website-1

A searchable and filterable directory of React Native libraries

https://reactnative.directory

fork in 18 hours

startedjVirus/compositional-layouts-kit

started time in 18 hours

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 21e36bb66350aa155e989bda791bb0c5aea26814

remove required labels + tweak TV color

view details

push time in 20 hours

PR opened facebook/react-native-website

improved labels design + ActivityIndicator and Button pages tweaks

This PR introduces improved labels design and updates the ActivityIndicator and Button pages code references according to the new "standard" based on Pressable docs.

Preview

Annotation 2020-05-26 190029

+216 -148

0 comment

4 changed files

pr created time in 20 hours

create barnchSimek/react-native-website

branch : labels-v2-and-formatting

created branch time in 20 hours

PR opened microsoft/react-native-macos

Reviewers
adjust default color of the TextInput placeholder

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

This small PR replaces the static default color of TextInput placeholder with systemPlaceholderColor platform color. This change improves the TextInput appearance in Dark Mode.

Since whole code block is inside macOS target conditional I have just replaced the value.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[macOS] [Fixed] - TextInput: fix default placeholder appearanace in DarkMode

Test Plan

All the changes has been tested in the app generated form the init and build from the local working copy.

Preview

Before

Screenshot 2020-05-25 at 16 35 19

Screenshot 2020-05-25 at 16 36 09

After

Screenshot 2020-05-25 at 16 34 42

Screenshot 2020-05-25 at 16 37 22

+1 -2

0 comment

1 changed file

pr created time in 2 days

create barnchSimek/react-native

branch : adjust-textinput-default-placeholder

created branch time in 2 days

startedmyspaghetti/macos-virtualbox

started time in 3 days

push eventSimek/react-native-website

bitboxx

commit sha 07ef66aeb0ddac5fa36cb624f9f4073c85d3a2c8

Remove picker as this is being deprecated (#1949)

view details

Emerson Thompson

commit sha c75471a8e72eedae99731482bcbbe0b4466c1029

fix responsive grid (#1947)

view details

Jishnu P Sreekumar

commit sha 260fbe0c186961bcd8c6e94bcefe7d26ca5713c5

Fixed Issue #1897 added description (#1938)

view details

luism3861

commit sha 1ad99af73cd4fcb00f94f25713316999847411dc

fix RCTAlertManager.m link in Native Modules iOS (#1935)

view details

Bartosz Kaszubowski

commit sha 8340a384de453288cf5f6df05275bba629274e1c

replace inline Image style props with link to the Image Style Props page (#1950)

view details

Bartosz Kaszubowski

commit sha 85eb83db517fb019f4823c6ce6f22fff3a7deb57

update links format in the Footer component (#1943)

view details

push time in 4 days

pull request commentmicrosoft/react-native-macos

fix default Text color in DarkMode

I have also spotted that backgroundColor is not working correctly for the TextInput component This may be somehow related issue since Text is the base of this component.

TextInput with backgroundColor: "red": Screenshot 2020-05-23 at 20 59 27

Simek

comment created time in 4 days

startedtabrindle/envinfo

started time in 4 days

push eventSimek/react-native

simek

commit sha b002fa5bceaa9282ca824a3962b06da07526a3bf

tweak order

view details

push time in 4 days

pull request commentmicrosoft/react-native-macos

fix default Text color in DarkMode

@tom-un I have moved the implementation to the JS side. CI passed, but there was an ambiguous 500.

Simek

comment created time in 4 days

push eventSimek/react-native

simek

commit sha 16e8136c6202af656e10b033519de281b9833d61

flow fix

view details

push time in 5 days

push eventSimek/react-native

simek

commit sha 80b380e701f8f3045f0dcc906c9a12d3e5167947

move fix to JS side

view details

push time in 5 days

pull request commentyuzu-emu/yuzu

qt_themes: remove unknown qss property from dark theme

@FearlessTobi I'm not sure right now, it might by just to ensure the "hidden" behaviour which seems to be default behaviour in QT anyway. In CSS this property hides the content which exceeds the boundaries on the parent element or container.

So if QT do not support "overflow" the line should be safe to remove without affecting the current UI.

BTW. When I was working on UI tweaks I have used this guide as a reference: https://doc.qt.io/qt-5/stylesheet-examples.html#customizing-qtabwidget-and-qtabbar

Neodyblue

comment created time in 5 days

PR opened react-native-community/async-storage

fix Pods installation on macOS

Overview

Refs #296

This small PR updates the podspec file and adds osx platform there which fixed Pods installation on macOS:

Screenshot 2020-05-22 at 00 42 42

Test Plan

I have tested the change on the local working copy of async-storage.

+1 -1

0 comment

1 changed file

pr created time in 6 days

push eventSimek/async-storage

Bartosz Kaszubowski

commit sha a3bef1e3085014651a45c9bc6120c98ff8f5c2d8

fix Pods installation on macOS

view details

push time in 6 days

fork Simek/async-storage

An asynchronous, persistent, key-value storage system for React Native.

fork in 6 days

PR opened react-native-community/react-native-netinfo

Reviewers
fix Pods installation on macOS

Overview

Refs #312

This small PR updates the podspec file and adds osx platform there which fixed Pods installation on macOS:

Screenshot 2020-05-21 at 23 57 22

Test Plan

I have tested the change on the local working copy of react-native-netinfo.

+1 -1

0 comment

1 changed file

pr created time in 6 days

push eventSimek/react-native-netinfo

Bartosz Kaszubowski

commit sha a615d2908e93b067dd7e6f0235044dce0990416c

fix Pods installation on macOS

view details

push time in 6 days

fork Simek/react-native-netinfo

React Native Network Info API for Android & iOS

fork in 6 days

push eventSimek/react-native

simek

commit sha c1dcd8ce881c86065e9f58c94130e5e7b565bab2

one more color rollback

view details

push time in 6 days

push eventSimek/react-native

simek

commit sha 35b94bd78d644916afe5fddd1d857d5ac39988bb

review fix + whitespaces

view details

push time in 6 days

Pull request review commentmicrosoft/react-native-macos

fix default Text color in DarkMode

 - (NSParagraphStyle *)effectiveParagraphStyle         alignment = NSTextAlignmentRight;       }     }-    

I had to add trim_trailing_whitespace locally to .editorconfig to fix the issue.

Simek

comment created time in 6 days

Pull request review commentmicrosoft/react-native-macos

fix default Text color in DarkMode

 - (CGFloat)effectiveFontSizeMultiplier  - (RCTUIColor *)effectiveForegroundColor // TODO(OSS Candidate ISS#2710739) {-  RCTUIColor *effectiveForegroundColor = _foregroundColor ?: [RCTUIColor blackColor]; // TODO(OSS Candidate ISS#2710739)+  RCTUIColor *effectiveForegroundColor = _foregroundColor ?: [RCTUIColor labelColor]; // TODO(OSS Candidate ISS#2710739)

Should I use the macOS target conditional there since upstream is still using blackColor there?

Simek

comment created time in 6 days

pull request commentmicrosoft/react-native-macos

fix RNTester display issues after adjusting default Text color

@tom-un Sorry for those colors tweaks! I'm still sometimes forgetting the fact that is the fork and changing as few lines as possible is desirable.

CI failed on this PR earlier because macOS examples from RNTester were run on the iOS e2e test. I can adjust the problematic colors with usage of Platform.select API.

Simek

comment created time in 6 days

push eventSimek/react-native

simek

commit sha ddf7d65c9f4fa8229a213fe75e2a9b6f94e65b35

review fix

view details

push time in 6 days

push eventSimek/react-native-windows-samples

Matteo Pagani

commit sha 6c99476b7d6321ac6d17af10ee2d58c767fe13ee

Added rssreaders sample for Windows

view details

user

commit sha 8e827b4936a5a62a992aa2d0f20ac46fcee6dc92

added MacOS support

view details

user

commit sha f5e33e75490e5e37f3f216f46a36322d6bfc56a8

added MacOs support

view details

Matteo Pagani

commit sha 1c065f582bd49e9a68ab8d6cc57827ebe54d2b69

Added README.md

view details

Matteo Pagani

commit sha 891d2c5493616fa57467251ca6957e53b15cfb33

Removed Pods folderfor MacOS

view details

Matteo Pagani

commit sha 57ff96ffc22d2f6a8aeb2a79b200cf41d0cbf5f0

Update samples/rssreader/ios/rssreader/AppDelegate.m Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha 321e888fc4e385ad93c99ac5f27b3fcc7b66afc3

Update samples/rssreader/ios/rssreaderTests/rssreaderTests.m Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha 2eb4bd832943da98e854de3e0fe6d9a482e92ef1

Update samples/rssreader/macos/rssreader-iOS/AppDelegate.m Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha c3278da63e59fb42c1bbf5ecf6ecbd762703c2c1

Update samples/rssreader/macos/rssreader-macOS/AppDelegate.m Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha 32f0317948e0d08b951ce9326e87357da9edb97b

Update samples/rssreader/screens/FeedScreen.js Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha 35e52d4fc45093cd0cf964d252896671b56177ba

Update samples/rssreader/components/ActionBar.js Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>

view details

Matteo Pagani

commit sha 9d1031f3f61ddc8def5641e477d5241d4bbf416a

Removed not needed files and fixed FeedScreen style

view details

Matteo Pagani

commit sha 38a48c2692ea638a643b90359daaaa5e41f0f03e

Merge branch 'master' of https://github.com/qmatteoq/react-native-windows-samples

view details

Matteo Pagani

commit sha 1dc31f0a9e8ccd558bb8f791f4eff797fafedb1f

Upgraded display name for Windows in the manifest

view details

simek

commit sha 4933a3bdd23539a80bb91fe1256550592c2ebd38

update home page, update buttons, macOS instead of Mac

view details

simek

commit sha bb4d8526cfa7c261a54047046499a218d6183bec

fix tagline overflow on Win, update footer

view details

simek

commit sha 5966769abc5fed38f7821693455383b572c21097

fix prev/next box background

view details

kikisaints

commit sha f5bc81f5de6cfe7caf14970f7c7af35fe5755dfa

social links updated added macos and windows github buttons near call to action buttons

view details

Kiki Saintonge

commit sha 629c53ad3237631bd17921ef28af8652bfd9b3f3

Merge pull request #106 from microsoft/kisai/social-links-changes social links updated

view details

kikisaints

commit sha c9adc508b30c46a9466c773225d26c01a23dd0e8

Merge branch 'master' into pr/100

view details

push time in 6 days

delete branch Simek/react-native-website

delete branch : image-props

delete time in 6 days

PR opened facebook/react-native-website

replace inline Image style props with link to the Image Style Props page

This small PR replaces the inline listed props for Image component style with link to the Image Style Props page.

+4 -41

0 comment

1 changed file

pr created time in 6 days

create barnchSimek/react-native-website

branch : image-style-props

created branch time in 6 days

create barnchSimek/react-native-website

branch : image-props

created branch time in 6 days

PR opened facebook/react-native-website

use platform labels on the Accessibility page

This PR replaces the platform names with the platform labels on the Accessibility page. This required a few additional CSS tweaks. Also the order of the sections has been adjusted.

Preview

Annotation 2020-05-21 171814

+65 -55

0 comment

2 changed files

pr created time in 6 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 36b324e9f283327ad2438951f1e090063066aef0

order fix

view details

push time in 6 days

create barnchSimek/react-native-website

branch : accessibility-platform-labels

created branch time in 6 days

PR closed facebook/react-native-website

Update typescipt docs with explicit babel config

Currently it's a bit bare bones and doesn't really mention how to set it up. Since Babel is already configured and able to parse TypeScript it's probably the easiest way forward.

Happy to make any changes if needed. I'm currently trying out a "hello world" with React Native MacOS. So I basically bootstraped with their getting started here... https://microsoft.github.io/react-native-windows/docs/rnm-getting-started and ended up wanting TypeScript.

<!-- Thank you for the PR! Contributors like you keep React Native awesome!

Please see the Contribution Guide for guidelines:

https://github.com/facebook/react-native-website/blob/master/CONTRIBUTING.md

If your PR references an existing issue, please add the issue number below:

#<Issue> -->

+15 -5

2 comments

1 changed file

madou

pr closed time in 6 days

pull request commentfacebook/react-native-website

Update typescipt docs with explicit babel config

Hi @madou, thank you for posting this PR but macOS is out of the tree platform maintained by Microsoft. Implementation is currently based on the RN fork by Microsoft and uses 0.61 internally (so this also could be a reason why the configuration from the current docs is not right for you) .

All the changes regarding to macOS platform should be performed on theirs RN Win + macOS website. If TS configuration to work correctly with macOS project need additional packages or steps this should be addressed on their website.

The repository for their website is there: https://github.com/microsoft/react-native-windows-samples (directory website).

AFAIK: There are no problems with the current TS configuration in Android and iOS projects using the latest RN version. Feel free to reopen this PR and correct me if I'm wrong.

madou

comment created time in 6 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 69f4c0155d9f39eb551fdbcc58940bb7283a1ee9

HTTPS in StackOverflow link

view details

push time in 7 days

PR opened facebook/react-native-website

update links format in the Footer component

This PR updates the links in the Footer component (removes .html and trailing /) and stores baseUrl in the local variable to simplify the code.

+9 -22

0 comment

1 changed file

pr created time in 7 days

create barnchSimek/react-native-website

branch : update-footer-links

created branch time in 7 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 1d415696a8214c5559c469ea0a1648de02e450f5

add PressEvent and Rect Object Types links to the components (#1940)

view details

Bartosz Kaszubowski

commit sha 0b7b3b987a15aa33733ac45cf6e736ebc389b4a9

update slightly feedback box and footer designs (#1939)

view details

R Nabors

commit sha f68161137bc567239cd8a5e11c82e8530a9ff2f4

Tiny edits to pressable wording (#1942)

view details

push time in 7 days

pull request commentfacebook/react-native-website

Add new option to ActionSheetIOS called disabledButtonsIndices

Hi @lukewalczak, thank you for such a comprehensive approach and remembering about documentation!

At this point in time, to merge this PR, the referenced changeset not only should be merged into master but also need to be cherry-picked into 0.63 release branch.

If this feature won't be a part of the next release this PR need to wait until the docs for 0.63 will be generated (from the files in docs folder).

lukewalczak

comment created time in 7 days

push eventSimek/react-native

simek

commit sha aae02ffeffc72b8e7daef99ca4dd4648bedcb656

fix lint

view details

push time in 7 days

push eventSimek/react-native

simek

commit sha 5288c4c0310541a8cbe91e5961ba2899d9e06157

review tweaks

view details

push time in 7 days

PR opened microsoft/react-native-macos

Reviewers
fix RNTester display issues after adjusting default Text color

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

Refs #402

This PR is a follow up for the PR mentioned above.

Adjusting the default Text color based on the current mode/appearance caused some display issues in the RNTester app. Changes included in this PR fixes bunch of those display issues (at least the most annoying ones, but at least few minor ones left).

I have also skipped Platform API and the TODO ref comment in the macOS specific components. If it is a wrong approach let me know, I would updated the code.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[Internal] [Fixed] - RNTester: adjust the app UI after Text default color changes

Test Plan

All the changes has been tested in the RNTester build from local working copy.

+58 -16

0 comment

11 changed files

pr created time in 7 days

create barnchSimek/react-native

branch : fix-RNTester-display-issues

created branch time in 7 days

PR opened microsoft/react-native-windows-samples

remove manual Pods installation from macOS guide

This small PR removes the manual Pods installation step from the latest Getting Started guide for the macOS.

Refs: microsoft/react-native-macos#366

+0 -6

0 comment

1 changed file

pr created time in 7 days

push eventSimek/react-native-windows-samples

Bartosz Kaszubowski

commit sha ab9143c5215ecaad431e0f796aa63ce63ed4f7a8

remove manual Pods installation from macOS guide

view details

push time in 7 days

PR opened microsoft/react-native-macos

Reviewers
fix default Text color in DarkMode

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

This small change fixes the default Text color in DarkMode. To ensure that correct color is always applied I had to remove the check which was an optimisation for other platforms and I have wrapped the whole block with TARGET_OS_OSX. I'm not sure if it's a correct approach, feel free to correct me.

Also it seems that my IDE has made a whitespace cleanup on commit. I hope this is not a problem.

This change also introduced a few display issues in RNTester. I'm working on the separate PR which will fix those issues.

Changelog

[macOS] [Fixed] - Text: fix default color in Dark Mode

Test Plan

All the changes has been tested in the RNTester build from local working copy.

Preview

May-20-2020 14-37-31

+10 -6

0 comment

1 changed file

pr created time in 7 days

create barnchSimek/react-native

branch : fix-text-color-in-darkmode

created branch time in 7 days

PR opened microsoft/react-native-macos

Reviewers
fix Picker text color in DarkMode, tweak text size

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

This small PR fixes the default Picker text and items color in DarkMode and changes the text size to match default styling on macOS.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[macOS] [Fixed] - Picker: fix default text color in DarkMode, adjust default text size

Test Plan

All the changes has been tested in the RNTester build from local working copy.

Preview

Before

Screenshot 2020-05-20 at 14 04 22

After

Screenshot 2020-05-20 at 14 02 44

+4 -3

0 comment

1 changed file

pr created time in 7 days

create barnchSimek/react-native

branch : fix-picker-items-color

created branch time in 7 days

push eventSimek/react-native

Jesse Katsumata

commit sha 95e8bc3af7ac164a820ef3ca68c0e6d909ecf67b

feat(react-native-macos-init): add pod folder to gitignore (#369) * feat(react-native-macos-init): add pod folder to gitignore * add gitignore to macos template

view details

React-Native Bot

commit sha 2a9cce850ae6650311f5fe9b37a923dc1ec88d1d

Applying package update to 0.61.31 ***NO_CI***

view details

Bartosz Kaszubowski

commit sha 8c3c6b5d49e73188b2627c88276a5626fbb7e0d9

set autorecalculatesKeyView to YES in the init template (#377)

view details

React-Native Bot

commit sha 39a85c443f6b6092c584351ded3ec1b04430bdc7

Applying package update to 0.61.32 ***NO_CI***

view details

Bartosz Kaszubowski

commit sha b463097239fd96a517069217fc4e42e9a09f58fb

RNTester: fix tester block description color in DarkMode (#378)

view details

React-Native Bot

commit sha e767c3582bb8d4e531b1192d55fc74909bda498a

Applying package update to 0.61.33 ***NO_CI***

view details

push time in 7 days

pull request commentmicrosoft/react-native-macos

set autorecalculatesKeyView to YES in the init template

@tom-un The CI fails seems to be related to the unknown for me macos-office pipeline, and Pods installation in there:

Cloning spec repo `trunk` from `https://cdn.cocoapods.org/`
[!] Unable to add a source with url `https://cdn.cocoapods.org/` named `trunk`.
You can try adding it manually in `/Users/runner/.cocoapods/repos` or via `pod repo add`.

##[error]Bash exited with code '1'.
Simek

comment created time in 8 days

PR opened microsoft/react-native-macos

Reviewers
RNTester: fix TesterBlock description color in DarkMode

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

This small PR makes the descriptions of the TesterBlock component in the RNTesters readable on macOS in the DarkMode.

Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. See https://github.com/facebook/react-native/wiki/Changelog for an example. -->

[Internal] [Changed] - RNTester: ensure that description is readable in DarkMode too

Test Plan

Locally run of RNTester app.

Preview

Before

Screenshot 2020-05-19 at 19 33 41

After

Screenshot 2020-05-19 at 19 33 19

+9 -0

0 comment

1 changed file

pr created time in 8 days

create barnchSimek/react-native

branch : RNTester-fix-description-color

created branch time in 8 days

PR opened microsoft/react-native-macos

Reviewers
set autorecalculatesKeyView to YES in the init template

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [X] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native

Summary

Fixes #376

This small PR changes value of autorecalculatesKeyView inside the init template from NO to YES as requested in referenced issue (similar way to RNTester).

Changelog

[Internal] [Changed] - set correct autorecalculatesKeyView property in the init template storyboard

Test Plan

The Main.storyboard in the test project generated form the local, working copy of RNmacOS had a correct value of autorecalculatesKeyView.

+1 -1

0 comment

1 changed file

pr created time in 8 days

create barnchSimek/react-native

branch : autorecalculate-key-init-template

created branch time in 8 days

push eventSimek/react-native

Bartosz Kaszubowski

commit sha 1f640ad99a98c7731a5c210b0dd92673d6a7a230

init cli improvements: check the current version of RNmacOS, other display tweaks (#370) * init cli improvements: check the current version of RNmacOS + display tweaks * verbose tweak * ensure that all errors are red * typo fix, small tweaks * few more tweaks * Change files

view details

React-Native Bot

commit sha a753d91f0ac7e1f5d10fdf3dde31bbf337e49595

applying package updates ***NO_CI***

view details

React-Native Bot

commit sha d304b8bc2e8b4eb8e6873214ecc7d5e1aafe52f6

Applying package update to 0.61.30 ***NO_CI***

view details

React-Native Bot

commit sha 355daa891629ebed2363cf21c5529aa7029bf2c0

Merge branch 'publish-temp-1589844748540'

view details

push time in 8 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 6f6e397a461c87cecb5f18565970fe81e80fe038

Image 'capInsets' also utilize Rect Object

view details

push time in 8 days

push eventSimek/react-native-website

Bartosz Kaszubowski

commit sha 9815c5258e0059fecbfa1979c9ceb17b4ee65c6d

add missing Rect components, same formatting of "Used by" section

view details

push time in 8 days

PR opened facebook/react-native-website

add PressEvent and Rect Object Types links to the components

This PR adds PressEvent and Rect Object Types links to the remaining components other than Pressable.

Also few descriptions in TouchableWithoutFeedback has been updated based on versions from the Pressable page.

+45 -73

0 comment

5 changed files

pr created time in 8 days

create barnchSimek/react-native-website

branch : add-pressevent-and-rect

created branch time in 8 days

startedbe5invis/Iosevka

started time in 8 days

push eventSimek/react-native

push time in 9 days

push eventSimek/react-native

Bartosz Kaszubowski

commit sha c46c7fc1e8bcb5620a733849b72571b4c3a36fe7

local-cli: quiet npx messages before pod-install (#373)

view details

React-Native Bot

commit sha 7b5fdec54cf4579768a0302ce8357782de9d0aeb

Applying package update to 0.61.27 ***NO_CI***

view details

Tom Underhill

commit sha f45db4710d7c00202cc431ccec3da3d35f31386f

Run beachball from root of repo in PR and publish scripts (#374) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae06b01301ac43533e7e20dd7fed24a0937f. * Remove unnecessary android builds and tar file upload. * Dont change cwd before running beachball. Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>

view details

React-Native Bot

commit sha 56b7a6d788497e478a806598d4bd77a78e75464a

Applying package update to 0.61.28 ***NO_CI***

view details

Bartosz Kaszubowski

commit sha ca5814049b4c39ecebdbc94224ec7ee7c3b52e4c

CI: remove 'Install pods' step since Pods are installed by init (#375)

view details

React-Native Bot

commit sha 65c216db5801ddca69b66bbbdea79e320748009f

Applying package update to 0.61.29 ***NO_CI***

view details

push time in 9 days

push eventSimek/react-native

Bartosz Kaszubowski

commit sha 21268ad3ed2728d24d940c0f63ca37f4253d0b14

local-cli: quiet npx messages before pod-install (#373)

view details

React-Native Bot

commit sha c437281a8e2217d961f54daed455dde2c0335e3b

Applying package update to 0.61.27 ***NO_CI***

view details

Tom Underhill

commit sha ec0413e1cc9e7879f4a1022014ee8cb73851595a

Run beachball from root of repo in PR and publish scripts (#374) * Update scripts to publish react-native-macos-init * Clean up merge markers * Restored ios:macos RNTester parity except for InputAccessoryView. * Revert "Restored ios:macos RNTester parity except for InputAccessoryView." This reverts commit 5a67ae06b01301ac43533e7e20dd7fed24a0937f. * Remove unnecessary android builds and tar file upload. * Dont change cwd before running beachball. Co-authored-by: React-Native Bot <53619745+rnbot@users.noreply.github.com>

view details

React-Native Bot

commit sha 7f02ff553ae5fab03bde537621f2b29b37af5701

Applying package update to 0.61.28 ***NO_CI***

view details

Bartosz Kaszubowski

commit sha b13c49a0d20089a42ca2bb4d50bad0f5d93520d7

CI: remove 'Install pods' step since Pods are installed by init (#375)

view details

React-Native Bot

commit sha 963945d282122b07a074f84cf64b9bd8b1f6992a

Applying package update to 0.61.29 ***NO_CI***

view details

push time in 9 days

PR opened microsoft/react-native-macos

Reviewers
CI: remove 'Install pods' step since Pods are installed by init

Please select one of the following

  • [ ] I am removing an existing difference between facebook/react-native and microsoft/react-native-macos :thumbsup:
  • [ ] I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos :thumbsup:
  • [ ] I am making a fix / change for the macOS implementation of react-native
  • [ ] I am making a change required for Microsoft usage of react-native
  • [X] None of the above

Summary

Since Pods are automatically installed during the react-native-macos-init (#366) the manual installation became redundant, so the CI step 'Install pods' can be removed.

Changelog

[Internal] [Removed] - CI: remove 'Install pods' step from react-native-macos-init template

Test Plan

Run the CI!

+0 -6

0 comment

1 changed file

pr created time in 9 days

push eventSimek/react-native

Bartosz Kaszubowski

commit sha 567b174ed2ed66ed5fbe18d3dbb0e02a633052a6

CI: remove 'Install pods' step since Pods are installed by init

view details

push time in 9 days

PR opened facebook/react-native-website

update slightly feedback box and footer designs

This PR includes small tweaks and small visual changes to the bottom components of the website: feedback box, prev/next navigation and footer.

In this changes I have also includes few minor CSS tweaks to the elements introduced earlier (platform labels, slim table headers).

Preview

Before

Annotation 2020-05-18 215555

After

Annotation 2020-05-18 215406

+40 -18

0 comment

4 changed files

pr created time in 9 days

create barnchSimek/react-native-website

branch : update-footer-and-feedback-box

created branch time in 9 days

push eventSimek/react-native-website

Kiki Saintonge

commit sha 93a69a25aeb63604e3bf7cb1f9afe8cb6e0c5278

addition of Pressable to apis

view details

Kiki Saintonge

commit sha 1ba2f275ffb505b70879e0d34e602fd291a65622

linked to color section, changed render prop to function

view details

R Nabors

commit sha 80e2e829936d6c4d70d51ae48960200283e1e40f

tweaking copy

view details

Kiki Saintonge

commit sha 551cd6f65a1afe78e14309700a7f5746e8dd220f

removed the use of * during react import

view details

Kiki Saintonge

commit sha 7985a462e3b8dce986876075b8dee64bb82dbea2

Merge branch 'pressable-api' of https://github.com/kikisaints/react-native-website into pressable-api

view details

Kiki Saintonge

commit sha 3581c5e706022854821653d7adeffef08815ba8e

style conditional added, function consistency syntax changed

view details

Kiki Saintonge

commit sha 031720dd952344e95f649e199f9da786762daea5

update to app export syntax

view details

Kiki Saintonge

commit sha 8159cf6c438eb23d7f2cc2e4babb2b6aea217118

fixed inline style conditional + mismatched view close tags

view details

Kiki Saintonge

commit sha c93c84c4d6bb74fbb5a306f4b8438c0a33c6a299

Update docs/pressable.md Co-Authored-By: Eli White <github@eli-white.com>

view details

Kiki Saintonge

commit sha d2a9446c8200301644f46a091e3e1526a12780bd

crosslinking, info definitions added links in the touchable docs to reference the pressable api doc. Added some info around what hitslop and pressrectoffset do. Added reference link to the Pressability.js file/implementation as I don't want to reguritate the info there into the docs because it's pretty well laid out in the comments within that file.

view details

R Nabors

commit sha a0728a179201482a7922c3275dd4159199b63bed

Merge branch 'master' into pressable-api

view details

Rachel Nabors

commit sha 443462c841443ac36194665cbb02a8ac0eedcb4d

Adding illustrations and explanations to Pressable

view details

Rachel Nabors

commit sha 4b93c2b478ccb1069d6254b1f7eec375cdd83478

Adding millisecond durations to presses and changing pressRectOffset to pressRetentionOffset

view details

Rachel Nabors

commit sha cca0b830247bcd89354591f91adfcd290a5faab6

reverting accidental IDE merge of Pressable doc--it's still in review

view details

Rachel Nabors

commit sha 7e9277305310d07ec634fe5a4a821fde0a742a8b

Revert "reverting accidental IDE merge of Pressable doc--it's still in review" This reverts commit cca0b830247bcd89354591f91adfcd290a5faab6. :wq

view details

R Nabors

commit sha fa9c1e84aeddeea2d3cddcbc0aa0660895fcc976

Adding illustrations to security doc (#1934)

view details

Bartosz Kaszubowski

commit sha a3979b40bca71ad9c5c6997da80c994256d4f9ce

Update two page titles (remove "React Native") (#1932)

view details

Johan du Toit

commit sha 8a5d03a593c3a25697dd21821d6ae2863c201ce7

Update native-module-setup.md (#1914)

view details

R Nabors

commit sha 97b71dbb11fb8c799354ea761ef3d4a7b4469f23

Adding the start of Object Types reference (#1936)

view details

Luiz Celso de Faria Alves

commit sha a25a60f430a47e3e6ee29ccbeea5ec3ed15ec8a6

Update examples introduction docs with the new standardize (#1927)

view details

push time in 9 days

PR opened microsoft/react-native-macos

Reviewers
local-cli: quiet npx messages before pod-install

Please select one of the following

  • [X] I am making a fix / change for the macOS implementation of react-native

Summary

Refs #366

This small PR adds --quiet flag also for the npx itself to get rid of the installation message in non verbose run.

This changeset also includes missing @param annotations for the extracted and added methods in the referenced PR.

Changelog

[Internal] [Changed] - react-native-macos-init: pass verbose flag also to npx

Test Plan

I have tested those changes locally by linking working copy of the react-native-macos package in the test macOS app.

Preview

Before

Screenshot 2020-05-17 at 17 06 44

After

Screenshot 2020-05-18 at 21 32 36

+7 -1

0 comment

1 changed file

pr created time in 9 days

create barnchSimek/react-native

branch : npx-quiet

created branch time in 9 days

push eventSimek/expo-cli

Brent Vatne

commit sha fecb8c35c86b3714ed6acf5a7883464853687aa2

fix: Rewrite ProjectUtils.findProjectRootAsync to use @expo/config (#2119) * fix: Rewrite ProjectUtils.findProjectRootAsync to use @expo/config * chore: add test coverage for findProjectRootAsync * Remove unnecessary setting config path

view details

Eric Samelson

commit sha e610c3bc936272044c339b6bb3b8eee5629e8c53

[xdl] prefer expo-updates version from template when ejecting (#2126)

view details

Ville Immonen

commit sha 4467989a3c7e4b53b0c70c54c4d0b8deb99fe927

fix: whoami treating all errors as "not logged in" (#2122) Co-authored-by: Charlie Cheever <ccheever@gmail.com> Co-authored-by: Charlie Cheever <ccheever@gmail.com>

view details

Charlie Cruzan

commit sha 137bfae9b4c6546063e7296e2c146a7ddb3d04aa

fix: dead links & better android keystore logging (#2116)

view details

Brent Vatne

commit sha e1c0d8955cd28669842ea01261833058ec065dc0

chore: update README for image-utils

view details

Ville Immonen

commit sha 8b51fef953b2d6c82c7c47609b8d6c79e13734f7

Clarify wording about upgrading Expo Client in the simulator (#2121) Co-authored-by: Charlie Cheever <ccheever@gmail.com> Co-authored-by: Charlie Cheever <ccheever@gmail.com>

view details

Charlie Cruzan

commit sha c69944867b24e29641903e66532fe5bfdd280c83

fix: warn if no facebook config when building custom client (#2124) * fix: warn if no facebook config when building custom client * apply expo-cli package prettier * fix * change disabledServices key name

view details

Ville Immonen

commit sha f6dc4cf34e3aae4c00c8c619a4a7f07cb910b836

chore(expo-cli): remove log.raw (#2111)

view details

Brent Vatne

commit sha ae467cf329a73dbec1e607f6b2a4f9fce5aa63db

Publish - @expo/config@3.2.4 - @expo/configure-splash-screen@0.1.5 - @expo/dev-server@0.1.5 - @expo/dev-tools@0.13.9 - @expo/electron-adapter@0.0.0-alpha.55 - expo-cli@3.20.6 - expo-optimize@0.1.27 - @expo/image-utils@0.2.25 - @expo/json-file@8.2.16 - @expo/metro-config@0.1.5 - @expo/next-adapter@2.1.7 - @expo/osascript@2.0.19 - @expo/package-manager@0.0.22 - @expo/plist@0.0.5 - pod-install@0.1.1 - expo-pwa@0.0.15 - @expo/schemer@1.3.15 - uri-scheme@1.0.12 - @expo/webpack-config@0.12.7 - @expo/xdl@57.9.6

view details

Brent Vatne

commit sha 21770d9b7da6e591643be6bc52634a6232b5bea4

Publish - @expo/babel-preset-cli@0.2.14 - @expo/config@3.2.5 - @expo/configure-splash-screen@0.1.6 - @expo/dev-server@0.1.6 - @expo/dev-tools@0.13.10 - @expo/electron-adapter@0.0.0-alpha.56 - expo-cli@3.20.7 - expo-codemod@1.0.24 - expo-optimize@0.1.28 - @expo/image-utils@0.2.26 - @expo/json-file@8.2.17 - @expo/metro-config@0.1.6 - @expo/next-adapter@2.1.8 - @expo/osascript@2.0.20 - @expo/package-manager@0.0.23 - @expo/plist@0.0.6 - pod-install@0.1.2 - expo-pwa@0.0.16 - @expo/schemer@1.3.16 - uri-scheme@1.0.13 - @expo/webpack-config@0.12.8 - @expo/xdl@57.9.7

view details

Ville Immonen

commit sha d3b1f02fd346650ca350c49f52346569d62843c3

fix: shrink traveling fastlane (#2128)

view details

Ville Immonen

commit sha 0c3f1ee4fffd1623935d7a6ec744361d2d954bb2

chore: run yarn

view details

Ville Immonen

commit sha 07bf21d3a3aaa3a660a65182a6c5a881055a8ae6

fix(dev-tools): add clean up to avoid inflating package size (#2130)

view details

Ville Immonen

commit sha c0c7b5bba611b0efece1febdc974e953ff94e539

chore: clean up @expo/babel-preset-cli (#2131)

view details

Brent Vatne

commit sha 03aa7e0f4ab2f53a29a540a58a7d3efda475eaca

Publish - @expo/babel-preset-cli@0.2.15 - @expo/config@3.2.6 - @expo/configure-splash-screen@0.1.7 - @expo/dev-server@0.1.7 - @expo/dev-tools@0.13.11 - @expo/electron-adapter@0.0.0-alpha.57 - expo-cli@3.20.8 - expo-codemod@1.0.25 - expo-optimize@0.1.29 - @expo/image-utils@0.2.27 - @expo/json-file@8.2.18 - @expo/metro-config@0.1.7 - @expo/next-adapter@2.1.9 - @expo/osascript@2.0.21 - @expo/package-manager@0.0.24 - @expo/plist@0.0.7 - pod-install@0.1.3 - expo-pwa@0.0.17 - @expo/schemer@1.3.17 - uri-scheme@1.0.14 - @expo/webpack-config@0.12.9 - @expo/xdl@57.9.8

view details

Eric Samelson

commit sha 5417b37e5c912b54ffa29e2632620e8840770369

[expo-cli] copy metro config in eject (#2132) * [expo-cli] copy metro config in eject * reorganize to catch errors thrown by fse

view details

Brent Vatne

commit sha 128fba3ad2d1c1ff2f8909f117ce8d23fc092761

Update xdl cache

view details

Brent Vatne

commit sha d982c94d51621afe422928270ac036fc895bccd9

Bump @expo/build-tools version

view details

Brent Vatne

commit sha b17349f344e165f5ee386f07bae110d73eafefac

Publish - @expo/dev-tools@0.13.12 - expo-cli@3.20.9 - @expo/xdl@57.9.9

view details

Bartosz Kaszubowski

commit sha 3fcb90c874f0f0959110170661a421ed93cd9a98

chore: add --quiet to the pod-install README (#2134)

view details

push time in 9 days

pull request commentmicrosoft/react-native-macos

init cli improvements: check the current version of RNmacOS, other display tweaks

One thing that I'm not sure is if execOptions ( and stdio) can be removed since flags are responsible for handling verbose? Only two minor changes for me testing this were:

  • temporary visible installation progress (Yarn)
  • warning word is yellow at the beginning of the peerDependency warning (see screenshot above) (Yarn).

Screenshot 2020-05-18 at 19 51 54

Simek

comment created time in 9 days

pull request commentmicrosoft/react-native-macos

init cli improvements: check the current version of RNmacOS, other display tweaks

The current failure in the CI just means you need to run yarn change from packages/react-native-macos-init and fill out the prompts. It will write a change log file that will trigger beachball to publish a new version of the package to npmjs.org.

@tom-un I have pushed the generated file, hope I have done this right.

Simek

comment created time in 9 days

push eventSimek/react-native

simek

commit sha 80cc95c53d531bb623a1230f0e003117f16e0f7f

Change files

view details

push time in 9 days

issue commentfacebook/react-native-website

Verify and update Animated Values pages code reference

When I compared the AnimatedValue.jswithAnimated.Value page , the data in the Animated.Value page is similar to the data provided as comment in AnimatedValue.js That was the task. Please do the same with XY. If there is no difference (documaentation is up to date with the current code) this issue should be closed.

Simek

comment created time in 9 days

issue commentfacebook/react-native-website

transform matrix documentation.

Hi @ProBeta1, feel free to work on this issue. Like an author I'm curious too about the matrix structure.

vaukalak

comment created time in 9 days

issue commentfacebook/react-native-website

Verify and update Animated Values pages code reference

Animated values pages (Animated.Value, Animated.ValueXY)

Pages are listed in the description above and the source code links shows exactly which file need to be reviewed:

  • AnimatedValue.js should be compared with the reference on the Animated.Value page
  • AnimatedValueXY.js should be compared with the reference on the Animated.ValueXY page
Simek

comment created time in 9 days

push eventkikisaints/react-native-website

Bartosz Kaszubowski

commit sha 6028cbef6948405a960828e792d45d21c88e8cac

sidebar order

view details

push time in 9 days

startedopenai/jukebox

started time in 9 days

startedfacebook/flipper

started time in 10 days

push eventSimek/react-native

simek

commit sha d7fa525189d0d4b093a224f87e3a7539ca5635ed

few more tweaks

view details

push time in 10 days

startedmicrosoft/fluentui-react-native

started time in 10 days

push eventSimek/react-native

simek

commit sha 2897a800e9935de468d1dec1aaf04c385b6c11c4

typo fix, small tweaks

view details

push time in 10 days

push eventSimek/react-native

simek

commit sha cdf2f6c867726540af690c258c0f1f426c667979

ensure that all errors are red

view details

push time in 10 days

push eventSimek/react-native

simek

commit sha e68935fbef7d63df15627bd65c35bf61824df61b

verbose tweak

view details

push time in 10 days

pull request commentmicrosoft/react-native-macos

init cli improvements: check the current version of RNmacOS, other display tweaks

CI fail looks like not related to this PR:

Failing tests:
	RNTester-macOSIntegrationTests:
		-[RNTesterLoadAllPages JSResponderHandlerExample]

** TEST FAILED **

##[error]Error: /usr/bin/xcodebuild failed with return code: 65
Simek

comment created time in 10 days

more