profile
viewpoint
Sami Hiltunen SamiHiltunen Berlin, Germany

grpc/grpc-web 5178

gRPC for Web Clients

SamiHiltunen/SPDIF-Keep-Alive 1

An OS X daemon for keeping the optical audio output alive.

SamiHiltunen/git2go 0

Git to Go; bindings for libgit2. Like McDonald's but tastier.

SamiHiltunen/open-wc 0

Open Web Components: guides, tools and libraries for modern web development and web components

push eventlovoo/goka

frairon

commit sha 09b1e04502f0a2415c1f199bc6e154330cd29278

Improve topic creation via topic manager fixed flaky tests by not resetting mockconsumergroup on close (not reused anyway) small fix to append to slices in GroupGraph

view details

push time in 8 hours

PR opened lovoo/goka

topic-manager improvements
+1060 -268

0 comment

15 changed files

pr created time in 8 hours

create barnchlovoo/goka

branch : improve-topicmanager-creation

created branch time in 8 hours

delete branch lovoo/goka

delete branch : LVPD-735-topic-fix

delete time in a day

PR closed lovoo/goka

LVPD-843 topic manager improvements
+1039 -268

0 comment

15 changed files

frairon

pr closed time in a day

PR opened lovoo/goka

LVPD-843 topic manager improvements
+1039 -268

0 comment

15 changed files

pr created time in a day

push eventlovoo/goka

Henri Koski

commit sha d905e7965f0480790a0c71466ccf2d5c21a46a4c

Use Go format for examples in README

view details

Jan Bickel

commit sha aa579ba792f414859c5ea2bb73aa7af7563875cd

Merge pull request #295 from heppu/patch-1 Use Go format for examples in README

view details

Jan Bickel

commit sha 55fae71f2c08188e4938ec9a7696830e29524d4b

Cleanup redis and monitoring example

view details

Jan Bickel

commit sha f8cff2d6658e8e08a4fdb08de10a548c8480950a

Merge pull request #294 from lovoo/redis-example-cleanup Cleanup redis and monitoring example

view details

frairon

commit sha 2b79ae1c9b9843185663d2c396267d1ab697aab4

wip topic fix

view details

frairon

commit sha d9b2c5b50b52dc17b46f35052d337d52a39a769d

LVPD-735 improve topic creation via topic manager fixed flaky tests by not resetting mockconsumergroup on close (not reused anyway) small fix to append to slices in GroupGraph

view details

push time in a day

delete branch lovoo/goka

delete branch : redis-example-cleanup

delete time in 6 days

push eventlovoo/goka

Jan Bickel

commit sha 55fae71f2c08188e4938ec9a7696830e29524d4b

Cleanup redis and monitoring example

view details

Jan Bickel

commit sha f8cff2d6658e8e08a4fdb08de10a548c8480950a

Merge pull request #294 from lovoo/redis-example-cleanup Cleanup redis and monitoring example

view details

push time in 6 days

PR merged lovoo/goka

Cleanup redis and monitoring example
+53 -73

0 comment

16 changed files

R053NR07

pr closed time in 6 days

push eventlovoo/goka

Jan Bickel

commit sha 55fae71f2c08188e4938ec9a7696830e29524d4b

Cleanup redis and monitoring example

view details

push time in 7 days

Pull request review commentlovoo/goka

Cleanup redis and monitoring example

+# Redis storage example++Using [Redis](https://redis.io/) as option of storage.++This example has an **Emitter** and one **Processor** with when this emitter+generates events with random keys (_user_id_) consumed by Kafka that uses+Redis as storage/cache.+++## Usage++Run a local Kafka cluster and redis server by calling `make start` in folder `examples/`.+This will start a kafka cluster accessible under `127.0.0.1:9092` and a redis service under+`127.0.0.1:6379` if you want to use a different configuration you need to adjust the config +file `config.yaml`.++The config file also has some more options to set:++```yaml+kafka:+  brokers:+    - "127.0.0.1:9092"+    group: "examples"+    stream: "events"+    redis: "127.0.0.1:6379"+    namespace: "producer"+```++Where:+  * **brokers** : slice of kafka brokers hosts.+  * **group** : group name of this example belongs.+  * **stream**: stream name of this example belongs.+  * **redis**: address of redis (`localhost:6379`).+  * **namespace**: namespace distinguish applications that write to the same keys on Redis.++After starting the machines and adjusting the config run the example with+`go run 7-redis/*.go -config 7-redis/config.yaml`.++The events are produced and consumed by Kafka with random keys. It's possible+run several of the same binary and check the behaviour of kafka+rebalancing and removing partitions without broken.

without broken, what does that mean?

R053NR07

comment created time in 7 days

Pull request review commentlovoo/goka

Cleanup redis and monitoring example

+# Redis storage example++Using [Redis](https://redis.io/) as option of storage.++This example has an **Emitter** and one **Processor** with when this emitter

"with when this" sounds strange. Did you forget a word or have too many? Not sure what you meant here :)

R053NR07

comment created time in 7 days

Pull request review commentlovoo/goka

Cleanup redis and monitoring example

+# Redis storage example++Using [Redis](https://redis.io/) as option of storage.++This example has an **Emitter** and one **Processor** with when this emitter+generates events with random keys (_user_id_) consumed by Kafka that uses+Redis as storage/cache.+++## Usage++Run a local Kafka cluster and redis server by calling `make start` in folder `examples/`.+This will start a kafka cluster accessible under `127.0.0.1:9092` and a redis service under+`127.0.0.1:6379` if you want to use a different configuration you need to adjust the config +file `config.yaml`.++The config file also has some more options to set:++```yaml+kafka:+  brokers:+    - "127.0.0.1:9092"+    group: "examples"

lines 23 to 26 need to be unindented one step to make it consistent with the actual config.yaml

R053NR07

comment created time in 7 days

push eventlovoo/goka

Henri Koski

commit sha d905e7965f0480790a0c71466ccf2d5c21a46a4c

Use Go format for examples in README

view details

Jan Bickel

commit sha aa579ba792f414859c5ea2bb73aa7af7563875cd

Merge pull request #295 from heppu/patch-1 Use Go format for examples in README

view details

push time in 8 days

PR merged lovoo/goka

Use Go format for examples in README
+2 -2

1 comment

1 changed file

heppu

pr closed time in 8 days

pull request commentlovoo/goka

Use Go format for examples in README

Seems like we missed that. Thanks :)

heppu

comment created time in 9 days

PR opened lovoo/goka

Use Go format for examples in README
+2 -2

0 comment

1 changed file

pr created time in 9 days

PR opened lovoo/goka

Cleanup redis and monitoring example
+53 -73

0 comment

16 changed files

pr created time in 9 days

create barnchlovoo/goka

branch : redis-example-cleanup

created branch time in 9 days

push eventlovoo/goka

frairon

commit sha 555c7788ed289d9290841b0106fe5a18f84d9ac1

LVPD-843 callback error leads to processor shutdown

view details

Thomas Linford

commit sha fd018080780f48cad545e0d88651e4a56abc2e82

fix topic manager stream retention not in milliseconds

view details

Franz Eichhorn

commit sha 5092fdc76776fd49b30c6e35b5fe516c17e85706

Merge pull request #291 from lovoo/LVPD-843-stuck-shutdown LVPD-843 callback error leads to processor shutdown

view details

Franz Eichhorn

commit sha 569d2e77a845555730d28f199ccce666954f98df

Merge pull request #293 from tlinford/master fix topic manager stream retention not in milliseconds

view details

frairon

commit sha 5e22ac16fadc6782062c1036c0b4b44c98252270

wip topic fix

view details

push time in 16 days

push eventlovoo/goka

Thomas Linford

commit sha fd018080780f48cad545e0d88651e4a56abc2e82

fix topic manager stream retention not in milliseconds

view details

Franz Eichhorn

commit sha 569d2e77a845555730d28f199ccce666954f98df

Merge pull request #293 from tlinford/master fix topic manager stream retention not in milliseconds

view details

push time in a month

PR merged lovoo/goka

fix topic manager stream retention not in milliseconds

Noticed that topics created with TopicManager.EnsureStreamExists had much longer retention than expected, and setting it to -1 to avoid deletion doesn't work either. %d on a duration seems to print out number of microseconds, and not milliseconds:

t := 1 * time.Hour
fmt.Printf("%d", t)

gives: 3600000000000

+1 -1

1 comment

1 changed file

tlinford

pr closed time in a month

pull request commentlovoo/goka

fix topic manager stream retention not in milliseconds

The whole functionality of creating and maintaining topics required for processors is somehow buggy and obviously needs some love, we noticed that some time ago. Especially when your cluster is configured to auto-create topics, you might end up having topics with the wrong configuration. But we're working on that. Nevertheless this retention-config was a bug and needed to be fixed, so thanks a lot!

tlinford

comment created time in a month

delete branch lovoo/goka

delete branch : LVPD-843-stuck-shutdown

delete time in a month

push eventlovoo/goka

frairon

commit sha 555c7788ed289d9290841b0106fe5a18f84d9ac1

LVPD-843 callback error leads to processor shutdown

view details

Franz Eichhorn

commit sha 5092fdc76776fd49b30c6e35b5fe516c17e85706

Merge pull request #291 from lovoo/LVPD-843-stuck-shutdown LVPD-843 callback error leads to processor shutdown

view details

push time in a month

PR merged lovoo/goka

Reviewers
LVPD-843 callback error leads to processor shutdown
+154 -12

0 comment

4 changed files

frairon

pr closed time in a month

PR opened lovoo/goka

fix topic manager stream retention not in milliseconds

Noticed that topics created with TopicManager.EnsureStreamExists had much longer retention than expected, and setting it to -1 to avoid deletion doesn't work either. %d on a duration seems to print out number of microseconds, and not milliseconds:

t := 1 * time.Hour
fmt.Printf("%d", t)

gives: 3600000000000

+1 -1

0 comment

1 changed file

pr created time in a month

issue commentlovoo/goka

Processor does not stop on error

#291 approved @frairon

tlinford

comment created time in a month

issue commentlovoo/goka

Processor does not stop on error

Hi @tlinford, thanks for the issue report! There's an open PR that fixes exactly that issue, see #291. I guess I just have to push harder to get some approvals :)

tlinford

comment created time in a month

more