Btw for my own rust education was the workaround correct if this were an issue on this side (switching to interior mutability with Rc<RefCell<>>)?

Unfortunately not. The code was already using RefCell<T> which has runtime borrow-checking. Rc can add reference counting, but it cannot change the behavior of runtime borrow checking with reentrant calls.

Seems the module status is under active development.
And there is no official release for this.

So is this module ready for production?

Summary:

when I set the response header like this, and I will receipt header content-type: text/plain,text/html

self.send_http_response(
    200,
    vec![("content-type", "text/html")],
    body,
)

update: when i use istio/proxy2:1.8.1, there have not issue, but istio/proxy2:1.7.4 have, it's proxy issue

I added some changes to improve performance when brotli_comp_level is used with a static value. In such cases we don't want to evaluate the complex value on every http request. Instead, evaluation is done at config merge time when nginx is still starting up. Didn't get around to do that commit cleanup, but you can still have a look if you're interested: https://github.com/fholzer/ngx_brotli/commits/variable-compression-level

This is great! You could set different compression level based on upstream's cache control response header. This would allow you to use better compression for resources that can be cached, and worse compression for no-cache/private resources using a map. I rebased this PR onto master in my fork, though there's still some unrelated commits in my branch which I'd like to clean up first.

Sorry for the question but I couldn't find documentation.

Can this SDK be used to create network filter for envoy ?

Thank you

found:

impl StreamContext for Authorizer {
    fn on_new_connection(&mut self) -> Action {
        info!("New TCP Connection : #{}", self.context_id);
        Action::Continue
    }

    fn on_downstream_data(&mut self, _data_size: usize, _end_of_stream: bool) -> Action {
        Action::Continue
    }


}

@eustas thanks a lot for your message! Here is working Dockerfile based on it:

# Build
FROM nginx:1.19.6 as build

WORKDIR /build

# install brotli build dependencies
RUN \
    apt-get update > /dev/null \
    && apt-get install gcc git libpcre3-dev libssl-dev make zlib1g-dev -y

# build brotli
RUN git clone https://github.com/google/ngx_brotli.git --recurse-submodules
RUN git clone https://github.com/nginx/nginx.git

WORKDIR /build/nginx

RUN git checkout release-1.19.6
RUN ./auto/configure \
  --add-dynamic-module=/build/ngx_brotli \
  --with-debug \
  --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --modules-path=/usr/lib/nginx/modules --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/error.log --http-log-path=/var/log/nginx/access.log --pid-path=/var/run/nginx.pid --lock-path=/var/run/nginx.lock --http-client-body-temp-path=/var/cache/nginx/client_temp --http-proxy-temp-path=/var/cache/nginx/proxy_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-uwsgi-temp-path=/var/cache/nginx/uwsgi_temp --http-scgi-temp-path=/var/cache/nginx/scgi_temp --user=nginx --group=nginx --with-compat --with-file-aio --with-threads --with-http_addition_module --with-http_auth_request_module --with-http_dav_module --with-http_flv_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_mp4_module --with-http_random_index_module --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-mail --with-mail_ssl_module --with-stream --with-stream_realip_module --with-stream_ssl_module --with-stream_ssl_preread_module --with-cc-opt='-g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.19.6/debian/debuild-base/nginx-1.19.6=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC' --with-ld-opt='-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -pie'
RUN make modules

# Run
FROM nginx:1.19.6

# add compiled brotli module
COPY --from=build /build/nginx/objs/ngx_http_brotli_filter_module.so /usr/lib/nginx/modules/
COPY --from=build /build/nginx/objs/ngx_http_brotli_static_module.so /usr/lib/nginx/modules/

# run nginx with configuration reload once in every 6 hours
CMD /bin/sh -c 'while :; do /bin/sleep 6h & wait ${!}; /usr/sbin/nginx -s reload; done & /usr/sbin/nginx -g "daemon off;"'

My installation but still get some errors.

yum -y install git python python-devel gcc zlib perl libxml2 libxslt autoconf automake bind-utils wget curl unzip gcc-c++ pcre-devel zlib-devel libtool make pam-devel

cd /usr/local/src git clone https://github.com/google/ngx_brotli cd ngx_brotli git submodule update --init

{ result [root@mail ngx_brotli]# git submodule update --init Submodule 'deps/brotli' (https://github.com/google/brotli.git) registered for path 'deps/brotli' Cloning into '/usr/local/src/ngx_brotli/deps/brotli'... Submodule path 'deps/brotli': checked out 'e61745a6b7add50d380cfd7d3883dd6c62fc2c71' }

cd /usr/local/directadmin/custombuild wget https://nginx.org/download/nginx-1.19.6.tar.gz tar -zxvf nginx-1.19.6.tar.gz cd nginx-1.19.6

./configure --with-compat --add-dynamic-module=/usr/local/src/ngx_brotli make modules

nano /etc/nginx/nginx.conf

#mkdir /usr/local/nginx/modules #cp /usr/local/directadmin/custombuild/nginx-1.19.6/objs/ngx_http_brotli_filter_module.so /usr/local/nginx/modules/ngx_http_brotli_filter_module.so #cp /usr/local/directadmin/custombuild/nginx-1.19.6/objs/ngx_http_brotli_static_module.so /usr/local/nginx/modules/ngx_http_brotli_static_module.so

add above the http block

load_module /usr/local/nginx/modules/ngx_http_brotli_filter_module.so; load_module /usr/local/nginx/modules/ngx_http_brotli_static_module.so;

./configure --add-module=/usr/local/src/ngx_brotli make && make install

{ result Configuration summary + using system PCRE library + OpenSSL library is not used + using system zlib library

nginx path prefix: "/usr/local/nginx"
nginx binary file: "/usr/local/nginx/sbin/nginx"
nginx modules path: "/usr/local/nginx/modules"
nginx configuration prefix: "/usr/local/nginx/conf"
nginx configuration file: "/usr/local/nginx/conf/nginx.conf"
nginx pid file: "/usr/local/nginx/logs/nginx.pid"
nginx error log file: "/usr/local/nginx/logs/error.log"
nginx http access log file: "/usr/local/nginx/logs/access.log"
nginx http client request body temporary files: "client_body_temp"
nginx http proxy temporary files: "proxy_temp"
nginx http fastcgi temporary files: "fastcgi_temp"
nginx http uwsgi temporary files: "uwsgi_temp"
nginx http scgi temporary files: "scgi_temp"

}

nginx -t

{ result [root@mail nginx-1.19.6]# nginx -t nginx: [emerg] "load_module" directive is specified too late in /etc/nginx/nginx.conf:14 nginx: configuration file /etc/nginx/nginx.conf test failed }

Error missing files.

mkdir /usr/modules cp /usr/local/directadmin/custombuild/nginx-1.19.6/objs/.so /usr/modules ls /usr/modules chmod 644 /usr/modules/.soso

{ changed positon and fixed the missing files. [root@mail nginx-1.19.6]# nginx -t nginx: [emerg] module "/usr/modules/ngx_http_brotli_filter_module.so" is not binary compatible in /etc/nginx/nginx.conf:10 nginx: configuration file /etc/nginx/nginx.conf test failed }

systemctl reload nginx.service

Hi, I am trying http_auth_random.rs and I am seeing the same error as in https://github.com/proxy-wasm/proxy-wasm-rust-sdk/issues/19

For the solution in https://github.com/proxy-wasm/proxy-wasm-rust-sdk/issues/19#issuecomment-668846982, can someone elaborate it? How/where can I apply this? Sorry that I am new to this.

Thanks,

Got it working. Turned out I need to add a cluster for "httpbin" in envoy config.

i got same problem too, pls check this problem

Hi, I am trying http_auth_random.rs and I am seeing the same error as in https://github.com/proxy-wasm/proxy-wasm-rust-sdk/issues/19

For the solution, can someone elaborate it? Sorry that I am new to this. https://github.com/proxy-wasm/proxy-wasm-rust-sdk/issues/19#issuecomment-668846982

Thanks,

Signed-off-by: mathetake [email protected]

Signed-off-by: mathetake [email protected]

(This seems related to pull request #111 btw.)

That option does not exist, Nginx's built-in Gzip support has gzip_proxied though.

Sorry for the question but I couldn't find documentation.

Can this SDK be used to create network filter for envoy ?

Thank you

same problem here, I solved by using proxyv2:1.5.1 I could not make it running on Mac OS btw. With Ubuntu it works.