profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/PeterAdams-A/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

swift-server/async-http-client 481

HTTP client library built on SwiftNIO

PeterAdams-A/async-http-client 0

HTTP client library built on SwiftNIO

PeterAdams-A/grpc 0

The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)

PeterAdams-A/grpc-swift 0

The Swift language implementation of gRPC.

PeterAdams-A/sswg 0

Swift Server Working Group (SSWG)

PeterAdams-A/swift-log 0

A Logging API for Swift

PeterAdams-A/swift-nio 0

Event-driven network application framework for high performance protocol servers & clients, non-blocking.

PeterAdams-A/swift-nio-examples 0

examples of how to use swift-nio

PeterAdams-A/swift-nio-extras 0

Useful code around SwiftNIO.

PeterAdams-A/swift-nio-http2 0

HTTP/2 support for SwiftNIO

Pull request review commentswift-server/guides

Swift Concurrency adoption guidelines for Swift Server Libraries

+# Swift Concurrency adoption guidelines for Swift Server Libraries++This writeup attempts to provide a set of guidelines to follow by authors of server-side Swift libraries. Specifically a lot of the discussion here revolves around what to do about existing APIs and libraries making extensive use of Swift NIO’s `EventLoopFuture` and related types.++Swift Concurrency is a multi-year effort. It is very valuable for the server community to participate in this multi-year adoption of the concurrency features, one by one, and provide feedback while doing so. As such, we should not hold off adopting concurrency features until Swift 6 as we may miss valuable opportunity to improve the concurrency model.++In 2021 we saw structured concurrency and actors arrive with Swift 5.5. Now is a great time to provide APIs using those primitives. In the future we will see fully checked Swift concurrency. This will come with breaking changes. For this reason adopting the new concurrency features can be split into two phases.+++## What you can do right now++### API Design++Firstly, existing libraries should strive to add `async` functions where possible to their user-facing “surface” APIs in addition to existing `*Future` based APIs wherever possible. These additive APIs can be gated on the Swift version and can be added without breaking existing users' code, for example like this:++```swift+extension Worker {+  func work() -> EventLoopFuture<Value> { ... }+  +  #if swift(>=5.5)+  func work() async throws -> Value { ... }+  #endif+}+```++If a function cannot fail but was using futures before, it should not include the `throws` keyword in its new incarnation. ++Such adoption can begin immediately, and should not cause any issues to existing users of existing libraries. ++### SwiftNIO helper functions++To allow an easy transition to async code, SwiftNIO offers a number of helper methods on `EventLoopFuture` and `-Promise`. Those live in the `_NIOConcurrency` module and will move to `NIOCore` once Swift concurrency is released.++On every `EventLoopFuture` you can call `.get()` to transition the future into an `await`-able invocation. If you want to translate async/await calls to an `EventLoopFuture` we recommend the following pattern:++```swift +#if swift(>=5.5)+func yourAsyncFunctionConvertedToAFuture(on eventLoop: EventLoop) +    -> EventLoopFuture<Result> {+    let promise = context.eventLoop.makePromise(of: Out.self)+    promise.completeWithTask {+        try await yourMethod(yourInputs)+    }+    return promise.futureResult+}+#endif+```++Further helpers exist for `EventLoopGroup`, `Channel`, `ChannelOutboundInvoker` and `ChannelPipeline`.++### Sendable Checking++> [SE-0302][SE-0302] introduced the `Sendable` protocol, which is used to indicate which types have values that can safely be copied across actors or, more generally, into any context where a copy of the value might be used concurrently with the original. Applied uniformly to all Swift code, `Sendable` checking eliminates a large class of data races caused by shared mutable state.+>+> -- from [Staging in Sendable checking][sendable-staging], which outlines the `Sendable` adoption plan for Swift 6.++In the future we will see fully checked Swift concurrency. The language features to support this are the `Sendable` protocol and the `@Sendable` keyword for closures. Since sendable checking will break existing Swift code, a new major Swift version is required.++To ease the transition to fully checked Swift code, it is possible to annotate your APIs with the `Sendable` protocol today.++You can start adopting Sendable and getting appropriate warnings in Swift 5.5 already by passing the `-warn-concurrency` flag, you can do so in SwiftPM for the entire project like so:++```+swift build -Xswiftc -Xfrontend -Xswiftc -warn-concurrency+```+++#### Sendable checking today++Sendable checking is currently disabled in Swift 5.5(.0) because it was causing a number of tricky situations for which we lacked the tools to resolve.++Most of these issues have been resolved on today’s `main` branch of the compiler, and are expected to land in the next Swift 5.5 releases. It may be worthwhile waiting for adoption until the next version(s) after 5.5.0.++For example, one of such capabilities is the ability for tuples of `Sendable` types to conform to `Sendable` as well. We recommend holding off adoption of `Sendable` until this patch lands in Swift 5.5 (which should be relatively soon). With this change, the difference between Swift 5.5 with `-warn-concurrency` enabled and Swift 6 mode should be very small, and manageable on a case by case basis.++#### Backwards compatibility of declarations and “checked” Swift Concurrency++Adopting Swift Concurrency will progressively cause more warnings, and eventually compile time errors in Swift 6 when sendability checks are violated, marking potentially unsafe code.++It may be difficult for a library to maintain a version that is compatible with versions prior to Swift 6 while also fully embracing the new concurrency checks. For example, it may be necessary to mark generic types as `Sendable`, like so:++```swift+struct Container<Value: Sendable>: Sendable { ... }+```++Here, the `Value` type must be marked `Sendable` for Swift 6’s concurrency checks to work properly with such container. However, since the `Sendable` type does not exist in Swift prior to Swift 5.5, it would be difficult to maintain a library that supports both Swift 5.4+ as well as Swift 6.++In such situations, it may be helpful to utilize the following trick to be able to share the same `Container` declaration between both Swift versions of the library:++```swift+#if compiler(>=5.5)+public typealias MYPREFIX_Sendable = Swift.Sendable+#else +public typealias MYPREFIX_Sendable = Any+#endif+```++The `Any` alias is effectively a no-op when applied as generic constraint, and thus this way it is possible to keep the same `Container<Value>` declaration working across Swift versions.++### Task Local Values and Logging++The newly introduced Task Local Values API ([SE-0311][SE-0311]) allows for implicit carrying of metadata along with `Task` execution. It is a natural fit for for tracing and carrying metadata around with task execution, and e.g. including it in log messages. ++We are working on adjusting [SwiftLog](https://github.com/apple/swift-log) to become powerful enough to automatically pick up and log specific task local values. This change will be introduced in a source compatible way. ++For now libraries should continue using logger metadata, but we expect that in the future a lot of the cases where metadata is manually passed to each log statement can be replaced with setting task local values. ++### Preparing for the concept of Deadlines++Deadlines are another feature that closely relate to Swift Concurrency, and were originally pitched during the early versions of the Structured Concurrency proposal and later on moved out of it. The Swift team remains interested in introducing deadline concepts to the language and some preparation for it already has been performed inside the concurrency runtime. Right now however, there is no support for deadlines in Swift Concurrency and it is fine to continue using mechanisms like `NIODeadline` or similar mechanisms to cancel tasks after some period of time has passed. ++Once Swift Concurrency gains deadline support, they will manifest in being able to cancel a task (and its child tasks) once such deadline (point in time) has been exceeded. For APIs to be “ready for deadlines” they don’t have to do anything special other than preparing to be able to deal with `Task`s and their cancellation.++### Cooperatively handling Task cancellation++`Task` cancellation exists today in Swift Concurrency and is something that libraries may already handle. In practice it means that any asynchronous function (or function which is expected to be called from within `Task`s), may use the [`Task.isCancelled`](https://developer.apple.com/documentation/swift/task/3814832-iscancelled) or [`try Task.checkCancellation()`](https://developer.apple.com/documentation/swift/task/3814826-checkcancellation) APIs to check if the task it is executing in was cancelled, and if so, it may cooperatively abort any operation it was currently performing.++Cancellation can be useful in long running operations, or before kicking off some expensive operation. For example, an HTTP client MAY check for cancellation before it sends a request — it perhaps does not make sense to send a request if it is known the task awaiting on it does not care for the result anymore after all!++Cancellation in general can be understood as “the one waiting for the result of this task is not interested in it anymore”, and it usually is best to throw a “cancelled” error when the cancellation is encountered. However, in some situations returning a “partial” result may also be appropriate (e.g. if a task is collecting many results, it may return those it managed to collect until now, rather than returning none or ignoring the cancellation and collecting all remaining results).++## What to expect with Swift 6++### Sendable: Global variables & imported code++Today, Swift 5.5 does not yet handle global variables at all within its concurrency checking model. This will soon change but the exact semantics are not set in stone yet. In general, avoid using global properties and variables wherever possible to avoid running into issues in the future. Consider deprecating global variables if able to.++Some global variables have special properties, such as `errno` which contains the error code of system calls. It is a thread local variable and therefore safe to read from any thread/`Task`. We expect to improve the importer to annotate such globals with some kind of “known to be safe” annotation, such that the Swift code using it, even in fully checked concurrency mode won’t complain about it. Having that said, using `errno` and other “thread local” APIs is very error prone in Swift Concurrency because thread-hops may occur at any suspension point, so the following snippet is very likely incorrect:++```swift+sys_call(...)+await ...+let err = errno // BAD, we are most likely on a different thread here (!)+```++Please take care when interacting with any thread-local API from Swift Concurrency. If your library had used thread local storage before, you will want to move them to use [task-local values](https://github.com/apple/swift-evolution/blob/main/proposals/0311-task-locals.md) instead as they work correctly with Swift’s structured concurrency tasks.++Another tricky situation is with imported C code. There may be no good way to annotate the imported types as Sendable (or it would be too troublesome to do so by hand). Swift is likely to gain improved support for imported code and potentially allow ignoring some of the concurrency safety checks on imported code. ++These relaxed semantics for imported code are not implemented yet, but keep it in mind when working with C APIs from Swift and trying to adopt the `-warn-concurrency` mode today. Please file any issues you hit on [bugs.swift.org](https://bugs.swift.org/secure/Dashboard.jspa) so we can inform the development of these checking heuristics based on real issues you hit.++### Custom Executors++We expect that Swift Concurrency will allow custom executors in the future. A custom executor would allow the ability to run actors / tasks “on” such executor. It is possible that `EventLoop`s could become such executors, however the custom executor proposal has not been pitched yet.++While we expect potential performance gains from using custom executors “on the same event loop” by avoiding asynchronous hops between calls to different actors, their introduction will not fundamentally change how NIO libraries are structured.++The guidance here will evolve as Swift Evolution proposals for Custom Executors are proposed, but don’t hold off adopting Swift Concurrency until custom executors “land” - it is important to start adoption early. For most code we believe that the gains from adopting Swift Concurrency vastly outweigh the slight performance cost actor-hops might induce.+++### Reduce use of Swift NIO Futures as “Concurrency Library“++Swift NIO currently provides a number of currency types for the Swift on Server ecosystem. Most notably `EventLoopFuture`s and `EventLoopPromise`s, that are used widely for asynchronous results. While the SSWG recommended using those at the API level in the past for easier interplay of server libraries, we advise to deprecate or remove such APIs once Swift 6 lands. The swift-server ecosystem should go all in on the structured concurrency features the languages provides. For this reason, it is crucial to provide async/await APIs today, to give your library users time to adopt the new APIs.++Some NIO types will remain however in the public interfaces of Swift on server libraries. We expect that networking clients and servers continue to be initialized with `EventLoopGroup`s. The underlying transport mechanism (`NIOPosix` and `NIOTransportServices`) should become implementation details however and should not be exposed to library adopters.++### NIO 3++While subject to change, it is likely that Swift NIO will cut a 3.0 release in the months after Swift 6.0, at which point in time Swift will have enabled “full” `Sendable` checking.++Do not expect NIO to suddenly become “more async”, NIO’s inherent design principles are about performing small tasks on the event loop and using Futures for any async operations. The design of NIO is not expected to change. It is crucial to its high performance networking design. Channel pipelines are not expected to become “async”.++The NIO team will however use the chance to remove deprecated APIs and improve some APIs. The scope of changes should be comparable to the NIO1 → NIO2 version bump. If your SwiftNIO code compiles today without warnings, chances are high that it will continue to work without modifications in NIO3.++After the release of NIO3, NIO2 will see bug fixes only.++### End-user code breakage++It is expected that Swift 6 will break some code. As mentioned Swift NIO 3 is also going to be released sometime around Swift 6 dropping. Keeping this in mind, it might be a good idea to align major version releases around the same time, along with updating version requirements to Swift 6 and NIO 3 in your libraries.

I wonder if "swift 6 dropping" is a term that everyone will recognise. eg, wondering what that would translate to if I ran this through google translate to a non-english language.

fabianfett

comment created time in a day

PullRequestReviewEvent

Pull request review commentswift-server/guides

Swift Concurrency adoption guidelines for Swift Server Libraries

+# Swift Concurrency adoption guidelines for Swift Server Libraries++This writeup attempts to provide a set of guidelines to follow by authors of server-side Swift libraries. Specifically a lot of the discussion here revolves around what to do about existing APIs and libraries making extensive use of Swift NIO’s `EventLoopFuture` and related types.++Swift Concurrency is a multi-year effort. It is very valuable for the server community to participate in this multi-year adoption of the concurrency features, one by one, and provide feedback while doing so. As such, we should not hold off adopting concurrency features until Swift 6 as we may miss valuable opportunity to improve the concurrency model.++In 2021 we saw structured concurrency and actors arrive with Swift 5.5. Now is a great time to provide APIs using those primitives. In the future we will see fully checked Swift concurrency. This will come with breaking changes. For this reason adopting the new concurrency features can be split into two phases.+++## What you can do right now++### API Design++Firstly, existing libraries should strive to add `async` functions where possible to their user-facing “surface” APIs in addition to existing `*Future` based APIs wherever possible. These additive APIs can be gated on the Swift version and can be added without breaking existing users' code, for example like this:++```swift+extension Worker {+  func work() -> EventLoopFuture<Value> { ... }+  +  #if swift(>=5.5)+  func work() async throws -> Value { ... }+  #endif+}+```++If a function cannot fail but was using futures before, it should not include the `throws` keyword in its new incarnation. ++Such adoption can begin immediately, and should not cause any issues to existing users of existing libraries. ++### SwiftNIO helper functions++To allow an easy transition to async code, SwiftNIO offers a number of helper methods on `EventLoopFuture` and `-Promise`. Those live in the `_NIOConcurrency` module and will move to `NIOCore` once Swift concurrency is released.++On every `EventLoopFuture` you can call `.get()` to transition the future into an `await`-able invocation. If you want to translate async/await calls to an `EventLoopFuture` we recommend the following pattern:++```swift +#if swift(>=5.5)+func yourAsyncFunctionConvertedToAFuture(on eventLoop: EventLoop) +    -> EventLoopFuture<Result> {+    let promise = context.eventLoop.makePromise(of: Out.self)+    promise.completeWithTask {+        try await yourMethod(yourInputs)+    }+    return promise.futureResult+}+#endif+```++Further helpers exist for `EventLoopGroup`, `Channel`, `ChannelOutboundInvoker` and `ChannelPipeline`.++### Sendable Checking++> [SE-0302][SE-0302] introduced the `Sendable` protocol, which is used to indicate which types have values that can safely be copied across actors or, more generally, into any context where a copy of the value might be used concurrently with the original. Applied uniformly to all Swift code, `Sendable` checking eliminates a large class of data races caused by shared mutable state.+>+> -- from [Staging in Sendable checking][sendable-staging], which outlines the `Sendable` adoption plan for Swift 6.++In the future we will see fully checked Swift concurrency. The language features to support this are the `Sendable` protocol and the `@Sendable` keyword for closures. Since sendable checking will break existing Swift code, a new major Swift version is required.++To ease the transition to fully checked Swift code, it is possible to annotate your APIs with the `Sendable` protocol today.++You can start adopting Sendable and getting appropriate warnings in Swift 5.5 already by passing the `-warn-concurrency` flag, you can do so in SwiftPM for the entire project like so:++```+swift build -Xswiftc -Xfrontend -Xswiftc -warn-concurrency+```+++#### Sendable checking today++Sendable checking is currently disabled in Swift 5.5(.0) because it was causing a number of tricky situations for which we lacked the tools to resolve.++Most of these issues have been resolved on today’s `main` branch of the compiler, and are expected to land in the next Swift 5.5 releases. It may be worthwhile waiting for adoption until the next version(s) after 5.5.0.++For example, one of such capabilities is the ability for tuples of `Sendable` types to conform to `Sendable` as well. We recommend holding off adoption of `Sendable` until this patch lands in Swift 5.5 (which should be relatively soon). With this change, the difference between Swift 5.5 with `-warn-concurrency` enabled and Swift 6 mode should be very small, and manageable on a case by case basis.

It would be better to put an expected date in rather than relatively soon or this guide will not read well in a few months time.

fabianfett

comment created time in a day

PullRequestReviewEvent

push eventPeterAdams-A/swift-nio

Peter Adams

commit sha ec62f0e4ef2810bd5ed5fe1ddc93eaae56a61721

Remove 1.0 from repo table

view details

Peter Adams

commit sha 37b12ed6050e4294fd1cad57f49316b386c4e220

Merge branch 'nio1support' of github.com:PeterAdams-A/swift-nio into nio1support

view details

push time in 11 days

pull request commentapple/swift-nio

Clarify the support status of NIO1

There's a table in the "Repository organization" section with a NIO 1 column; should we remove that too?

I think we should remove it in May 22 when it actually becomes unsupported.

PeterAdams-A

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentapple/swift-nio

Clarify the support status of NIO1

 APNS | ✅ | ❌ | [kylebrowning/APNSwift](https://github.com/kylebrowning/APNSw PostgreSQL | ✅ | ❌ | [vapor/postgres-nio](https://github.com/vapor/postgres-nio) | `PostgresNIO` | SSWG community project Redis | ✅ | ❌ | [mordil/swift-redi-stack](https://gitlab.com/Mordil/swift-redi-stack) | `RediStack` | SSWG community project -### Supported Platforms+### Supported Versions -SwiftNIO aims to support all of the platforms where Swift is supported. Currently, it is developed and tested on macOS and Linux, and is known to support the following operating system versions:+### SwiftNIO 2+This is the current version of SwiftNIO and will be supported for the forseeable future. -* Ubuntu 18.04+-* macOS 10.9+, iOS 7+; (macOS 10.14+, iOS 12+, tvOS 12+ or watchOS 6+ with [swift-nio-transport-services][repo-nio-transport-services])+The latest released SwiftNIO 2 version supports Swift 5.2+. NIO 2.29.0 and older support Swift 5.0+. -### Swift versions+### SwiftNIO 1+SwiftNIO 1 is considered end of life - it is strongly recommended that you move to a newer version.  The Core NIO team does not actively work on this version.  No new features will be added to this version but PRs which fix bugs or security vulnerabilities will be accepted until the end of May 2022.

I'm prepping for NIO3

PeterAdams-A

comment created time in 12 days

Pull request review commentapple/swift-nio

Clarify the support status of NIO1

 APNS | ✅ | ❌ | [kylebrowning/APNSwift](https://github.com/kylebrowning/APNSw PostgreSQL | ✅ | ❌ | [vapor/postgres-nio](https://github.com/vapor/postgres-nio) | `PostgresNIO` | SSWG community project Redis | ✅ | ❌ | [mordil/swift-redi-stack](https://gitlab.com/Mordil/swift-redi-stack) | `RediStack` | SSWG community project -### Supported Platforms+### Supported Versions -SwiftNIO aims to support all of the platforms where Swift is supported. Currently, it is developed and tested on macOS and Linux, and is known to support the following operating system versions:+### SwiftNIO 2+This is the current version of SwiftNIO and will be supported for the forseeable future. -* Ubuntu 18.04+-* macOS 10.9+, iOS 7+; (macOS 10.14+, iOS 12+, tvOS 12+ or watchOS 6+ with [swift-nio-transport-services][repo-nio-transport-services])+The latest released SwiftNIO 2 version supports Swift 5.2+. NIO 2.29.0 and older support Swift 5.0+.

Probably not given that someone has just made nio1 work with swift 5.5. It would seem unreasonable to be more restrictive here. We do have practical constraints though that we can only do patch releases and stick with sensible semantic versioning.

PeterAdams-A

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentapple/swift-nio

Clarify the support status of NIO1

 APNS | ✅ | ❌ | [kylebrowning/APNSwift](https://github.com/kylebrowning/APNSw PostgreSQL | ✅ | ❌ | [vapor/postgres-nio](https://github.com/vapor/postgres-nio) | `PostgresNIO` | SSWG community project Redis | ✅ | ❌ | [mordil/swift-redi-stack](https://gitlab.com/Mordil/swift-redi-stack) | `RediStack` | SSWG community project -### Supported Platforms+### Supported Versions -SwiftNIO aims to support all of the platforms where Swift is supported. Currently, it is developed and tested on macOS and Linux, and is known to support the following operating system versions:+### SwiftNIO 1+SwiftNIO 1 is considered end of life - it is strongly recommended that you move to a newer version.  The Core NIO team does not actively work on this version.  No new features will be added to this version but PRs which fix bugs will be accepted until the end of May 2022. -* Ubuntu 18.04+-* macOS 10.9+, iOS 7+; (macOS 10.14+, iOS 12+, tvOS 12+ or watchOS 6+ with [swift-nio-transport-services][repo-nio-transport-services])+If you have a SwiftNIO 1 application or library that you would like to migrate to SwiftNIO 2, please check out the [migration guide](docs/migration-guide-NIO1-to-NIO2.md) we prepared for you. -### Swift versions+The latest released SwiftNIO 1 version supports Swift 4.0, 4.1, 4.2, and 5.0. -#### SwiftNIO 1+### SwiftNIO 2+This is the current version of SwiftNIO and will be supported for the forseeable future. -The latest released SwiftNIO 1 version supports Swift 4.0, 4.1, 4.2, and 5.0.+The latest released SwiftNIO 2 version supports Swift 5.2, 5.3, and 5.4. NIO 2.29.0 and older support Swift 5.0+.

yes.

PeterAdams-A

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentapple/swift-nio

Clarify the support status of NIO1

 APNS | ✅ | ❌ | [kylebrowning/APNSwift](https://github.com/kylebrowning/APNSw PostgreSQL | ✅ | ❌ | [vapor/postgres-nio](https://github.com/vapor/postgres-nio) | `PostgresNIO` | SSWG community project Redis | ✅ | ❌ | [mordil/swift-redi-stack](https://gitlab.com/Mordil/swift-redi-stack) | `RediStack` | SSWG community project -### Supported Platforms+### Supported Versions -SwiftNIO aims to support all of the platforms where Swift is supported. Currently, it is developed and tested on macOS and Linux, and is known to support the following operating system versions:+### SwiftNIO 1

Done.

PeterAdams-A

comment created time in 16 days

PullRequestReviewEvent

push eventPeterAdams-A/swift-nio

Peter Adams

commit sha 6ca646a085b4eac97c2554874dfe64e0051a44c9

Code review suggestions

view details

push time in 16 days

push eventPeterAdams-A/swift-nio

Peter Adams

commit sha ed03c3bf57594ef8251c98ab89fe19f6a5903aa5

accept security vulnerabilities. Co-authored-by: George Barnett <gbarnett@apple.com>

view details

push time in 16 days

PR opened apple/swift-nio

Clarify the support status of NIO1

Motivation:

It's currently unclear that SwiftNIO1 is end of life.

Modifications:

Update the README to set a deadline on patches to NIO1

Result:

Everyone knows where the core team stands on supporting NIO1

+13 -9

0 comment

1 changed file

pr created time in 16 days

create barnchPeterAdams-A/swift-nio

branch : nio1support

created branch time in 16 days

issue openedapple/swift-nio

Replace NIOAtomics with swift-atomics

We should use the standard code now it's available.

created time in 18 days

PullRequestReviewEvent

Pull request review commentswift-server/async-http-client

[RFC] Add async/await proposal

+# Proposal: Async-await support++## Introduction++With the introduction of [async/await][SE-0296] in Swift 5.5, it is now possible to write asynchronous code without the need for callbacks. ++Language support for [`AsyncSequence`][SE-0298] also allows for writing functions that return values over time.++We would like to explore how we could offer APIs that make use of these new language features to allow users to run HTTPRequest using these new idioms.++This proposal describes what these APIs could look like and explores some of the potential usability concerns.++## Proposed API additions++### New `HTTPClientRequest` type++The proposed new `HTTPClientRequest` shall be a simple swift structure.++```swift+struct HTTPClientRequest {+  /// The requests url.+  var url: String+  +  /// The request's HTTPMethod+  var method: HTTPMethod+  +  /// The request's headers+  var headers: HTTPHeaders

Could make the third way a protocol with default implementations for both such that if we get the right one it's close to free, and wrong one is just the conversion we'd have to do anyway.

fabianfett

comment created time in a month

pull request commentapple/swift-nio-transport-services

Move check for event loop shutdown into taskQueue

Raised night build fail - https://bugs.swift.org/browse/SR-15090

PeterAdams-A

comment created time in a month

pull request commentapple/swift-nio-transport-services

Move check for event loop shutdown into taskQueue

Also see rdar://82043918 It feels slightly counter intuitive to check if the EventLoop is shutdown from on the loop but I believe this is fine as the dispatch queue doesn't go away with shutdown. A similar pattern seems to be used elsewhere in this file too.

PeterAdams-A

comment created time in a month

PR opened apple/swift-nio-transport-services

Move check for event loop shutdown into taskQueue

Motivation:

The event loop state is not protected for access on different threads. This means it must only be accessed from the task queue.

Modifications:

Move check for event loop shutdown into taskQueue

Result:

Event Loop state only accessed from the task queue.

+4 -5

0 comment

1 changed file

pr created time in a month

create barnchPeterAdams-A/swift-nio-transport-services

branch : eventlooptsan

created branch time in a month

PullRequestReviewEvent

Pull request review commentswift-server/async-http-client

[RFC] Add async/await proposal

+# Proposal: Async-await support++## Introduction++With the introduction of [async/await][SE-0296] in Swift 5.5, it is now possible to write asynchronous code without the need for callbacks. ++Language support for [`AsyncSequence`][SE-0298] also allows for writing functions that return values over time.++We would like to explore how we could offer APIs that make use of these new language features to allow users to run HTTPRequest using these new idioms.++This proposal describes what these APIs could look like and explores some of the potential usability concerns.++## Proposed API additions++### New `HTTPClientRequest` type++The proposed new `HTTPClientRequest` shall be a simple swift structure.++```swift+struct HTTPClientRequest {+  /// The requests url.+  var url: String+  +  /// The request's HTTPMethod+  var method: HTTPMethod+  +  /// The request's headers+  var headers: HTTPHeaders

Presumably at the point where this is currently created we don't know which HTTP version we'll be using? Would we need to do some sort of delayed creation? I think we need to provide and easy version to use, even if we also have a fast option.

fabianfett

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentswift-server/async-http-client

[RFC] Add async/await proposal

+# Proposal: Async-await support++## Introduction++With the introduction of [async/await][SE-0296] in Swift 5.5, it is now possible to write asynchronous code without the need for callbacks. ++Language support for [`AsyncSequence`][SE-0298] also allows for writing functions that return values over time.++We would like to explore how we could offer APIs that make use of these new language features to allow users to run HTTPRequest using these new idioms.++This proposal describes what these APIs could look like and explores some of the potential usability concerns.++## Proposed API additions++### New `HTTPClientRequest` type++The proposed new `HTTPClientRequest` shall be a simple swift structure.++```swift+struct HTTPClientRequest {+  /// The requests url.+  var url: String+  +  /// The request's HTTPMethod+  var method: HTTPMethod+  +  /// The request's headers+  var headers: HTTPHeaders

In gRPC did you not just move the overhead to HTTP/1? Ie, made HTTP/2 the default and now have to convert when on HTTP/1?

fabianfett

comment created time in a month