PKief ( Philipp Kief )

issue closedPKief/vscode-material-icon-theme

Default icon

Hi,

I'm trying to use default icon to folder clients but it's not working.

How can I use a default icon instead of material icon?

Thanks

closed time in 12 hours

guitexa

issue commentPKief/vscode-material-icon-theme

Default icon

Sorry this is not so well documented but you have to use an empty string here:

"material-icon-theme.folders.associations": {
    "clients": ""
}

guitexa

comment created time in 12 hours

Pull request review commentPKief/vscode-material-icon-theme

Add Minecraft Function Icon.

+<?xml version="1.0" encoding="UTF-8" standalone="no"?><!-- Generator: Gravit.io --><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" style="isolation:isolate" viewBox="0 0 18 18" width="18pt" height="18pt"><defs><clipPath id="_clipPath_ZCf2LQlLcDT1rvUIMPQZ2BwFsyQtxuDq"><rect width="18" height="18"/></clipPath></defs><g clip-path="url(#_clipPath_ZCf2LQlLcDT1rvUIMPQZ2BwFsyQtxuDq)"><rect width="18" height="18" style="fill:rgb(0,0,0)" fill-opacity="0"/><rect x="0" y="0" width="18" height="18" transform="matrix(1,0,0,1,0,0)" fill="rgb(89,184,58)"/><clipPath id="_clipPath_IqV1t47XAPzoKOUWtMSfYUWN0BwegKNN"><rect x="0" y="0" width="18" height="18" transform="matrix(1,0,0,1,0,0)" fill="rgb(89,184,58)"/></clipPath><g clip-path="url(#_clipPath_IqV1t47XAPzoKOUWtMSfYUWN0BwegKNN)"><path d=" M 2.25 4.5 L 2.25 9 L 6.75 9 L 6.75 11.25 L 4.5 11.25 L 4.5 15.75 L 6.75 15.75 L 6.75 13.5 L 11.25 13.5 L 11.25 15.75 L 13.5 15.75 L 13.5 11.25 L 11.25 11.25 L 11.25 9 L 15.75 9 L 15.75 4.5 L 11.25 4.5 L 11.25 9 L 6.75 9 L 6.75 4.5 L 2.25 4.5 Z " fill="rgb(0,0,0)"/></g></g></svg>

Thanks for the changes, will have a final look on it soon :)

llgava

comment created time in 12 hours

PullRequestReviewEvent

Pull request review commentPKief/vscode-material-icon-theme

Add Minecraft Function Icon.

+<?xml version="1.0" encoding="UTF-8" standalone="no"?><!-- Generator: Gravit.io --><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" style="isolation:isolate" viewBox="0 0 18 18" width="18pt" height="18pt"><defs><clipPath id="_clipPath_ZCf2LQlLcDT1rvUIMPQZ2BwFsyQtxuDq"><rect width="18" height="18"/></clipPath></defs><g clip-path="url(#_clipPath_ZCf2LQlLcDT1rvUIMPQZ2BwFsyQtxuDq)"><rect width="18" height="18" style="fill:rgb(0,0,0)" fill-opacity="0"/><rect x="0" y="0" width="18" height="18" transform="matrix(1,0,0,1,0,0)" fill="rgb(89,184,58)"/><clipPath id="_clipPath_IqV1t47XAPzoKOUWtMSfYUWN0BwegKNN"><rect x="0" y="0" width="18" height="18" transform="matrix(1,0,0,1,0,0)" fill="rgb(89,184,58)"/></clipPath><g clip-path="url(#_clipPath_IqV1t47XAPzoKOUWtMSfYUWN0BwegKNN)"><path d=" M 2.25 4.5 L 2.25 9 L 6.75 9 L 6.75 11.25 L 4.5 11.25 L 4.5 15.75 L 6.75 15.75 L 6.75 13.5 L 11.25 13.5 L 11.25 15.75 L 13.5 15.75 L 13.5 11.25 L 11.25 11.25 L 11.25 9 L 15.75 9 L 15.75 4.5 L 11.25 4.5 L 11.25 9 L 6.75 9 L 6.75 4.5 L 2.25 4.5 Z " fill="rgb(0,0,0)"/></g></g></svg>

The idea having an icon for Minecraft Functions is great. I'd prefer having only one icon for that, no alternative icons.

Could you please use this icon as the only icon of this PR: https://materialdesignicons.com/icon/minecraft

and pick a color from the Material Color Palette: https://pkief.github.io/material-color-converter/

Then, it's very likely that this one will be merged ;) Thanks!

llgava

comment created time in a day

PullRequestReviewEvent

issue closedPKief/vscode-material-icon-theme

Icons hierarchy/paths problems

Hello,

Firstly my project is not a workspace. I applied in the user settings and not in the workspace settings.

In my project called suru-plus-folders, there is a symlinked folder sito-hugo which is symlinked to themes/hugo/suru-plus-folders-site. See the tree:

suru-plus-folders
├── site-hugo -> themes/hugo/suru-plus-folders-site
└── themes
     └── hugo
         └── suru-plus-folders-site

I open the subfolder site-hugo or themes/hugo/suru-plus-folders-site directly with code-insiders --extensions-dir='$HOME/.vscode-insiders/workspaces/html+markdowm+hugo'. Result:

If I open the same sub-folder with the regular VSCode without the command --extensions-dir, it is all OK:

But I can not use the normal VSCode because of a lot of extensions. I have to optimise some extensions designed only for Hugo.

Let me give another info:

Although my project is not a workspace, the material-icon-theme* commands work in the .vscode/settings.json, because they are recognised by the own VSCode, but have no effect. I know your extension does not support it as I saw other issues.

closed time in a day

gusbemacbe

issue commentPKief/vscode-material-icon-theme

Icons hierarchy/paths problems

Sorry for the late response, but good to hear that you could solve your issue on your own ;) Will close this issue then.

gusbemacbe

comment created time in a day

issue closedPKief/vscode-material-icon-theme

bug with .github folder

if I create only one subfolder(workflows) and do not create others in the rootfolder(.github), then the rootfolder icon is not displayed

closed time in a day

peach-lasagna

issue commentPKief/vscode-material-icon-theme

bug with .github folder

Hi, this is because VS Code tries to apply an icon for "workflows" which is not (yet) existing in this extension. This is why it simply uses the default icon. If you collapse the directory tree and press the refresh button of your file explorer, you can see that it will show the github folder icon again. Feel free to open an issue at VS Code, if you think that this is not satisfying for you. It cannot be customized right now.

peach-lasagna

comment created time in a day

issue closedPKief/vscode-material-icon-theme

Rescript icon support

This might seem early, but the sooner the better. Since Reason+BS merging into Rescript with a rebranding as well, it would be nice to support ReScript.

The file extension is .res

Here is also a link about their visual rebranding : https://rescript-lang.org/blog/new-rescript-logo And here is the link to assets : https://rescript-lang.org/brand

I will take it asap if that 's fine and submit a PR. :)

closed time in a day

prazdevs

issue commentPKief/vscode-material-icon-theme

Rescript icon support

Fixed by #823, thanks for both the issue and the PR :)

prazdevs

comment created time in a day

pull request commentPKief/vscode-material-icon-theme

Add rescript icon

Sorry, I forgot to add these commits to this PR before merging:

https://github.com/PKief/vscode-material-icon-theme/commit/a4e5520036c4d04740adf415fc8ceb5038a8346a
https://github.com/PKief/vscode-material-icon-theme/commit/8fd0644cc15e371a0c641cdacc5350318527285a

Now, they are directly on master :)

prazdevs

comment created time in a day

push eventPKief/vscode-material-icon-theme

PKief

commit sha a4e5520036c4d04740adf415fc8ceb5038a8346a

Update rescript icon

Original Image