Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.
Apache Camel K
pull request commentwso2/carbon-deployment
Update jackson-databind version
PR builder completed Link: https://github.com/wso2/product-is/actions/runs/952728924 Status: failure
comment created time in 11 hours
pull request commentwso2/carbon-deployment
Update jackson-databind version
PR builder started Link: https://github.com/wso2/product-is/actions/runs/952728924
comment created time in 11 hours
PR opened wso2/carbon-deployment
pr created time in 11 hours
push eventwso2/carbon-kernel
commit sha 43e2171d159a81c8f5e22463a79ecf8909818df1
Move audit message format to carbon constants
commit sha bc7b8c374c266633458e0767ad0c04ff005452b7
Merge pull request #3002 from emswbandara/diag-logs Move audit message format to carbon constants
push time in 2 days
pull request commentwso2/carbon-kernel
PR builder completed Link: https://github.com/wso2/product-is/actions/runs/949553476 Status: failure
comment created time in 2 days
pull request commentwso2/carbon-kernel
PR builder started Link: https://github.com/wso2/product-is/actions/runs/949553476
comment created time in 2 days
Pull request review commentwso2/carbon-kernel
public Object run() throws Exception { } catch (PrivilegedActionException e) { if (e.getCause() != null && e.getCause().getCause() != null && e.getCause().getCause() instanceof UserStoreException) {- if (((UserStoreException) e.getCause().getCause()).getErrorCode() != null) {- throw new UserStoreException(e.getCause().getCause().getMessage(),- ((UserStoreException) e.getCause().getCause()).getErrorCode(), e);+ boolean isClientException = e.getCause().getCause() instanceof UserStoreClientException;+ String errorCode = ((UserStoreException) e.getCause().getCause()).getErrorCode();+ String errorMessage = e.getCause().getCause().getMessage();+ // If the error codes are available send the error codes as well.+ if (StringUtils.isNotBlank(errorCode)) {
Fixed in 9abb9f1bd36da933af860bd929be65ef1d9f23dd
comment created time in 2 days
Pull request review commentwso2/carbon-kernel
public Object run() throws Exception { } catch (PrivilegedActionException e) { if (e.getCause() != null && e.getCause().getCause() != null && e.getCause().getCause() instanceof UserStoreException) {- if (((UserStoreException) e.getCause().getCause()).getErrorCode() != null) {- throw new UserStoreException(e.getCause().getCause().getMessage(),- ((UserStoreException) e.getCause().getCause()).getErrorCode(), e);+ boolean isClientException = e.getCause().getCause() instanceof UserStoreClientException;+ String errorCode = ((UserStoreException) e.getCause().getCause()).getErrorCode();+ String errorMessage = e.getCause().getCause().getMessage();+ // If the error codes are available send the error codes as well.+ if (StringUtils.isNotBlank(errorCode)) {
Arrage as follows for more readability if (isClientException) { if (StringUtils.isNotBlank(errorCode)) { }
} else {
}
comment created time in 2 days
Pull request review commentwso2-enterprise/choreo-connect-global-adapter
+/*+ * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ *+ */++package xds++import (+ "fmt"+ "math/rand"+ "time"++ corev3 "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"+ "github.com/envoyproxy/go-control-plane/pkg/cache/types"+ ga_api "github.com/wso2/product-microgateway/adapter/pkg/discovery/api/wso2/discovery/ga"+ wso2_cache "github.com/wso2/product-microgateway/adapter/pkg/discovery/protocol/cache/v3"+)++var (+ apiCache wso2_cache.SnapshotCache+ apiMap map[string]types.Resource+)++const (+ maxRandomInt int = 999999999+ typeURL string = "type.googleapis.com/wso2.discovery.ga.Api"+)++// IDHash uses ID field as the node hash.+type IDHash struct{}++// ID uses the node ID field+func (IDHash) ID(node *corev3.Node) string {+ if node == nil {+ return "unknown"+ }+ return node.Id+}++var _ wso2_cache.NodeHash = IDHash{}++func init() {+ apiCache = wso2_cache.NewSnapshotCache(false, IDHash{}, nil)+ apiMap = make(map[string]types.Resource)+ rand.Seed(time.Now().UnixNano())+}++// GetAPICache returns API Cache+func GetAPICache() wso2_cache.SnapshotCache {+ return apiCache+}++// AddAPIsToCache adds the provided set of APIUUIDs and updates the XDS cache for the provided label.+func AddAPIsToCache() {+ AddAPI("default", "apiID1", "1234")+ time.Sleep(10 * time.Second)+ AddAPI("default", "apiID2", "1234")+ time.Sleep(5 * time.Second)+ AddAPI("default", "apiID1", "4567")+ time.Sleep(5 * time.Second)+ RemoveAPI("default", "apiID1")+}++// AddAPI adds the API entry to XDS cache+func AddAPI(label, apiUUID, revisionUUID string) {
method signature needs be changed to array.
comment created time in 2 days
Pull request review commentwso2-enterprise/choreo-connect-global-adapter
+/*+ * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ *+ */++package xds++import (+ "fmt"+ "math/rand"+ "time"++ corev3 "github.com/envoyproxy/go-control-plane/envoy/config/core/v3"+ "github.com/envoyproxy/go-control-plane/pkg/cache/types"+ ga_api "github.com/wso2/product-microgateway/adapter/pkg/discovery/api/wso2/discovery/ga"+ wso2_cache "github.com/wso2/product-microgateway/adapter/pkg/discovery/protocol/cache/v3"+)++var (+ apiCache wso2_cache.SnapshotCache+ apiMap map[string]types.Resource+)++const (+ maxRandomInt int = 999999999+ typeURL string = "type.googleapis.com/wso2.discovery.ga.Api"+)++// IDHash uses ID field as the node hash.+type IDHash struct{}++// ID uses the node ID field+func (IDHash) ID(node *corev3.Node) string {+ if node == nil {+ return "unknown"+ }+ return node.Id+}++var _ wso2_cache.NodeHash = IDHash{}++func init() {+ apiCache = wso2_cache.NewSnapshotCache(false, IDHash{}, nil)+ apiMap = make(map[string]types.Resource)
remove
comment created time in 2 days
PR opened wso2/carbon-kernel
Purpose
Throw client exceptions when the original cause is an instance of UserStoreClientException.
pr created time in 2 days
Pull request review commentwso2-enterprise/choreo-connect-global-adapter
+/*+ * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.+ *+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ *+ */++package server++import (+ "context"+ "fmt"+ "net"+ "os"+ "os/signal"++ "github.com/wso2-enterprise/choreo-connect-global-adapter/internal/xds"+ ga_service "github.com/wso2/product-microgateway/adapter/pkg/discovery/api/wso2/discovery/service/ga"+ wso2_server "github.com/wso2/product-microgateway/adapter/pkg/discovery/protocol/server/v3"+ "google.golang.org/grpc"+)++const grpcMaxConcurrentStreams = 1000000
check if there is any resource utilization associated with
comment created time in 2 days
PR opened wso2-enterprise/choreo-connect-global-adapter
Purpose
<!-- Short description of the issue you are going to solve with this PR. -->
Issues
<!-- Link github issues that are going to be solved with this PR. Format should be: Fixes #123 --> Fixes #
Automation tests
- Unit tests added: Yes/No
- Integration tests added: Yes/No
Tested environments
<!-- Specify the environments you used to test this PR. OS, DB, JDK version, etc... --> Not Tested
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr created time in 2 days
Pull request review commentwso2/product-microgateway
Remove redundant log config read operation.
import ( toml "github.com/pelletier/go-toml" logger "github.com/sirupsen/logrus"+ pkg_conf "github.com/wso2/product-microgateway/adapter/pkg/config"
pkgconf
comment created time in 2 days
Pull request review commentwso2/product-microgateway
Remove redundant log config read operation.
func GetMgwHome() string { func ReadLogConfigs() (*LogConfig, error) { onceLogConfigRead.Do(func() { adapterLogConfig = new(LogConfig)- _, err := os.Stat(GetMgwHome() + relativeLogConfigPath)- if err != nil {- logger.Fatal("Log configuration file not found.", err)- panic(err)- }- content, readErr := ioutil.ReadFile(mgwHome + relativeLogConfigPath)+ content, readErr := ioutil.ReadFile(getLogConfigPath()) if readErr != nil { logger.Fatal("Error reading log configurations. ", readErr)- panic(err)+ panic(readErr)
No need to panic
comment created time in 2 days
Pull request review commentwso2/product-microgateway
Remove redundant log config read operation.
func GetMgwHome() string { return mgwHome } +// getLogConfigPath reads the LOG_CONFIG_PATH environmental variable and returns the value.+// If the env variable is not available, returned value would be the combination of MGW_HOME+// env variable value + relative log config path+func getLogConfigPath() string {+ logConfigPath = os.Getenv(logConfigPathEnvVariable)+ if len(strings.TrimSpace(logConfigPath)) == 0 {+ //for backward compatibility+ logConfigPath = GetMgwHome() + relativeLogConfigPath+ }+ _, err := os.Stat(logConfigPath)+ if err != nil {+ logger.Fatal("Log configuration file not found.", err)+ panic(err)
No need to panic if the the log_config.toml is not available And log level should be set to Warn
comment created time in 2 days
issue commentwso2/product-microgateway
We might need to add the fix [1] for internal key implementation.
[1] https://github.com/wso2/product-microgateway/pull/1852/files
comment created time in 2 days
Pull request review commentwso2-enterprise/choreo-connect-global-adapter
+# The logging configuration file for global adapter+######### root Level ########+logfile = "logs/adapter.log"+logLevel = "INFO"++[rotation]+MaxSize = 10 #meabytes
fixed with https://github.com/wso2-enterprise/choreo-connect-global-adapter/pull/3/commits/f26916c5ef99e0b5f9b9ff19f08f600721f4c516
comment created time in 3 days
Pull request review commentwso2-enterprise/choreo-connect-global-adapter
+/*+ * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
fixed with https://github.com/wso2-enterprise/choreo-connect-global-adapter/pull/3/commits/f26916c5ef99e0b5f9b9ff19f08f600721f4c516
comment created time in 3 days
pull request commentwso2-enterprise/choreo-connect-global-adapter
The VirajSalaka fork can be removed from go.mod file once the following PR is merged.
https://github.com/wso2/product-microgateway/pull/2076.
comment created time in 3 days
PR opened wso2-enterprise/choreo-connect-global-adapter
Purpose
This includes the basic structure for logging implementation. Logfile parsing happens within adapter implementation.
Issues
<!-- Link github issues that are going to be solved with this PR. Format should be: Fixes #123 --> Fixes #
Automation tests
- Unit tests added: No
- Integration tests added: No
Tested environments
<!-- Specify the environments you used to test this PR. OS, DB, JDK version, etc... --> Not Tested
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr created time in 3 days
PR closed wso2/product-microgateway
Purpose
$subject
Tested environments
OS name: "linux", arch: "amd64", family: "unix" OpenJDK Runtime Environment (build 11.0.10+9-Ubuntu-0ubuntu1.20.04) 4 cores, 8 threads
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr closed time in 3 days
issue openedballerina-platform/plugin-vscode
Pasting some string within double quotes should escape the pasted string
Description: We as programmers usually expect the IDE to escape the text we paste within double quotes.
Describe your problem(s)
Describe your solution(s)
Related Issues (optional): <!-- Any related issues such as sub tasks, issues reported in other repositories (e.g component repositories), similar problems, etc. -->
Suggested Labels (optional): <!-- Optional comma separated list of suggested labels. Non committers can’t assign labels to issues, so this will help issue creators who are not a committer to suggest possible labels-->
Suggested Assignees (optional): <!--Optional comma separated list of suggested team members who should attend the issue. Non committers can’t assign issues to assignees, so this will help issue creators who are not a committer to suggest possible assignees-->
created time in 4 days
PR closed wso2/product-microgateway
to make the test pass in the build
pr closed time in 4 days
PR closed wso2/product-microgateway
$subject
Tested environments
OS name: "linux", arch: "amd64", family: "unix" OpenJDK Runtime Environment (build 11.0.10+9-Ubuntu-0ubuntu1.20.04) 4 cores, 8 threads
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr closed time in 4 days
PR opened wso2/product-microgateway
Purpose
$subject
Tested environments
<!-- Specify the environments you used to test this PR. OS, DB, JDK version, etc... --> Not Tested
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr created time in 4 days
PR opened wso2/product-microgateway
Purpose
This PR will add duplicating logic written in the global adapter to the common package.
Issues
<!-- Link github issues that are going to be solved with this PR. Format should be: Fixes #123 --> Fixes # https://github.com/wso2/product-microgateway/issues/2040 Related Issues: https://github.com/wso2-enterprise/choreo/issues/4323
Automation tests
- Unit tests added: Yes/No
- Integration tests added: Yes/No
Tested environments
<!-- Specify the environments you used to test this PR. OS, DB, JDK version, etc... --> Not Tested
Maintainers: Check before merge
- [ ] Assigned 'Type' label
- [ ] Assigned the project
- [ ] Validated respective github issues
- [ ] Assigned milestone to the github issue(s)
pr created time in 4 days