Thank you. I understand. I would suggest that the best way to communicate what went wrong is with the return value. Right now it is a bool but if it were an enum you could return the exact reason and the calling code would be able to reason about the reason and take appropriate action. What do you think? Best, Patrick

Please note that the defines I used are not new. They were present and used in all of the .cpp files that I changed. I believe they are already defined and commented out in their relevant .cpp files. Thanks, Patrick

Hi Kurt, I am using your library in a context where Serial isn't defined because of my USB configuration. I am looking forward to your comments. Thanks, Patrick.

Hi Kare

Fastest way to disable it completely is to comment out the line

g_ServoDriver.setGaitConfig();  //sets servo config to MJS version

in the .ino file. But if you do that you are going to loose all the setting for Gyre (clockwise/counterclockwise) and the offsets and the max speed that are working for you.

To be honest I did the same - I got the offsets from LSS Config app and copied them into the leg config table. If you already set them in the LSS config app then you really don't need to set them in the table.

Hope that answers your question.

I have problems typing english as well for what its worth - thank goodness for backspace and delete buttons :)

Btw Mike,

I can't wait for the site to be open again. Is there a way to disable the offsets in code. The section in the driver file, where you are using -104(femur) and -137(tibia). For my robot -190 was more correct for the femur though. but some of my legs are a bit off, but the calibrations I already did using the LSS app should be ok. So is there a way to disable it or am I thinking wrong? I did write much more on the forum. Writing english isn't my fastest skill. lol.

Best regards, Kåre

On Mon, Jun 14, 2021 at 9:53 PM Kåre Halvorsen ***@***.***> wrote:

Thanks to you both!

Like I said in the other mail, forum is under maintenance. I had some Q's for Mike regarding the offsets in code. I hope my post wasn't lost, but I'm afraid so.

On Mon, Jun 14, 2021 at 9:45 PM KurtE ***@***.***> wrote:

Thinks Mike and Zenta – looks like our version of the fixed point old code is somewhat working 😃

Will be interesting to see how many more things to integrate into the USB settings…

Probably start with KISS

Thanks both of you!

From: Mike S ***@***.***> Sent: Monday, June 14, 2021 12:18 PM To: KurtE/LSS_Test_sketches ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [KurtE/LSS_Test_sketches] Some changes in config (#2)

Hi @Zenta https://github.com/Zenta When you close the PR it means it either has been incorporated or no longer needed. When the owner merges it he/she will close to saying it was merged, or if it wasn't merged they should notify you as the author of the PR.

Going to merge it for Kurt.

Oh if you redown the sketch now you should have the 'A' command available

• it toggles using either moveT command or the S/W interpolation that Kurt merged.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/KurtE/LSS_Test_sketches/pull/2#issuecomment-860930387> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAL4MQGZPC5K7IP4A3EQP3LTSZIX3ANCNFSM46VXTRDA> . < https://github.com/notifications/beacon/AAL4MQFHDXQQ43EKEPIW7TTTSZIX3A5CNFSM46VXTRDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNIMCUY.gif>

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KurtE/LSS_Test_sketches/pull/2#issuecomment-860945644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQJV4QGBT6MKDGXGKYBPYLTSZL6LANCNFSM46VXTRDA .

--

---

Kåre Halvorsen, aka Zenta Mob:95041299

Zenta's blog http://www.zentasrobots.com/ Zenta's YouTube channel http://www.youtube.com/ZentaOlbaid

--

Kåre Halvorsen, aka Zenta Mob:95041299

Zenta's blog http://www.zentasrobots.com/ Zenta's YouTube channel http://www.youtube.com/ZentaOlbaid

Thanks to you both!

Like I said in the other mail, forum is under maintenance. I had some Q's for Mike regarding the offsets in code. I hope my post wasn't lost, but I'm afraid so.

On Mon, Jun 14, 2021 at 9:45 PM KurtE ***@***.***> wrote:

Thinks Mike and Zenta – looks like our version of the fixed point old code is somewhat working 😃

Will be interesting to see how many more things to integrate into the USB settings…

Probably start with KISS

Thanks both of you!

From: Mike S ***@***.***> Sent: Monday, June 14, 2021 12:18 PM To: KurtE/LSS_Test_sketches ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [KurtE/LSS_Test_sketches] Some changes in config (#2)

Hi @Zenta https://github.com/Zenta When you close the PR it means it either has been incorporated or no longer needed. When the owner merges it he/she will close to saying it was merged, or if it wasn't merged they should notify you as the author of the PR.

Going to merge it for Kurt.

Oh if you redown the sketch now you should have the 'A' command available

• it toggles using either moveT command or the S/W interpolation that Kurt merged.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/KurtE/LSS_Test_sketches/pull/2#issuecomment-860930387> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAL4MQGZPC5K7IP4A3EQP3LTSZIX3ANCNFSM46VXTRDA> . < https://github.com/notifications/beacon/AAL4MQFHDXQQ43EKEPIW7TTTSZIX3A5CNFSM46VXTRDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGNIMCUY.gif>

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KurtE/LSS_Test_sketches/pull/2#issuecomment-860945644, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQJV4QGBT6MKDGXGKYBPYLTSZL6LANCNFSM46VXTRDA .

--

Kåre Halvorsen, aka Zenta Mob:95041299

Zenta's blog http://www.zentasrobots.com/ Zenta's YouTube channel http://www.youtube.com/ZentaOlbaid

Hi @Zenta When you close the PR it means it either has been incorporated or no longer needed. When the owner merges it he/she will close to saying it was merged, or if it wasn't merged they should notify you as the author of the PR.

Going to merge it for Kurt.

Oh if you redown the sketch now you should have the 'A' command available - it toggles using either moveT command or the S/W interpolation that Kurt merged.

Just some minor Zenta stuff. And trying to learn Github. Not sure if I'm doing it correctly though. Trying to Create a pull request.

Or reopen? When I'm closing is that the same to say I'm done for now? Or is this for conversation so others(master) can check?

Just some minor Zenta stuff. And trying to learn Github. Not sure if I'm doing it correctly though. Trying to Create a pull request.

What to do next. Should I choose Close with comment?

Just some minor Zenta stuff. And trying to learn Github. Not sure if I'm doing it correctly though. Trying to Create a pull request.