My NixOS configuration
Hinidu/nixos-solarized-slim-theme 1
Solarized dark theme for SLiM with NixOS logo
vim plugin for ACM-like competitions
Haskell implementation of famous arkanoid game.
Automation
task management & automation tool
Reactive collections based on Rx.Net
Elixir is a dynamic, functional language designed for building scalable and maintainable applications
SSL Certificates for Erlang
pull request commentNixOS/nixpkgs
Rebooted onto 5.12.12-hardened, network seems fine on my setup with both onboard ethernet and wifi (802.11ac 5GHz) both with or without VPN (private resources)
Pings, tracepath and bandwidth as expected.
comment created time in a few seconds
pull request commentNixOS/nixpkgs
Hi @TredwellGit, about to reboot into the new version. I normally use ethernet but would want to try to replicate the issue you encountered. Could you describe a bit about how you are connected to networking? (Ethernet, WiFi onboard, card or dongle, use or not use VPN, etc)
comment created time in 7 minutes
Pull request review commentNixOS/nixpkgs
doc/python: explain bulk package set updates
The following rules are desired to be respected: If necessary, `pname` has to be given a different value within `fetchPypi`. * Attribute names in `python-packages.nix` should be sorted alphanumerically to avoid merge conflicts and ease locating attributes.++## Package set maintenance++The whole python package set has alot of packages that does not see regular+updates, because they either are a very fragile component in the python+ecosystem, like for example the `hypothesis` package, or packages that have+no maintainer, so maintenance falls back to the package set maintainers.++### Updating packages in bulk++There is a tool to update alot of python libraries in bulk, it exists at+`./maintainers/scripts/update-python-libraries` with this repository.++It can quickly update minor or major versions for all packages selected+and create update commits, and supports the `fetchPypi`, `fetchUrl` and+`fetchFromGitHub` fetchers.
`fetchFromGitHub` fetchers. When updating lots of packages that are hosted on GitHub, exporting a `GITHUB_API_TOKEN` is recommended.
comment created time in 8 minutes
pull request commentNixOS/nixpkgs
Likely related to changed errno codes: https://cdn.kernel.org/pub/linux/kernel/v5.x/ChangeLog-5.12.12
comment created time in 11 minutes
PR opened NixOS/nixpkgs
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libaec/versions.
meta.description for libaec is: "Adaptive Entropy Coding library"
meta.homepage for libaec is: "https://gitlab.dkrz.de/k202009/libaec"
meta.changelog for libaec is: ""
Updates performed
- Version update
To inspect upstream changes
Impact
<details> <summary> <b>Checks done</b> (click to expand) </summary>
-
built on NixOS
-
The tests defined in
passthru.tests, if any, passed -
/nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5/bin/aec passed the binary check.
-
1 of 1 passed binary check by having a zero exit code.
-
0 of 1 passed binary check by having the new version present in output.
-
found 1.0.5 with grep in /nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5
-
found 1.0.5 in filename of file in /nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5
-
directory tree listing: https://gist.github.com/72e25d79690b9da663c1c2f348859509
-
du listing: https://gist.github.com/bec39f0fd7485796b75829b6d627d5f3
</details> <details> <summary> <b>Rebuild report</b> (if merged into master) (click to expand) </summary>
77 total rebuild path(s)
26 package rebuild(s)
26 x86_64-linux rebuild(s)
19 i686-linux rebuild(s)
11 x86_64-darwin rebuild(s)
21 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
bareos
bosh-cli
ceph
ceph-client
ceph-dev
connman
connman-gtk
connman-ncurses
connmanFull
connmanMinimal
connman_dmenu
gitea
home-assistant
libaec
libceph
nixos-install-tools
python38Packages.WSME
python38Packages.pecan
python38Packages.pytest-subprocess
python39Packages.pecan
python39Packages.pytest-subprocess
qemu_full
samba4Full
sambaFull
terra
tests.nixos-functions.nixos-test
</details>
<details> <summary> <b>Instructions to test this update</b> (click to expand) </summary>
Either download from Cachix:
nix-store -r /nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5 \
--option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
--option trusted-public-keys '
nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
'
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libaec https://github.com/r-ryantm/nixpkgs/archive/a74a2029f499e0b641e4866e755cd8c140ea8338.tar.gz
After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5
ls -la /nix/store/3rdyvgalakvygbp1rs20fax39njqbzar-libaec-1.0.5/bin
</details> <br/>
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages. Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1
<details>
<summary>1 package built:</summary>
<ul>
<li>libaec</li>
</ul>
</details>
Maintainer pings
cc @tbenst for testing.
pr created time in 12 minutes
PR opened fish-shell/fish-shell
This removes all of the universal variables from fish's initialization scripts. With this change, fish will not even create its fish_variables file until the user sets a universal variable. See #7317.
Variables which used to be universal (the color variables like fish_color_cwd) are now global, instead of universal. As before, they are only set if not already set.
There are two risks here:
- We no longer migrate the pre-3.0 abbreviation format. It seems like an OK time to stop doing that.
- Because color variables are now global instead of universal, a command like
set -U fish_color_normal purplewon't appear to work until the user spawns a new shell. This is because global scope trumps universal scope. I think we should fix that by just removing universal variables, but I am saving that for a next pull request.
I think the second risk is serious enough that I will not merge this until we have a solution. My proposal is to remove universal variables, and I'm pretty far along on that, but I think this change can be reviewed separately.
pr created time in 13 minutes
pull request commentNixOS/nixpkgs
5.12.12 breaks networking for me.
comment created time in 15 minutes
pull request commentNixOS/nixpkgs
WIP: Sign systemd boot EFI images for secure booting.
Maybe open a new PR and ask for reviews again.
comment created time in 16 minutes
pull request commentneovim/neovim
@janlazo should be OK to merge 👍
comment created time in 19 minutes
push eventNixOS/nixpkgs
commit sha 23c453f4254f222026ef551eb5c4ac27e7c4efa0
python3Packages.testpath: enable tests
push time in an hour
push eventNixOS/nixpkgs
commit sha a37b662ba1ff8546d6e0c9b7b35947263f86ea95
flow: 0.152.0 -> 0.153.0
commit sha f96d3cae5c1f6a42870b34d3af0f92b49cb1b502
Merge pull request #127294 from r-ryantm/auto-update/flow flow: 0.152.0 -> 0.153.0
push time in an hour
PR merged NixOS/nixpkgs
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/facebook/flow/releases.
meta.description for flow is: "A static type checker for JavaScript"
meta.homepage for flow is: "https://flow.org/"
meta.changelog for flow is: "https://github.com/facebook/flow/raw/v0.153.0/Changelog.md"
Updates performed
- Version update
To inspect upstream changes
Impact
<details> <summary> <b>Checks done</b> (click to expand) </summary>
-
built on NixOS
-
The tests defined in
passthru.tests, if any, passed -
/nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0/bin/flow passed the binary check.
-
1 of 1 passed binary check by having a zero exit code.
-
1 of 1 passed binary check by having the new version present in output.
-
found 0.153.0 with grep in /nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0
-
found 0.153.0 in filename of file in /nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0
-
directory tree listing: https://gist.github.com/d3f8fdb53f2cf5396f68cbb86c4ea386
-
du listing: https://gist.github.com/a05d53e651230b90e768287e7a70f7a4
</details> <details> <summary> <b>Rebuild report</b> (if merged into master) (click to expand) </summary>
4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
flow
</details>
<details> <summary> <b>Instructions to test this update</b> (click to expand) </summary>
Either download from Cachix:
nix-store -r /nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0 \
--option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
--option trusted-public-keys '
nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
'
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flow https://github.com/r-ryantm/nixpkgs/archive/a37b662ba1ff8546d6e0c9b7b35947263f86ea95.tar.gz
After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0
ls -la /nix/store/j7knb0xsnjkbp2f4hbf732jinkrrnqyk-flow-0.153.0/bin
</details> <br/>
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages. Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1
<details>
<summary>1 package built:</summary>
<ul>
<li>flow</li>
</ul>
</details>
Maintainer pings
cc @marsam @puffnfresh for testing.
pr closed time in an hour
push eventNixOS/nixpkgs
commit sha 5420c28e6763ca915a0899ef6e2496a0dec0f918
go-toml: 1.9.2 -> 1.9.3
commit sha ea135fa8ed89530e6312b7d2b9c2ad8c08652012
Merge pull request #127307 from r-ryantm/auto-update/go-toml go-toml: 1.9.2 -> 1.9.3
push time in an hour
PR merged NixOS/nixpkgs
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/pelletier/go-toml/releases.
meta.description for go-toml is: "Go library for the TOML language"
meta.homepage for go-toml is: "https://github.com/pelletier/go-toml"
meta.changelog for go-toml is: ""
Updates performed
- Version update
To inspect upstream changes
Impact
<details> <summary> <b>Checks done</b> (click to expand) </summary>
-
built on NixOS
-
The tests defined in
passthru.tests, if any, passed -
/nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3/bin/tomljson passed the binary check.
-
/nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3/bin/tomll passed the binary check.
-
/nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3/bin/jsontoml passed the binary check.
-
3 of 3 passed binary check by having a zero exit code.
-
0 of 3 passed binary check by having the new version present in output.
-
found 1.9.3 with grep in /nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3
-
found 1.9.3 in filename of file in /nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3
-
directory tree listing: https://gist.github.com/6235e951ec7182ba2bfa5711d4eed617
-
du listing: https://gist.github.com/53f57e31f75eaacf938397c783ecd1ee
</details> <details> <summary> <b>Rebuild report</b> (if merged into master) (click to expand) </summary>
4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
go-toml
</details>
<details> <summary> <b>Instructions to test this update</b> (click to expand) </summary>
Either download from Cachix:
nix-store -r /nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3 \
--option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
--option trusted-public-keys '
nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
'
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A go-toml https://github.com/r-ryantm/nixpkgs/archive/5420c28e6763ca915a0899ef6e2496a0dec0f918.tar.gz
After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3
ls -la /nix/store/1sicgrh9gah3mlrj309jx75ynqfaf5ld-go-toml-1.9.3/bin
</details> <br/>
Pre-merge build results
We have automatically built all packages that will get rebuilt due to this change.
This gives evidence on whether the upgrade will break dependent packages. Note sometimes packages show up as failed to build independent of the change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1
<details>
<summary>1 package built:</summary>
<ul>
<li>go-toml</li>
</ul>
</details>
Maintainer pings
cc @marsam for testing.
pr closed time in an hour
push eventNixOS/nixpkgs
commit sha 0cf8408d185b76c34b154a2573602ec173f5004a
python3Packages.fetchPypi: support wheels where dist & python differ This introduces the `dist` argument to the `computeWheelUrl`, that allows the distribution format in the path to differ from the python version. A wheel can be py3 and still have their file below the py2.py3 dist url.
push time in an hour
PR opened NixOS/nixpkgs
<!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions -->
Motivation for this change
Things done
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
- [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux) - Built on platform(s)
- [x] NixOS
- [X] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
- [ ] Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip" - [X] Tested execution of all binary files (usually in
./result/bin/) - 21.11 Release Notes
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [X] Fits CONTRIBUTING.md.
pr created time in an hour
pull request commentneovim/neovim
PVS/V547: Expression 'eap->line2 < 0' is always false.
Vim has the same error so this can be upstreamed.
comment created time in an hour
push eventNixOS/nixpkgs
commit sha 6cf3ec0947b7b750c510db779ade0f7a57a832c4
terra: 1.0.0pre1175_ef6a75f -> 1.0.0-beta3 Contains the combined single-commit work by both @jnetod and myself from NixOS/nixpkgs#122665. Brings the build up to LLVM 10, switches to `symlinkJoin` for putting Clang where the CMake build expects it, and updates to a fresh update of Terra that works around a few LLVM bugs.
commit sha da04b1f00fb1a112c65187271c5ff91bfe58f5ae
terra: update to use LLVM's split derivations A patch has been added to inject environment variables into the CMake test runner, the `INCLUDE_PATH` variable has been specified, and the merged LLVM derivation has been updated to refer to the split outputs.
commit sha 59a07bc60f51980fd9a407cd0580fdc6d2706ec8
terra: add seylerius as a maintainer
commit sha 0a44bbbb3dcffe68ef71c5d73d5b455970cc5b1e
terra: add toggle argument for CUDA support Terra can be built with CUDA support, and this commit adds a toggle to the arguments, `enableCUDA`, for enabling it.
commit sha c4e14f4818596fbfd321506160b8ca97cb6f12b9
Merge branch 'master' of github.com:nixos/nixpkgs into terra
commit sha 999e5d9cdf99eaa54130da8154bd9dc43922988f
terra: add override for `CLANG_RESOURCE_DIR`
commit sha 709dd2dc6406a089ead5dfcd068bf85a80f9bbfc
terra: delete now-unnecessary patches
commit sha 36659d1efa4f745787026b5892f3f045293573ff
nixos/home-assistant: update hardening This makes access to serial devices contingent on using certain components and restricts the default setup even further.
commit sha dd1b9306467d6ad3cfaabfb0d8d5a79c8c76404b
bosh-cli: 6.4.3 -> 6.4.4
commit sha da575846cb1bf27e692c95888c8895362b0c01ef
terra: update to support new override
commit sha c49d9adc385ccff57ef020456f3700fe6878619d
terra: fix LuaJIT fetch per @jnetod in #125896
commit sha 316d7e2da452d6f2456d6e7c32507570147cc70f
guile-json: init at 4.4.1
commit sha 215c16d88e620b997c482b05d610fe0f4e3371e3
python3Packages.enocean: init at 0.60.1
commit sha d7398d2c38c3d192f57f09a38cf1c8d65523758f
home-assistant: update component-packages.nix
commit sha afbade0186aece50b961f41d41f026af0b6f4f49
home-assistant: test enocean component
commit sha 5f5380a3755c882c16480fe4f43cdb8ba2a73922
python3Packages.pytest-subprocess: 1.1.0 -> 1.1.1 https://github.com/aklajnert/pytest-subprocess/blob/1.1.1/HISTORY.rst
commit sha a038f775183f1c0e82928c0271d17ee9684ee99f
python3Packages.pecan: apply the patch for SQLAlchemy 1.4.x
commit sha d5edee8113b7b0567492568e1c0552b4c7d22771
gitea: 1.14.2 -> 1.14.3 ChangeLog: https://github.com/go-gitea/gitea/releases/tag/v1.14.3
commit sha af664bf942b8bd0d6c00e1b025d4d704711fb0cd
Merge pull request #127127 from mweinelt/home-assistant nixos/home-assistant: update hardening
commit sha 75f70a36ca67841d8482bcced042af8d1eb6946e
Merge pull request #125896 from Fundament-Software/terra
push time in an hour
push eventNixOS/nixpkgs
commit sha 6cf3ec0947b7b750c510db779ade0f7a57a832c4
terra: 1.0.0pre1175_ef6a75f -> 1.0.0-beta3 Contains the combined single-commit work by both @jnetod and myself from NixOS/nixpkgs#122665. Brings the build up to LLVM 10, switches to `symlinkJoin` for putting Clang where the CMake build expects it, and updates to a fresh update of Terra that works around a few LLVM bugs.
commit sha da04b1f00fb1a112c65187271c5ff91bfe58f5ae
terra: update to use LLVM's split derivations A patch has been added to inject environment variables into the CMake test runner, the `INCLUDE_PATH` variable has been specified, and the merged LLVM derivation has been updated to refer to the split outputs.
commit sha 59a07bc60f51980fd9a407cd0580fdc6d2706ec8
terra: add seylerius as a maintainer
commit sha 0a44bbbb3dcffe68ef71c5d73d5b455970cc5b1e
terra: add toggle argument for CUDA support Terra can be built with CUDA support, and this commit adds a toggle to the arguments, `enableCUDA`, for enabling it.
commit sha c4e14f4818596fbfd321506160b8ca97cb6f12b9
Merge branch 'master' of github.com:nixos/nixpkgs into terra
commit sha 999e5d9cdf99eaa54130da8154bd9dc43922988f
terra: add override for `CLANG_RESOURCE_DIR`
commit sha 709dd2dc6406a089ead5dfcd068bf85a80f9bbfc
terra: delete now-unnecessary patches
commit sha 36659d1efa4f745787026b5892f3f045293573ff
nixos/home-assistant: update hardening This makes access to serial devices contingent on using certain components and restricts the default setup even further.
commit sha dd1b9306467d6ad3cfaabfb0d8d5a79c8c76404b
bosh-cli: 6.4.3 -> 6.4.4
commit sha da575846cb1bf27e692c95888c8895362b0c01ef
terra: update to support new override
commit sha c49d9adc385ccff57ef020456f3700fe6878619d
terra: fix LuaJIT fetch per @jnetod in #125896
commit sha 316d7e2da452d6f2456d6e7c32507570147cc70f
guile-json: init at 4.4.1
commit sha 215c16d88e620b997c482b05d610fe0f4e3371e3
python3Packages.enocean: init at 0.60.1
commit sha d7398d2c38c3d192f57f09a38cf1c8d65523758f
home-assistant: update component-packages.nix
commit sha afbade0186aece50b961f41d41f026af0b6f4f49
home-assistant: test enocean component
commit sha 5f5380a3755c882c16480fe4f43cdb8ba2a73922
python3Packages.pytest-subprocess: 1.1.0 -> 1.1.1 https://github.com/aklajnert/pytest-subprocess/blob/1.1.1/HISTORY.rst
commit sha a038f775183f1c0e82928c0271d17ee9684ee99f
python3Packages.pecan: apply the patch for SQLAlchemy 1.4.x
commit sha d5edee8113b7b0567492568e1c0552b4c7d22771
gitea: 1.14.2 -> 1.14.3 ChangeLog: https://github.com/go-gitea/gitea/releases/tag/v1.14.3
commit sha af664bf942b8bd0d6c00e1b025d4d704711fb0cd
Merge pull request #127127 from mweinelt/home-assistant nixos/home-assistant: update hardening
commit sha 75f70a36ca67841d8482bcced042af8d1eb6946e
Merge pull request #125896 from Fundament-Software/terra
push time in an hour
PR opened NixOS/nixpkgs
<!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions -->
Motivation for this change
Things done
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
- [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux) - Built on platform(s)
- [x] NixOS
- [x] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
- [ ] Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip" - [x] Tested execution of all binary files (usually in
./result/bin/) - 21.11 Release Notes
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits CONTRIBUTING.md.
pr created time in an hour
Pull request review commentneovim/neovim
PVS/V547: Expression 'eap->line2 < 0' is always false.
static char_u *invalid_range(exarg_T *eap) } break; case ADDR_UNSIGNED:- if (eap->line2 < 0) {
Ranges can be negative. ADDR_UNSIGNED prevents negative range for quickfix commands. Patch v8.1.1261, 35dc6d6e.
comment created time in an hour
Pull request review commentneovim/neovim
PVS/V547: Expression 'eap->line2 < 0' is always false.
static char_u *invalid_range(exarg_T *eap) } break; case ADDR_UNSIGNED:- if (eap->line2 < 0) {- return (char_u *)_(e_invrange);- } break;
Delete this line if you're doing this. ADDR_NONE and ADDR_UNSIGNED cases are grouped in other switch/case code.
comment created time in an hour
pull request commentNixOS/nixpkgs
Built fd on x86_64-darwin.
comment created time in an hour
PR opened NixOS/nixpkgs
<!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions -->
Motivation for this change
https://github.com/lesovsky/pgcenter/releases/tag/v0.9.0
Things done
<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->
- [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux) - Built on platform(s)
- [x] NixOS
- [x] macOS
- [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
- [ ] Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip" - [x] Tested execution of all binary files (usually in
./result/bin/) - 21.11 Release Notes
- [ ] (Package updates) Added a release notes entry if the change is major or breaking
- [ ] (Module updates) Added a release notes entry if the change is significant
- [ ] (Module addition) Added a release notes entry if adding a new NixOS module
- [x] Fits CONTRIBUTING.md.
pr created time in an hour
push eventNixOS/nixpkgs
commit sha 11f575d96e219218378343648aa61836ffa4142b
python3Packages.cligj: 0.5.0 -> 0.7.2
push time in an hour
push eventNixOS/nixpkgs
commit sha 9cefea43cb324913c2a197def89ebf4b068ada04
python3Packages.astroid: fix build and tests
push time in an hour
push eventNixOS/nixpkgs
commit sha ed0b2c21dc921283888d0a3f6f9de16278c632ab
python3Packages.testpath: fix source
push time in an hour