I've renamed the file (doesn't really make a difference), as you can see the top-most check is what all future PR's will have, the check will fail if a PR introduces a bug or breaks the build.

This is an extra check on top of the existing OSS-Fuzz integration, this lets you know not to merge commits that would fail with OSS-Fuzz ahead of time.

Hi, I installed and used macOs with succes on a Linux machine. I changed the resolution of the Mac image and everything works well until I turn off my computer. Indeed, since I restarted my computer, when I launch macOs from Clover, with "Boot macOS from macOS", macOs is launched but in a small size of my screen like in the attached picture.

Do you have an idea about the problem, and idealy a solution? Thanks

Hi, I installed and used macOs with succes on a Linux machine. I changed the resolution of the Mac image and everything works well until I turn off my computer. Indeed, since I restarted my computer, when I launch macOs from Clover, with "Boot macOS from macOS", macOs is launched but in a small size of my screen like in the attached picture.

Do you have an idea about the problem, and idealy a solution? Thanks

I saw this, but didnt try yet: https://github.com/joeknock90/Single-GPU-Passthrough

Hi @jakub-zwolakowski , thank you for intruducing this is an amazing tool, and it certainly make sense. However, I have no permission to configure this tool. I have configured the github actions CI for it, and cJSON has also been integrated in oss fuzz, do you think these can replace trust CI?

I'm running macOS catalina which works fine without GPU passtrhough.

I bought an Rx 560 Saphire 2 Gb Gddr5 and tried to PCI passthrough to my macOS VM, both using basic.sh and virt-manager.

On both, I get the GPU to display the clover, and when I choose the macOS installation, I see all the kernel output, but when the kernel stops and the login screen should appear, I get a black screen and then HDMI goes out of signal.

Also tried to choose the installation live image and get the same results.

When I start the host computer, the AMD VGA and Audio are both in use by vfio-pci, so it looks like I did everything right.

Here's by basic.sh:

#!/bin/bash
 
OSK="ourhardworkbythesewordsguardedpleasedontsteal(c)AppleComputerInc"
VMDIR=$PWD
OVMF=$VMDIR/firmware
#export QEMU_AUDIO_DRV=pa
#QEMU_AUDIO_DRV=pa
 
qemu-system-x86_64 \
    -enable-kvm \
    -m 2G \
    -machine q35,accel=kvm \
    -smp 4,cores=2 \
    -cpu Penryn,vendor=GenuineIntel,kvm=on,+sse3,+sse4.2,+aes,+xsave,+avx,+xsaveopt,+xsavec,+xgetbv1,+avx2,+bmi2,+smep,+bmi1,+fma,+movbe,+invtsc \
    -device isa-applesmc,osk="$OSK" \
    -smbios type=2 \
    -drive if=pflash,format=raw,readonly,file="$OVMF/OVMF_CODE.fd" \
    -drive if=pflash,format=raw,file="$OVMF/macOS_unsafe_coding_VARS.fd" \
    -device ich9-intel-hda -device hda-output \
    -usb -device usb-kbd -device usb-mouse \
    -netdev user,id=net0 \
    -device e1000-82545em,netdev=net0,id=net0,mac=52:54:00:c9:18:27 \
    -device ich9-ahci,id=sata \
    -drive id=ESP,if=none,format=qcow2,file=ESP.qcow2 \
    -device ide-hd,bus=sata.2,drive=ESP \
    -drive id=InstallMedia,format=raw,if=none,file=BaseSystem.img \
    -device ide-hd,bus=sata.3,drive=InstallMedia \
    -drive id=SystemDisk,if=none,file=MyDisk.qcow2 \
    -device ide-hd,bus=sata.4,drive=SystemDisk \
    -vga none \
    -device pcie-root-port,bus=pcie.0,multifunction=on,port=1,chassis=1,id=port.1 \
    -device vfio-pci,host=06:00.0,bus=port.1,multifunction=on \
    -device vfio-pci,host=06:00.1,bus=port.1 \
    -device vfio-pci,host=02:00.0,bus=port.1 \

02:00.0 is an USB controller, and 06:00.0 is the GPU VGa and 06:00.1 is the audio. I tried launching without audio but I get the same results.

Here's what I get when I run basic.sh:

lz@lz:~/macOS-Simple-KVM$ sudo ./basic.sh 
[sudo] password for lz: 
ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave
alsa: Could not initialize DAC
alsa: Failed to open `default':
alsa: Reason: No such file or directory
ALSA lib pcm_dmix.c:1090:(snd_pcm_dmix_open) unable to open slave
alsa: Could not initialize DAC
alsa: Failed to open `default':
alsa: Reason: No such file or directory
audio: Failed to create voice `dac'
 

Qemu window starts even though I get this error. I then switch to the HDMI of the GPU and see clover and kernel output then black screen.

Anyone knows what I could try?

Normally all GPU passtrhoughs are to be used by connecting the HDMI directly to the GPU

Is that possible? If so, I would want to do this too. My PC is too old for IOMMU.

What to add to change the video ram in basic.sh, i'm not trying to passthrough a GPU btw. If you could write it as well that would be helpful.

I'm looking for the same thing my guy, have you had any success?

Fill me in

What to add to change the video ram, i'm not trying to passthrough a GPU btw. If you could write it as well that would be helpful.

I'm using Manjaro it gives good graphical performance i couldn't do the gpu passthrough I gave up on the gpu passthrough

I assumed you mean the wildcards in the tab-reload function. You are right. I guess I was a little carried away with the match pattern (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns).

It makes sense that it should only reload the target pages that we are adjusting the user agent for.

Is it possible the subtraction of the two strings "return tolower(*string1) - tolower(*string2);" to cause buffer overflow?

static int case_insensitive_strcmp(const unsigned char *string1, const unsigned char *string2)
{
    if ((string1 == NULL) || (string2 == NULL))
    {
        return 1;
    }

    if (string1 == string2)
    {
        return 0;
    }

    for(; tolower(*string1) == tolower(*string2); (void)string1++, string2++)
    {
        if (*string1 == '\0')
        {
            return 0;
        }
    }

    return tolower(*string1) - tolower(*string2);
}

it won't.

• if string1 is longer than string2, i.g. , char* string1 = "helloworld", char* string2 = "hello", then the for loop will break when string1 point to w and string2 point to \0, and res = 'w' - '\0'
• if string1 is shorter than string2, i.g. , char* string1 = "hello", char* string2 = "helloworld", then the for loop will break when string1 point to \0 and string2 point to w, and res = '\0' - 'w'

Also inside the for loop, should we also check for string2?

for(; tolower(*string1) == tolower(*string2); (void)string1++, string2++)
    {
        if (*string1 == '\0')
        {
            return 0;
        }

        if (*string2 == '\0')
        {
            return 0;
        }   
    }

no need to check both strings, tolower(*string1) == tolower(*string2) has ensured that the two characters are equal, namely if *string1 equals '\0', *string2 absolutely equals '\0'

Is it possible to connect the monitor to the GPU I will passthrough? Or it should be connected to the one which is running Linux?

Sorry for my late reply, i was a bit busy. I reviewed your pull request, it looks ok so far, but i would like to eliminate the wildcards.

Having an error on Ubuntu 20.10

./basic.sh
qemu-system-x86_64: ,bus=sata.2,drive=ESP: Could not open ',bus=sata.2,drive=ESP': No such file or directory

Basic.sh:

#!/bin/bash

OSK="ourhardworkbythesewordsguardedpleasedontsteal(c)AppleComputerInc"
VMDIR=$PWD
OVMF=$VMDIR/firmware
#export QEMU_AUDIO_DRV=pa
#QEMU_AUDIO_DRV=pa

qemu-system-x86_64 \
    -enable-kvm \
    -m 16G \
    -machine q35,accel=kvm \
    -smp cpus=12,cores=12,threads=1,sockets=1 \
    -cpu Penryn,vendor=GenuineIntel,kvm=on,+sse3,+sse4.2,+aes,+xsave,+avx,+xsaveopt,+xsavec,+xgetbv1,+avx2,+bmi2,+smep,+bmi1,+fma,+movbe,+invtsc \
    -device isa-applesmc,osk="$OSK" \
    -smbios type=2 \
    -drive if=pflash,format=raw,readonly,file="$OVMF/OVMF_CODE.fd" \
    -drive if=pflash,format=raw,file="$OVMF/OVMF_VARS-1024x768.fd" \
    -vga qxl \
    -device ich9-intel-hda -device hda-output \
    -usb -device usb-kbd -device usb-mouse \
    -netdev user,id=net0 \
    -device e1000-82545em,netdev=net0,id=net0,mac=53:de:c1:5a:29:f1 \
    -device ich9-ahci,id=sata \
    -drive id=ESP,if=none,format=qcow2,file=ESP.qcow2 \
    -device ide-hd ,bus=sata.2,drive=ESP \
    -drive id=InstallMedia,format=raw,if=none,file=BaseSystem.img \
    -device ide-hd,bus=sata.3,drive=InstallMedia \
    -drive id=SystemDisk,if=none,file=/home/eugenebos/macOS/MyDisk.qcow2 \
    -device ide-hd,bus=sata.4,drive=SystemDisk \

Actually everything went wrong with the guide

sudo apt-get install qemu python python-pip git
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Note, selecting 'python-is-python2' instead of 'python'
Package python-pip is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  python3-pip

E: Package 'python-pip' has no installation candidate

So I changed it to python3-pip, then:

pip install click request
Requirement already satisfied: click in /usr/lib/python3/dist-packages (7.1.2)
ERROR: Could not find a version that satisfies the requirement request (from versions: none)
ERROR: No matching distribution found for request

So I did: sudo apt-get install qemu

Then `` qemu-img create -f qcow2 MyDisk.qcow2 99G Command 'qemu-img' not found, but can be installed with: sudo apt install qemu-utils

So I did
`sudo apt install qemu-utils`

Then

./basic.sh ./basic.sh: line 10: qemu-system-x86_64: command not found

So I did
sudo apt install qemu-system-x86

Yes it is possible, I just added the full path to the album, everything is going well so far! qemu-img create -f qcow2 /run/media/droid/DataGlobal/macox/Disco-osX.qcow2 70G

Formatting '/run/media/droid/DataGlobal/macox/Disco-osX.qcow2', fmt=qcow2 size=75161927680 cluster_size=65536 lazy_refcounts=off refcount_bits=16 [android macox]# ls -lhat total 208K -rw-r--r-- 1 root root 194K ago 6 06:50 Disco-osX.qcow2 drwxr-xr-x 3 root root 4,0K ago 6 06:50 . drwxr-xr-x 7 root root 4,0K ago 6 06:48 macOS-Simple-KVM drwxr-xr-x 9 root root 4,0K ago 6 05:18 ..

how to add the full path to the album, where is the album? Thanks