BryanDonovan ( Bryan Donovan )

I left get to simply retrieve from cache and not do any implicit updates. I could see the case to have it do an update as well, but that's really what wrap is for.

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

No uniform way of defining an inifinite ttl

Yeah, it should get set in the local cache for B. This test demonstrates that: https://github.com/BryanDonovan/node-cache-manager/blob/master/test/multi_caching.unit.js#L1693

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

No uniform way of defining an inifinite ttl

Hmm... actually, are you sure using 0 for ttl is not working? This example seems to work for me:

const cacheManager = require('cache-manager');
const memoryCache = cacheManager.caching({store: 'memory', max: 100, ttl: 0});

function getUser(id, cb) {
    setTimeout(() => {
        console.log("Fetching user from slow database.");
        cb(null, {id: id, name: 'Bob'});
    }, 100);
}

const userId = 123;

function getCachedUser(id, cb) {
    memoryCache.wrap(id, cacheCallback => {
        getUser(id, cacheCallback);
    }, cb);
}

getCachedUser(userId, (err, user) => {
    // First time fetches the user from the (fake) database:
    console.log('Fetched user:', user);

    setTimeout(() => {
        getCachedUser(userId, (err, user) => {
            // Second time fetches from cache.
            console.log('Fetched user:', user);
            process.exit();
        });
    }, 1010);
});

The output is:

Fetching user from slow database.
Fetched user: { id: 123, name: 'Bob' }
Fetched user: { id: 123, name: 'Bob' }

(which shows that it's only fetching from the "database" once).

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

No uniform way of defining an inifinite ttl

How would noTtl work with lru-cache?

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

No uniform way of defining an inifinite ttl

The problem is that I can't arbitrarily decide that a ttl of zero means infinite for all stores. All we can do is pass it to the underlying store. I didn't want to define the behavior of passing zero to lru-cache because they could change how it works and then cache-manager's docs would be wrong. Still, I could clarify the docs.. I'll do that when I have a bit of spare time.

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

No uniform way of defining an inifinite ttl

Sorry, I can't do anything about how the underlying stores work..

jbeaudoin11

comment created time in a month

issue commentBryanDonovan/node-cache-manager

How to disable cache in development?

Oh, cool. I think someone else bumped it for a security reason. Glad it's faster too..

fookit

comment created time in a month

issue commentBryanDonovan/node-cache-manager

How to disable cache in development?

Sorry for the delayed response. Yeah, what @curtdept said. You basically have to manually turn cache on or off. Also, a ttl of 0 results in there being no ttl at all.

fookit

comment created time in a month

created tagBryanDonovan/node-cache-manager

tag3.4.0

Cache module for Node.JS

created time in 2 months

pull request commentBryanDonovan/node-cache-manager

Update dependencies

This is in version 3.4.0

orgads