profile
viewpoint

jina-ai/jinabox.js 174

A lightweight, customizable omnibox in Javascript, use it with a Jina backend.

pull request commentjina-ai/jina

test: refactor index remote

No comments from my side as I am not familiar with remote functionality

bwanglzu

comment created time in 22 minutes

issue commentjina-ai/jina

get remote pod documentation updated

Good move! This part of the documentation is really out-of-date.

bwanglzu

comment created time in an hour

pull request commentjina-ai/jina

refactor(types): move add_chunk add_match to Set

Right now, there are two functions for adding a chunk/match to the document. I'd suggest removing add().

There should be one-- and preferably only one --obvious way to do it. The Zen of Python

with Document() as d:
    c1 = d.chunks.append()
    c1.id = f'1:0>16'
    c2 = d.chunks.add()
    c2.id = f'2:0>16'
hanxiao

comment created time in 2 hours

pull request commentjina-ai/jina

test: refactor index remote

Codecov Report

Merging #1346 (56a0550) into master (f8db230) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1346      +/-   ##
==========================================
+ Coverage   83.27%   83.28%   +0.01%     
==========================================
  Files         103      103              
  Lines        6744     6744              
==========================================
+ Hits         5616     5617       +1     
+ Misses       1128     1127       -1     
Impacted Files Coverage Δ
jina/peapods/gateway.py 94.32% <0.00%> (-0.71%) :arrow_down:
jina/peapods/pea.py 92.44% <0.00%> (+0.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8db230...390f062. Read the comment docs.

bwanglzu

comment created time in 6 hours

push eventjina-ai/jina

Jina Dev Bot

commit sha d1f152ac4880262b2984a0b4fcd5d6d8135d4d47

chore(contributor): update contributors

view details

Jina Dev Bot

commit sha 28016639e8df95b49ea2ef4047f8c1c13e929509

chore(docs): update TOC

view details

push time in 6 hours

issue openedjina-ai/jina

get remote pod documentation updated

--allow-spawn has been removed in #1276 , while it still exists in the documentation, run-remote-pod-jina.md image

created time in 6 hours

push eventjina-ai/jina

bwanglzu

commit sha 390f0626667031fc54cd2f9e914e56bf619c8ef9

test: remove allow spawn from remote test

view details

push time in 6 hours

PR opened jina-ai/jina

test: refactor index remote
  1. Removed index remote 2 from tests, since it testing the delete args --allow-spawn.
  2. Refactor index remote test.
  3. Remove JinaTestCase from __init__, we're not using unittest anymore.
+46 -240

0 comment

3 changed files

pr created time in 7 hours

create barnchjina-ai/jina

branch : test-refactor-index-remote

created branch time in 7 hours

pull request commentjina-ai/jina

Test adding convert driver tests

@bio-howard you can continue with the PR now, please replace jina_pb2. DocumentProto with Document, import from jina.type

bio-howard

comment created time in 7 hours

pull request commentjina-ai/jina

Update README.kr.md

hi @rabbits99 would you like to continue with this PR? it has been 2 weeks. Please check commit guidelines #553 to update your commit message, and sign the CLA.

rabbits99

comment created time in 8 hours

Pull request review commentjina-ai/jina

fix: handle empty shards

 def arg_wrapper(*args, **kwargs):             if b_size is None:                 return func(*args, **kwargs) +            # catch empty shards+            if data is None:

I think I was wrong it may be actually a bug at batching level. I am howevrr not sure we can assume it returns an np.ndarray. batching decorator has too many things, if you find a pattern to abstract in another function it can also be good

cristianmtr

comment created time in 8 hours

push eventjina-ai/jina

cristian

commit sha f8db230173d50dc256158295883d79afc9082e3d

fix: fix module name in tag workflow (#1345)

view details

push time in 13 hours

delete branch jina-ai/jina

delete branch : fix-tag-workflow

delete time in 13 hours

PR merged jina-ai/jina

fix: fix module name in tag workflow area/cicd area/housekeeping size/XS
+1 -1

0 comment

1 changed file

cristianmtr

pr closed time in 13 hours

PR opened jina-ai/jina

Reviewers
fix: fix module name in tag workflow
+1 -1

0 comment

1 changed file

pr created time in 13 hours

create barnchjina-ai/jina

branch : fix-tag-workflow

created branch time in 13 hours

created tagjina-ai/jina

tagv0.8.1

An easier way to build neural search in the cloud

created time in 13 hours

push eventjina-ai/jina

Jina Dev Bot

commit sha 5a653ccc88706f1dd50f10573219c30eed49ddc8

chore(version): the next version will be 0.8.2

view details

push time in 13 hours

push eventjina-ai/jina

Han Xiao

commit sha 7264977df1e296987065faf58c498e59a46b7dd1

build: hotfix release 0.8.1

view details

push time in 13 hours

push eventjina-ai/jina

Han Xiao

commit sha f3a7c15bd5add354e771883c07b20cb7bf144df0

refactor(types): move add_chunk add_match to Set (#1343) * refactor(types): refactor constructor for ql, doc, req

view details

push time in 13 hours

delete branch jina-ai/jina

delete branch : refactor-doc-set

delete time in 13 hours

PR merged jina-ai/jina

Reviewers
refactor(types): move add_chunk add_match to Set area/core area/helper area/testing component/driver component/type size/M
+255 -210

1 comment

22 changed files

hanxiao

pr closed time in 13 hours

pull request commentjina-ai/jina

refactor(types): move add_chunk add_match to Set

Codecov Report

Merging #1343 (84d57cc) into master (79064e6) will increase coverage by 0.14%. The diff coverage is 91.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1343      +/-   ##
==========================================
+ Coverage   83.25%   83.39%   +0.14%     
==========================================
  Files         101      103       +2     
  Lines        6717     6812      +95     
==========================================
+ Hits         5592     5681      +89     
- Misses       1125     1131       +6     
Impacted Files Coverage Δ
jina/types/request/__init__.py 91.89% <72.00%> (-4.15%) :arrow_down:
jina/types/document/uid.py 84.74% <78.94%> (-2.76%) :arrow_down:
jina/drivers/craft.py 100.00% <100.00%> (ø)
jina/drivers/evaluate.py 98.21% <100.00%> (+0.03%) :arrow_up:
jina/drivers/index.py 95.00% <100.00%> (ø)
jina/drivers/rank.py 97.22% <100.00%> (+0.34%) :arrow_up:
jina/drivers/search.py 94.73% <100.00%> (+0.09%) :arrow_up:
jina/excepts.py 100.00% <100.00%> (ø)
jina/types/document/__init__.py 96.87% <100.00%> (+0.29%) :arrow_up:
jina/types/querylang/__init__.py 90.47% <100.00%> (+1.08%) :arrow_up:
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c596897...84d57cc. Read the comment docs.

hanxiao

comment created time in 13 hours

push eventjina-ai/jina

Han Xiao

commit sha 84d57cc6cfe62db778deff07b592d14d58bf5682

refactor(proto): jina primitive types

view details

push time in 14 hours

push eventjina-ai/jina

cristian

commit sha dfacc51b19994f5aff7cc22fdfa2c7eab41ee57b

ci: auto approve/merge chore tasks for hub (#1298)

view details

Joan Fontanals

commit sha 0dfa66bca0db7c1cd248bac680d5aeedbc418f47

fix: send terminate to every Pea (#1331) * fix: send terminate to every Pea * fix: terminate for remotepod Co-authored-by: Deepankar Mahapatro <deepankar.mahapatro@jina.ai>

view details

Nan Wang

commit sha 3b70f6982356e7c32d76a9cb6db60dd3f1cdcb0b

refactor: refactor the test for evaluation (#1339)

view details

Deepankar Mahapatro

commit sha 8d97afa3c24953277a22ef20dd908515f7bd982d

refactor: moving log parse to core from jinad (#1342)

view details

Joan Fontanals

commit sha 79064e60b6a18d3c0469af6e134bd0fb9393f800

test: add integ test about non blocking gateway (#1338)

view details

Han Xiao

commit sha c59689749e6b1e4a04908d94a47ae97eace3139f

chore: fix toc generator behavior

view details

Han Xiao

commit sha a1b274a7ed1588aed1d36cdae2cac4e3d9aff7d2

Merge branch 'master' into refactor-doc-set

view details

Han Xiao

commit sha d88d771ead052946ca59267c45830c6a16d8dba9

refactor(proto): jina primitive types

view details

push time in 14 hours

push eventjina-ai/jina

Han Xiao

commit sha ed311b01ff9cdf7c94481cc73a56902a5f1acb53

refactor(proto): jina primitive types

view details

push time in 14 hours

Pull request review commentjina-ai/jina

fix: handle empty shards

 def arg_wrapper(*args, **kwargs):             if b_size is None:                 return func(*args, **kwargs) +            # catch empty shards+            if data is None:

but it is not necessaritly an np.array, it may also a simple array I think

cristianmtr

comment created time in 14 hours

Pull request review commentjina-ai/jina

fix: handle empty shards

 cur_dir = os.path.dirname(os.path.abspath(__file__))  +# TODO add test empty index with search

the tests would belong somewhere else I think?

cristianmtr

comment created time in 14 hours

Pull request review commentjina-ai/jina

fix: handle empty shards

 def arg_wrapper(*args, **kwargs):             if b_size is None:                 return func(*args, **kwargs) +            # catch empty shards+            if data is None:

yes, maybe some change also needs to be there for batch_iterator but it will also affect the indexer executor.

cristianmtr

comment created time in 14 hours

more